From patchwork Wed Aug 3 17:45:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12935817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A356DC19F28 for ; Wed, 3 Aug 2022 17:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238326AbiHCRpS (ORCPT ); Wed, 3 Aug 2022 13:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235820AbiHCRpS (ORCPT ); Wed, 3 Aug 2022 13:45:18 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D3082DF0; Wed, 3 Aug 2022 10:45:17 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id k25-20020a056830169900b0061c6f68f451so12648979otr.9; Wed, 03 Aug 2022 10:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=FmXpKV8L1ROy4Dh0Qt2TT7rzbx5rKU4HTkrXEsPEgGo=; b=SCtGjXpQVoKIpxtAyZk++KjKMr9rCo21niMsPRrUvenRuBlxTbSseU28pFkuHqh8FX Xykwfzh4Sml8eslvIY9bmg25WlopXFA2UureEZHzYiAx3CHe/nq3nmw56XmCv2FYBy0t hAMhUPqAVtLa41OyZbUEp69LDm5sOkd7VcSVreYxDqsGXu8q1uP1l6T4XuLLxvZdbVSZ YP1zagr+RoGupJ5gk4zHhLm50BUuHeSFWzDVIpus2Ga7JmyI+K0CLWwjLI0ucF3jBQSH m9p14GGB2b2Mbye44d1fl4sfXcHjMOQ7y4hH8tcNYy3HTrfi5tqI6LhesMkkT0UE9GUK NqOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=FmXpKV8L1ROy4Dh0Qt2TT7rzbx5rKU4HTkrXEsPEgGo=; b=i4l+tpEnphpLr7xGoYhNCS0FOA4ttfLhSq7luaisPkWQ1ieNBtGgHcNkCo92kTslPU 01dhQaHqSpqqn4vEgrGTzvPsrUmWze/Cq1art9bRkOR3lpjUjV1rv7h7vRZGPOXP8fwJ h/hOu/mwAnMHL48hT5tB/ApNx9Md6BORShIAVZb28M1linH8xqZW59LNfjcGtpHofO0P TdrC6aOayszYX2PfgkKF71W7G+r44NLNfu5WpwgTzZB5PfG3sAS7Mh5EfFBQKrDW6+yF ppt/Nq3RTfNeWcxhEOIRCY/XmRFedhLlPICRfItAvle7XO/SqaynBKinCxILP+eCZOha +EoQ== X-Gm-Message-State: ACgBeo3zrB/uQZ587QpK0xxh2pESrFPKt84Hk7yMOmQGy5m9MCRc8mE5 F+jIGPf5ak2Am6j63R2M+wJtCkFeFcU= X-Google-Smtp-Source: AA6agR6jI3Xbzz+VFMZY+Y5gnDosB44jxMB1eE17H8nXvRUzy6UDOYkbcwJA8mu+Ep9HwrwT0qlC9A== X-Received: by 2002:a05:6830:18f0:b0:628:b0f5:a003 with SMTP id d16-20020a05683018f000b00628b0f5a003mr6101530otf.107.1659548716528; Wed, 03 Aug 2022 10:45:16 -0700 (PDT) Received: from wintermute.localdomain (cpe-76-183-134-35.tx.res.rr.com. [76.183.134.35]) by smtp.gmail.com with ESMTPSA id bx6-20020a0568081b0600b0033a6bfdc5adsm3551893oib.36.2022.08.03.10.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 10:45:15 -0700 (PDT) From: Chris Morgan To: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org, dmitry.torokhov@gmail.com, contact@artur-rojek.eu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, jic23@kernel.org, paul@crapouillou.net, Chris Morgan , Maya Matuszczyk , Rob Herring Subject: [PATCH v10 1/3] dt-bindings: adc-joystick: add poll-interval Date: Wed, 3 Aug 2022 12:45:03 -0500 Message-Id: <20220803174505.21420-2-macroalpha82@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220803174505.21420-1-macroalpha82@gmail.com> References: <20220803174505.21420-1-macroalpha82@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Add poll-interval support for the adc-joystick documentation. This is an optional value and if not provided the adc-joystick works as it does today (with buffers). If this value is provided, the adc-joystick driver is polled at the specified interval. The existing attribute of "poll-interval" was used instead of complying with property-units.yaml after discussion of the issue on the mailing list. Signed-off-by: Maya Matuszczyk Signed-off-by: Chris Morgan Reviewed-by: Rob Herring Acked-by: Artur Rojek --- Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml index 2ee04e03bc22..ab5caad055ea 100644 --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml @@ -14,6 +14,9 @@ description: > Bindings for joystick devices connected to ADC controllers supporting the Industrial I/O subsystem. +allOf: + - $ref: input.yaml# + properties: compatible: const: adc-joystick @@ -28,6 +31,8 @@ properties: https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml for details. + poll-interval: true + '#address-cells': const: 1 From patchwork Wed Aug 3 17:45:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12935819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C7E0C19F28 for ; Wed, 3 Aug 2022 17:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238455AbiHCRpV (ORCPT ); Wed, 3 Aug 2022 13:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238442AbiHCRpT (ORCPT ); Wed, 3 Aug 2022 13:45:19 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C155E60E5; Wed, 3 Aug 2022 10:45:18 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id p132so20648000oif.9; Wed, 03 Aug 2022 10:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=cK8P+NQx1HxjzaitSSfn9Crns+5z0PdzCX3QJxjESvY=; b=VbpxpWZe71OV9ZsGhSOHFw3j4jFe5aWqBvzt+3AcwyrqU+kzhSj7GW2djSKXXXniqx +6ZZ/pbZV2wlXVPm0jVnN8RFJz4qfUrhkwRk/U4Sdyj3hCl/SzB9qqgffMdnTRiI2olz YlIGqnNB2IEjwp0//2r1F5Tp/kUmnwmf8MXmKn/zi9wWg4XsNpxtVA7Ro1XejttMv8ng tbCcxgRarasoYspDxFm30+J32VQb83iy/EdOyJFpDSptRQw40XhA+xLBSyNqYy1o3cf/ y78iaKUeVRTkItF5KSNxm8pjL6AAyEu/al3xuZHwesa7xa7egjDTylwYSMmlBLtxOTn2 RN2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=cK8P+NQx1HxjzaitSSfn9Crns+5z0PdzCX3QJxjESvY=; b=HX4QZPga7HQ8KBGYagIL93v0c+C6Any53Hc9y4xicU8DUWXX8D2jED2dX6dHT4+YGX aP00ygwt9xNSORN4JeDHAWRzbS71RwyW2NGtDso7sIgA/J9ZbKnC/qbqQl/eQxLfZShx 97wqaTQrW28/3PeJHqQZZuLN9IGpfTslbP34ss6/rWXqWBtKqM5gMiutR94aAj2uaR++ 0LwXThVcK2hklCuRmV188A4UYAIhShfQaQD9qXem1lQ3lylvKq7JHcvHbqASg/PYnwxS /KLnpvltYMBtIEgvOq5ftCj2zfOn+JKlAPZ8HKWNdZoZgF04LoaK6SSoItrhFQakTNBK H0iA== X-Gm-Message-State: ACgBeo2ku13O16g+pnuwMxqiEeaPYx61Hgcf3ScMVVod8Cv4qfGIrF5x EmcrdjlFqS7eoHNW4xyUtxdSc6ez0FQ= X-Google-Smtp-Source: AA6agR4dbysuDm+Z/+s7SwMXTMQ2GZT7Jae2of/lZ1+UGoVKE44v2SX/0Gpi+nQczkhCjDoFrb2LgA== X-Received: by 2002:a05:6808:f90:b0:33a:c3ed:cae8 with SMTP id o16-20020a0568080f9000b0033ac3edcae8mr2098280oiw.218.1659548717842; Wed, 03 Aug 2022 10:45:17 -0700 (PDT) Received: from wintermute.localdomain (cpe-76-183-134-35.tx.res.rr.com. [76.183.134.35]) by smtp.gmail.com with ESMTPSA id bx6-20020a0568081b0600b0033a6bfdc5adsm3551893oib.36.2022.08.03.10.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 10:45:17 -0700 (PDT) From: Chris Morgan To: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org, dmitry.torokhov@gmail.com, contact@artur-rojek.eu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, jic23@kernel.org, paul@crapouillou.net, Chris Morgan , Maya Matuszczyk Subject: [PATCH v10 2/3] Input: adc-joystick - Add polled input device support Date: Wed, 3 Aug 2022 12:45:04 -0500 Message-Id: <20220803174505.21420-3-macroalpha82@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220803174505.21420-1-macroalpha82@gmail.com> References: <20220803174505.21420-1-macroalpha82@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Add polled input device support to the adc-joystick driver. This is useful for devices which do not have hardware capable triggers on their SARADC. Code modified from adc-joystick.c changes made by Maya Matuszczyk. Signed-off-by: Maya Matuszczyk Signed-off-by: Chris Morgan --- drivers/input/joystick/adc-joystick.c | 53 ++++++++++++++++++++++++--- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c index 78ebca7d400a..a288ebfe254e 100644 --- a/drivers/input/joystick/adc-joystick.c +++ b/drivers/input/joystick/adc-joystick.c @@ -26,8 +26,23 @@ struct adc_joystick { struct adc_joystick_axis *axes; struct iio_channel *chans; int num_chans; + bool polled; }; +static void adc_joystick_poll(struct input_dev *input) +{ + struct adc_joystick *joy = input_get_drvdata(input); + int i, val, ret; + + for (i = 0; i < joy->num_chans; i++) { + ret = iio_read_channel_raw(&joy->chans[i], &val); + if (ret < 0) + return; + input_report_abs(input, joy->axes[i].code, val); + } + input_sync(input); +} + static int adc_joystick_handle(const void *data, void *private) { struct adc_joystick *joy = private; @@ -179,6 +194,7 @@ static int adc_joystick_probe(struct platform_device *pdev) int error; int bits; int i; + unsigned int poll_interval; joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL); if (!joy) @@ -192,11 +208,25 @@ static int adc_joystick_probe(struct platform_device *pdev) return error; } - /* Count how many channels we got. NULL terminated. */ + if (device_property_present(dev, "poll-interval")) { + error = device_property_read_u32(dev, "poll-interval", + &poll_interval); + if (error) + return error; + joy->polled = true; + } + + /* + * Count how many channels we got. NULL terminated. + * Do not check the storage size if using polling. + */ for (i = 0; joy->chans[i].indio_dev; i++) { + if (joy->polled) + continue; bits = joy->chans[i].channel->scan_type.storagebits; if (!bits || bits > 16) { - dev_err(dev, "Unsupported channel storage size\n"); + dev_err(dev, + "Unsupported channel storage size\n"); return -EINVAL; } if (bits != joy->chans[0].channel->scan_type.storagebits) { @@ -215,8 +245,14 @@ static int adc_joystick_probe(struct platform_device *pdev) joy->input = input; input->name = pdev->name; input->id.bustype = BUS_HOST; - input->open = adc_joystick_open; - input->close = adc_joystick_close; + + if (joy->polled) { + input_setup_polling(input, adc_joystick_poll); + input_set_poll_interval(input, poll_interval); + } else { + input->open = adc_joystick_open; + input->close = adc_joystick_close; + } error = adc_joystick_set_axes(dev, joy); if (error) @@ -229,13 +265,18 @@ static int adc_joystick_probe(struct platform_device *pdev) return error; } - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy); + if (joy->polled) + return 0; + + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, + joy); if (IS_ERR(joy->buffer)) { dev_err(dev, "Unable to allocate callback buffer\n"); return PTR_ERR(joy->buffer); } - error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer); + error = devm_add_action_or_reset(dev, adc_joystick_cleanup, + joy->buffer); if (error) { dev_err(dev, "Unable to add action\n"); return error; From patchwork Wed Aug 3 17:45:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Morgan X-Patchwork-Id: 12935820 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 450F3C25B07 for ; Wed, 3 Aug 2022 17:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236470AbiHCRpV (ORCPT ); Wed, 3 Aug 2022 13:45:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238444AbiHCRpU (ORCPT ); Wed, 3 Aug 2022 13:45:20 -0400 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31FF6318; Wed, 3 Aug 2022 10:45:19 -0700 (PDT) Received: by mail-oo1-xc2a.google.com with SMTP id r16-20020a4abf10000000b0044100d984ddso247085oop.12; Wed, 03 Aug 2022 10:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=yrhBL50UTTJaHzMh461WNNj8NIR2DIRZ1vY8GGWYUG8=; b=nOzo/z0DXRuzNrvvDkrdSTnZXSaXa94couCp2tepWOB9I2HhxtxMV6pqtdsX6lry7k V6qNXWFevzNprHO/Hm0KSSF01coR33VKLWhmxAVv8AFji+1dyWf8RYWV87deEOBbE0DW DPAU/4kw8mLJEIIpnJIzULXatmSYeeIeexoNBGIPxpcwTpzyFlh1Bf2X74+/FWUJSS9i 2MHAQsUsxT/pFNTwQPWJhpJRjZgfbJbS5AlHfp3hkFIxnu803MrpskbVh+tlkYwMhErq u6xs41ijM7h0RQ7q7WzP0+yfIK7rmpddZqktPqYD0eGDJYgVlTdca3qiKZ9dUp5fTlGL ks0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=yrhBL50UTTJaHzMh461WNNj8NIR2DIRZ1vY8GGWYUG8=; b=NAbhhalVuIiWz5NdlvfxdZdKSzwnhPUKBNj3ib4BHEF+hwOsefuo4Eoc9xG9t2e1Sq RR9W7WEva3XLjaScNmql1b0m0yjUN0obm6M2/FCzyfiRXsbLQbVd8sdFLLXNWzeulQCH kGVRU4RelKb0EnKObNpkhj36AO7SesdSvkwIRvO9EW5YeChQ2/AdDjNesHSRHP4raTwN WcSIZ85VPsnib/Vgt9iJjcL4h2TEnNcwETou1c4BCOPniRpAFthI0kMrkoP7gzmSyUG9 IYtLntXyZb8+u6gv777aA8ymjpvCAZKHuvfVKgoUaGb0TORyGsOKNxTSCiZQT48KaH+p csKg== X-Gm-Message-State: AJIora8ZdzLY/ve+wCFMm2cDvbJSUQhu4rSFvmSqDwa/y5ii0V4sXZmC TTs6gB3FvKIKl/WEBRxDUyzuzQXtK1M= X-Google-Smtp-Source: AGRyM1uxZTzGZSjXseoVZADNgo8eDvvshYrIsUDh7iHnk+88MNDGO7icvdnCLMVxuEShgkFbYjnDZw== X-Received: by 2002:a4a:dccc:0:b0:435:9890:a10 with SMTP id h12-20020a4adccc000000b0043598900a10mr8670943oou.63.1659548718955; Wed, 03 Aug 2022 10:45:18 -0700 (PDT) Received: from wintermute.localdomain (cpe-76-183-134-35.tx.res.rr.com. [76.183.134.35]) by smtp.gmail.com with ESMTPSA id bx6-20020a0568081b0600b0033a6bfdc5adsm3551893oib.36.2022.08.03.10.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 10:45:18 -0700 (PDT) From: Chris Morgan To: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org, dmitry.torokhov@gmail.com, contact@artur-rojek.eu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de, jic23@kernel.org, paul@crapouillou.net, Chris Morgan , Maya Matuszczyk Subject: [PATCH v10 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Date: Wed, 3 Aug 2022 12:45:05 -0500 Message-Id: <20220803174505.21420-4-macroalpha82@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220803174505.21420-1-macroalpha82@gmail.com> References: <20220803174505.21420-1-macroalpha82@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Chris Morgan Update the Odroid Go Advance to use "poll-interval" from the adc-joystick driver. Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk --- arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts index 415aa9ff8bd4..3389755dbdc8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts @@ -26,6 +26,7 @@ adc-joystick { compatible = "adc-joystick"; io-channels = <&saradc 1>, <&saradc 2>; + poll-interval = <60>; #address-cells = <1>; #size-cells = <0>;