From patchwork Mon Aug 22 01:38:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12950108 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C218C00140 for ; Mon, 22 Aug 2022 01:38:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7970A940008; Sun, 21 Aug 2022 21:38:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75044940007; Sun, 21 Aug 2022 21:38:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E558940008; Sun, 21 Aug 2022 21:38:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4BE02940007 for ; Sun, 21 Aug 2022 21:38:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A6051C5EE0 for ; Mon, 22 Aug 2022 01:38:37 +0000 (UTC) X-FDA: 79825519074.15.02BCA7B Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf08.hostedemail.com (Postfix) with ESMTP id C7AFB160070 for ; Mon, 22 Aug 2022 01:38:36 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id x63-20020a17090a6c4500b001fabbf8debfso9802190pjj.4 for ; Sun, 21 Aug 2022 18:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=K7UprDRIIcI1lBn04E49aPjKkq0MqHdFyTOxCUBbGvE=; b=d29onEhm91OYy3o9+ePmWmv2+7JpIwwMCfKpunKYrezd3VDEmO2PKd2iIsJ8kLayXM xn8iUjKiVhMsDpkihjF2EbJAWg1kndYVuSEFKYfBrdP3WwJq2tItKLTparATI5vk9Alr u14AsNsRqGOhw7/FApUFeYE/TR8r2FE6Lw1murnq11bLYFaO2jHK579hdUWzGfcWbmMI tgGwDEPVuZcfcKiKFthT3RFWqtcOqtapBMaND3R/+u154qIsdq2bbcUvtGP5cBJq11Tt ONdX6ZyiUXl4Hv7YhfN8zkmQkVy2VuidaLSBhir9eU4+smyw297/9YAh2J0LTHGRz7JV yx/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=K7UprDRIIcI1lBn04E49aPjKkq0MqHdFyTOxCUBbGvE=; b=wtrT+xXH9UPn0UsGxxIOql4CV9XjpVUj+mjmrg1o/c7pfVPy59h/urvDs9SPWlbTtH 9HJtT2GWH3xcoeZdyn+9QMubTtX/q0GlBDVrNwnk97+KnZGRjsOrtxSE5VmJndeBltRx arK78BuIdiMuykqq/Jehq4athy0MDod/SW2metgfZ+FI9QMl3oA1m3CWIzfUvXMg/M0T pTl+X6sXXOMIq/jJf75um/1+LykhP6owOwY8Nm54pV+VJ4NwVvsT5eQ6JjlukhNbHCnD I4+eCVaMGEz0KAw1BX+tFSLQmrp+j5+QoDHPNnHqhICOi2/Y8rPuZFvXAB58q0lNJxnK eUbg== X-Gm-Message-State: ACgBeo1Wio+IQpIKLiO3sWy0eSVNzycpsFhwiqGTYNYs+FPT7XdRK0QS nk2T7t5CiOx2AEp4LUsudeU= X-Google-Smtp-Source: AA6agR7sT+0zMr7sSM9aLeDqrNyvdPYvi9pKXGNznYOUScC/7aadUH1MYNjptASgAyPCLb+UfCG1eA== X-Received: by 2002:a17:902:e3d5:b0:172:a78f:dbc with SMTP id r21-20020a170902e3d500b00172a78f0dbcmr17828611ple.144.1661132315747; Sun, 21 Aug 2022 18:38:35 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id d5-20020a623605000000b0052b94e757ecsm7258352pfa.213.2022.08.21.18.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 18:38:35 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: 42.hyeyoo@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: [PATCH linux-next v2] mm/slub: Remove the unneeded result variable Date: Mon, 22 Aug 2022 01:38:30 +0000 Message-Id: <20220822013830.199836-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661132316; a=rsa-sha256; cv=none; b=8RQR5949nxjXLf+w4dsV1YA5FFlqyDmsMwipS/8LgShsqNLDm0yNWI70QfdY3n5iOhaV4P g1AQTon+bPHmKMDAQ9gp7xB6DuVuH+jvpl20q3l/uP74UddgXwIFxq0nVsHS7vkaQZl5H+ OfhIivoZVZ1D6m14Fnj7jBSgtwO0KQk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=d29onEhm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661132316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=K7UprDRIIcI1lBn04E49aPjKkq0MqHdFyTOxCUBbGvE=; b=ucHZ/SOf4KEqOi22jL3QYO0Z6+uOVFe/GPjUZnPLfSquTMJM7wPn2xFGtaNfUfSPT+51GJ wNXmS+C535kdsfr0PyA/QvavyTJTyTWKtGqoW7BeaBT5F9XdsAIx1jARYJjAu2wvMgk8Ge I7LCZVpFuxGMxzuwlqKm9QBQ4OcYbgo= X-Stat-Signature: i88ctzxh4ksmeqjucup6hgycyeohr8a9 X-Rspamd-Queue-Id: C7AFB160070 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=d29onEhm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1661132316-631739 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: ye xingchen Return the value from attribute->store(s, buf, len) and attribute->show(s, buf) directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Signed-off-by: ye xingchen --- v1 -> v2 Add the whitespace between subsystem and summary in subject line. mm/slub.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 6953c3367bc2..7bea010a20ff 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5852,7 +5852,6 @@ static ssize_t slab_attr_show(struct kobject *kobj, { struct slab_attribute *attribute; struct kmem_cache *s; - int err; attribute = to_slab_attr(attr); s = to_slab(kobj); @@ -5860,9 +5859,7 @@ static ssize_t slab_attr_show(struct kobject *kobj, if (!attribute->show) return -EIO; - err = attribute->show(s, buf); - - return err; + return attribute->show(s, buf); } static ssize_t slab_attr_store(struct kobject *kobj, @@ -5871,7 +5868,6 @@ static ssize_t slab_attr_store(struct kobject *kobj, { struct slab_attribute *attribute; struct kmem_cache *s; - int err; attribute = to_slab_attr(attr); s = to_slab(kobj); @@ -5879,8 +5875,7 @@ static ssize_t slab_attr_store(struct kobject *kobj, if (!attribute->store) return -EIO; - err = attribute->store(s, buf, len); - return err; + return attribute->store(s, buf, len); } static void kmem_cache_release(struct kobject *k)