From patchwork Mon Aug 22 15:51:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 12950881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDAF8C32774 for ; Mon, 22 Aug 2022 15:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YBOfdq82Qq4mS1G3VKoPNjXA+lpyFDtGYW3MX358oME=; b=QGBuHgP6tCd+BR EDqB0Z+Z5C0nVT5eCvaunDFYyJ0sUBr7iaXXI58S5WQPto79So91Z6BLBmu/LwYdJoQfkjjCe9BTb 25u3bTolT4BrkQ5Mzc3Ifff9FUaJWeqvNfKfMPW04EgBtnBuyviFkZgKnJ9IF21cqoLp8lH7SAVsM YMTORZkXFKyvrfZiLqG+d4mS3q9SFQGHgtdYMua8ehEtlvRwMCwhBvtZtZWimPlvXvVcxsSAM+Frl TSij0ZHTViMkus0THOKv/h8VLdbatv5zpa1dJfKIel+d94YXWu4WyaUQ1YfgLTGlRu283AZt8PqED HhIsp9n8VfUvjDoKw+jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9j0-00CQb6-Fh; Mon, 22 Aug 2022 15:52:26 +0000 Received: from mail-am6eur05on2075.outbound.protection.outlook.com ([40.107.22.75] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9ic-00CQMm-1K for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 15:52:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUs7QL8ZpZxpmGar+Owu6dQtXLU32waQ9iSqEznzP4Hks7vy6ab2hBMb15d2cgHFX9RKgqu0MgfKmEIJKRVYGDckcK4BDA6Gnqk304KqZCNMizBDTagkTlSjdloNEO4Z8lT4C68fmc0Ew3HqjmDw+NsxaCrhqI9j5TpfEFaoFEAky/uYIByqxFctCK9ULZuXG+FAni1aojMZFQIL3PAUeXVXzPBiJ+vDRImwe6MaY/COy5fiO0Xcs0EpMcpIJCUw8SKmxx8Rd4znWcOzxAA3PFMGS3TSpPjxtd+EDoHZfoBjMy+8HmkuXM2KDhoXZV1CO2j651L5yyRWsthdAJ2XqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxyZmoQ4HPxt9JAZN3QVzBllZWpIazPpqniEWrzTllw=; b=Dikqcumkd7XqHEv4EE75dV8DcCGDYPCOl+DFZRjJljsDs+xwwWTLasV/u5aFqdJofO1PP956v3DkTv+cv/4ZtsttloivsY7U5/D07F7EJg4X2WopqgJH3hIRdp49tjQI3M9hu/0v6JXAljrLr+qJYpQGyzZDuyhv5ZTK1F+FBZO2F+GUkLwhuUtFvFdznPFuFrKSM56DwVfNeBqjheN6XupHHoU0ryKBLCQd5I5EAeRCWshR4fb0MxHAU5mLPuosjOQuaTqUwAHcCu/qtU/9Rn0exaBZe8JihJVF8Gny5Ph6Z68Yhdo8+CLGCIz8xcbvozDPNEh07/mO+c9YZOrXWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxyZmoQ4HPxt9JAZN3QVzBllZWpIazPpqniEWrzTllw=; b=SJQxXqvLjX+XSHQ5UkT7cEyYAfgweYGFc4WGX6OYDzXgNHa1IiYpOVsnQBCrxkO6bjc4Y+/GG4wu7OHJVwlvSMGfYLjsrUsaAJ5rKNpplpVH5iEy4jBYgVGX71N12lY1dmUFRc63QeDz/vzcJW62fz+d1k7IXjYZC5mZRjkO4+g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) by AM5PR04MB3169.eurprd04.prod.outlook.com (2603:10a6:206:4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Mon, 22 Aug 2022 15:51:56 +0000 Received: from PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba]) by PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba%4]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 15:51:56 +0000 From: Frank Li To: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com Subject: [PATCH v7 1/4] irqchip: allow pass down .pm field at IRQCHIP_PLATFORM_DRIVER_END Date: Mon, 22 Aug 2022 10:51:27 -0500 Message-Id: <20220822155130.2491006-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220822155130.2491006-1-Frank.Li@nxp.com> References: <20220822155130.2491006-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR13CA0038.namprd13.prod.outlook.com (2603:10b6:a03:2c2::13) To PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a87240d-ab7f-47d7-ff0e-08da84563d3b X-MS-TrafficTypeDiagnostic: AM5PR04MB3169:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aPPIsPsOOERtJWwdaXcDZRmynoSCL/xVRq/C1pS0vzBwYtsIbhlN47GzttE/DkPX/PAhh9z+tDX4c37ZJjeb+2J+p43Xgae2Rs8OvrtWIkxFsks1B9g0D+8o2jmd2xkat+M+49x6B0U94WrP+C5mzypsNySMh+1gL7EHtDixTBb2TSiAM4koBaVHsOgUt1gByfAKqrRoPBeD6MqG602qb8gZAJA6VBCBOCvtGs90Ymtbq2GXPVdzZUUTbEa3E6ELpMJFtmBzDbY88JRKFMRlXg2Mum0mgSoTcDBXpiKNGd1tpaXPGYA/n54HcGoqE+z1OV5wa60z7Pp1f1UXPeNCJTmtYHEbe7ocO6Qe7A2COPZbQsEQKIA1x5ljxLKRne7GBGHPrsjYqCAXPLRnCrVeY4mVNIJ0SwD8zwpwRDD97uobGd1iOcoHiUrsr0paO/ZXMO/lfHX4bft8lxMU4s2WsXMYcxzUiJu9GhhJ92TnA2S7TFcmgnFFqyVH50pbDojcoCBOcGphvRCI3jrugN8dUjNqejv0AMqgO3v2ruDB4o0xS4p2q92Cctb1KRK8nqVm43BT+bXc0aFoyWyhP3fhaD4Y/T3gvi6yjkrgeIwUL5dSx1s2cUH5AxhV0RvsUuVe/zMu+TzYiRZVCGCyNIq3viduv1X7R/HttxkQvuJp0CSjDdqqhPOhd7bOauur557+uMm2slybzo3FuPrgHDQFzCSn8I2DCbYmfVfllWabVflxLtWJj7qxcLzelR06Z89Hx3yYSklXReiVTRduO8wwmNNBQgZnBCqvSjHgJzM6JOY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9186.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(316002)(86362001)(38100700002)(38350700002)(36756003)(41300700001)(83380400001)(26005)(6506007)(52116002)(6666004)(6486002)(6512007)(478600001)(2906002)(66946007)(66556008)(66476007)(1076003)(8936002)(5660300002)(8676002)(7416002)(2616005)(4326008)(186003)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9if8T1RyeMSLCo5bZJcey4K7cKuWNjYy9L4gBAGhqeAmlBJWSsq0+3FpdZfkF2SWP9IPr6UuqCsks2Nu+gHFpvW9suAnukfeEPOCY/0/pC+zlaVYUuet182WTKc9A0w9JT+efSeQvLNo/JX6+KSgxTBS3lCHkRHV0ZvjGhZx+ofpBGCaQfNvKCCn9qNl3TyOPaQcoaGUDThDPjlAjBbaE1i2DqMvuehJIIQxhxotKbZZ01BmSq13DDj1F7DuvTejK0HBR90Yq6yiXsaG95nWy7g6TFG6VUER26UKQluNJyrNnFqWqJ77fGYX8ZlJhzEl2Zb1h6IgZYfEu3R+3emTn+Fp5OP369y4+9jEBUnU7JBbvC8NlDLXp7X0njpX25eUWM9GJQceA3X0hWjBFXK1hQ9J7YXjtlisvr8bU5jTmOYKgkkRS1GkmH6KIumBf6BTXo93dMPnc6R2M7wqNr16DIRAS3Dc4XHTLiOBkxOeTLifjLw2MFBwvAyKQ6TNlmS6LT4owdI3LOm1eZdCDJvJk46g7SlxQCDijARl/W7yg9F8eDd8GOh8hu9V0hUOl9y9ci+yVXo1kNLvM3kGUt3Edc9u0TW35enT+baEycOvegat4SE8iasmTQIifpliAV1p4zDWQfQjtPVfAsuoqZGECmDxN1obwP78PzJ9UofNVLUe6i4PMcucvScxAJr3CgQRZZKv71zJ0Jq9ImEM5TgSyTfeMvbJCDkEh6oZDemcg5+0impRInP5tG6sn2ZVyHXiw+eXLfqwZuG98tUujXXzIMzaXICgq5YwV5T/2nPGzfdAzZbI8qcwUPCp9zecqHcX/6X8SdtfvOxr2mPFyriQ6TA5OxVfLBbn0AxXp9TNbnWmAH9b7Jda8scEt6rOGqBZ0OO0TX2l4AYy0xVRv5EZAQwgO7icVe+wxjAvFKGNa+QnkWuPVZaRPbpt2yFukrYpGy/xIStgdzzgLrVPwuiG45WMEJ3l36bPnb4RvHtISHa0z7QXEXPmm6YFyRnVR3apCd+RsllKn8FL5iiOKCyqYiB2b+/SZrJpyUUtZbRSdmxkuAHXV1N5l5DoXrSbkpxni+eJOm87ni9SYPjqKOdFqyO1aFl8WLG3Wd/wkQXmzZcYxBHsr9NGg3e34qa7R/k3ibmTpXu80j4VjjMjkmGfuaynYAMGkXwczL97d+eYEy26WZS2ZnO8Kur1DyWDfBwLAVv1EE4O0/eejR7knDsh3eP6EecXCfWbfeTu1NGCcwpHKn5hFm3VT0CCsDQRoBDEDtFwNcewq28RypdjSaMdrGrxks8XPaWMTgwdTV6yp9s2gvsaZjXXiIsU3yZ/tCfS2ZfLrNtswDJi1FnxJH1/PZiwJuiaduyBlTEPtdZsDiSs+7O6cTHSmPY8UzJX1I+jEifs3nr1XFgcnNCnDqiIaQfM8t7BdHl7u+mvmKfJ7ZBisUDkrq2xNipavt7vw1udvh7bSaFW8WZkLr91hrH2zCnaFvmRfI2tsjZ26igneCAbbw2FXUwESYvD1ydZxmImANA704NBgPbghLIBFlTh5QClGm8vCE3FHNeQKApS8uX/EAyvAQTw+5VpCJalS9h1 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a87240d-ab7f-47d7-ff0e-08da84563d3b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9186.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 15:51:55.9192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OKuN8th08wS+6nxbPdi4KgOgOGBGX8T95ja5vsiQV/n4n/DASs1gr9B+uBDe8XuM3BeX3u4MAC77/VQHLB9xrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3169 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_085202_297436_CB7386C9 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org IRQCHIP_PLATFORM_DRIVER_* compilation define platform_driver for irqchip. But can't set .pm field of platform_driver. Added variadic macros to set .pm field or other field if need. Signed-off-by: Frank Li --- include/linux/irqchip.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h index 3a091d0710ae1..d5e6024cb2a8c 100644 --- a/include/linux/irqchip.h +++ b/include/linux/irqchip.h @@ -44,7 +44,8 @@ static const struct of_device_id drv_name##_irqchip_match_table[] = { #define IRQCHIP_MATCH(compat, fn) { .compatible = compat, \ .data = typecheck_irq_init_cb(fn), }, -#define IRQCHIP_PLATFORM_DRIVER_END(drv_name) \ + +#define IRQCHIP_PLATFORM_DRIVER_END(drv_name, ...) \ {}, \ }; \ MODULE_DEVICE_TABLE(of, drv_name##_irqchip_match_table); \ @@ -56,6 +57,7 @@ static struct platform_driver drv_name##_driver = { \ .owner = THIS_MODULE, \ .of_match_table = drv_name##_irqchip_match_table, \ .suppress_bind_attrs = true, \ + __VA_ARGS__ \ }, \ }; \ builtin_platform_driver(drv_name##_driver) From patchwork Mon Aug 22 15:51:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 12950882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D384FC28D13 for ; Mon, 22 Aug 2022 15:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7I1U+t41AzMFbU8zTnGX4R9uyGLeNRa2tsUGeV794rQ=; b=EzsUOhQojni9j0 Ejo0L6nGhJU+cjeg/Omz0w/jXwsr25ToNAztLoskwEqUy74qIhFmwY/OTMQg/mv5SMsU9Mzbpf/qr t/4JnZXA4gR7MJWFawq112u8MgiuVye131AFO+CVUDcD+gZFOzIc2VTSsm+pfcsjRXGZUyLEZX1XY +zr8YhUFgHsjCwv0KGDrIFWiXwCz7Ep7lJRxMaa/WOk+VUXaluKxwP5UFf/maM0QQzow0Yg0x9x1P Xk/StNY8y0GXkZ7/qGowdEKGlneBwwBg3z/fKK10HGkatyr/Vo5eMzLe8+wr+/Ruesi0uheH7uq/s 0T6MrQRkQHKoaaLoJuug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9jD-00CQgO-Lh; Mon, 22 Aug 2022 15:52:39 +0000 Received: from mail-am6eur05on2068.outbound.protection.outlook.com ([40.107.22.68] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9il-00CQTR-Cs for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 15:52:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qltts+PccpoGwOviBgy59bIl1Va8FPutBNY1d+mhSThA5H0Sv64RWvUvIgjCIYmgZMk6KBwbd3xQvIcMJHNgu4Tcb/QU1C+6ViHYZKduyAgM2BsDaZirrcqIVDtIErMmCSIWnn6LNInm6numsF9ziW6frEKRnw/DpfK+7w9IVud4zr3bPE5hzpaB/sjyBlGm+E3zYVs75a/Y+FiyOZx/ZYM2N+O7p2mqjikoMJeZWNGijp/3fqWBdck8cqW7wKOit+2/XGnL5g1cl1auQC0LJVgUDIi6vVSJLY8OZH+BkXq/ezw+4ZKECUli4S0LoqMygf0E33kGMsdPxZkGmZHVLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FTN6H7ukeDkJqVfwyfo0imFQDw/M5zvxApyhzWREEs=; b=OvCI2Oeq9MPi1D35E1NBsY4LO4A2/uOSpGZ6qxvgf0pLn33Bbc4r12MnIFUna8N/gQm8DlBPS+MaNu5y53v/TKC2b7HaFnl3dKtViKGGDC3C2dZYTuYeShldU7N3AC1gfeAIcGmJpHEw/m3t1J0FJ35uUfJB7wyPATv+0JbNKrnVofNw+rW+A2xtUEOoPXkQlDYL0xiWzKL7aA+yc8mqNoF2zIPLEfHTjCS9BndKo7jOB+St0MFHbasA0uxiIF1v9RK54S3VD7pycAtfOTISa5vg7J84I/d6aLYaMkbBbn9Ux1pONCbWIGDzrw0XZ/1584DgB4xY5wuWkIcj5PXaNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0FTN6H7ukeDkJqVfwyfo0imFQDw/M5zvxApyhzWREEs=; b=eLa9SErOB3Z7qwCX7u5YR3BjX3AXPcjBGxD7FOuf8CkQYNfZVX8mqVVTtOfFzmCCuFgM+oZQzaNvXr7iEv+NeKjqAtdXqjLtxtsFnKhleG2X6wIBBzs09l6Q35fTml/hePHGG0KjkToU6b3Q5PZzVpkOVzzay1P2dm9iL+/txXA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) by AM5PR04MB3169.eurprd04.prod.outlook.com (2603:10a6:206:4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Mon, 22 Aug 2022 15:52:01 +0000 Received: from PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba]) by PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba%4]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 15:52:01 +0000 From: Frank Li To: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com Subject: [PATCH v7 2/4] irqchip: Add IMX MU MSI controller driver Date: Mon, 22 Aug 2022 10:51:28 -0500 Message-Id: <20220822155130.2491006-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220822155130.2491006-1-Frank.Li@nxp.com> References: <20220822155130.2491006-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR13CA0038.namprd13.prod.outlook.com (2603:10b6:a03:2c2::13) To PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 652281de-8a9e-4be9-509d-08da84564075 X-MS-TrafficTypeDiagnostic: AM5PR04MB3169:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Kw5cnsc0yHkVaW3pr/WlL12URMh9FJGPqYeJNvWWCzPcxdgWDthVxJv6eqJ1fRmJEwB6KJd1o/HmB+Lxz74N91MwKByS/Io0tJVAU0DC0GKELaSutx2NAkLmQjBTxh4MDWN4eLdaH4hhJE4tgM34/BW3Dqse1fudeb7MUpayPaoMv9GXcEEi1zzk8QP1X/8wDgnKVETpr2D6Bq7jzlVNn2Mia+RNOu3+39DBD1EPLaMAqA3U0B3F9/BSXX8qnSnvw4aeFCvs3TmaPCXkxW2MgpDhYuoX/PV2kuK6M7Qq4QTohoanY2NMrEblWR33bKnV5yJCXlAjeDzlZqFkL6zXItf4J3J5gFPacwD9mulwQqZMm+0Psy1sR4BbHSm1KOiPzjQuvun4diXNijaycr9fBuDlhs0ZHcY7hIoE9mJdIUuNfbd0xusgSghCCvfWyy8bEXdsLKSRVPfqJ9InBjlMw7khxsz3OpanH4Sxyyv58+7on/UooyGykZNFpJwbFUghDg2l/dXGYSdMuweaDX+QwC2gfp9mAfHsowRqO9hgA4MuIWnatHE4P0EBuB3uB0p1yULM+uHSzMq1B4tSoC0vp7dUf/ee7RHiC7Um/xdskDwQhIcWewe8OYzYrkSNht4ODZH4Q1heTNMo/YS6L0c3QLxgZpHDfFrJicB6LtUEGoCm4Vd/1lxzFkolxANYwBLBGxLYhBMHWiPGbJMPSq7f9X3+l7us2Kg5KDVxJLd+a42M8Ver2GEX4SSJ/X2iBKRqTo2fpibQMVRyKpf6Kswhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9186.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(316002)(86362001)(38100700002)(38350700002)(36756003)(41300700001)(83380400001)(26005)(6506007)(52116002)(6666004)(6486002)(6512007)(478600001)(2906002)(66946007)(66556008)(66476007)(1076003)(8936002)(30864003)(5660300002)(8676002)(7416002)(2616005)(4326008)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /2mAS4MX1m+NnFWooW+Pq2hX8F2kNVqbSIbMe8BCwp/+HZ+IyGC66Gd+/fHfs07TXBQIAhyvnWqJStfGVvtLp0gqeUpat6OI3TFVu0QxXCJNxlhosrXC4qm2oH3QWvQU5+k7ZRjN0tQEWfavIeQJg5+0Ezd5acFY+EmY5sWbQekmdDEQFDo8mEpJO29HxLYjLO4S7ved1ZinkV5TGwpwLs1yWolwyxfTNI763sQBmdSK/tAt33WyoKrx7TN2jByzWPwFa9xDhIW8pIIAxWIHQsDkCzMDEdMWF82OYJK6TD7HgAnRTrxTFSTMzC+d7W5FYge5pPqq5JwTNMRk+XdUM4KFLxZbQ137jHnJuoXlIAm73ykqWvWjw/y+/v1KPXfXZeeRFm7aJiJKASEMCiZbP3EeUt72/poqSxQXrM66QYQCcHLATvCiR3gKmiOlr9IIOqguF0iLCaDYZ2TNuBiFRQo2dLHpvXzvlIgz2lnwKTJLZgJi9RVz9nd5TtbYQ9aKCt39f/BorTV77YcrybzKrjZsEZlLKgbzJuDE9wxpjuTUPRnJXTfzsb0rGhQTdZRiN28m5kgk4vka1R2Vv5B3ua4L0GMiVDRVwCY5UL7ylyIT0SSRASCv/AfEP7xo2EPGedHFv8ZNyv9IeaYm42cWnyK4D/SvQg/50b8VIHIn1WUSs2cZHq3+WQx2Ys02V7qILdjnRVOXtkICej5H71El5m2PayXd3UW1tOMUCWjaDJ1I16uei+Woo4gxZTXONoAwATM/n75AyxYyPYJ2FBlY7xazaeXwdlevdzIAu5IT0w5sehN1wUqE5r19homWkQaRbBLbyTW9oWysj6T60a9GrOyICBxQBQRC0zrH0Xx5OCJFXxL0igI1o6MixPoJgx5YhrIgaed71no1mAtvXTw7ui62C27f2ggS9SeYFnBTyjUQGUmtUkyMNSodMvngzf7NEbI2JGNlRNJMJazh1CvjaCLZEw+MFTEACCFRT40q6EX9xAXOFHCysn3h5xjzs2PLHRSd337nqc5U9H3Ynb1cSqa/KMwpCm9YUaBQDmNUbyUwL4wV0BepTJAt+acY1IV00Oml9hoVWpB18zOoWwllioB6Q9XTSjoJ9bn55Xd0qR0lw2OzYN+Y+PfXg8X65B5rp5AqigmjoKyQt0b/vZOy8MVimWnF3km7kkQSJp1qh+/YmMvYbln0Lupm6oB1nldyY/O1doqNA0NDAK9uaPG/sQ16Da0Zmy38QJxUSuDN2lkLbHxI96Y3aLGrzxMoe6gwcTcrJyenlV8/RFOP3SHv2EmmWfQmreTjcwT/QSNTURPy0u3vh8nsWFAVBNK7+/Sxbf3VgRM58x0+PtwwX8bN8R6Eqd/hPEEg9dx+XuZY9uTSaGjEAg8EIWVqSlR0O1JISrVZFbA5GJnHTTPYnRg187O5dYvhBtaxmcCrDorqt6IpLIay4gb/3T5fBY90yVqhBU+WC7PPD0Ud4oCo8pUWdllf6GV6N6MbtJ8Ecs6hKymeUseShFbpT7pzraRTw23gmgUipdwyO0hu899LEHOWb6o0jUboJo1skd6goLN9jS+4e26wvSccaJa36UspEUi6 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 652281de-8a9e-4be9-509d-08da84564075 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9186.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 15:52:01.2950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: at8ntAKp9LJAzyrux148EdlTLT3iXzDTviZCNhjeM3fnlAZJe0R8CfohSLCNVhZ/+XCpDo0ZSj/65mgJsecQPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3169 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_085211_744047_2B42D960 X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MU block found in a number of Freescale/NXP SoCs supports generating IRQs by writing data to a register This enables the MU block to be used as a MSI controller, by leveraging the platform-MSI API Signed-off-by: Frank Li --- drivers/irqchip/Kconfig | 9 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-imx-mu-msi.c | 451 +++++++++++++++++++++++++++++++ 3 files changed, 461 insertions(+) create mode 100644 drivers/irqchip/irq-imx-mu-msi.c diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 5e4e50122777d..e04c6521dce55 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -470,6 +470,15 @@ config IMX_INTMUX help Support for the i.MX INTMUX interrupt multiplexer. +config IMX_MU_MSI + bool "i.MX MU work as MSI controller" + default y if ARCH_MXC + select IRQ_DOMAIN + select IRQ_DOMAIN_HIERARCHY + select GENERIC_MSI_IRQ_DOMAIN + help + MU work as MSI controller to do general doorbell + config LS1X_IRQ bool "Loongson-1 Interrupt Controller" depends on MACH_LOONGSON32 diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index 5d8e21d3dc6d8..870423746c783 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -98,6 +98,7 @@ obj-$(CONFIG_RISCV_INTC) += irq-riscv-intc.o obj-$(CONFIG_SIFIVE_PLIC) += irq-sifive-plic.o obj-$(CONFIG_IMX_IRQSTEER) += irq-imx-irqsteer.o obj-$(CONFIG_IMX_INTMUX) += irq-imx-intmux.o +obj-$(CONFIG_IMX_MU_MSI) += irq-imx-mu-msi.o obj-$(CONFIG_MADERA_IRQ) += irq-madera.o obj-$(CONFIG_LS1X_IRQ) += irq-ls1x.o obj-$(CONFIG_TI_SCI_INTR_IRQCHIP) += irq-ti-sci-intr.o diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c new file mode 100644 index 0000000000000..110e5df1d6aa8 --- /dev/null +++ b/drivers/irqchip/irq-imx-mu-msi.c @@ -0,0 +1,451 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Freescale MU worked as MSI controller + * + * Copyright (c) 2018 Pengutronix, Oleksij Rempel + * Copyright 2022 NXP + * Frank Li + * Peng Fan + * + * Based on drivers/mailbox/imx-mailbox.c + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + + +#define IMX_MU_CHANS 4 + +enum imx_mu_xcr { + IMX_MU_GIER, + IMX_MU_GCR, + IMX_MU_TCR, + IMX_MU_RCR, + IMX_MU_xCR_MAX, +}; + +enum imx_mu_xsr { + IMX_MU_SR, + IMX_MU_GSR, + IMX_MU_TSR, + IMX_MU_RSR, +}; + +enum imx_mu_type { + IMX_MU_V1 = BIT(0), + IMX_MU_V2 = BIT(1), + IMX_MU_V2_S4 = BIT(15), +}; + +/* Receive Interrupt Enable */ +#define IMX_MU_xCR_RIEn(data, x) ((data->cfg->type) & IMX_MU_V2 ? BIT(x) : BIT(24 + (3 - (x)))) +#define IMX_MU_xSR_RFn(data, x) ((data->cfg->type) & IMX_MU_V2 ? BIT(x) : BIT(24 + (3 - (x)))) + +struct imx_mu_dcfg { + enum imx_mu_type type; + u32 xTR; /* Transmit Register0 */ + u32 xRR; /* Receive Register0 */ + u32 xSR[4]; /* Status Registers */ + u32 xCR[4]; /* Control Registers */ +}; + +struct imx_mu_msi { + spinlock_t lock; + raw_spinlock_t reglock; + struct irq_domain *msi_domain; + void __iomem *regs; + phys_addr_t msiir_addr; + const struct imx_mu_dcfg *cfg; + unsigned long used; + struct clk *clk; +}; + +static void imx_mu_write(struct imx_mu_msi *msi_data, u32 val, u32 offs) +{ + iowrite32(val, msi_data->regs + offs); +} + +static u32 imx_mu_read(struct imx_mu_msi *msi_data, u32 offs) +{ + return ioread32(msi_data->regs + offs); +} + +static u32 imx_mu_xcr_rmw(struct imx_mu_msi *msi_data, enum imx_mu_xcr type, u32 set, u32 clr) +{ + unsigned long flags; + u32 val; + + raw_spin_lock_irqsave(&msi_data->reglock, flags); + val = imx_mu_read(msi_data, msi_data->cfg->xCR[type]); + val &= ~clr; + val |= set; + imx_mu_write(msi_data, val, msi_data->cfg->xCR[type]); + raw_spin_unlock_irqrestore(&msi_data->reglock, flags); + + return val; +} + +static void imx_mu_msi_parent_mask_irq(struct irq_data *data) +{ + struct imx_mu_msi *msi_data = irq_data_get_irq_chip_data(data); + + imx_mu_xcr_rmw(msi_data, IMX_MU_RCR, 0, IMX_MU_xCR_RIEn(msi_data, data->hwirq)); +} + +static void imx_mu_msi_parent_unmask_irq(struct irq_data *data) +{ + struct imx_mu_msi *msi_data = irq_data_get_irq_chip_data(data); + + imx_mu_xcr_rmw(msi_data, IMX_MU_RCR, IMX_MU_xCR_RIEn(msi_data, data->hwirq), 0); +} + +static void imx_mu_msi_parent_ack_irq(struct irq_data *data) +{ + struct imx_mu_msi *msi_data = irq_data_get_irq_chip_data(data); + + imx_mu_read(msi_data, msi_data->cfg->xRR + data->hwirq * 4); +} + +static struct irq_chip imx_mu_msi_irq_chip = { + .name = "MU-MSI", + .irq_ack = irq_chip_ack_parent, +}; + +static struct msi_domain_ops imx_mu_msi_irq_ops = { +}; + +static struct msi_domain_info imx_mu_msi_domain_info = { + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), + .ops = &imx_mu_msi_irq_ops, + .chip = &imx_mu_msi_irq_chip, +}; + +static void imx_mu_msi_parent_compose_msg(struct irq_data *data, + struct msi_msg *msg) +{ + struct imx_mu_msi *msi_data = irq_data_get_irq_chip_data(data); + u64 addr = msi_data->msiir_addr + 4 * data->hwirq; + + msg->address_hi = upper_32_bits(addr); + msg->address_lo = lower_32_bits(addr); + msg->data = data->hwirq; +} + +static int imx_mu_msi_parent_set_affinity(struct irq_data *irq_data, + const struct cpumask *mask, bool force) +{ + return -EINVAL; +} + +static struct irq_chip imx_mu_msi_parent_chip = { + .name = "MU", + .irq_mask = imx_mu_msi_parent_mask_irq, + .irq_unmask = imx_mu_msi_parent_unmask_irq, + .irq_ack = imx_mu_msi_parent_ack_irq, + .irq_compose_msi_msg = imx_mu_msi_parent_compose_msg, + .irq_set_affinity = imx_mu_msi_parent_set_affinity, +}; + +static int imx_mu_msi_domain_irq_alloc(struct irq_domain *domain, + unsigned int virq, + unsigned int nr_irqs, + void *args) +{ + struct imx_mu_msi *msi_data = domain->host_data; + unsigned long flags; + int pos, err = 0; + + WARN_ON(nr_irqs != 1); + + spin_lock_irqsave(&msi_data->lock, flags); + pos = find_first_zero_bit(&msi_data->used, IMX_MU_CHANS); + if (pos < IMX_MU_CHANS) + __set_bit(pos, &msi_data->used); + else + err = -ENOSPC; + spin_unlock_irqrestore(&msi_data->lock, flags); + + if (err) + return err; + + irq_domain_set_info(domain, virq, pos, + &imx_mu_msi_parent_chip, msi_data, + handle_edge_irq, NULL, NULL); + return 0; +} + +static void imx_mu_msi_domain_irq_free(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs) +{ + struct irq_data *d = irq_domain_get_irq_data(domain, virq); + struct imx_mu_msi *msi_data = irq_data_get_irq_chip_data(d); + unsigned long flags; + + spin_lock_irqsave(&msi_data->lock, flags); + __clear_bit(d->hwirq, &msi_data->used); + spin_unlock_irqrestore(&msi_data->lock, flags); +} + +static const struct irq_domain_ops imx_mu_msi_domain_ops = { + .alloc = imx_mu_msi_domain_irq_alloc, + .free = imx_mu_msi_domain_irq_free, +}; + +static void imx_mu_msi_irq_handler(struct irq_desc *desc) +{ + struct imx_mu_msi *msi_data = irq_desc_get_handler_data(desc); + struct irq_chip *chip = irq_desc_get_chip(desc); + u32 status; + int i; + + status = imx_mu_read(msi_data, msi_data->cfg->xSR[IMX_MU_RSR]); + + chained_irq_enter(chip, desc); + for (i = 0; i < IMX_MU_CHANS; i++) { + if (status & IMX_MU_xSR_RFn(msi_data, i)) + generic_handle_domain_irq(msi_data->msi_domain, i); + } + chained_irq_exit(chip, desc); +} + +static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev) +{ + struct fwnode_handle *fwnodes = dev_fwnode(dev); + struct irq_domain *parent; + + /* Initialize MSI domain parent */ + parent = irq_domain_create_linear(fwnodes, + IMX_MU_CHANS, + &imx_mu_msi_domain_ops, + msi_data); + if (!parent) { + dev_err(dev, "failed to create IRQ domain\n"); + return -ENOMEM; + } + + irq_domain_update_bus_token(parent, DOMAIN_BUS_NEXUS); + + msi_data->msi_domain = platform_msi_create_irq_domain( + fwnodes, + &imx_mu_msi_domain_info, + parent); + + if (!msi_data->msi_domain) { + dev_err(dev, "failed to create MSI domain\n"); + irq_domain_remove(parent); + return -ENOMEM; + } + + irq_domain_set_pm_device(msi_data->msi_domain, dev); + + return 0; +} + +/* Register offset of different version MU IP */ +static const struct imx_mu_dcfg imx_mu_cfg_imx6sx = { + .xTR = 0x0, + .xRR = 0x10, + .xSR = {0x20, 0x20, 0x20, 0x20}, + .xCR = {0x24, 0x24, 0x24, 0x24}, +}; + +static const struct imx_mu_dcfg imx_mu_cfg_imx7ulp = { + .xTR = 0x20, + .xRR = 0x40, + .xSR = {0x60, 0x60, 0x60, 0x60}, + .xCR = {0x64, 0x64, 0x64, 0x64}, +}; + +static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { + .type = IMX_MU_V2, + .xTR = 0x200, + .xRR = 0x280, + .xSR = {0xC, 0x118, 0x124, 0x12C}, + .xCR = {0x110, 0x114, 0x120, 0x128}, +}; + +static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp_s4 = { + + .type = IMX_MU_V2 | IMX_MU_V2_S4, + .xTR = 0x200, + .xRR = 0x280, + .xSR = {0xC, 0x118, 0x124, 0x12C}, + .xCR = {0x110, 0x114, 0x120, 0x128}, +}; + +static int __init imx_mu_of_init(struct device_node *dn, + struct device_node *parent, + const struct imx_mu_dcfg *cfg + ) +{ + struct platform_device *pdev = of_find_device_by_node(dn); + struct device_link *pd_link_a; + struct device_link *pd_link_b; + struct imx_mu_msi *msi_data; + struct resource *res; + struct device *pd_a; + struct device *pd_b; + struct device *dev; + int ret; + int irq; + + if (!pdev) + return -ENODEV; + + dev = &pdev->dev; + + msi_data = devm_kzalloc(&pdev->dev, sizeof(*msi_data), GFP_KERNEL); + if (!msi_data) + return -ENOMEM; + + msi_data->cfg = cfg; + + msi_data->regs = devm_platform_ioremap_resource_byname(pdev, "processor a-facing"); + if (IS_ERR(msi_data->regs)) { + dev_err(&pdev->dev, "failed to initialize 'regs'\n"); + return PTR_ERR(msi_data->regs); + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "processor b-facing"); + if (!res) + return -EIO; + + msi_data->msiir_addr = res->start + msi_data->cfg->xTR; + + irq = platform_get_irq(pdev, 0); + if (irq <= 0) + return -ENODEV; + + platform_set_drvdata(pdev, msi_data); + + msi_data->clk = devm_clk_get(dev, NULL); + if (IS_ERR(msi_data->clk)) { + if (PTR_ERR(msi_data->clk) != -ENOENT) + return PTR_ERR(msi_data->clk); + + msi_data->clk = NULL; + } + + pd_a = dev_pm_domain_attach_by_name(dev, "processor a-facing"); + if (IS_ERR(pd_a)) + return PTR_ERR(pd_a); + + pd_b = dev_pm_domain_attach_by_name(dev, "processor b-facing"); + if (IS_ERR(pd_b)) + return PTR_ERR(pd_b); + + pd_link_a = device_link_add(dev, pd_a, + DL_FLAG_STATELESS | + DL_FLAG_PM_RUNTIME | + DL_FLAG_RPM_ACTIVE); + + if (!pd_link_a) { + dev_err(dev, "Failed to add device_link to mu a.\n"); + goto err_pd_a; + } + + pd_link_b = device_link_add(dev, pd_b, + DL_FLAG_STATELESS | + DL_FLAG_PM_RUNTIME | + DL_FLAG_RPM_ACTIVE); + + + if (!pd_link_b) { + dev_err(dev, "Failed to add device_link to mu a.\n"); + goto err_pd_b; + } + + ret = imx_mu_msi_domains_init(msi_data, dev); + if (ret) + goto err_dm_init; + + irq_set_chained_handler_and_data(irq, + imx_mu_msi_irq_handler, + msi_data); + + pm_runtime_enable(dev); + + return 0; + +err_dm_init: + device_link_remove(dev, pd_b); +err_pd_b: + device_link_remove(dev, pd_a); +err_pd_a: + return -EINVAL; +} + +static int __maybe_unused imx_mu_runtime_suspend(struct device *dev) +{ + struct imx_mu_msi *priv = dev_get_drvdata(dev); + + clk_disable_unprepare(priv->clk); + + return 0; +} + +static int __maybe_unused imx_mu_runtime_resume(struct device *dev) +{ + struct imx_mu_msi *priv = dev_get_drvdata(dev); + int ret; + + ret = clk_prepare_enable(priv->clk); + if (ret) + dev_err(dev, "failed to enable clock\n"); + + return ret; +} + +static const struct dev_pm_ops imx_mu_pm_ops = { + SET_RUNTIME_PM_OPS(imx_mu_runtime_suspend, + imx_mu_runtime_resume, NULL) +}; + +static int __init imx_mu_imx7ulp_of_init(struct device_node *dn, + struct device_node *parent) +{ + return imx_mu_of_init(dn, parent, &imx_mu_cfg_imx7ulp); +} + +static int __init imx_mu_imx6sx_of_init(struct device_node *dn, + struct device_node *parent) +{ + return imx_mu_of_init(dn, parent, &imx_mu_cfg_imx6sx); +} + +static int __init imx_mu_imx8ulp_of_init(struct device_node *dn, + struct device_node *parent) +{ + return imx_mu_of_init(dn, parent, &imx_mu_cfg_imx8ulp); +} + +static int __init imx_mu_imx8ulp_s4_of_init(struct device_node *dn, + struct device_node *parent) +{ + return imx_mu_of_init(dn, parent, &imx_mu_cfg_imx8ulp_s4); +} + +IRQCHIP_PLATFORM_DRIVER_BEGIN(imx_mu_msi) +IRQCHIP_MATCH("fsl,imx7ulp-mu-msi", imx_mu_imx7ulp_of_init) +IRQCHIP_MATCH("fsl,imx6sx-mu-msi", imx_mu_imx6sx_of_init) +IRQCHIP_MATCH("fsl,imx8ulp-mu-msi", imx_mu_imx8ulp_of_init) +IRQCHIP_MATCH("fsl,imx8ulp-mu-msi-s4", imx_mu_imx8ulp_s4_of_init) +IRQCHIP_PLATFORM_DRIVER_END(imx_mu_msi, .pm = &imx_mu_pm_ops) + + +MODULE_AUTHOR("Frank Li "); +MODULE_DESCRIPTION("Freescale MU MSI controller driver"); +MODULE_LICENSE("GPL"); From patchwork Mon Aug 22 15:51:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 12950883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A074C28D13 for ; Mon, 22 Aug 2022 15:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWjEcPXbZKDS9LV/ZmXI/sgtVTqWTEZIFzOS1D1VELw=; b=aYSnkHKev3p8Cp fbPtyGmJzuCYnkUZzccWha9F7wQQYNIz3AIoRdUZVztmy//ImHoBuJ6XBkZ4nQTImmfRXYcLT9jxL a8lIGGuYQJ5d/TE8U5ZIDH4g30EvNh2yx1RjGxX/3ExCl0m6kS6kqgVzFfHjwimmaG9KZkcnHP16N IT3/tKBFr8TZAJi4pI1nKGcaGBH1xlT1La80bXhVb+yXnFQQykM4DbPbv0Tgj1ogs7IGUf1gRtE4x qtcDUmwKmyovzRrH1V9vL9BY7BfGgAozlHyFGV3pOsw+WDYNLEfqAMC1BGmp1OsVuNRjpytRUBHu6 YHKSsBryQSr77oZY36vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9jT-00CQkp-Ty; Mon, 22 Aug 2022 15:52:56 +0000 Received: from mail-am6eur05on2068.outbound.protection.outlook.com ([40.107.22.68] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9ip-00CQTR-5y for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 15:52:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmfr4+G85vc0xUPX9eUfhHZxKhYyei9Wlf+tRRdNQtiARpq9fTLKnH1q5nANLYWZxJJaBmTWl8JiBmbc3K3ZmyBvSa497ossLM6C9S1QN3GdkcN4NWhCTl3wYQHVYH3BZ78n9gITArRTzmAdk0yAbKWZQcvv6JxQE23pvJQ7nT9fbcBNNXs5PDLNgxn+nYZ7+MBujP09/rFA6pK+0qiCdDVhlL/6Pg16EVaFWofmcYXuJXzU0qnj6DTlGKlrQtZhbZWnfyj5iQpc9wwYmeCiSSfbIc3pMOQegSwOdRQVc4xhnN/Jm4w6+Um1OGlUnB0wO4oalVZZN0uAhx4Bdx+/Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OVFJJkHBYbxdRZKhWWlDd3nZUmM3IMXu087up/Kc5H4=; b=VLRGrUXZ7cty8qLpQ58Lz1gxziefCx4L6CH0EpYL5kZUdP0Nu2pXGcbHW3EmiKTWZoSiYqaBP223jeSVtSlFCUrgFI+hT9JJ8zNMRGWqdG/YNo99+anIdJq30qg/XwKo7i8swQ4+6MMTZXse9mh6JawmnlOL2z6zQY415xz2MobFcIzrlC2cNJLhwtJYkTCfRRiPynKkM3WHmV49WuKA5ovXOUCnQ8dDf31BZ7iutpI8Ymxlw5X1A5t4nP4Tp6MvNz35+yTvgdrmu+4k76MmLDmr6+caNUHLwYVtKMes88XaHcfE27vXRC2wl1T6ryAiiJ+a5idy9y9m7nQ+nRML8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OVFJJkHBYbxdRZKhWWlDd3nZUmM3IMXu087up/Kc5H4=; b=eVa5JAjvOO0BB62BQgwN4NAyFcjf5BkYH8blGf5dWuCbsGkl1YK/9k1w9Tpd5Jv4w47+zP5Y9VgVwB334ohr7K7sGbDvAYpPexUwpZC86r+CUU+4dw5Lybi2D/a3CP4ITXHSWN8jEmLgUiJ+uXdgEg44vbEEt8EDcqtaYrVPq3k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) by AM5PR04MB3169.eurprd04.prod.outlook.com (2603:10a6:206:4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Mon, 22 Aug 2022 15:52:07 +0000 Received: from PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba]) by PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba%4]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 15:52:07 +0000 From: Frank Li To: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com Subject: [PATCH v7 3/4] dt-bindings: irqchip: imx mu work as msi controller Date: Mon, 22 Aug 2022 10:51:29 -0500 Message-Id: <20220822155130.2491006-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220822155130.2491006-1-Frank.Li@nxp.com> References: <20220822155130.2491006-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR13CA0038.namprd13.prod.outlook.com (2603:10b6:a03:2c2::13) To PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3314034f-95f6-49fe-1d74-08da8456437f X-MS-TrafficTypeDiagnostic: AM5PR04MB3169:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p2fk2sK9Zsl4lqOhu/BssTXok6U7OeVWdaPH003TsyRRkED+SslZiK1rx10THfXIuGx+dZUJG896z0YS6U9LGb32Z2fdw2J1Z8SeOZiys2sMupaq16PLY+lfshHkYN1zK/ri4DUys2FMLkOxNwhgdte+MU9MGouqkxLHcYlWdBT3I1YFg+GQCu5dfpgsgQLClrAdR1R0Mhl6BfKF+OGuqg/CBsrpcShgODh/f7HAQjzK2f7I8TpaMYCnAZ98IXYZk7XcRsybCeYvWU0IUWCF+RuIkFDwBx01KKR0ACcn/cCZgdOVR5yDyRc+zQFYJiWkevA9YA9sX0K1GQtSn7r0L5xLFrh9qXRqzNuvIuh1IsAn77u6Lik2ZKQ4J795xa4jtXqqM/lnK7VIRPj94yO60Ux4KPJBwyXHLvlzWpWiCJm2fdtFTIj5hWk3WqaCo59JSHY7nF6+g9hB17iftdgdslbgSuXqrK1vsHSDZrC0+adBoTGQBZTwVp2nfPmS2z4i7R5uCfVjzSompo3wI/ez0qPQqlNtIX4J7lYsbjvGxnu0+ylS91iryGWpCcQBy6ysvMyg4nmVYF8JcG+Gr0acUX/X/9up8CGCFXRcTqRPR9zSPQ3eSVyI6BWSWQCH257yTGkYmjhJz3jgFDbB3wQTa//0dyCucSlpLRVCH/G0OBBgga0KHV706u7BiJhz1piDWFOo/1RoQ+TEUYYfDoAwlXBzDnLfNPEEJHDjE1aExCKHLTfZIZz9YL2Db5rvI5TKk/nk3VNiTkBx6foRyUaXS5DfpUnNN/J6xn51iJ4YE/2L7PL+TAaLZVOwqFOA4yFPFeBVCAOcyD8W1PD7W/os9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9186.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(316002)(86362001)(38100700002)(38350700002)(36756003)(41300700001)(83380400001)(26005)(6506007)(52116002)(6666004)(6486002)(966005)(6512007)(478600001)(2906002)(66946007)(66556008)(66476007)(1076003)(8936002)(5660300002)(8676002)(7416002)(2616005)(4326008)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 84H4grMEkJG+fpT2ntU3P4Sv0xC5tuDizY3MLdPnq2ZFOzl4ZcpKq/pJSHwnbG6j24HefVizEnU82uPSCw2VoVqUojSldk4oYHvTcIfHjaT9GbK5DwCSvbSolnR8V3cMla0jXqzN8fHhS2ukUaxKHmYx8/Y6pNMy9wD+j+bIsvQTMtkiYKpgXBRuXy0rLoQ+Ga0Y2A/cpN9oDh12lxQkJPApuXks0vAqWxZCbmzamx7bUW5gtSVBL2Ga7ntCvUtaFLS1mo1kttvy6hLozmkeO8Wpm2oSOQ8JoGn/QKzMyNjrrl0C1UfVTkbJ4LZcKRoqy6PKmtlLTFW/axAu1AfmQwUrxPDLY4+PXSvjnulIVm8T336P8YvEdhdYnI+VCfwa6lEDfNPBq0YNAsr8x0HE56FtQtGFedsnHqAy+VJ/UnBBu7UmLgczxsrjpTo+OZcm5PP0ymXSIkSY4ejS4eW2dliwqrRKrQ3YirHENDvhUv1yFp6tAxd8Aqevs+hX4IRKKGZP6C0DRGnKhZfXjei4sKJeNBJgjqPD//7JhQVoASG2Ts9ZRDvqN/NvOBS9TBtMdbgK++KD9e0/Ai+aO5mhg4Hxb3M4LC1Dri1wDNMdfDvmrawr3PJbPs1Co8eh5kfH3J2lk1isfd4RUT9bbBLYt26ylRZ2ctKzVLUCbMD9ZdteBhu+OoilqPrWPmDH3TQEos2MSe9sGcxreCCV3XhmFjfTS9nm+c6+mJmsjjt3GA9nOwf8tFF/+ZmLUZXLNep42A5dpCggSidEEterIqh0sSD+7oHOpc+HVNyBbkA+52FScDOBtE+MmrFUrgAmnvIOkZGazZW7gVHHbM+n/OPu606WlskLoY5kQE9cxMArlvEN8+WiV4+WzGJEW8PsjkJTS0pXcsrCLA5oox/ZGbGbq/RXJpX+c+EmiHkLIQR6Ja0ElyZKZGlkUZMMHSy5bksKe8rNtYBg1+sFFeRK/7g3u6tbi8FDwP+zIJpYLHYU4+Yyshtv5Z2y5+8DKG0OhUclwA4vNKppsJTB/kt3yp2GAPHTY4MnhA+cIvxjLuJAesCS9ktxKe9mw0vYFta3J44vrzWTr5HQPvAl41dxhSNJ5NiA1NLgbLZK9L5hxGzcd82EskmrLnidbUPB/Fr7Y3M9VtX751xqUHKizGx0ojLAPqBHcuYSRnN03HGjow3CkB193idvkrvTNb+upToa0nlDbpGPiBoZ5X8SPccWr820LMT3LBBJ9IdM+Mih0zM1MafY7iNymRtpvPca2RzOgqFFDszRryEt9M3mO6pP1YddAIfHjHT2A4JalUNt+RoMuwDINOXLW1tHRtrI0cqKcr/WwjzwS1pEJrr33q7pbPNOQh4WKmhQCb2njgjbI66nmsMXUiVgX7HHqbPM/pqhcvAMYERC3d3jlddojKe4kW7qcwduhtoG5jhgOM1irDoGxbLBGxl54N+KL2674P5XtcuQAnK1YqN0PEu3Ih3ybZKsdVy9q5q9qE6CKFyxdvbmYegOFuDIvhxjGYLIuHlNKEDoYIgkl/EfzHCTcag0+kWOB6sF5o+j9Cc79CV2V0QI7XTwErg7C1hnU1Ps7VpJt9FA X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3314034f-95f6-49fe-1d74-08da8456437f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9186.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 15:52:06.2522 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zw6U8OVZVGWXjfcxMwRM7IiwDNEGuoL6mrc3BvJfOp5Oo3vU+/Y8Tf7zSDImaVzeZ97ya/AIlA/WPOVv8EnGuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3169 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_085215_329038_0E4DA0E8 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I.MX mu support generate irq by write a register. Provide msi controller support so other driver such as PCI EP can use it by standard msi interface as doorbell. Signed-off-by: Frank Li --- .../interrupt-controller/fsl,mu-msi.yaml | 98 +++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml new file mode 100644 index 0000000000000..ac07b138e24c0 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/fsl,mu-msi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale/NXP i.MX Messaging Unit (MU) work as msi controller + +maintainers: + - Frank Li + +description: | + The Messaging Unit module enables two processors within the SoC to + communicate and coordinate by passing messages (e.g. data, status + and control) through the MU interface. The MU also provides the ability + for one processor (A side) to signal the other processor (B side) using + interrupts. + + Because the MU manages the messaging between processors, the MU uses + different clocks (from each side of the different peripheral buses). + Therefore, the MU must synchronize the accesses from one side to the + other. The MU accomplishes synchronization using two sets of matching + registers (Processor A-facing, Processor B-facing). + + MU can work as msi interrupt controller to do doorbell + +allOf: + - $ref: /schemas/interrupt-controller/msi-controller.yaml# + +properties: + compatible: + enum: + - fsl,imx6sx-mu-msi + - fsl,imx7ulp-mu-msi + - fsl,imx8ulp-mu-msi + - fsl,imx8ulp-mu-msi-s4 + + reg: + items: + - description: a side register base address + - description: b side register base address + + reg-names: + items: + - const: processor a-facing + - const: processor b-facing + + interrupts: + description: a side interrupt number. + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + items: + - description: a side power domain + - description: b side power domain + + power-domain-names: + items: + - const: processor a-facing + - const: processor b-facing + + interrupt-controller: true + + msi-controller: true + + "#msi-cells": + const: 0 + +required: + - compatible + - reg + - interrupts + - interrupt-controller + - msi-controller + +additionalProperties: false + +examples: + - | + #include + #include + + msi-controller@5d270000 { + compatible = "fsl,imx6sx-mu-msi"; + msi-controller; + #msi-cells = <0>; + interrupt-controller; + reg = <0x5d270000 0x10000>, /* A side */ + <0x5d300000 0x10000>; /* B side */ + reg-names = "processor a-facing", "processor b-facing"; + interrupts = ; + power-domains = <&pd IMX_SC_R_MU_12A>, + <&pd IMX_SC_R_MU_12B>; + power-domain-names = "processor a-facing", "processor b-facing"; + }; From patchwork Mon Aug 22 15:51:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 12950884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39710C28D13 for ; Mon, 22 Aug 2022 15:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nwLR3WfanjVSng4nG9OtPF3bqXl64ugdRfTsu10K7dg=; b=Rlz7HvOmCYtmpy oKZCoeiXzXkkBHa0vLM78w/cfoAyJMRvw0feX1QWgRFw8kA/LTb7hZZiNX1k314hFrnH6pUGOiFBH 7u6mCUv02fiRJ6qmSlHpnZoclZgwv4nolM73+tIKKtUkwrinpw/KkLH2vKQFbNC07iJfd5gfGBtDC h/iD6veclAKdn/6YwOrDP0YNbeQVp5Qa49U8VqsHG5bKObOXoO1vqTHM4w8+byZ8sjIjLjw2kWkVz xzdBWvN6Sf66LGV1vmye2Cl0VH8QeVJ/JdrqS8UaN3crRxM+Z6aYe8x9bs9Sk+YR8xWZYic4n6fqr AZuQ6cDcKnZ1iBnHv1ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9jr-00CQw3-37; Mon, 22 Aug 2022 15:53:21 +0000 Received: from mail-am6eur05on2068.outbound.protection.outlook.com ([40.107.22.68] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ9ir-00CQTR-Ml for linux-arm-kernel@lists.infradead.org; Mon, 22 Aug 2022 15:52:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GdZ11DihJ4sdkkaUeWhIczIEJgE9nnlIHcz9e1U8VHn+XJO3jOyfk1EQH2a3ExAjQ5lQwhRRHjWYgtB2oAmDFQ4IMdMWqBo4XrrjHtLOPyKb4IJi7UX+8Ciei0Ueor11BAKjXIi6alOgAucH4GwTBZL9NvXilvMJU7sPqKqTBizTU6d79OyGp4/zMJiC1ydKzo7Oxhf8f9KUq3UxruL8GK2WTbuosQemuGNTNMgJA0V+YV2hHUWEGjywZgxaVgJjsbtFIUwj30mXgFFAbpARjHxFOoI9gv4OCPaJopp+eaGgYImdRVRd+XameIDGUy4Jo52krOYz9qBpLX6oJXeNTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QQXsOmuWXBzf9yYCiCT7zVy4+e+0vl65Kcdrmv8mNtE=; b=Nh+6UJ5pd8ToJ9iUYeYCEse0FiTDiyh+PVfI0bS9Tc1nWJnK5E+3Vvi0+w8S1KKo/squ7fEVct/cgL9NGOoFYNYW45yAsoUo6gebAAghIRUSoZa8J6pvEoMjEeuyhRYjcrs5DfHLHaFEJogHIaddvpF6jW7MI2J2sNeNakwOOtGYMUivKnRmPhBin0F5ZGW7NTMeMCyWjEVastCQ3vasK+5JE3eOsimvBieTJofvoOAdw1E2M2jCyA6vHfza/52JrlFHxjhrAKgdRztgzKX5kZLYuSUQ6dCFLF/Skro+BlnG0QoOgzRUHaTyupb1RUNy3Zdkce1uWdSx9zOiHiPaIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QQXsOmuWXBzf9yYCiCT7zVy4+e+0vl65Kcdrmv8mNtE=; b=ROzW+uBeoEQXYjxwqO9NDAi4nJyrZi2eRadbu63nEIHbP7ARkN7Hfe4l2rAiUMtvcNpvVJq6YlVDufd8IqrKgLhlChpwzYh3MRXXmSN6dX3+Zbaaoq2304i6h8bKr3E+IJMzbM4p8tuo7mel6v3Rvi1iZzSXAnBqzi3YkigO3Co= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) by AM5PR04MB3169.eurprd04.prod.outlook.com (2603:10a6:206:4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Mon, 22 Aug 2022 15:52:11 +0000 Received: from PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba]) by PAXPR04MB9186.eurprd04.prod.outlook.com ([fe80::85cb:614b:9f52:2dba%4]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 15:52:11 +0000 From: Frank Li To: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com Subject: [PATCH v7 4/4] PCI: endpoint: Add NTB MSI support Date: Mon, 22 Aug 2022 10:51:30 -0500 Message-Id: <20220822155130.2491006-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220822155130.2491006-1-Frank.Li@nxp.com> References: <20220822155130.2491006-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR13CA0038.namprd13.prod.outlook.com (2603:10b6:a03:2c2::13) To PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd101fe5-0396-4866-b5cf-08da84564670 X-MS-TrafficTypeDiagnostic: AM5PR04MB3169:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: STQCcIy8v7SceW1nWizJtvE4yfJ24iW7rsciSCyE1df7Hc5sVlUWFVpNZCTRG5pSW+C4saXae7533fhFY3yeIaPijmAriZrT8pP1teKhjKKrmi6hUyN9i9jr+XiWsLmu0F49I3hNoe9wgFh5NRCZpDmd2R7mNCm4s1SJJeRW57lvBp5/rghyYCJc3Y54Pke7FCUw1jgySbjuj03ywlKT3HsAbyq+/jlgC565doyLm8ZRubsqBW4yMUyNAd+YN75K+MD4DuuS4c075w7jwLf8LTWsGp7X62xAnp/CM4tyhwwh/9lVADVvclSfECM9mB3SjMmXXAzLtuHBHn6qswQMhH9Sk+flQAOhCENioh4/OFTU65aBy5rX2hJPtBoEUFOk7RX4V8K0Ezr59HSiZI/uPqs9U2G9JllcO29lEygF/NyU+1RXY6lHPjOxxOz22qCL3WqjyOA+UcEk2lb08KdTTUlA/2xNQU5q6GgKc3bCtjcf3vSDW1YOFU9xHjJe77Zao4lKrZpqq3tWNLG4bIPJ6DZmIUFwwQpFVFDFrLEPl1s1MwsJvqBvqhXWjrC/sl9+vR6hLQK4t8cC89vJ00lOLGwEO1FMPhB+iX6mGIPmIbSVEgwWEBv7WdBvayp+AmVMGjM0w6JqTjExABZ0lt8LaqYUnZ/JUy8TUIEIipWKscyxQ+y/4oiWsArVtTLLZFoa0k13BYMedJDPievWdqtU6X4MV51TMx7jcTvHEoNxHc8jWvANQBavVDkBwvX1Ae44I0htkO+6dGJ9G9NggSXO2g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9186.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(316002)(86362001)(38100700002)(38350700002)(36756003)(41300700001)(83380400001)(26005)(6506007)(52116002)(6666004)(6486002)(6512007)(478600001)(2906002)(66946007)(66556008)(66476007)(1076003)(8936002)(5660300002)(8676002)(7416002)(2616005)(4326008)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?TrssZjYbYXqRUlTY+stCHhR2c5dJ?= =?utf-8?q?+UMFFf7jrVaKxEXowGrTh2OFUSCoucgrZ4dvGmCHJ7T3Xas++Y+oBXojKuMyfAD36?= =?utf-8?q?mz3jufBV79XEld9l0VCMC3lRoZ0N/PNzE2Cc3pQMUJQdZS6aqe9fnyPQRPSYZXBrl?= =?utf-8?q?TKyYHS2DgjlwABzF+mhqMBXD/BIBaT2rcO84VhXaD8rrGyudeDr9K4z4eo8utoZYJ?= =?utf-8?q?dIF+RGPLZepHdQyAmIjQ1hBWF3ZtaMWJjrDG9UhGwbIKn+FzfdIPSwu49ycDRKVxO?= =?utf-8?q?1eXyedxIxiay2yfiyyIZrd/GXKrZyg5Br2KvjpDvlEE7mnyzz+bh6qmzYNQSlum4X?= =?utf-8?q?P0LWpXCM8FuLPLzI/zDHXIq0Ly77Oo2uI0CYeQUfUFiOl2G14Z9gbT4PiA7obgrop?= =?utf-8?q?UlQcqJ0KS2XHbDsN68WdjgCgcawX8r4qMVW8Dw9zu8yZAzO0m4YVR8UeeWxa3pNzC?= =?utf-8?q?vsaeSUMWfLqmv2L3Clm19JR/9fJWAW1tTsTNFGScEyeHibkAG5ZAAIVFuw3sswHwP?= =?utf-8?q?C7/GHD6Ga1h3YySVdNxnr4UDJUIdU05TZ/Y5sOGjA8mXTLYrQkZ/p8ngbFMGR5un4?= =?utf-8?q?q8bGYqkKNnSPY82eGjRv5Oa8vTr4K73iu/k45RMpliWvFV+x8yAi+Adt3hV+9sgPQ?= =?utf-8?q?xq9FV0MN3EHxAE3xPXbF+p7/0KjezDnioyWy/OCWreTh6Fix4R73or8tN1/3glurY?= =?utf-8?q?boq2Dd3DTyeNK5hCv4mcCg2zNlBi08nS3ebjpE06Mh2au0pr4dtUXzCtktfmv/hZ/?= =?utf-8?q?L2oIpKJAa2bR3545A+NKpHpj1QEnxzfnboApMRIQVGLx4UbCM93hq42OzasSLWPq1?= =?utf-8?q?OMnqrEx4fiRM57pVqVuy/R7JBrVrQveMvYnkwwcZmzjgH7PyDmneobbnLibx0lwNr?= =?utf-8?q?l9rHU1cAqXrbMO+h9wFF02QIqxd0WXzM37ddjPwVABwTmtSY12JUc/34EG3lRKwh7?= =?utf-8?q?v6VY/xjV/wR4BviaksLKrwdZ/cDAd8jy14Po9plSm7vVN3//a1aIH5DAPH8V2WEHZ?= =?utf-8?q?kLAuergdrmc+tTsUIUkeNNkwanAr+32uneeCQhe5teuDFov42BSVrzGgmnHpicTJV?= =?utf-8?q?fF8vcWvxhczo8612cBSsnw2F0MqODZgJGJbvr4nSP8q10gzY9Sv4gjya59K4Oz814?= =?utf-8?q?AbhA9bSK5VNtUt0yI5Tv84UcbBhLvG67565+7okHnlS0qjLfTMTFEVH+BTtCj7BIW?= =?utf-8?q?TtDQ+SDFnWsSrrj5tgSGPHr7GQxUUGgRBpViu3WDuhaJ740GP8lXyvTNrrY5+xXbQ?= =?utf-8?q?LAj5HRYmV7c3knFBN7ARqaF1MuDcWXMDvNeusR44dRtb/9qFbABEsXKoJsBGNtYsh?= =?utf-8?q?ktrSRIjq7Kgc2cCIwM85VqPOL8mtR8xxIgJng7KCsyNdJO/SbG1M3Lx9qFUqg4vKD?= =?utf-8?q?LaxZAJDG66G999xT1V5tLl89aJAVaxgpFqDv5RUZ7HXZJsvEDZl9oT0vrwK0Imj6C?= =?utf-8?q?cwc8GT83SN9wLrnY2QG1c8lBBitUIsJd866skfgOZZSZSv7n/JxrKYhewZwvnh4nH?= =?utf-8?q?EqtenyV96Vov?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd101fe5-0396-4866-b5cf-08da84564670 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9186.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 15:52:11.4410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yf0fKXliTZeQHgMGkL5gof1qFAnPQQcSjzCRhnPAQSshC5toNRNp+pMlvryUEQSsZmhIQmru0alzlPH67wf30w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3169 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_085217_967161_6A8FDDDB X-CRM114-Status: GOOD ( 22.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ┌───────┐ ┌──────────┐ │ │ │ │ ┌─────────────┐ │ │ │ PCI Host │ │ MSI │◄┐ │ │ │ │ │ Controller │ │ │ │ MSI Write │ │ └─────────────┘ └─┼───────┼───────────┼─BAR0 │ │ PCI │ │ BAR1 │ │ EP │ │ BAR2 │ │ │ │ BAR3 │ │ │ │ BAR4 │ │ ├──────────►│ │ └───────┘ └──────────┘ Linux supports endpoint functions. PCI RC write BAR space like write to memory. The EP side can't know memory changed by the host driver. PCI Spec has not defined a standard method to do that. Only define MSI(x) to let EP notified RC status change. The basic idea is to trigger an IRQ when PCI RC writes to a memory address. That's what MSI controller provided. EP drivers just need to request a platform MSI interrupt, struct msi_msg *msg will pass down a memory address and data. EP driver will map such memory address to one of PCI BAR. PCI RC writes to such memory to trigger EP side IRQ. Add MSI support for pci-epf-vntb. Query if system has an MSI controller. Set up doorbell address according to struct msi_msg. So PCI RC can write this doorbell address to trigger EP side's IRQ. If no MSI controller exists, fall back to software polling. Signed-off-by: Frank Li Reported-by: kernel test robot Reported-by: kernel test robot --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 148 +++++++++++++++--- 1 file changed, 122 insertions(+), 26 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 1466dd1904175..f6e0b682da000 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -44,6 +44,7 @@ #include #include #include +#include static struct workqueue_struct *kpcintb_workqueue; @@ -143,6 +144,8 @@ struct epf_ntb { void __iomem *vpci_mw_addr[MAX_MW]; struct delayed_work cmd_handler; + + int msi_virqbase; }; #define to_epf_ntb(epf_group) container_of((epf_group), struct epf_ntb, group) @@ -253,13 +256,15 @@ static void epf_ntb_cmd_handler(struct work_struct *work) ntb = container_of(work, struct epf_ntb, cmd_handler.work); - for (i = 1; i < ntb->db_count; i++) { - if (readl(ntb->epf_db + i * 4)) { - if (readl(ntb->epf_db + i * 4)) - ntb->db |= 1 << (i - 1); + if (!ntb->epf_db_phy) { + for (i = 1; i < ntb->db_count; i++) { + if (readl(ntb->epf_db + i * 4)) { + if (readl(ntb->epf_db + i * 4)) + ntb->db |= 1 << (i - 1); - ntb_db_event(&ntb->ntb, i); - writel(0, ntb->epf_db + i * 4); + ntb_db_event(&ntb->ntb, i); + writel(0, ntb->epf_db + i * 4); + } } } @@ -454,11 +459,9 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) ctrl->num_mws = ntb->num_mws; ntb->spad_size = spad_size; - ctrl->db_entry_size = 4; - for (i = 0; i < ntb->db_count; i++) { ntb->reg->db_data[i] = 1 + i; - ntb->reg->db_offset[i] = 0; + ntb->reg->db_offset[i] = 4 * i; } return 0; @@ -509,6 +512,28 @@ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) return 0; } +static int epf_ntb_db_size(struct epf_ntb *ntb) +{ + const struct pci_epc_features *epc_features; + size_t size = 4 * ntb->db_count; + u32 align; + + epc_features = pci_epc_get_features(ntb->epf->epc, + ntb->epf->func_no, + ntb->epf->vfunc_no); + align = epc_features->align; + + if (size < 128) + size = 128; + + if (align) + size = ALIGN(size, align); + else + size = roundup_pow_of_two(size); + + return size; +} + /** * epf_ntb_db_bar_init() - Configure Doorbell window BARs * @ntb: NTB device that facilitates communication between HOST and vHOST @@ -522,33 +547,32 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) struct pci_epf_bar *epf_bar; void __iomem *mw_addr; enum pci_barno barno; - size_t size = 4 * ntb->db_count; + size_t size; epc_features = pci_epc_get_features(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no); align = epc_features->align; - - if (size < 128) - size = 128; - - if (align) - size = ALIGN(size, align); - else - size = roundup_pow_of_two(size); + size = epf_ntb_db_size(ntb); barno = ntb->epf_ntb_bar[BAR_DB]; + epf_bar = &ntb->epf->bar[barno]; - mw_addr = pci_epf_alloc_space(ntb->epf, size, barno, align, 0); - if (!mw_addr) { - dev_err(dev, "Failed to allocate OB address\n"); - return -ENOMEM; + if (ntb->epf_db_phy) { + mw_addr = NULL; + epf_bar->phys_addr = ntb->epf_db_phy; + epf_bar->barno = barno; + epf_bar->size = size; + } else { + mw_addr = pci_epf_alloc_space(ntb->epf, size, barno, align, 0); + if (!mw_addr) { + dev_err(dev, "Failed to allocate OB address\n"); + return -ENOMEM; + } } ntb->epf_db = mw_addr; - epf_bar = &ntb->epf->bar[barno]; - ret = pci_epc_set_bar(ntb->epf->epc, ntb->epf->func_no, ntb->epf->vfunc_no, epf_bar); if (ret) { dev_err(dev, "Doorbell BAR set failed\n"); @@ -704,6 +728,77 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) return 0; } +static void epf_ntb_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg) +{ + struct epf_ntb *ntb = dev_get_drvdata(desc->dev); + struct epf_ntb_ctrl *reg = ntb->reg; + int size = epf_ntb_db_size(ntb); + u64 addr; + + addr = msg->address_hi; + addr <<= 32; + addr |= msg->address_lo; + + reg->db_data[desc->msi_index] = msg->data; + + if (desc->msi_index == 0) + ntb->epf_db_phy = round_down(addr, size); + + reg->db_offset[desc->msi_index] = addr - ntb->epf_db_phy; +} + +static irqreturn_t epf_ntb_interrupt_handler(int irq, void *data) +{ + struct epf_ntb *ntb = data; + int index; + + index = irq - ntb->msi_virqbase; + ntb->db |= 1 << (index - 1); + ntb_db_event(&ntb->ntb, index); + + return IRQ_HANDLED; +} + +static void epf_ntb_epc_msi_init(struct epf_ntb *ntb) +{ + struct device *dev = &ntb->epf->dev; + struct irq_domain *domain; + int virq; + int ret; + int i; + + domain = dev_get_msi_domain(ntb->epf->epc->dev.parent); + if (!domain) + return; + + dev_set_msi_domain(dev, domain); + + if (platform_msi_domain_alloc_irqs(&ntb->epf->dev, + ntb->db_count, + epf_ntb_write_msi_msg)) { + dev_info(dev, "Can't allocate MSI, fall back to poll mode\n"); + return; + } + + dev_info(dev, "vntb use MSI as doorbell\n"); + + for (i = 0; i < ntb->db_count; i++) { + virq = msi_get_virq(dev, i); + ret = devm_request_irq(dev, virq, + epf_ntb_interrupt_handler, 0, + "ntb", ntb); + + if (ret) { + dev_err(dev, "devm_request_irq() failure, fall back to poll mode\n"); + ntb->epf_db_phy = 0; + break; + } + + if (!i) + ntb->msi_virqbase = virq; + } +} + /** * epf_ntb_epc_init() - Initialize NTB interface * @ntb: NTB device that facilitates communication between HOST and vHOST2 @@ -1299,14 +1394,15 @@ static int epf_ntb_bind(struct pci_epf *epf) goto err_bar_alloc; } + epf_set_drvdata(epf, ntb); + epf_ntb_epc_msi_init(ntb); + ret = epf_ntb_epc_init(ntb); if (ret) { dev_err(dev, "Failed to initialize EPC\n"); goto err_bar_alloc; } - epf_set_drvdata(epf, ntb); - pci_space[0] = (ntb->vntb_pid << 16) | ntb->vntb_vid; pci_vntb_table[0].vendor = ntb->vntb_vid; pci_vntb_table[0].device = ntb->vntb_pid;