From patchwork Mon Aug 22 18:42:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12951082 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0BEBC28D13 for ; Mon, 22 Aug 2022 18:44:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2AE9D1636; Mon, 22 Aug 2022 20:43:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2AE9D1636 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661193871; bh=vFptHFTQvMLLc8fNOk6m0lzbZBBJ5nP10P1cIx99YyU=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j4/DddhKjJt8fwXOQLJCoxftZeSh6cd3/k2kmw4s9z7TCkAr6mNX+VxWC2L7NKbE6 JwF3DB8i6VzlZRgZtVsNIRKLwiVrsGvaSxQtPah+GXzJQi1k43MX0aDKebuZBJps3g PCuOYk/iknFuu5vQGQu1G3K4ApFCfUn6BnL6kVFc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E1B24F80528; Mon, 22 Aug 2022 20:43:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B3D50F80529; Mon, 22 Aug 2022 20:43:13 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9C9EF800A7 for ; Mon, 22 Aug 2022 20:43:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9C9EF800A7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TT4icqA+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661193788; x=1692729788; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vFptHFTQvMLLc8fNOk6m0lzbZBBJ5nP10P1cIx99YyU=; b=TT4icqA+/Dp0H18fgt5d+ImUrUeUEeQnN1IboD+YLtG39pLF+ScQ+fDz SYBPLHnXeFO/xX+/KrQ81jcRmHjo8wZ3jxT4zKis8kxLo/j1gEs1sZ08v puZ9zm2s3PFBAWFU276sHnJ3SSgnLwOnKJvW8zBO6XPxSmQQNxrZI95Et WjxGX/PxsG5YjojPTXQoNw4DxV03y8+qTq45P9DmB2+RtxTlz7aneUJ5C lzK1Fkjb1LVHRf+8NMbpATHsNpE7OJKGG1aeEgZuXpmypwbA6l9Ju+wnX LuZNrMJojq4lxaBmOD97gsYPFSL61Hx3JFn/gsAsDU/5n3aqKsjUALhzh g==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="293488946" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="293488946" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:05 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="669671063" Received: from apascali-mobl2.ger.corp.intel.com (HELO pbossart-mobl3.home) ([10.252.42.21]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:02 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 1/5] ASoC: hdmi-codec: remove unused definitions Date: Mon, 22 Aug 2022 20:42:35 +0200 Message-Id: <20220822184239.169757-2-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> References: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: Charles Keepax , Kai Vehmanen , tiwai@suse.de, open list , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , broonie@kernel.org, Chao Song , Dmitry Osipenko , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" cppcheck warning: sound/soc/codecs/hdmi-codec.c:24:16: style: struct member 'hdmi_codec_channel_ma`p_table::map' is never used. [unusedStructMember] unsigned char map; /* ALSA API channel map position */ ^ Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Chao Song --- sound/soc/codecs/hdmi-codec.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 5679102de91f8..863e679d2ac11 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -20,10 +20,6 @@ #define HDMI_CODEC_CHMAP_IDX_UNKNOWN -1 -struct hdmi_codec_channel_map_table { - unsigned char map; /* ALSA API channel map position */ -}; - /* * CEA speaker placement for HDMI 1.4: * From patchwork Mon Aug 22 18:42:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12951083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64A6DC28D13 for ; Mon, 22 Aug 2022 18:44:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78AAB1670; Mon, 22 Aug 2022 20:43:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78AAB1670 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661193880; bh=LXeq1g0rOoidK7Ljzxcs+75UbaovvOPztMME8H2Yn5I=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YxgY5uGIhlawQAKdiyrgu71lGW8gg0iaL2HYvyJuMhMFOUPSJg/xO8Eio/QyyKzKW PSNFBbic1+WThlCREAIsSfA2ZLY/F4yS6SdJEDKRg/u8ezM6x560T1IFjyuoF6p0fL LzVNcVoCPwuOQHttI76OK53mkWERI61dBsYk7QCM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5E38FF8052D; Mon, 22 Aug 2022 20:43:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0FC8DF80535; Mon, 22 Aug 2022 20:43:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 50C8AF80517 for ; Mon, 22 Aug 2022 20:43:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 50C8AF80517 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="iFWPYfrF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661193791; x=1692729791; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LXeq1g0rOoidK7Ljzxcs+75UbaovvOPztMME8H2Yn5I=; b=iFWPYfrFMsQvmAK1H1CyB5UU2vEQtOPzusV9fgalB+1SpUcI4uKU+k2Z rfbQBXR+h4YHmkllJbhjFch0FG5nNobYm4avMX2u2o+A/5rd4EunoAMa3 DIr7z6jghAYxxJhM3Qmy4ypeIwdtXXGTjAF3c5UTJWjp9+uvbIOD7+r1L WwT4ZeAeQyuyI5yzl7P4WoL7TH4cR/E+OagaAADHbavtsr1N/u3z5OPXZ I33p0aM+dH2FX095rPdt8Jmy61OTyBx0ZjrUEyRk2wsRE6SHnEzfAlwJ7 ArY3pSRbpHrw7p/s52EmYLb9+JHklBc1B0WqVS/VAlOc+mJynsAWmO9qT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="293488963" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="293488963" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="669671087" Received: from apascali-mobl2.ger.corp.intel.com (HELO pbossart-mobl3.home) ([10.252.42.21]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:06 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 2/5] ASoC: wcd-mbhc-v2: remove always-true condition Date: Mon, 22 Aug 2022 20:42:36 +0200 Message-Id: <20220822184239.169757-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> References: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: Kai Vehmanen , tiwai@suse.de, open list , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , broonie@kernel.org, Srinivas Kandagatla , Banajit Goswami , Chao Song , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" cppcheck warning: sound/soc/codecs/wcd-mbhc-v2.c:1192:26: style: Condition 'cross_conn<0' is always true [knownConditionTrueFalse] } else if (cross_conn < 0) /* Error */ ^ sound/soc/codecs/wcd-mbhc-v2.c:1188:15: note: Assuming that condition '!cross_conn' is not redundant } else if (!cross_conn) { /* no cross connection */ ^ sound/soc/codecs/wcd-mbhc-v2.c:1192:26: note: Condition 'cross_conn<0' is always true } else if (cross_conn < 0) /* Error */ ^ Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Chao Song --- sound/soc/codecs/wcd-mbhc-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd-mbhc-v2.c b/sound/soc/codecs/wcd-mbhc-v2.c index 98baef594bf31..b16a18dbfe7af 100644 --- a/sound/soc/codecs/wcd-mbhc-v2.c +++ b/sound/soc/codecs/wcd-mbhc-v2.c @@ -1189,7 +1189,7 @@ static void wcd_correct_swch_plug(struct work_struct *work) pt_gnd_mic_swap_cnt = 0; plug_type = wcd_mbhc_get_plug_from_adc(mbhc, output_mv); continue; - } else if (cross_conn < 0) /* Error */ + } else /* Error if (cross_conn < 0) */ continue; if (pt_gnd_mic_swap_cnt == GND_MIC_SWAP_THRESHOLD) { From patchwork Mon Aug 22 18:42:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12951084 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE8C8C28D13 for ; Mon, 22 Aug 2022 18:44:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DCB5D1677; Mon, 22 Aug 2022 20:43:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DCB5D1677 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661193889; bh=n8LryROOr9/Rmu/wIyOOGB0YSEQdyNpliRqkID42vQM=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BcS2ek7cbnICwIl5FfgntxQJOO1ChVwAe7mB74z7K1Q7ibyMG/+Nmt3YaVfcBxxMe vEASOYlWYH99hBOYx4ceNeC90q9om7BnSNplDp6erlJhQD+IMNQ2s2h3j5ltVHftcL xlrgNmEfN9744qlarQ+22pcox4tss30OZknHKU6k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D8C4AF8053A; Mon, 22 Aug 2022 20:43:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D9F7F8053B; Mon, 22 Aug 2022 20:43:21 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 685E3F8052F for ; Mon, 22 Aug 2022 20:43:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 685E3F8052F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EUPHNKAp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661193795; x=1692729795; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n8LryROOr9/Rmu/wIyOOGB0YSEQdyNpliRqkID42vQM=; b=EUPHNKApkNkerBJj8wlkr5kOCldOh0TEj4CP0g52Oc0mFcKhl0K4Fm/e UnPiEhclI3c2va0iGoCdeienrV4eNv0NZv3eFDMktqA4ZOwl9CBQ3Nd0n I9nqjVsKGn9BVxh/MRbMSoSoI/JynoIJHJVxqGJSpWTrbRx3V1bahsADZ uBpF6UXRj5cVL6Fkq0R+rZlOLHabLpV8cttGxZmakWcDuEXFi44KfscaR Ukb5b4fx2XA2MP8T/MH3LCAbubKJT6mMGXxm19sq9ZS4h/Equq65IoVMz qkIlZoP/+l87ATlrEOJWYqMSObpwoRqSP0R38a8He/WxEZTQcxhaQjTyJ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="293488979" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="293488979" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:13 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="669671100" Received: from apascali-mobl2.ger.corp.intel.com (HELO pbossart-mobl3.home) ([10.252.42.21]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:10 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 3/5] ASoC: wcd9335: remove always-true condition Date: Mon, 22 Aug 2022 20:42:37 +0200 Message-Id: <20220822184239.169757-4-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> References: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: Kai Vehmanen , tiwai@suse.de, open list , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , broonie@kernel.org, Srinivas Kandagatla , Banajit Goswami , Chao Song , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" cppcheck warning: sound/soc/codecs/wcd9335.c:1824:22: style: Condition 'tx_port==13' is always true [knownConditionTrueFalse] } else if (tx_port == 13) { ^ sound/soc/codecs/wcd9335.c:1802:16: note: Assuming that condition 'tx_port==12' is not redundant if ((tx_port == 12) || (tx_port >= 14)) { ^ sound/soc/codecs/wcd9335.c:1802:35: note: Assuming that condition 'tx_port>=14' is not redundant if ((tx_port == 12) || (tx_port >= 14)) { ^ sound/soc/codecs/wcd9335.c:1824:22: note: Condition 'tx_port==13' is always true } else if (tx_port == 13) { ^ sound/soc/codecs/wcd9335.c:1845:22: style: Condition 'tx_port==13' is always true [knownConditionTrueFalse] } else if (tx_port == 13) { ^ sound/soc/codecs/wcd9335.c:1802:16: note: Assuming that condition 'tx_port==12' is not redundant if ((tx_port == 12) || (tx_port >= 14)) { ^ sound/soc/codecs/wcd9335.c:1802:35: note: Assuming that condition 'tx_port>=14' is not redundant if ((tx_port == 12) || (tx_port >= 14)) { ^ sound/soc/codecs/wcd9335.c:1845:22: note: Condition 'tx_port==13' is always true } else if (tx_port == 13) { ^ Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Chao Song --- sound/soc/codecs/wcd9335.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index beeeb35e80321..5b4d3c5973532 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -1821,12 +1821,10 @@ static int wcd9335_set_decimator_rate(struct snd_soc_dai *dai, tx_port_reg = WCD9335_CDC_IF_ROUTER_TX_MUX_CFG3; shift = 0; shift_val = 0x0F; - } else if (tx_port == 13) { + } else /* (tx_port == 13) */ { tx_port_reg = WCD9335_CDC_IF_ROUTER_TX_MUX_CFG3; shift = 4; shift_val = 0x03; - } else { - return -EINVAL; } tx_mux_sel = snd_soc_component_read(comp, tx_port_reg) & From patchwork Mon Aug 22 18:42:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12951085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99104C3F6B0 for ; Mon, 22 Aug 2022 18:45:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B9A791686; Mon, 22 Aug 2022 20:44:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B9A791686 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661193913; bh=Ka7WextPfjZOGGLuRueSjo/vpJj3kZ8OnGhm3O3GFNo=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JVlAP531K5AbiA8CdRruzjlUMlbZ3QgcOvjUJzTrryBW9F9PA/0vE4Ld49mBawuNQ /hJO0nnM7kTq4SkSnFF5RDsFf7Q6l10jsrqbW7uDk9PH7BsZ2SGiCOfDua7EKIKWyn SgiIvTbbJHLMf3qI1u6+mUMsgUj3cghr6HBy3wjo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50BD3F80548; Mon, 22 Aug 2022 20:43:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B40F0F80549; Mon, 22 Aug 2022 20:43:25 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1B744F80537 for ; Mon, 22 Aug 2022 20:43:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1B744F80537 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RAOECdV7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661193800; x=1692729800; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ka7WextPfjZOGGLuRueSjo/vpJj3kZ8OnGhm3O3GFNo=; b=RAOECdV7NFHLXWYFvQkSgOABWsYu15jmVqKRWTocGUZXhDY1gSXKfKt/ 4F13dTp9cXC2GEzDX+7KmEYi87yZS0s0MwZTUB/QuO8q298GOx8LYRCNZ Cu9PbJvP0Gm9JpQT7B87fciQK0snbjaW4TF1UeaF2jjYjYIyqQ2I9FH52 KSIkjxMqJDS1ceGlBAa6WsAdBjkck6EBwgq+bD1wI6mZqdBeD0mW9yEY4 CXDA0meAf/iiR8lhA4V/fVe/cEmOKM5AU/g3SE5gwghhG11W8SFFL5H6T 7XufdR1lseztCSCB7LmSKyHvlDwZwY31kUP8zKN8BpLBheD4wP7WDNNX0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="293489001" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="293489001" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:18 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="669671108" Received: from apascali-mobl2.ger.corp.intel.com (HELO pbossart-mobl3.home) ([10.252.42.21]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:14 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 4/5] ASoC: fsl: fsl-utils: remove useless assignment Date: Mon, 22 Aug 2022 20:42:38 +0200 Message-Id: <20220822184239.169757-5-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> References: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: "open list:FREESCALE SOC SOUND DRIVERS" , Kai Vehmanen , Xiubo Li , tiwai@suse.de, Shengjiu Wang , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , Nicolin Chen , broonie@kernel.org, Fabio Estevam , Chao Song , Bard Liao , open list X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" cppcheck warning: sound/soc/fsl/fsl_utils.c:127:10: style: Variable 'ret' is assigned a value that is never used. [unreadVariable] int ret = 0; ^ Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Chao Song Acked-by: Shengjiu Wang --- sound/soc/fsl/fsl_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c index d0fc430f7033d..a5ab27c2f711c 100644 --- a/sound/soc/fsl/fsl_utils.c +++ b/sound/soc/fsl/fsl_utils.c @@ -124,7 +124,7 @@ void fsl_asoc_reparent_pll_clocks(struct device *dev, struct clk *clk, { struct clk *p, *pll = NULL, *npll = NULL; bool reparent = false; - int ret = 0; + int ret; if (!clk || !pll8k_clk || !pll11k_clk) return; From patchwork Mon Aug 22 18:42:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12951086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1AE5C28D13 for ; Mon, 22 Aug 2022 18:45:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 19CB8168F; Mon, 22 Aug 2022 20:44:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 19CB8168F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1661193927; bh=ysLY52QIaymnVb5gk/TwZwHIvVe0JIPygRIZPu439/o=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CEc2u2NLxmaBsROCeSnXn50y54iz09vhbbbaEK0cWNVDpXhax9cEfi7M82x/uBFI5 sieSvfiDGL0kFQFXLl7MCVwJ/Sl++EcndvYPuLOA5VXFXMRppE4jGO+oFxUcwjfJeJ yXoIuu9TWhq68hzXnPsceAEsEUeRWqUqnsE3hMpA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C4730F80542; Mon, 22 Aug 2022 20:43:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 90EE0F8054A; Mon, 22 Aug 2022 20:43:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 072DEF80542 for ; Mon, 22 Aug 2022 20:43:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 072DEF80542 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M7plYHlP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661193804; x=1692729804; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ysLY52QIaymnVb5gk/TwZwHIvVe0JIPygRIZPu439/o=; b=M7plYHlP6qe13+zGrQL6g92iFepQZuhI5ujRHqKF5GoNP4jNNQTiNyzL pym6EnBHMQVYuoax3OeSLWmkHAN2O6CdoDVddmXYJp+6rTLD4VJ68VLHZ hT8XEs32Fy4caLQl8l9TL59VS3UPrCz/eOZRpGnvejUzLPUQdiNSFJ8ww n1hi4vXO1YC1fbEaNWamwL8Q8M5d0GYgWNTQq+dslwIWSkCVMjWAPJ9ZQ ikhhayUpqz+vvOzVC7fLAtP4Fu4kSMzkZEBqXHXSC09oiUp7ePbz6Mb9c p11OfoIoWARN78AhWSyHefhKy4GHLptSIB+wNfZCk566nRBPLdmKpGAWE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="293489010" X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="293489010" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:22 -0700 X-IronPort-AV: E=Sophos;i="5.93,255,1654585200"; d="scan'208";a="669671123" Received: from apascali-mobl2.ger.corp.intel.com (HELO pbossart-mobl3.home) ([10.252.42.21]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2022 11:43:19 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 5/5] ASoC: ti: omap-mcbsp: remove useless assignment Date: Mon, 22 Aug 2022 20:42:39 +0200 Message-Id: <20220822184239.169757-6-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> References: <20220822184239.169757-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: "open list:OMAP AUDIO SUPPORT" , open list , Kai Vehmanen , tiwai@suse.de, Peter Ujfalusi , Takashi Iwai , Pierre-Louis Bossart , Liam Girdwood , broonie@kernel.org, Chao Song , Bard Liao , Jarkko Nikula X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" sound/soc/ti/omap-mcbsp.c:617:10: style: Variable 'ret' is assigned a value that is never used. [unreadVariable] int ret = 0; ^ Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Kai Vehmanen Reviewed-by: Chao Song --- sound/soc/ti/omap-mcbsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c index 0b377bb7737fd..7c539a41a6a34 100644 --- a/sound/soc/ti/omap-mcbsp.c +++ b/sound/soc/ti/omap-mcbsp.c @@ -614,7 +614,7 @@ static int omap_mcbsp_init(struct platform_device *pdev) { struct omap_mcbsp *mcbsp = platform_get_drvdata(pdev); struct resource *res; - int ret = 0; + int ret; spin_lock_init(&mcbsp->lock); mcbsp->free = true;