From patchwork Mon Aug 29 10:08:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957632 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44141ECAAD2 for ; Mon, 29 Aug 2022 10:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbiH2KKQ (ORCPT ); Mon, 29 Aug 2022 06:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbiH2KKF (ORCPT ); Mon, 29 Aug 2022 06:10:05 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8E2E57; Mon, 29 Aug 2022 03:09:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSlRA0k+uNAL6AbqIHq+pIuBPGULvSM7cOLs7wcr87Hx+SxjE+mxRcx5zLK9a10lG6/6HafCcDsqvRBY0Ao7hi+lUefMyaU9mR99YZQBMADDik0gHYe0FraMIf0WsJdqL4YKwIZYYFh7yHPL703EeSntKxnniaextrJMbJ948RR1O0m+AsT7N6OHuzwZFTcZHjKZL+MeBDMV2kuHjLVTT/yoWu9XlKwjI53twH+lxEZF6JobCzZcjrv1kqTw32XQPUgvd52tLeQjTDyhiOmVlWlETFMyZ7OoT5FS+NVpvQsIlqMQWwkNABGE7b67HS+JPqiC4Q6dhdlzSIgCoe0W9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4XA6vdXLhGOUkb5BTwjeCIo8SWwEktYYo72tm1B6l5o=; b=OtbKASs9IMxkXb5GEgsArFrEf7EDVxPp+/80F/yL9rk641zNNuJRI+7ukLL9ByxyLnXm4+N9r/AfrWl5gZVPZF0oe4Oqiu3uz8M9gOxnzFJDRPzUy/WOJq+g7644v8di3aigDfCWBwKpiGNDAlzwcFCc+zocsdLKY7lmHtyhmBGNyfflriKD/6+OqBvH/t/wZfydwB5IZkDSQYQ+0w8u8JoxsUCgoJ81sp1wSidCuSzrwMPSY5y/+ZfRpUolK6M5db49ezVZyhik6KoxzoukId6QaG/OA5lTGU5REbrBZkQXPb7fax9RmlnnrWtaysGqBXDotYsgAdEyKwtOkxx8Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4XA6vdXLhGOUkb5BTwjeCIo8SWwEktYYo72tm1B6l5o=; b=z1/nMuNM1n9aegnaQCW8WDOhnrTXRNkl2OHKzjj8wSmpKdNXh4ve06LnDJvlJuKoLlA60e1/VvUCjwVDlDdmEMB6P9ihIF/YOCXv3W2/AZZyQ1xC2bNPNKdUGxib5Axw6VpDrTUPWxlRSHnDwMtA1vsM3WRzI2iMSkiW0i9Qzt4= Received: from MW4PR03CA0154.namprd03.prod.outlook.com (2603:10b6:303:8d::9) by DM6PR12MB2955.namprd12.prod.outlook.com (2603:10b6:5:181::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Mon, 29 Aug 2022 10:09:48 +0000 Received: from CO1PEPF00001A5F.namprd05.prod.outlook.com (2603:10b6:303:8d:cafe::65) by MW4PR03CA0154.outlook.office365.com (2603:10b6:303:8d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.18 via Frontend Transport; Mon, 29 Aug 2022 10:09:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A5F.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:09:47 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:09:32 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 1/8] x86/cpu: Add CPUID feature bit for VNMI Date: Mon, 29 Aug 2022 15:38:43 +0530 Message-ID: <20220829100850.1474-2-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c5740cb-54ae-409c-b95d-08da89a69aa7 X-MS-TrafficTypeDiagnostic: DM6PR12MB2955:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OTj3AyArotWsznZbFmyx2To/rReI6tPyMtXQCRU7PezShKux2g3wypWqoUxTp52Z3G4TfLV9u98M0w0lBwuUo+xja1/jR8omXSM9fA7R7R/IkBhtuCn//Dm/8lfbSPHovkkovcM5iqUklvTm9tcsSq1ovlrBc/DXy05OkyY+hqD5UXvAXiASRyfBdz2Q7hwN8GQrGTklk9zeCplEDHRCiiCVv6rIm7i18s/SFdG+qtwRtBDdcBs0EROPY9Ie2vRJP0WzrGBkdcCdpoZvlXvnl9tyNjNO4F8pYWndCBRe2QZ54ASPa4+o+sWYfOA/PssbuhYrSFAxehp2K76hMBdh+cldFGPD6pTRp7wGV7YdhVh5s98CpG9Oegf7j3i9SnzZuJEAE4XYYw9yWwWZs77iBNMkvYiOKENAhXZ7P8NQvWSGnPsX+wNA+RmR3nv0YAtIITItN5EEKhKXoTZ6hVEkg9cAKLJPl2cWLssnUE/6daVIjlfKrRnxub6sroUV9IydC4GYBRmPhJR7lIQsxxn3m26jQZL2esVMJWJl7h6vDZy2EuZ8sOr66AglmZj46yO5eUSAcXZxjEfSzz9GQrYx2NhJXUypH5LCq1bs0Utz4fMPFjxYe7SA1/1FPmUVphCJfHij0KEuXAvQxDoU31IAf/iHp6H/Grv6hW6qXRkQibR4oO2KP0HqzHkknaNit8rO/zwkZKlYd0X9E5baK3p+5s2rXAOI5BIPDMzXSiKsOrrELspU46xMJLiy5d0+csnpIvoHB1CPmNnZ+NNaXb+Gu5cdFnm98ztLcipcNcynilBV5d2rQc3XpI2NtmcuVmpR X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(136003)(376002)(36840700001)(40470700004)(46966006)(6666004)(86362001)(7696005)(26005)(36756003)(426003)(336012)(186003)(16526019)(2616005)(47076005)(478600001)(41300700001)(1076003)(40480700001)(40460700003)(82310400005)(8676002)(6916009)(54906003)(70586007)(70206006)(316002)(82740400003)(81166007)(356005)(8936002)(4326008)(36860700001)(44832011)(5660300002)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:09:47.6575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c5740cb-54ae-409c-b95d-08da89a69aa7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A5F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2955 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org VNMI feature allows the hypervisor to inject NMI into the guest w/o using Event injection mechanism, The benefit of using VNMI over the event Injection that does not require tracking the Guest's NMI state and intercepting the IRET for the NMI completion. VNMI achieves that by exposing 3 capability bits in VMCB intr_cntrl which helps with virtualizing NMI injection and NMI_Masking. The presence of this feature is indicated via the CPUID function 0x8000000A_EDX[25]. Reviewed-by: Maxim Levitsky Signed-off-by: Santosh Shukla Reviewed-by: Jim Mattson --- arch/x86/include/asm/cpufeatures.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index ef4775c6db01..33e3603be09e 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -356,6 +356,7 @@ #define X86_FEATURE_VGIF (15*32+16) /* Virtual GIF */ #define X86_FEATURE_X2AVIC (15*32+18) /* Virtual x2apic */ #define X86_FEATURE_V_SPEC_CTRL (15*32+20) /* Virtual SPEC_CTRL */ +#define X86_FEATURE_V_NMI (15*32+25) /* Virtual NMI */ #define X86_FEATURE_SVME_ADDR_CHK (15*32+28) /* "" SVME addr check */ /* Intel-defined CPU features, CPUID level 0x00000007:0 (ECX), word 16 */ From patchwork Mon Aug 29 10:08:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43E4ECAAD4 for ; Mon, 29 Aug 2022 10:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbiH2KKf (ORCPT ); Mon, 29 Aug 2022 06:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiH2KKK (ORCPT ); Mon, 29 Aug 2022 06:10:10 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2068.outbound.protection.outlook.com [40.107.212.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4B7663D0; Mon, 29 Aug 2022 03:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyUHgqfFSVeX1J8VC/P6BFFXB13YVHTvdXUwA7q8Hv72Gdf5gP2cCtZJD7U0/yK2oaC0Rkx9pGyNs6O23IsJS5UO030+PDr9Ct3PFZQPUpEuiEt4kdHqgvxDn6OeCHDhXg17dgR9rXUZvrIgF63NLQnHiS6zEsTkeg1lKaSWivYj+YGvM+57ADZxzkdBnDvoIXwqY0Gtbi5wa2Z24gnEuiCyXQqoP6KPG3LhFLTdDALm11Sb7HcPY33Fq8LWJpqgHT5hl1ph9NX3zvBOdBPXiCEdVxOguy10EEg/XVrxUOH/VeHQww/yjRFgBnPqiucluGCYd7ZFvZWT7yY9wF0y8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GAu3xcWGgzkvSilv3WWelZnCfuOZEVIzuB/OeMv+Zv8=; b=i0EmETw8MFCScwZyRFQqEiF6GiTo2J+wqZwiH5vGcbRruzxzLiVfqiUcOKqvOY9ZdZiYtPKEePlRt8J9F15ofZXZDdGzg8m4fPpue+kLDMTqrReI5kkycyWRga3+dU/DKrtnd+InsH9nx5nkHTQVmawSSLHv6CJ5CMOnl3MCHmbu7QFFXuzIiW9ph8vDthfWEJxOkhfwZDo6dacyMYoVPWNHfJGI9gtp17NdN+Ay+5LAvkBSfM6vU/21jzTKA8r64z5YMEVJmvKDq2ddVJkSyL4C6YmcQXUadU5TgJ8PGBARuYT3/T5VUy7tRv9Ah5U6A/NnA9W74XP/CFeVP/BM5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAu3xcWGgzkvSilv3WWelZnCfuOZEVIzuB/OeMv+Zv8=; b=tVqeiPCvaIysbzjk/gEqv/aGfVh5TVlTz6K1vx/49l910/ZF0QsHqwfSaOvWjKRfKoja4lw5FYUWAMChHCpl0sZnVI2P6M3yq143e7rwpICYIXbs37b65PCoqdMe6nZb7kO52705+d2IMBMcjoK12jQWjsZq8RHMo/RlXOJp0qU= Received: from BYAPR04CA0023.namprd04.prod.outlook.com (2603:10b6:a03:40::36) by SN7PR12MB6689.namprd12.prod.outlook.com (2603:10b6:806:273::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Mon, 29 Aug 2022 10:09:58 +0000 Received: from CO1PEPF00001A64.namprd05.prod.outlook.com (2603:10b6:a03:40:cafe::7f) by BYAPR04CA0023.outlook.office365.com (2603:10b6:a03:40::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:09:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A64.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:09:57 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:09:50 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 2/8] KVM: SVM: Add VNMI bit definition Date: Mon, 29 Aug 2022 15:38:44 +0530 Message-ID: <20220829100850.1474-3-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4bc9b0f-a117-4e11-0981-08da89a6a0b0 X-MS-TrafficTypeDiagnostic: SN7PR12MB6689:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xW496eBmalKV83pC+gpzOLMujkbN63Gk3Y8jLGxKMFJWmJWUIQWKFiPxJxoK7oS0Ju4/1/4gReIrSjmHS/fkjlhhattfLPM3AEiLWKlHl9VaVUHpKbi2KQ9eN8p35BUAPzJSei05EdAjUosBl4QTRjy8t1GPJhdUrLnfHkZwlcP9qAh8U6iPwY1UqOcma3iiJ4q51MrXNRrCUt64UrzlK8MknOihh1UwDv8X6FZhvz+EIED199gXxoMcQ8uJljRo9VGXJXCOmsDYyIqR6IDxJa57ikEGixV6nnYFo5ZlE3mzVeIAMbxx66ZEjZXudj5e4nrC1tRLhh2a7JsHP8x5LcDhpryBM64sLoHdVXQfOu7GcvDhsmphnoVLl+nDVgHM8hZgJncUxSlnMZXJqMDDYBIGmVCRO3SCA0nDA/oq34ERZXIIcBH9rzXhpTORIoL5lIBIViZmcZFS0tYnNQ4qeRm2emlgQYpBqnDjbEKyVwyqqwVPzijpautCO1XUWsxEWhvppYmtMqNTazKzF1XYDul0tZz6mTqkPyOF4gH1r5ir6cKISPMxfKjD7R7FPHINs4zumfNHCYsuHQQU73KY8KzS4NmU4sZsOGw7E+2l2rM5j8HXUhlsQ8s4EgkDHEBnuBNTRoM91reyv4HBbbVE+sc+XS27Q4OZL22vxT8SiG8wSsL6+ZPN2vSjzMCP9oSRoHekTAwnX4NvYTXoqjJ8xbpkuytnv1oFrnJkjgLePWgc6D/fWzFq/bh5tGV9KPdeszSo4ToqrpWspkH4BLuiOC+CIOIrIFyHrQkRfWaT4EWk/EZGv8M4YrwqEw6CGYaF X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(376002)(46966006)(36840700001)(40470700004)(336012)(16526019)(1076003)(47076005)(186003)(426003)(2616005)(26005)(41300700001)(6666004)(7696005)(36860700001)(44832011)(8936002)(8676002)(4326008)(40480700001)(5660300002)(82310400005)(40460700003)(2906002)(478600001)(70586007)(54906003)(70206006)(6916009)(82740400003)(316002)(356005)(81166007)(36756003)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:09:57.7939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4bc9b0f-a117-4e11-0981-08da89a6a0b0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A64.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6689 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org VNMI exposes 3 capability bits (V_NMI, V_NMI_MASK, and V_NMI_ENABLE) to virtualize NMI and NMI_MASK, Those capability bits are part of VMCB::intr_ctrl - V_NMI(11) - Indicates whether a virtual NMI is pending in the guest. V_NMI_MASK(12) - Indicates whether virtual NMI is masked in the guest. V_NMI_ENABLE(26) - Enables the NMI virtualization feature for the guest. When Hypervisor wants to inject NMI, it will set V_NMI bit, Processor will clear the V_NMI bit and Set the V_NMI_MASK which means the Guest is handling NMI, After the guest handled the NMI, The processor will clear the V_NMI_MASK on the successful completion of IRET instruction Or if VMEXIT occurs while delivering the virtual NMI. To enable the VNMI capability, Hypervisor need to program V_NMI_ENABLE bit 1. Reviewed-by: Maxim Levitsky Signed-off-by: Santosh Shukla --- arch/x86/include/asm/svm.h | 7 +++++++ arch/x86/kvm/svm/svm.c | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h index 0361626841bc..73bf97e04fe3 100644 --- a/arch/x86/include/asm/svm.h +++ b/arch/x86/include/asm/svm.h @@ -198,6 +198,13 @@ struct __attribute__ ((__packed__)) vmcb_control_area { #define X2APIC_MODE_SHIFT 30 #define X2APIC_MODE_MASK (1 << X2APIC_MODE_SHIFT) +#define V_NMI_PENDING_SHIFT 11 +#define V_NMI_PENDING (1 << V_NMI_PENDING_SHIFT) +#define V_NMI_MASK_SHIFT 12 +#define V_NMI_MASK (1 << V_NMI_MASK_SHIFT) +#define V_NMI_ENABLE_SHIFT 26 +#define V_NMI_ENABLE (1 << V_NMI_ENABLE_SHIFT) + #define LBR_CTL_ENABLE_MASK BIT_ULL(0) #define VIRTUAL_VMLOAD_VMSAVE_ENABLE_MASK BIT_ULL(1) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index f3813dbacb9f..38db96121c32 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -229,6 +229,8 @@ module_param(dump_invalid_vmcb, bool, 0644); bool intercept_smi = true; module_param(intercept_smi, bool, 0444); +bool vnmi = true; +module_param(vnmi, bool, 0444); static bool svm_gp_erratum_intercept = true; @@ -5063,6 +5065,10 @@ static __init int svm_hardware_setup(void) svm_x86_ops.vcpu_get_apicv_inhibit_reasons = NULL; } + vnmi = vnmi && boot_cpu_has(X86_FEATURE_V_NMI); + if (vnmi) + pr_info("V_NMI enabled\n"); + if (vls) { if (!npt_enabled || !boot_cpu_has(X86_FEATURE_V_VMSAVE_VMLOAD) || From patchwork Mon Aug 29 10:08:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957634 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E86E7ECAAD4 for ; Mon, 29 Aug 2022 10:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbiH2KLI (ORCPT ); Mon, 29 Aug 2022 06:11:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbiH2KKr (ORCPT ); Mon, 29 Aug 2022 06:10:47 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0F50636C; Mon, 29 Aug 2022 03:10:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xl0dm4QhrKLTopKRABFoAtmsTn6x30gAPOj0iaCaIr/UKpmxPqalAr4a/Gbw2fXB3vUzILdCd5F2OAdPS3OuR9WnuIbgWcnI1jBnQenHtbj4W7V+2i3cABTm/375HpnS1+eelRDnqRCArWha4MeoO3LhwlPcrnxN6mvaSUhXCtH7XDHzWU8bN2IFyrEA2Ny8JmqKkYFLpP1k7+dvSBmgpu38Fp09gn0ZG5QVkkb4G1dFB3dSG2CLHcE4/P9PXGMiBGrtwaIzmt9x3ROkjRlmHGUEn5uW7t2odhuEAQQ0d/vVzfoDFPXGMeFIovRHkAq9KGlcBQfHh6/rv2pL0iBjnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d4hWf2cX8HyJA6YkFBwdnL3SgpKG6/MFN+iTFTu3cas=; b=SgRBWNzYONcAm4oRTtDe7ge3aU1HfYWOE42/jWcj5GxXjTNeFwmZBIzvK02Djw3y+wFDojKouG6+DTw5S6wlgkHLvmvX8CvFwc2ySmLtIo+OtZ7psBTOaO+kCQRzSoJHsQ9DbDZm78C/2wd45VebHtGky30A/J3HBGKXR5z8GinX43OBcHUdbG4Y6vwn8VFUzzBmYmIQeiPNWSzHlUNRa83cRTLYDQlcaQoEI3Ub1FqgzH7wM2vP4jkYP2u1/Y4t9XrIPdmC13iR4NXPpPZsj8Bc18rf8A9//x6MFdsRZOuyWFQ6f3il3M18hUBEVrTG+mozUsdxRMXMXUmT79oeiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4hWf2cX8HyJA6YkFBwdnL3SgpKG6/MFN+iTFTu3cas=; b=HtSsJpuu45KE2ekyhIWdeB6MqX7f8yzbVkPPr3s6xOeOeY82BdugORkr/JvLB9b/tlaEMjrffqJMTEV/rloOKN5jOD0/w7WvJMzjmlDoZY6KsLRffwRFJYOD2gEd7OPspLaujz8udgd8VCXL5cg+4s0RxMxEfSdqm+cSH28wy+g= Received: from BYAPR04CA0026.namprd04.prod.outlook.com (2603:10b6:a03:40::39) by PH7PR12MB7113.namprd12.prod.outlook.com (2603:10b6:510:1ec::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 10:10:28 +0000 Received: from CO1PEPF00001A64.namprd05.prod.outlook.com (2603:10b6:a03:40:cafe::ec) by BYAPR04CA0026.outlook.office365.com (2603:10b6:a03:40::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:10:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A64.mail.protection.outlook.com (10.167.241.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:10:28 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:10:22 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 3/8] KVM: SVM: Add VNMI support in get/set_nmi_mask Date: Mon, 29 Aug 2022 15:38:45 +0530 Message-ID: <20220829100850.1474-4-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6cc8280b-669f-43f6-c5af-08da89a6b2e2 X-MS-TrafficTypeDiagnostic: PH7PR12MB7113:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3zfXCdNpGXmvzHtOZu+RhYXt3cXQVPxlM6a6QQvi9yvTVV+19+cSODizVk4CPFahfzuhxSvF6B+Xm9d8P3XSS21PmMVfwiBXVaRaZHC/2sz2ke8uZe4VvyYpy8mHKUAbixUNxD3egPI1QYqpgEF84udRdLKPkMkE/RnmlF8LBqh/LeLgM5jFt/KEXTii+T340BL5zHgSQ88pjwhpnTcSUlPzlgbPynGrW80K7h7Qvph50eMASk1xGsNHVti/MjN3HPlrSNCqGTqfDHOxWX43dmElODaz8doDAbkaVYhEe5VAAejUSfG9zDy492xMLNyjl+Lm0nsRv1wx4U8oPZGN+FYpb6y8fhfN765Rev5i9mNTmHa00a/r4KtFnmFo13KfJNYaN7SFR7l3bUco+zJueophnb2qGh8JXwNpvYaoeBe19WBaObWVKX6ClTqjJz68NLsZOabK3EZUl/h6SR/fIMkS+o09N5QoEq+UkxThm8qtn7FY+iPeOJjGHFTmMVEOagc1rCGeaFwXXihU7146Rtu7btU4JImVaAKv5dNE08k9+o7EE2Ny/HVVFywjFVsQHayf1qh0sb9sBKmyEde+c0pT8FporRTN2dY9PLqMA2t0JrOZUlxdovf0/zvr9tPMbO9ou1rhAAjHVmEMzpWPP/9l0l0ELImDTurDn5U2G+x7OyyfjEVEPV2NLN7ff6fdFQ75Co0c8seap4VRP3mJHy729eOlmVRPeY9zpFMxaGfdlD2Jr/4jCnxndmfToG7cPhJ+yWmrIpYAEuFjzS0wlUK8JWHqHO79fPaSgU9M7mCzWZgkzD/A9BGXmcGWEYY/ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(46966006)(36840700001)(40470700004)(83380400001)(81166007)(40460700003)(16526019)(426003)(86362001)(36860700001)(1076003)(47076005)(186003)(336012)(2616005)(356005)(44832011)(82740400003)(5660300002)(36756003)(4326008)(8676002)(70586007)(70206006)(2906002)(82310400005)(40480700001)(41300700001)(478600001)(7696005)(6666004)(26005)(54906003)(8936002)(316002)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:10:28.3254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc8280b-669f-43f6-c5af-08da89a6b2e2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A64.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7113 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org VMCB intr_ctrl bit12 (V_NMI_MASK) is set by the processor when handling NMI in guest and is cleared after the NMI is handled. Treat V_NMI_MASK as read-only in the hypervisor except for the SMM case where hypervisor before entring and after leaving SMM mode requires to set and unset V_NMI_MASK. Adding API(get_vnmi_vmcb) in order to return the correct vmcb for L1 or L2, and also API(clear/set_vnmi_mask) to clear and set mask. Signed-off-by: Santosh Shukla --- v3: * Handle SMM case * Added set/clear_vnmi_mask() API. v2: - Added get_vnmi_vmcb API to return vmcb for l1 and l2. - Use get_vnmi_vmcb to get correct vmcb in func - is_vnmi_enabled/_mask_set() - removed vnmi check from is_vnmi_enabled() func. arch/x86/kvm/svm/svm.c | 17 +++++++++++++- arch/x86/kvm/svm/svm.h | 52 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 38db96121c32..ab5df74da626 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -3621,13 +3621,28 @@ static int svm_nmi_allowed(struct kvm_vcpu *vcpu, bool for_injection) static bool svm_get_nmi_mask(struct kvm_vcpu *vcpu) { - return !!(vcpu->arch.hflags & HF_NMI_MASK); + struct vcpu_svm *svm = to_svm(vcpu); + + if (is_vnmi_enabled(svm)) + return is_vnmi_mask_set(svm); + else + return !!(vcpu->arch.hflags & HF_NMI_MASK); } static void svm_set_nmi_mask(struct kvm_vcpu *vcpu, bool masked) { struct vcpu_svm *svm = to_svm(vcpu); + if (is_vnmi_enabled(svm)) { + if (is_smm(vcpu)) { + if (masked) + set_vnmi_mask(svm); + else + clear_vnmi_mask(svm); + } + return; + } + if (masked) { vcpu->arch.hflags |= HF_NMI_MASK; if (!sev_es_guest(vcpu->kvm)) diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index 6a7686bf6900..cc98ec7bd119 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -35,6 +35,7 @@ extern u32 msrpm_offsets[MSRPM_OFFSETS] __read_mostly; extern bool npt_enabled; extern int vgif; extern bool intercept_smi; +extern bool vnmi; enum avic_modes { AVIC_MODE_NONE = 0, @@ -532,6 +533,57 @@ static inline bool is_x2apic_msrpm_offset(u32 offset) (msr < (APIC_BASE_MSR + 0x100)); } +static inline struct vmcb *get_vnmi_vmcb(struct vcpu_svm *svm) +{ + if (!vnmi) + return NULL; + + if (is_guest_mode(&svm->vcpu)) + return svm->nested.vmcb02.ptr; + else + return svm->vmcb01.ptr; +} + +static inline bool is_vnmi_enabled(struct vcpu_svm *svm) +{ + struct vmcb *vmcb = get_vnmi_vmcb(svm); + + if (vmcb) + return !!(vmcb->control.int_ctl & V_NMI_ENABLE); + else + return false; +} + +static inline bool is_vnmi_mask_set(struct vcpu_svm *svm) +{ + struct vmcb *vmcb = get_vnmi_vmcb(svm); + + if (vmcb) + return !!(vmcb->control.int_ctl & V_NMI_MASK); + else + return false; +} + +static inline void set_vnmi_mask(struct vcpu_svm *svm) +{ + struct vmcb *vmcb = get_vnmi_vmcb(svm); + + if (vmcb) + vmcb->control.int_ctl |= V_NMI_MASK; + else + svm->vcpu.arch.hflags |= HF_GIF_MASK; +} + +static inline void clear_vnmi_mask(struct vcpu_svm *svm) +{ + struct vmcb *vmcb = get_vnmi_vmcb(svm); + + if (vmcb) + vmcb->control.int_ctl &= ~V_NMI_MASK; + else + svm->vcpu.arch.hflags &= ~HF_GIF_MASK; +} + /* svm.c */ #define MSR_INVALID 0xffffffffU From patchwork Mon Aug 29 10:08:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957635 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B39ECAAD2 for ; Mon, 29 Aug 2022 10:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbiH2KLe (ORCPT ); Mon, 29 Aug 2022 06:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbiH2KLM (ORCPT ); Mon, 29 Aug 2022 06:11:12 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FD7C38BF; Mon, 29 Aug 2022 03:11:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHSotq1O+bLV50Oo5a+WkWRK0oVaHw2OhrRMWc74UltPEPQlOeO9xyXnzK+77rKzUDfT+O5Ia4DZhejRgP3g08Syyb18OTtHHgm2nwIOTT1LXW8Gld7mYPUlbNecP5AIeBBz2Y8ONJ19fLDSFLdDebcFQ6M/jHQHm6+ttRE2C17KUTt9mbT8Hhot0W50G5m8bcozYWvHW0MxV6PHO6GTc9pxlWdj2aI76wGgctxp608qibvS6qeSFo4wNZw7IXQFFdMMJWSMJJEUZujduQiGmsVm40XTnM4sluQT4XzwDFv2S/0FcnNQrVbJMFSYMEngTsts7SPB3SHEqBtM1Y2RyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2KfyleGqdFUZ726MZ1QjhVlEsBIwC4z+T2J17fH2BMA=; b=EAgRwD9EsOQJgN9DZeSqzpRF2dUg4D0NzaBiwjUaDHSEehafvS3xRmx94dDbd7xSi+gkKuq6WsUBVglgfc9KYyv20V22R+uW5cTz9wOtpR1DnTFoiUJcNBibyfpaCqLBg9eNQIuzjzC0uKWMoNOT7bfrhhIU7wT2qqeB/yyKKTlNxQFWIkWO0rt4HW1NKyntYR7/baf5lhpP00GUxRXd0f3aGqaMGmFugu12KrQGjqvh1pm0aFtsJkBYLWEN57DetxxHsl5B7rNbKBESZ7hyk4KPN2shC1gHK0MJQKXC+pqkKqxoBsULMNCc0MCdEGDr6itvtIuXpDNp2YiGrqMIAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2KfyleGqdFUZ726MZ1QjhVlEsBIwC4z+T2J17fH2BMA=; b=JSrLjRhGfLRqolojHZeM1Ft4JMK+1rAWhAfWkEm83kbktcht0i1wAEYi359mt49HmUD6tppgJYo4G7Ak1jU3nxLH4L7b0WqoA+1SeccJbXH7mdhjF3EH3YcHhipz5QDDavQ6Cy22sGJ/jGtg0aXj/9hVyq75C/SYuCuKbYiFVok= Received: from BYAPR08CA0026.namprd08.prod.outlook.com (2603:10b6:a03:100::39) by BYAPR12MB2725.namprd12.prod.outlook.com (2603:10b6:a03:6b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Mon, 29 Aug 2022 10:11:04 +0000 Received: from CO1PEPF00001A60.namprd05.prod.outlook.com (2603:10b6:a03:100:cafe::5f) by BYAPR08CA0026.outlook.office365.com (2603:10b6:a03:100::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:11:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A60.mail.protection.outlook.com (10.167.241.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:11:03 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:10:57 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 4/8] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI Date: Mon, 29 Aug 2022 15:38:46 +0530 Message-ID: <20220829100850.1474-5-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c60a389-2674-43b2-1110-08da89a6c816 X-MS-TrafficTypeDiagnostic: BYAPR12MB2725:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3zhS3u3jYA+vaJk37omofq9ZFR3DzB+21+B3QwXDmEX5ADbKAbhUy31dnQC2O9lElNEIkm1o8YTcG9CEL8jDw0rU9K4OSeaqyg4woHJtHpKqNfmRoAel70AOMfU0slSwg909ZijFxbRaqMH4fukCf0fi5m8MmyPzzEAgukjhNj/epeG//4lddHY7Rai92eCVDrXDdstPmmpWWRqnRrRqWo5pRRo3+Mfcudig4dE5lyZWNxmlZ6EN7Kg2knfn3clcX5Nvozw0d326X4rmeayV/xuwHxsmYlyivZRRaZJu6R7ufiz6xOgpsO9ZlsqfpslyltWU8KPBNaa2sSXEvkWn7m7r+9v3pEMUS5KZzxwb4at5WHvxGrSWoLwqBJVsoRLMJ6cByKso6SxDNlp4SoUCxfHWGFhgBQtkN/fQwSqNK2ZmTFXSoSY/dvBKke+7GASS5EIvqSezi6GgsyRrWR4x1z+tfcxYltuyj+2Dk/NttmGlNn7F9UnMt5L3hV5TrEWeHibOibM8tICAdSv9DFtOrJUVKbfvE5ZcgJP84AqCcpBo54dhqbuMlIYt4L/W3cDLS2jyBeNJaJ8DkJ3Hs6Ozo5kM/s2gk4YjR0rMJHKb6pR0BnG+Ie8tqWFbNBIx2GOwPHFJrbEKMIE2wwhF+wCfPlgHWuj9jDAB1FHQ4OnEDfrHWSLJaUnEAjxvcCeaV89XRPolCPs08QXPYuvj3eIuKXftt8OfgDr7Rqdnpk3eoqkSnMaNJyqDn7XY5hpps4d0UZnhdnIjWV4MBWuZ4wskTwhhgoZ6hFq3aC7Z5SgSbec= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(346002)(396003)(40470700004)(36840700001)(46966006)(86362001)(81166007)(83380400001)(426003)(186003)(336012)(2616005)(1076003)(16526019)(356005)(47076005)(36860700001)(82740400003)(40460700003)(36756003)(5660300002)(44832011)(8936002)(8676002)(4326008)(70586007)(70206006)(40480700001)(2906002)(82310400005)(26005)(6666004)(7696005)(41300700001)(6916009)(316002)(54906003)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:11:03.8780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c60a389-2674-43b2-1110-08da89a6c816 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A60.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2725 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org In the VNMI case, Report NMI is not allowed when V_NMI_PENDING is set which mean virtual NMI already pended for Guest to process while the Guest is busy handling the current virtual NMI. The Guest will first finish handling the current virtual NMI and then it will take the pended event w/o vmexit. Signed-off-by: Santosh Shukla --- v3: - Added is_vnmi_pending_set API so to check the vnmi pending state. - Replaced is_vnmi_mask_set check with is_vnmi_pending_set. v2: - Moved vnmi check after is_guest_mode() in func _nmi_blocked(). - Removed is_vnmi_mask_set check from _enable_nmi_window(). as it was a redundent check. arch/x86/kvm/svm/svm.c | 6 ++++++ arch/x86/kvm/svm/svm.h | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index ab5df74da626..810b93774a95 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -3598,6 +3598,9 @@ bool svm_nmi_blocked(struct kvm_vcpu *vcpu) if (is_guest_mode(vcpu) && nested_exit_on_nmi(svm)) return false; + if (is_vnmi_enabled(svm) && is_vnmi_pending_set(svm)) + return true; + ret = (vmcb->control.int_state & SVM_INTERRUPT_SHADOW_MASK) || (vcpu->arch.hflags & HF_NMI_MASK); @@ -3734,6 +3737,9 @@ static void svm_enable_nmi_window(struct kvm_vcpu *vcpu) { struct vcpu_svm *svm = to_svm(vcpu); + if (is_vnmi_enabled(svm) && is_vnmi_pending_set(svm)) + return; + if ((vcpu->arch.hflags & (HF_NMI_MASK | HF_IRET_MASK)) == HF_NMI_MASK) return; /* IRET will cause a vm exit */ diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index cc98ec7bd119..7857a89d0ec8 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -584,6 +584,16 @@ static inline void clear_vnmi_mask(struct vcpu_svm *svm) svm->vcpu.arch.hflags &= ~HF_GIF_MASK; } +static inline bool is_vnmi_pending_set(struct vcpu_svm *svm) +{ + struct vmcb *vmcb = get_vnmi_vmcb(svm); + + if (vmcb) + return !!(vmcb->control.int_ctl & V_NMI_PENDING); + else + return false; +} + /* svm.c */ #define MSR_INVALID 0xffffffffU From patchwork Mon Aug 29 10:08:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E3FECAAD4 for ; Mon, 29 Aug 2022 10:11:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbiH2KL4 (ORCPT ); Mon, 29 Aug 2022 06:11:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230007AbiH2KL2 (ORCPT ); Mon, 29 Aug 2022 06:11:28 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2044.outbound.protection.outlook.com [40.107.237.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60CA40542; Mon, 29 Aug 2022 03:11:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+3Usslqqc8a8iOCIM5fKAcos7DD/Y4SERfUt62Ht2Ha8xxvcv96Jbf8RWdNHcSfbIp0Ffl63T0aErocMLmvvKt1wg1CvR7Xqm9iTP4AlxuTADNPqgRnyF166oRu/xQAitVo+mjIHRv0gJuoget1to00+2kdQ7hTGmTyatUDz5MEutnPaSG70msAcI+Ci6Wp9paoVru/ePfkWkEP3EETVI2+ae8NvUkywU2KtTvLuUcTihJNhKBqSwwGH7DjQBQfj9veSk21qniRNkiUne1ZAP/UO39ziiwaa2qPq42fWH5+9Utm5zw0+igjn3z9WRNdCfOtSYQ7p4+rVwVGo69Wuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4xbR2snkxD9XJ0q1wpI7kLCfpKJrBJZjTVBPRAUibyw=; b=kem26Q7+fA1ufSEfDpSx1UhLbfpnM81cRgQbLV8nV1nfbkslzRY3Iz8jD2V3CZPhjZnEUaJuuiPaK4vRiyoF3UWB0neK6r0ARNgU/QAVnE+biFBEbLqcCqI6cijyr4Zzc0idnUAtOyIhC59eM9F3I68F61LFW8vfojjEBYpptEGmfQTqeSmVXuFn6kyHrc/00hIaqONKCD801JyvQMXJikWPaWyy7m2eZDKBPaTeEyT1ANaMXU131cG/jCty1/CUYXDT+KTB3u0PkuKk+f6+ltIldlZpWjltYWJi+WDLd5d+nKFRGMnGu4aN10WoQCJqghkuKtVTDTVmkS9swGBzOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4xbR2snkxD9XJ0q1wpI7kLCfpKJrBJZjTVBPRAUibyw=; b=qBtJLGW5vPt/nkMdHMSTWyvuWbnrrou6boNh/JI9OJHc+p7cu3su+ri0F4yNGNpRdNabq5d1ajXAYtb1a67DjJPRKC9eJWBAAcIR8cKkEC92u1zkJDwNjNSxnlNrvvxKf+g0skOz5Cq6kiNLr/uMfIgZcvKtwykxWJorA/7mxVw= Received: from MW4PR03CA0198.namprd03.prod.outlook.com (2603:10b6:303:b8::23) by DM5PR12MB2342.namprd12.prod.outlook.com (2603:10b6:4:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 10:11:21 +0000 Received: from CO1PEPF00001A5D.namprd05.prod.outlook.com (2603:10b6:303:b8::4) by MW4PR03CA0198.outlook.office365.com (2603:10b6:303:b8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:11:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A5D.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:11:20 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:11:15 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 5/8] KVM: SVM: Add VNMI support in inject_nmi Date: Mon, 29 Aug 2022 15:38:47 +0530 Message-ID: <20220829100850.1474-6-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b004503-0ec5-4428-6f8d-08da89a6d22c X-MS-TrafficTypeDiagnostic: DM5PR12MB2342:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fUrPyb8Eyu+b3BWNk3rrx/9JdEyMLV+Xqgvgg3WG5+9nt/aZdPtsGT56yt0KxI0UlNoVQjgyvAaHphkBXlL7Lcpmiz2x0+BI2pWU4c/6EAdKZ9hSECOBNkGHV1AJ73/c2gtH1FGfLdsAyrtvVXhhp115zIKMczFANeI2koGg9hWTgWNKUUKJbqlZZFGMtNBgQ6yJ9R2AXf6f8cdYmEmXAzoBgVp/TYuUcGIB+pbuI0OgQfdDYo2A7r8jKBhzC6qHf73iKgfktjyJaxXf0zw7P8Lpt03V3UjPsYasRFba4AaUamepA/b0JsbHZw9gvHVsGcLHcNiunTw9SbLooz999Vh+78dICQRn58oGAO8a19u7pJ1pRfPOOeIHnBJd9+o3Bj38TsuzGN+qQ7w2ukxY+O+ZJ36gY1Hh4Wfx21yUC4vid59h4z/pojOtfltMOLYEHdK1OkEZMsLhUMJT68cV2erwNZ+kuSaausIzGWiui2Nd8uAoOBukaUiCzUj38+cglAZ2jW2fsHML5BUdgLwjzBwlCiByEcSYdQc6/MwTJ698a1vi274T3h2+lPglwuZig3EZ0oIpSGoXzrH+pPRcQRA1hL/Vu+RTb5lpEgz/OE+ezEsZ6TsHf3wttIGIgvoy9jPX8HeXRsB4TZvNWOO8TbBNMx5tgQczMwJapNBFjPsi5afWUcWF4LQmfcEoGM7kKtasK7dKBVG7Frfqten474oVWWn7t1qmuhGGsLkti3RpZglEv/E/ViFK4Tzw94x6TzfTJ2OXOeI2BWquerdAKcMs+HAQ+B9RrSqTv6dxstRSMwDvmkA9U4ShURqjkwYn5WB1CY+xNWbu78w8Iy0sCg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(346002)(396003)(40470700004)(46966006)(36840700001)(8676002)(4326008)(316002)(6916009)(966005)(70206006)(70586007)(36756003)(86362001)(5660300002)(8936002)(54906003)(478600001)(41300700001)(81166007)(356005)(26005)(82310400005)(2616005)(2906002)(44832011)(6666004)(82740400003)(36860700001)(47076005)(40460700003)(336012)(16526019)(40480700001)(7696005)(426003)(186003)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:11:20.8175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b004503-0ec5-4428-6f8d-08da89a6d22c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A5D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2342 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Inject the NMI by setting V_NMI in the VMCB interrupt control. processor will clear V_NMI to acknowledge processing has started and will keep the V_NMI_MASK set until the processor is done with processing the NMI event. Also, handle the nmi_l1_to_l2 case such that when it is true then NMI to be injected originally comes from L1's VMCB12 EVENTINJ field. So adding a check for that case. Signed-off-by: Santosh Shukla --- v4: - Added `nmi_l1_to_l2` check, discussion thread https://lore.kernel.org/all/bf9e8a9c-5172-b61a-be6e-87a919442fbd@maciej.szmigiero.name/ v3: - Removed WARN_ON check. v2: - Added WARN_ON check for vnmi pending. - use `get_vnmi_vmcb` to get correct vmcb so to inject vnmi. arch/x86/kvm/svm/svm.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 810b93774a95..4aa7606a9aa2 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -3479,7 +3479,14 @@ static void pre_svm_run(struct kvm_vcpu *vcpu) static void svm_inject_nmi(struct kvm_vcpu *vcpu) { struct vcpu_svm *svm = to_svm(vcpu); + struct vmcb *vmcb = NULL; + if (is_vnmi_enabled(svm) && !svm->nmi_l1_to_l2) { + vmcb = get_vnmi_vmcb(svm); + vmcb->control.int_ctl |= V_NMI_PENDING; + ++vcpu->stat.nmi_injections; + return; + } svm->vmcb->control.event_inj = SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_NMI; if (svm->nmi_l1_to_l2) From patchwork Mon Aug 29 10:08:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB7CECAAD2 for ; Mon, 29 Aug 2022 10:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiH2KMW (ORCPT ); Mon, 29 Aug 2022 06:12:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbiH2KMA (ORCPT ); Mon, 29 Aug 2022 06:12:00 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2049.outbound.protection.outlook.com [40.107.101.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01FCB7EB; Mon, 29 Aug 2022 03:11:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFeEPcpPSGX02bPuM7MQy5pVgs1lvULxVMB7zIm2JnfmABGm1zpH80pzL89swCFmrJWTCvRpsahGn6UZOlRH1Nb0po96A082bJ9x0XnfF8RG98R1mhH+VuBlxQJJ7Rt4UhHClBp3RNAO/fwM5Ig5KDwD9GFNM7/x7+REtG0sLrOY1BgkYEdNtAOso53Vx7qyXvtRLgeCCYdphl2P4mIdW4Ebjq3XDdTDUvAlU+Eiu82Ds3v7+qtMnTFKWhRmPew3v7/2rI6nQZQUj+Qo+1DPPIlcyBV7sMduXTHDCZxngNu65U15k3mWfBaxIhAZk39ePU9ObSGWjvC1WMvGhyUalA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSvewsmvxCcTYLNh2jK4uUBqj+oiabAnv54l8AY76T4=; b=KyKKyvKxAD7McbjzYVBSDDAlbXPAfzyY7EjvfuRkVemz/v+p50pMQi1PMXKEcfgK5tNSI+BXonE0lJPLnZ3KzZAYI7JVz/c9wXVPfHCLtW/3DSid2YNsKGCJCyS/lH2GwJ0xT8xs3VI2zY2YPT3TmEEMTNLfBMHIj7l8HQsSzJjTels8Cs8t3Kk3qzkKe+TiSTUpHKQ0DxiK+pV9VcYolRYIZdC+mIBbfWzpnQOqhfb5jOlfqWqC7A6dcABt2rok7I6oL6UjseVUxZYtfkP0ScYusUkDSLUfUZnmJr62G4TF8oYs0mt9vvfDgKEN0CALkW8TsvUHgrkagNHbsg38XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSvewsmvxCcTYLNh2jK4uUBqj+oiabAnv54l8AY76T4=; b=D3Mc8vbhpMsqZ6lJeSBigi784b92DEHz7a0rNTHKt+5bko0kCfg3yjnZvLgsdaOjg/BinRBLroSQzatkNTYYGPAivv0hKkz3JhPlbEzrSHRS25xHiTzu7kVUG/fMABwh0SBFl5DmEY6jdmkMxMDDJkwlHtUFRmBiD/0g0FfJ23Y= Received: from MW4PR03CA0179.namprd03.prod.outlook.com (2603:10b6:303:8d::34) by DM6PR12MB2956.namprd12.prod.outlook.com (2603:10b6:5:182::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.19; Mon, 29 Aug 2022 10:11:51 +0000 Received: from CO1PEPF00001A5F.namprd05.prod.outlook.com (2603:10b6:303:8d:cafe::62) by MW4PR03CA0179.outlook.office365.com (2603:10b6:303:8d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16 via Frontend Transport; Mon, 29 Aug 2022 10:11:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A5F.mail.protection.outlook.com (10.167.241.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.7 via Frontend Transport; Mon, 29 Aug 2022 10:11:50 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:11:37 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 6/8] KVM: nSVM: implement nested VNMI Date: Mon, 29 Aug 2022 15:38:48 +0530 Message-ID: <20220829100850.1474-7-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ed155cb3-400a-4852-5b14-08da89a6e423 X-MS-TrafficTypeDiagnostic: DM6PR12MB2956:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2waBXnPfDzBiawQDhoxTIuBrMBtoC+i95/0/p87dxCS2Lu/IAqKqlb9bJv/tUEQpouP0ImHiLkm8UzipeqxfBM6+PFa7lmVGZVxKPNEh3tKzO+9IkscyMKHCPSuMBziI9seuP2CDy4zJzuv0etSGHR+7eXEF8zXzZj+TZs6jjEzDY8i2sSr70sRUA0K3mHW4KGfBJri2e7APqQ69N9Kp9kDCyrJnI65kJtD5fyYAWsda1qR6cfjqFRYedjna9S3gmEmoyiaIme5+tjsJUA6xUTsECLESFamPw4FTxhBmwZVRzSeY8PWKioPbpeli+hhJzsKC84FT7iB/2zYdsLfkOKGfJRqL1TVmZMLmfu13eBFjVtW04s5iVenztX9cjRVRrWkE+R6R7Aw+OTklfAkNsOaA8OtEVnAUkmzNq31FGF302tBBaR8msvFrWHxbETSlwXcIgR5TRxRDO5/Kk8FsEljDzIwqip2M6F2IgVqQZD+LYV2yBLKSjR3v5LwHmYMqe+IVYaYzorGpmOEv/33lDw8w86vHTkZLqI9PQUSZzFqwVxZoZVSnJ6RVG9hjnqCg5mQud3eUFcNWgkekN2wYjrkJEOYnKQYbTfbH3rt6KMRNgkk1sv2ysIQobMnmE77wI8aGBM9TlbViRKHmpRUjPGuu+id1zqeUpY2ahlxMbg8viEFN+i3kbS8X239dN4My4X7LzekXjx0BDeY5GWJAGl/pKgWAhBVWfPkpBhFANfMCwW7aPE6IL9tcLotEfq8gwXxUPKHJYcJrsyrca0MV2rONrn8H1X04eQBQLdSyffg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966006)(36840700001)(40470700004)(40480700001)(2906002)(82310400005)(4326008)(8676002)(70206006)(70586007)(8936002)(7696005)(6666004)(26005)(316002)(6916009)(54906003)(41300700001)(478600001)(426003)(2616005)(336012)(186003)(47076005)(36860700001)(40460700003)(356005)(16526019)(1076003)(81166007)(83380400001)(36756003)(82740400003)(5660300002)(44832011)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:11:50.9569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed155cb3-400a-4852-5b14-08da89a6e423 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A5F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2956 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org In order to support nested VNMI requires saving and restoring the VNMI bits during nested entry and exit. In case of L1 and L2 both using VNMI- Copy VNMI bits from vmcb12 to vmcb02 during entry and vice-versa during exit. And in case of L1 uses VNMI and L2 doesn't- Copy VNMI bits from vmcb01 to vmcb02 during entry and vice-versa during exit. Tested with the KVM-unit-test and Nested Guest scenario. Signed-off-by: Santosh Shukla --- v3: - Added code to save and restore VNMI bit for L1 using vnmi and L2 doesn't for the entry and exit case. v2: - Save the V_NMI_PENDING/MASK state in vmcb12 on vmexit. - Tested nested environment - L1 injecting vnmi to L2. - Tested vnmi in kvm-unit-test. arch/x86/kvm/svm/nested.c | 27 +++++++++++++++++++++++++++ arch/x86/kvm/svm/svm.c | 5 +++++ arch/x86/kvm/svm/svm.h | 6 ++++++ 3 files changed, 38 insertions(+) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index 76dcc8a3e849..3d986ec83147 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -662,6 +662,11 @@ static void nested_vmcb02_prepare_control(struct vcpu_svm *svm, else int_ctl_vmcb01_bits |= (V_GIF_MASK | V_GIF_ENABLE_MASK); + if (nested_vnmi_enabled(svm)) + int_ctl_vmcb12_bits |= (V_NMI_PENDING | V_NMI_ENABLE | V_NMI_MASK); + else + int_ctl_vmcb01_bits |= (V_NMI_PENDING | V_NMI_ENABLE | V_NMI_MASK); + /* Copied from vmcb01. msrpm_base can be overwritten later. */ vmcb02->control.nested_ctl = vmcb01->control.nested_ctl; vmcb02->control.iopm_base_pa = vmcb01->control.iopm_base_pa; @@ -1010,6 +1015,28 @@ int nested_svm_vmexit(struct vcpu_svm *svm) vmcb12->control.event_inj = svm->nested.ctl.event_inj; vmcb12->control.event_inj_err = svm->nested.ctl.event_inj_err; + if (nested_vnmi_enabled(svm)) { + if (vmcb02->control.int_ctl & V_NMI_MASK) + vmcb12->control.int_ctl |= V_NMI_MASK; + else + vmcb12->control.int_ctl &= ~V_NMI_MASK; + + if (vmcb02->control.int_ctl & V_NMI_PENDING) + vmcb12->control.int_ctl |= V_NMI_PENDING; + else + vmcb12->control.int_ctl &= ~V_NMI_PENDING; + } else { + if (vmcb02->control.int_ctl & V_NMI_MASK) + vmcb01->control.int_ctl |= V_NMI_MASK; + else + vmcb01->control.int_ctl &= ~V_NMI_MASK; + + if (vmcb02->control.int_ctl & V_NMI_PENDING) + vmcb01->control.int_ctl |= V_NMI_PENDING; + else + vmcb01->control.int_ctl &= ~V_NMI_PENDING; + } + if (!kvm_pause_in_guest(vcpu->kvm)) { vmcb01->control.pause_filter_count = vmcb02->control.pause_filter_count; vmcb_mark_dirty(vmcb01, VMCB_INTERCEPTS); diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 4aa7606a9aa2..2e50a7ab32db 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -4217,6 +4217,8 @@ static void svm_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu) svm->vgif_enabled = vgif && guest_cpuid_has(vcpu, X86_FEATURE_VGIF); + svm->vnmi_enabled = vnmi && guest_cpuid_has(vcpu, X86_FEATURE_V_NMI); + svm_recalc_instruction_intercepts(vcpu, svm); /* For sev guests, the memory encryption bit is not reserved in CR3. */ @@ -4967,6 +4969,9 @@ static __init void svm_set_cpu_caps(void) if (vgif) kvm_cpu_cap_set(X86_FEATURE_VGIF); + if (vnmi) + kvm_cpu_cap_set(X86_FEATURE_V_NMI); + /* Nested VM can receive #VMEXIT instead of triggering #GP */ kvm_cpu_cap_set(X86_FEATURE_SVME_ADDR_CHK); } diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h index 7857a89d0ec8..4d6245ef5b6c 100644 --- a/arch/x86/kvm/svm/svm.h +++ b/arch/x86/kvm/svm/svm.h @@ -253,6 +253,7 @@ struct vcpu_svm { bool pause_filter_enabled : 1; bool pause_threshold_enabled : 1; bool vgif_enabled : 1; + bool vnmi_enabled : 1; u32 ldr_reg; u32 dfr_reg; @@ -533,6 +534,11 @@ static inline bool is_x2apic_msrpm_offset(u32 offset) (msr < (APIC_BASE_MSR + 0x100)); } +static inline bool nested_vnmi_enabled(struct vcpu_svm *svm) +{ + return svm->vnmi_enabled && (svm->nested.ctl.int_ctl & V_NMI_ENABLE); +} + static inline struct vmcb *get_vnmi_vmcb(struct vcpu_svm *svm) { if (!vnmi) From patchwork Mon Aug 29 10:08:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74805ECAAD4 for ; Mon, 29 Aug 2022 10:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbiH2KMs (ORCPT ); Mon, 29 Aug 2022 06:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiH2KMY (ORCPT ); Mon, 29 Aug 2022 06:12:24 -0400 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2083.outbound.protection.outlook.com [40.107.102.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6151E4E84B; Mon, 29 Aug 2022 03:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqlFirZwcyh//hlYfbywXXIOsRngDNX5lvGN2Ctoqz3qTLPXN/5z1zJiMcNb7/3cF3Hnp4J7gM/3gLNNQryqBVGCvXXrSgihm/n0ZgV/kgBymtgv0o7VQEHidL2aYgv5ruRTPrqRHW7xb6p4iJCC+PBZLfTW8/WRFex5dG5CX79rg9PjLZotgqzxZBc1wNQPMtowgE2FWm1SgclT2dchA7GkTPQqfRJgLHqGODmojZOuvFrF8o8FiTana0pFPvTBnh15Fns7RutbhsRWRrYjliaCq6BwW+yAFaBPCho9IqAlxylIKVu1gSFOWhVsRuvrPDh+GsCTP8BdBNAzJMSSVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=av/DJE8D6kP2/Aub97o2cS1hU4kJbUl90ppjiJRXwhk=; b=W/HEtwDxpVrmpPl1IM5E6XfkQ+3VuG6s4UwP9SylZz/ApzvGw7dbNTDXrK7w1RwMTMU16UgAbq1oHTD7gBbRwoOQHTomBmr1P+75SIL3oTcrrZ7aeDXH8dQGEjXaREGjWmSY5l2T8wMyJs5mqWj21B8dq+inUooIycXxnB1wYWL63f7DOQY1KPDVn2hfXXIV2q1RX/3yDsf2y0OVguaHQQ55BdYMfLtPern799bVk/aMJPOiJLwwRF/oMYgG0V1JFnx/5gtt15dk1HF8b19PctiSCGTWEgVmKgjmXC+Mh1XIqBBTzQE7WBQdKpbxIW+UzqIWWWVQCGChfLQ24xdSgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=av/DJE8D6kP2/Aub97o2cS1hU4kJbUl90ppjiJRXwhk=; b=lXxI+CClxWcTTZv/e7z39VyG7ZO8YpYfv4OtXsSGmRHD18SAHeR9OaSfJhfbFZ6LB51dvqiOUKegLVThNNKft9uY4tTsIyHJ+tLDi1f/hYTvQcfkadFT/rt9t0EOZJSTe4Gsiz3BDiPMBaFQFMfc/elcJr2yRuM+kV+5nlS7ZaU= Received: from MW4PR04CA0176.namprd04.prod.outlook.com (2603:10b6:303:85::31) by BN8PR12MB3635.namprd12.prod.outlook.com (2603:10b6:408:46::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 10:12:16 +0000 Received: from CO1NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:303:85:cafe::e9) by MW4PR04CA0176.outlook.office365.com (2603:10b6:303:85::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16 via Frontend Transport; Mon, 29 Aug 2022 10:12:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT018.mail.protection.outlook.com (10.13.175.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:12:15 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:12:10 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 7/8] KVM: nSVM: emulate VMEXIT_INVALID case for nested VNMI Date: Mon, 29 Aug 2022 15:38:49 +0530 Message-ID: <20220829100850.1474-8-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6575e4d8-b06b-4126-a767-08da89a6f2b2 X-MS-TrafficTypeDiagnostic: BN8PR12MB3635:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q2Hz7Cum2+XKFlcgd/0RJB2Vi+Dk3QS5+N6L53Ajj8l1pZCf1MG6/LEyYiLxGiOd6PIuL0Mwtqz/NEUyEYm+Xa5NCiRk4SWqCxa9XlqGJ3A2pVi0uuBKbft6FAtbJqGK9wholpq6BYzOL7HJ24goS4lvAnx3D0eej10kc3i4c4jSTFrK+sfIxM/9JlLAPcbSzN6FFItnNnQdqJdGXUDUAZ8w/uVBgFgtzOdTeeJVDfr0sAg2sxQTFAiT4YlAsbJoLHDyA6vS8leOtO/shZQ64BgQ68mxRXnhUk/kECjNZHeUd7bhMNFPrjNoQp0IWkTiDhBYMOwpPTOXwIxQhIELhdd3aNeZM9UjJhovyhQ1KyJm8/QGdmKGB/XehOHWYFCRCzMlyd1VlXIeze3YbkZ0J9Gi//tSTnY57KWQPhr8DcVuamV80mtWTnPRiH/72+vOX+shd5kpSkGkBi3dceJmhs/ctPEQ5IckX6xXKh2GQDowKDRbSr71Rw/sugFAw0Dwkqma9G/ldG/dfuAXJAr+hU2BWm2KlxBabYYU66OR/z2vY1UHe+fJI6WvzmlFPZAEWB8M3alq0ZpYtrvDJY12BlKlugqoBZF7NoE4fdfndJ/bp9qtX8zDgetqOSdJBX4XV9vMV9Tjl7hcDskc2bcH948IsT7fXNlNh8AkV+u6/bTWUCAFff0xgaxRQf63kMyqL9BFXfc8/q0oqetXP0n7LUzw2CLMDbsJC49jR/6k18NH219pWz/nOYr2o5+TlCSndv/V5/WjBGZeRrtjEv/VVz/+FsagB2eb9KrncaVnfSuY0apluGw39cXFKtvV2PrC X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(376002)(396003)(36840700001)(46966006)(40470700004)(1076003)(316002)(81166007)(6916009)(40460700003)(8676002)(70206006)(86362001)(4326008)(70586007)(54906003)(478600001)(356005)(36756003)(8936002)(41300700001)(5660300002)(4744005)(44832011)(6666004)(82740400003)(2616005)(82310400005)(7696005)(2906002)(36860700001)(426003)(16526019)(47076005)(336012)(40480700001)(83380400001)(26005)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:12:15.3842 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6575e4d8-b06b-4126-a767-08da89a6f2b2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3635 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org If NMI virtualization enabled and NMI_INTERCEPT is unset then next vm entry will exit with #INVALID exit reason. In order to emulate above (VMEXIT(#INVALID)) scenario for nested environment, extending check for V_NMI_ENABLE, NMI_INTERCEPT bit in func __nested_vmcb_check_controls. Signed-off-by: Santosh Shukla --- arch/x86/kvm/svm/nested.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index 3d986ec83147..9d031fadcd67 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -296,6 +296,11 @@ static bool __nested_vmcb_check_controls(struct kvm_vcpu *vcpu, if (CC(!nested_svm_check_tlb_ctl(vcpu, control->tlb_ctl))) return false; + if (CC((control->int_ctl & V_NMI_ENABLE) && + !vmcb12_is_intercept(control, INTERCEPT_NMI))) { + return false; + } + return true; } From patchwork Mon Aug 29 10:08:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 12957642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3857ECAAD2 for ; Mon, 29 Aug 2022 10:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiH2KNR (ORCPT ); Mon, 29 Aug 2022 06:13:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbiH2KMw (ORCPT ); Mon, 29 Aug 2022 06:12:52 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2083.outbound.protection.outlook.com [40.107.220.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A63560683; Mon, 29 Aug 2022 03:12:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwSF41Z6EOScUNvJL77uqGyFspbLr17yuK3kyxnmrkfepqUo4ZGa9PwKkrceSkHKSbuOdRAHaZFl0KYLZGnvrsBV75RZzNBV1fAzPszEKWfBcAWXBRT4+Dc6Gbe91JolRdM5vF2uBz3KAW/kHZGMaRY7+ckBXXVRx/fRE+foXz8cqleTDZYQE5NHLwZs2sTk+KPVVmc6+GmidVMhOWbDWss5URqBCWInEbxLmX/DZG6zi+InEW/6ajmiUzuN2sw1zYMIpq6VvWO9BKCrJxhz2rZ3kHGaeBq18qe8GB2A8ZrQbCBERg/WUtdVyBcNOinomO3E4j8nNRHw+znKIbFksA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6EZG/lz1SUy56FBbUHo27pkj4aikMggVHur0m7qvhnw=; b=eIk46hUOohYANPVhCAWzjF3VqwnSn5a5wLq0vKoRCRKEbvaaYLojt7FmUkIiqRZcvRMLYJdZ/WXoktvYiHEI7IBntLT/p3cm+u8p8/JzlMsH3uzHWj3Aj/K6Zu9RO4+DBBUuCQnjjvS0M75eu5pi3GcLcEsCAaRBzq/WucOUhKfePuWVrQehuXh5f6AEIDUHPAfYePwUHb+nVkHx7MIcorEF2I9BFez/BbkYSyxh2kv93ZLJGbEC8mcYifbDxQ9DKETcide0wOXhFJ3X71rfwLFccxtQoFjpR/nZGzqBpxm5UFTepMXNLYVadLWY5nKXF+e4AYSH7UsE/1XqQnmQXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6EZG/lz1SUy56FBbUHo27pkj4aikMggVHur0m7qvhnw=; b=42lLqhGUiibh/IZSKl0XI/9iMyM/07j7bUjig+lMbUNHJRBPasmbyfxD562jfZOyOKq/OC9tBGWo3oQTmpOww3xlBCEOBPdqEHGLX4vG0LE+w6v6Es+rExaiaQcaXRsDy+lh1GOJ1RTbudVrIzx9H6pATAbmsum1CilKjRGuTnc= Received: from MW4PR04CA0259.namprd04.prod.outlook.com (2603:10b6:303:88::24) by BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 10:12:34 +0000 Received: from CO1NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::ca) by MW4PR04CA0259.outlook.office365.com (2603:10b6:303:88::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Mon, 29 Aug 2022 10:12:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT061.mail.protection.outlook.com (10.13.175.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Mon, 29 Aug 2022 10:12:34 +0000 Received: from BLR-5CG113396M.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 29 Aug 2022 05:12:28 -0500 From: Santosh Shukla To: Paolo Bonzini CC: Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , Tom Lendacky , , , , , Subject: [PATCHv4 8/8] KVM: SVM: Enable VNMI feature Date: Mon, 29 Aug 2022 15:38:50 +0530 Message-ID: <20220829100850.1474-9-santosh.shukla@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220829100850.1474-1-santosh.shukla@amd.com> References: <20220829100850.1474-1-santosh.shukla@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df736ec9-864d-4474-a0f5-08da89a6fdf8 X-MS-TrafficTypeDiagnostic: BN8PR12MB3587:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gKVEjZ6wzsETItt+MGa6sEH7ST+TtL/SqjingZc7A1ITc2seBXJvcUl+MdxMisd7gR19C3KMA/vMUorybc2/BwL23+FLdtucXSh66mpL6tHcBj2QAaeLprBmPVuxPjVp0MtpuvWYgdT9o1uMOzxPFq2CHUA2PGT5EvU9E8rc9KkCWwBmucqA4M9qbj8I9dgUjVIcCjBv/QXJ+JVYmWNlF2gqvXaHurotaQ0BLt9tE406wXZlxHPpl6TanYKKDfGQbCMR1FrpuBbU0Rxdx0OGSNv264jQJ9farcDHwxXodXfYLRqZMcgvT7GB5eWx5dHHHODF6wlTZyZrTea0e6DST51PX4VPhJY349t1fVnCgSKZ0eeiFCPVpI5oP4M90FFWUdI/t9WNxW/aQ4UG8eY8pz3WwOdqC8pJqhPAgtRtLtqaqx+Xknfh2+ZEDTk8F3I9aQlpKzeJq94or8hC+BTc0nWOHzF2EXd+wMCpKrZKwohvYIO8a8cEbHDBwGEE/cQdLddGQ6MtWpfHpDjz+3823lrwBiB+eLzKBCD2VYU6mh3XoD7cS/KyIZ7BIbgr+IwXJONpItX82U2oobsEIx/streStD6aLCvarRKkaNawZe3R6bOcPipem63IWAxaiqEuhvvWnipMq+p7GZFmLFBaaLmv3oCtHIekinf+kCoG5cWLd76bPfzVv1AxQkwstHg3TNkad+8PDpAGMyp+9S+GzaOcWqWDux+LQOFSF9vrv21VXkH8YH4HXEogXIYXDkq6Pi1VkoB+MH8gGJbqWPdthCJ6ar/8dd5453bylq44YXJCeDnTX2oxfIJeMv7nxQbY X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(39860400002)(46966006)(36840700001)(40470700004)(81166007)(40460700003)(16526019)(86362001)(36860700001)(1076003)(47076005)(186003)(426003)(336012)(2616005)(356005)(44832011)(82740400003)(5660300002)(36756003)(4326008)(8676002)(70586007)(70206006)(2906002)(82310400005)(40480700001)(41300700001)(478600001)(7696005)(8936002)(4744005)(6666004)(26005)(54906003)(316002)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 10:12:34.2977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df736ec9-864d-4474-a0f5-08da89a6fdf8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3587 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Enable the NMI virtualization (V_NMI_ENABLE) in the VMCB interrupt control when the vnmi module parameter is set. Signed-off-by: Santosh Shukla --- arch/x86/kvm/svm/svm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 2e50a7ab32db..cb1ad6c6d377 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -1309,6 +1309,9 @@ static void init_vmcb(struct kvm_vcpu *vcpu) if (kvm_vcpu_apicv_active(vcpu)) avic_init_vmcb(svm, vmcb); + if (vnmi) + svm->vmcb->control.int_ctl |= V_NMI_ENABLE; + if (vgif) { svm_clr_intercept(svm, INTERCEPT_STGI); svm_clr_intercept(svm, INTERCEPT_CLGI);