From patchwork Thu Sep 1 04:42:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 12961746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E850ECAAD8 for ; Thu, 1 Sep 2022 04:43:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 884378D0002; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A9E6B0073; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7496C8D0003; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 63E268D0002 for ; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3BDBCA01D2 for ; Thu, 1 Sep 2022 04:42:58 +0000 (UTC) X-FDA: 79862271636.12.0385285 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id D3A2540052 for ; Thu, 1 Sep 2022 04:42:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7C8CA221E1; Thu, 1 Sep 2022 04:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662007376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOrpVxoLkMuflgUaHdVwwjK9xZD6TEf1SyG3O69U9sM=; b=oqUP1He733QNLVLXx7ZWAPtgoRicZnRMKKIqn8PvRcZFqUMfNU+jubRai5zZXdbSjGZfB2 tKE3euSDQAC6MFj2MJXx5k6xZSq1IAA2fL0ZIZZsqjYwbGO3vlnds8nEelP7CxpLh+NQYZ o3Ilo8vI2yNYqqnLcy6r/u3kaQL7ueA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662007376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kOrpVxoLkMuflgUaHdVwwjK9xZD6TEf1SyG3O69U9sM=; b=JHXCx1XeJ41HxPNZTsatF5O2LGA8NRw2HNBLQSosOcF4hihZSq3/QPnWCCbEBPm7bBx6OP zbzHRN1kgE6rixCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E7CBD139C4; Thu, 1 Sep 2022 04:42:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +GvANU84EGPheAAAMHmgww (envelope-from ); Thu, 01 Sep 2022 04:42:55 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Oscar Salvador Subject: [PATCH 1/3] lib/stackdepot: Add a refcount field in stack_record Date: Thu, 1 Sep 2022 06:42:47 +0200 Message-Id: <20220901044249.4624-2-osalvador@suse.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220901044249.4624-1-osalvador@suse.de> References: <20220901044249.4624-1-osalvador@suse.de> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662007377; a=rsa-sha256; cv=none; b=LZmire8lNa4cF07elFiaMvSvCiSfOGJpW5SsnsYQ0qDBdeWAXv/nyUF3tWTAHoaYRCrF8l 8oPUEt/A6wLo8Y0j2uqEASY0r498c5/4onAY9CIQgtfXh4xhtfpt2+Ri6oODezoPsmPgzY scgjOhzNapl6Zw94DHzkiifmNQvkoa4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oqUP1He7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JHXCx1Xe; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662007377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kOrpVxoLkMuflgUaHdVwwjK9xZD6TEf1SyG3O69U9sM=; b=UiP6wVNRbnetkuz+ggj4Q1qnSYOWrNRrqetI6ebF532dwdaiUmL6fNBcWFNxKNDVbonc4M uG0teRmlCnVnyi/y+F6pJcSnxvQKxMcc83lfMtW66yKCVDnIYTp9jyA5C/XacTh1cO72oS HvZCVsLD8UG5J9evNKxEbfimOqV++1I= X-Stat-Signature: hya97xukdq3dn1u1kusgrwfbqn9pdsbs X-Rspamd-Queue-Id: D3A2540052 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oqUP1He7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JHXCx1Xe; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1662007377-806559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We want to filter out page_owner output and print only those stacks that have been repeated beyond a certain threshold. This gives us the chance to get rid of a lot of noise. In order to do that, we need to keep track of how many repeated stacks (for allocation) do we have, so we add a new refcount_t field in the stack_record struct. Note that on __set_page_owner_handle(), page_owner->handle is set, and on __reset_page_owner(), page_owner->free_handle is set. We are interested in page_owner->handle, so when __set_page_owner() gets called, we derive the stack_record struct from page_owner->handle, and we increment its refcount_t field; and when __reset_page_owner() gets called, we derive its stack_record from page_owner->handle() and we decrement its refcount_t field. This is a preparation for patch#2. Signed-off-by: Oscar Salvador --- include/linux/stackdepot.h | 13 ++++++- lib/stackdepot.c | 79 +++++++++++++++++++++++++++++++------- mm/kasan/common.c | 3 +- mm/page_owner.c | 13 +++++-- 4 files changed, 88 insertions(+), 20 deletions(-) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index bc2797955de9..5ee0cf5be88f 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -15,9 +15,16 @@ typedef u32 depot_stack_handle_t; +typedef enum stack_action { + STACK_ACTION_NONE, + STACK_ACTION_INC, +}stack_action_t; + depot_stack_handle_t __stack_depot_save(unsigned long *entries, unsigned int nr_entries, - gfp_t gfp_flags, bool can_alloc); + gfp_t gfp_flags, bool can_alloc, + stack_action_t action); +void stack_depot_dec_count(depot_stack_handle_t handle); /* * Every user of stack depot has to call stack_depot_init() during its own init @@ -55,6 +62,10 @@ static inline int stack_depot_early_init(void) { return 0; } depot_stack_handle_t stack_depot_save(unsigned long *entries, unsigned int nr_entries, gfp_t gfp_flags); +depot_stack_handle_t stack_depot_save_action(unsigned long *entries, + unsigned int nr_entries, + gfp_t gfp_flags, + stack_action_t action); unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries); diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 5ca0d086ef4a..aeb59d3557e2 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -63,6 +63,7 @@ struct stack_record { u32 hash; /* Hash in the hastable */ u32 size; /* Number of frames in the stack */ union handle_parts handle; + refcount_t count; /* Number of the same repeated stacks */ unsigned long entries[]; /* Variable-sized array of entries. */ }; @@ -139,6 +140,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) stack->handle.slabindex = depot_index; stack->handle.offset = depot_offset >> STACK_ALLOC_ALIGN; stack->handle.valid = 1; + refcount_set(&stack->count, 1); memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); depot_offset += required_size; @@ -302,6 +304,29 @@ void stack_depot_print(depot_stack_handle_t stack) } EXPORT_SYMBOL_GPL(stack_depot_print); +static struct stack_record *stack_depot_getstack(depot_stack_handle_t handle) +{ + union handle_parts parts = { .handle = handle }; + void *slab; + size_t offset = parts.offset << STACK_ALLOC_ALIGN; + struct stack_record *stack; + + if(!handle) + return NULL; + + if (parts.slabindex > depot_index) { + WARN(1, "slab index %d out of bounds (%d) for stack id %08x\n", + parts.slabindex, depot_index, handle); + return NULL; + } + slab = stack_slabs[parts.slabindex]; + if (!slab) + return NULL; + + stack = slab + offset; + return stack; +} + /** * stack_depot_fetch - Fetch stack entries from a depot * @@ -314,30 +339,42 @@ EXPORT_SYMBOL_GPL(stack_depot_print); unsigned int stack_depot_fetch(depot_stack_handle_t handle, unsigned long **entries) { - union handle_parts parts = { .handle = handle }; - void *slab; - size_t offset = parts.offset << STACK_ALLOC_ALIGN; struct stack_record *stack; *entries = NULL; if (!handle) return 0; - if (parts.slabindex > depot_index) { - WARN(1, "slab index %d out of bounds (%d) for stack id %08x\n", - parts.slabindex, depot_index, handle); - return 0; - } - slab = stack_slabs[parts.slabindex]; - if (!slab) + stack = stack_depot_getstack(handle); + if (!stack) return 0; - stack = slab + offset; *entries = stack->entries; return stack->size; } EXPORT_SYMBOL_GPL(stack_depot_fetch); +static void stack_depot_inc_count(struct stack_record *stack) +{ + refcount_inc(&stack->count); +} + +void stack_depot_dec_count(depot_stack_handle_t handle) +{ + struct stack_record *stack = NULL; + + stack = stack_depot_getstack(handle); + if (stack) { + /* + * page_owner creates some stacks via create_dummy_stack(). + * We are not interested in those, so make sure we only decrement + * "valid" stacks. + */ + if (refcount_read(&stack->count) > 1) + refcount_dec(&stack->count); + } +} + /** * __stack_depot_save - Save a stack trace from an array * @@ -363,7 +400,8 @@ EXPORT_SYMBOL_GPL(stack_depot_fetch); */ depot_stack_handle_t __stack_depot_save(unsigned long *entries, unsigned int nr_entries, - gfp_t alloc_flags, bool can_alloc) + gfp_t alloc_flags, bool can_alloc, + stack_action_t action) { struct stack_record *found = NULL, **bucket; depot_stack_handle_t retval = 0; @@ -449,8 +487,11 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, /* Nobody used this memory, ok to free it. */ free_pages((unsigned long)prealloc, STACK_ALLOC_ORDER); } - if (found) + if (found) { retval = found->handle.handle; + if (action == STACK_ACTION_INC) + stack_depot_inc_count(found); + } fast_exit: return retval; } @@ -472,6 +513,16 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries, unsigned int nr_entries, gfp_t alloc_flags) { - return __stack_depot_save(entries, nr_entries, alloc_flags, true); + return __stack_depot_save(entries, nr_entries, alloc_flags, true, + STACK_ACTION_NONE); } EXPORT_SYMBOL_GPL(stack_depot_save); + +depot_stack_handle_t stack_depot_save_action(unsigned long *entries, + unsigned int nr_entries, + gfp_t alloc_flags, + stack_action_t action) +{ + return __stack_depot_save(entries, nr_entries, alloc_flags, true, action); +} +EXPORT_SYMBOL_GPL(stack_depot_save_action); diff --git a/mm/kasan/common.c b/mm/kasan/common.c index c40c0e7b3b5f..f434994f3b0d 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -36,7 +36,8 @@ depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc) unsigned int nr_entries; nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0); - return __stack_depot_save(entries, nr_entries, flags, can_alloc); + return __stack_depot_save(entries, nr_entries, flags, can_alloc, + STACK_ACTION_NONE); } void kasan_set_track(struct kasan_track *track, gfp_t flags) diff --git a/mm/page_owner.c b/mm/page_owner.c index e4c6f3f1695b..794f346d7520 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -106,7 +106,7 @@ static inline struct page_owner *get_page_owner(struct page_ext *page_ext) return (void *)page_ext + page_owner_ops.offset; } -static noinline depot_stack_handle_t save_stack(gfp_t flags) +static noinline depot_stack_handle_t save_stack(gfp_t flags, stack_action_t action) { unsigned long entries[PAGE_OWNER_STACK_DEPTH]; depot_stack_handle_t handle; @@ -125,7 +125,7 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags) current->in_page_owner = 1; nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 2); - handle = stack_depot_save(entries, nr_entries, flags); + handle = stack_depot_save_action(entries, nr_entries, flags, action); if (!handle) handle = failure_handle; @@ -138,6 +138,7 @@ void __reset_page_owner(struct page *page, unsigned short order) int i; struct page_ext *page_ext; depot_stack_handle_t handle; + depot_stack_handle_t alloc_handle; struct page_owner *page_owner; u64 free_ts_nsec = local_clock(); @@ -145,7 +146,10 @@ void __reset_page_owner(struct page *page, unsigned short order) if (unlikely(!page_ext)) return; - handle = save_stack(GFP_NOWAIT | __GFP_NOWARN); + page_owner = get_page_owner(page_ext); + alloc_handle = page_owner->handle; + + handle = save_stack(GFP_NOWAIT | __GFP_NOWARN, STACK_ACTION_NONE); for (i = 0; i < (1 << order); i++) { __clear_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags); page_owner = get_page_owner(page_ext); @@ -153,6 +157,7 @@ void __reset_page_owner(struct page *page, unsigned short order) page_owner->free_ts_nsec = free_ts_nsec; page_ext = page_ext_next(page_ext); } + stack_depot_dec_count(alloc_handle); } static inline void __set_page_owner_handle(struct page_ext *page_ext, @@ -189,7 +194,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order, if (unlikely(!page_ext)) return; - handle = save_stack(gfp_mask); + handle = save_stack(gfp_mask, STACK_ACTION_INC); __set_page_owner_handle(page_ext, handle, order, gfp_mask); } From patchwork Thu Sep 1 04:42:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 12961747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C81ECAAD1 for ; Thu, 1 Sep 2022 04:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB5538D0003; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D64456B0073; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B918D0003; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B57D56B0072 for ; Thu, 1 Sep 2022 00:42:58 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90D78A01D2 for ; Thu, 1 Sep 2022 04:42:58 +0000 (UTC) X-FDA: 79862271636.11.19A2308 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 29E9F180067 for ; Thu, 1 Sep 2022 04:42:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20776221E2; Thu, 1 Sep 2022 04:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662007377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+9op6+s45dBeDDz0hB6cxjRW0r3Pje/FesTmSW2Zek=; b=NAIeqLSDDSE+P9kHg5Syu0+cXWEM5KdAOu1En/FPsEPWos0BsZE1cBPGZR5MRySX53IHfn wTIcA1u8waN9m0Rh3w/lLxoexge/vWQvCv0TcjSze3peDkowN5nJZecsg+6TI/P3K5tBGs 5iCdzLF5xUjKZuBqvi542DvQpNR+D64= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662007377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I+9op6+s45dBeDDz0hB6cxjRW0r3Pje/FesTmSW2Zek=; b=0oalvhcOoaYu6EzaGL2RxZ5vSihBQFyAzeJIJ+GbTXuKLQnsKZUIv00y4F5pN+YHdBNWQo Nqe/TXfpazjOnrCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C293139C4; Thu, 1 Sep 2022 04:42:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IMKAH1A4EGPheAAAMHmgww (envelope-from ); Thu, 01 Sep 2022 04:42:56 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Oscar Salvador Subject: [PATCH 2/3] mm, page_owner: Add page_owner_stacks file to print out only stacks and their counter Date: Thu, 1 Sep 2022 06:42:48 +0200 Message-Id: <20220901044249.4624-3-osalvador@suse.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220901044249.4624-1-osalvador@suse.de> References: <20220901044249.4624-1-osalvador@suse.de> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662007378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I+9op6+s45dBeDDz0hB6cxjRW0r3Pje/FesTmSW2Zek=; b=cE7Cb8B7zIvw+RVLqSuqKeONFm0R+d5BEZrUMyzzGflY37UwiBRyFH0RlEufxOgfGDRHB8 TWgkyS+h6AWz0FDD6estuOaLtAgkOlc3A6nDB8qCiwmdnrwV9HLiOPuG0QH7NVRBSFol2V m42nD+ct3PuI8uriJJwd7ZO9OLE2EBw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NAIeqLSD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0oalvhcO; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662007378; a=rsa-sha256; cv=none; b=eybaNT7CNlbHc2fKYslSaeNUVjIoXiIic4mM8tZsX79gla478SxqEVnrXja59BJY4yd1Zi a5E6BuXdFicm6zuTVgaxzzFVH8PEJ7L8kMzQAlC8Ev11LanY6FUfgyGeZHkc5Zkl+4puvk lmrHyjBRFBgbh0RGp0rRn+zB9mAT4j4= X-Rspamd-Queue-Id: 29E9F180067 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NAIeqLSD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0oalvhcO; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: hz3k5cbwiyigox1eamktazecanb9su6k X-HE-Tag: 1662007378-477409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We might be only interested in knowing about stacks <-> count relationship, so instead of having to fiddle with page_owner output and screen through pfns, let us add a new file called 'page_owner_stacks' that does just that. By cating such file, we will get all the stacktraces followed by its counter (allocated - freed times), so we can have a more specific overview. Signed-off-by: Oscar Salvador Reported-by: kernel test robot Reported-by: kernel test robot --- include/linux/stackdepot.h | 2 ++ lib/stackdepot.c | 40 ++++++++++++++++++++++++++++++++++++++ mm/page_owner.c | 30 ++++++++++++++++++++++++++++ 3 files changed, 72 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index 5ee0cf5be88f..20f62039f23a 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -25,6 +25,8 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, gfp_t gfp_flags, bool can_alloc, stack_action_t action); void stack_depot_dec_count(depot_stack_handle_t handle); +int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos, + unsigned long *last_stack); /* * Every user of stack depot has to call stack_depot_init() during its own init diff --git a/lib/stackdepot.c b/lib/stackdepot.c index aeb59d3557e2..3090ae0f3958 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -526,3 +526,43 @@ depot_stack_handle_t stack_depot_save_action(unsigned long *entries, return __stack_depot_save(entries, nr_entries, alloc_flags, true, action); } EXPORT_SYMBOL_GPL(stack_depot_save_action); + +int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos, + unsigned long *last_stack) +{ + struct stack_record *stack = NULL, *last; + struct stack_record **stacks; + int i = *pos, ret = 0; + + /* Continue from the last week if we have one */ + if (*last_stack) { + last = (struct stack_record *)*last_stack; + stack = last->next; + } else { +new_table: + stacks = &stack_table[i]; + stack = (struct stack_record *)stacks; + } + + for (; stack; stack = stack->next) { + if (!stack->size || stack->size < 0 || + stack->size > size || stack->handle.valid != 1 || + refcount_read(&stack->count) < 1) + continue; + + ret += stack_trace_snprint(buf, size, stack->entries, stack->size, 0); + ret += scnprintf(buf + ret, size - ret, "stack count: %d\n\n", + refcount_read(&stack->count)); + *last_stack = (unsigned long)stack; + return ret; + } + + i++; + *pos = i; + + /* Keep looking all tables for valid stacks */ + if (i < STACK_HASH_SIZE) + goto new_table; + + return 0; +} diff --git a/mm/page_owner.c b/mm/page_owner.c index 794f346d7520..8c67c7eb2451 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -43,6 +43,8 @@ static depot_stack_handle_t early_handle; static void init_early_allocated_pages(void); +static unsigned long last_stack = 0; + static int __init early_page_owner_param(char *buf) { int ret = kstrtobool(buf, &page_owner_enabled); @@ -663,6 +665,32 @@ static void init_early_allocated_pages(void) init_zones_in_node(pgdat); } +static ssize_t read_page_owner_stacks(struct file *file, char __user *buf, + size_t count, loff_t *pos) +{ + char *kbuf; + int ret = 0; + + count = min_t(size_t, count, PAGE_SIZE); + kbuf = kmalloc(count, GFP_KERNEL); + if (!kbuf) + return ENOMEM; + + ret += stack_depot_print_stacks_threshold(kbuf, count, pos, &last_stack); + if (copy_to_user(buf, kbuf, ret)) + ret = -EFAULT; + + if (!ret) + last_stack = 0; + + kfree(kbuf); + return ret; +} + +static const struct file_operations proc_page_owner_stacks = { + .read = read_page_owner_stacks, +}; + static const struct file_operations proc_page_owner_operations = { .read = read_page_owner, }; @@ -676,6 +704,8 @@ static int __init pageowner_init(void) debugfs_create_file("page_owner", 0400, NULL, NULL, &proc_page_owner_operations); + debugfs_create_file("page_owner_stacks", 0400, NULL, NULL, + &proc_page_owner_stacks); return 0; } From patchwork Thu Sep 1 04:42:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 12961748 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC970ECAAD2 for ; Thu, 1 Sep 2022 04:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21DD68D0005; Thu, 1 Sep 2022 00:43:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10A326B0073; Thu, 1 Sep 2022 00:43:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E28CD8D0005; Thu, 1 Sep 2022 00:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D5B666B0072 for ; Thu, 1 Sep 2022 00:42:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A2F801C65DC for ; Thu, 1 Sep 2022 04:42:59 +0000 (UTC) X-FDA: 79862271678.29.363C26F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 0AF2E160056 for ; Thu, 1 Sep 2022 04:42:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2024221EE; Thu, 1 Sep 2022 04:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662007377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8DWylbFwSCb/px9RHGyLSh+EhBiVeZp3bgNDtmW9IA=; b=S7u1rvndnGXFGe9gpIQARWw/22R+6XqNKcNzRqacOvUWansQ9BHdjWh8iRcKXrqgqLuOV2 v6DNKPXLbjMM5RWzIlyGrePp8e4xf2+G40n99CDJxSnS5QOyKG04Sjxj+U0/vhXgjzyXUW RP6Cdu7Ae7QcP7PhwIku/EEFbAb/KXE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662007377; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e8DWylbFwSCb/px9RHGyLSh+EhBiVeZp3bgNDtmW9IA=; b=BPF/tSxXMQDSvEmbgyPhuBR9rysuTMAjY41Rxsu8/nW5dEMdII4hStCGu0uptmYWj17dRU oJeH7qfBX4uymWBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 32E2C139C4; Thu, 1 Sep 2022 04:42:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WKusCVE4EGPheAAAMHmgww (envelope-from ); Thu, 01 Sep 2022 04:42:57 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Oscar Salvador Subject: [PATCH 3/3] mm,page_owner: Filter out stacks by a threshold counter Date: Thu, 1 Sep 2022 06:42:49 +0200 Message-Id: <20220901044249.4624-4-osalvador@suse.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220901044249.4624-1-osalvador@suse.de> References: <20220901044249.4624-1-osalvador@suse.de> MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662007379; a=rsa-sha256; cv=none; b=mCWh4AZ2WGQk6wDjIgXNtMK+lW2eDYJ4f2fY/4RWs2QbqyFuOMkxaq7M53JIy3Py3+2n2N 07AR/m8SK6X4qp0+2JhKnbW+a3Y83oVtB5T40VSfA7HJytVioFFTbzoxqZhzJ3bawnVzsT 6v5LojIWW3yxYizQQDAEeS6l8XgxwPA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S7u1rvnd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="BPF/tSxX"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662007379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e8DWylbFwSCb/px9RHGyLSh+EhBiVeZp3bgNDtmW9IA=; b=2UFcS8uTAmCgSuh/ZMtfJUh2tZZpNbOWViowsx3kkP4e0GdnX3ZBXHGNUjr8S6Z4ak8tNO wMvaUEarcc0XlUkiE9Kklm4AStlpoZGPKp1EZNpMxqSGm28t6zUgbE2RDI+WCBfnd1T6RX 9qqFlhlk8prhOYAbIBvvOhXD2icuWxw= X-Rspamd-Queue-Id: 0AF2E160056 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=S7u1rvnd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="BPF/tSxX"; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam03 X-Stat-Signature: 5iw3qz97d339hegpexa1gy9k6x54j36y X-HE-Tag: 1662007378-847884 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We want to be able to filter out the output on a threshold basis, in this way we can get rid of a lot of noise and focus only on those stacks which have an allegedly high counter. We can control the threshold value by a new file called 'page_owner_threshold', which is 0 by default. Signed-off-by: Oscar Salvador --- include/linux/stackdepot.h | 3 +- lib/stackdepot.c | 6 ++-- mm/page_owner.c | 61 +++++++++++++++++++++++++++++++++++++- 3 files changed, 66 insertions(+), 4 deletions(-) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index 20f62039f23a..ee66be40a152 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -26,7 +26,8 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, stack_action_t action); void stack_depot_dec_count(depot_stack_handle_t handle); int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos, - unsigned long *last_stack); + unsigned long *last_stack, + unsigned long threshold); /* * Every user of stack depot has to call stack_depot_init() during its own init diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 3090ae0f3958..b4a04f09a7b7 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -528,7 +528,8 @@ depot_stack_handle_t stack_depot_save_action(unsigned long *entries, EXPORT_SYMBOL_GPL(stack_depot_save_action); int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos, - unsigned long *last_stack) + unsigned long *last_stack, + unsigned long threshold) { struct stack_record *stack = NULL, *last; struct stack_record **stacks; @@ -547,7 +548,8 @@ int stack_depot_print_stacks_threshold(char *buf, size_t size, loff_t *pos, for (; stack; stack = stack->next) { if (!stack->size || stack->size < 0 || stack->size > size || stack->handle.valid != 1 || - refcount_read(&stack->count) < 1) + refcount_read(&stack->count) < 1 || + refcount_read(&stack->count) < threshold) continue; ret += stack_trace_snprint(buf, size, stack->entries, stack->size, 0); diff --git a/mm/page_owner.c b/mm/page_owner.c index 8c67c7eb2451..ef10cf44aaec 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -44,6 +44,7 @@ static depot_stack_handle_t early_handle; static void init_early_allocated_pages(void); static unsigned long last_stack = 0; +static unsigned long threshold_count = 0; static int __init early_page_owner_param(char *buf) { @@ -676,7 +677,8 @@ static ssize_t read_page_owner_stacks(struct file *file, char __user *buf, if (!kbuf) return ENOMEM; - ret += stack_depot_print_stacks_threshold(kbuf, count, pos, &last_stack); + ret += stack_depot_print_stacks_threshold(kbuf, count, pos, &last_stack, + threshold_count); if (copy_to_user(buf, kbuf, ret)) ret = -EFAULT; @@ -687,6 +689,61 @@ static ssize_t read_page_owner_stacks(struct file *file, char __user *buf, return ret; } +static ssize_t read_page_owner_threshold(struct file *file, char __user *buf, + size_t count, loff_t *pos) +{ + char *kbuf; + int ret = 0; + + count = min_t(size_t, count, PAGE_SIZE); + + if (*pos >= count) + return 0; + + kbuf = kmalloc(count, GFP_KERNEL); + if (!kbuf) + return ENOMEM; + + ret = scnprintf(kbuf, count, "%lu\n", threshold_count); + if (copy_to_user(buf, kbuf, ret)) + ret = -EFAULT; + + *pos += count; + kfree(kbuf); + + return ret; +} + +static ssize_t write_page_owner_threshold(struct file *file, const char __user *buf, + size_t count, loff_t *pos) +{ + char *kbuf; + int ret = 0; + + count = min_t(size_t, count, PAGE_SIZE); + kbuf = kmalloc(count, GFP_KERNEL); + if (!kbuf) + return -ENOMEM; + + if (copy_from_user(kbuf, buf, count)) { + ret = -EFAULT; + goto out; + } + + kbuf[count - 1] = '\0'; + + ret = kstrtoul(kbuf, 10, &threshold_count); + +out: + kfree(kbuf); + return ret ? ret : count; +} + +static const struct file_operations proc_page_owner_threshold = { + .read = read_page_owner_threshold, + .write = write_page_owner_threshold, +}; + static const struct file_operations proc_page_owner_stacks = { .read = read_page_owner_stacks, }; @@ -706,6 +763,8 @@ static int __init pageowner_init(void) &proc_page_owner_operations); debugfs_create_file("page_owner_stacks", 0400, NULL, NULL, &proc_page_owner_stacks); + debugfs_create_file("page_owner_threshold", 0600, NULL, NULL, + &proc_page_owner_threshold); return 0; }