From patchwork Mon Sep 5 19:08:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12966483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9AFCECAAD3 for ; Mon, 5 Sep 2022 19:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Se8rw716fF2HSS2LpS/Y/jfBcmtcU/RxFsWR4YXL6Uw=; b=uuALJ2qqxJ84nA 5KWsTsO7BM+ZrbjIzWEMi7z/osA9sAdelvoU7kFarG7d+HKEfPCnMXukPr/lMrLo2pcqwKjvIr5Vi Iu9eV5DPHYS6WAGC21RaNVq6wcNbMYXGDbfp80RcFQvtR3e6Ndz04EDrzzuv1lDzpzqfm+Qzuwkm2 FDYgb2OPy6LuwhPVllK/6SCWNJba1e0KXgpHht7V+4HloDtet/z9nrNKu0ufy+6O72hnJ6ds7gS6G jkeJGY/Cli0SovpdxmLfjvw+qV8vGbK25f7XK+TAwZcVVDFrvGrHJOrq0i7Ln97zW/LOcVs7EIMfX LIRGLI7a0BdUrJX5yg3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVHy8-009Vo9-2g; Mon, 05 Sep 2022 19:41:16 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVHSo-008ywz-Gc for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 19:08:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662404934; x=1693940934; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WwmzwywTSAN6ZMOyQiemN7PKzXK7Aa4TUDjqPx95sFw=; b=BU6l94X8j8b7iR9JwwdgNYSpMeKUSgALSt808Eqd84vTk9IVodAKPaCt czLcq/UbfEVLCEdnGOtPXr6ktXuyPAkk2pq6GWGLGj4R0SbSDuN459kst Hs4MRQYFWY5hgt8lBq9Pnc4Qo36duY5GD7f1INdnHiwxSk1EYXlkgOEAZ nEM6+DP7w5n4+6l10mqIMOIq7KN6OV7xiXKMFQ+cAI4582aic9PP7D9gL 9ZbIpSXavIAp9Iahge1QhEGsjpd5dlNOojsun92UCoZ8QqdsiNakkVjUF b2aql0Tfq1aJyEtYvbnHmcOrOXtLuQEn9f9i2hnhkEMIPe2vKUWf5SdIc Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10461"; a="279456554" X-IronPort-AV: E=Sophos;i="5.93,292,1654585200"; d="scan'208";a="279456554" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2022 12:08:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,292,1654585200"; d="scan'208";a="609738324" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 05 Sep 2022 12:08:37 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id F1BE6101; Mon, 5 Sep 2022 22:08:52 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Michael Walle , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Andy Shevchenko Subject: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check Date: Mon, 5 Sep 2022 22:08:49 +0300 Message-Id: <20220905190849.73194-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_120857_150151_9938371C X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org fwnode_irq_get() may return all possible signed values, such as Linux error code. Fix the code to handle this properly. Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for sparx5)") Signed-off-by: Andy Shevchenko Reviewed-by: Michael Walle --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 6f55bf7d5e05..0771b743a940 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -864,9 +864,10 @@ static int microchip_sgpio_register_bank(struct device *dev, gc->can_sleep = !bank->is_input; if (bank->is_input && priv->properties->flags & SGPIO_FLAGS_HAS_IRQ) { - int irq = fwnode_irq_get(fwnode, 0); + int irq; - if (irq) { + irq = fwnode_irq_get(fwnode, 0); + if (irq > 0) { struct gpio_irq_chip *girq = &gc->irq; gpio_irq_chip_set_chip(girq, µchip_sgpio_irqchip);