From patchwork Fri Sep 9 07:22:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12971095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF450ECAAA1 for ; Fri, 9 Sep 2022 07:23:26 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.403863.646114 (Exim 4.92) (envelope-from ) id 1oWYLr-00022N-M3; Fri, 09 Sep 2022 07:22:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 403863.646114; Fri, 09 Sep 2022 07:22:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYLr-00022G-Hq; Fri, 09 Sep 2022 07:22:59 +0000 Received: by outflank-mailman (input) for mailman id 403863; Fri, 09 Sep 2022 07:22:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oWYLp-00022A-En for xen-devel@lists.xenproject.org; Fri, 09 Sep 2022 07:22:57 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 393b55f1-3010-11ed-a31c-8f8a9ae3403f; Fri, 09 Sep 2022 09:22:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB9013.eurprd04.prod.outlook.com (2603:10a6:20b:409::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20; Fri, 9 Sep 2022 07:22:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 07:22:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 393b55f1-3010-11ed-a31c-8f8a9ae3403f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJQo4EkoYn85e1604VR5I8Gm3gV6slaHToBFyp0rBlo+8HggCCpoZnkvbuOovaTmlgCWs3SrsDJWIDTLeDheIgOTWq1uQJ4EswEbFEBu8XjAfnYUZGd+xKU+fQ0b8S1vqfTEdlPT+acTiV1aVFzA23BQlwcCPJKf68pFJDHp9YBd0OG7LN10tzWa+zQQlYxhIuxFjq91gFT4tYEgOxXTGqQiw0sWF6ocX98Z9wFjb0RfF18k3jhkURQAvtXCsCEhh8VY7X9RlNsMxgyOtQwmmq/tul5ue1vk0DVzQi2qOmvYy3lGTPqVlPE4ROBl0iUW9rf21eh4Y4d/JMn1LkqEtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w64Ecx1+8EL+wrspYIaDYT1Izwreh0mSF8hsvv4Kvz0=; b=UzQ1dvHbvqBiWQepYGmtPtlurjiVtQ9yj+GNChj7O9mOyZepTdDlZOoDzkYaGymIMJOPmIagbQlRcA72aO5qQi2L+xgRMEZs3dLvTgO0gZYSH+bDRTCWeW8wcDwds3OOhNYgVuOo8mU6ntIys6TUUHSjbTtkhcH5Dp/tY3T4Uw+sUUNt1ytdarzRQwNiMhx9w0waK7DULTWjZjoIlZRGnyFcQ0RKGDAWVCiVDWcPzAmdoLJlUtYDHJVPSyJlevMJFW06lzTTn/L1+E8IKcZ1sZC+k9KKmR65/+lIt1PBKxZJronwhaacm8EqXi3lwUCPg28301ZpZzweLU3hqmqAkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w64Ecx1+8EL+wrspYIaDYT1Izwreh0mSF8hsvv4Kvz0=; b=EgEw314XzgmtbkgNb9clilLM3mKxRl0rblvLMwplDtZKj3kpiWTaysX2Qs9wvmCJiNuav0mAqYbbCZ1NsKqmhlBcI70B41b3FenAkwUGB0zCiBxwDfsf6kdUDr6+I8HgxpYUytMzGderTB6loqgZMtUhBQ8GWg+zkbDssoBO68hOjeEYOWcTU7jCJhAtGoO8SjIbh26C5YYVTvspfzxaFBtqX94Lb+5P7O38/UWtyC83f6CQpnmMmD7hn91hi/rO+GNN8ZCE8mT0U6LacJmaws6ch//Seed8zV6/Xux9qZpL0SdlQEnXUYplbKOZK9PBmK6m4h86IOY3pd+z3sti3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 9 Sep 2022 09:22:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Anthony Perard From: Jan Beulich Subject: [PATCH] zap linking-only option from EMBEDDED_EXTRA_CFLAGS X-ClientProxiedBy: FR0P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB9013:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cd4a91c-138c-4ca0-d199-08da92341c99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XJxaXwHsd0BC7GHH7oulhzduW4grWkUQQiuPiqhRu1I9t80TUiVeQIgVpVqlwtf76unAW1CupUAKyxczRTBUNAau4PoJfd0FzeqCk96IQaVBohfQJQS6tHO30//LZ7rZjYwoaCOAexi50xORsnhPRxfnrwHqsrL2Wpt16mw/G/4UaigcTT715wulED5IfX576HZSDkPPsdkKhopbzVDQylzGwoHBSAD0DEm+PP3KeoYwU+kKPJyf+Lj3C02IAC6fzICPtT8cR5ZB9MJUDKPYIL8sNDKCPZvF292UwDEEuU9Z3gUJ8fCevzKxcWGNwfLfwUdR7Wb76cqW2SOyxLH/CdtdiiAExWyl9oy8fXwwPnVIt73MPb0Jvq/K4TwEzDEBxTBnriKmiKynLR9BmgDhyEzzonl0I85IZGFHd+8XkVGrwTm6QC3bB5uTLHnAFQzKjUDWGMONzsK3demq+R8zU0tWWVunkbo0vNBc4EGQ9R5Pj3vGudWkZI9yISHb6aEZuNhJRaohMmHGpd7p6AdOyETR5CJDMSpJtNlKC5/jYwPFXtGYwUv9y96WNRqy5kwWFhXXlyfOz6r0bFm1yof/6n2AyOn7cOMbOfXQ9JTmcwN3GBLkV6ydkVGV88cD6hD2ZVceNrMTe05kzG8vuwps0kI+lUtyUUJ1dyq+rl8CVj6/fmoPQ91gmvlFez29YZ4OGWqR2f3BT7/bfXC7UIEwy4o2lRlqwrefhI2aNmOb3f6VmdXSfg6SMad6wiUQXWR9s9ewarBjY5yYmCKM2CiSiw5UYwTlXMESlgpUAJjzSzg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(39860400002)(366004)(396003)(346002)(31696002)(86362001)(54906003)(6916009)(316002)(6486002)(31686004)(8936002)(478600001)(6506007)(186003)(6512007)(26005)(2906002)(36756003)(5660300002)(41300700001)(2616005)(83380400001)(38100700002)(8676002)(4326008)(66946007)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fKPYLfcIDJgrFeGs8Q1vHoqkak5P?= =?utf-8?q?UToBPQeAzFkir2SUnIiAVPyhj4+3z57jG+XRdc+YimNtvseuR2xnKV+UmjY0IMfun?= =?utf-8?q?CCxNntblwyA8lQQ/ohFPgYevQG6ESPqLZjMm/I7B1E87VrY4WeAgAM5hfCFwJ1iJ/?= =?utf-8?q?xvewi+HYJNUwoBbVtgUXPwli+YFzh8+idIdpW7BWT/AisM4tNJMLVZYuLf6Ujphb7?= =?utf-8?q?eY+CNl8I+gHmEO4LHYrIg/w/cT6oIZbCxTBKuel3KjsxSjvSrnwhT4DNxoM/9Ea0U?= =?utf-8?q?wuSU6w/5jdRTDmIqH+VwVZhifhIhlIjX1NPDOqKDtrHIEU4l6MAc8GX15ptT723CT?= =?utf-8?q?zxhNTGP+DpTtYYhI1nE+c9qvgwUt46LqIYIDDDy7UKNQZh2dIcq+ro3GmVX3ikZkD?= =?utf-8?q?Gyo6DLGhUqbCF0NuzFVO7T6fvd9/toNikHV8epI+NDP7G1mwwZQdX8/EDSZQw9l3c?= =?utf-8?q?ocQ51jOBQ3kLsL9YVpQt+3ZWqvIkExQkVrRVT9tgrUNQ2CBCK48L4Ef46KD1Y4+Jt?= =?utf-8?q?pSk+pOMOb7zEnlAvzffiS4/W1dEzx7NVq1iZxlYywKNeYDolKwtIQ8kn+8p0r3hsZ?= =?utf-8?q?f3REMR1oxp4obwvPeXYKR8+lG2pYRo3zXhctWDOQ3vFwL8V/HyNl2vkFB1fB2PtNe?= =?utf-8?q?9RlTIKb8v3GJbRl+wdWNGmUhstzIz7UWZ7eIymAHAsnsU2Pfp0Cwy2XKoFc5cbIdn?= =?utf-8?q?F6h36AzCmMuJBK8rHofGQX9fFwVC5BuAkfJBsejpgEPTDEwAmrgKwSsE36R3V4Aj2?= =?utf-8?q?jZej9iXfbev42YYTE0Wpp2Qua6yRddml7bVlLRRudaHoaI4PTmavOyMGjUwfycgQd?= =?utf-8?q?qLGHipTvgzssap8qcPv38by4fIT9TIQIIm6puYkcXTjDifdjjOV095o3vAGfkFozG?= =?utf-8?q?n0x4v9Sa4YznF6zsZ8fKxyspTLBES+2aQNPzGyd1QGFSkXYrPaKj402HmZOEHV3HP?= =?utf-8?q?wYlvftbWqKu03V8PI+1CDvzLvOtDrhytRkhv6aER48+S9dySNVIwLftRmFDgbZzJD?= =?utf-8?q?n4+if2CL85EZqdPB+CFrWk6kje9SEtDc+qwYJZSpnN6gROGn7t6yKIT6OB7Pb28M6?= =?utf-8?q?emI03U3PjoZ7TrtpGyXXsV5eLcNTa6TbXsryhDaZ7UnbP1ltszOl9hbCIjQ/5jNtl?= =?utf-8?q?QVrqf1XWkQW4VrYQgTQpDxpUTeSPO+NPD4+8Jqdr+2egt0J2IhaZumldS4o4j6q/k?= =?utf-8?q?0J+XmDU4ATUUZbQb5ULu7VnPLurvBYWJ8PUQV+n4KpKJ4tZ0B5c9480s5VMHTOH6w?= =?utf-8?q?5nzeU5rMOvRunepOK+n48bkGPmS4evy5g0etME7YyFnehb7bX1/tymgvwbNNXZlpm?= =?utf-8?q?HLW30Ru+QIskUSuI8/80DX3TpZQtZaW08Us8tyi0N05dOW+D2MMbgpLCgo+1egrBY?= =?utf-8?q?RSMQm96XebdC4huelFmYVuxq8DtM4GASLveVs2dDIDwEOYZ3J8ZBXe9Bwq/hm63gO?= =?utf-8?q?iIdmIHgr0C3emNP9BIuoTyZUAYFuQN5DXo7Oylraj5KBQyh5DMjxqm3D7mkcON9WW?= =?utf-8?q?Z3VW/vvENqdW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd4a91c-138c-4ca0-d199-08da92341c99 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 07:22:54.3237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MB7MzE48THrPkP/Z4JLM/80rBXSqloqQ65a/7T5YTiq7xOD6bUh+veFp+gboixnrZflutQsC+bWaEk5tL6fD1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB9013 While I was suspicious of the compiler issuing a diagnostic about an unused linking-only option when not doing any linking, I did check this with a couple of gcc versions only, but not with Clang. (Oddly enough at least older Clang versions complain about the use of '-nopie' now that we actually use '-no-pie'.) Filter out the problematic option in all cases where the variable is consumed for compilation only (which right now is everywhere). Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS") Reported-by: Stefano Stabellini Signed-off-by: Jan Beulich Tested-by: Stefano Stabellini --- Arguably with all users of EMBEDDED_EXTRA_CFLAGS using these just for compiling, the option could be omitted from that variable right away. But if any compile-and-link-in-one-go use appeared, there would be an issue. --- a/tools/firmware/Rules.mk +++ b/tools/firmware/Rules.mk @@ -13,7 +13,7 @@ endif CFLAGS += -Werror -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-fcf-protection=none) --- a/tools/tests/x86_emulator/testcase.mk +++ b/tools/tests/x86_emulator/testcase.mk @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../.. CFLAGS := include $(XEN_ROOT)/tools/Rules.mk -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) CFLAGS += -fno-builtin -g0 $($(TESTCASE)-cflags) --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -1,7 +1,7 @@ ######################################## # arm-specific definitions -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) # Prevent floating-point variables from creeping into Xen. --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -10,7 +10,7 @@ CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFF # Prevent floating-point variables from creeping into Xen. CFLAGS += -msoft-float -$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) $(call as-option-add,CFLAGS,CC,"vmcall",-DHAVE_AS_VMX) $(call as-option-add,CFLAGS,CC,"crc32 %eax$$(comma)%eax",-DHAVE_AS_SSE4_2) --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -12,7 +12,7 @@ endif $(obj)/head.o: $(head-bin-objs:.o=.bin) CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS)) -$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) +$(call cc-options-add,CFLAGS_x86_32,CC,$(filter-out -no-pie,$(EMBEDDED_EXTRA_CFLAGS))) CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float ifdef building_out_of_srctree CFLAGS_x86_32 += -I$(objtree)/include