From patchwork Wed Jan 16 21:04:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Goyal X-Patchwork-Id: 10766911 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 38D0B13A4 for ; Wed, 16 Jan 2019 21:04:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8563E2E106 for ; Wed, 16 Jan 2019 21:04:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 776EF2E170; Wed, 16 Jan 2019 21:04:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 120DE2E106 for ; Wed, 16 Jan 2019 21:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727004AbfAPVER (ORCPT ); Wed, 16 Jan 2019 16:04:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36706 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726803AbfAPVER (ORCPT ); Wed, 16 Jan 2019 16:04:17 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C499C002960; Wed, 16 Jan 2019 21:04:16 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6AFB17A67; Wed, 16 Jan 2019 21:04:15 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 6FC44220CE1; Wed, 16 Jan 2019 16:04:15 -0500 (EST) Date: Wed, 16 Jan 2019 16:04:15 -0500 From: Vivek Goyal To: fstests , linux-unionfs@vger.kernel.org Cc: Dave Chinner , Amir Goldstein , Miklos Szeredi , guaneryu@gmail.com Subject: [PATCH][V3] xfstest: overlay: File capabilities should not be lost over copy-up Message-ID: <20190116210415.GB4945@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 16 Jan 2019 21:04:16 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure file capabilities are not lost over copy-up when file is opened for WRITE but nothing is actually written to it. Following commit introduced regression where if a lower file with CAP_SETUID is opened for writing, and capability is cleared over copy up. bd64e57586d3 ("ovl: During copy up, first copy up metadata and then data") A later kernel patch will fix it. This test will help avoid introducing such regressions again. Signed-off-by: Vivek Goyal --- tests/overlay/064 | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/064.out | 2 + tests/overlay/group | 1 3 files changed, 63 insertions(+) Index: xfstests-dev/tests/overlay/064 =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ xfstests-dev/tests/overlay/064 2019-01-16 15:31:58.268178038 -0500 @@ -0,0 +1,60 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2019 Red Hat Inc. All Rights Reserved. +# +# FS QA Test 064 +# +# Make sure CAP_SETUID is not cleared over file copy up. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs overlay +_supported_os Linux +_require_scratch +_require_command "$SETCAP_PROG" setcap +_require_command "$GETCAP_PROG" getcap + +# Remove all files from previous tests +_scratch_mkfs + +# Create test file +lowerdir=${OVL_BASE_SCRATCH_MNT}/${OVL_LOWER} +echo "This is lower" >> ${lowerdir}/file + +# set setuid bit +$SETCAP_PROG cap_setuid+ep ${lowerdir}/file + +_scratch_mount + +# Trigger file copy up without actually writing anything to file. This +# requires opening file with WRITE and xfs_io opens file with +# O_RDWR by default. +$XFS_IO_PROG -c "stat" ${SCRATCH_MNT}/file >>$seqres.full + +# Make sure cap_setuid is still there +$GETCAP_PROG ${SCRATCH_MNT}/file | _filter_scratch + +# success, all done +status=0 +exit Index: xfstests-dev/tests/overlay/064.out =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ xfstests-dev/tests/overlay/064.out 2019-01-11 13:18:22.652461223 -0500 @@ -0,0 +1,2 @@ +QA output created by 064 +SCRATCH_MNT/file = cap_setuid+ep Index: xfstests-dev/tests/overlay/group =================================================================== --- xfstests-dev.orig/tests/overlay/group 2018-12-19 11:47:04.443031019 -0500 +++ xfstests-dev/tests/overlay/group 2019-01-10 15:43:28.053079686 -0500 @@ -66,3 +66,4 @@ 061 auto quick copyup 062 auto quick exportfs 063 auto quick whiteout +064 auto quick copyup