From patchwork Wed Sep 14 09:06:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 12975897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F909ECAAD3 for ; Wed, 14 Sep 2022 09:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbiINJSN (ORCPT ); Wed, 14 Sep 2022 05:18:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiINJRt (ORCPT ); Wed, 14 Sep 2022 05:17:49 -0400 Received: from esa6.fujitsucc.c3s2.iphmx.com (esa6.fujitsucc.c3s2.iphmx.com [68.232.159.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7442577556; Wed, 14 Sep 2022 02:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1663146484; x=1694682484; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=3DNQqdln3Py7csMXE0mynMir2rNmfZO/eILyH+2VOHs=; b=naSgFqQjOc8MIEUVPW6LlCjCBG/8W0FgLf5U2u4xSNBQD5m5qIOfYSg7 P7PrD4Rq0y5QpjANqce+Z8lWsxXfq7+OJtfO3lC+c6I7l1wM0gpFVBzmy iP5+zbzEUIjQP94jooj9mKPPvYH8SAHctGWtAAPq5SNVcsuoS8wT+0I2m 6bEGX4DVKp33N9A0VoOR2uNc3if9x8r52cwE3JR9whUuJDbHoAGagoQB1 8qLql8D0pXSTBHZNA8p4RdQDdk7iPW78I7mUz3UGzWOECizb1Xofcw5o6 fS2ANpMcPmS4412dr79f4bE0QymPd7J5WkUSAOkZFm2AGyaAKPltbG/Q1 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="65130961" X-IronPort-AV: E=Sophos;i="5.93,315,1654527600"; d="scan'208";a="65130961" Received: from mail-os0jpn01lp2111.outbound.protection.outlook.com (HELO JPN01-OS0-obe.outbound.protection.outlook.com) ([104.47.23.111]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 18:06:41 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YvWGNIWRd797t2i52n8JHE2xSqoU9HEPdV5UV7BslcdlIEB1rGSegE/KlwXDklN4QlDopfzhe1E63JEQQIILMQylCR61/bFarDVLF5CRGnTeV0vshilQ448rI7qX/VJvHzqKiNMmWABhPI0R4xkh2QZvRXi64x9LsVbk7qZJlC6269c4VWGqJXzntzOFxABZi+bPdB+KD6Ch8RTdEMVyyymIztpB2RWlvjm2+kYAAVxkPkfmahQtS8Ic5sQZa1vzhmT/tJKLuA8wB9bs75QF726JiATBk3xVnat82ifvxF56gTLkfaYHW8U3p+40A2DYl+B0bHGLcHzbcAAOHn5Y3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3DNQqdln3Py7csMXE0mynMir2rNmfZO/eILyH+2VOHs=; b=G8pbUNuA/+LpqiNwMX/fUJextOWj/spiwph25RMwn/Q8T+RZBMMSpde8CK2WTAdEqUqLrjKt3Vcse7o+ss6bUOG3W3oQO3E7HEKOjdvxMYoBcNx4dPZUH2rMRQSKNX2dci0muNRYXyGV+9leS5RQsQi5eTWFOGCQTIR3v5ae7QB3H7cno/4WREu/ONcJAMl/DDi7PRAKv7QkUwJEEGDC3Rpbwhl3oswlLDcZwfDkCE1bMTgwkXdg5Hs/08+rfvSw66s/WMItoqo+DoChENrALharFBS3jpb+zS3/2jRIBpU6kXrLrh1S3D8bscbpcEC39urWlO6nbXErhRbfwwCrLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from OS3PR01MB9499.jpnprd01.prod.outlook.com (2603:1096:604:1c8::5) by TYCPR01MB5629.jpnprd01.prod.outlook.com (2603:1096:400:44::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Wed, 14 Sep 2022 09:06:37 +0000 Received: from OS3PR01MB9499.jpnprd01.prod.outlook.com ([fe80::7861:36f0:2a19:ad0c]) by OS3PR01MB9499.jpnprd01.prod.outlook.com ([fe80::7861:36f0:2a19:ad0c%5]) with mapi id 15.20.5612.022; Wed, 14 Sep 2022 09:06:37 +0000 From: "yangx.jy@fujitsu.com" To: "fstests@vger.kernel.org" CC: "zlang@kernel.org" , "djwong@kernel.org" , "bfoster@redhat.com" , "ruansy.fnst@fujitsu.com" , "linux-kernel@vger.kernel.org" , "yangx.jy@fujitsu.com" Subject: [PATCH] Revert "generic/470: use thin volume for dmlogwrites target device" Thread-Topic: [PATCH] Revert "generic/470: use thin volume for dmlogwrites target device" Thread-Index: AQHYyBlL8iUjjv5ES0aVaBRgA21H4Q== Date: Wed, 14 Sep 2022 09:06:37 +0000 Message-ID: <20220914090625.32207-1-yangx.jy@fujitsu.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.34.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS3PR01MB9499:EE_|TYCPR01MB5629:EE_ x-ms-office365-filtering-correlation-id: e29b7073-3dbe-499d-b87a-08da96306dda x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JGLWW/pNZTJmAIu6jwa3pxXrFt46IgCrYI1Hk22iDtXLO/MADaH2pD5kw1Uj2TUCPQ01loX+gyCiGUhmnPQddthG/UFtaOEjuVyfyCYt2j41T0VV02Dz36Stg3lxe/IpmLcUvu59+/o2ZT6kBc4OE6JkvpUzPAadf+dTNVeULKu89stiD3SfO5lzWjgv0Qnt88MKV6Nk0hFXfpffD8oXVSfiC7hM/ImaeaIMNuusgw3Mu0v23vmqBdx3+z2Na/NJjtPbrBU9HsS7Bo4Zm5B3zHd4iva6XccwP/6EJbOOcCwExlOE2fQN9Of0fSWv8Vw5wskiIsKXA0cI7a+01siSGwdEHKzsp1/W+zv4+8c4tEcVeuTdEbRPntm3kbaUWXitgOpyjDVoLvUMNQ9uTrmlpbPVRr9Duc8XYV+cbtWmD8uKRs0jDUekmjCBMqKPEbYy3yGBX5xPNfGxwdN+HTzSDeidC4RQ0+hcpzQLVhgOkmbzbq7YRVPPnkBXIyG+AaLq4sPOHWEIsLPNwJrlIqfWvK8WVD/opsHO8CBVe2qKYMN/LqkeLHiUWWRWLH0OOvzkHlUF+eLHQD55HNjwTPchjJ3nzc5BB9gtUIdl1dF7M4kWmhcxaycoZe09Cajm9SEMoGerT5MOPtlTQ3lFU2RLp3R6GhFTc7KE0o+dV7EH9KLPOAQseInHZezo0S1KuEkSd/TMy9Rlafyu/zjOgUP+hJimssfy2E/tZmIRrDCKMMWM/m8YAhoiLo6ztnIuz396XlXXS2YWfIGFr+h73YK6R2OLgH+nLf+qDAdR/H9AEAd3/Ec03ZDOtAxrynk5/jr6 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB9499.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(451199015)(1590799012)(66476007)(8676002)(38070700005)(2906002)(1580799009)(86362001)(41300700001)(316002)(1076003)(107886003)(186003)(8936002)(6486002)(2616005)(6506007)(6512007)(85182001)(82960400001)(26005)(64756008)(5660300002)(66946007)(54906003)(122000001)(83380400001)(478600001)(71200400001)(36756003)(91956017)(4326008)(66556008)(76116006)(66446008)(38100700002)(6916009)(41533002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?dUVuNTk4ZTdOS2hldjhzTkMx?= =?eucgb2312_cn?b?YVVWcGFoMEQ0bUo1OXNxTGJRVkxpKzhrL3VSL21xa3kzQ3cxd3RmMzFtK1I5NDNK?= =?eucgb2312_cn?b?SVI0VjA5ekZickhPbmZhaGNnK3BMV2x2ZHBmMmdCbHN2YUpMelE5Z25UVElENmh1?= =?eucgb2312_cn?b?OE9JckJzYVBqWGFlMmUvaWszeTU0aDF5ZXRPT1B6MzJnWm10Nkk5bldNaDliSTYr?= =?eucgb2312_cn?b?cE5RczJ0TjNRRWJpU2NpdXcrN2FXMGY5dWZVT25oQ1NFaFFsRDhKUjQzRzBZOC9Q?= =?eucgb2312_cn?b?Sy9Vc1lhSjA0RXYvOXdMNXpBN2RCeFFROGgvY2RhdTB1dXptc2lZVXlzNHJlZzB3?= =?eucgb2312_cn?b?K0d2b0lYNldmTE1Tb2NRZ0dScml3K0IwNWhwTk51T2tQS3JhY3NRY0l3NndJaGJq?= =?eucgb2312_cn?b?Z3FKdUJIUTc2d013S1VUQmZRMzZMbXh5aWFUelBxVFRjcm1aY0lYa3JLNXgzVUxn?= =?eucgb2312_cn?b?QnhpSXMxVTNoS3hINFdxNEhXbWorUklzUCtkeUZ1LzVzWlpkVlE5THZsYzRjOTdQ?= =?eucgb2312_cn?b?WWFEYTg0SjFPd1Zma1hQWVltZ2JmZjZTb1FQZnh3V0t0UEFwdEpRTHBURHMyaVFW?= =?eucgb2312_cn?b?MlZlNERETGlvK1lIODU3VXNScE9FMFRQazJ6UUN0QWxkQkRKay9TaEk1LzFBR1I1?= =?eucgb2312_cn?b?dFdxcFJoUDkwVTAzNlVoU0U4L1VrZ1dkTDdIQkpFazcvUXBvOUpZV2phT2YyMFV4?= =?eucgb2312_cn?b?OUwxMFBaT2RQQVlkbmczZEp0NlZyay92dG5BQVhyZVlmTVMyOXZBaExXMU8xSkM4?= =?eucgb2312_cn?b?NWl4ZERPNFdkRFc1eUJ5RkhsVi8vR3QvaWZ3ZWZQOGRYcFNPRmJQbm55VnpkalN5?= =?eucgb2312_cn?b?cHoyV2d5YzRzWDZQcFBpU21FbzFEVlRRYzBGcmJxSGwxdWo5UWkyMDdDM0M3M0E2?= =?eucgb2312_cn?b?TlBvSWJ0MWxzdEt2K05NNHA1bUpidVZJVWJSYU54NDBkUDEvZ2Z2RDlJTDNnbXlX?= =?eucgb2312_cn?b?NlByR2g1RXB5QkJiTW9QWWdDZlB0TnVod2lwRDFxNUs5S2huOVdyOTlPSTlOQ3Bu?= =?eucgb2312_cn?b?bFZiR1BaMVV0b0FFUWFPeUU2N2llNmdLN09OZXlQak1ORXY0RStFMC9Ha1JoQlJ0?= =?eucgb2312_cn?b?Z1FLWnAzODVTdGN0ZDBrZm9UdFVSd1FlcTEzTG5ZTXY2dVRpSzA1dVVKUzlWalY4?= =?eucgb2312_cn?b?RnhLaHNrd1gxdFJ5Y2hQMWVrVzVNb3ZSaGtuVWI1ajBqZnViR1E2dlJoYzVLczU5?= =?eucgb2312_cn?b?VHIwRlVJWkZGNlg4YUpSd3pwZDRNTDlLenYvOXZpWTlhTkh2aXQwT2p5MUM3czdQ?= =?eucgb2312_cn?b?SVppY3pWSUlWZlBaVEZRUzBWQ2hVQ3N4aGMxUnVyWlRmL3FCdG1Ib3FSdHBhZ1gz?= =?eucgb2312_cn?b?ckYvVTdaTHhjTTRhVk50M0tXVkRPQnFWQlBhQ0lvOS9zazVzWWxvZC93bG1kOS9P?= =?eucgb2312_cn?b?NnNacDBQS3JjWE80NDd0T2dpenRSWHBIREhJNnFTWFYycHRFb0NQVmUvQXcxQUIx?= =?eucgb2312_cn?b?Ri8xZHVZYzJ5T2lrOGM5d3FtYy9hWVdEbnFIZy9YZGJJRm0rRm4zRlcyWDRQdkVj?= =?eucgb2312_cn?b?V051T2NSQzNvV05aUDVjNG5sQ1ZGZExnZ2dUaitWcVR4QUwvYjJxSFlyMkM3NDRx?= =?eucgb2312_cn?b?ckhzS1ROUGVvcG9xekVsNVlKVFJUOU5ZblBKcktRTU1Vay92Zlg4c2hERjk1SEZ0?= =?eucgb2312_cn?b?enkwSVVUeXJxNVkyTVJLUGthektqOXJTQWtkb0M1bnNMc3RKNTY2eG5wVU5Zd0pN?= =?eucgb2312_cn?b?TjVGK0lLc1U0Q1dmVi83WkJyaHR4ZmRVL3NMYmdESWNvaE5oamxHWnFyU3hmR1hL?= =?eucgb2312_cn?b?OHA0ZkxONGtzMU9CV2xCci9qSVlucmVBcHhlb1phUXl2Si8rL2Urc3dHVHYyVVVz?= =?eucgb2312_cn?b?d3plR0ZRSEkzRjZjSXV6R1R2anpiSDJabWpyRUd3VTBrZVV4RkJQZklienZGbDZQ?= =?eucgb2312_cn?b?WjAxWkV6ZzdSTmtOdDNJeXhLZmlKSG1Gd0MrZ3ZCNDdDT29BOFRmcTBqMGJrUGwy?= =?eucgb2312_cn?b?SmZaalpwWmtpU29LQjBLVCtSMzVBMUpDZG1jdFBzdStROTY0V1Y1QXpBQnF1MEs3?= =?eucgb2312_cn?b?MEwyczJVYjVvcFJDUEVvdzFReXJBTGR0bHUrLytCOSt5RUdLOURHelV0OVY0VkF2?= =?eucgb2312_cn?b?bU1jaUhodDVNNDNVeDhMTUJZbGc9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB9499.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e29b7073-3dbe-499d-b87a-08da96306dda X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2022 09:06:37.1525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t2K4Rr5A6Dgg9X7IFPO7bLBB9H9iXlbR0BtT/C7QZUf3NLcFUQ3qKzyzfsGoJnHY4iM2Wlf2l/OwoHMgDZ4dqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5629 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org This reverts commit fc5870da485aec0f9196a0f2bed32f73f6b2c664 generic/470 was original designed to verify mmap(MAP_SYNC) on the log-writes device enabling DAX. As a result, we need to ensure that all underlying devices under the log-writes device support DAX. However the thin-volume device never supports DAX so generic/470 with the dm-thin device always gets "[not run] Cannot use thin-pool devices on DAX capable block devices". Besides, mmap(MAP_SYNC) will throw "mmap: Operation not supported" even if we make generic/470 continue unconditionally. Please see the difference between old and new logic: old logic new logic ------------------------------------------------------------ log-writes device(DAX) log-writes device(DAX) | | PMEM0(DAX) + PMEM1(DAX) thin-volume(non-DAX) + PMEM1(DAX) | PMEM0(DAX) ------------------------------------------------------------ I think it is wrong for generic/470 to use thin volume. Signed-off-by: Xiao Yang --- tests/generic/470 | 23 ++++++----------------- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/tests/generic/470 b/tests/generic/470 index f3407511..93a6e3f4 100755 --- a/tests/generic/470 +++ b/tests/generic/470 @@ -15,33 +15,22 @@ _cleanup() { cd / _log_writes_cleanup - _dmthin_cleanup rm -f $tmp.* } # Import common functions. . ./common/filter -. ./common/dmthin . ./common/dmlogwrites # real QA test starts here _supported_fs generic -_require_scratch_nocheck +_require_scratch _require_no_logdev _require_log_writes_dax_mountopt "dax" -_require_dm_target thin-pool _require_xfs_io_command "mmap" "-S" _require_xfs_io_command "log_writes" -devsize=$((1024*1024*200 / 512)) # 200m phys/virt size -csize=$((1024*64 / 512)) # 64k cluster size -lowspace=$((1024*1024 / 512)) # 1m low space threshold - -# Use a thin device to provide deterministic discard behavior. Discards are used -# by the log replay tool for fast zeroing to prevent out-of-order replay issues. -_dmthin_init $devsize $devsize $csize $lowspace - -_log_writes_init $DMTHIN_VOL_DEV +_log_writes_init $SCRATCH_DEV _log_writes_mkfs >> $seqres.full 2>&1 _log_writes_mount -o dax @@ -54,14 +43,14 @@ $XFS_IO_PROG -t -c "truncate $LEN" -c "mmap -S 0 $LEN" -c "mwrite 0 $LEN" \ # Unmount the scratch dir and tear down the log writes target _log_writes_unmount _log_writes_remove -_dmthin_check_fs +_check_scratch_fs # destroy previous filesystem so we can be sure our rebuild works -_mkfs_dev $DMTHIN_VOL_DEV >> $seqres.full 2>&1 +_scratch_mkfs >> $seqres.full 2>&1 # check pre-unmap state -_log_writes_replay_log preunmap $DMTHIN_VOL_DEV -_dmthin_mount +_log_writes_replay_log preunmap $SCRATCH_DEV +_scratch_mount # We should see $SCRATCH_MNT/test as having 1 MiB in block allocations du -sh $SCRATCH_MNT/test | _filter_scratch | _filter_spaces