From patchwork Mon Sep 19 06:37:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 12979703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DC1CC54EE9 for ; Mon, 19 Sep 2022 06:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=9cWhRlbfIxTLBUsDSjl9jPY+ai154zAQdByq8UKhWmE=; b=IxH5MPWVthmA2v S4UhkQ+6M9uI2XhyyrPwvOosNpuweLmv2gEEh4TwJF69Tfy4EDjisD1W7L7dtWf81Qk+m6lZdY/tI EnOP6jlVhVLlLcNX45gshqoU1zdphudkSZdMmJYMFthoKPVvPRJYnDxnAwFF7dfNPYhzgvzBIwmlh IhGn0TvPZdE/2Ktx02dZnOg7AWDY4Bo3ZaGq9zMsUZUy6UTc1KBmpf9CugVROFPOwO6uCs2FjLC4p QW0t9abR9Wev77B2iotUV91f6wjgGQywfqRKBiTF6fsdtOsrthDV0f5AbDUspvHhUgcKivVoAD2oD rWNRuvLphGR2WKBKRzdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaARB-008l1M-Dk; Mon, 19 Sep 2022 06:39:25 +0000 Received: from [211.20.114.71] (helo=twspam01.aspeedtech.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaAR7-008kyU-IT for linux-arm-kernel@lists.infradead.org; Mon, 19 Sep 2022 06:39:23 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 28J6GVap079123; Mon, 19 Sep 2022 14:16:32 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Sep 2022 14:37:13 +0800 From: Neal Liu To: Herbert Xu CC: Randy Dunlap , "David S . Miller" , Joel Stanley , Andrew Jeffery , , , , , kernel test robot Subject: [PATCH] crypto: aspeed: fix build error when only CRYPTO_DEV_ASPEED is enabled Date: Mon, 19 Sep 2022 14:37:05 +0800 Message-ID: <20220919063705.358225-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 28J6GVap079123 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220918_233921_918205_732953B7 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix build error within the following configs setting: - CONFIG_CRYPTO_DEV_ASPEED=y - CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH is not set - CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO is not set Error messages: make[4]: *** No rule to make target 'drivers/crypto/aspeed/aspeed_crypto.o' , needed by 'drivers/crypto/aspeed/built-in.a'. make[4]: Target '__build' not remade because of errors. Reported-by: kernel test robot Signed-off-by: Neal Liu --- drivers/crypto/aspeed/Kconfig | 3 +-- drivers/crypto/aspeed/Makefile | 7 ++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/aspeed/Kconfig b/drivers/crypto/aspeed/Kconfig index ae3eb0eb57f6..ae2710ae8d8f 100644 --- a/drivers/crypto/aspeed/Kconfig +++ b/drivers/crypto/aspeed/Kconfig @@ -1,6 +1,7 @@ config CRYPTO_DEV_ASPEED tristate "Support for Aspeed cryptographic engine driver" depends on ARCH_ASPEED || COMPILE_TEST + select CRYPTO_ENGINE help Hash and Crypto Engine (HACE) is designed to accelerate the throughput of hash data digest, encryption and decryption. @@ -20,7 +21,6 @@ config CRYPTO_DEV_ASPEED_DEBUG config CRYPTO_DEV_ASPEED_HACE_HASH bool "Enable Aspeed Hash & Crypto Engine (HACE) hash" depends on CRYPTO_DEV_ASPEED - select CRYPTO_ENGINE select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 @@ -34,7 +34,6 @@ config CRYPTO_DEV_ASPEED_HACE_HASH config CRYPTO_DEV_ASPEED_HACE_CRYPTO bool "Enable Aspeed Hash & Crypto Engine (HACE) crypto" depends on CRYPTO_DEV_ASPEED - select CRYPTO_ENGINE select CRYPTO_AES select CRYPTO_DES select CRYPTO_ECB diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile index 3be78cec0ecb..a0ed40ddaad1 100644 --- a/drivers/crypto/aspeed/Makefile +++ b/drivers/crypto/aspeed/Makefile @@ -1,6 +1,7 @@ -hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace.o aspeed-hace-hash.o -hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace.o aspeed-hace-crypto.o +hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace-hash.o +hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace-crypto.o obj-$(CONFIG_CRYPTO_DEV_ASPEED) += aspeed_crypto.o -aspeed_crypto-objs := $(hace-hash-y) \ +aspeed_crypto-objs := aspeed-hace.o \ + $(hace-hash-y) \ $(hace-crypto-y)