From patchwork Tue Sep 20 03:03:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sireesh Kodali X-Patchwork-Id: 12981274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFEDC54EE9 for ; Tue, 20 Sep 2022 03:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229575AbiITDDt (ORCPT ); Mon, 19 Sep 2022 23:03:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiITDDn (ORCPT ); Mon, 19 Sep 2022 23:03:43 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0E6658527; Mon, 19 Sep 2022 20:03:40 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id h188so1174973pgc.12; Mon, 19 Sep 2022 20:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=IHv+se6PCST4Oao8xK2ZgRiscYBxXE1DiDrvnYlWrIY=; b=NXCegjGzPUIaiuBhU/qR9JqeK5hJjCZdKxe3wIGzQwuVRmK/5e6xX2+wxJaBwDj7yQ tFtt60TsXyCvkN2ZE+1jhh/y9C/6BtxTyNNhWupu2cJeAtUPgyVZrYqOQLAyro+Q0mrb dk45XPlBec5QDZ5CFAE4zaZ5NgsfHGxjHKRCt2CrvwBYocc/SBOvHJulr1O+aQUdM/Ht ZjJ4lgrdXP+ZhADVLpEk7OTiTDBxmCVqmKxlWRVobxQyQY7fST16LzN1/qqmJ/kUtB7p CuUe0vc+XxvC0Bn6LxZEEDWN+4RWlz5CPLV57vbEGn0D63L52Ul2amMlOMq4KNU8p69L N7AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=IHv+se6PCST4Oao8xK2ZgRiscYBxXE1DiDrvnYlWrIY=; b=ZdDssZtXFJcj7wp0xFzfKo33PIc72iI/3rcRGsK5lknxKl8ggPIPh2ZCTXeh06FW4U VNCDKL6vo8coK3H/CkLb+KN2/N8t7m+SmmLSQqT57+xjOl1chXBUcBsZ269Byw2KHwbj F8+hNLhYUruwzaVNL/0wgW1Vrx9lal1FAe68zmjTQzvoeWIDZnaykZG7mWKgZgndnNSl /mOIHVknTYQN8CRcrTVl/jqvLlwS+QozztFPmyb/RNcB6ocDluduNQg9XkaibspIgsSO pQokFhKt5z1DxBFvm+2w/YQOjt5i5VPJCVAhVXJQab+2HAqQ/VB+D7+in+MsGBoTcXrj m/iA== X-Gm-Message-State: ACrzQf1r3tj9bMB1ynZKehJ25ubTHrPopg7qqmqwqrzHa0/0WtC0WxXI 1bV+sNBHE2fPH2WO3XzzkpymFQwG/4nzHQ== X-Google-Smtp-Source: AMsMyM4GBHdSc51aiMUpdWHQNLXwGmTJWsrmxM0193CCuRgMdKWWwiKUm5a1KDhi/rol0HCopo+opA== X-Received: by 2002:a65:464d:0:b0:439:246e:8091 with SMTP id k13-20020a65464d000000b00439246e8091mr18510462pgr.295.1663643019989; Mon, 19 Sep 2022 20:03:39 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:8a0f:392d:db19:673c:627a]) by smtp.googlemail.com with ESMTPSA id t193-20020a635fca000000b0043a18cef977sm171083pgb.13.2022.09.19.20.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 20:03:39 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Cc: andersson@kernel.org, Vladimir Lypak , Sireesh Kodali , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/4] remoteproc: qcom: qcom_wcnss: Add support for pronto-v3 Date: Tue, 20 Sep 2022 08:33:13 +0530 Message-Id: <20220920030316.1619781-2-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220920030316.1619781-1-sireeshkodali1@gmail.com> References: <20220920030316.1619781-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org From: Vladimir Lypak Pronto-v3 is similar to pronto-v2. It requires two power domains, and it requires the xo clock. It is used on the MSM8953 platform. Signed-off-by: Vladimir Lypak Signed-off-by: Sireesh Kodali --- drivers/remoteproc/qcom_wcnss.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index 68f37296b151..ff18bfae5eb6 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -141,6 +141,18 @@ static const struct wcnss_data pronto_v2_data = { .num_vregs = 1, }; +static const struct wcnss_data pronto_v3_data = { + .pmu_offset = 0x1004, + .spare_offset = 0x1088, + + .pd_names = { "mx", "cx" }, + .vregs = (struct wcnss_vreg_info[]) { + { "vddpx", 1800000, 1800000, 0 }, + }, + .num_pd_vregs = 2, + .num_vregs = 1, +}; + static int wcnss_load(struct rproc *rproc, const struct firmware *fw) { struct qcom_wcnss *wcnss = (struct qcom_wcnss *)rproc->priv; @@ -675,6 +687,7 @@ static const struct of_device_id wcnss_of_match[] = { { .compatible = "qcom,riva-pil", &riva_data }, { .compatible = "qcom,pronto-v1-pil", &pronto_v1_data }, { .compatible = "qcom,pronto-v2-pil", &pronto_v2_data }, + { .compatible = "qcom,pronto-v3-pil", &pronto_v3_data }, { }, }; MODULE_DEVICE_TABLE(of, wcnss_of_match); From patchwork Tue Sep 20 03:03:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sireesh Kodali X-Patchwork-Id: 12981276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A062CC6FA92 for ; Tue, 20 Sep 2022 03:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiITDDz (ORCPT ); Mon, 19 Sep 2022 23:03:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbiITDDv (ORCPT ); Mon, 19 Sep 2022 23:03:51 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3373158527; Mon, 19 Sep 2022 20:03:49 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id t70so1206694pgc.5; Mon, 19 Sep 2022 20:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=xiJ4eakZRhBliS0FKYx5g+Igo+LUyI4eBKYE7J68wu0=; b=gEpk7h2DrBcKM5H5XHlb6W79aPPgBdeBlCtDAabfdnZwqYYkihsivjJye0KGRQLTSd MFpuXtclcroPPaTHk/uFK3dGlL+pNOI1x+7DehpW+l5ud7pS6Rx+t6T0aQiy5SsyRZ+3 qgcZYi/ngphtTrAQgEu9Jeo/qfAZcQ6qLO6oUvljgMXszALfFDV8zNrX3oHfstcdujGi Ny858kESfgQyQr9mBBp/kmUZGGZTU1bAwRocLfKKbv4rBTN2isBK9RumWb6/9YjX98Lt cq83dxSfwOcqW7pcmhyoJBo2gRzKGymQNm45e7F4l6n2N0XAwdacilIrtYElQPj6+8Ln EgVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=xiJ4eakZRhBliS0FKYx5g+Igo+LUyI4eBKYE7J68wu0=; b=JPi2m+KEUHF4gnPEynlfiYSpCzOr/FJYxYxfGZh46MDH50putYOP+xKgqaU/DXS24E dVqrhoQhbkoNWy1W0kIaJ8KvaZ+bG4vzE5jNIrD9wCNlFN8UhqALWH5d4ljCylrOj9i+ POwaoBcbMbfaseWDAhykPg8WOygE7UR6OskBT/XbXBnzejDKgHCjownTYXi9mFWGMr8F jDGY9tavuwIpHE6oYxzEU/Y/mprV1FOOD/5YKqxBL39t8EuYAVRCGpwdTOBEEX9niUBT 9XW/LwmI5l3V4cRjuxiVuZ0RAb1/226PwGCkeCVGIvTovN9uDJXUgv+o03e8FugwGHk/ HDRw== X-Gm-Message-State: ACrzQf1WJDscSZrKrt3S5e5gLw2f2TW5uNl1N43vNEeXG1/7HWZRmlYG wKc81kTw7gGjucIjULQRCe170g+kXta1wA== X-Google-Smtp-Source: AMsMyM4COtz2slNzGDFh3gL/o22M3q9tImTXWOTeDkLfYBBOje9Z/JI4xrCDWUGe1QL36b6J7FSKtQ== X-Received: by 2002:a63:81c2:0:b0:439:fbd1:7bab with SMTP id t185-20020a6381c2000000b00439fbd17babmr9605844pgd.33.1663643028140; Mon, 19 Sep 2022 20:03:48 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:8a0f:392d:db19:673c:627a]) by smtp.googlemail.com with ESMTPSA id t193-20020a635fca000000b0043a18cef977sm171083pgb.13.2022.09.19.20.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 20:03:47 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Cc: andersson@kernel.org, Sireesh Kodali , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 2/4] dt-bindings: remoteproc: qcom: Convert wcnss documentation to YAML Date: Tue, 20 Sep 2022 08:33:14 +0530 Message-Id: <20220920030316.1619781-3-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220920030316.1619781-1-sireeshkodali1@gmail.com> References: <20220920030316.1619781-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org This is a direct conversion of the existing txt documentation to YAML. It is in preparation for the addition of pronto-v3 to the docs. This patch doesn't document any of the existing subnodes/properties that are not documented in the existing txt file. That is done in a separate patch. Signed-off-by: Sireesh Kodali --- .../bindings/remoteproc/qcom,wcnss-pil.txt | 177 ------------ .../bindings/remoteproc/qcom,wcnss-pil.yaml | 267 ++++++++++++++++++ 2 files changed, 267 insertions(+), 177 deletions(-) delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt deleted file mode 100644 index ac423f4c3f1b..000000000000 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt +++ /dev/null @@ -1,177 +0,0 @@ -Qualcomm WCNSS Peripheral Image Loader - -This document defines the binding for a component that loads and boots firmware -on the Qualcomm WCNSS core. - -- compatible: - Usage: required - Value type: - Definition: must be one of: - "qcom,riva-pil", - "qcom,pronto-v1-pil", - "qcom,pronto-v2-pil" - -- reg: - Usage: required - Value type: - Definition: must specify the base address and size of the CCU, DXE and - PMU register blocks - -- reg-names: - Usage: required - Value type: - Definition: must be "ccu", "dxe", "pmu" - -- interrupts-extended: - Usage: required - Value type: - Definition: must list the watchdog and fatal IRQs and may specify the - ready, handover and stop-ack IRQs - -- interrupt-names: - Usage: required - Value type: - Definition: should be "wdog", "fatal", optionally followed by "ready", - "handover", "stop-ack" - -- firmware-name: - Usage: optional - Value type: - Definition: must list the relative firmware image path for the - WCNSS core. Defaults to "wcnss.mdt". - -- vddmx-supply: (deprecated for qcom,pronto-v1/2-pil) -- vddcx-supply: (deprecated for qcom,pronto-v1/2-pil) -- vddpx-supply: - Usage: required - Value type: - Definition: reference to the regulators to be held on behalf of the - booting of the WCNSS core - -- power-domains: - Usage: required (for qcom,pronto-v1/2-pil) - Value type: - Definition: reference to the power domains to be held on behalf of the - booting of the WCNSS core - -- power-domain-names: - Usage: required (for qcom,pronto-v1/2-pil) - Value type: - Definition: must be "cx", "mx" - -- qcom,smem-states: - Usage: optional - Value type: - Definition: reference to the SMEM state used to indicate to WCNSS that - it should shut down - -- qcom,smem-state-names: - Usage: optional - Value type: - Definition: should be "stop" - -- memory-region: - Usage: required - Value type: - Definition: reference to reserved-memory node for the remote processor - see ../reserved-memory/reserved-memory.txt - -= SUBNODES -A required subnode of the WCNSS PIL is used to describe the attached rf module -and its resource dependencies. It is described by the following properties: - -- compatible: - Usage: required - Value type: - Definition: must be one of: - "qcom,wcn3620", - "qcom,wcn3660", - "qcom,wcn3660b", - "qcom,wcn3680" - -- clocks: - Usage: required - Value type: - Definition: should specify the xo clock and optionally the rf clock - -- clock-names: - Usage: required - Value type: - Definition: should be "xo", optionally followed by "rf" - -- vddxo-supply: -- vddrfa-supply: -- vddpa-supply: -- vdddig-supply: - Usage: required - Value type: - Definition: reference to the regulators to be held on behalf of the - booting of the WCNSS core - - -The wcnss node can also have an subnode named "smd-edge" that describes the SMD -edge, channels and devices related to the WCNSS. -See ../soc/qcom/qcom,smd.yaml for details on how to describe the SMD edge. - -= EXAMPLE -The following example describes the resources needed to boot control the WCNSS, -with attached WCN3680, as it is commonly found on MSM8974 boards. - -pronto@fb204000 { - compatible = "qcom,pronto-v2-pil"; - reg = <0xfb204000 0x2000>, <0xfb202000 0x1000>, <0xfb21b000 0x3000>; - reg-names = "ccu", "dxe", "pmu"; - - interrupts-extended = <&intc 0 149 1>, - <&wcnss_smp2p_slave 0 0>, - <&wcnss_smp2p_slave 1 0>, - <&wcnss_smp2p_slave 2 0>, - <&wcnss_smp2p_slave 3 0>; - interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; - - power-domains = <&rpmpd MSM8974_VDDCX>, <&rpmpd MSM8974_VDDMX>; - power-domain-names = "cx", "mx"; - - vddpx-supply = <&pm8941_s3>; - - qcom,smem-states = <&wcnss_smp2p_out 0>; - qcom,smem-state-names = "stop"; - - memory-region = <&wcnss_region>; - - pinctrl-names = "default"; - pinctrl-0 = <&wcnss_pin_a>; - - iris { - compatible = "qcom,wcn3680"; - - clocks = <&rpmcc RPM_CXO_CLK_SRC>, <&rpmcc RPM_CXO_A2>; - clock-names = "xo", "rf"; - - vddxo-supply = <&pm8941_l6>; - vddrfa-supply = <&pm8941_l11>; - vddpa-supply = <&pm8941_l19>; - vdddig-supply = <&pm8941_s3>; - }; - - smd-edge { - interrupts = <0 142 1>; - - qcom,ipc = <&apcs 8 17>; - qcom,smd-edge = <6>; - qcom,remote-pid = <4>; - - label = "pronto"; - - wcnss { - compatible = "qcom,wcnss"; - qcom,smd-channels = "WCNSS_CTRL"; - - qcom,mmio = <&pronto>; - - bt { - compatible = "qcom,wcnss-bt"; - }; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml new file mode 100644 index 000000000000..bb499ae9a4f0 --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -0,0 +1,267 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,wcnss-pil.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm WCNSS Peripheral Image Loader + +maintainers: + - Bjorn Andersson + +description: + This document defines the binding for a component that loads and boots + firmware on the Qualcomm WCNSS core. + +properties: + compatible: + enum: + - qcom,riva-pil + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + + reg: + maxItems: 3 + description: + The base address and size of the CCU, DXE and PMU register blocks + + reg-names: + items: + - const: ccu + - const: dxe + - const: pmu + + interrupts: + minItems: 2 + maxItems: 5 + + interrupt-names: + minItems: 2 + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Relative firmware image path for the WCNSS core. Defaults to + "wcnss.mdt". + + vddpx-supply: + description: + PX regulator to be held on behalf of the booting of the WCNSS core + + vddmx-supply: + description: + MX regulator to be held on behalf of the booting of the WCNSS core. + + vddcx-supply: + description: + CX regulator to be held on behalf of the booting of the WCNSS core. + + power-domains: + maxItems: 2 + + power-domain-names: + items: + - const: cx + - const: mx + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + States used by the AP to signal the WCNSS core that it should shutdown + items: + - description: Stop the modem + + qcom,smem-state-names: + description: The names of the state bits used for SMP2P output + items: + - const: stop + + memory-region: + maxItems: 1 + description: reserved-memory for the WCNSS core + + smd-edge: + $ref: /schemas/remoteproc/qcom,smd-edge.yaml# + description: + Qualcomm Shared Memory subnode which represents communication edge, + channels and devices related to the ADSP. + + iris: + type: object + description: + The iris subnode of the WCNSS PIL is used to describe the attached RF module + and its resource dependencies. + + properties: + compatible: + enum: + - qcom,wcn3620 + - qcom,wcn3660 + - qcom,wcn3660b + - qcom,wcn3680 + + clocks: + minItems: 1 + items: + - description: XO clock + - description: RF clock + + clock-names: + minItems: 1 + items: + - const: xo + - const: rf + + vddxo-supply: + description: + Reference to the regulator to be held on behalf of the booting WCNSS + core + + vddrfa-supply: + description: + Reference to the regulator to be held on behalf of the booting WCNSS + core + + vddpa-supply: + description: + Reference to the regulator to be held on behalf of the booting WCNSS + core + + vdddig-supply: + description: + Reference to the regulator to be held on behalf of the booting WCNSS + core + + required: + - compatible + - clocks + - clock-names + - vddxo-supply + - vddrfa-supply + - vddpa-supply + - vdddig-supply + +required: + - compatible + - reg + - reg-names + - interrupts-extended + - interrupt-names + - iris + - vddpx-supply + - memory-region + - smd-edge + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + const: qcom,riva-pil + then: + required: + - vddcx-supply + - vddmx-supply + + - if: + properties: + compatible: + contains: + enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + then: + properties: + vddmx-supply: + deprecated: true + description: Deprecated for qcom,pronto-v1/2-pil + + vddcx-supply: + deprecated: true + description: Deprecated for qcom,pronto-v1/2-pil + + required: + - power-domains + - power-domain-names + +examples: + - | + #include + #include + #include + pronto@a21b000 { + compatible = "qcom,pronto-v2-pil", "qcom,pronto"; + reg = <0x0a204000 0x2000>, <0x0a202000 0x1000>, <0x0a21b000 0x3000>; + reg-names = "ccu", "dxe", "pmu"; + + interrupts-extended = <&intc GIC_SPI 149 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, + <&wcnss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; + + power-domains = <&rpmpd MSM8916_VDDCX>, <&rpmpd MSM8916_VDDMX>; + power-domain-names = "cx", "mx"; + + vddpx-supply = <&pm8916_l7>; + + qcom,smem-states = <&wcnss_smp2p_out 0>; + qcom,smem-state-names = "stop"; + + memory-region = <&wcnss_region>; + + pinctrl-names = "default"; + pinctrl-0 = <&wcnss_pin_a>; + + iris { + compatible = "qcom,wcn3620"; + vddxo-supply = <&pm8916_l7>; + vddrfa-supply = <&pm8916_s3>; + vddpa-supply = <&pm8916_l9>; + vdddig-supply = <&pm8916_l5>; + + clocks = <&rpmcc RPM_SMD_RF_CLK2>; + clock-names = "xo"; + }; + + smd-edge { + interrupts = ; + + qcom,ipc = <&apcs 8 17>; + qcom,smd-edge = <6>; + qcom,remote-pid = <4>; + + label = "pronto"; + + wcnss_ctrl: wcnss { + compatible = "qcom,wcnss"; + qcom,smd-channels = "WCNSS_CTRL"; + + qcom,mmio = <&pronto>; + + bluetooth { + compatible = "qcom,wcnss-bt"; + }; + + wifi { + compatible = "qcom,wcnss-wlan"; + + interrupts = , + ; + interrupt-names = "tx", "rx"; + + qcom,smem-states = <&apps_smsm 10>, <&apps_smsm 9>; + qcom,smem-state-names = "tx-enable", "tx-rings-empty"; + }; + }; + }; + }; From patchwork Tue Sep 20 03:03:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sireesh Kodali X-Patchwork-Id: 12981277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C58EC6FA82 for ; Tue, 20 Sep 2022 03:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbiITDEA (ORCPT ); Mon, 19 Sep 2022 23:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbiITDD4 (ORCPT ); Mon, 19 Sep 2022 23:03:56 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F2358B4D; Mon, 19 Sep 2022 20:03:54 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id b23so1451770pfp.9; Mon, 19 Sep 2022 20:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=+3eju7uhrhrPGpe9XN04gsAsv03pWlu1T8bRnciTvXY=; b=oILFDOvKt0Nwhx4ckErDPUov3ejPkKnaW9Cet8ChQenqDx+XwBS2ulIeZqt/vOQlUN UBl0eljyCNU3/WkeeKJHeEqhdvasZ/u15/4eEvT9IhZdQ3IJAjdhhzQgOmaVQQSZGY34 0fiuXAfuoT/r0z7ZfwHVh/eYcSANlfH2eSdOqPbJHztWkTfUCwln4XfLwGGU54j6zz/8 CH/Tw28NPyI+Ygu2w8bLsCp2WodV8dFuRHQB7yOE0hh4Apurkpr9h371SSRuo95Bz20b TBPAHiqlK77KRu8Jya3lacipdLXHkqJDx+LrM8e4TJB9qfiyRe4HXNhHD1pVM2tRSvFj 5Nog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=+3eju7uhrhrPGpe9XN04gsAsv03pWlu1T8bRnciTvXY=; b=ZP1KelDguehvsTW6UrFr6DrfG3pTl68QDCr7bqPNFWZ63cYS+DK5M3Fp/+oJ4qIaGy QInYqfh7FKVqYfFgLGaGngP4Ovb1NdgQQ78w9Qi5t2yJu/fNwp/OsDVcFTcuIs35hmZX z0j+rHSc8c12KbPJnuXkiT6s/mvggaDl1wDkxdlt2VLzYQqN8OX/61Dt4WDja3T7/w6T JaULYRRoliBOTgPZLcG3IK4I4HW910iRSzcuaMpyFiaN26NkWJbj2LPRmoFvIscb2UfX yfORhmjxHpz0/ZNrnzbAodljbyzc7EEnSy6Tl8Uk19GhkU2CQmEHJ9wNakqWHCCukJjG wtAg== X-Gm-Message-State: ACrzQf1DAYm2ZmdXORoTCHvwD5TC0dkO646TdB+gbbn0GL7I5SY/vHnK XVV3eJ2JqtXXq6R5Z5Dv1Zozx37481xemw== X-Google-Smtp-Source: AMsMyM6Y9MR8VWMfkGukz6soHNJTZJ3gq0xGxlNzkf6dDkUjROwudAaTkwNMoadvTs0WKSzGU4kTxQ== X-Received: by 2002:a63:e909:0:b0:438:c9c9:61e3 with SMTP id i9-20020a63e909000000b00438c9c961e3mr18490380pgh.194.1663643033509; Mon, 19 Sep 2022 20:03:53 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:8a0f:392d:db19:673c:627a]) by smtp.googlemail.com with ESMTPSA id t193-20020a635fca000000b0043a18cef977sm171083pgb.13.2022.09.19.20.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 20:03:53 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Cc: andersson@kernel.org, Sireesh Kodali , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 3/4] dt-bindings: remoteproc: qcom: wcnss: Add qcom,pronto compatible Date: Tue, 20 Sep 2022 08:33:15 +0530 Message-Id: <20220920030316.1619781-4-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220920030316.1619781-1-sireeshkodali1@gmail.com> References: <20220920030316.1619781-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org This is not a fallback compatible, it must be present in addition to "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This is the reason for documenting it in a separate commit. This compatible is used in the wcn36xx driver to determine which register must be accessed. However it isn't immediately clear why the wcn36xx driver relies on this extra compatible string rather than just looking for "qcom,pronto-v*". Signed-off-by: Sireesh Kodali --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index bb499ae9a4f0..31232c59b22b 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -15,10 +15,15 @@ description: properties: compatible: - enum: - - qcom,riva-pil - - qcom,pronto-v1-pil - - qcom,pronto-v2-pil + description: + Append "qcom,pronto" if the device is actually pronto, and not riva + oneOf: + - items: + - enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + - const: qcom,pronto + - const: qcom,riva-pil reg: maxItems: 3 From patchwork Tue Sep 20 03:03:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sireesh Kodali X-Patchwork-Id: 12981278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310A6C54EE9 for ; Tue, 20 Sep 2022 03:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbiITDFP (ORCPT ); Mon, 19 Sep 2022 23:05:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbiITDEs (ORCPT ); Mon, 19 Sep 2022 23:04:48 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD66DBCB5; Mon, 19 Sep 2022 20:04:26 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id a80so1474307pfa.4; Mon, 19 Sep 2022 20:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=1ZAgs0EUhexlFlK2MZMbzZ6IVMi8WJy1viUVzYD9emk=; b=mz2nf/kpV65RpPN0RxEjlCpMh7TtltlOTVC6jiGG97yzv1C4MN6RzvyEYIuSmm3OG2 Our5rGPb7SjhuI7BtCKuDLTeRkiA4xYUMmIykzT1wDDOvJiQMQJYLll+cpUUc3Ex9AL4 YnWINGn19qKq6DKXF3Ccwk5TDfy07eS8eVqSSwsZReBLbJBLrERONLNwrqrQ0B3b3y8/ kG7i3GmFTNNHrxcJ/kZIuAf85k6RaYmRsl5zgLh7oEs5na1Gr5+lxooREHsD7yGk5Dsq O/Gzda4ZIwpI/xuJZVseT92X9MJEMv8mSqy1amnhjm+FIAz5Bazg3AFyecau54wTxf30 15qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=1ZAgs0EUhexlFlK2MZMbzZ6IVMi8WJy1viUVzYD9emk=; b=uCXJ914i67ONFbL9BVU30kWR4fDhFyVeqs39Me9AeD+5Rx4Zt46k93m1t+v3PUZCW2 l/vUyP1a0rTvLoVUIMCvX0esYbCSfxCA8ahUEg4xBMrCsZcsgU1UhdrDwfcoHIfTzust 5NWPrfuW/suTz/4f0VvBlLOK8acifHcoiPphAJylnMcpUdFn/AK2iGlUQfv7ZxWuEXMW MuBKSh2i8kJGyRE9owHWbvAvEKW6++mylg37KOlXEbNJVcbUgrtROZdFxJHn0FbRscGp NG2AR9xPkty963ZrmNeMi5c+PbLTfspUQLZCf53MDWzA5vq105fkPRn4SZbmfAiXCKMP ruRg== X-Gm-Message-State: ACrzQf1RDOLV9G25D+mEwEQKams9Q/QROko0sVrGvYJvHfc6+SGZhy+b wt4x5s0eB4kFbCwst+S803pzZZFAN+j2gQ== X-Google-Smtp-Source: AMsMyM4c+NnhvJf5VR8ihN9H6u+dBOlOl1hRfRzYIvJe9+wQ2FGWaeKUq7AcKI69mRRNR2ZnJgH3XQ== X-Received: by 2002:a63:d250:0:b0:435:1774:1f93 with SMTP id t16-20020a63d250000000b0043517741f93mr18422050pgi.339.1663643065471; Mon, 19 Sep 2022 20:04:25 -0700 (PDT) Received: from skynet-linux.local ([2406:7400:61:8a0f:392d:db19:673c:627a]) by smtp.googlemail.com with ESMTPSA id t193-20020a635fca000000b0043a18cef977sm171083pgb.13.2022.09.19.20.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 20:04:24 -0700 (PDT) From: Sireesh Kodali To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Cc: andersson@kernel.org, Sireesh Kodali , Andy Gross , Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 4/4] dt-bindings: remoteproc: qcom: wcnss: Add compatible for pronto v3 Date: Tue, 20 Sep 2022 08:33:16 +0530 Message-Id: <20220920030316.1619781-5-sireeshkodali1@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220920030316.1619781-1-sireeshkodali1@gmail.com> References: <20220920030316.1619781-1-sireeshkodali1@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org The pronto v3 remoteproc is similar to pronto v2. It is found on the MSM8953 platform, which is used by SDM450, SDM625, SDM626, APQ8053 and other SoCs. Since the configuration is same on all SoCs, a single compatible is used. Signed-off-by: Sireesh Kodali --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index 31232c59b22b..639c52284f4f 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -22,6 +22,7 @@ properties: - enum: - qcom,pronto-v1-pil - qcom,pronto-v2-pil + - qcom,pronto-v3-pil - const: qcom,pronto - const: qcom,riva-pil @@ -197,6 +198,21 @@ allOf: - power-domains - power-domain-names + - if: + properties: + compatible: + contains: + enum: + - qcom,pronto-v3-pil + then: + properties: + vddmx-supply: false + vddcx-supply: false + + required: + - power-domains + - power-domain-names + examples: - | #include