From patchwork Sun Sep 25 10:21:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Glathe X-Patchwork-Id: 12987855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509D3C04A95 for ; Sun, 25 Sep 2022 10:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbiIYKVu (ORCPT ); Sun, 25 Sep 2022 06:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbiIYKVt (ORCPT ); Sun, 25 Sep 2022 06:21:49 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0F02F672; Sun, 25 Sep 2022 03:21:47 -0700 (PDT) Received: from [192.168.0.127] ([91.64.235.177]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M6ltQ-1obrKf2lEE-008Ifx; Sun, 25 Sep 2022 12:21:39 +0200 From: "Jens Glathe" To: "Greg KH" Subject: Re[2]: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 25 Sep 2022 10:21:39 +0000 Message-Id: In-Reply-To: References: Reply-To: "Jens Glathe" User-Agent: eM_Client/9.1.2109.0 MIME-Version: 1.0 X-Antivirus: Avast (VPS 220925-0, 25.9.2022), Outbound message X-Antivirus-Status: Clean X-Provags-ID: V03:K1:AS8SpZUFIW+fxoM1N7kzRjiQLDoU1GjBHGHV9m81vmI2SFv26Xf vpgEvnVQKXAA/ksZBEYEUPYzUyKMqerNGk43NOisdXWl2zLzecE/OF8yU+qhatXt6CqzlYY kkqQK5NkDz0CtW4fqlHy/pRCYe0V8bxQRELxi2fwwBAOtmwBLi6du1xPcsacPS3twxePFut t2oXFHrGEcAh/R+VxFTUw== X-UI-Out-Filterresults: notjunk:1;V03:K0:F2MPB5Z5RjY=:CEZLTNNz+Ho5WAK5NqJ4sI bCXb6t/HCJGGU/V5+4Z3DweqsxUhJM1EXwCDn9l2hS3zc25CrwKlSn0LcAPrdQVZRZArCQlCU bgCkeWMUDbidHlJ2WIs1YgsLYt36EHODN8vUpin9YJgudmJhF1HTx7UMfpxIX6YGDLsnofOs4 R3yLaOpnbKRSApfLVtF5nN3Mxp9KXugc/wlg19a1gyRTFQSGvcylF/YKaaVWCQU3aTF3FYpGz JnWnKmaUp7oVRiq8AITXWP6PqC6yTs6o7uiNQ14+pg/p5cEDZdg46cOwYJhwFP4sZiJOTPEAS twcsjA5RItIlD6ezLHhf6DNS6Y1e0GbMx5nQLprBo40YM4VV0gN+e5nMk5+cuNFz0fOPjE8JB 8ze6zT5TTnKAwUihmB1i+VJcs4zV78PlBQw6WfUbr/iYwkCWMxjMq5SEwDRIOG8lgCTFJHO+F nkPLs/WJBnX8qRDCPBSoJak+Esd4SXeq+iSLUL5lbuPPwsW1F5hGqQnN2vomjD4tDJKgfjrdd rYcStEiZ3zsyiocYWCoCNDdIDD0/XIhivn9V2nkjgJP4/R2fMupJ80A2c0pdEw9cuPfAZbEjC jXLgqtNlKTad9D9ySaLxxZLjOri3pXSCs8ytLIAe0ujbI8InU7gdMz0V8jlUhMBlHGt6VASeC 31MKJfiPij6Yh+hF3vtaJZGUANfUMNgYti/1x8ZtmGo6wAshp8UyW6/e/CHZCbSKA+z94BA7V QMPz/5ClzipCZ9ZW6qS6LWwQFg7MjiLscN/knLnxOjVRajGfXVlmkh1yP+Z26otoGHm/EocJU DJjcLCVMOvsLbHilnibz2ldv0aZCA== Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org ... and this is the moment where I append the patch file in hope that this somehow works. with best regards Jens Glathe ------ Originalnachricht ------ Von "Greg KH" An "Jens Glathe" Cc mathias.nyman@intel.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org Datum 25.09.2022 12:07:15 Betreff Re: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller >On Sun, Sep 25, 2022 at 10:02:53AM +0000, Jens Glathe wrote: >>Yep, found it. Them pesky editors... >> >>thanks, >> >>Jens Glathe >> >>--- >> >> > From 8d6e467569118b83a4622edf09768ba20aef5086 Mon Sep 17 00:00:00 2001 >>From: Jens Glathe >>Date: Sun, 28 Aug 2022 16:23:41 +0200 >>Subject: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a >> V0.96 controller >> >>only if it reports as a V0.96 XHCI controller. Appears to fix the errors >>"xhci_hcd
; ERROR Transfer event TRB DMA ptr not part of >>current TD ep_index 2 comp_code 13" that appear spuriously (or pretty >>often) when using a r8152 USB3 ethernet adapter with integrated hub. >> >>Signed-off-by: Jens Glathe >>--- >> drivers/usb/host/xhci-pci.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >>diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c >>index dce6c0ec8d34..d1b8e7148dd1 100644 >>--- a/drivers/usb/host/xhci-pci.c >>+++ b/drivers/usb/host/xhci-pci.c >>@@ -306,8 +306,12 @@ static void xhci_pci_quirks(struct device *dev, struct >>xhci_hcd *xhci) >> } >> >> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && >>- pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) >>+ pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) { >>+ /* try to tame the ASMedia 1042 controller which is 0.96 */ >>+ if (xhci->hci_version == 0x96) >>+ xhci->quirks |= XHCI_SPURIOUS_SUCCESS; >> xhci->quirks |= XHCI_BROKEN_STREAMS; >>+ } >> if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && >> pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) { >> xhci->quirks |= XHCI_TRUST_TX_LENGTH; >>-- >>2.25.1 >> >>--- >> >>replaced spaces with tabs > > >Hi, > >This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him >a patch that has triggered this response. He used to manually respond >to these common problems, but in order to save his sanity (he kept >writing the same thing over and over, yet to different people), I was >created. Hopefully you will not take offence and will fix the problem >in your patch and resubmit it so that it can be accepted into the Linux >kernel tree. > >You are receiving this message because of the following common error(s) >as indicated below: > >- Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > and can not be applied. Please read the file, > Documentation/email-clients.txt in order to fix this. > >- Your patch was attached, please place it inline so that it can be > applied directly from the email message itself. > >- This looks like a new version of a previously submitted patch, but you > did not list below the --- line any changes from the previous version. > Please read the section entitled "The canonical patch format" in the > kernel file, Documentation/SubmittingPatches for what needs to be done > here to properly describe this. > >If you wish to discuss this problem further, or you have questions about >how to resolve this issue, please feel free to respond to this email and >Greg will reply once he has dug out from the pending patches received >from other developers. > >thanks, > >greg k-h's patch email bot From 8d6e467569118b83a4622edf09768ba20aef5086 Mon Sep 17 00:00:00 2001 From: Jens Glathe Date: Sun, 28 Aug 2022 16:23:41 +0200 Subject: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller only if it reports as a V0.96 XHCI controller. Appears to fix the errors "xhci_hcd
; ERROR Transfer event TRB DMA ptr not part of current TD ep_index 2 comp_code 13" that appear spuriously (or pretty often) when using a r8152 USB3 ethernet adapter with integrated hub. Signed-off-by: Jens Glathe --- drivers/usb/host/xhci-pci.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index dce6c0ec8d34..d1b8e7148dd1 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -306,8 +306,12 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) } if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && - pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) + pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) { + /* try to tame the ASMedia 1042 controller which is 0.96 */ + if (xhci->hci_version == 0x96) + xhci->quirks |= XHCI_SPURIOUS_SUCCESS; xhci->quirks |= XHCI_BROKEN_STREAMS; + } if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) { xhci->quirks |= XHCI_TRUST_TX_LENGTH;