From patchwork Tue Sep 27 22:05:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 12991419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 357B2C54EE9 for ; Tue, 27 Sep 2022 22:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbiI0WFM (ORCPT ); Tue, 27 Sep 2022 18:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiI0WFK (ORCPT ); Tue, 27 Sep 2022 18:05:10 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7113D2D44; Tue, 27 Sep 2022 15:05:09 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id q35-20020a17090a752600b002038d8a68fbso69355pjk.0; Tue, 27 Sep 2022 15:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=PnX3CTK8Zi/GFiq6cOApXc7JemEFXP3BVlCstRnzeVE=; b=UZxCiPMdneRhR1zMpsq6m+Za1l+DjCwmsa12S2HstAjJJAGw0wrjYRm6sZUCylDLIH UvAFcV2u+J688aF9AGJ+0kW5aIEUsSle4gI/HkDu/kMb5MzDgY5/60DaiwA85D9zdc+F T7m95eI7arF9MJmNOS9Bw4bsvqe37h6uL2cdh+8pXT5B92x6OIjhMrEo+OzKhIE7sb0x hKl5fGG65VTblomdsVxvixTTuOYrwewaYz7pTo/M+t8XpBxKRxKoI416/bNoiVlzvy1X R40QyK4+S17bdq7ZI8A6ao2YkDEg3RHGmlWbQ/4Al+kNh2iBGd/ADI2OL5lpFMJcinEV Clhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=PnX3CTK8Zi/GFiq6cOApXc7JemEFXP3BVlCstRnzeVE=; b=GgLPR623TA5SurJ6t1N9GMoHrjsBUA7bdN7jrNLrcNKgSKhZG6ywvYJWGsyKCVMt8V 9yd9H7LObSVVJ5KJroJavciG6II7dszPuMsRL7i0g8MEEDuPXE9pkLI01FqAbnP+b+GF ox3prhyyq+glgFHUK6Ms9dMbn0wfAQsJCS4iG99bnmwhbYp4f7xe6wMJxYx3ftaRI8HS OfeBFSrRQ5MO39bidiroqO88i7RD+mCL+NkONpAkWYWUxsDO3RihB18j1pX+G4XlTljC d8MyZXmOXZJNfRr8c7MF2eBIMbqPk/aCHZ5R0tru0vh6zfHvGnYWS5JoUZsKl/xAiq5O IrRw== X-Gm-Message-State: ACrzQf0o7qcFFhexPC1segjIc/9Upo4rW8OUVKqg4wvKGzKgbEvV5O/N Qsl7w++B+uuExA9KlHA098c= X-Google-Smtp-Source: AMsMyM6Qey9ZeFIp1MguvDe3X+YReqLE0XvCk637reYX3ZwJhK/u/om/ItckfnCalVVon+Z4AfAKHQ== X-Received: by 2002:a17:902:d512:b0:178:6946:a2aa with SMTP id b18-20020a170902d51200b001786946a2aamr29503248plg.116.1664316309002; Tue, 27 Sep 2022 15:05:09 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:9739:ab49:3830:2cbb]) by smtp.gmail.com with ESMTPSA id e9-20020a17090301c900b001782398648dsm2051220plh.8.2022.09.27.15.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 15:05:08 -0700 (PDT) From: Dmitry Torokhov To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman Cc: Alan Stern , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ARM: dts: exynos: fix polarity of VBUS GPIO Date: Tue, 27 Sep 2022 15:05:03 -0700 Message-Id: <20220927220504.3744878-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org EHCI Oxynos (drivers/usb/host/ehci-exynos.c) drives VBUS GPIO high when trying to power up the bus, therefore the GPIO in DTS must be marked as "active high". This will be important when EHCI driver is converted to gpiod API that respects declared polarities. Fixes: 4e8991def565 ("ARM: dts: exynos: Enable AX88760 USB hub on Origen board") Signed-off-by: Dmitry Torokhov --- arch/arm/boot/dts/exynos4412-origen.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts index 6db09dba07ff..a3905e27b9cd 100644 --- a/arch/arm/boot/dts/exynos4412-origen.dts +++ b/arch/arm/boot/dts/exynos4412-origen.dts @@ -95,7 +95,7 @@ &exynos_usbphy { }; &ehci { - samsung,vbus-gpio = <&gpx3 5 1>; + samsung,vbus-gpio = <&gpx3 5 GPIO_ACTIVE_HIGH>; status = "okay"; phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>; phy-names = "hsic0", "hsic1"; From patchwork Tue Sep 27 22:05:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 12991420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7B5C54EE9 for ; Tue, 27 Sep 2022 22:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbiI0WFS (ORCPT ); Tue, 27 Sep 2022 18:05:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiI0WFO (ORCPT ); Tue, 27 Sep 2022 18:05:14 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056FEDCCF8; Tue, 27 Sep 2022 15:05:12 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id b5so10590307pgb.6; Tue, 27 Sep 2022 15:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=sSNiRI+ap5x7MQu5aicCdFhgVcBXQnxVbZJ3Z+sJpp8=; b=OOyC2BrocNE0X+rCeeu5h8pK/QD9DXH43+jMmNO5mvsOZ1mxwh/D5n0xieeWhMZMnJ s4nHeJeglfR0/5RU++bvcwYzn6G4IrgSYGOpSs/8vrzWLfC3QhiAjd8d5J0IHFGG72+b jh1EWUQL8qtdxipQcm7saWcg8ckvv4bqxrIgzZDkfiq8H4zxtRZrSJceGlfjpfmA45LF bphWnbtWxfEZXZTatXhOlRTEL4QYDsUTf8Gwpq1uwtwfnsxGgy5PoXKCGaHpmKQiWk6F nwcdWVgZ+JBOENToCG2htL6cs8qi4PaCHV83K/lr5Ni/I/jWFAjJyQKg/VYsy92EPMVP 12DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=sSNiRI+ap5x7MQu5aicCdFhgVcBXQnxVbZJ3Z+sJpp8=; b=z6vpU3MJXDmkqcXoMazgM0SNlJzrVz8bSRedtA+jmdCIc3VCXVqdFQ3uA55qnVFQrX quc7T+Xlz+364BbiBUaGjUQ3KEDoD/YzVeg4FSkxWfUwgsXI11RoVWFxxDqY13S05bMj PgOi5FJDmEZHaxGcUI2WduTOebexg4AzRdTX7rCbkHcSYtPEXnePhoxDCctd6R/t+luX d63MBA7b8A5eFYQsbGlZ0wxhRxX4KkYq3dni75VteFmNdnkvjO7+RzkqDyfE0jEKFicu JXO0F8CZYHb/L3WtwebILctHwRHi2RnnQqGuEeFBWSvG7skMokymccG2UTxJ8yUbrtW/ 1ylA== X-Gm-Message-State: ACrzQf0yAlrpGIun9+0RSxiV4s//Xd0OT9gDq2LXHdqivh2QZZNDnHSl MH9Rmolarxhkl4S4OKK1IyE= X-Google-Smtp-Source: AMsMyM7B+45kOzKa6I+J8lHdpYg6f15aeiEZITup3tLWRn8nUeSzydKNeCzYrlQc6OG9pm1jFIonVw== X-Received: by 2002:a63:1521:0:b0:43c:9566:7a6a with SMTP id v33-20020a631521000000b0043c95667a6amr15583244pgl.339.1664316311492; Tue, 27 Sep 2022 15:05:11 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:9739:ab49:3830:2cbb]) by smtp.gmail.com with ESMTPSA id e9-20020a17090301c900b001782398648dsm2051220plh.8.2022.09.27.15.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 15:05:10 -0700 (PDT) From: Dmitry Torokhov To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman Cc: Alan Stern , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] usb: host: ehci-exynos: switch to using gpiod API Date: Tue, 27 Sep 2022 15:05:04 -0700 Message-Id: <20220927220504.3744878-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20220927220504.3744878-1-dmitry.torokhov@gmail.com> References: <20220927220504.3744878-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This patch switches the driver from using legacy gpio API to the newer gpiod API. Signed-off-by: Dmitry Torokhov Acked-by: Krzysztof Kozlowski Acked-by: Alan Stern --- drivers/usb/host/ehci-exynos.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index c8e152c2e0ce..a333231616f4 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -13,7 +13,7 @@ #include #include #include -#include +#include #include #include #include @@ -131,20 +131,13 @@ static void exynos_ehci_phy_disable(struct device *dev) static void exynos_setup_vbus_gpio(struct device *dev) { + struct gpio_desc *gpio; int err; - int gpio; - if (!dev->of_node) - return; - - gpio = of_get_named_gpio(dev->of_node, "samsung,vbus-gpio", 0); - if (!gpio_is_valid(gpio)) - return; - - err = devm_gpio_request_one(dev, gpio, GPIOF_OUT_INIT_HIGH, - "ehci_vbus_gpio"); + gpio = devm_gpiod_get_optional(dev, "samsung,vbus", GPIOD_OUT_HIGH); + err = PTR_ERR_OR_ZERO(gpio); if (err) - dev_err(dev, "can't request ehci vbus gpio %d", gpio); + dev_err(dev, "can't request ehci vbus gpio: %d\n", err); } static int exynos_ehci_probe(struct platform_device *pdev)