From patchwork Fri Sep 30 08:38:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 12995047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F71C433FE for ; Fri, 30 Sep 2022 08:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbiI3Iju (ORCPT ); Fri, 30 Sep 2022 04:39:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbiI3Ijs (ORCPT ); Fri, 30 Sep 2022 04:39:48 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2079.outbound.protection.outlook.com [40.107.96.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AD22181E; Fri, 30 Sep 2022 01:39:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UpbvKcs3LnHRe0wW9lYB1K/+0yL3PqwSbZObMnpkYa+2ewS7sIXpHQ6W2kL6YhBbdLh06aGl70cvwUk+AKM7hNqAVjLK23rv4JuaQ/Lo/GwBilbwuUYAOOXgB72vY5VoSWli8dXu2JW0CWw0lAKMBZI8x16/piqqwjlCmb+srlskU65aWFhhVYTkSfb7RmRxzXzS8CXMY5il3eEyHiYyUGEnKOEi3Y5spsDy+iI0u8IQWBD3fQQ29mfBz1aqIKo4ZCOQegutPKpjQu0W5//8+MKGt9jKi6LluTDcS3SljVhbcpheXXMSbOQQYDIEYyngwKJAwxbnsaZdLA0qUEyZyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QRVe+irIhR5dhl3rwxRVJItNumO1KPRFGlC7UQFfTKE=; b=O0KWVr6msM0fPD7V/oF8fzO8t/QmyCIzdpaOYP8JjUOOjrmgl4Fr9hGqfrIKCv7jn5QWB5UwhXn7LmYNV9UTpOGb3hfNU68rNVTmPYQ/HnHRGXqPa9oZaUIk+806siBdZOfXncvP80UHlFHYxXwX/y/OKEjQXk/vDcmlIDYFIvW2l/+db8QWcZAoWrIFBCAbKkkJDcsTmLC3A0g23OtV5CFfLnfsFGcIkVlf/MjXpNpE64uzoTvRZ0CwAiqSG4/cnzYG1g0t8prtlb2+VrkeaWxGgjdAAwZPNa2fAurDj/EFRH6MzoXylJDES2RPydmUmvLVMl/icZaSkLQv5CAo0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QRVe+irIhR5dhl3rwxRVJItNumO1KPRFGlC7UQFfTKE=; b=U3OK4zW0wJ69LtbQAlVf0H1MDZFYXglT+lNM9bC3pNHDk8SdgS6H+EhO2IhPu6MniNaNFcq7hjaXiIuGBpfEifY5DXXouHg/HQEXRXZ5C1SWLBz9WGX5AeP2cc9HBFCEzLSZugDoEirkwDmb3eZAp4NzspARrJg+JjZLe7MHipU= Received: from MW3PR06CA0002.namprd06.prod.outlook.com (2603:10b6:303:2a::7) by DM4PR12MB5310.namprd12.prod.outlook.com (2603:10b6:5:39e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 08:39:45 +0000 Received: from CO1NAM11FT080.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2a:cafe::ed) by MW3PR06CA0002.outlook.office365.com (2603:10b6:303:2a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.23 via Frontend Transport; Fri, 30 Sep 2022 08:39:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT080.mail.protection.outlook.com (10.13.174.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5676.17 via Frontend Transport; Fri, 30 Sep 2022 08:39:44 +0000 Received: from amd.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 30 Sep 2022 03:39:39 -0500 From: Arvind Yadav To: , , , , , , , , , , , , , CC: Arvind Yadav Subject: [PATCH] Add NULL check for s_fence->parent Date: Fri, 30 Sep 2022 14:08:57 +0530 Message-ID: <20220930083857.3950-1-Arvind.Yadav@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT080:EE_|DM4PR12MB5310:EE_ X-MS-Office365-Filtering-Correlation-Id: 3298a2d0-b5b9-4f59-b005-08daa2bf536d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bUJZAyg2fTnx08FV5s/yww7KpwdINCuH4T9wgf2LNentPDLEbJktGP2AGQ9CYSgOkFPXWQiG7L9FAQUuyBZHk8JRVjyQcLXSDyyqx0apCnFtJCnxedgEBjL3FtonN0AeGjmvzfKnenLc6Nnwvr3XCnXw26klvp0MsLc0P9PkU1LJ7oDV0xIbYij1LXfbfYZa/Fvv1IKEU4NpN0fRSu3ydcLxCQR4T5yT3nGzan1MvVp3n5ghUvQhs0SRtNAV+FjgeSCce07BpCdtlegvhUNRRATr4NONlK9IiIFZs0llAguWiheTM0LZfiZn0qM0lnRHlCpXRt+Jcrx0kCybQN84Lk/xjEjZCTSonVgsZhxORQL3li+n059d2bLig+dWDUvPKtWqz1K2QqAxcOQq3OrPsDEeqMbH83FH8oh7a4ytllsy38Bt7GACr6drRn/9/9T3sLC66uHIwO9ThA6QrzzDMkPRIYeX6ntU0p9noUskgsryPYgztDEbjCSW/enTE/Vh1oT9tlwcbyn7PIIjRj8HlLkAS6Eenw2Xi1sY3wHewbFIGOINjWQt1326DuHWpfJv6urjNLd8QKmwN6KWcF8mYq9iGwGsHdPU/3r2sqMdzdAwxdOWwc3Xf4rSGM+LnauMWlpUnGzhIy3mPngeeeePpPiijXEtLprQQWliGCpRucZnoZ0LdRwKxveYSV2n7Hd06nVeUmgwttS078D8bQe6XGhB+WWX+BfAnLAaHLhFhsxpN9ovAd+napW8aYRgjvHxeOF9VgO/dU2o2d8GtJfY9owkZHPtddXW940L+PbrDCBjM4zy8Hlh37UD/5UNFfUaqU/GnWg2KboL1K3CSbR3ZInzqwHrZ35+G3Wzp3QrHvc= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(40470700004)(36840700001)(46966006)(186003)(1076003)(16526019)(336012)(47076005)(2616005)(426003)(5660300002)(6666004)(82310400005)(7696005)(26005)(4744005)(81166007)(478600001)(921005)(82740400003)(40480700001)(86362001)(356005)(2906002)(40460700003)(83380400001)(36756003)(36860700001)(70586007)(41300700001)(8676002)(4326008)(70206006)(110136005)(8936002)(316002)(83996005)(2101003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2022 08:39:44.6622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3298a2d0-b5b9-4f59-b005-08daa2bf536d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT080.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5310 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org NULL check is added for s_fence->parent. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/scheduler/sched_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 4f2395d1a791..6684d88463b4 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -829,7 +829,8 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched) job = list_first_entry_or_null(&sched->pending_list, struct drm_sched_job, list); - if (job && dma_fence_is_signaled(job->s_fence->parent)) { + if (job && job->s_fence->parent && + dma_fence_is_signaled(job->s_fence->parent)) { /* remove job from pending_list */ list_del_init(&job->list);