From patchwork Mon Oct 3 15:29:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 12997626 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E403FC433F5 for ; Mon, 3 Oct 2022 15:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbiJCPaK (ORCPT ); Mon, 3 Oct 2022 11:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbiJCPaA (ORCPT ); Mon, 3 Oct 2022 11:30:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D06112AB1; Mon, 3 Oct 2022 08:29:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C04B12187A; Mon, 3 Oct 2022 15:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664810995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ox4ltjMjfoXYKHNGFlInSfH4y3XOXpGSwEj9RpfYwYs=; b=mgK6MXAy/k6wFGXadHPtSB+wzXevm7/vexrn3H+Lo7bwRZayH6CM3fBiWJyKfSUBE/8THl jqgRMrmRWAJutopgy8p9d30FQ6TDZwkgU1dJNLLmaOrkLi7fe66/pI9Om3+eoi+VqRgwLT I2WOAT3ML2n70l70mMZE18+hiS1EYuQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664810995; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ox4ltjMjfoXYKHNGFlInSfH4y3XOXpGSwEj9RpfYwYs=; b=2NZ2/9eX1UNGVm7/oj+qv6Z0AHUG9aRzBAI6EcnXs4tdoEcUM6EdRd7/nW13YLWgdyTfIu y4OC6LFF2LS4nAAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 959141332F; Mon, 3 Oct 2022 15:29:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G/L8IvP/OmOdfgAAMHmgww (envelope-from ); Mon, 03 Oct 2022 15:29:55 +0000 Date: Mon, 3 Oct 2022 17:29:53 +0200 From: Jean Delvare To: Dmitry Torokhov Cc: Daniel Hung-yu Wu , linux-input@vger.kernel.org, LKML Subject: [PATCH] Input: misc - atmel_captouch does not depend on OF Message-ID: <20221003172953.30354439@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org The atmel_captouch driver does not actually depend on OF, it includes a non-OF device ID which could be used to instantiate the device, and the driver code is already prepared to be built with or without OF. So drop the unneeded dependency. Signed-off-by: Jean Delvare Cc: Daniel Hung-yu Wu Cc: Dmitry Torokhov --- The problem I'm trying to solve here is that "depends on OF || COMPILE_TEST" does not make sense since OF can now be enabled on all architectures. One way to fix this is by removing the dependency altogether (this patch). If the driver is known to be needed only on OF-enabled systems then we could leave the dependency on OF and only drop COMPILE_TEST (and simplify the driver code accordingly). I have an alternative patch doing that already. Tell me what you prefer, I'm fine either way. drivers/input/misc/Kconfig | 1 - 1 file changed, 1 deletion(-) --- linux-5.19.orig/drivers/input/misc/Kconfig +++ linux-5.19/drivers/input/misc/Kconfig @@ -107,7 +107,6 @@ config INPUT_ATC260X_ONKEY config INPUT_ATMEL_CAPTOUCH tristate "Atmel Capacitive Touch Button Driver" - depends on OF || COMPILE_TEST depends on I2C help Say Y here if an Atmel Capacitive Touch Button device which