From patchwork Thu Oct 13 09:56:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FF58C4332F for ; Thu, 13 Oct 2022 09:57:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ECD310E7A1; Thu, 13 Oct 2022 09:57:23 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34D7210E505 for ; Thu, 13 Oct 2022 09:57:07 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9130D5C0153; Thu, 13 Oct 2022 05:57:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 13 Oct 2022 05:57:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655026; x= 1665741426; bh=62GXbMiFTt9uaw64RKnyb4grN73sPghENIMkyLwxD+g=; b=F wtIX81xMp6WHCqpoNNFqN/eMHR3eggHU/XoJWPo/HdG8a90TbH5Z+oaAdOZ45Qpe yoX7sjThT/XrAHYJVPHWb2BCXQ9gn+8VXyInPGlQ819wxP7DrZh4FB4GuDP3n5FE mUhvHhccgwYCq+Mklas9g0750rMvMRC+ZdHbqskEGE3nw9yLbVQPO5kuaVp3slJo fEjaJPfVGVBR5vIwrbpPjsbA0E2K54bUY+mb6d6zeoNIMmITMsjD3gupjtopTkcU 2IRqe7PKcJBByBRfiBRRA4i1JvtOCsXTB0Iojwt5bl6xyU1XifTcrz2uiW9HQbQZ 4mlzPpZhy6wVqFqX708NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655026; x= 1665741426; bh=62GXbMiFTt9uaw64RKnyb4grN73sPghENIMkyLwxD+g=; b=k ae4Wv4keAAVLuHfUSrV+HO8sMO5VVAnpbdMitqNbgM6OJSXWbxCaxGFEWp59RHhu mNCfrt9zAqYGpU+mQfAQqxwJT91lNJ8qx29/ero2kwxWwQ05bVb56/1IFTdEMgsv Ye5JqubX4+MjF8pg6f/mBdpWzCo8UnXEZOx+otoic7Qs7NG+ap5pCymy0W1bq8YY nxseS2KFDrpMY3LEJN3Z+coIA/QsBLHvDv2lYrEHFqvV/+k6Su/FGHzLLsukNT2q 8rG1SNOnYG3fDaDh08DrnZDDTkjmLqT//4iVAL6Te3CSWaAj3Aq39RPkjtQDQdKF 3Nc05Lx9+ZwGFvoYqa9vA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:06 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:45 +0200 Subject: [PATCH 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-1-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1172; i=maxime@cerno.tech; h=from:subject:message-id; bh=AXDxrrKOwTJMNRx7phkeG0zUY8vfY+S2ctdZLJRv9aM=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD95O5Xs+oWVNfcLMGSeXvZio5TD5woXsLOVlq2+3Ltvs 3H4uoaOUhUGMi0FWTJElRth8SdypWa872fjmwcxhZQIZwsDFKQATCdvHyLBx8TqxdQ9W24d8ZGz87H ryjP69delOy+/91b/mLjbb8l8Ew/+sHZ3tByRLN3SyvKw8yzDhHrvhvh9WnvtuzlCty/+nLcAMAA== X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan Signed-off-by: Maxime Ripard --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index ec3323dbb927..b0a945eb7040 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,13 +34,14 @@ #define MEDIA_BUS_FMT_FIXED 0x0001 -/* RGB - next is 0x1022 */ +/* RGB - next is 0x1023 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE 0x1004 #define MEDIA_BUS_FMT_RGB565_1X16 0x1017 +#define MEDIA_BUS_FMT_RGB565_1X24_CPADHI 0x1022 #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005 #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 From patchwork Thu Oct 13 09:56:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD446C4332F for ; Thu, 13 Oct 2022 09:57:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF98410E71F; Thu, 13 Oct 2022 09:57:18 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8C8B10E71F for ; Thu, 13 Oct 2022 09:57:08 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 561C75C00FD; Thu, 13 Oct 2022 05:57:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 13 Oct 2022 05:57:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655028; x= 1665741428; bh=fzePJBfgekN27jwbUeNwvvkHu+S3PaZkEzmettXE8PQ=; b=J 2Dv4VwaxOMaD9l8owZN6YIbOqIw6RawDF7G44tAA14XrhpISEb4M8OiWpGy0+RCx hnELAquLcAkCZBjVZvESwRYL0WEunxy8ndOt4r6JBtiULJp6F/zij4Mdo5f49R50 8uycZDqJc7UfoSGcdiGFMJkydpeqArHygm+777FI1xC58xp+QlkP6jMIbAKNigHm ueUL+w11h9MUmti7CS3Oz9Q2J+IA9qGrhjhqY2aLMpJZHFsmm1E6ZCEHnzreLLCg cMOKREBksZ2diBOLCtZIx28zasElbGC0eafTRfa2F30ez0NSvI08Vh79yb5OeKtu fLBYakZnxVsBi9nacI+0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655028; x= 1665741428; bh=fzePJBfgekN27jwbUeNwvvkHu+S3PaZkEzmettXE8PQ=; b=l 1gocYRau031QGq8M5inb5JYkWB7UCT/5+Rq2xgwe3YPeKjWGEuH34iHkSBhVbtMH QSF6msswuKIFV1ycV7qC1xH2IgEmu5kNjL5AZswbnqivz2h86Ckam8C1jYd+G8B2 wsBXYitYHRM2JyIcrpzg8u6FEJfF39wGKH6yMzvA2vv6l6nfS1hF+vN9x7rDqaMu +uDG2kWk/u2so/I6WXHw/T5nR7G0p7Q9JwBi0WT0OqD/nkqwZw/7ylH8IOVABbUn TH+ZnXAEkg/udahPlRT1z2uHWas/LpSBFvzBA3tVeUDw/bicqdVZKAjf+Q74j49H iCcBxXDRxg3S9IrqoAtuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:07 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:46 +0200 Subject: [PATCH 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-2-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1156; i=maxime@cerno.tech; h=from:subject:message-id; bh=/lJlArH50OghiguxY4jwNzQdKqp5YZ0WFt8xFs+ec9s=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD97Gx/+Y+/DXFbfwWZbXVn0oiahdEGg58YTSPNbLe2yv THN+1lHKwiDGxSArpsgSI2y+JO7UrNedbHzzYOawMoEMYeDiFICJxJ5n+B+/P++49bbq13PPXFdhTO e7aTLp5NdrIZFHM8ye1jhVCYQyMvw+Wtf+PpSxyJu7yTaX08+mhvFF0fztMt+UKs4xqqxfwQcA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the RaspberryPi. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index b0a945eb7040..2ee0b38c0a71 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,7 +34,7 @@ #define MEDIA_BUS_FMT_FIXED 0x0001 -/* RGB - next is 0x1023 */ +/* RGB - next is 0x1024 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 @@ -46,6 +46,7 @@ #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008 +#define MEDIA_BUS_FMT_BGR666_1X18 0x1023 #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 #define MEDIA_BUS_FMT_RBG888_1X24 0x100e #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 From patchwork Thu Oct 13 09:56:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005830 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E80A1C4332F for ; Thu, 13 Oct 2022 09:57:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 50FC510E724; Thu, 13 Oct 2022 09:57:19 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1F2510E71F for ; Thu, 13 Oct 2022 09:57:10 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0ED9C5C0153; Thu, 13 Oct 2022 05:57:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 13 Oct 2022 05:57:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655030; x= 1665741430; bh=XGmWWgDw5WokLE0gsZ436DZNtPe1pLT1+ayIAvJ/eP0=; b=o LWy60b+YVF/i5xSdbi4PqitxsVAreY767A313vTjcPx3kfY6aeOunGRdNDY7M6O9 Bh11nEts5BTds8EjhJIDqy7TifbVukZ45KyvwiBdEW13vv4A01BvNtpWKXMqa1CP 4Ir+JynkzOnyW5XQmG+TODRwmOR0RCAPEpmVQAbjcogI76Zqe/pM88ulPNlOWNDI YBpbDR2SoNSGYKHOCl7oEJNtsDPJ1RrxMyzyCmQZPDB7wERnOm5YUDZGHYeL+oaW BoB6nUPMIveZCZ/avHYWl/Do6OcPEapOM6cIKbaH/XdINdJLMWii8krW9RxUIzrb nUg578teF9tRq2p8uJrvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655030; x= 1665741430; bh=XGmWWgDw5WokLE0gsZ436DZNtPe1pLT1+ayIAvJ/eP0=; b=A 9ofJhQE/Jk8iIf+xr23lNd7TBMLZEM8qU3Vk+pP68HsJhEQE/t0OfiydLEZFWdGO gU7sv4ETDxgxNvv27pWU9y25E9HZY83v4iA8XMPMcOFIPOxm7Zq6JTBZQ7N5HZuB KNytf/EZRzL5KuNNoabu2Qwxo5nLwdqq3mjw4UQR/eRmFf3aJux5OqDNz7iOAnfp jxWHLYJf0JmL8bjR58iQ98uZHAbf2kgB9a/w3ZpHGtZurlev2NYajyevM41Sl/RP 5icV9lBrYvs4MIi9XzuXSqvR705stbYCWmNJkPYYI4Jm3jK0Strp/i/8B/bBHstP We7Z0T8GgQlZmlaSaUNzQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:09 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:47 +0200 Subject: [PATCH 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-3-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1169; i=maxime@cerno.tech; h=from:subject:message-id; bh=0XY6F612UcTptE6B+KNZY6b+mxAKI6UoQCqYByTqpxI=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD94W//708kRG0vrHhkysSateuV96u+Xbw7o2R63uHwvv miXVd5SyMIhxMciKKbLECJsviTs163UnG988mDmsTCBDGLg4BWAi+tYM/+yOSP7X8ulZsjBHyMtNuP nKoqcbr1kk2WcctXsc1Pum6RjD/9QyDRfGs9Vq/290px/yz27udJIpLv99kqd0Y1LVE712PgA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Joerg Quinten Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X24_CPADHI supported by the RaspberryPi. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index 2ee0b38c0a71..d4228d038b54 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,7 +34,7 @@ #define MEDIA_BUS_FMT_FIXED 0x0001 -/* RGB - next is 0x1024 */ +/* RGB - next is 0x1025 */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 @@ -49,6 +49,7 @@ #define MEDIA_BUS_FMT_BGR666_1X18 0x1023 #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 #define MEDIA_BUS_FMT_RBG888_1X24 0x100e +#define MEDIA_BUS_FMT_BGR666_1X24_CPADHI 0x1024 #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG 0x1010 #define MEDIA_BUS_FMT_BGR888_1X24 0x1013 From patchwork Thu Oct 13 09:56:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A61BC433FE for ; Thu, 13 Oct 2022 09:57:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 593B510E7AC; Thu, 13 Oct 2022 09:57:22 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 580EC10E71F for ; Thu, 13 Oct 2022 09:57:12 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B4F525C00A6; Thu, 13 Oct 2022 05:57:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 13 Oct 2022 05:57:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655031; x= 1665741431; bh=u1MKeK43KUVSNr+zlGBU1hNNtkwDdXrF2GqPW2EMI4Y=; b=D +zZ1Fc4ZBFSXef7tM+bIuF1Seiv0mr6zF4Vqwd243kEn5i/QHGrMLmko0N/1O81a qKpyywvkMls4P2sbY3XEIss+fpgk7mFrpR4lQ+aiwjQA5nzcHODog5S9HXQvTzdb WYFQjxeNT0/YKGYz2rqr8ap5zhDVHdW85IQHYzDt69ZBjbDDHRNI3jSIPTS+VkQq GuhQyd0Ux0pqUFUqHZ6e2+OJZdZ/XefBKs14IJ58l/UpsSnZKueftjyV02r/Qha1 WtR3dz/EJCqFFDQVf5QFYJPchxG8fGsg85r2Xf5jGEq4hMGy8KT5lVls9LU96pph 90titF7qZeGD+4Ki1SFtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655031; x= 1665741431; bh=u1MKeK43KUVSNr+zlGBU1hNNtkwDdXrF2GqPW2EMI4Y=; b=E MKMv+y19UkgmjQjJnz0/C0PQbdYCK3C+HlPyaVhiDPs08xmsw5waorM1KwnWd/LR e9jYpEyWlv/bPFixoX1woa/C4kTr0b4ju8HnqvFY50sNCdHodmquph8rS5afI1Tv 9o6QpFY+05eoGJLzG5C7y+zJXIN4ZvdEmaOB1bkC1TV1PbI8dF5WIR/5U7nCBK3i rh53bQmXgw87eWFGPoOqgTKVXMSmLcyzAQ70HZt+Hcof45JBv+nVD9Pe3KIrZh0s mlLJuPGFERFpe8w4d5JRDoyEyTxnKCO/yePo1A6HOalLJw+vGe6S56vMk6StwdlF 681aMbZ5r2C3h4hbQA7gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:11 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:48 +0200 Subject: [PATCH 4/7] drm/vc4: dpi: Support RGB565 format MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-4-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; i=maxime@cerno.tech; h=from:subject:message-id; bh=ZQPHjwQYtyeJjJI91c4T4N+E7FyRjwcxYJLQyKTsOPQ=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD976HfHdkCzeup1vaZ7V8SR1Sy/mDWblL7pW/ftcJBnx 09+0o5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABMJTmH4H1lpb6z/XEcsaYrTxLrqPT t2bv3ys2/HlK5JBTJBqmz51gz/g/YYvBDJ2W93qfqS8dKFkyI7Z9eFGQc/qmJ3CuS78YORFQA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chris Morgan The RGB565 format with padding over 24 bits (MEDIA_BUS_FMT_RGB565_1X24_CPADHI) is supported by the vc4 DPI controller as "mode 3". This is what the Geekworm MZP280 DPI display uses, so let's add support for it in the DPI controller driver. Reviewed-by: Dave Stevenson Signed-off-by: Chris Morgan Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 1f8f44b7b5a5..7da3dd1db50e 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -182,6 +182,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, DPI_FORMAT); break; + case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2, + DPI_FORMAT); + break; default: DRM_ERROR("Unknown media bus format %d\n", bus_format); From patchwork Thu Oct 13 09:56:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 929DEC433FE for ; Thu, 13 Oct 2022 09:57:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4111010E742; Thu, 13 Oct 2022 09:57:22 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E5EF10E71F for ; Thu, 13 Oct 2022 09:57:14 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6EE865C015A; Thu, 13 Oct 2022 05:57:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 13 Oct 2022 05:57:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655033; x= 1665741433; bh=c9JIB0N1ry3TbulJgGhW5FL0vfJVlWv5g9q7AUZjWIo=; b=a NN4L3WxEDdGU/FywYDQ1MClme1PcOXNzlN9aC5XJvCd2iPBt52WDRnmmea/Bw4tb Pjq+CPcIfsGZqQ04GRmTtdkLgKUxSOL2fsxwLqRk69mEE7WB5cSgR1N8ifVZA1dr VfeQ4VPHQmRG3y/ep4yOt1wA3d5PwY3phY0jtfSZd9ILFgHwxB7wf4kimQm/Wx84 nTh0NW8SSrKtGc/vcoK9siOC2HTUkWA0nPWpqS6gtp77toeHOFbPIL8F4AySGQ/U n8GhbVf5DsjeAiO9u4BO8K/JiC2ds9e1ZOH/ungBoeg2oZdn3pq6nqJZLydQG/Nr rEigCVRTMOB/oJFvuts+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655033; x= 1665741433; bh=c9JIB0N1ry3TbulJgGhW5FL0vfJVlWv5g9q7AUZjWIo=; b=d /0OVpEDQ4TNzQNUgQnRMlEeaIoZztjGK5DkZLhsgRkdUrbHrQa6hwSWFiNeemjS7 DICz4nAkECI8Xk8P+PxBoi3XLftlyoCXrxSdklqfr1aQEH8j0Xyd2Oj2ZGztQtk5 wolFOxmuWig42x/+YE5L/1TeuO/zzVpiSq2UKf7ntl4JVIRAEU9cvyRL3jE0Albl VZHQU/txbAY3QuKGotCY8gQcy5LIYL18Tc1YKVfyoaa3heNPwtArFJY+IWiiocOi XaKkzZGpx0ntWjQ5MM4M17eDgArCnL4eSO/BRFa0/EXJ4Wq2MNA6Au23AN2fVEvC Txh61pU6ZsDT6q8/ggr5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:12 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:49 +0200 Subject: [PATCH 5/7] drm/vc4: dpi: Support BGR666 formats MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-5-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1228; i=maxime@cerno.tech; h=from:subject:message-id; bh=1jlV3cpohJvxfKQ50ZdTSBF7QOjvv8tfuT0cBwwSJJw=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD97e+tB6zFene/7a3+cWRQkq6T7c8kj9jwbzsdgwpf2n F7Zmd5SyMIhxMciKKbLECJsviTs163UnG988mDmsTCBDGLg4BWAiW50Z/tnk37Q7ZPRmkYSr+MFADY viU1PWSG/iUrT3Zc+yeZErLsDI8Krnr5OYmNiuKdbuU2azRi988s3q28zfZuEmmZwu3lNs2QE= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Joerg Quinten The VC4 DPI output can support multiple BGR666 variants, but they were never added to the driver. Let's add the the support for those formats. Signed-off-by: Joerg Quinten Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_dpi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 7da3dd1db50e..ecbe4cd87036 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -170,10 +170,16 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); break; + case MEDIA_BUS_FMT_BGR666_1X24_CPADHI: + dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); + fallthrough; case MEDIA_BUS_FMT_RGB666_1X24_CPADHI: dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2, DPI_FORMAT); break; + case MEDIA_BUS_FMT_BGR666_1X18: + dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR, DPI_ORDER); + fallthrough; case MEDIA_BUS_FMT_RGB666_1X18: dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); From patchwork Thu Oct 13 09:56:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F10AC433FE for ; Thu, 13 Oct 2022 09:57:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8335410E7A8; Thu, 13 Oct 2022 09:57:21 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFBDA10E71F for ; Thu, 13 Oct 2022 09:57:15 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1CCE35C00A6; Thu, 13 Oct 2022 05:57:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 13 Oct 2022 05:57:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655035; x= 1665741435; bh=YJIorxZ3pr3ObxvJBlO+ZXthuYIK21XnMOr0CgbO85g=; b=B /K/5gJoeHdYAJtm/xI3HB0HpvFmv0vVKfPkgneITXJsMni8HIo5A+w7wXosbENtH WAQJLL+fRTlZ+UhKaRloXgdtAkOu+pgJIj30A+NI+4SZaELN7jwRqx1wEIBN5mfb wBxNzy5L5DwxA0LkJh2Wn5Ff3GwXMQic2L+4xxAlcCKZK1eEYTy+wPGAUEaoQN8G YHwh05xJOWzQimRwDXshAcQ3WP6PmxC0KOqbMBy8sriNhSBWN3OS50vLTNqSioQ7 99LPs5CUyqQnSXn+BEOkSA18C3Rr4n9BxiSV4BzQMdGClT5zX+IQApqJ3ggNzAnx b2UpkEI7xBD2yzqrOMg0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655035; x= 1665741435; bh=YJIorxZ3pr3ObxvJBlO+ZXthuYIK21XnMOr0CgbO85g=; b=T 1qUH36QS6wVuprS6GW2gNoDbfQfxHVde1oSUdy9kPWVP5M0it87NVXIYFE/mDCw0 u7SuYjhXEk/wLXlEXPO0sDShocrKdX4Gcr5cZsPa/57sLqd+cit5/+iGcvul8RPz AUhAgz385uQkSI2GWYAF/bJ3teIwc1MSVVXIxEeu57nRxPgy06syxMVHUq50tnYN Q6UoTi6vLWIHggkyOdjOlQe3fIsdL5sR8GkhSjPXjYXIJOQ44qjdykWJTespPjnC WxvSAED8E6VyALcjsO+wx4lpjO7EX4QhEFuUfTcm0A3ILqRJklpb24y/6PT45R1t AoUvCLe2udomn6UqLM6MA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:14 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:50 +0200 Subject: [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-6-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1264; i=maxime@cerno.tech; h=from:subject:message-id; bh=Wft1tzL7nxwyTwNtu5OqGs7F+nLIDZNQX56ZSduIte0=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD9627pcUfvUmYLe7i/T0yiCHiGsTm4zta7877tj58PNp QTmJjlIWBjEuBlkxRZYYYfMlcadmve5k45sHM4eVCWQIAxenAEzkkirDf/9Yrx4+zXuFmqJZ6oG7GD lcKzcbvJ30z7K679TKtGWbDzD8r/l+dfb2a5lLkvdJ3nPQ3ury3rV2fzJ7qbGAXuOM6Zv6uQE= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Dave Stevenson DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { From patchwork Thu Oct 13 09:56:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 13005835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8CD5C433FE for ; Thu, 13 Oct 2022 09:58:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18C1210E7B5; Thu, 13 Oct 2022 09:58:07 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6868310E71F for ; Thu, 13 Oct 2022 09:57:17 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CB8C45C00FC; Thu, 13 Oct 2022 05:57:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 13 Oct 2022 05:57:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655036; x= 1665741436; bh=MQ066bDfliOyaWbJBRc3Sb4MdlZldWl5D7wyoX+CGZo=; b=x 81AffMZCH+CvgwcgB4t5iYYaUopenUM7qCfoFaHlEyZlWqeObBhKMrzyZtd3pi6h /LBHzx4gDs6VRP44xtKrhelGrH35CGlmCWGWXE8yXZnH+aKqMMhX56bQPcHM+jNX gE/YFKyOsNMlP9XkvvR68z4yfLu2jdibvkSLv136GOFSq5o8JGtrJ3+8d5Jo4xVu k39UsJTrTbr1cgvKbNUMjqw6nZkOJPWzUmYiFDSsZVVT/Owz0Sk/r3tTLhk4Ba9U wW3uwmXS1mFOXeiLR77Nj1S5wbPEaRYrAIJBk37mX/qhawgjVmU3JE3djbAuelvP WVoX500KXMYxswItFd7XQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655036; x= 1665741436; bh=MQ066bDfliOyaWbJBRc3Sb4MdlZldWl5D7wyoX+CGZo=; b=U KrmIqrHP2GXOaMsc5KVl3D/YTRp190ljJV6KkiAwhn77qMs+H5hep7EK2U9sUWWn qBS94O2LkLePEGPCFPOLfQEy7TfUwTgOcIAM3CMZ7MEPTCJHcS8IXIpYX8DYr6ZK rQ6EhnHMatr30ESN2m+g3FZ4hTgJEncb3y2Rg3KobZZA+Al3pjZpijFvIyPPPSEK Oil4L62avqqrBUnoVkUnFlZRdW1brRBVqdAG/TEBRNMgBTquLIplL1DRXMHNhDhk vQvE3x5ctjWYUBL8M93ndOeCrfWMdmKN+guxr46njwzbYQrdstfOthkC6IbIe8n+ Q56JQoRzx2676gD3cebvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:16 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:51 +0200 Subject: [PATCH 7/7] drm/vc4: dpi: Fix format mapping for RGB565 MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-7-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=965; i=maxime@cerno.tech; h=from:subject:message-id; bh=Bfa8b+T0qwe2ry6WQDaIcHsRajSivGlVAl/5p4IUcxg=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD96e/7H/+CrrHeVva3cZWF1YfCg5aYbU5YxDujWlSrLr mKpedZSyMIhxMciKKbLECJsviTs163UnG988mDmsTCBDGLg4BWAiXucY/lkV6ZqeCg1OO/Lk4ILN97 OmLitbkCjYk/yQo1639KGS6yZGhr65R1brnv661ffvY5Untyy//O1fMimxlJW582vQYd9VIiwA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten , Maxime Ripard , Chris Morgan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Dave Stevenson The mapping is incorrect for RGB565_1X16 as it should be DPI_FORMAT_18BIT_666_RGB_1 instead of DPI_FORMAT_18BIT_666_RGB_3. Fixes: 08302c35b59d ("drm/vc4: Add DPI driver") Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index fdae02760b6d..a7bebfa5d5b0 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -185,7 +185,7 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X16: - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_1, DPI_FORMAT); break; case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: