From patchwork Sun Oct 16 11:36:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yen Chun-Chao X-Patchwork-Id: 13007763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABD3C433FE for ; Sun, 16 Oct 2022 11:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiJPLgs (ORCPT ); Sun, 16 Oct 2022 07:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiJPLgq (ORCPT ); Sun, 16 Oct 2022 07:36:46 -0400 Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2157.outbound.protection.outlook.com [40.92.63.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01DB39B99 for ; Sun, 16 Oct 2022 04:36:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5tr0aH/iDact8PW2YF+T9vmi57046OWpYOfyv4tpQBN9O65j8M5XhAP8Dx3s+U92x/4CotZPE1IVJOfyLPnYgm26gWSv9wFLQH1KXzWNCCPsCplvH2cg8wXbe0zyxdk7LHTdTYPbdrsF/XVRct5SUAfB8j9hUZUOEATfsASdwUPfeZOIudKnO2IYnBI1G0oPR+ndDUdVwiRFk0sasXrIh/qxauv0xHl7rw3Q99BBxnI1oh485+GnsVT/qBXoaNnXKakiI41HvI/yosKd/tnf0uZD+N7aKk3LDWxhQ/oo4SHVIsvbpvRc3EHk3K8dxRcpEPLPA/64b75Na3eYrQ9Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oK9tbQsMylI7AlQMq3ATfw11RQ5+bFVq5Sfu1PDnLPY=; b=YOtY7JCjIvsjcWqws+AHcQc+tTZ2sLFGWpTXgtr2UpcXI1ufT1RBeWi7+acaM/ynkcgr8o0E9VmjsdcuX9l3/Pczk+WH/ZdL12lVCX53NFqGKHwr4SAjNStWScz42m4UJrG+Ue6oKDxLBGFE/xVRYKoZjTCDLEzRqaNWJfJwP2YVIFYkJliQDGdnf6z+lzOgyu5U7V2HNXrJqn/2mV21pqh1zP1QpMzY1GsnCFr2z2R0S3L5N7nvU8iuR2ajiwZ2m0MpPc7ZXocA4463A/NQBZNH4i3oGKNYGsK8foYllMLQo4I5Uzv9Z8uLXiLoUAcv6FLmamsgF1o4OQ+05LBIuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oK9tbQsMylI7AlQMq3ATfw11RQ5+bFVq5Sfu1PDnLPY=; b=cspkCXDrE0JNn6smF75mATxEeti8ML15X/NqPVocWDuDohbD+vHv+/ZbFuqrIdjOqxUfO+r8U8PFM8ohJ2HslPntUEqDywP2m73DOWuBgsGZnYxw3Dv6Xdr7/zj+r/ZwyrvoiWquDWM5RgUZ8GXNFu3RDq849BLPLBh0yp8Wv+MZn89KpMeEU9vNOhSwEYXSfjWyuPT3AAu6VMygJs9dsT79ksPQYdutIJLXhCddU1miUMQilpsGd2lJAz5LYxXgmaEoA/wV06WFhhNw+wI3BTlAJ6GMtxsKzn/JjH4adN7ptaYiQz5z7059ANIPuATrahsRGzdtJiHrRnZdkI7cTw== Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) by SY4P282MB2790.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:159::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sun, 16 Oct 2022 11:36:39 +0000 Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06]) by ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06%8]) with mapi id 15.20.5723.032; Sun, 16 Oct 2022 11:36:39 +0000 From: Chun-Chao Yen To: pabeni@redhat.com Cc: davem@davemloft.net, linux-usb@vger.kernel.org Subject: [PATCH 1/3 (RESENT)] net: usb: ax88179_178a: Enable FLAG_MULTI_PACKET to improve tx stability Date: Sun, 16 Oct 2022 19:36:25 +0800 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [i/E7ULRakQLLCCKulMHstcFR+zEnv+1w] X-ClientProxiedBy: TYCP286CA0120.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::20) To ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) X-Microsoft-Original-Message-ID: <20221016113628.4176189-1-nothingstopsme@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ME3P282MB2827:EE_|SY4P282MB2790:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c2498a1-4fff-4d61-608c-08daaf6ab056 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qAn/gOySyP2aTvqMuL2tpJ/IQ0AqqUvXKLG6NWMAWH/QNELEph31Wrh3eNzVrAH5PZJT0DwnzO/OO9XLyOuRp0DdqGhtirjLodfGcrEnewCkZe+js6LCWvOvXFxt5xAkSILsB4qkdzFKyV2QiD2hXQKndyqNpdJU6eTagM9rz1Qdh7bj5QHvYS+la5+wBcORGdngdRPAYlmY4ZSI7DvhcHmU1PpKqh/ekRVXtxTOhKJ5ZEbiYb7xThucxdZ21ZvEvW/PU2U0h8fGXKvsycwfZnDlfhrbI6Wi2oQ5Jl46hIWQvrjXv+zVIp5xF+Y3u2lMIBuA2mA5YmvskJkE0WWJwUh6PcvI2OHLT4G93mHUelVdjkXMAtdtZ7e3K9IM82p6L3DwwX8jt7Ts0npT454p9iuvGeXQ6K3AnZ8b0e6K8jUArsrn1l8pDuHV3PyW2kbh2yObBKkHoaaRw+6E7MprEXPflKDTVL0pYknItX/jSxgV1U/mBmADhhGpw3nK6oCWlppHXVEsxZM0i7kyx76C/oM27aVJY8J75JZSledwgXeDsCC8Li0umGQAvkYV8sZmN4Tqsm29+wE8m8V4eFlez+RW4Q+tMx/GbHAVlIZKw/mBcmcTWoR7fGcYphWT5kVx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: b/2ADQkmBeFigeFUmtsySEXqDMddm6gZYdDY9/WCuQeMpUdkkPy+x53sqUjAvi8YEhqvfccAkVSeV0bXWKhLP6VSRTuDOhFWi+Drn5Um0/7GTwJfUGXUbHgZl78/JLbEmcp+OAcsAlK+ukvuM7s25tP3w76ZJBAfPV/Vw4OYSmOWvrOEw9MtMPQ5x0KGaH+pg/pmJQQmNtHgmMAKucdMUS/USKlbPkDEyWcr+FDmjGht3TCSl+4DMcUXkQ7BzT7dYPtLauSALjklel8dBYztoGqNmP2aYTEbod1RjzsUIQtJ+X9bVPPaKl+Y6NVwUtOsbYs3YMGzS5fbW+6/DKoqc0xs6NA1ai/DhZdfMpmJ2YKPlFZEw3EXj8XJ5PmUB93cBSzMAxrOnsO6U0aSwQ6MbP+/VHJNOwYGao+8Xv/0j8K2NvgsN2Om2P28U9n6nTww9aWUpKI82kScS+nK/Eku9YcnvOcdzsEa8tWnI/HnKvLBJ6CNU5TsQN8B3JI4aj6HpOTLPKwXhuSuWdZ3rcNlyWOMlxQfAq3xUnvPVdqw6wdNEeXcGDFtd454TqKcuQM+f+phGVyT/UN0VSZFgBOJYbKtgbWIEiEjPlLkT6xQ6SQvIgmAxKA3dplK3TPzd84CTirMs1SeGIV6fMaF+KlN9Ver7FSCZVGof/f9/Mh74Ff4HXAdgmGPRruChcm+qL7NUs2QwvGchNXl7FRRgaH4en0ip+5RbaZeAlho+apIQLfma77Ft2ThzWKktNMy+L3ncJM6DDfBR1CKkEHHP8oapsoFFCrg8KH4kU0/gB0or1tKSi4jaU1rMWvMLPi1kreA1FR63Lb1cGpvY07/liLtpvGXoBmC3vqtm0/2aUVuQURgYeeFHeXJEDxlXhzI42Z1NsWJQRn1AuK2sT3rDJs+360uG+IWD6zIAjCbumPf8XSLl+meNBQ4kC0q0+U5/uJXgJ/3CTKJlL8zeOkKPVmtiNipVq5fLnXwUC36+Bf9wqTthgUqGuVRT7H4Dobhi9BplUj3eiUEBG7yo97UeBHcg6kQ8MpuWGNdaAvitraXPO/zPOO4hFbIa5H/GqpKpKRt7uD+9PH5NDROdf0U+r3vIMQgAOcM3tnpdY6jzTwbQBY3G3banhHELavDp8GfCm1G0fGDr2T0AlUEs+mP3IMEViOSWuK/gZQDoOL2VP7yTA5FUistBqY1UXbFa//S30lFaFpG8WXWKKdW2a3Hz5Otp+dwwxfZ7Z+TIZ9RqIRD6NRE5+7JPvLC8f9iXhDusHmS4fx75Ez0dHUX6x+CbQ1oFg== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7c2498a1-4fff-4d61-608c-08daaf6ab056 X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2022 11:36:39.0409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB2790 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Problem Description: The current way of handling the boundary case in tx, i.e. adding one-byte padding when the size of an outbound packet is a multiple of the maximum frame size used for USB bulk transfer, does not work with the hardware. This can be shown by running a loading test via iperf with this hardware as the sender; one can then tune the iperf parameters on the sender side (e.g. "-M 510" in my testing environment) so that sent packets frequently hit the boundary condition, and observe a significant drop in the transmission rate. In the worst case (often after a long run), the hardware can stop functioning (can not send or receive packets anymore, albeit the corresponding network interface is still reported present by ifconfig). It is also believed that this problem is highly relevant to this bug [1]. Solution: Enable FLAG_MULTI_PACKET and modify both ax88179_rx_fixup() and ax88179_tx_fixup() accordingly. Rationale: When FLAG_MULTI_PACKET is enabled (and FLAG_SEND_ZLP is off, which is the case for this driver), usbnet will skip padding, and trust that each sk_buff returned from the mini-driver's tx_fixup function has been taken care of to cater for the requirement of its target hardware. That mechanism allows this mini-driver to send, even when the boundary condition is detected, "untampered" packets (no padding, no extra flags, as if in the normal case) that the hardware accepts, and therefore resolves this problem. Note that rather than being viewed as a workaround, enabling FLAG_MULTI_PACKET is intended to better match the overall behaviour of the hardware, as it also echos well the rx procedure conducting multiple-packet extraction from a single sk_buff in ax88179_rx_fixup(). Verification: Only tested with this device: 0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet References: [1] https://bugzilla.kernel.org/show_bug.cgi?id=212731 Signed-off-by: Chun-Chao Yen --- drivers/net/usb/ax88179_178a.c | 62 ++++++++++++++-------------------- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index aff39bf3161d..b50748b3776c 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1426,58 +1426,48 @@ static int ax88179_rx_fixup(struct usbnet *dev, struct sk_buff *skb) if ((*pkt_hdr & (AX_RXHDR_CRC_ERR | AX_RXHDR_DROP_ERR)) || pkt_len < 2 + ETH_HLEN) { dev->net->stats.rx_errors++; - skb_pull(skb, pkt_len_plus_padd); - continue; - } - - /* last packet */ - if (pkt_len_plus_padd == skb->len) { - skb_trim(skb, pkt_len); - - /* Skip IP alignment pseudo header */ - skb_pull(skb, 2); - - skb->truesize = SKB_TRUESIZE(pkt_len_plus_padd); - ax88179_rx_checksum(skb, pkt_hdr); - return 1; + goto advance_data_ptr; } ax_skb = skb_clone(skb, GFP_ATOMIC); - if (!ax_skb) - return 0; + if (!ax_skb) { + /* Report a packet droped, and continue parsing the rest + */ + dev->net->stats.rx_dropped++; + goto advance_data_ptr; + } skb_trim(ax_skb, pkt_len); /* Skip IP alignment pseudo header */ skb_pull(ax_skb, 2); - skb->truesize = pkt_len_plus_padd + - SKB_DATA_ALIGN(sizeof(struct sk_buff)); + ax_skb->truesize = SKB_TRUESIZE(pkt_len); ax88179_rx_checksum(ax_skb, pkt_hdr); usbnet_skb_return(dev, ax_skb); +advance_data_ptr: skb_pull(skb, pkt_len_plus_padd); } - return 0; + return 1; } static struct sk_buff * ax88179_tx_fixup(struct usbnet *dev, struct sk_buff *skb, gfp_t flags) { u32 tx_hdr1, tx_hdr2; - int frame_size = dev->maxpacket; int headroom; void *ptr; tx_hdr1 = skb->len; tx_hdr2 = skb_shinfo(skb)->gso_size; /* Set TSO mss */ - if (((skb->len + 8) % frame_size) == 0) - tx_hdr2 |= 0x80008000; /* Enable padding */ headroom = skb_headroom(skb) - 8; - if ((dev->net->features & NETIF_F_SG) && skb_linearize(skb)) + if ((dev->net->features & NETIF_F_SG) && skb_linearize(skb)) { + dev_kfree_skb_any(skb); return NULL; + } if ((skb_header_cloned(skb) || headroom < 0) && pskb_expand_head(skb, headroom < 0 ? 8 : 0, 0, GFP_ATOMIC)) { @@ -1680,7 +1670,7 @@ static const struct driver_info ax88179_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1693,7 +1683,7 @@ static const struct driver_info ax88178a_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1706,7 +1696,7 @@ static const struct driver_info cypress_GX3_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1719,7 +1709,7 @@ static const struct driver_info dlink_dub1312_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1732,7 +1722,7 @@ static const struct driver_info sitecom_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1745,7 +1735,7 @@ static const struct driver_info samsung_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1758,7 +1748,7 @@ static const struct driver_info lenovo_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1771,7 +1761,7 @@ static const struct driver_info belkin_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1784,7 +1774,7 @@ static const struct driver_info toshiba_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1797,7 +1787,7 @@ static const struct driver_info mct_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1810,7 +1800,7 @@ static const struct driver_info at_umc2000_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1823,7 +1813,7 @@ static const struct driver_info at_umc200_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1836,7 +1826,7 @@ static const struct driver_info at_umc2000sp_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_MULTI_PACKET, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; From patchwork Sun Oct 16 11:36:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yen Chun-Chao X-Patchwork-Id: 13007764 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CEC6C4332F for ; Sun, 16 Oct 2022 11:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbiJPLgv (ORCPT ); Sun, 16 Oct 2022 07:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiJPLgu (ORCPT ); Sun, 16 Oct 2022 07:36:50 -0400 Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2157.outbound.protection.outlook.com [40.92.63.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE36939BA1 for ; Sun, 16 Oct 2022 04:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qxza6E6fVICpJ/JyINI6BLCxrbw5gDC2m7LCBjshKgLWiZ6H5uOXO4M/UGQy8urvm2Rc9rZq0E1GWB781XDVYIKZZkg+CYhwL6T6o0EMIBnHG4wwMq9OMEh0K8uF+7N4plDUd7LQHdn154BMt/jZWrenrGP1plnfvMCPIUARotJ9NoCfKyoxf3RDbHUmAeX+MXfmZzgH56FKQO0nEUmtEaK0s8tMG49GG/XTmIg+giL1jxW0rC2qKBLrNWzv0pd1cCPvGijrQA/ta0O/R27FksGdN2EivvWEkj7sVI/VPDjBjYiWEHLtgGJrsWY6CZ4MVME9/Kio3boEVkwIaYXWsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Omn5NIDMedQ0BB3et8V13wjnLYUbDdDCUMCMQjAYpKk=; b=FSOPLUckVCEVidKJuMCAKNyftT8WQ7GTLODUHKH/yxqBKy+LKv0HVPqin/YvYtekp4SdsX8cYjWrw5c6XGIU9AYgKH/HMbPC01E/rI4W0n9ktBF8ZHYdlcGegswJ4Ye4/r3EqL0hLoMAlSYeNK2rMmotpd/064tHUpN0BgOQqYmsAzqxDKW6dOqW+jEjvNLrbGiR6J6hU1MJPXLzhbL5DuMFxGifyqoBCLdTG0kMT0jcMec894CHwjWarWmh5xkNiZtb3nvTlY7jiPWBJvry/miWjKIlJ8Ar/dhVJ5cTKPP/gMo/T7EcaVl3MywNkEwmJd1IKuZQV+IgU5QFp2aMiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Omn5NIDMedQ0BB3et8V13wjnLYUbDdDCUMCMQjAYpKk=; b=AHbfMjTNM5Ov6E3XSD5n/2DFiKA2nxZ+1u26Bay2RZ7dslD9X/2xLsDLAq/1ld6jrm02dSS6lBwhdMGC5DCNra6WxyhNiIbAkhy/W0uBlcXAQhcx/W2WOCIXuvAQjmrU5dubni8womK9rLW5n8uRbku+mKZv3NllfQpcYPV3xNHgwwbFm4Xu4wpHpl1sOR63cV5vFU0cq5jcDDku7OHfPjzfJVOake6V/lSR4jhAb7JP14igtkqRCJnuUaGtrp6fKZXMeKDbFZe7+9ET8VXlC/49CFM2NG1D4uZrKX3G+jfEgcvc5qSGoGru8+3phF7psML9jdMShK5eBvH+1+j8zA== Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) by SY4P282MB2790.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:159::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sun, 16 Oct 2022 11:36:40 +0000 Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06]) by ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06%8]) with mapi id 15.20.5723.032; Sun, 16 Oct 2022 11:36:40 +0000 From: Chun-Chao Yen To: pabeni@redhat.com Cc: davem@davemloft.net, linux-usb@vger.kernel.org Subject: [PATCH 2/3 (RESENT)] net: usb: ax88179_178a: Enable AX_RX_CTL_IPE only when NET_IP_ALIGN != 0 Date: Sun, 16 Oct 2022 19:36:26 +0800 Message-ID: X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221016113628.4176189-1-nothingstopsme@hotmail.com> References: <20221016113628.4176189-1-nothingstopsme@hotmail.com> X-TMN: [okkWM+/gY+KAe8EqFBR5usze8SbaXojo] X-ClientProxiedBy: TYCP286CA0120.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::20) To ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) X-Microsoft-Original-Message-ID: <20221016113628.4176189-2-nothingstopsme@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ME3P282MB2827:EE_|SY4P282MB2790:EE_ X-MS-Office365-Filtering-Correlation-Id: 12602520-2533-42d8-f104-08daaf6ab144 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U8X8TT00YMo4QnuWfSOpm3+yQjItVjMlEgxvDq+1WSXQPnCTHsq3n/yOW4jIdPWmkYTiHV+60O3R9GuPnuiFOWrHkPRG3So7v+b/ygVCB0GMrLc+628V4AKSqnsZfoa9La2J0qqdFWNbCYMXDKkZRjZDEg0raY3cS5FWH7Sb1a1RAl0mHwPorNy//viX7fu2TexNf9El0u/qByfHj46enbVWEf9RnPZl9vEGCYma6UA57bp+akoDx4TCThq1dw/IM7PkZf5et6vHZ0kU19bxyNlSTKfnkFFCDs+Vljp6oGSTBcN+bMhZMdtpe8f0xCy10f0iVKigiz7sAML/JFN1xRIt4M6/ixhTUb06r98Sg+svylaYQ4O+fmoa6H1xc5/BmOjbjMyO0PUYSafWzwB4xOxpnZKvw8S8XDqX29n8JpTymIvXrUI3lbA2LTgqSYDgV/oVYpLrBmf4UXYEHGWPtZrrjx3IX80jUIZrSDrP9bqMIc5UPeqdwUIk7Qy86kakmKWNDL5a3vodaL013FiKNUfdYzB5zZV7zCw8EKOhb6YUcuvRNewJYHJcgGCk/ADVeB/43zozJqGcRbET1pDjCN4HUlUdZRxcIRzZEV/PdEbIntgjaawGlkHa3jeS+utl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NbsbHfQNGgYUhO5RvFMMT7vKHDS15/tMsRHltjYKklk1UdYmzi8UATl1aGM9LxGWF+Kio62ilMNw6LsPskkS+sVvnc6uN7Cam2tYpUjrmMpjRnLrX3dyNoLyUDpX8Bp1FjBcpSmoJcg6WedWF6/KNbi1q390vLGAqLe3L9j5VxjHa4iC11dc60+rZX11unSNP/osHu8Im7AOIcQ5WQCk/HFypVjKXnPuLQC3w9aQMGnlslW5Lbi8HynKUa5PJcNl4Zp3uIaFjaBuOJys9mePEGQnPCop2CvSCT9ZGhASnwR+F0/G6U6DAdPa+jG0uRrGxq19dGg9iw0ZezTHW3KBFb1lHpKkvFcMCxtYvCLrxofe9F3QFaeKM+8phXbU+DGLzhkk55u4ic0ia9jfIluVoTiMHmMnfHDDc/vmU5H1M70mvVu3/FXYoeKWXsXUiXTtkYiJaWo/ab63hOQPran+cXekK/2N0FelU+za2PCJP7QmPuyv6dghgcWaYxWPM3B+65QiSl33jYd+A5GG4Qi5hqzGoXCJtDaNdFBl4nSDUSolmvIvE/C/sGfxnu6ZAKYvWWjA39E0lzx4jDiiJKBb/hYki7bUWv8Dt2I9Gg6eTjXf4bxEeUP7/R3JRr8Bk+6dbiQeSPMVMPSuYBDHNI08pN5pxnp/GQfVUWWh1O4F6F34+Z6hVyvYsCOUxtxyXv3bhVbZek8DwWz+umrRlqOOi0thMUaUag0kSPg0wfoCWJF5WMTO3v+UXmlhgZifNAua2hcMcHSRKnqiH+EfCr1uawEaDEfAVa/PZRCDdmxfkzHXUiD51mqGvTXocavF84s0js+Q5papzE5a/ci96Z+rWemZKO4trky7k1ACDtIqYexTKYLlbwn59eNNHPEMDmKQ6vG+9DZk4JImjr7PvbOXyYjGagxSfyGOQl8/nrrGW2acJp9uX68AJlRNyYK6a67IVflolJSD2gezjeB56775Z/piBT5mfoUh8yGLuikhdqzEyQk5+SIsbgaKULN9lUOktJPW9oG3joxfFN5YVKU4voDxrx8v4nTAf1jahc7fxaGRmW3Fwd+qi1JfVGwtVnxscWSTG4lNveh+GnbuUb/wilhVnuNl1NKqhzW4dRPtfw6wdZpUbL7DNneAc98F2WcbZci6BSID353Lh2p4HqGRad0yqCofwY/LZuRnL+uShLagA5+D2P2Sy4BK/BjMsNICYCHiU6QAOLoA1sD8NixQtCU4YJndCedhGqArtOQNwMD6A+J3Y7UfncJyiLgxx+pQKtS6Z2Kb6XbNlNC8Tw1qew== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 12602520-2533-42d8-f104-08daaf6ab144 X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2022 11:36:40.4495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB2790 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Problem Description: According to the comments in the hardware vendor's outdated source code [1], AX_RX_CTL_IPE signals the hardware to do 32-bit(4-byte) IP header alignment; such alignment is equivalent to the concept of NET_IP_ALIGN = 2 (an extra 2-byte "pesudo header" at the beginning of each etherner frame), as described in skbuff.h. In the current implementation, however, AX_RX_CTL_IPE is always enabled regardless of the value of NET_IP_ALIGN; this can introduce waste in many aspects, such as 1. hardware internal resource 2. USB bandwidth 3. host memory 4. cpu cycles (for updating frame start pointers and frame size variables) when alignment is completely unnecessary, i.e. NET_IP_ALIGN = 0. Solution: Enable AX_RX_CTL_IPE and process pesudo headers only when NET_IP_ALIGN != 0. Verification: Only tested on a platform where NET_IP_ALIGN = 0, with this device: 0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet References: [1] https://www.asix.com.tw/en/support/download/file/120 (AX88179 USB3.0 to 10/100/1000M Gigabit Ethernet Controller, version 1.20.0) Signed-off-by: Chun-Chao Yen --- drivers/net/usb/ax88179_178a.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index b50748b3776c..96ede3a131d4 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -858,7 +858,10 @@ static void ax88179_set_multicast(struct net_device *net) struct ax88179_data *data = dev->driver_priv; u8 *m_filter = ((u8 *)dev->data); - data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB | AX_RX_CTL_IPE); + data->rxctl = (AX_RX_CTL_START | AX_RX_CTL_AB); + + if (NET_IP_ALIGN) + data->rxctl |= AX_RX_CTL_IPE; if (net->flags & IFF_PROMISC) { data->rxctl |= AX_RX_CTL_PRO; @@ -1424,7 +1427,7 @@ static int ax88179_rx_fixup(struct usbnet *dev, struct sk_buff *skb) /* Check CRC or runt packet */ if ((*pkt_hdr & (AX_RXHDR_CRC_ERR | AX_RXHDR_DROP_ERR)) || - pkt_len < 2 + ETH_HLEN) { + pkt_len < (NET_IP_ALIGN ? 2 : 0) + ETH_HLEN) { dev->net->stats.rx_errors++; goto advance_data_ptr; } @@ -1438,8 +1441,13 @@ static int ax88179_rx_fixup(struct usbnet *dev, struct sk_buff *skb) } skb_trim(ax_skb, pkt_len); - /* Skip IP alignment pseudo header */ - skb_pull(ax_skb, 2); + if (NET_IP_ALIGN) { + /* Skip the pseudo header, 2 bytes at the start of each + * ethernet frame, resulting from hardware 4-byte + * IP header alignment (triggered by AX_RX_CTL_IPE) + */ + skb_pull(ax_skb, 2); + } ax_skb->truesize = SKB_TRUESIZE(pkt_len); ax88179_rx_checksum(ax_skb, pkt_hdr); @@ -1609,8 +1617,10 @@ static int ax88179_reset(struct usbnet *dev) ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_TXCOE_CTL, 1, 1, tmp); /* Configure RX control register => start operation */ - *tmp16 = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_IPE | AX_RX_CTL_START | + *tmp16 = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_START | AX_RX_CTL_AP | AX_RX_CTL_AMALL | AX_RX_CTL_AB; + if (NET_IP_ALIGN) + *tmp16 |= AX_RX_CTL_IPE; ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, tmp16); *tmp = AX_MONITOR_MODE_PMETYPE | AX_MONITOR_MODE_PMEPOL | From patchwork Sun Oct 16 11:36:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yen Chun-Chao X-Patchwork-Id: 13007765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246D0C433FE for ; Sun, 16 Oct 2022 11:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbiJPLgx (ORCPT ); Sun, 16 Oct 2022 07:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbiJPLgv (ORCPT ); Sun, 16 Oct 2022 07:36:51 -0400 Received: from AUS01-ME3-obe.outbound.protection.outlook.com (mail-me3aus01olkn2157.outbound.protection.outlook.com [40.92.63.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F74E39B99 for ; Sun, 16 Oct 2022 04:36:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvwj3mxtZf9K+u2jfuCtw76MHvsf8lZxFKx+dHW5EZ/nJjRaH5Tt4laevKFwEdtz+Pv4dDRg2wZSzZh8S/p5QewubKEOzTiYy3cu+UfVOW1pYU41AKlwFKtsa6e/5P6iqjaNDg41IibcWl1icBWF6uw9USPCxe/lH3hqGCPl10c9Da0LTg5TUogzTQIyxvRKgiOpTSlgZwTqbxbpI55Iz2TlkVff//76Q3VOU28Qk+RHv43roXRqZIjvtj+EKQg/NSZ/gKT6x+tXA5R/IX3cJjEQIopF8M9hIpNXhC2cqueE34Ury/3IGK9PW5oQRpwBQtinUUDgR2wonbldxWPwNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rIdBAdu5ytZ67B9JZB/nneJXLg81xKaa0qhv+CktaRQ=; b=AuZThStgOm7LkZ55NH/yfZuwWxBRKIWbUqfMHlaVkGIQddF55vGAvAKmrzYzRv16GUk71G00qVSYcsIPgbW6nPGRb6KwwIVodf+sgyeP1qYoett+j5yYNmhm2P5AIAOPLBw7Co1ulSz9XOrvzU7JR4omgwQqPGG6G3EVcLZD94UEPl0setYY5CAeG3RfufOtJVtwrvqEx5LiMrVhgG96oAvQStzOjCjwo1yqdN08guXgqPykuQNsHefMeMGD3SAqYO2SrFa+289Jnt1YCYKwPeJIMiY1bS4t/6nRJaZOJnxlgwp5A4OeNOe7JxLBHvHMNpltGEIuP+1+yiEW57RlfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rIdBAdu5ytZ67B9JZB/nneJXLg81xKaa0qhv+CktaRQ=; b=BEU8hO/RqpKFAHBB0yrz62irpKRHw9zlAMNrzRpn7w8zAo2ONUEyNhT5oAWCRK86yca4T7LQ8/WJzSn4yuhnlFUNhEC35laH45SRgjjGPWeghbjC6csW58n3hZThrliDvXf4ykZhpi0CybYOHgGKmdFsFc+nyfF2zuuUS2+ryYxxl9/gXHQdhSAYoPbAXdASCNsPutpyevteigaVU2Q5Zgbch+2QswXH3bxbel9WolN/X2BzahDVju6cKDm6RuLo3AzvqAJdJKXe1b3ahxR7NB1ECXohlvMnLVB4q570BZYoQdAqT7cMQqAgSIIcP3Lo5JlVhQY3OskooW8VWCLU9Q== Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) by SY4P282MB2790.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:159::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Sun, 16 Oct 2022 11:36:41 +0000 Received: from ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06]) by ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM ([fe80::d403:bdaa:515:ae06%8]) with mapi id 15.20.5723.032; Sun, 16 Oct 2022 11:36:41 +0000 From: Chun-Chao Yen To: pabeni@redhat.com Cc: davem@davemloft.net, linux-usb@vger.kernel.org Subject: [PATCH 3/3 (RESENT)] net: usb: ax88179_178a: Allow live update of devices' mac address Date: Sun, 16 Oct 2022 19:36:27 +0800 Message-ID: X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221016113628.4176189-1-nothingstopsme@hotmail.com> References: <20221016113628.4176189-1-nothingstopsme@hotmail.com> X-TMN: [GgnMbM79s8NNfomjuvcLKeHDzUEZG8dx] X-ClientProxiedBy: TYCP286CA0120.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:29c::20) To ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:13c::13) X-Microsoft-Original-Message-ID: <20221016113628.4176189-3-nothingstopsme@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ME3P282MB2827:EE_|SY4P282MB2790:EE_ X-MS-Office365-Filtering-Correlation-Id: 37b29fa6-5be2-402d-dfa5-08daaf6ab20f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXlxSmdrGUrlzT7mFPrBWM9PL1CLlymjz9XntQJsgDqV5wE676PjtXVoTcIpD8PJ6cocMtJ5jken5pXjhwwbqqm2rBizJBlFCi0e6g6FtQCSs6ylqlF2C1frPrX1df762mt9MwsiOyFqg8+KYUVk8RuLh9zjoiQrPKi8kPw0D9K1sUdgvG6CsSRGrOFgpItAKvyVJ3qKP6WefvCCBu6sLXqAQDY8L/D1ClSc3/Mt8h3HVTle4zz2hzIDnXk1Den7xhJ1SjvKTV80Dq/NmXhJE8WUBs3E1840J1935z9XwS2Qppf2d/uDSLGgorIOG7wQ+M6AAW98xMzJByTnweCbLOK956tK8P+V4qwddd4qSXuQcLH3EeRNx94iHCAtAPrd1rnyNXhiTpTPPkNGRw6gffX3M912dr/nOpz/NPMlnAPMlDjve9eMLemlzINqC32qFg4kuP0s7H00MQ/g2ko74NUIy4Xh2lGwuitW4Hv15ebOdep5WfOyKHe4+qfTmpdMaEdyusYoLrSPDG3HrtFk0Ep7Uxy1shpw7CfPtFw+xQFsv7KSrNbk/sv4JcxF6Pu5fe6IJ0YLVyUop949W9eVDRn1IvAwo2htRh84PLnUaItCZPqfIimeFP5070Sjha7X X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gPckE/sMjvrMQoWIAsnyPepJ2C+MEQr0vqwcrRJZuX1Cdjg2KDEzE0YfZE4T3+p4drMJlA2dpTObJIezC/bfQQ6BqidHRUOAe4CpFiKcpW5We7mGKLdTSRM/v3IR57VLlQI8AwcDFn1oZwCdC3qcMEEiXvg5AkoMOtM96PTQB/KmXCBloCHd+TZqR/kn9tSNHhyJ0iZgFg+5i7kWNtNL1vKa/GroD9a1iRtVPCleczRW6uhU/KNyUtER7LCASvfxQ5o6yN0qYMJgxStEzqYKS7ooxh5/eL7HY64mGnW5FsCCDr7Bgabt4rOUBbD2knVy1ZgAE44l5MrNheB0VlZppVC5P4TX8ObLhVcNMXv3g2qoWfCw6IZhJwg9moeQ7nq5THMoD4xhpj8rywRS1XOFk1djyIASe5zVPdAC/M5PXKxLC+1CcdzlVCoSdID2G5lUM2lhW2OmB4uSB7DshOHIwz+ymWaERBDeZJEXZySYFm0Ar7k3BaJs1p2e2fjFBeWG44A3sYeCNmIYntvMZeuctBwJ49JuVJoWQx+qFBIamU/njN1cnhCHp7C7TTQuuvImDziUg52b5cTXFWduoLpBlRrrpFTy/TWfUz00PbXz5lNZQlgAdvxPuDsya8sYOprXc3ty6Vr2XJ7SY7SGTfTWsH54VicUYOXBkSXwxHZXtOIE1L31HpiJH7NGJBUMAFUh80qFiB3cCWg89mmXQUG5VEDlOWhBV0TTCaBobasLMrxzaxH/r2zsLnqqciq8KRAXrTpTggVGZzpDuqxeBp5xs9vSZAyktnWuH284FXMTX2a9MBUzd1uNr+GM2og0qmXEv7ZB+iAGcPZf1Fhj5W13XEGe0dU9jriGs019shfK9w0t6GNxRzL4ZK92JTGoKzBCydzLT9Voa8cXURhiA0dtUw9P/aBkeivQrTd1h5geyT79RodS3bE+wcicWXzv3nlR9jf/jE6VGSlG4INGrcOEpTnd7/xTKMqvN7Dm8QdEKCMgvQzJnKbjH9GJvfKv1nrcKmlENtqRYRx9beXTcAJEd9u4eZyXfhyrplb7KQ2ofsRbvEl+vF9EdvXkd+GN5a4Zw0SZInUZmZQOFS7dz6hbsD1uBdE065jajnpj/QwQcE0DZEZvAl2r1DJRrt0Pk8sQpUQYQCoa3aX6LXGDytw9prL+bKinGotLplQ00xhAMm1h5XOUuSOz1ab615WgnvM7KHKc321Vz1OAe1bf/p3cxR5tBlDP5w18Vs8NwGQYWaI75qLj8/UFZD5NkVwX26OaecFF2rRVv8dRnF33YRnTEA== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-746f3.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 37b29fa6-5be2-402d-dfa5-08daaf6ab20f X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB2827.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2022 11:36:41.8406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SY4P282MB2790 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Problem Description: Live update of devices' mac address is currently blocked by this driver, as it requires the evaluation of netif_running() given the corresponding device being false. While appearing a harmless check, it can be disruptive in some networking configurations, such as "Link Aggregation" operated in active-backup mode with fail_over_mac=follow, where the mac address of a device will be updated dynamically even when it is already up and running. Solution: Remove the check of netif_running() in ax88179_set_mac_addr(), so that the update procedure can proceed irrespective of the boolean status returned by netif_running(). Verification: Only tested with this device: 0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet Signed-off-by: Chun-Chao Yen --- drivers/net/usb/ax88179_178a.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 96ede3a131d4..84016e0567d4 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -958,8 +958,6 @@ static int ax88179_set_mac_addr(struct net_device *net, void *p) struct sockaddr *addr = p; int ret; - if (netif_running(net)) - return -EBUSY; if (!is_valid_ether_addr(addr->sa_data)) return -EADDRNOTAVAIL;