From patchwork Tue Oct 18 14:36:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tuo Cao <91tuocao@gmail.com> X-Patchwork-Id: 13010714 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2279C4332F for ; Tue, 18 Oct 2022 14:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECD366B0072; Tue, 18 Oct 2022 10:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7D056B0075; Tue, 18 Oct 2022 10:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D451C6B0078; Tue, 18 Oct 2022 10:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C3C1B6B0072 for ; Tue, 18 Oct 2022 10:37:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 070941C6921 for ; Tue, 18 Oct 2022 14:37:58 +0000 (UTC) X-FDA: 80034324636.21.A5A615A Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf24.hostedemail.com (Postfix) with ESMTP id A28A2180036 for ; Tue, 18 Oct 2022 14:37:57 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id f23so14025878plr.6 for ; Tue, 18 Oct 2022 07:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=eM6DqSRMVv1I6J8Rz4Q13ykLhUES0rYe2ZYVOe4gWNOOFdM/+7+opEMdjXhtGxPWjZ bkpiva/nANsSBAd4nBXwf5CJkXPZHwmTP86j6+lVmWxtrTwFUtpjEBWUaQBk7vPcqxG+ /WNRm2BiHWURU4dh5cUAPm1sloxCaP5vAwC2ysF+c3V73d8Kd85G8tfakguKHGjXbCT2 NN/bPmOoeKedMKykOVFqW/7QOoreIvYon+Ktf8REPPEcnQfj4/j3pzg9f+bR/JUxL5Bh Z7OYmQTVl6APm14AWCO7NdZE+i3+PGBOSSNLz3zsolKGxdt1BaXfdKu9hlAsH/C09RpX 3+Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=ocdgC4bfrXl8PV512aJxwCNryVEQgVdqUp8YT+OJA0M3Jq0uNiR53YLmji3e7Fny9/ 8HiVzfRxyKwHcKpbH2Rif9f5ZWnRnC2olmSgDALnDaC3y05NvFz5I9RPJu55MaG0Cnzp spSMrNoLT1QaeKuryT8NDjwPwvtzU3aNg2bce0fxq7K4bvsFM0xTON3lizDSNhgo8Gxm cJXfnw/ea+QDRTZsf0YzIZ6ZSuD4+3Dt7C4SqVVjShzivDvEZfOSW41/KborRB8owrBn mdb97PLHKreRpcy1chCJZpNSPD2CO8GAJ2EcsJM0W48Uns+xTXS/OVXvitEmicjTk8sJ PO7w== X-Gm-Message-State: ACrzQf2n1rKbYTgARRJS8fV8KxFB5LsGI5FjLGXw1RAYFh657PA6M4LM z6wMGBlu7aiTQvkIe7MiZvc= X-Google-Smtp-Source: AMsMyM54iVDRJ+YG116kjqtwzeL/Vs0TW/7yChUCfXljnPckCF3wWpxsUUte6Jy+ewQHHv1xjgFtGQ== X-Received: by 2002:a17:90a:c7d3:b0:20a:68a1:85cb with SMTP id gf19-20020a17090ac7d300b0020a68a185cbmr40099316pjb.138.1666103876522; Tue, 18 Oct 2022 07:37:56 -0700 (PDT) Received: from localhost.localdomain ([182.160.5.243]) by smtp.gmail.com with ESMTPSA id b16-20020a170902e95000b0017b264a2d4asm8814839pll.44.2022.10.18.07.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Oct 2022 07:37:56 -0700 (PDT) From: Tuo Cao <91tuocao@gmail.com> To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 91tuocao@gmail.com Subject: [PATCH] mm: folio-compat: fix bug for pagecache_get_page Date: Tue, 18 Oct 2022 22:36:39 +0800 Message-Id: <20221018143639.5099-1-91tuocao@gmail.com> X-Mailer: git-send-email 2.17.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666103877; a=rsa-sha256; cv=none; b=VJdOKPUPh9UT/6ZcLgpHW/jfeu00/eaoAaqOnX9bUC1J93awwV0XFJ3X/XtwEmYX8UjiRy KirS1eG6RSUZqxkeOxfpEE59gfiW/HToAI+73P8k6QMnAyPNg0ZWgH8bXcRrV2KAJL6S2K HQuc3fUUVJJa+IRB67R4MdSoPCEmGns= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eM6DqSRM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of 91tuocao@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=91tuocao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666103877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=zwuWy4jARkZiYQhQKKp3kZsxq7qh8bIcksVC/zF6xJY=; b=v76C2l/lLZKXpybcu1C7mp6MNCB3qbRy9Zlyq0GpaDLcgYdLk7ZWKcvWepOSMQolLmYKJ1 jixpxbCJRTFZdGyK3dlSpgwepVKsEFOLSbudLh4yba7AZWcEt+8WU/jl7UQcuGcdk95MQt o82AyM/TR13R8RRJCLY17Zmib01Id1s= X-Stat-Signature: ukqo7r9i9knm46nytg5s3kx1i9jetbke X-Rspamd-Queue-Id: A28A2180036 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eM6DqSRM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of 91tuocao@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=91tuocao@gmail.com X-Rspamd-Server: rspam11 X-HE-Tag: 1666103877-841973 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The folio returned from __filemap_get_folio may be a NULL, it will causes the kernel crash when access folio->page. Signed-off-by: Tuo Cao <91tuocao@gmail.com> --- mm/folio-compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/folio-compat.c b/mm/folio-compat.c index e1e23b4947d7..37ba33135506 100644 --- a/mm/folio-compat.c +++ b/mm/folio-compat.c @@ -108,7 +108,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, struct folio *folio; folio = __filemap_get_folio(mapping, index, fgp_flags, gfp); - if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio)) + if ((fgp_flags & FGP_HEAD) || xa_is_value(folio)) return &folio->page; return folio_file_page(folio, index); }