From patchwork Wed Oct 19 16:38:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012166 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0A9C4332F for ; Wed, 19 Oct 2022 16:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbiJSQj2 (ORCPT ); Wed, 19 Oct 2022 12:39:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbiJSQjZ (ORCPT ); Wed, 19 Oct 2022 12:39:25 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA9925EA2; Wed, 19 Oct 2022 09:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngD30IkCgBtBSfKnO1m+dcLmZNaa/rG8f5Z+JG+7NB8KCf1tthZR7Vn8LMIo++rPvdWDMls4UvZI/DUULTzGxsBLQ0+Nhc4aoWqbLrd4xxFSXJqSdDH1vsAQydU40gFujNbdJtXSRjTQPmx+GofTMi3Cei/yMtYyxBmRMmy0JAiDAgLrbxUXMpC+roniq1WOvYPotsu2J5u5B6nv630fJPZUgHBs5rboT/cFZut9c2HqdOcaPLPsmoK4uC/myGwTMn/sLVe5AazLj3VepIJ6mEQiOsQTMsPrm0xkcMQ9mZYlLhMbMcv3kUFxDQluhTO570wwrrhynrOrut04rLqKQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ztuGq2FTvBPO9qE1epwO3aSqJAJQbfBz/Tjg3yJV2fA=; b=ml4w8bioQJqZ58UIqEBQdYyVZ+33jYuzex16AF10+8pUxHtUDqMSP0z4XDdJHNbS+h6lnYQMViUnzN9o95sRpFHyNfSBB9t8R2qrmyfPS5ehfYOdYa4zAtfC0ym/fikQzrya4rc4F8mJvf3mq4wRsznpKonT4Z5fXiSdMtCxT5pO6wa/qwkTDGoeK6jnK6JMmsgLlcCu8VVxehadsCVkzEJYR/cCL2axaapYs3IOCSucZ9XVfSgjdSO6NC2d6hgrNqH6WBy9OrRMbIivMDbGQ1Bw/KPGOTXdarS/x8daWQPQ6zgz3Jnfxj48ZpEY7UngUu2fCLBiQXZ18aSsNaFaqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ztuGq2FTvBPO9qE1epwO3aSqJAJQbfBz/Tjg3yJV2fA=; b=GumWHcwnbWETCOgsAHwyqmxjOPlU82hF2tSXuFGhpxVRJO31AOWpxu5vhpxPN2KK60tFi9rfE43nr7yNGqoDOxPanODJkNasEzj17kDWxetdlMw9AVTECNPMCxgUp9lKvy/AISdKy5FmN3NVp/KIMjxAFen1qNCc76g5zR4vq/s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:19 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:19 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 1/6] PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning Date: Wed, 19 Oct 2022 12:38:50 -0400 Message-Id: <20221019163855.1267295-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: a4f08106-af3b-4238-bd76-08dab1f07802 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Txv9TmqkATBOvPDSv03puwWZksyIS4Jz9cQKd/b44BPYRzHJ4q2f/RERPOk2r5bJ5VrIZ5QWIIx4wz7C0xPURUV72CQKwSnk8TTtsRpA9RYNPwS5NnQHj+r4GG7kcOfkRdjeZPmb/5w4YdRxQOhoYLg2JI8hY86QpjOkQPnixZUA6AiCNhcB094Z+SBlDGgUN7SJvtZtnjTZvdaCO2+Cqis2theB6QJvBKeC82Oo/eFgU1cDkhcUs2rJM6w93wpIPRxKRsi002h0Fx1CLkTloQPmc6VLiXeU9+UyNNWFNkhevYeVKX61mjv7SKVeyB1nTtLVzScWYn6Lj6K8qDJ8WyQZzWo3V806heI2bHH/sUQbVijqm/ay37d1ScGSjUp3QlwaVPecuGsglHJ3zUrVV6xroBeEEnXV65KxW1/zF9Vby1OV128Ll73B3286LudYgkVdPazGzMGVddqRcX8FtSisCH4xkdbJUdjrAu+xYbzlovwFwKIyvUJssMP45nVkBK58MGBclkvR5D7RuLJKdaYh2qnfcPJlGLszHk92088VfGSg+nvAiSgnov4iE+g5XZ4QJ6jUviedcUdskTKjF0iifm35RDiuT1tEfza8+97SZ1UeOumi4rIccFk5DGXebpu3alWTP36iVfuaOjfSvNAXH1NSyswvH1YItR7TFOgj+z0KTkWShCjNvIdYr+bulFb7dzpYCLv0laYQ6ljKcJ3Q+D3zOZz4wf3YIk9fAXOrGHtL9tecAB998za8J7pLVU5TmrahUEf4lzDq/rtS+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(2906002)(30864003)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Y3ZOF+jQolxjZIQ06oxVs1ZAz1NASeSazLrlLsRK+LKWjkJpogHC65bmQOHgoNUqYtlh2cnGlxP9z59vgRdRzrYLu+RyeQgs8A24RaMORE62R8ETKu50FFEii+SZDnW9IErV+5QiVOm9WyKeK9iKgjsrLie2tOqChvjlXE+VnqtvX1K5rKM9PHVMWjKevfLR5SktSZhLRR/c0AXoBw8fywjFVUYPsNVaGEwOKFdCQptb3CNbxPBHvkf9UpHbNJgy8877kZ/7HflsXwOw4/5TKDlQBo3RWTZcdJim2S664oV3vt/55BZXE04iaRhTHHUNsMZWWkg/gDsa4lSff4wnz2gx+P47iVGHhccXzZOGEPGINzRNOnakW8Owm8mQvIttgEeCECUSDaM21J0NW9I6KKTfitfQHp07l21kwO4RfIywcB/Je68pbevKVcEckhR5JFSDB0aFFIIiD06Pihx07pr6nu3ZytrWewRB5N41b14fNHospNZ09wKyHxaOTiNoELXleMk3xrO5c98n4t7QBb0NDNfMVkofcMwPuefyquwi7Ser8HsGqq+/QCbKJAZ6xCmy3f7nSDZiCIaCLGtvgCXAAjEXUrO3WX63cVEZlDuyiHJjG3vDZD72a1bCdHRfqNky6iNkqvbQbKgpdexKchf3b/V8oLBNxNzEQjHzrDPvDGvyKVZxVB+ef7KpEIxEThJTYIl51n8+Rj98yGUEVWtoCiH+txRcDLjHvxuKeZ7WsaBHhcgAz2uRC9MMATQJtlbMaZWrZ+/fclsZIy58ItOdVi87sTr2Z4lc9G9l936YI6RX2zqbojGMmFD2cueaZK0cZza3v3woagl/1WefCya6cP4Oy8pXzJfeDVueeNC+FBKkSu/Xzm+z0ug4UGqGLISrP+ho9x3PT2kyjznqW2ZnfUNW6IX7aTwFFEtxmRtwVXW5MqBQZwC/lIedz4halrnWeFxP/kiwxlHtnof9Fp9L5MmLsYRI2NVpjuOUaOBWlK74NMOUP6/VfMw0Cpqy96VRH2GfPlqwLOw9KO4bkXNifBEYNpmYU0DRiVBy2fnHpn9dP5vWj0iwNOvILlUDvjH+dvFpZYDMlHmalKBHhPXyHR074cz0Cd54QBnCMvIrcLp0awZuZxVr7XUekrav5ZZu1WbI2DTIHf9y/zimLidhrsF9Ri2MGyHCV7DyFE9w4rfoJkU/SmpQCLSwbrH6dSgaCU3/RX+psrF5NEggC2yPrYYNVmqEvHxq34uzluEgtHLKAEecuagxj3QKw26D84mktRNnKTKDyVCowSEYTN3X0CNutvnSAkWow6wm7l++kVZDLCFbd6cRgtFwbbK/9BMhPLKykhPjxdL1vlyucmwbCaVjOs1MrEtMKvfW/ObGwn0S9FvlO3GpOnNUhjXCDzBksTqKCaPGhG6N5i1QhD/rJpXldUWql3t4lqzKC/x6QfVgQw/I0yHVLCDGKYaOs2FJ9qGbV0Dk/HNiLIx1x5xTD3rd1Nq2wJaHHwL4HfU+ygP0jYYG3N0Mi1iy9qgePpw3uucNh2j1mMnxfrl8yk4tqznAHqeM+S0exx67cHQVDDrck17hiczVWUfYCD7O X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4f08106-af3b-4238-bd76-08dab1f07802 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:19.3496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 75b4GS/+bgN4Ijmz4Xz9VKIWW8YbsyYROc7mS9dk0MiTCoUXuen0ZJtCQTyungUpqBklFTkZ8+mjKE8/hpusgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Cleanup warning found by scripts/kernel-doc Consolidate term host, host1 to HOST vhost, vHost, Vhost, VHOST2 to VHOST Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 83 ++++++++++++------- 1 file changed, 54 insertions(+), 29 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 0ea85e1d292e..c0115bcb3b5e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -11,7 +11,7 @@ * Author: Kishon Vijay Abraham I */ -/** +/* * +------------+ +---------------------------------------+ * | | | | * +------------+ | +--------------+ @@ -156,12 +156,14 @@ static struct pci_epf_header epf_ntb_header = { }; /** - * epf_ntb_link_up() - Raise link_up interrupt to Virtual Host + * epf_ntb_link_up() - Raise link_up interrupt to Virtual Host (VHOST) * @ntb: NTB device that facilitates communication between HOST and VHOST * @link_up: true or false indicating Link is UP or Down * * Once NTB function in HOST invoke ntb_link_enable(), - * this NTB function driver will trigger a link event to vhost. + * this NTB function driver will trigger a link event to VHOST. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) { @@ -175,9 +177,9 @@ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) } /** - * epf_ntb_configure_mw() - Configure the Outbound Address Space for vhost - * to access the memory window of host - * @ntb: NTB device that facilitates communication between host and vhost + * epf_ntb_configure_mw() - Configure the Outbound Address Space for VHOST + * to access the memory window of HOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * @mw: Index of the memory window (either 0, 1, 2 or 3) * * EP Outbound Window @@ -194,7 +196,9 @@ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) * | | | | * | | | | * +--------+ +-----------+ - * VHost PCI EP + * VHOST PCI EP + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_configure_mw(struct epf_ntb *ntb, u32 mw) { @@ -219,7 +223,7 @@ static int epf_ntb_configure_mw(struct epf_ntb *ntb, u32 mw) /** * epf_ntb_teardown_mw() - Teardown the configured OB ATU - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * @mw: Index of the memory window (either 0, 1, 2 or 3) * * Teardown the configured OB ATU configured in epf_ntb_configure_mw() using @@ -234,12 +238,12 @@ static void epf_ntb_teardown_mw(struct epf_ntb *ntb, u32 mw) } /** - * epf_ntb_cmd_handler() - Handle commands provided by the NTB Host + * epf_ntb_cmd_handler() - Handle commands provided by the NTB HOST * @work: work_struct for the epf_ntb_epc * * Workqueue function that gets invoked for the two epf_ntb_epc * periodically (once every 5ms) to see if it has received any commands - * from NTB host. The host can send commands to configure doorbell or + * from NTB HOST. The HOST can send commands to configure doorbell or * configure memory window or to update link status. */ static void epf_ntb_cmd_handler(struct work_struct *work) @@ -321,8 +325,8 @@ static void epf_ntb_cmd_handler(struct work_struct *work) /** * epf_ntb_config_sspad_bar_clear() - Clear Config + Self scratchpad BAR - * @ntb_epc: EPC associated with one of the HOST which holds peer's outbound - * address. + * @ntb: EPC associated with one of the HOST which holds peer's outbound + * address. * * Clear BAR0 of EP CONTROLLER 1 which contains the HOST1's config and * self scratchpad region (removes inbound ATU configuration). While BAR0 is @@ -331,8 +335,10 @@ static void epf_ntb_cmd_handler(struct work_struct *work) * used for self scratchpad from epf_ntb_bar[BAR_CONFIG]. * * Please note the self scratchpad region and config region is combined to - * a single region and mapped using the same BAR. Also note HOST2's peer - * scratchpad is HOST1's self scratchpad. + * a single region and mapped using the same BAR. Also note VHOST's peer + * scratchpad is HOST's self scratchpad. + * + * Returns: void */ static void epf_ntb_config_sspad_bar_clear(struct epf_ntb *ntb) { @@ -347,13 +353,15 @@ static void epf_ntb_config_sspad_bar_clear(struct epf_ntb *ntb) /** * epf_ntb_config_sspad_bar_set() - Set Config + Self scratchpad BAR - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * - * Map BAR0 of EP CONTROLLER 1 which contains the HOST1's config and + * Map BAR0 of EP CONTROLLER which contains the VHOST's config and * self scratchpad region. * * Please note the self scratchpad region and config region is combined to * a single region and mapped using the same BAR. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_config_sspad_bar_set(struct epf_ntb *ntb) { @@ -380,7 +388,7 @@ static int epf_ntb_config_sspad_bar_set(struct epf_ntb *ntb) /** * epf_ntb_config_spad_bar_free() - Free the physical memory associated with * config + scratchpad region - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_config_spad_bar_free(struct epf_ntb *ntb) { @@ -393,11 +401,13 @@ static void epf_ntb_config_spad_bar_free(struct epf_ntb *ntb) /** * epf_ntb_config_spad_bar_alloc() - Allocate memory for config + scratchpad * region - * @ntb: NTB device that facilitates communication between HOST1 and HOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Allocate the Local Memory mentioned in the above diagram. The size of * CONFIG REGION is sizeof(struct epf_ntb_ctrl) and size of SCRATCHPAD REGION * is obtained from "spad-count" configfs entry. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) { @@ -465,11 +475,13 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) } /** - * epf_ntb_configure_interrupt() - Configure MSI/MSI-X capaiblity - * @ntb: NTB device that facilitates communication between HOST and vHOST + * epf_ntb_configure_interrupt() - Configure MSI/MSI-X capability + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Configure MSI/MSI-X capability for each interface with number of * interrupts equal to "db_count" configfs entry. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) { @@ -511,7 +523,9 @@ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) /** * epf_ntb_db_bar_init() - Configure Doorbell window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) { @@ -566,7 +580,7 @@ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws); /** * epf_ntb_db_bar_clear() - Clear doorbell BAR and free memory * allocated in peer's outbound address space - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_db_bar_clear(struct epf_ntb *ntb) { @@ -582,8 +596,9 @@ static void epf_ntb_db_bar_clear(struct epf_ntb *ntb) /** * epf_ntb_mw_bar_init() - Configure Memory window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb) { @@ -639,7 +654,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb) /** * epf_ntb_mw_bar_clear() - Clear Memory window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws) { @@ -662,7 +677,7 @@ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws) /** * epf_ntb_epc_destroy() - Cleanup NTB EPC interface - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper for epf_ntb_epc_destroy_interface() to cleanup all the NTB interfaces */ @@ -675,7 +690,9 @@ static void epf_ntb_epc_destroy(struct epf_ntb *ntb) /** * epf_ntb_init_epc_bar() - Identify BARs to be used for each of the NTB * constructs (scratchpad region, doorbell, memorywindow) - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) { @@ -716,11 +733,13 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) /** * epf_ntb_epc_init() - Initialize NTB interface - * @ntb: NTB device that facilitates communication between HOST and vHOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper to initialize a particular EPC interface and start the workqueue - * to check for commands from host. This function will write to the + * to check for commands from HOST. This function will write to the * EP controller HW for configuring it. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_epc_init(struct epf_ntb *ntb) { @@ -787,7 +806,7 @@ static int epf_ntb_epc_init(struct epf_ntb *ntb) /** * epf_ntb_epc_cleanup() - Cleanup all NTB interfaces - * @ntb: NTB device that facilitates communication between HOST1 and HOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper to cleanup all NTB interfaces. */ @@ -951,6 +970,8 @@ static const struct config_item_type ntb_group_type = { * * Add configfs directory specific to NTB. This directory will hold * NTB specific properties like db_count, spad_count, num_mws etc., + * + * Returns: Pointer to config_group */ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf, struct config_group *group) @@ -1292,6 +1313,8 @@ static struct pci_driver vntb_pci_driver = { * Invoked when a primary interface or secondary interface is bound to EPC * device. This function will succeed only when EPC is bound to both the * interfaces. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_bind(struct pci_epf *epf) { @@ -1377,6 +1400,8 @@ static struct pci_epf_ops epf_ntb_ops = { * * Probe NTB function driver when endpoint function bus detects a NTB * endpoint function. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_probe(struct pci_epf *epf) { From patchwork Wed Oct 19 16:38:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012167 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19DAC433FE for ; Wed, 19 Oct 2022 16:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231342AbiJSQjf (ORCPT ); Wed, 19 Oct 2022 12:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbiJSQj2 (ORCPT ); Wed, 19 Oct 2022 12:39:28 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF4BB14D0E; Wed, 19 Oct 2022 09:39:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddoDaHhdelUAn4A5CCCsHcjhMwaMeLIRN9ux2mY/VVmY0BAjSMiAY0LMtc6h/JRal3nx+Pm20qnglxxSb2+BOOeq8KjhKsNrEMeunM4bI8gMObVwa3A/7PCbk2jkGP8CbmC26FLthzMYn323eHOU6K5LyYTPvcm+1XKS0BYBBKT5M7JHT+6VLwZfJjQZvZDhKOsUE4FEgSxqFPMfq902AsIY2QMBh7NJLlreSE14ag3WPLBpGjqjzc6QGxEFxSA3tamjgioVAmem8qqmTFTGy3QBNeEissX5phAtjZXUOmiTQn3/iEV1zSxHzZ8+luXCNJ2lVY86URGK37j49Y6Lvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0aTpYZBIayAJTU8Q7biEmzV0MnRHl78tQiUE5REJug=; b=XwzIcQs22lq/09k6IcsAamiFq0QkeTlGg9KauX/XbXiGzsjpgqjx3WobaQIUGA4qmPpRoRO8J6oe/jdaXrAKahtGviCnlR4tGAjEbIqEqg3MnrTVGWmsVIr+XBRDtx+RdLtTpJ1HEH5KT51lt3uzALIkSk/r6V/BVXtWtngEqdLiGHa+t3J50PEC6I1SK8Cs4TH8C6bR2adL709Kohx2yIUJ/aqCNTMdiYnLNcoXm4nqsegXJnx4NGOG36h1oPFEjT+kaEwYmfGH7SCxMlFtKLrMEMbg807m7FMMPxkOzgBWii+bnYSBZROVpIfsWBVaFhIA/zH9tXfnPWsk9qvE4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0aTpYZBIayAJTU8Q7biEmzV0MnRHl78tQiUE5REJug=; b=Atxp4oCrksJMQucglq+sh2sgOC2icWLE3N98XrIsRdNBtZ3s5SKxPeac6y5o4J+lK+6gg0t9eHuPrjZ8gNAzsHkHV45qEoy6BC2J9Grhs8mZF67WUteUZdQq0/IAGiEutU3DbS0QhAfy1LbEMc2UXiVlPMpP8WSECzEgSjMOyaY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:23 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:23 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 2/6] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl Date: Wed, 19 Oct 2022 12:38:51 -0400 Message-Id: <20221019163855.1267295-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d430591-4c3f-4db6-34da-08dab1f07a4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +HgJJmusikCG8IIFKKXDYVJlw6fZdsUbwOA0okOwQEcBI7jJmHN0jaFsNykHIdwOE1AxhdztSKrlsBQm+JBVC0r9NvxrK9NBaILGwqBatWn2iKetf/rx3dQpWOvctEW4SHMQtzu7Ymoz9CSJxruhNiDKU7XIpx6iNTDG2AB3FBPUF74umf/NpIBOkJ6bquiGmr3DOHAUvN3cs23cKfkmjjIMGOQW7fjjBGhra8wA8eG7ilOZSwbMUOyvBK/TTNbbLpx+D8GXfqm2rp76k4vZTrgmWTZlzJlqqXVgfVPcEH0ub9W8zqjnVZbvD5xlnmqBMFCv4RDSXStqK4uK4BzhMCvwOqt5LzkX+lN0PqVcKERHntobRYqwJK/+amfyItW1hXKFuP95ptqVqSYBXSYAehm8XulSb3Pv5XY0nrbiivil4l8ZO4Eqmn9GdcgkUDZEkh3ybwpU2JZHw4cXoFMEwpTVL9suZHE58liYr5LLIwnl7LbRi1Rjit91TJ/Ejm9JRAjv46Ka4+1SgU9ApVImPcYI7p9VFUGGAqh/SNYZVd/1tbF+fcK/RJEGSqHfcdyk0RX7kjC/CJ9u4OCzk37sG+WDYj10idN7Yl+bjXNpKWYqdd1FfQj1S3MXKsLMEaJZdpGhiBz+lpQXFRTWGh9YAPOexR9Ik4CwBk7pLPdsyXDJd/NXZGFVGx0KHfcT6ikw1UvmSLEb21kVDUFrY/TyMDZ5zRWiGX40DlpLu9ekxCNGTP78jwbR41Q9HS1wPdLCgEQ2hTAV4/MXEw1B//1KpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(2906002)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K5ujA53XOiRq+zJLCwEED+SgC9EY3l15PKW1Ji/AA1mhw6cRKSZ1nHjfsZQBImg+1o9pJLmAHy2QGgB8QFZKaxrSAAcT20R8eSzFAMQxg8hoFrm20wOGz1Cbc36ykzbl9/La/mxvMmDEo02oiLVWb/u5fMFtgo6zr8xED34SC9Q08tt+KlXkK84BTAFPf7FzYF0ydCRGvraqMTAJ/S0to83CSUBOUicg/6wb6R5+JcqiU8d9ZDXjngvYQaAN0yoWcQIHnKi3PMWFv7Y/Zg+55w/uRHkZQZQ5/cxQmFnwIh8P9Qi99aX5tB9zw7axQnQ15wxUI/VnJyjtdbTDRwab0+IgZ3igJt0n/YXJ9zfLjqPfRwjfA1UJ9II8EG0gFOxkJAQPf92g8tcwjfpKAFPzHulTQ9DVaEUrV+dCgPtoqC9sc7i0Sfg9bhvFftLf0tQ+Xyful+LXHDm07urqjhQKpNvmeo0eYkA29kNa+w0P5ylJ9SB9u0GspNmYvC8jVdZRFJYTGBjTPbxISQdp+EHTtOChe8J1Sel8ZG1QOadmKV8qDMnZcTgMkE/H0bDC/A/ZcQKeja3oog9WzL/NZUCPt8kPNCz6kkN1DKapgt2oTApPUo0O9q28Yv6vjiQVQ1OH33nh+i/nBo2LFBsTv+hZvFffK2ZvScFrs1n4ggZgCIn78CIwIm7NhfGoD0zH3xxB5eRL2qpW1gkvx6cWVbymo76ZfRbN2jbAniNNDef+P35O8mUZr3WcyaZPrkoM6TZkmmokLx5zh2cj8Hjdso0YzjrBVbj08kZWo1IvC61ZlMfDbvaTEsXtb5RwFMKXC8haglK9KYERrgYptyaFvzLZtSifqysRf4JYXjVl0D+Iamja8A6cYN0DoU5D+VJZ2Ay3nwExu0JU8eyqHZdTZK94jkQeAAHb2zHrS5Lq3ZvFZz7EFUyyXRHDlFTlYwp63HI3VAJg7Gg20o8uYdwb+LPE52vlC26yF/fhRohXR6xdkGJhGixIqpidOHkKFjOKLuQhvWpbwHonvRzkU5OLRRWlwWW1cbxsyH8IILkGn5eCe4XfEtFulATaCeg3uKO7NeEjh/jy4Bnb1ampAbvByqCYye/1YEntbDfuwJBCbNEEGy1VVgQu0aNiPyeCM85cGb3wiGV94PxCMKmYgxT11rZgoGfxGNKUOz0r9uKV5bi/2QpfnHbwWkPSkSwZbOkJT782t+FGCBwwY2OxSLH2k63Nt4TsMFZp8Qt+VP/YJnrAiPYfTDICSd1bkxwgaFnbNFrfh4x8/XhCvJBIvTaMOXNKANYnnO6edtcZ4u+8PgUD9U/ijCbFPKADOTqZOeRjoNDdU4Zs4Jj7aovJn2VavWbOMhuLBOVIaqyNQp855I+7VEtxEreZkB+JO8//rb2c0yZ1jw432KQT8ZddostTd9PYuHbmz/mkA7W3cXUHH1AZC9ffYH15jb+tXJkgXJjW//TNi/ERyhQLhrVQ5TkTCecBctmhIK2LBruM8MMEG0hrLLIop61jPnczRD2cK/pvmTpr8C7rYRpj5gMDvoeRxwJXAX++Tpxowt09eGLX1eecgMN9So2sNrYNq0C1xQueYYjK X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d430591-4c3f-4db6-34da-08dab1f07a4d X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:23.1775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fFc5gXs4IwIou2kxBllgar2CZw47a7bTH8AMvAw+PtpMHQVNN6MZy6V7vKUW1vuRvzI/y6FdmCn/LT8U9fwhsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Indentation of the struct epf_ntb_ctrl align with other struct Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index c0115bcb3b5e..1863006cc36c 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -99,20 +99,20 @@ enum epf_ntb_bar { * NTB Driver NTB Driver */ struct epf_ntb_ctrl { - u32 command; - u32 argument; - u16 command_status; - u16 link_status; - u32 topology; - u64 addr; - u64 size; - u32 num_mws; - u32 reserved; - u32 spad_offset; - u32 spad_count; - u32 db_entry_size; - u32 db_data[MAX_DB_COUNT]; - u32 db_offset[MAX_DB_COUNT]; + u32 command; + u32 argument; + u16 command_status; + u16 link_status; + u32 topology; + u64 addr; + u64 size; + u32 num_mws; + u32 reserved; + u32 spad_offset; + u32 spad_count; + u32 db_entry_size; + u32 db_data[MAX_DB_COUNT]; + u32 db_offset[MAX_DB_COUNT]; } __packed; struct epf_ntb { From patchwork Wed Oct 19 16:38:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012168 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82830C433FE for ; Wed, 19 Oct 2022 16:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231489AbiJSQju (ORCPT ); Wed, 19 Oct 2022 12:39:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbiJSQji (ORCPT ); Wed, 19 Oct 2022 12:39:38 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5216F64DF; Wed, 19 Oct 2022 09:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gubS8LUL9I5nDeV8s/PrBEhSBT5MAllUUuDO5X6FjN3xrBbT59Vsc9J3u3EmkVpADA42uItVqWUvhTxc6H2FGeMQWv9Q/yFyE883G3XREC5GzBynk7MdxbZeQfZBztxFlkzVvkylEXWOm/yfeBdhsmvBmfMIytmT2NJ1L6401F2p2zMuGSh7MZu9rY5xNgbKLL9T3YkEc4OH2BNNk0O0x1dyncFBaJiw1nxaB+ARJ/urlImDIa39NEjnntBiKxZyiflC8XxJlJoMxO25jEhdv82j+K6K6Kit22xcyiXfeXDIuxXdeSbM9PW1mpQ2yWHoRS8kgNOCJKrPILTdN6GuUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pyD6aoIjEVUqZqDnSZCuVf6c3XoOXvPwpCEPm4asbEs=; b=BFNi/jxP/5BAgF3DZLJRqXRo2+1LYBuw8CBI7Lp5AU5NzCtzBTlgWiOqGmIPy4Vi3xy3/gF4fKcULAGzDZ34IQYW4piL2nnixOeqY6x8HF0Rzw+KzHmEjDG7qyOMQE+BvZEvSVy6P/HmEc6KNjo9qsRrTOHQsb1iHstjCnAqUrTydO5gFXKRDDerEbtGY2L9Axgj2yqsOFR9QUYBig+QpPM5cmoePqsCbK2EbXUKMiEwqYlzRy7c2L7KMq/85u0O557N/eJrSCCrGCb71xXhaqNvDTjfsv0UifiTaNLA6WhZSszOiVEj8H3q/ocIICuUMd3f8msO7B05uywRrMuLYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pyD6aoIjEVUqZqDnSZCuVf6c3XoOXvPwpCEPm4asbEs=; b=an/Lo6pTgMqakPmrcxXSwoKbcz77vDrQ/HiKq4S0U3ti+s43++UFOQeC7E9ewovUqYedauo2bGrXooVq7CjBxxGegoNsTmsnrEx3Aw/CG6kbeT4M4MXYEb3Hy+nsesK9eSnvIkuQzXtKNYiXopTv1pFw1INDY4/NXffRcrsnz6Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:27 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:27 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 3/6] PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err path Date: Wed, 19 Oct 2022 12:38:52 -0400 Message-Id: <20221019163855.1267295-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: 60e0ecda-74f5-4c4b-8551-08dab1f07c90 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rG1lKt4VJlAuHWeYFWIXTYkgJKJfWL6KcMAJkCQ/e3PS4FLVgVKI5KTQUmz3DlOhAAztwwCM3ezsHTWW1lmgsiylrhSvvsf+4Cjqgz03KzrZpYaAQ1U9o6KNssrvwgue8l/VwqLL+sFNQEvXyYkNomUald2NCSn4J2a9YfscR8SOYDWiBcg5dU0BLkbcihopoAL7LgQaSzQwWKTuYYT6Hu7miEplmJUAfyKejATtwC16ORr+o3+kO5OCd3Itluu1nPbkTuqIbDsWhc5dpvhitusCSWWn01srdG4ARBcfTzsX6fV4fESi9T/0H0kH8YVJo0FClYfYVJ7tC5qYCwGewdafZqH8DsFiCJmFF0BA93xts9u8z0Us6fbETsbPQ89wunNnHQurxMRxZkB+u8ZTx+ruG+leSscnBrm7ChTae+TNZTVJgh2RMh1ULu4Qnx/v6pjo4y8ONbeCQDDqXYy65exDg8PESaFtbbKXTOn15cHnY33SEyjxoKudxLghmE3cgauPkXd51EArYNSX+uybDsvsKiH4W5LKnqiYOvqCNpOD7TdxSlrXI5gD/t0e5uZMPVTBBfuIbeDrCH98jp5OFbtjJxLSmS4lIA73mZFimFUlAywBvKUeOpeHM/oWo9FTJQVoPB67wL+VRdrkfgVFr/oC5re/o3AbeYXr4a7vavSx5Iz64sFctPFIcjQrHZd4Tma2wuKotuqlFm/lTEKNDcTkQq0pxOanw7ly4SShSgZ+npod4h+kOg5K/6SrchcR39gM3csxdjV2vYhV88S4BQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(4744005)(2906002)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hm9w7F13Za4lL42l6MlVy3ARBS3QYuxaneCg0HLyylqWD933WuPvON8/udVrRV6iO4FcVmoqk14w33CBUy7rrwZg5rawgeBtqlXptd4bvrCBmMU7diUlnUBHWDIWKuJQeKpVqOcxC5HwLL2p0MDxO1wHmtZgZFjFBzrbYgN/oDxxuclY1krCXSclIZFg4NTJralpESEsPYcJNRQKPvtRgQTwp4+oda8d4d/ycZg5f0mH5Us+SO7rZT6H6s+mwjZJFLlByD1fcNTipZf3SdaAS8j6Uc4MyXAxTaLAvwdCZGPZNh7OPM0dLDwPf/Zb4VbO+AhGMP2qCxTNMBJyIgumwMEDjHp3aSjDYOu9V/AxPWuquptv6AlWiDNZBuV+4MNQrmfrKjz9RElxWbUONO5G3j6O6Gu7whKZ8p0ARyQvoLX40c4asrYDOB/g6tznyno7AEiuIhAzvCtKxHEbs63EUST9vCM1d1umtz8XIOmopP7zfD4QmKhMzO7IkN/fxqtZQiOAz7JpCTQ3aaLOanswQJglczIVZQHwssCFDQr8KqZy5b0F9vpzJsx/IecXqLZz8vngTG3QTmzKMtJi4cnEKJdc4xfYiUsYyBRBrl4uahmWGcDLYlGZdkhqf8k3p7MUkKZs2R2fSFpxQMFBr7CvLUNoUPGAozuu1q00/AiaSF6Ol9T59bJQl8hC/5htdf4C/D59ZVWtgRG3I4QFTIZspJ/OfnZmnF0MTZwquy8JPPilQPXdRoNdobJD5whPCfV4mWHhqrTUsJOEGZXyXtE9vUkpQznz+12hd4hSAunIu87pDr4mYvd6KyygjCcYMXtp+v/ZMxNonqqga4cJQRIY1PnIzb0EqaoVm2bOYLwF3GfBFAhDtVO0gDrOhQ/VrkfuWbeCDj2lHUM2GEWf9ryyxANG0yEd9ekpUiuz8L6kPLzY865mO3xbUhuPO42HqadtxNcyXJxp37ILL7/VooTSZ5qBAem5LIyQl9b75KmWdTye+s24UuGwfmD3jBuGiWP5f3cZs3oFnN+4+haP/HAd+f6J11S8sTeWRG8hSP8hQKBsitZCsg0g/9TaKBjH/G8AR3PDXbSxpmUtqIKcho61+MKuosoZjuXWPrcZHmDmzQPmfelST+WXM/ofqm/7JSnoCK8S3pO5UKUcSf+Rijr46hpb0zWIxGiq3OTULMriIGgxfjD4KJLsUhd+3bLJBO8r58ZAOhMGXnGA8W7D3t0j36h9pMJ8uuqgqxgnENtcpn+Lonuq1ffbdFgXVfyDZm/0orTHM7cA7enTnGl5pe0molV9h9Msl4zWNaBeGMr7ISDPVab/1MMP29nVNMPbhKszV8mxtJk+wE4qJQPXfC1DVbuN4/APCrlGu37Dn0fxxf30pdtfgcQyN8ieuB27fKynPIbtvavyUhWapHaQ5RioOE6vs2sKx+iviLdsQvRQPMPRTyXvg6CT28k4FOlu3F9Gz1eItMUMU/8lCQhLTSi+U3TVf/3+FgBpYnPGcax/I8lGENDlly0dGW1dXWPWxKNoH2mkmkrwuiBfSVah8flKdyzTUNKDPADXzimlb/1cIWBhNR44RnKmnUY7M5T9gY5x X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60e0ecda-74f5-4c4b-8551-08dab1f07c90 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:27.1459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MFXM8ce7wHC28td4WU2wIJkCKICJIWLoxBKlDjF4K5aDN6v3Ypo7fzDcE43xq6OzXgcIUWHnAqd1qWdjcsMwEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error handle path to match pci_epf_alloc_space(). Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 1863006cc36c..191924a83454 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -571,7 +571,7 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) return ret; err_alloc_peer_mem: - pci_epc_mem_free_addr(ntb->epf->epc, epf_bar->phys_addr, mw_addr, epf_bar->size); + pci_epf_free_space(ntb->epf, mw_addr, barno, 0); return -1; } From patchwork Wed Oct 19 16:38:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012169 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C13C4332F for ; Wed, 19 Oct 2022 16:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbiJSQjz (ORCPT ); Wed, 19 Oct 2022 12:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbiJSQjr (ORCPT ); Wed, 19 Oct 2022 12:39:47 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EDD2286DC; Wed, 19 Oct 2022 09:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRTC21/y+FZcWfYAo6CNKbdR/jimbZMgBUnNi+0bzvb9U+X007+sjFx7OqazIhGsmpjxeRH7Tsz+5ClOxAfhBziL5fej/t+YJ7AP2BE41YqPHcyGHgzm0h9Ge+d4GFz2BKqXf/N5AA6OPPISXB0BbyT3Fs7s558oLm5uG9T3EPrGWHf8WairoDA4otIfqbFFxXThgjRwkOIXAFvMubpuC6MOmp0mo+htcPnmVmVuFHY0bCtwi8Wuf6WrSIraUiEvL7QkExioS7iiCsrtXTD/pOqHkW4BXjAzznn7ZOTRnswfj6eqXXlRaLQXOu5WarOqv/dq17WZK5hyzM0xbFrabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QfqKjmRXfkbqfS71fsocR7ajWkM3hp3bLrQF/zSSm4k=; b=juHcSyYHnmzzZ9DPFdworlvMJz4zG2Ei9tCsXz6mHNr6vM4frPKT6MP4K2BTL0Owf4FANoNK0pwCOH32mQ4aZyPz9bDoY84m9xRqIa0Y1Yeq/yGjdsMGl0Ln7iZSIrAl83IvYroQRQf05GFNrNtmvoh8vQ5WbqbyTl2+snOD6h4mSqKr2Fvam9AbzdE+V+4MZdMRHDmsy/PO1BkSowi/yFNTq9qiLTIJJqot4rGWVeu103fSgtMD9y4Xq3h/hSUf2FCPOCQfU6rn+EDDd67BXV260TXIX9xyxuTYojuNQTSRigyw4gqlcThgcfTtjs4Y9VENpFA/aVaexdxGifHfsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QfqKjmRXfkbqfS71fsocR7ajWkM3hp3bLrQF/zSSm4k=; b=b8NuZqbsFLU53SXfr0nDxZbH//Bsn7E6B7AbN85WFZJ6kACAOzOTZyOaFHBiyngL6+QcaYEXhAlZN2JyaQmCjmrb5jUw/Rs0M7qhOowV8hMg39kpBb8ieodzWXA68kpsFMEwGouCd7AX+HVIpzumzqwsdL+Wq/kHLwIfX/637tA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:31 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:31 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 4/6] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy Date: Wed, 19 Oct 2022 12:38:53 -0400 Message-Id: <20221019163855.1267295-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: c63729df-7257-42f2-0f27-08dab1f07eee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sgMSH1j/Oe4RCIHZ1QGhpddxvLwO9cm+0Yd3FRoS7ZKqJZuD2hKu0HiTUNnQs7+pxIyUmLeKyai/jdiG90n19jrRrHCAIHA9sMa+tzTcF0TsNorqR6fJzH45Oh/t5e1fw7uBKJhUOHKV1qDG4BaMJt1nR3LndYuH99RSH5inHQM9GWzs1l04ezFaV+1I4XzmwV00xa2Xut96uCr9QfUMvi9P7bbfjTU67Yo+mJ9kSETJzu9kefgnSvfO004HOtSP9Y3qqpwqPwEZFO6YvCFShKwr6CxdUm+BagXKbLk2SW/ylxhQ87ZHibjKet8unIZibROyeuwjinnV31c8mrlpI4yE7ageiEwKJB1DSp92bb2RLzH0jymYvF6Zqe9qORkZa0fyW6TgFPMiAA5h1oIyOpn1gJXNRA5xH23FteXkbi2TP852BYQXBR6gZKv4NMOjN2awsq33A/WoOHduRW7eVRrJ47K8sYqe3mV7vdlRUI5Ga2X5DgZZV5O49v91JmRzHvbwteigWKx8Vh+5bUHHwXV8+/s9S0KTMq1oJl3X57+UG64DgEJs7zgva2dXYkJBzXpUzaGK3ub3Wf5UR2P0XPcw+qYnlk8Z+uUhMEKb+Ldz2T6cqU0a4uYO3Cc6Od2Sp6Z+0Khno/pwv1WaW4ZxuliWM7rCQpYMA0d6WLcDUe3DvzSyOIomowCiAk/f6BRQ8cEkakX50A1qbQ5qH2gxeKUFA4OsQ6Z84vWbTrSsHA2gKkzXkUVhmYpta7T/HGm/F8uBdCduyGi+EqFPh92cfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(4744005)(2906002)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sjSclDhTOLByVRpjF81CLV2eMGrAPaHxWDp2SxGFB23CxII3elXx4MMd/w6Tt9n5Dv91DahGsoMpyCRFjYvxcGmkZ768PN/PbCk4UjaPDKsSa+TxhCLc3odmdpdRq/V4tCVUnTBuItzficLqU962GYQ0bztLJITUC0PYmnALXivZacNNHt5hpmCmmQEPBC0uppioYB+1MErxfrT7HRpeJMlzzIVIatvLlFEwf+RrSPI5jt/YS3OQ1LiNAJU8bsFTna2Z1aJ9h/88Ep9wfGJ/S1i7GFDbRheX3F9hDak49m+HLpNdkFN0sfUzwHdpXPMs1WZS6Y1pkgT1lTgeZ7LPnPQxIXKKjM7MWzvgsDKT9GRxlakskuWnKt8iJO6h5MkNoge7D5YSsaRZxEaf0X7rlsWAiKNCCW5hKUjtNg09Ah0azAcWsZQw5q54nKL3ox6E12H64x6dcnNRO4dXZ4Oufkm0tZfMPlSFah87g5uMnJwUe5NEesoZubswnh1jj1zLSc5vE/lBiD6zadDEgb+OAykG59KL7rmup51e7H+UCzkkCiA5ujSoVcYq8rsORc01Ukv5K3FzCnHRY0LB9GsVH5QIaOBxCTJxJojiajRS/B/K9BkYrkcSDNpNqLHEhwAS2qR4f6uiqQ2ne8mL1+7qNB/JAIYZVpjDOsJtT+ij5R55qWWqHS2yonO7a1IoPaw+gtUJy2LQPJeSle05od5DomckQIWtPElnJ1/t9mTL3+p4ZXb1vMRy+jJ8nXl1kgTa0+KwW4ty0SuW2KvqgPh0Ekc0wfayCTvhqB4260aKDxkqy0oSEx4igzs+g1mnMXjhsdRolC5J+0Lcy6+GDkYYix0MDL+ETBLZUU9PlpDRk6a2vyh3uB4Ris2pXDhaF3wWtxxZb+F+hBufMBivVVWZHTAWlCf1p2/CGphiNRBXH0ZY8CD6QMeaxfo5aRvywIW8S2/qQ1EFWBkcRioYRK5ZtZcJCE3TQd6L03jBbOJ4NpmGv9IAvYEjC3mTtlVLkgWqjZsMy/oj6cKEA75NmMQpU301g+gFzTRFfCdiSt/UgNfdGlSTYaiSh0iA5xVYAi2K79N1QsomUDmss+PP2jRRw0mPrc8y1xe7sVPQe+QKNM6++OT44R+4LU4+dEZwbAXZ9O0/Z2D3LrJM9d5EW8NCVXokeXy37SvEnd0T00wtpIT/XIvTtuoN1CE43KrPhqixqkbaAPuoMBaKii/QvC08IFEhpepRexYxuG+jPVrHuk1PKp27W69B90Fr19XqZPvL13lr/dkNRe2ssm5PCanBS0NNXdzsXCP++EhBI/lczyxb3GnaEnC3/TgSsMDtMvWCniWoORoBExYPT8jThmIHee8d+qLtLBNhwzqW6mVvEp01A0RaiRVOI8Bvj5xXAhGcEysEz/hsCxij/SKrMLeNBy1szIC8HG5A+QMr/8QzBUe9UoSUtnstI+QXDy0+CaCUI8wPLrhPH3FWEdsnBCVLRNqPWe10tHTWxrYNBVZgTjNcq26qZ0+onoqiPi9IdIyaX/7O7y+WQi1WR+nkbDSC01CipeT/P96VptrEK/1sZMdscY77tOlqwUb7tgejMJG+ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c63729df-7257-42f2-0f27-08dab1f07eee X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:30.9425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JohXJEyXz2YbeGxo38HPi0V+UwFS4xuAGTyJ98CmH2V95x387H1IJxyUb/R5RVDs+62HfvgNJ8Pvdf5KbluZ2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li None use epf_db_phy and remove it. Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 191924a83454..ee66101cb5c4 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -136,7 +136,6 @@ struct epf_ntb { struct epf_ntb_ctrl *reg; - phys_addr_t epf_db_phy; void __iomem *epf_db; phys_addr_t vpci_mw_phy[MAX_MW]; From patchwork Wed Oct 19 16:38:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012170 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4F5C4332F for ; Wed, 19 Oct 2022 16:40:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231583AbiJSQkK (ORCPT ); Wed, 19 Oct 2022 12:40:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbiJSQjw (ORCPT ); Wed, 19 Oct 2022 12:39:52 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31DA644CFC; Wed, 19 Oct 2022 09:39:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HsKGKEzJA6Q2eKc6TWNhD6u3hpXl7BZxvMCUvj+uJK6r8sx1zE3ldNPGqwgOGAoQCgQ51FajMlpT06eMPq5FFCxzrQxAWwsURIms4VOWcZXzRXV6k6CmxPmUE9vRwuP2p/XYCKjmnRW1E+iJexj8gOdsQjCJTMrIaG5iiS+wfE6VXHcdExN3S9AdpI9tOvWnOfkaM0+FHtg5wk/PSfIPywxfQCTHd60aF0snAO4vYEZGMPkvzf8qw+8snZ7VvyYLlwRGL65VZ6lCWfeG3eX+RrtPvqp30ZH8GyDZRAOZ1EtAdbbC0k4GCEPrOGN2OPlTQMeFBMYyv7ZdYNlUQRfJBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7rFAgLLE8DgxLzFxypT6h/aMZ7/AGzWG+1ThOcYzlQ=; b=j/KcR7lgvw7uSZfg17HEQmqJxH5uHPJ1OkkKz7bB+SLHOVGiILiw4stQ+lUFqeVG0oQl6MjVq+fU75fJGcExW6INRZXdQBGtTwJtbj9YydOK/BgxQeFSL7o/DsS/vjJrXCVvlvmACEtS7LE/t6BV5oEZMm4sMR9DLcwL7rg3setaaLHr/YFvpAToKSb2r3zFQp90Enurv50WBJH5VTWe9wARESOTlSNN9v6Eiw0dXS5ghnJO12l9NADx0KTLjFA8rLEWfUJ/9YAXODpD4CCCTqr4u8pWnubfjwWGtwG8D6f1Kiwmt7lmldG9/u4pxOR+2xuiZblQze/CXgPmzgZHwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7rFAgLLE8DgxLzFxypT6h/aMZ7/AGzWG+1ThOcYzlQ=; b=FmBU7lwn3WzMp3PMB1+OhuA+SYl5E4GJry+oPizOyK65fHa5mFFgDR0uQJRz9xZMq8ukxpvgA4uHCmPxmfLGjuhxfLkmAxGrF3Q8b2NHEdhNufv1CEd1y1Lc8mRPDpPDe48PR/8vF8VZkWjQ/ghLPEN7fuNHf5SvzPRMCUBhdyY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:35 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:35 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 5/6] PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32) Date: Wed, 19 Oct 2022 12:38:54 -0400 Message-Id: <20221019163855.1267295-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: 3593101f-bbfc-4c01-7015-08dab1f08163 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k7z5cfWn2SiEGNpRQt6O09fB+x1EdRxwGxGo9bSQOH6srFMhB78Tqc9l9j4Jql52mVmWXs1dfra+lZlKPygjKeAcEnQ7lx4ki4tWq5O+YSDL1N/7+4r0isfXf2zKQa5qpLghkiHNScdNxijO6UQd79AvpvTSaBNIeZB5gKidWL32SrTNsnzmj5ZrnaSaBdBjTbGNNZ3o4+U+d/eBJ7FZXHjiyUApEr2Y1neOwlJ9Id9FkslF2IxGTpodb7gkfjSz6hA6wlcjK70KHGj9maE9/bhC7tQuNJRL0CJEzO/Bvj8M1y347AzZx8ttJ0fKBPA6p8a9Z5tLYG9QHPGcQJ//FLdNO8/Jev9vxLhpRHiRCM90uBLt1qJJBMFMrgdBqmvG206sjTt79J3j7SuidOO8IQZPFnwakfY8rqm/qeARB2XJp9NBGziR6DKsNwa3o+G5HKS/YcF5WINj/sCdIbCqAn6Fktw72T0NPIFnEI2v/GIqqU0KRz/EelvrrU1fi+XSj7F9YVAMSw37wSDwZv8AjhI7ywjPtSYQ2/K4k6KrJvgBh4OL6ySl1dWkYaGyHj3PhDRbkaJ9+dH53VAuVYOzRRN7vwQ0nTjMcX2VUu0NyIkANlbGdpNl5g/6aB8fAdYXfDzrqQ2XlpGT5Su/mEjLa73jCOCNNDzCMT2XXsKjPXHVWLk0ssFNJCZ8v//qj/Sq9Ub4eAWFxioZ9Y7GYcthP7cHO7iSnF3oCD3PKy9fLmtnUMbC8xu99dm/wQMrtC9w/h/knZHCc3ngrbtEKrvzQw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(2906002)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9o8bQstFY1AouBbWyDjroctxVf8IckShTpqYA83aAAiipK3IGfpn0USk/zU0atYcE6icIbyClTrmGJ+0eVregQnaPktxyTjqJatz7EL7daoqhFece/7WS2YeiL00nD8O7n72V8BbIOIGLtz4u9FlVHkylv2xQDaGp7LshAabVS4Sa1LhwI4DeMDuQC/rAKUp21zQ1aepk6whibkk36+WqrCXUSrlKmrdVqg5TdhFGkZbA1yVpUZHCpKHecRWmWoX9h4GtlQaMvzxGd4qYdNJOBMBTOx6pnefqioNXJQMghOoAKH9/LyJslCdSkTn3lsPz1uEKg601vCqBMhlyNjlKAsZK/mPQA7A5PuZPRyG95kS4Z8hao84nF8rWHihIPtldle169qEU91Oxcf4BTuOwvrA7cDo9PM0wVgF2c/tecI42SGa7DcrKgWCaYJ1a947c+KyLbPFQT1xhkLvVmJSwXRCqo5McrANtcFBTiyEfO8gGPFrCsoebN3mOJv1xI0deEAsKzP795wVhnxnxjUADuTNd82L89mYNlDIZwrV4U1kPUuL/Pe6PRaz94DjJsLYKriBIYk87NMIsT23E1Jd4AfBzpuvd7bLpHnf3EApo6vR+t452oMh82P4arAcIR9cy67Y4Q/MXEbojRKpCeMUK5lq1wYwGW4vRmn0zfbAcdyi0LI3Qk2lr2HVIp7m7U43LPPLCLzKvMMsba2uEfg+hClc5rSy2oHoUd4zZBuaF9TEJWodPgKOlxjMAoPzpvXXsEMAGn5M++uZx9bU57XwfeX6uce9ytTHKFhkJ1+lF6mTLbtSu8/3iV5kot6mNxBlELxRxmwqw/NWt531v1h/yWo8bi30ltIQtHbn9kgkSFNUQJUTU3WDWXSnhQqxyfWHs6cpDiLgUEPLTsm429su3kQZbsjoyO00VPVzE6ZdTuNrbBy/zyhvjmaxC1vzjO4B+/UlnSVNRHpV3im5HPHNJvghihR0uDlY30WBwsS98CVttfOfHHV/yjY0SoaseQ0lDPACT4kmh3ndimJJ1fwpQ5nDAtZifDBIn16xUG8Q/a8Gbg7c4DCc0qrYr7MtNM1iinH4JDAJ9Mr9WPPzM7qu9uqLfoOzbcUlh1MjLKZ80zmSgS07wr1eVRhXbSQ+STfuD2uMN96AnlbSPzRLDmnUwwQT17VUvAd3bf3VYwF51kqoN4NgH4GcgIYs/YSpJS4H0JLtI3ENxQsCfJspNskPXp6QKF/QpcogRqM/AHEHskS27mNmedPxPPJCxQ3u7XlekwsaGNVoBC/mbjezF/LdaNTwncOoFx02mc1BxJ52Euv4BQzfiDgD7l1Af0hCvozp9SIgXgNQrhIa5XIjQzIALHgOO0hbqnl5BpWydR0kq1mfJnVaFP5LaegfOIm2EeMM9+FmuHuetPOhMLg8LAu2akgHOpvaVitNkf/VmWczACWU0Kwk+lkkse8fwnN0apiZEVRT6iWxm4LeVN9X5MRTakbowg/gymKslUgLvQgJdqqciBynlXMIwKkPEQ5Aun5/e9KqUbngT0mgawTorR8mHiwUc7Q7gQ4V0aBhoY6HS9Gpsazi6mDNv7XNv7Umao6W X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3593101f-bbfc-4c01-7015-08dab1f08163 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:34.9422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w5eTtPnRjx1T3fqmmZYV4iRdq9q4J/ncVpTUxuWwnoKwH8Q3ZLjJlZZDCx6tnuk0EpNzKvR72nJ3uXdRVfkUmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li ntb span entry item size is sizeof(u32). Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index ee66101cb5c4..54616281da9e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -257,12 +257,12 @@ static void epf_ntb_cmd_handler(struct work_struct *work) ntb = container_of(work, struct epf_ntb, cmd_handler.work); for (i = 1; i < ntb->db_count; i++) { - if (readl(ntb->epf_db + i * 4)) { - if (readl(ntb->epf_db + i * 4)) + if (readl(ntb->epf_db + i * sizeof(u32))) { + if (readl(ntb->epf_db + i * sizeof(u32))) ntb->db |= 1 << (i - 1); ntb_db_event(&ntb->ntb, i); - writel(0, ntb->epf_db + i * 4); + writel(0, ntb->epf_db + i * sizeof(u32)); } } @@ -433,7 +433,7 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) spad_count = ntb->spad_count; ctrl_size = sizeof(struct epf_ntb_ctrl); - spad_size = 2 * spad_count * 4; + spad_size = 2 * spad_count * sizeof(u32); if (!align) { ctrl_size = roundup_pow_of_two(ctrl_size); @@ -463,7 +463,7 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) ctrl->num_mws = ntb->num_mws; ntb->spad_size = spad_size; - ctrl->db_entry_size = 4; + ctrl->db_entry_size = sizeof(u32); for (i = 0; i < ntb->db_count; i++) { ntb->reg->db_data[i] = 1 + i; @@ -535,7 +535,7 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) struct pci_epf_bar *epf_bar; void __iomem *mw_addr; enum pci_barno barno; - size_t size = 4 * ntb->db_count; + size_t size = sizeof(u32) * ntb->db_count; epc_features = pci_epc_get_features(ntb->epf->epc, ntb->epf->func_no, @@ -1121,11 +1121,11 @@ static int vntb_epf_link_enable(struct ntb_dev *ntb, static u32 vntb_epf_spad_read(struct ntb_dev *ndev, int idx) { struct epf_ntb *ntb = ntb_ndev(ndev); - int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * 4; + int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * sizeof(u32); u32 val; void __iomem *base = ntb->reg; - val = readl(base + off + ct + idx * 4); + val = readl(base + off + ct + idx * sizeof(u32)); return val; } @@ -1133,10 +1133,10 @@ static int vntb_epf_spad_write(struct ntb_dev *ndev, int idx, u32 val) { struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; - int off = ctrl->spad_offset, ct = ctrl->spad_count * 4; + int off = ctrl->spad_offset, ct = ctrl->spad_count * sizeof(u32); void __iomem *base = ntb->reg; - writel(val, base + off + ct + idx * 4); + writel(val, base + off + ct + idx * sizeof(u32)); return 0; } @@ -1148,7 +1148,7 @@ static u32 vntb_epf_peer_spad_read(struct ntb_dev *ndev, int pidx, int idx) void __iomem *base = ntb->reg; u32 val; - val = readl(base + off + idx * 4); + val = readl(base + off + idx * sizeof(u32)); return val; } @@ -1159,7 +1159,7 @@ static int vntb_epf_peer_spad_write(struct ntb_dev *ndev, int pidx, int idx, u32 int off = ctrl->spad_offset; void __iomem *base = ntb->reg; - writel(val, base + off + idx * 4); + writel(val, base + off + idx * sizeof(u32)); return 0; } From patchwork Wed Oct 19 16:38:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13012171 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E8EC433FE for ; Wed, 19 Oct 2022 16:40:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbiJSQkW (ORCPT ); Wed, 19 Oct 2022 12:40:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbiJSQj6 (ORCPT ); Wed, 19 Oct 2022 12:39:58 -0400 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2072.outbound.protection.outlook.com [40.107.22.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17F1F937BD; Wed, 19 Oct 2022 09:39:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P5R2CWkUbONfEC82y5KBksiLFZVv9Gin4ZHEXpnk8xVXHjB0S4mbMxTqATSoBNiFQa7QdfGdrXgJ3hJWwl2uxwTB+zrT3+kQZYitzPMFK80+7rXKNhWphqFbjFvJWx3Q+n8Jf/qmue78Sn/DRLxhZaUjR2vtHTOshWDdEhQKJTj1EiOZfeeWn61l+IUDArH0wj6K23pebivCytWUoErzSaxD+4FVtFg+m8bG86ziQ09kTtnsXT1jSV8/OrU+JhaqQxQSwl9wITPJApdDAi3wlYNYfmkmQtp5r6o+6EHobtTk5XZlBKUmFyXgd6EdqI6qJOkz65JWYiA9pm91XSROHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AF6juBIUfEb+5nX+4ySQMH0fMffTYAz1usWWEhHb174=; b=Nft1RDJ+UisH3JQKtXuc/FpA1Wcxybf5ZOzWGxxLnChNfYdR61YydBxJ0ywlfuiz+03ie9hL82zpp+mLYDu8cU2v7/wR2I68xFYN1xpJm/Itfe0X7RQFrOF08l0TuV9Hsd+W71vv1x8AnCY5HyDezTMbTOAOaXbcQCQnomlMbu72+XRUmmokzCTB58gFTIoTaN8rFipu64GAoMa+XeR8EdSd3ToIMAPt7sns7I8nOKx1FlGIgRIPyNp9dCTn/Wi4UBcfwXardp9eOJ7IsupL6NwgqL5X05Nx/2uQuF8XJEoI8GOwBGJvAkZhIBjiO9Jy7CpyYk/HjCEr0r2fZiTFjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AF6juBIUfEb+5nX+4ySQMH0fMffTYAz1usWWEhHb174=; b=MUScSGFY0HQcbo2RSTWpd+CtJiVr2clgHfxk1LMyxABoaooigctlZJQSqpd/fMnMr77gnNiYBVVO1HGyGWrc2mWnCYJbwz6XowQDlIkjFqm1mwCdRtoio8c8LiAM1bQZ9q+0NWKQJazr+wRYBd01KYwpWEYcQZCQNLgrJLpKlzk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DBAPR04MB7318.eurprd04.prod.outlook.com (2603:10a6:10:1ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 16:39:38 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::6110:8304:5648:88f5%10]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 16:39:38 +0000 From: Frank Li To: helgaas@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, mani@kernel.org, ntb@lists.linux.dev Subject: [RESENT PATCH v13 6/6] PCI: endpoint: pci-epf-vntb: fix sparse build warning Date: Wed, 19 Oct 2022 12:38:55 -0400 Message-Id: <20221019163855.1267295-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221019163855.1267295-1-Frank.Li@nxp.com> References: <20221019163855.1267295-1-Frank.Li@nxp.com> X-ClientProxiedBy: SJ0PR03CA0352.namprd03.prod.outlook.com (2603:10b6:a03:39c::27) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DBAPR04MB7318:EE_ X-MS-Office365-Filtering-Correlation-Id: ea78c336-4a2e-47b9-105e-08dab1f08396 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nHvwUC9ANFqclWnICAlOaz13nRvRwsrO3zGL+ieWAN2hyjB4DTSwRBS6VvNwNmD6MLXSrH3aV8oj9pdZCrmPBFSYrZtP8zDb0kJ58vJhp9nN6WYH4KnxrteOGzbP1uA+7fcfHqpaHrQ1CLiAACtfqVxpE4mz31nTsg9t2Mnvzcagxpi64oRxa0YtwdACPoUgmy3E4D10gVgTUFt1ljNojYbuwKfRYAcilZrg6wAdlyUHDXTwQRCO5gEvnluNtKVaRt79/QSyuukcEAQzEcyn83yOSeZtLT2LI72bHBgacWw2qej3WrYjPfMgwVn9MTQJTQvFhGg+L0abb3SpEmeAHOVTWE3Wf7sS8OzMTQ8yztmV1JG7L0p37tel0L3c/EBYMhI+1F8UrQccZhxvivjNfGghB0IC9Q+mWNq9FbaTbHJO5bswmww6oA41m1klsyYNzkSuISo6k7HkxrAVel8w8aj0soZ/Stkcq+0IpRUChZ8vP0vPBxepBLe3kttWN+vxpzL9POSR7WyGZdwZlnY974dNzOpWOISgO0ZTeegNEMF6vfnBHg4Wq5OtsfV8ceoYUJuo/jq7PEFAUR3oSM11o1czV0T5ekyEdqkOnu4iFWdChUlx2YeOOb2tSruaDJERyD7DLK76mwbWBKiXixAz+3g85pusiTX0XEj2U0b7qRPb3729oDbFzXoJOYUokL8Dd6ZelJiMadwzg8RN6lUSKIhaEAmeJD/noPusLaVaHZz/zOtDrv4WexnuJncv7nMW0Mr1DwLTIPB14cCVT1Unyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199015)(41300700001)(5660300002)(8936002)(2906002)(26005)(316002)(66946007)(7416002)(6916009)(4326008)(8676002)(38100700002)(66556008)(66476007)(83380400001)(38350700002)(6666004)(52116002)(86362001)(6486002)(6506007)(478600001)(6512007)(186003)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ut79OYt8KocfJOJkuP61HyKzkvqSAPXWOYtmFCq4++cs7pa+/0sNAw1ZRFDWtoAyZ29RXI7Na255bdTmTxpyEHt2pV1MqXtVZ5J9N5bKUQ7GLlIVgoEBVrV2xLLVfu3UyVSq1G4d5sc6gV8E4gxtBVOWEb8a/P/gGolNShj3tre75EUCmGPrPK+HNfluRiUySa6VB2MS9Byh7H8BvLr4P46VF2hzgx0VAIyn5tevK21GjJajFtKr8IMpRYtNYYkj7S8m5bKhSh7zSCYpihIFNjqhj6iGYMwwAIgJijb6h4IYEnnqfOEdbmGaA7pf4AE3TXQiwonywC0PgizveQKDfRAADdhWY3r8CDf/rQZynliVAPxJ2tYh7XnYFuCvXhV/wJPf+Z5+VGJaI9X1V5YQONJgzOybWZ02IVum8fA6NWOeYgT85bXHDmtQHc5bFdfYMf6ukGCa1VUw/jTUK4zng8A5GpfA65sWubstj8EdxNBnqoQsEyaUeC/RysjY0pfQSaC3+HiZUD6GCQVl05HrGO3FoSbfutY6eGZL4A8hYOwcIXHw1o+f+uc9Gfp7tDQM5x1wEmQGsDhKaxlbhPP9X2oAgOh+Jc2a9ApYATfF4fLJy672Eb5W6+UCuN+IfjbibkstCBbr7uIJCWqsp1+EZ4ZI00+knWjXbFdyu3txzgnnx/2FGjwsyjfucpY28Jju4nmyZziGv9fLIFAp1rodLDtR4G7AEkdDD7PlE399oG37cxZA9U6M1jEarAY0VoMRwiRwrDHl7TzPbOFP5hZpj7vraYzQeUCXAPJ1xCRucbv1CZtMvSiK6W7P8F+pjBINnYIDTEF9sfcqaMEwkP89pCcQF0YMfoTOz7nFBy73Egf7a26hyfkINGzEs/9rUPgZtgsAtCHGcMuHkv9MvaxknJ9cNlyUl3+uGSZbevuqCSLeZrZwdIfz9fUQpgEab+JJF8BHKk37zpGb0nhE9Tct0Ls1+9z/OTP7I4Xk78jt75FAA9UxzIoBivD3JLtmIRkwF0krtMNUxf/ntMwXz/vBTADQaDW5BpomNoMlNjCBj2c/f4ZnVD8Y4Y918QeiApCmuAaP380tRh8rpapRsZ2tXt90N1u7Sn7Qs3Hv8BaMfFOkNBpCbINQ7yVdDJbD8nhQ9bOYguWOTLmRC/bf+kGx3ocHZ2bpgtZovmYkiIerbAQ19I4QRzg/Gpmv7I+LkBtbUBtgxDBnGqAAhZtK5iLMUOZ1l+uq1S5sJgdy9oHsHqwfY6fC9gOBNql7TdWuYfXQpyIP6IU8X1caCaPfmNFeAGnDcR0vmQQczS5+m/bZ+jxxOQW7PVgrJX3PJd50eVY/FAHHVRkgz9i1r5TSLYZcBTss83jBxyKZCzyVfChsebnRimYYqCHeE98Qu29IQHkl8/n7NppwbpQxEcO8etYatP/c2MTit8KZB+K9qZmexVhv7ZIr6gE6RUY+qL9IsFuMniq6ddRvxmpbkdXfAoBXjFtMETuAV+HM4xUO0LIQPiW+LpNbbpLGv4dD85pWPcsdJOyrKBphg9xCVxqx2fmF5DEGGBiVpKJCK5KwUCRHFIJCzdteKznQsJ4IoCPVHFNz X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea78c336-4a2e-47b9-105e-08dab1f08396 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 16:39:38.6138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7i9x2lYkG79TYZpgJnojePYeniz7g4tNQs3YxuTHC9wOu381KVQTDW+n5aNT6Q0GYgOtibFWG3Cv5v/xGpK1yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7318 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Using epf_db[i] instead of readl() because epf_db is located in local memory and allocated by dma_alloc_coherent(). Sparse build warning when there are not __iomem at readl(). Added __iomem force type convert in vntb_epf_peer_spad_read\write() and vntb_epf_spad_read\write(). This require strong order at read and write. Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 54616281da9e..9f1ec6788e51 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -136,7 +136,7 @@ struct epf_ntb { struct epf_ntb_ctrl *reg; - void __iomem *epf_db; + u32 *epf_db; phys_addr_t vpci_mw_phy[MAX_MW]; void __iomem *vpci_mw_addr[MAX_MW]; @@ -257,12 +257,9 @@ static void epf_ntb_cmd_handler(struct work_struct *work) ntb = container_of(work, struct epf_ntb, cmd_handler.work); for (i = 1; i < ntb->db_count; i++) { - if (readl(ntb->epf_db + i * sizeof(u32))) { - if (readl(ntb->epf_db + i * sizeof(u32))) - ntb->db |= 1 << (i - 1); - + if (ntb->epf_db[i]) { ntb_db_event(&ntb->ntb, i); - writel(0, ntb->epf_db + i * sizeof(u32)); + ntb->epf_db[i] = 0; } } @@ -529,13 +526,15 @@ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) static int epf_ntb_db_bar_init(struct epf_ntb *ntb) { const struct pci_epc_features *epc_features; - u32 align; struct device *dev = &ntb->epf->dev; - int ret; struct pci_epf_bar *epf_bar; - void __iomem *mw_addr; enum pci_barno barno; - size_t size = sizeof(u32) * ntb->db_count; + void *mw_addr; + size_t size; + u32 align; + int ret; + + size = sizeof(u32) * ntb->db_count; epc_features = pci_epc_get_features(ntb->epf->epc, ntb->epf->func_no, @@ -1123,7 +1122,7 @@ static u32 vntb_epf_spad_read(struct ntb_dev *ndev, int idx) struct epf_ntb *ntb = ntb_ndev(ndev); int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * sizeof(u32); u32 val; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; val = readl(base + off + ct + idx * sizeof(u32)); return val; @@ -1134,7 +1133,7 @@ static int vntb_epf_spad_write(struct ntb_dev *ndev, int idx, u32 val) struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset, ct = ctrl->spad_count * sizeof(u32); - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; writel(val, base + off + ct + idx * sizeof(u32)); return 0; @@ -1145,7 +1144,7 @@ static u32 vntb_epf_peer_spad_read(struct ntb_dev *ndev, int pidx, int idx) struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; u32 val; val = readl(base + off + idx * sizeof(u32)); @@ -1157,7 +1156,7 @@ static int vntb_epf_peer_spad_write(struct ntb_dev *ndev, int pidx, int idx, u32 struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; writel(val, base + off + idx * sizeof(u32)); return 0;