From patchwork Tue Nov 1 16:57:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027231 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6507BC433FE for ; Tue, 1 Nov 2022 16:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231210AbiKAQ5q (ORCPT ); Tue, 1 Nov 2022 12:57:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbiKAQ5i (ORCPT ); Tue, 1 Nov 2022 12:57:38 -0400 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2064.outbound.protection.outlook.com [40.107.105.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53ACE1D0FE; Tue, 1 Nov 2022 09:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9/jhFkdfN0Coz+HyHCYna693Y9bQgIfN+7WWiV0G3jiZzxB+f5ksAgJ5SKpRHhvHSICdOA3KxP1FXc0WJoWB6dhGjp7jrlArkYCwBJrKZADJoZgt/lHvtF4CM9SH9Ozynx/yCrhp+dSw+5jUc8fDdaM/UvCB7hfWn5cWA1yPrwO5DSQWRvrZpRgmZb1wMWCuv2wtqw0mdUHCuM/hE4JA842LeEinnVlr//ZdRwLoOzQMdkbaAYWxK3aDzGPPC+RcEB1b4gzmkU82KF200QDqTzaNqFMWDv293i+ERjgpWu5TTDrsl9uIwH1SeRvTQ81YR6IJB+LdiKc4b9jh8ZJUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+crJ9i3nm+wkdGC5mvPCy8uw2cmvfs1NDX++obGypGU=; b=McKMVRAgEEGDVYT6xKaCTADk9SGLGHWH/ADu9VE3swx7uFl+WvZE/o8sG+jJOQF3Lrs6DjLR1IwuNH6aymWwXD7GFjF+N1TTgM+qyvMKavHw1y/BH9+Ama24HccIGpOwG6CZbmxNy9nn8U219urvhKrgLo4t1KvMHS78U8ddqesWKvFPzLFfSvBrDGyB0GiHxDnCtWxtpDdyZmJJpV/PDqGqSLvLdBRcSjlnxeqcHOVeeJnu/x6EcDyEUooD6u/JCbw6H5btEfRdB4m104wRX+e3ZkKe30nfV394HQSL4D8sPTdbzUz6o8M8tpmA+xqHOLAheOtYvtKoZwn5F/Ui2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+crJ9i3nm+wkdGC5mvPCy8uw2cmvfs1NDX++obGypGU=; b=Jm//ar+uV2UDg9Beb9+FoczSP2k1YaVW+TcT0wlnnHOubqMeszu0AQFU2ZZet4Gr7iDDuSDTBimZzBadwCADbxD+ybX3KizhfLejPnt7jMcqOj7vUKwHjnJL8CoH57xXLdKJ2/RPp+tAIXRbegcxmAGn474IErgKgz6eFfcoc5g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:33 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:33 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 1/7] PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning Date: Tue, 1 Nov 2022 12:57:03 -0400 Message-Id: <20221101165709.983416-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: ad82594e-37e5-4aeb-e4d9-08dabc2a2b8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eWLnvOXilnBvDNUMP7ESM906YFXHoDZYhIMV26mvvQEQ7ESxHTt50QG2lJD4LE/bvpo0F1oGblOJf7F+JHxzM0WEroOMXn47INys4Roh3LoE0YyOenRjmgO7xKJcMZbQwVXJ+oM2GQ+8VAN8a0X09jgYI4g8AJVXlDe5fdO7BxrGpQUABmqQbEg4tem2iRyE8SyITu7QiWJ8nLMy3UKuD8pF5gbty+ZSsMdilR8Yze9G/OZ2FC+kiz32maMatCIQ+q9qVxPQMRaQJFlNmBB2xwyJM7eLjYI23L6x4Bs6MfaOYb4pDpWDIxTYIhQh/1nl91ciDdXkwkQzAKWLaJGaQIgSWOltTEqRI+abDCPXAeWhxawAUbwpWVU31KjtcCMbz6oSP9dEiA5sJNXBk63mrH8zWb6X8jOFNuGSOQWjQAw7FgwhUmrpOgBLLH0htzUrqnVWMDmMcTPFt5Hkbpq9whlEf4HhUXYYwulXhPm/RlxWBL2essoCkS2IrRduJdz50U5d9JeXe7l5KcUdGthO+6vkAtCRLjin7m/0OkYkPkk1G/b1TrQsBZG8bd9HbqQgr7zOBhCrNAP0N7UUmXWUREQkhTD5B/e3aKoG6DiVlgyadd82r3szW5xF8SRnotG+RtsFmJCqelcMYocxQkaNHeFtqYRM7vCKK5IzLD1o7TnJ7Hr2Y9fU2Dk1l2bpqKSH5X8ti37WWImLtq8jzb6nr21Nt6kVTrhAehO0xil3Ymjob4aKCo2v5SuamdARK7hLFm1BEWutQi5pruORYH3rfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(5660300002)(30864003)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i/ijSYPZNqfrNliewZ60xgoaKSALNf1KOu53N+Pd8ik9uNpFlq9O7ILA/JD64rjunupcWU2AiolGQ6Kik4aQzYtQO3FrQ72+qp62JzAyN3ooqSYNxh/nK2VywOc2ZyZcXbZtC0MkXTPshBNFivv2Tk0OCarUAhaprxTuZEKe3IJcF5ZOhBEobVBnlZBOfmANfW/1hYzfRLv0/mDGUzceRS8HjJ/AXbfOolBAMJRtBgst6a//E7wiESUnW16vJkvdcKxNczFSH7P7AVyoHKd3YiimdL31q4ntHBZCNuA8l0QlW95jQaveUnhTwqJmrFR/IS8YgnyuU81gENtVKqjxJIQ6iKVzz/5P1IoDDc+gj6GYBs0NrwwDDOcSXr+20nS/vE7ARp4vrxTAWqbZFbzsIHUK+hBYOD9b+H4Nnqqq+JkMgZib7EHWBuql+QxGGm+dnqk7OB6/j1xZqCRxdnqW9z0MImbJNuasr54kNqWzaIOBs9K/e/Kn/ZcaojL33s17LUQ+3mZ7HdX7onENaewv2cTlJcdlJ/NOHJd9FbfDFd0GTIigQKoNTmEmRqqCdj5p7aFdL4y/JsgTzAThKnSeH8Lt3YqsrjXNPVhtrWSZUSkA7sJOnKwohFzp2QavLGcCfo8mRWr/bhsXqMMf4zaFULn2IW0krzd9ywGXRY3tkjMhSC/7YDQ8Zc/zQlCfSHgwJKHWK5yJrY0FzZ1dazZDpT0M0VTsx6ckx/mokyuwfmmrA2dK1+QG6lkYw9Xpx4uPKoi5TxfFF1+BzVbHluU1NBpc4x8pcDBe/WGGU2GGfo6QRL0XA+KXGtr1dR23bvEzttLFcBf4Ok3uqxWBOuR4fmTIosW7Wr03tFUA9FwVZeh+2QlCCQeI7hYIfE20O6QuMXkQt2A4yayB6Xkp1DNJITgnlELv0FRUqxezDW+upqhjD5CaipxYi2sQ8ZAFcPfUIg3RbiDVwIeNOAvg14YPVwe2xEec0ontDQ9W+f51Ky5wCtN5qKrjf62Xn7Ds6dEKCT9Bf7i0zt5f9LizH2EsUFWsL5NZMlgXAwhWw5V3+Xa0vxehzfIaVNvAKqE4gztgXgnq9REDHiJo+5MKPjAwukavirYsbTzow8xf344LXy3LHmreyJvCUtgHhy3X4UM4hR9LEaKQHIGETuLOp12ByjqoDirUl10nskv/KmAZgwnZZQb8NhRAtT5UT6vKeOYmEY/CRl8qr54Yscuvc7XXZDSOYDGJbPnp7l/CtOms3TVs4ky1+lE0cE6JGzr7F1d8Ce8rdOTSSBHEzUIpbw7tkESAnk6XC07imkPFneM3vc9VgMaK6yXZcDl45I8OdpXCkkVbgBoOF7WdMUwBrbF3zS0230+Iev7gFqV3YCBd+q683Vs3pQRwd7LYUWcDcVxcrJHZqZgAH8fFeMGBxgGFFDPR2XAvpY6kQdwpcEpdgeauALfUqse0F4mkvsWNte61TWAFGBoKUgBvsNgetr7z3Z3RPwzBeBPsZPW2OW/z98il7eFqzdgVsdWLqB4My/ha54+2+IX7gIJxHRzz3jLen0LaolaP5uVYhDW4vlNSmSD6Sdb6YdrQCl/JLESoh4FR X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad82594e-37e5-4aeb-e4d9-08dabc2a2b8f X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:33.5282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 28PtiIm2MvKU0X5Xfi3u0dH8lL4W0nwpVuxQTCo7mmjJWXODHCp5Yn0tF7dGLFnNBHd7qdB0QZznDIpcrGGTKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Cleanup warning found by scripts/kernel-doc Consolidate term host, host1 to HOST vhost, vHost, Vhost, VHOST2 to VHOST Acked-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 83 ++++++++++++------- 1 file changed, 54 insertions(+), 29 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 0ea85e1d292e..c0115bcb3b5e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -11,7 +11,7 @@ * Author: Kishon Vijay Abraham I */ -/** +/* * +------------+ +---------------------------------------+ * | | | | * +------------+ | +--------------+ @@ -156,12 +156,14 @@ static struct pci_epf_header epf_ntb_header = { }; /** - * epf_ntb_link_up() - Raise link_up interrupt to Virtual Host + * epf_ntb_link_up() - Raise link_up interrupt to Virtual Host (VHOST) * @ntb: NTB device that facilitates communication between HOST and VHOST * @link_up: true or false indicating Link is UP or Down * * Once NTB function in HOST invoke ntb_link_enable(), - * this NTB function driver will trigger a link event to vhost. + * this NTB function driver will trigger a link event to VHOST. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) { @@ -175,9 +177,9 @@ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) } /** - * epf_ntb_configure_mw() - Configure the Outbound Address Space for vhost - * to access the memory window of host - * @ntb: NTB device that facilitates communication between host and vhost + * epf_ntb_configure_mw() - Configure the Outbound Address Space for VHOST + * to access the memory window of HOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * @mw: Index of the memory window (either 0, 1, 2 or 3) * * EP Outbound Window @@ -194,7 +196,9 @@ static int epf_ntb_link_up(struct epf_ntb *ntb, bool link_up) * | | | | * | | | | * +--------+ +-----------+ - * VHost PCI EP + * VHOST PCI EP + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_configure_mw(struct epf_ntb *ntb, u32 mw) { @@ -219,7 +223,7 @@ static int epf_ntb_configure_mw(struct epf_ntb *ntb, u32 mw) /** * epf_ntb_teardown_mw() - Teardown the configured OB ATU - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * @mw: Index of the memory window (either 0, 1, 2 or 3) * * Teardown the configured OB ATU configured in epf_ntb_configure_mw() using @@ -234,12 +238,12 @@ static void epf_ntb_teardown_mw(struct epf_ntb *ntb, u32 mw) } /** - * epf_ntb_cmd_handler() - Handle commands provided by the NTB Host + * epf_ntb_cmd_handler() - Handle commands provided by the NTB HOST * @work: work_struct for the epf_ntb_epc * * Workqueue function that gets invoked for the two epf_ntb_epc * periodically (once every 5ms) to see if it has received any commands - * from NTB host. The host can send commands to configure doorbell or + * from NTB HOST. The HOST can send commands to configure doorbell or * configure memory window or to update link status. */ static void epf_ntb_cmd_handler(struct work_struct *work) @@ -321,8 +325,8 @@ static void epf_ntb_cmd_handler(struct work_struct *work) /** * epf_ntb_config_sspad_bar_clear() - Clear Config + Self scratchpad BAR - * @ntb_epc: EPC associated with one of the HOST which holds peer's outbound - * address. + * @ntb: EPC associated with one of the HOST which holds peer's outbound + * address. * * Clear BAR0 of EP CONTROLLER 1 which contains the HOST1's config and * self scratchpad region (removes inbound ATU configuration). While BAR0 is @@ -331,8 +335,10 @@ static void epf_ntb_cmd_handler(struct work_struct *work) * used for self scratchpad from epf_ntb_bar[BAR_CONFIG]. * * Please note the self scratchpad region and config region is combined to - * a single region and mapped using the same BAR. Also note HOST2's peer - * scratchpad is HOST1's self scratchpad. + * a single region and mapped using the same BAR. Also note VHOST's peer + * scratchpad is HOST's self scratchpad. + * + * Returns: void */ static void epf_ntb_config_sspad_bar_clear(struct epf_ntb *ntb) { @@ -347,13 +353,15 @@ static void epf_ntb_config_sspad_bar_clear(struct epf_ntb *ntb) /** * epf_ntb_config_sspad_bar_set() - Set Config + Self scratchpad BAR - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * - * Map BAR0 of EP CONTROLLER 1 which contains the HOST1's config and + * Map BAR0 of EP CONTROLLER which contains the VHOST's config and * self scratchpad region. * * Please note the self scratchpad region and config region is combined to * a single region and mapped using the same BAR. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_config_sspad_bar_set(struct epf_ntb *ntb) { @@ -380,7 +388,7 @@ static int epf_ntb_config_sspad_bar_set(struct epf_ntb *ntb) /** * epf_ntb_config_spad_bar_free() - Free the physical memory associated with * config + scratchpad region - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_config_spad_bar_free(struct epf_ntb *ntb) { @@ -393,11 +401,13 @@ static void epf_ntb_config_spad_bar_free(struct epf_ntb *ntb) /** * epf_ntb_config_spad_bar_alloc() - Allocate memory for config + scratchpad * region - * @ntb: NTB device that facilitates communication between HOST1 and HOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Allocate the Local Memory mentioned in the above diagram. The size of * CONFIG REGION is sizeof(struct epf_ntb_ctrl) and size of SCRATCHPAD REGION * is obtained from "spad-count" configfs entry. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) { @@ -465,11 +475,13 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) } /** - * epf_ntb_configure_interrupt() - Configure MSI/MSI-X capaiblity - * @ntb: NTB device that facilitates communication between HOST and vHOST + * epf_ntb_configure_interrupt() - Configure MSI/MSI-X capability + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Configure MSI/MSI-X capability for each interface with number of * interrupts equal to "db_count" configfs entry. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) { @@ -511,7 +523,9 @@ static int epf_ntb_configure_interrupt(struct epf_ntb *ntb) /** * epf_ntb_db_bar_init() - Configure Doorbell window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) { @@ -566,7 +580,7 @@ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws); /** * epf_ntb_db_bar_clear() - Clear doorbell BAR and free memory * allocated in peer's outbound address space - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_db_bar_clear(struct epf_ntb *ntb) { @@ -582,8 +596,9 @@ static void epf_ntb_db_bar_clear(struct epf_ntb *ntb) /** * epf_ntb_mw_bar_init() - Configure Memory window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb) { @@ -639,7 +654,7 @@ static int epf_ntb_mw_bar_init(struct epf_ntb *ntb) /** * epf_ntb_mw_bar_clear() - Clear Memory window BARs - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST */ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws) { @@ -662,7 +677,7 @@ static void epf_ntb_mw_bar_clear(struct epf_ntb *ntb, int num_mws) /** * epf_ntb_epc_destroy() - Cleanup NTB EPC interface - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper for epf_ntb_epc_destroy_interface() to cleanup all the NTB interfaces */ @@ -675,7 +690,9 @@ static void epf_ntb_epc_destroy(struct epf_ntb *ntb) /** * epf_ntb_init_epc_bar() - Identify BARs to be used for each of the NTB * constructs (scratchpad region, doorbell, memorywindow) - * @ntb: NTB device that facilitates communication between HOST and vHOST + * @ntb: NTB device that facilitates communication between HOST and VHOST + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) { @@ -716,11 +733,13 @@ static int epf_ntb_init_epc_bar(struct epf_ntb *ntb) /** * epf_ntb_epc_init() - Initialize NTB interface - * @ntb: NTB device that facilitates communication between HOST and vHOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper to initialize a particular EPC interface and start the workqueue - * to check for commands from host. This function will write to the + * to check for commands from HOST. This function will write to the * EP controller HW for configuring it. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_epc_init(struct epf_ntb *ntb) { @@ -787,7 +806,7 @@ static int epf_ntb_epc_init(struct epf_ntb *ntb) /** * epf_ntb_epc_cleanup() - Cleanup all NTB interfaces - * @ntb: NTB device that facilitates communication between HOST1 and HOST2 + * @ntb: NTB device that facilitates communication between HOST and VHOST * * Wrapper to cleanup all NTB interfaces. */ @@ -951,6 +970,8 @@ static const struct config_item_type ntb_group_type = { * * Add configfs directory specific to NTB. This directory will hold * NTB specific properties like db_count, spad_count, num_mws etc., + * + * Returns: Pointer to config_group */ static struct config_group *epf_ntb_add_cfs(struct pci_epf *epf, struct config_group *group) @@ -1292,6 +1313,8 @@ static struct pci_driver vntb_pci_driver = { * Invoked when a primary interface or secondary interface is bound to EPC * device. This function will succeed only when EPC is bound to both the * interfaces. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_bind(struct pci_epf *epf) { @@ -1377,6 +1400,8 @@ static struct pci_epf_ops epf_ntb_ops = { * * Probe NTB function driver when endpoint function bus detects a NTB * endpoint function. + * + * Returns: Zero for success, or an error code in case of failure */ static int epf_ntb_probe(struct pci_epf *epf) { From patchwork Tue Nov 1 16:57:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027232 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED27C4332F for ; Tue, 1 Nov 2022 16:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbiKAQ5r (ORCPT ); Tue, 1 Nov 2022 12:57:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230143AbiKAQ5m (ORCPT ); Tue, 1 Nov 2022 12:57:42 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A0911D0F9; Tue, 1 Nov 2022 09:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F60l9JoFyx+GQfdZwSCh3r0GlzbiJEvco6+ZD9NYOugkdfPucAYmd0fS+G99TBT3stn1z6G5AEEu5R34wAicIoX8Tj/DpgpHpVZVh4NFXI6tFcqZRCCfg+Ts7K9Hp6hbl/MZz0izy36EhmhwAQv+c3GgpjgshJYilR33xBqd7XVpvrpuCJ4mry7NKX1ER9Vkb3exgJBRpHghpjUF5GEpl8V5Whnyyi3PsBKXaORGEx+RJtFvmRGqUjlm3aLNb/pgtQIsMHG4DuS2CcrAQAHYxMboCFgHmZFQeFrN7ux8OTMc+oiSZm7HEh40RWvk4OrkSEG3EKn8vyvp3XhGEcY20A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSqxyTF416uWTAfTmzpTKKp4abZoPZOkUSlBUHn3j/M=; b=apu+iMGFDP7dhD425/iTHdr69RyxH7/NuDpt/h4rJGVRtRaHvzqcRe+Lqk4WnLFpIfEQF96W/qGl4w9Y8y0H/emMZ7eOC3FS/QtSDK/NjXEO0S3ts79algcilPudrnLPVdvmNNCLIm/F+1QMqCILwWKIodI5u3Zzy1mYYLuE5gHr0csDvu7DVwI4+p62bONx9moY2Bxnw4rU/ph+J/3EYcOToRVwI/t0pMzjf35YkD18N+yKUo1FjK8vcNOsNHFTkEsEHAZHrV4xUAPI6VkJ9OWDMGo5OA87QwFuGm5qOcrG3PjQswM4akiqE95NzLNiomZalqjg9g+aEWrThq/k2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSqxyTF416uWTAfTmzpTKKp4abZoPZOkUSlBUHn3j/M=; b=lirKo7xepSaiL3y29YZABSPsYx7M72QKkuz066mXbTC0QHZOjQIiFSVfMqJnwxyaBCiwNjMcCxU0+YPDcIih+aazYpPhPo4P7SjV3FjIN0oloPM2f5lEEcmDjMCjl7KQCgWb+RQGhBzfNPnm3cE8R1LFDNJmVHCBxYlnhG8k5Ac= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:37 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:37 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl Date: Tue, 1 Nov 2022 12:57:04 -0400 Message-Id: <20221101165709.983416-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: af02de2c-6459-4de4-e5da-08dabc2a2de3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1IjVS4ggcsGnr3p08bDmxNgngOPY6Khgjxwc9250B7WmZ/LoGqI/Wg9kPEt2/45ZvIYBZofvGGA3zGJeMqpH/mqPzUIGi35HxACxiRGZu5e+aHP0Nnu+Sm8PORJQ7SDpkuxslF0h8JD2bn0wOMwe/LhHFtVITnZWgCuoNNYtDA5bdk76ZE0MtHqLe1SV9X+8sWPIeq5I53qBCmGouG+NZO0lYRZSwMFNBZr9nXzP8QfW1OhOmIqQlcbFNp9nEdt4pCNDtkyDcbhqLS8gtshrFYghJiuj1zL7XaomoPP+KG6GIdHDPaGBHTWjxbdEPUgUr2zL8kBdLYDr0tFtdWffKIt2/iDma+nhOAPQ+QYrSNTW0A3Z24wPaqw+x1a9MFeRGrRzZHNkmwma4W0fvnArVDPHdFsE/JmudPtdx2g6a0OivumWqWGkU4Ix5tmBCiElSZAsxTeUy+A7ZsxcMkZO/Kid6zglilR7ax3z/k1S5mD56KIGs6wpPLiqs1IVNddjn6pwQsbrDZSdku3OmfSX01/djGGe1TPfHYIOhAA7kumUSESg12JVY3Vd1ydx7kbo03nkPiub+/JnVNlTkqSh8NBywEI2HrNurAyT7rQ753Q0/lmJSJgSww1Wt1u0fZRdNZL2bYv2H0DnlI7xG0rIUUzLBdFAlTcXZppWe8bZ3kfgvm/3JNqCjXd0JxzYgh06m2hAMBZPYn+unNN30sd9i7jO1l37K/BrDGVK+TsAMeqg/O3jY6qej99ELy1dwPrZedcUNf4cNnyh0f+euaF/cw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u6xjuA1w/SlDnNwvhMCFk7n7tPBPPeJCGyzwT8X3O1rxstDYfw3Iq4N8X6RFWynNXBGaB+goB5FhBqVKFyXQFSQnS9PU9z+2yrJ/tdwgV1SsGdrI1eXRjcI/HcDxJP49rUSJHFe4wE817fnuex4hpu5VfuP1Zn53w7otaV1CuHj9QKCbulL2z9FdtACKidrqhfDf/2GzQPC8RU6vh9w6Ln6CCFYP8YYRwK7+oV0P0/UmfecK/8MYmcDrwXvkiC09IxuQCDlWT3oF0cP+mE2QybxSTPDpv0PGFzpdQnt6J5P6e99q+I7M6iWr148jgzpFbZMcHSjsvDMRvmBrA4stoxfvgoYsWTpceDIsM3uGmtMQYVzgeoMkYnilnABIAWMvWA2LdJRSaNBHA41/HaoDnk2zFxsSYeheosdGegvVALfI2LLhUZS/iBokILAj+XMhPsDMlSlaXcQ4uo29BoWGVRg3l9sfL2BekFnnmfmN8PqX0Rp7QELsup8Q0pmun+h7X05SVyJVRkI1p6UyvJNwPpruVJtdXVq7oYbwR9lGPoV6F42nOIqgvv6cB4+xAxtsPqyBFvxpHUkpFcnJaLg/++qRt6NDtCxq8ZgjsOePnhR/pnrnOjpq0taJS9GzR65GFSNmVbH8mBJjoTI7Jb17/L4kViW3NGu/5cnkp1z1GHrUxDMNiEw6lgUoRPFo5pTSVnhfiAiyU8CMtpzHlpYTpyfEvcQEXr+Jg7BS14K3k19sSVMTNmz6WC9BDYsO+TXwXWarArbc5Z3qdOnYX9IUxY+7tdGGLfemiBRK1WAkmW37o4qVX/v1viQ7eDWbPxXDCwJMIeQ2Fmiw1iP0M7cICGVi5XVd4IbkDaRI5oC+PVPHbdAfuK1yyvhMtT1hlhHCrvgbmMHSu/ONwy0T3cYvlgQzjvdoWQU1AOdi5B3EQ6+9B94dCDKkDcQA8WbV1Uw8Iv3/rPMO4QiOIFm3mOV04ym2JC3mi840hdQFq9eEolHNACkjZ+k9g0zaqrUhJWVfwfW4H0aKJD7UxetfaJCbi0Spyr1wSVZYxhDa05iKL0uBg0DfGT+LtCMW8cE0Erk4D5uXPmfzKCgQ6Pl7v6Yh4yjKSNyfS4Ov8JuG5MdMm5ag+ZI01bYPUFCWtglEnpGHuMueoFYDEJNi+DhCNUveq4ircssO35X51xG6v/s0XfDZ8wpBrQCxHwiaKYFBLb7BGu8EjBKUjzugLLkxJHpxw2dmb84TkkeG7VIDLODMn40gApE/JHnk5SkK0xToa/5+659PGUVU1LxKKMLTGRXEIGbWleKxCqrTglKXYPdDweOwAho3EPHGDKNipEbuPuL00sZzmA+GGXfRclOg8BBj4EHLVqOzARAaqD82eT6Kq6AtSdHYxXcNMRF0bf/5z6UFdLGvKuELRRFWNnxXITYZUWCNk5UjNaBIfGa4MU+hq1UAxGV05mhrnIZB7XQXdWf0ZUzaoLQJCbaVbdDlwr/z2/2CQDtjfQ8B38YVhO1IxUuxC1hL9kq15AorRB6AGCPsiC9QWqMZ9dTRUBWgFbUyAdbpp/UG6QUKAGx5r0U/M7qjTKqRp0XKqh3OiZ/Ikc0i X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: af02de2c-6459-4de4-e5da-08dabc2a2de3 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:37.4186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: poOHuD91yKrGD9dOQPGRbhXW6rugqfYhCy3dH+mZzcDr5a2eh11nQm1Tatj8dfSbV8nrZNDA94piFS1GJ0hxjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Align the indentation of struct epf_ntb_ctrl with other structs in the driver Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index c0115bcb3b5e..1863006cc36c 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -99,20 +99,20 @@ enum epf_ntb_bar { * NTB Driver NTB Driver */ struct epf_ntb_ctrl { - u32 command; - u32 argument; - u16 command_status; - u16 link_status; - u32 topology; - u64 addr; - u64 size; - u32 num_mws; - u32 reserved; - u32 spad_offset; - u32 spad_count; - u32 db_entry_size; - u32 db_data[MAX_DB_COUNT]; - u32 db_offset[MAX_DB_COUNT]; + u32 command; + u32 argument; + u16 command_status; + u16 link_status; + u32 topology; + u64 addr; + u64 size; + u32 num_mws; + u32 reserved; + u32 spad_offset; + u32 spad_count; + u32 db_entry_size; + u32 db_data[MAX_DB_COUNT]; + u32 db_offset[MAX_DB_COUNT]; } __packed; struct epf_ntb { From patchwork Tue Nov 1 16:57:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027233 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D68C4321E for ; Tue, 1 Nov 2022 16:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229511AbiKAQ5t (ORCPT ); Tue, 1 Nov 2022 12:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231191AbiKAQ5q (ORCPT ); Tue, 1 Nov 2022 12:57:46 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70047.outbound.protection.outlook.com [40.107.7.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA4041D0FE; Tue, 1 Nov 2022 09:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU9lgzfdsGWg4VgjwULe7hSVBL5RQgAq7uGFq0lihRtVTCrBY2ZTrnBfaZ0wbaPVyWn/yF2V6gWtMUL1fMnmM4RwN2aSj3A6h864KMx9x6Pds+eXex9U8rq/cHp+kbnrgo+MPH5TamTcy/KVwjrRLm9dOuJBYCWWR/5nT0sIGoqfnsQrmXMy/Lk9OEeVO5/hun0blXH0NClHvVfOhVJ9GGtyXZ/8P/vyU2KTeMaLG8vVpjY0MIXwTy4oo89cCUIGYmfYexJYlr19HEEbxCVCoN7q2CTuQM/L3nlQBiL5GjnUSrPVfb1PEKRDRIQ7HAQuEMHb4c7+qy9zN2Rgu+rrNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YRK103siZ5945LFLHIFILLE1HOlBh4/xZcoINeMqjBQ=; b=A1YV7cjQZwAnPEVuy4TUREunXISpicstprDxThzmty/9qnEiVjaOB58wKAW822EZkvQywIrvgSifFN1Cpxsfs317b0tgjPMRglkThTVvgu6a/x0aXrB4bQii9rlZl5stz4BEwpGcNHEsgY00hdy5hJqfZfLRfplQczHKcZEgLLhw5VtErw+jPRfBBXsG/4Hbl6+ag7BOQhPARQn9TEyHP0YYWcJYiQZyN7LCGXE0VwJP3+fpv0TQmwzsYaNzgYvLTkZ5KR0HVO8ASbVURDqLYEuWYkAKa0mkPxvLFn+V6F9qGYij3rs1TKSjt9LFpalmyRL+mDCWY0iwIfcFFKbAdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YRK103siZ5945LFLHIFILLE1HOlBh4/xZcoINeMqjBQ=; b=O9IzxmVbQh7Fv+3qZio7XVm+0Im2jkwAy0Xs2emQgH/KvFi03lTZGjCiknRfiMH1hN5nzVWky5/7xoEbSZmzdVq/63fmmJvTd7NSJcze+Wnq1sZu3Qc5y8jW54fJoc6ZPPWk0JIXQWwyEFtDzCH/c3o6xBt2KXnMaB1JHmkdkhE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:41 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:41 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 3/7] PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err path Date: Tue, 1 Nov 2022 12:57:05 -0400 Message-Id: <20221101165709.983416-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: 50dbc345-2f14-4640-ab66-08dabc2a303c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Id6iNBatm8e8n2StFNdUaqWO3ZJngyTYzeeKOTn2uSv2F0rJIfrbWfNmsj0vxoHmY49Kp1hwUNXsIJh0OkJxgIlle/FxQyEjjmWm5HYWhm2qdRXMspVpuE57koGeXpyGueq9mQptEpg3IxOBydKKSlwX/yxnwCGiCP8uPPtkVaSn49h//gORs55Jxn9f3Gy/8UcerKjmnfzz4F9cvPYZJoDZbqqWAhm/Xqu1obhzNRD1lkm/0WlbKt+UoOzzo1ODdjDdToS5Bw77TfoDryNf/lyep0928/JBe6koQAUZf3BfLGtiz4v0xRsycwjxV2KqBAA3WLt/wWI9buJjavP+UtegNu0iFPTeFWHqDBXY0Rh6kVEhw1YoGpmJERjE3r6fwSAM8eVrw0wd+11bgaaaTgQlMhYyOxgmXS5Hpg703WfVVRbeRynjZ6KdTfRIHDGTb7Uv8stYfNBLpoF4VNLN262fogo4SOeeP/YmS31q+1AS8FgEmifGoWTC0wNVbH9l9ZZ+/RtN29umPuZ/IB4etiJABPAhmeMNOyxOCnKHiC28djMv/mx9Tj8R3rfLFxBqH77IrHkyDRj+iXqJOGJgMKfDvObGqp5+E1F4CwlD4vKXSWTbyrDxG30s8rD+sxC4HDuqLwYv07MC4hC9pe3gH/OimZLHwzDD6JlpSLeVqUbUIKEmr4fg4Z5IO6XTIbNZw2S5JAdQ/Ltd/QgkwkFyYkcbexMQMRR9BAqUJAE70IWdOm3k9TRM+XKgUFeix4rkv4COavWHvw84rsTXT5zfog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(4744005)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KTlWXZYoVekw3ZMSzgmHQ48HdLvBzwKdcJ9oiLp+CggpZ+6X7UYvqZice/kw2AQCVei2lh6gP0Nsgf2A7ZygSzrPkcZFPy8Rf2W54y55mqNPKZkLe5SG6flM75Uw0/UBchI6YIUQ5YrFqIxyWMqLkNls4BVH88YOkDeBgfK8WQXkZFsCQc8MCQXq1WhB8ksM7li7pt6BuJKJuASUCfifSGqRxw5bqUwYIkXz7aQiKMUa0rupQqfgUocKN54C3AMKkdOAfRXgVsNwbMAKR++ebf27nlD2jaXKHnN5a4XUXuyDJG/dhj6E91LTy1fD9gAOqvCTsvNw90kesnAZU96OxC3T9Stl76TL4Havx8qCFs/Bo05mMDmEF8bsF95B6K4mewW4zomH657JeRwJ8WpPnb6danPAgR+yKAj+jimRF+cpMkvYBxeJrGtzsABHPVVc82F/XWXBhSzSMAjTFgtmBsl908VU68YhqT/3buWnfCmmUPtW9dmmMWRGfL8a9u8T3xm7ctZZNhG99EB6QypqLoSZYSJPKJJI08wylNmKfNAPsSyjFl7rs9JAIUirhOp6qEqcUrmU+S3Zty5zEUMnnpmwtulZedY38+gvGoya8DVqSjyfg2mcr9QNv6R87EwRtUTckrRItwnh12WL0XIJgl8zFmDRSyH5q6OEOr7c/paJ70amlBi0Y7hzFtnj+sUjzSqwDqU9U1Y0dyk1EG/WQDjPvzkKjAsLb/HFLFnfRoY7mu3tCYketTb3T40wyB6sX3T/VAMecrs8FJEyP2VxsA612ldt5MRLLDJyuMbsgqLiITze2J/73N+7BCyYAUV+U40gjEtX1MEY0jK0jdoZIhPe4CcScwA/pxzCHyrmwzC/JP41YSeShNRhKd2HoQoQHwPmlqgYmI5Wh5Zt8eYtBswgcLVZ9rP0vyTp8WkhvAgDu7PoRdyl60xJ65oZ09D7ahIjTyMwWcuSZlBS72PNTjLKHlbSsSAUwPDfhmUYhUsV6m4FOYELxJhJD6VWRlN0olBYltAdKFK8iQnkvK0W4wT/d4BMxpzOTySNp4gcUAA7YrXcWYeNfKJnD67jue77MMYSBNPlWUTHUizLIGqRaZidBMrLu4ye0IoVlshFupmg/3h6Rew1Vm6CcXK/goGV6r/PcTY/8fbT6VfiCCKbJ0IWDfFZLbQpqQ6An7xrJHmFOSxJT+PF90CKN3StnDLy9cE4LVt7F2XVsmJIaU6ZQphNh+EUMBEYcE/lWZ/yrBIUKO7V3NL6szQoBLC2qmPEp3No3QPYwPDM7XyQe3r80V7y9GGBtBmtTREzj0lUFXg9LA/muFdZvsdmcNjMM84evMznHJRxwz9Ln83sYOVPUja7ZBpkMH9HBoL2OmAVBBSWC/QnxjDUPCSzAF3gBmbia0jUC5HzSqMZsBdmtxHKbAAL5GTe/otguJyGZ+kapInOEpKKW5Ct76KWsf4uk5Qo99Gtxyy5lFX1SdreRGI/pB+64l+6IJ6JV6wsoQmvNXtY0SKPDGOCphXSvZiD8/XpUjGaMEw3vYX31Ba7nrDLIzL7nJ1j78p/enohNwSl3mx25AYtR43SVf+whnO75HIP X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50dbc345-2f14-4640-ab66-08dabc2a303c X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:41.3558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZyKXj6qYoElIxGiuVbOePHVHLfdwHBzKhv7S0o5ty+41qNx7zklozSI0Yt68Yi+xIxJGiqEFQLyfem/oTozogg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error handle path to match pci_epf_alloc_space(). Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP") Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 1863006cc36c..191924a83454 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -571,7 +571,7 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) return ret; err_alloc_peer_mem: - pci_epc_mem_free_addr(ntb->epf->epc, epf_bar->phys_addr, mw_addr, epf_bar->size); + pci_epf_free_space(ntb->epf, mw_addr, barno, 0); return -1; } From patchwork Tue Nov 1 16:57:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027234 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C06FC433FE for ; Tue, 1 Nov 2022 16:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbiKAQ5v (ORCPT ); Tue, 1 Nov 2022 12:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbiKAQ5s (ORCPT ); Tue, 1 Nov 2022 12:57:48 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70047.outbound.protection.outlook.com [40.107.7.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCC3E1D0FC; Tue, 1 Nov 2022 09:57:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1aH0xa7Fmz9JuqGPI3uEmPDYtTT2fmvLKOdyXQgOn4Sj6xCh+gQ0o3H9SZ/aMdAs/i5YOJC5fyMbUZSWGYGGB8E4LjiPFSr1ruSjEl4au7Z2fWIK9QyH0DyIocKk/l72qPVz433J35wZsle4Y9AMD6wqqaoXbAuX7MRWDL7MXDgzmWQ3CuqfCQyyjKxhTghGigYi8fkSVGlXuuieYB8HsvEwsQnoLvstipfomjxi4yqZZ7aT3JwmhBLl/sg5qzxILoDmgH2OMRqDxAk4mHiQuxCmlTFSk4maqT+xU9gAGqFkRDuttzZ3bXWPsIAtKcXovHLvl2Ksqvrr/gzxx6cHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cg9Cz+TfGC5o2RUupkOOm59g23D635oht16Vk34QK4Y=; b=QCAgJN2OtWoB8bU+o94ug8SObJqBxrghjCidoajvvCfiATUEHTpRErBL2HBdwiruykxWwYhHK7BAgzdjKiB7ZzerCP0kso0UsZuBYBrtRzzNyW3ONguyCYsPuhAh9Ckxn0YeV0HS6gCOgStoGJsGnVQdJzHdD2z2kPRUhfCEWbS7j7vXVWu7mZA4PyOOj+DelE7oHTvpmmEzuzcnrRkQvZyP+6oWZ6irN/sv99P4/tbMOvEPzyBV39rfIUAmHH3ABvzbuMgSJv4rIH1SdyN66goRdXrNKrCwtky21IRq3RvdpSqLKJ3V0MEVazFrd/tJMgFuAVeUlkr8lWRHZVrPIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cg9Cz+TfGC5o2RUupkOOm59g23D635oht16Vk34QK4Y=; b=V8kJkq87shf8IAL0EVpMIkY8ujsSNjb6r9CjYa1vzAdKV/++TWZqk25s2LlA2DHF6p9+QjsbDxGC+jbVcM/S+tIDweBjDJGw8ww2c5REayypZQqnMPQ/ELtQ9WSQjhof01D7/niWr8ZjHsongHQf6owhYZhPS0NxP2sBJVjoaSY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:45 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:45 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 4/7] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy Date: Tue, 1 Nov 2022 12:57:06 -0400 Message-Id: <20221101165709.983416-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: 4871a37b-9a5e-4f56-7105-08dabc2a3295 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QUqTAWuxjMJ2yT8f3n55CiLT+wQV8v0ZUs1Togn5bs4fDyXCFCywozglK1fmf1i+/QCSSMH3KpS0X1jqZ/HBYIyCE2z3GJkUQwEr3nOHbOZFpVjdKNEwyd/8O5pr5s/hM1EV1pnCNSdECVql2Vado+dLBvxhWQGvOg3+kKEPhEl3xXGECL58nAXXgVhq3mtHeUJXvSw42VLjdne1Oi9xCU7/eztJnPWfZlAzc2ybQeqKCQKU8B16Y06BojzAfdGLv/LQoF1YSGvJekgffKPO8WwYIdNC7bPKlsaDg8kC3GUX2moC+V4w8tHYlKKf906WYNwc+R7ONien8jmCQSMVMjVaMmeOfGfOlVUeSBx/DXop9LIDTnbmiGwFxD5zsdYmDGrbLwjoye6RGqA98iPXpqfKo9M4v1LQHXAPYRlhMF4oHRjghAt1Ps3V31vuyQqCuODg4oZXm267cqhUeZJbL827LillK9V2SjJ9ty8kVRlG0k3IIWDnJrM99pN7hdI1mKCuD8v0ab2EzAvjlg+ELOzmVCdTNEnUDPpKkEhCHixTwsipgFQBTJ14Zp2MFx4bRZrLU8jdmf3AgkboiNoTyrMOOwTidrc7LLPue7szAz5o9qv7BoNQ8t3u86Q8+MSINX975rWU1XJ7bwjpCPajK888DLApRbZ4p2GuPqJd+CJQZhRskG8PNtAcZpP2LLiwKF58m3DdZM+6kUZP1dKaGURRrJY7I35My1TEpm/ULI3UzVJrp8eJXZERl/zxykInr3689OYZaagqybX+Sl6GhA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(4744005)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ICT/kEomWu3od2dSIMiGaHx6wKc3G/ClTbFqRzrEQ727Fq5lObCoYkeVf9DVnaWri7fkB7qCpTqUqLZU2maXS871/6IB24neONtGZgwyMqdmilxda9gmth3A4eP0uCzfj5R6LSlhbh4pcHL0rrkYxhoSsEkpvbyzbxzFziBmk7E5fWGHfV9S9eq7vqr2DUKYdxuE9OjtM/f5+O2brJ8Fkf2NWNtRiVDXR/WIhxIa+NekEEI0nlS1Z0cM131lhGtEiryvDKWlUXewwcT7Hakbfd28Br9qjXyKSaCPVyg6QX0u1cnWxvIKZzHNg4ppt6QW1QxhICtvBytViNIBZBuL9oOXmGbI1ZMXDm6LqhHavNAkoET5nup3PeZ6QaZkn3k/iSPznxIc4jVbzuPnol82NDATzWf2XkNpZCNrkyq7TQ8sktoHZ6lq0nY9jVe67aRWv8Tke5c8sS6axnGIb4l+N9w9M9oerkXWtYdQuDsA6JwV7Y/Rmot6ptILSeeB9j8QNKFB/CzbFnfC5VxWr6Nzo10eYRW8CwHAwvPDPaqMxAM9Vll/VwW/Z9J7+XT0aqrJraRSdeGa0q7f439ujepaLBQR6Ro62rS8UzXMS1waBa0JMfylaih9jRkPOtzfMjn3IhrppceNXoDtN5xWBuUIxJ8P+BkWHKz6i0yYn2iA1q89mrDqrtGOpM5aXTr0ZJ2/TsnZKnugI0WVeoSkgUwbieZ4KyRp+fA5p8R/NPPXMF5FHT7tc15a43DH8zw63TrAPcK6GwBk0LQWKLd3gksM4Gy/hu5M3enZPtxVzdKQzB7iDtzzpLo7Xik1C2NsbjkOPDwX4/hxyYWlmPwCYFbjIwjDI7vQr394/UUsXUJK0kJ7+076JHmibPGVb04zzLtlWvkJtx4I5tPsfJJ8vj69Q8/KEHrb0aS3arKW1y1Z9hYHAuklo141lWjt4jAa1dtTcDEFe2CfHf3rFjZmhOF3jPc+FwXoXzP7tzlbHs7szzbgm2TzSAKRiHnwE3RHgpQt34pe5/Xf3GHQoODM1xP5p3e2iqaQR8pqvdUsUYxubLfkdcrl4ZAH7IY45u1hiHuKjnqjIJNgibMFtTVMvit3hrB/5V+dMlzT6HlQG9CPKf0bD9RwPQ7ITGvdX+QH7vQGhJhl/8R+T9DUzhT26nZkoK8UyZlFciqZWAVJCHuF8PbZR9/G3SjXD3r3SCE5EyzqOLGOUSsS3aT4tVCuUQWrNLVzATGKI5sBZYWsmjiOYEDS/gtb4ytNLBkqGAVoo8trT91UTl3EILLNxzx7Kcf9CimG0c4HEQgne1rZ9tNpU9MqpQG24XmwuDHLE/vU1zw5LmX1uh8cvha8m1893PrM2KOnOTswSMqt/2I+isfzLYtN1yneztWngcNHP2Td+3il0wUzFcZ5jTKUd7r9P+b9rZAHdhnaFEZjkkK45SAc4tlixjFIJyvyQS9JMWTnScbyHYwMMxr+zJ1RZ3t+up9AF+/XmJqHVso/O4sJ2W8qbV40c5FboKDGwrD2VG8QUN61hPC+80zgJcJOaXf4zhNnETbcKVF0ycb69AoLIsMNjvF7IUNltpJPqqWLX9o/gpfF X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4871a37b-9a5e-4f56-7105-08dabc2a3295 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:45.2774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h6h2UO9gUYK2+0IlUXVKmQ+mfWEvo+eLDEY3KMHRqYD56wRRoq9YnPidyawN10HC/63sLfet0BwLVs3k1x7uaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li epf_db_phy is not used, so remove it Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 191924a83454..ee66101cb5c4 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -136,7 +136,6 @@ struct epf_ntb { struct epf_ntb_ctrl *reg; - phys_addr_t epf_db_phy; void __iomem *epf_db; phys_addr_t vpci_mw_phy[MAX_MW]; From patchwork Tue Nov 1 16:57:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027235 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5178FC433FE for ; Tue, 1 Nov 2022 16:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231194AbiKAQ6E (ORCPT ); Tue, 1 Nov 2022 12:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbiKAQ56 (ORCPT ); Tue, 1 Nov 2022 12:57:58 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E4F01D0C3; Tue, 1 Nov 2022 09:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kteey2HVuyXtS77yx7eTeUB7XbggQKHRgoY8BMh3dwXwL6Zf7r9QBK5o9xI4YJPo8/mkIb8OrMZ/TevclzCsAqrSZF86WcRmc+vPcVG9X1c8Y30bNReobyoYR7C3XtQosntiUcLyJo2lM4uHiulg5boWntUtwiNPgLJTMpO9nNfHPkhV8yAjWnCIJBnXJCL5tnjBgNthGFo1ZK6lEmhHub8LtdADT4Md0J+vFsKvNZi0o/rQwOgjo1E9XrIAbIojGfADUwP39OzTQFPMhC9f0Wq9DrIAnFrr1EC238gOCOVL5SOO/fACu2K71bWWjhGMcSBkUuzdy/Aade+7XpRMmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P5pmgfmO9df3Hk/t5Nvw6lWOCyuSGK6o3sQhZJwpX0E=; b=PDe2AfMG/J1753TC/tRStYV7IOlDNV8ZKwHFvBiGscM9WbWyFGammjMqrXQSRP5R4eMP9Unay5nIZTVOSvvtGWzr8B9y6IiPnsLfaS2hGcbhqyg+iVuDlP0iIDF4Eg6qlMGg5Z90SBkRo25RQ6bohdSwoDuIEl+m7iHEHoGSacZCw+9qbxo//Ll81rNrEBj2rkyV+b71PYzizs/fwBvR/ZSaCEfHnPpENDDh58umKGwCw72aAt818sd5SjDFhUSvhuRIBS6N39srvdcR+ZOPd5YcCgdXm2371GzTGW7SHurvagFrU15AvNu+XpqNzxepKXNis5atDp1QaTYqZl35mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P5pmgfmO9df3Hk/t5Nvw6lWOCyuSGK6o3sQhZJwpX0E=; b=oEU7uyDXVLZPZUNACQMDgdYlmaFRlbNwdLVBvzzzWltlGDJHwk6SnDHxY5vY19btXqg7sWWehQ7OSNdY0uaOElyte7WsVSfOUdagxiT/OpeV1oGSY/SW/ryYMeGofxRKPa3wzYoraU6IvTDO8FkLGrmR0Z/KUfroY20mPUa0Tio= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:49 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:49 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 5/7] PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32) Date: Tue, 1 Nov 2022 12:57:07 -0400 Message-Id: <20221101165709.983416-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: 58bd74fa-2fa8-4fe6-d452-08dabc2a34eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8A5CBYGhu+PSPIBlpQjubQYfH/wGSFQ0/QMYbRf8dJJL6ngxhUrFXFQTeCLMqma4t96Tpnyd+M8dUr4xgfVS4zn/X8+hhTSoc/BGIEjTVqKXjNd8D8+P1eSrT8pusiCh3f7nKjvn7VWEPfhSWBbbsnNrkaQ0urDz64zyJ1euO7afqGaaIHlfxfRbGIQjJZYs/PgC+iUo4YE8oYFC+Xav+pLfkHvf/CunsD1sdxEVgdXhczI+ipAcmdxU0B6bULudVpdLNlsLvBVlvio4+y2dDMOFQnC5+V5hzl7myx6IG2ndwoYguMpSZxxgliW2tDTCgLNV9M9nUPHldnFg5M6a7UqfaCcUuGlkWebICrv+m8DsbDlLvbpp306bSbUjWd/xsLQXXPXfmlpSdqmydTqpJ8UavfavL7txESEiT9UfMdLAClGbigAQtsQaGpFk7qfnUAoyemKksXmz9hjzfzWfCNgl5aG1w3DNtqh3PkyEWPtaE1MP6UKtxGs6xBFIr/A8glgf7Zg6QWj3z59Gzs8gSOY7gTtog+C5iNEsX9DIb6/C2msZ4y4Tw9BQaGAaXrIXJtq8CfwERhpocRY5Jm/eVxQ0L+ZKGmVxjBaWLshMZyQZX/uPWS8D56+kQn01RDal20R1OTF5uEaF2XBugmI4dNKd1XkOy6N+TgvEnKxtR14I1uzQOf6gTa0XB5/XkZcbgbYkZUYb8agfgTHtyT1yiazQRRCjuqjpoyEK/2rVksvF35e/usGMSey2IZ9LzSou7CannOXpEE8S+yo+D4MIBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A8AMe/C1CL3KIH5cRB4QyFWsvFcXmcPuHTe8OBIjAOnm74wy9X1cVuzBYkn8a6qwiHB1a1ZFbOOIz/SiwyIKKxfsd+e/TTAjHN8ggOKZmoHtLizO0/SPTA1brZvfqKb3brxpPffWWSY0JRWiwPQvTKsZzYllGZCfA1vWZpMMS5h89swGEC9yT2voBkRgDOsxwTu1LqvcUmGYritYD3xE1+gRknRY5kfFB/QA2DyGb8mqSRaITjE3FUVUQGBxPWU34Ui8HUm0v5GkRx+df4CCGXQNhoyZRthyqhNKrIZFqWpmAYkgP+MnTEZGQxd4nxxY1GueR8Gvkdp/dbtLfUf64iP6RfrvQYOUIc3HOofwpG4Yn6rN7+SE5rs4DrZoawphTriz0Q6NTpzYvq9ykjc5IPBf0scXMLXU5AJohB36Xiw/ZMsuDdbMZRqfg5Zo5yKXK/gwMvzPIXseMKfcjId+q5lpNghlduy4xI3yj7iKXRclj1W0s1F4/ljUbYgQCdL+3OxZmufN2rUURVGrPhegGQZv3hmtQiPuJTBgNsmzTt1viPKTS3mA/25vWKUCIKGfe7NspDBsrxNwRkEkdBjSPbsUQipV3W4liFuKGduFsqJ4M3dCe6NAatYLuHFSarPFVk+kPeBmYJztI7gInmt83rers2xE9gG/ksQkY2FloXsVhJ9dMv6+Tp/Z/7XkLersqEYDD1lQDRW2Y+pxrRhtHvTOwj5Ff3FqrOzF768+LM7yR3aXLECbp7nnXWJ4wezkbzHz2AqEi1yA7gN6JOy3T0r8bol5JYrN6T56zhw1LElRRp6+gKWUW6bkAp5X9vti11nDiSufG7avY9b5AUt0LP/3EAOw5OGcmQg4zAV9uPx7PGakZn+OgqtKUsG42rbch6tcUF6DYpyVtzDDpg+Qc7IorafsWUEs99uPXorCWAxN882MH/CatvBteqGilXkTtljbEoHpVDy+b+j+6X7BZCcxUSRQSda3uZbqOU9NvK5OnKkDNY4gCBqn2iQRIVcljlhpBz+IPGys/Pr3Rgi+H9avhh7cg7S6Gd+zdSAIVbaOFvSm1wuWLpObHFObcKEBaAVx1fvUD+1Ctln3Mhzb+KGeBvDzMYzTnXtRB96h62FBmKUvrbs5eM/LSOFUdZWO00pqgZBBQ9Ed+FiiFf6miu29y9egGZFicXpnit4HpuMYlHqRaryDGCFrWTyRbdyRIREnuoeu7iKpok19xA09pQtj1VIWEewqLUbrjAWxaMLzcuZg8T7LkrofrlNPz8h6G88hNXoKIeSh85H+cmDv+UP4DkWWepqsspi8witm/AuNjYHK+nt88a+X8lyUOFtp102xcwlYWr4GJiVh9yCQ+vYHXIvGjVOmrUPszbcDOYRDCf9kxCBqxjZpLZ+OIKm3cG3zGZtEorciWDaZIWiisUESXB6EOSkc9vV6COQgpUpiNgUQfCg8K6Vizgv2xoR6GgJIgNkjobgDc1RfKVUbgNQusQBDw37IeGLbz+0v4MhguT2a/YICkp3rpeMUIKMZD7UrlI+Bh50S3K6jc/b+PG1Mu49Xw2KUdJKyGeN9iQ+mNQfSj8YxeeISgYDjdmyr X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58bd74fa-2fa8-4fe6-d452-08dabc2a34eb X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:49.0583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xbiqIDp24HZAZjLH6CHzTzRmHEM2U8KOJ9pJznWKdl879Ag1bPnMtq06uABvAIGobydJ8oGXfJWf001aNIkYvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li ntb spad entry item size is sizeof(u32). Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index ee66101cb5c4..54616281da9e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -257,12 +257,12 @@ static void epf_ntb_cmd_handler(struct work_struct *work) ntb = container_of(work, struct epf_ntb, cmd_handler.work); for (i = 1; i < ntb->db_count; i++) { - if (readl(ntb->epf_db + i * 4)) { - if (readl(ntb->epf_db + i * 4)) + if (readl(ntb->epf_db + i * sizeof(u32))) { + if (readl(ntb->epf_db + i * sizeof(u32))) ntb->db |= 1 << (i - 1); ntb_db_event(&ntb->ntb, i); - writel(0, ntb->epf_db + i * 4); + writel(0, ntb->epf_db + i * sizeof(u32)); } } @@ -433,7 +433,7 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) spad_count = ntb->spad_count; ctrl_size = sizeof(struct epf_ntb_ctrl); - spad_size = 2 * spad_count * 4; + spad_size = 2 * spad_count * sizeof(u32); if (!align) { ctrl_size = roundup_pow_of_two(ctrl_size); @@ -463,7 +463,7 @@ static int epf_ntb_config_spad_bar_alloc(struct epf_ntb *ntb) ctrl->num_mws = ntb->num_mws; ntb->spad_size = spad_size; - ctrl->db_entry_size = 4; + ctrl->db_entry_size = sizeof(u32); for (i = 0; i < ntb->db_count; i++) { ntb->reg->db_data[i] = 1 + i; @@ -535,7 +535,7 @@ static int epf_ntb_db_bar_init(struct epf_ntb *ntb) struct pci_epf_bar *epf_bar; void __iomem *mw_addr; enum pci_barno barno; - size_t size = 4 * ntb->db_count; + size_t size = sizeof(u32) * ntb->db_count; epc_features = pci_epc_get_features(ntb->epf->epc, ntb->epf->func_no, @@ -1121,11 +1121,11 @@ static int vntb_epf_link_enable(struct ntb_dev *ntb, static u32 vntb_epf_spad_read(struct ntb_dev *ndev, int idx) { struct epf_ntb *ntb = ntb_ndev(ndev); - int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * 4; + int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * sizeof(u32); u32 val; void __iomem *base = ntb->reg; - val = readl(base + off + ct + idx * 4); + val = readl(base + off + ct + idx * sizeof(u32)); return val; } @@ -1133,10 +1133,10 @@ static int vntb_epf_spad_write(struct ntb_dev *ndev, int idx, u32 val) { struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; - int off = ctrl->spad_offset, ct = ctrl->spad_count * 4; + int off = ctrl->spad_offset, ct = ctrl->spad_count * sizeof(u32); void __iomem *base = ntb->reg; - writel(val, base + off + ct + idx * 4); + writel(val, base + off + ct + idx * sizeof(u32)); return 0; } @@ -1148,7 +1148,7 @@ static u32 vntb_epf_peer_spad_read(struct ntb_dev *ndev, int pidx, int idx) void __iomem *base = ntb->reg; u32 val; - val = readl(base + off + idx * 4); + val = readl(base + off + idx * sizeof(u32)); return val; } @@ -1159,7 +1159,7 @@ static int vntb_epf_peer_spad_write(struct ntb_dev *ndev, int pidx, int idx, u32 int off = ctrl->spad_offset; void __iomem *base = ntb->reg; - writel(val, base + off + idx * 4); + writel(val, base + off + idx * sizeof(u32)); return 0; } From patchwork Tue Nov 1 16:57:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027236 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D37C4332F for ; Tue, 1 Nov 2022 16:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231299AbiKAQ6R (ORCPT ); Tue, 1 Nov 2022 12:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231305AbiKAQ6B (ORCPT ); Tue, 1 Nov 2022 12:58:01 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866051D64B; Tue, 1 Nov 2022 09:57:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fm2h9Jh6UJaW/wyLm05q4qQzHQlbqP2dNeBCDWPXqa4FQ5ghbvWxdKA0vOVzeSMFt9hOrGgec6agE95GPbkGsw3gu7WY1Qk4nXOJntXTpVOwLyqw/sMMSI3nfa9RVzECi6rR1fMGBdDlnv/IlmOwJKLQMcOlrcbSe4ThmMfKdDu64kzARzsT4AlL3uJCV7ys1hEfYFlLE2NKyHKvfiG38cafCivSgHCX9L9yKRyhevBpaAKxPXQT9YzmrvyDZil8jCT7cMgmlqgdZ7Y2AOlAylRReMp64GeftTv3Mfqs/FKYdMHfgRrODOsm+jCwFFxaiGigVBfsNBUdAfj3PVtPaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ioq8i8JEn9HvTPMXs4bwgq2Vsrd8In4CWHIXoks/i+E=; b=ZNMMTJi0ydImqpNXVUT718wTqSdYNnGT2PKYEGnU7ax8JZ7guGr3W3OnEcgy6OAMnbynPP8yxP7TcFQgq1gn6PrJ6vRb1vfiuyOPuucmSn9TX+icxos78+RzX93Sh+ZNmCUjuqOL4cudlRHtZKBH/RQqrkiz7jwLGOxXeflW+FpmlShRioz/vGwMvLCs97Cyy0ZaSu/yapeudKtWl4vjhAqTigFPzawYSw3KeMRiyEKmlrni1DVbcWZpQxcGaXtNpeTEXC8zX/xFOrbScThsKOcWHoDBz/O0J/Dx8xeRAT1qBG2mjqq8lw/inJ1cH46mRmv21A5KUVPM7QgoF1qTeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ioq8i8JEn9HvTPMXs4bwgq2Vsrd8In4CWHIXoks/i+E=; b=r37bcl9P9LEjKc1JmWV6sRpWuitvnms/FigdTkAdImekSnC0GhqmCSEZ5Q+D+Uj/FSfrKnZfnKXOs4MjbaD+Yphs4dbDTaONij8WycrGgdE7ShfTZGCepHREWkBapJTtPeVYhtYXCqXHkLDOx1B4gDpOHAdIPxGa1uHEt8pONxo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:53 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:53 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 6/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db Date: Tue, 1 Nov 2022 12:57:08 -0400 Message-Id: <20221101165709.983416-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: 38dd3ef1-7a5b-474c-6086-08dabc2a372a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ujNrmyKR/HpPvTLXweXxn1uMCz0MRPgxETl11FbuzqximUloyfHV9RH8hFIKexAGL6YHbAkGLfyzv6g7KQi9BpixYSp3jMC+zWtUGABP0Y5fawp+mGwZ0HnoKIRDGh/utErWksDb4iWeQDjYuKwtS219Z7BS3imD7a+u9XEJvzKTgMVp7xUYhv3OIEYB/MhAKIRUksodbM3MA9exTmb/ukBlziNbA70KwbXjZD+5Jihi8emWy7ywE7p4X9SSBgC6vFgiS3r7tjEtxQ6DDD/vOPuroVc65hKh0SNgYqbvTqeoEnJwAbqPRovaJvsoff2tbJyOfO5LM5hmFLvFoey27+VJPuZ0QgcCO0vdsjPC4w9Xo/qTJZIQskhD5e13g7Yh/Wowf79fO/bIlZb+3sVbX/b9fHs6SwsxmospGaATB83wJhDefSI/xm9wSA6xBsMb5/V+93LtSv/9L9dtUKT5ngdAsSzmPMs6BTftJqaVciXt2qqNs2uGZqh1+/TF0RlOVykFiiV6ZcwmY97JzeqyW4inz3NgOeeRstYH0EVnXrHqQYLtBvqNH5yad+JOXAZOXZ8xJGThlSL841Dm/GVWQ3swm7SKIANJI+Msga2eOkwTC2vIWdOdR/4WCpuLbc1nSou9bgjj2nHZ36Z3PI5WLJ6HLZeEBEkInQz7Zx+VqPM8caTvBw6N+OTxl1U/3SUIjl33cNBesc+Pt0EEgX7CyPFfTUYqkoN6Vp+aFSAedr1vGxRQH3JN/NlfjjdZEU3tBo/PMPXVUtAVDwR+dprnsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tazUIOimJbuh/duBCEBCbNAGRlI9AxAaAJ5ldjlbiUV2sRDJFZvuZd1sNGV37P165UYw1Ar0xy1oKupqRPBJrovuVKikl0eRPMvoHC82PZUK7Sfz0YcAJ4zjNd7Hgps2Q013vbMWIuERvoSxGe0Vx6oeRwdqoJIvI0/ApMJ9jr9L6IQ6kRUMDW8nJer11gDUbT8+ADrzscQqLT0eH/mJnNf0Hv8f2Ni6Nby0SiKUDXkv+HMvnXmNenIEIBaHgzdfxXRjVhCtoB2ixKbvLR9h2DA2PGJx5iQciy4gDy9tO5el6plVvTQfCtvMN1esNBiOBFH/BiUmo2Q0bbDa/OIzaxGoNGGPctY8uavLTJoaiq6ru8SQk/l/BMoZi4qBL6UzvXbHlk8M7QE3h9p4dh/Om+1v6/r9cfLdNKefCfU5hVr4MSO722Wkp7KpJadRLogqa9PG2djVMHTjRF5vPeP+hBkyTW8YIW2BwCbQNJa7tRO4bl5a9zLDx4gIhc3DRGpYV8K8BMTDLdDglq9AnAtPiItUdJTlGfjnpUmToWPvyfOD0ilsZLw7sL8URuFqpKztHrsAeyG5B5ndxyQnZmMsHBh76b+pXOiaRel4f9WWrJWQWOhHSoFbJDx10FKhvgL7EdFlmR3hoym0LS22WGT1ejKgLqr4Lf5lzk2rC7anuEkK4Bw3L4nmOWwzKdHqGSYVTyjBuFo1BSGmhdcjWeirGxdqFyH0BS7qMb2a/L9EfRXodlu0N7ojk5Iw4K1So4emb1y6kwblPM7IZ7o9TxlCc2ligcir4XTflYOUdfj7mCPqj2gK95MkM2P0CLUpwBuJjP0/PnG3w8je9k1mzVEa6yYEEhoMh4VRPUhn5dn4ShnkXyF1wlhC+joGjfm3Bn0rAqRgm4K9DNyQtWzsOcWW2WLvXGXR1ViawuRh6iaiRSAJrlRzX9nyjUTL4HzQ6IxLvhidhP7fAUDILmuTnOqcHiccaewWY5+oKsa5Pfnp2sjpKqay5fEXq30bAJ3ol56M5junXjtv4c3dCwBFGbvi8iiKCcq2TeVTm+d52PttT8GEvyLN13HAbRq0k8zeqdjuxSAov/oSMUDhRQJX23OsPv5Qw6mM0ZowD9Dx+qPA0RsnWrtszz3jFnHBQMX/YtbJ2nV/D3RXYl6ZnyFCa863q5CuuR8J0I6wAsyT1UjGW3Vqc21MSne0I4eL3YP8G81gKbeao5iL/aBgGD1gpymlvf6X9IVp2wgg8D/nd6usnqlRSXVtOnOGLZNf1XKoxOzT9kyzbwQULbo9jU6HBbSkRhKJPj3PAk/BESIABj8gmWeW+u7PlbjwUTBf0qguWDBT4fyV7MJCcsoYHsVXGeKiFjIx7rtJEefzdmtG042yXq5gn9IbdX5/wblZtP6nn63x3jo4LDqKMNGVfz66ImhzKHnL4atSLAyZQwIiE1dIiOGgKObhi3hRpfYVoeKEGOTI5BvkMkfGNR5lD+EC3Cdj4wCOjeUujv+yyOwETVSXv4ibNStKM8qK1SLhmZ6JMD+IhcZf6n9Jd5RjAhbkPEALhJfM6LJzMhiu9fA9fv4cAYbdY/KOp2f9IQKCu7D0GRtP X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38dd3ef1-7a5b-474c-6086-08dabc2a372a X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:52.9956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OioOmnxSwTVY6h3Uk2Mew2b9mDdM39VwyWPSP4P1IgHcHQJfNBDAzJrkXq6MX0lRrsuwfhrWXmcd7rj0EhDwkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li Using epf_db[i] instead of readl() because epf_db is in local system memory and allocated by dma_alloc_coherent(). Signed-off-by: Frank Li --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 54616281da9e..f896846ed970 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -136,7 +136,7 @@ struct epf_ntb { struct epf_ntb_ctrl *reg; - void __iomem *epf_db; + u32 *epf_db; phys_addr_t vpci_mw_phy[MAX_MW]; void __iomem *vpci_mw_addr[MAX_MW]; @@ -257,12 +257,10 @@ static void epf_ntb_cmd_handler(struct work_struct *work) ntb = container_of(work, struct epf_ntb, cmd_handler.work); for (i = 1; i < ntb->db_count; i++) { - if (readl(ntb->epf_db + i * sizeof(u32))) { - if (readl(ntb->epf_db + i * sizeof(u32))) - ntb->db |= 1 << (i - 1); - + if (ntb->epf_db[i]) { + ntb->db |= 1 << (i - 1); ntb_db_event(&ntb->ntb, i); - writel(0, ntb->epf_db + i * sizeof(u32)); + ntb->epf_db[i] = 0; } } From patchwork Tue Nov 1 16:57:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13027237 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27440C433FE for ; Tue, 1 Nov 2022 16:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231329AbiKAQ6b (ORCPT ); Tue, 1 Nov 2022 12:58:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbiKAQ6I (ORCPT ); Tue, 1 Nov 2022 12:58:08 -0400 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A41501D668; Tue, 1 Nov 2022 09:58:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yr94jpWqsRYjuqFVWg89f4ED5egXrLhwqubRWGBMfYr/QRGBkhs4QDMabzAHZTeMQTI12zltd9WIz8YhQp6WDIUzO6BRe4xsk2YDZOE08WUVSD5cbDIy8urAv6Cj+muMCxGxHTMOe/q15LfFvAQOkd1lKVX/nFV8j3zwYYpcMsu2pb9vf7OpAJ5XT/d8hGhMDctwpCYYi0SXjbycJLsWTEOjWEetGgEtZLZo9dSetAOkiTLDD6+LrJ790UYixaUU1ImwXWH2mEX8LpxguSrVI3NEdUYd/kLo2OMU4axOFZjLxuetd62MUKUuhMmD5RmFsNK8OuG4EYYZLmh6x4Rkpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFzFyx1vsGg3jLH40Ok722Zs8rNi57PQqnyZ7ZkJjRA=; b=jvlT/BIcUqqKZO6EjKAtZl5IKLgi9cvNJd8SdDc+BvdNpEAtWiyraG106TtsD5aOzN41fC81/zaQyMsVzF9qkaAgkxSQ97BnDNTEEBF0brJs1A/BDySjpd9M8aIedDz1Hf8rHGmqXiieqGzFB2PUXgVJA5E3gfRNJA0XJAxn5Y3odlAo2S7QUFE8bFX/MZueEk16WWfPz44hGYCF4IwzLdYBgGhI4bLQ8vPexMuCwRA7HVxl2TvGpB0iq3qVqLfnNvLvcmUdvNiGUcNWrJv+UrIvvYWkGgOLhpNXD90Nf+QfgTMSLL71i/WBh25gz+hHD4cD70NW6NTjOotCXLMqmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFzFyx1vsGg3jLH40Ok722Zs8rNi57PQqnyZ7ZkJjRA=; b=Lb7poSpMjR2FzIjGTlxhTEQQIdGFdwTe295JbRXXh65rsd0YGZbpN9QImDxFzLoRwM4CLm3JoLDyqWd5WXHSMvCZBMMTcnjMPv8TS/YTUbtZQpLg+uCoacUX7GJu4cZDGaYjnSwAqzXxhGaZtF7m7OPTTEPVPlY93tp5BcHu68c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Tue, 1 Nov 2022 16:57:56 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:57:56 +0000 From: Frank Li To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v15 7/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg Date: Tue, 1 Nov 2022 12:57:09 -0400 Message-Id: <20221101165709.983416-8-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com> References: <20221101165709.983416-1-Frank.Li@nxp.com> X-ClientProxiedBy: BYAPR05CA0007.namprd05.prod.outlook.com (2603:10b6:a03:c0::20) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: 5879f941-1ba3-4f14-2623-08dabc2a3983 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vyv/lPaEiikBwp8jNWWC0clo8TSaqzuaINmHuP7SiiRmdHks9dMQCyXaBX7Rt7JvKw0c8JrND9dct5gUJDy9glyYOQAo1qbTju1W08QLRbEOaM2GmTuckHE8X6/YQh3x429NVkPIcB4t3tb6oex2/zSzRdXU79Kf6UMcoGWEAdndg7uFn88xuREWo0dmhvl0EqDx/hAYBIg0qdWkZ5Xa+HssE3WRz1vV/OZ6o+9oDX2rjXVKQgQ7IzIT+oKlT13uiO6uXVHF0Kdky3sG1hqq3BnYytn1I4inXAlzRd7Jniz8pB6+rZ8KuBoB/5ejEBvY39byC90MQDGUH10xd3mTeWBKVlEz6dnoEpuB5BKmAVebAGEKrXb9zc4CH8LpNBEy7Um0HWEmeqSZVmQD0x86MfGeulDVEgcPNefAizghQD90sWPvzoK8yAKepBBQ6BDCiHXXECRSfZ9InBQyzhCb3ITVwfu9cKi7VycoZlwXjoZMZr4owgTlZuUJJjahyPgq62IUphi9dCkZcE181GNiZhmFIrLeJugYg2ntSJ/la9rk0/H1u6lWYJiLJHjzKk3kQB1jXgWoKRSIYNITl8TVr/n6sUlyI3A9FLZiIKQa3AGqKGbNT5xHuLpvlbRm9KCHJ5rzuRAkAxzuLpjdGH3uGijsl8y2HFINZWNwbiPzgwek9C7e+k2vzL5uQVX3hBoVU1AXO0Sh4IqWJhXglmq0b78AchOfMZ/lscOQ8G0NRUtWw65Zb+awNPDzYOw9V2omaXqQSh76YaSwvp3W49PC0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(38350700002)(38100700002)(6916009)(316002)(6666004)(2616005)(1076003)(7416002)(5660300002)(186003)(6486002)(2906002)(6512007)(26005)(41300700001)(6506007)(8676002)(4326008)(66476007)(66556008)(66946007)(52116002)(8936002)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /Pg+TfWiwtiGv/AHEU0TRL52ayOkxwzpXRvotrTSH9XxxTiNx7IPIiGgzbB0XQsXRwzrdWdPpB+q04emv6gxizdvWhjX7hTFOVYxLVPWP87AIoqIPFchzyzvW/ivlC96lezo24zQdXnOwZ07fJcFFG715bJTnSZ4Gyh6wr0GNP4kP3oS70DZo37at8cqHbYwNluRGWKSFlddZJxyIrEc0iCcqqdvB79Zth9suskpkUW+L1pGwCS8zW9MrHGRP92Yu/qULTbtHOcayuJr3YEzCCvQA/sFSRH5Ai87wQYFaxzZDw6cwYmAqIoaZUtMJsUWwmG040ZcFTNlu499mqjXenEKoNp3fdrc2bVgh9RDpoZcEF4TMwYboXL5LRwotORu2qT8yql3aRZhCwjTl/2QEZVqym4qQUpzR8pCdvvhpcE6HppBfMbcCBGmJGHtECOEb5qhA1nsLXdZKKfcanjfwtfnWatson47FW21JU+EW2Xuvk61PJ3Yqso+vjrxKtlOGBYU0LPk/p72aguQ+umThh+SZCkhLKajzY2KXT1i7DFvWyUPJDi5qEWoXNivA3mVuz6hojXa0MxQ+SuCK7WkMuBLEeQ6qR4leQC0aVR+0SaVWecClSM5Yo+jN3CJqWXca9L3PT2BXUPQFootdbSScrqHYntQoeT1SRNQJwC/vZwepf0rUexLUSSB7LGjN3cik06o3Btt9pPElUZHhqRZEGtaeB5sKtsm02XE8/b0XDjuikP55DVrGb8AaOV8zIrC7rIAW5VMne5Y26dKr3jpK7BXBaUgqbmjjOyJjFVTqI5WaNe+5TZe2ZG+VCYDiHkdBbCm1FJjK+qzPjB3aA0AKZR+NyhwgTgJjCIcL16rige4HfrqtJQzE1Dme/8sVijCo5R6uTzJ5OhQdEhO/PFL3Njg1n6eH4ApQPRry64ZtuVRY93ViUPb2hLO4iZbE2x4LPz5o6JtQCIuPJNLUGxIi/fQd0BGa4apddhPYV7WHXsp2+eWUMgi4FY0kQJTBFIttEY/VNwQjSy/l0hhOxOWCwgLbCLO9D3QGch+gvMcf6H6KOX53Xe0Uj2zb5j0CjAqhegSW3sgxoYHShmM5sC13wEFQ5+hFTlKrbuyEOnGBGdhGa5YKNj/U8DIyCBOEkERXC9z6uevd/eSV3Iw4irrXQwzruON55cMabTAwCRHOMtWxHYHhvgm3midpqMvfQw11+0nRTOeQ8Wpv35HqmrUZZSsNWqqAJQyF37p4y4Lv9Ym5HMf+RV5P1ei5hKDZPZU3eGUGNC/xV9ab5VGUr2p3R8IMdge5Ws3gx9MQq/5qzWJzNdxJF7JvU7CJ+SyKckppAxxeWkoGGJygeCRXoWXbx1ka6xWPkHoMClKeF8JZifgeiEws8sTmmtpVume4yq5EbIu2pvpb3xjp3RtF27+CwhsJCm6dGW9AfVwviYScwL5PSgIbc5jtxWURlYXA4mkZC7U/U35rovjahKLQ3Po/4PtzU0lexDMbaxW+wUjrWeyewwpZSnByQkP7iB8TdMCDpYxlco7pF6o17tOnYhpslbG9ALn6I68BKnTNOQrnBVx9+I0L91w0GokpLZ4IwSB X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5879f941-1ba3-4f14-2623-08dabc2a3983 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 16:57:56.7453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oNPK4q1KdoJbIrmBbhQIG7ffAqsd7Y1UFz9B/bscfVml114DEFepBS/j0c49oi33xW7d7xO97n2gpKq8s1nQ1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Frank Li pci-epf-vntb.c:1128:33: sparse: expected void [noderef] __iomem *base pci-epf-vntb.c:1128:33: sparse: got struct epf_ntb_ctrl *reg Add __iomem type convert in vntb_epf_peer_spad_read() and vntb_epf_peer_spad_write(). Reported-by: kernel test robot Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index f896846ed970..04698e7995a5 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1121,7 +1121,7 @@ static u32 vntb_epf_spad_read(struct ntb_dev *ndev, int idx) struct epf_ntb *ntb = ntb_ndev(ndev); int off = ntb->reg->spad_offset, ct = ntb->reg->spad_count * sizeof(u32); u32 val; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; val = readl(base + off + ct + idx * sizeof(u32)); return val; @@ -1132,7 +1132,7 @@ static int vntb_epf_spad_write(struct ntb_dev *ndev, int idx, u32 val) struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset, ct = ctrl->spad_count * sizeof(u32); - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; writel(val, base + off + ct + idx * sizeof(u32)); return 0; @@ -1143,7 +1143,7 @@ static u32 vntb_epf_peer_spad_read(struct ntb_dev *ndev, int pidx, int idx) struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; u32 val; val = readl(base + off + idx * sizeof(u32)); @@ -1155,7 +1155,7 @@ static int vntb_epf_peer_spad_write(struct ntb_dev *ndev, int pidx, int idx, u32 struct epf_ntb *ntb = ntb_ndev(ndev); struct epf_ntb_ctrl *ctrl = ntb->reg; int off = ctrl->spad_offset; - void __iomem *base = ntb->reg; + void __iomem *base = (void __iomem *)ntb->reg; writel(val, base + off + idx * sizeof(u32)); return 0;