From patchwork Mon Nov 7 07:34:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13033971 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095B1C4332F for ; Mon, 7 Nov 2022 07:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230504AbiKGHfc (ORCPT ); Mon, 7 Nov 2022 02:35:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbiKGHfb (ORCPT ); Mon, 7 Nov 2022 02:35:31 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF0D438BB for ; Sun, 6 Nov 2022 23:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667806528; x=1699342528; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=A3q9YR+y9h1VgbsvrXPlSicbf70nTtfbkGCgrH+7dA4=; b=P9irU0mn9zR/QKs67iIhgrs37tw4R8Fbx7vQngyjhzy2WUW14iEqRCSR oSHfttDJ2Q0TH1zQxDfSWyTsPdHNp52Odb2kdEEJTZAWuNSGTuMdcX82q HzyVnsVh30Oz0/l0+6GLCOwyg/jQZTk/AIreQ9MvkPLpWVCH455ann/1r ixf8p5UAZsXTqCvOzclTGvLz4sgoDpYRgxlT31ChiRyAPYQp7loljZoH+ Kr8PBNAnc4kKvBlvTB543WASEJtgp2mo/Oi7RKWvQ7fyv8Sl0fK9crjMJ dNPrcWfAHhwUkbgRUbY9/eSI2nMgJr1B9DTuRbrtYaPwoED8MB+a3JYF6 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="297838564" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="297838564" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 23:35:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="638268561" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="638268561" Received: from bswcg005.iind.intel.com ([10.224.174.25]) by fmsmga007.fm.intel.com with ESMTP; 06 Nov 2022 23:35:25 -0800 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, linuxwwan@intel.com, M Chetan Kumar Subject: [PATCH net V2 1/4] net: wwan: iosm: fix memory leak in ipc_pcie_read_bios_cfg Date: Mon, 7 Nov 2022 13:04:49 +0530 Message-Id: <20221107073449.1978178-1-m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar ipc_pcie_read_bios_cfg() is using the acpi_evaluate_dsm() to obtain the wwan power state configuration from BIOS but is not freeing the acpi_object. The acpi_evaluate_dsm() returned acpi_object to be freed. Free the acpi_object after use. Fixes: 7e98d785ae61 ("net: iosm: entry point") Signed-off-by: M Chetan Kumar --- v2: * No Change. --- drivers/net/wwan/iosm/iosm_ipc_pcie.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c index 31f57b986df2..97cb6846c6ae 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c @@ -232,6 +232,7 @@ static void ipc_pcie_config_init(struct iosm_pcie *ipc_pcie) */ static enum ipc_pcie_sleep_state ipc_pcie_read_bios_cfg(struct device *dev) { + enum ipc_pcie_sleep_state sleep_state = IPC_PCIE_D0L12; union acpi_object *object; acpi_handle handle_acpi; @@ -242,12 +243,16 @@ static enum ipc_pcie_sleep_state ipc_pcie_read_bios_cfg(struct device *dev) } object = acpi_evaluate_dsm(handle_acpi, &wwan_acpi_guid, 0, 3, NULL); + if (!object) + goto default_ret; + + if (object->integer.value == 3) + sleep_state = IPC_PCIE_D3L2; - if (object && object->integer.value == 3) - return IPC_PCIE_D3L2; + kfree(object); default_ret: - return IPC_PCIE_D0L12; + return sleep_state; } static int ipc_pcie_probe(struct pci_dev *pci, From patchwork Mon Nov 7 07:35:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13033972 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E80AFC433FE for ; Mon, 7 Nov 2022 07:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiKGHfq (ORCPT ); Mon, 7 Nov 2022 02:35:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231398AbiKGHfk (ORCPT ); Mon, 7 Nov 2022 02:35:40 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B57D5FB4 for ; Sun, 6 Nov 2022 23:35:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667806539; x=1699342539; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8kawSVDkbfcBgrFdvOzOhUDkcdm2cKaY6bTMZJ+ESrc=; b=eT32b/r5qIr0Ip1HIsolPTQQUjSFXF50GiTsCn4/GSXo6/KTgESHxC6D z4v107joC9jKh6Bxe1ulZ3Em3iDuSfPX9s8ylr+Shu9m0FPveON+AI2EF zondz+lfeuGjdJUqBcxowbRT6R9UnC1Mkj+SYKqiNMWXzmAQK6czy2v7f P7zfbEvmf0J8CwvBEZBBkog+cmIncFk8dkXRxdtcrApfFdtPK35UxkHM+ jM6drWsRqlOWFQSOO8BgssPBUYXXuII33RIVWaVZqWYYu/SyFrNZuBcsv 4YVEjWA7kHROSpoQHlz+CEGGhRsd+kcZK/1TkmMzyLHCgr/s4I0YjF6zc A==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="372465633" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="372465633" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 23:35:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="638268595" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="638268595" Received: from bswcg005.iind.intel.com ([10.224.174.25]) by fmsmga007.fm.intel.com with ESMTP; 06 Nov 2022 23:35:36 -0800 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, linuxwwan@intel.com, M Chetan Kumar Subject: [PATCH net V2 2/4] net: wwan: iosm: fix driver not working with INTEL_IOMMU disabled Date: Mon, 7 Nov 2022 13:05:02 +0530 Message-Id: <20221107073502.1978194-1-m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar With INTEL_IOMMU disable config or by forcing intel_iommu=off from grub some of the features of IOSM driver like browsing, flashing & coredump collection is not working. When driver calls DMA API - dma_map_single() for tx transfers. It is resulting in dma mapping error. Set the device DMA addressing capabilities using dma_set_mask() and remove the INTEL_IOMMU dependency in kconfig so that driver follows the platform config either INTEL_IOMMU enable or disable. Fixes: f7af616c632e ("net: iosm: infrastructure") Signed-off-by: M Chetan Kumar --- v2: * Add dependency on PCI in kconfig file to resolve kernel test robot reported errors. --- drivers/net/wwan/Kconfig | 2 +- drivers/net/wwan/iosm/iosm_ipc_pcie.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig index 3486ffe94ac4..ac4d73b5626f 100644 --- a/drivers/net/wwan/Kconfig +++ b/drivers/net/wwan/Kconfig @@ -94,7 +94,7 @@ config RPMSG_WWAN_CTRL config IOSM tristate "IOSM Driver for Intel M.2 WWAN Device" - depends on INTEL_IOMMU + depends on PCI select NET_DEVLINK select RELAY if WWAN_DEBUGFS help diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/iosm_ipc_pcie.c index 97cb6846c6ae..d3d34d1c4704 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c @@ -259,6 +259,7 @@ static int ipc_pcie_probe(struct pci_dev *pci, const struct pci_device_id *pci_id) { struct iosm_pcie *ipc_pcie = kzalloc(sizeof(*ipc_pcie), GFP_KERNEL); + int ret; pr_debug("Probing device 0x%X from the vendor 0x%X", pci_id->device, pci_id->vendor); @@ -291,6 +292,12 @@ static int ipc_pcie_probe(struct pci_dev *pci, goto pci_enable_fail; } + ret = dma_set_mask(ipc_pcie->dev, DMA_BIT_MASK(64)); + if (ret) { + dev_err(ipc_pcie->dev, "Could not set PCI DMA mask: %d", ret); + return ret; + } + ipc_pcie_config_aspm(ipc_pcie); dev_dbg(ipc_pcie->dev, "PCIe device enabled."); From patchwork Mon Nov 7 07:35:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13033973 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D10BC4332F for ; Mon, 7 Nov 2022 07:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231415AbiKGHf6 (ORCPT ); Mon, 7 Nov 2022 02:35:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231448AbiKGHfv (ORCPT ); Mon, 7 Nov 2022 02:35:51 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DE7D5F8C for ; Sun, 6 Nov 2022 23:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667806550; x=1699342550; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cqAL1mb7WsNpRNgxXU3Crgm6BmqLtBXu5eKVs11cjQA=; b=VdHeGN7fb2p8R+Q0VQF9ORulfH77U8WE4OfWLMcg/COkHqYpRzTLzLfD ddZFLi+KSrEdvwuQyTbM+TbUoyIge/gdf/hx5jSLmA2W21geTXQ2jRsSr pDQ1O3N45xCV4h6P4yt0tU06jyegM/r5HUMDfFwQzR+jiW1Gmfd3IwcPe tatE6o+lntERO1JXm84hhM+sv5azspAvIqor4ox8uTW/XBZZFpSu4Y2Nd 0tQ69Y3yadEd+uvAHcKzWwqQS6CDJBaKDC6Gl5aKYWVNV2ne93D9ogP5n g8IBvdUsAFAphhp6gOD0n5Tj3OnMOKI2amBxBDsR/uM2ErwXJThQq1eCk Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="337064296" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="337064296" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 23:35:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="638268628" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="638268628" Received: from bswcg005.iind.intel.com ([10.224.174.25]) by fmsmga007.fm.intel.com with ESMTP; 06 Nov 2022 23:35:46 -0800 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, linuxwwan@intel.com, M Chetan Kumar Subject: [PATCH net V2 3/4] net: wwan: iosm: fix invalid mux header type Date: Mon, 7 Nov 2022 13:05:13 +0530 Message-Id: <20221107073513.1978209-1-m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar Data stall seen during peak DL throughput test & packets are dropped by mux layer due to invalid header type in datagram. During initlization Mux aggregration protocol is set to default UL/DL size and TD count of Mux lite protocol. This configuration mismatch between device and driver is resulting in data stall/packet drops. Override the UL/DL size and TD count for Mux aggregation protocol. Fixes: 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support") Signed-off-by: M Chetan Kumar --- v2: * No Change. --- drivers/net/wwan/iosm/iosm_ipc_imem_ops.c | 8 ++++++++ drivers/net/wwan/iosm/iosm_ipc_mux.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c b/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c index b7f9237dedf7..66b90cc4c346 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c +++ b/drivers/net/wwan/iosm/iosm_ipc_imem_ops.c @@ -91,6 +91,14 @@ void ipc_imem_wwan_channel_init(struct iosm_imem *ipc_imem, } ipc_chnl_cfg_get(&chnl_cfg, ipc_imem->nr_of_channels); + + if (ipc_imem->mmio->mux_protocol == MUX_AGGREGATION && + ipc_imem->nr_of_channels == IPC_MEM_IP_CHL_ID_0) { + chnl_cfg.ul_nr_of_entries = IPC_MEM_MAX_TDS_MUX_AGGR_UL; + chnl_cfg.dl_nr_of_entries = IPC_MEM_MAX_TDS_MUX_AGGR_DL; + chnl_cfg.dl_buf_size = IPC_MEM_MAX_ADB_BUF_SIZE; + } + ipc_imem_channel_init(ipc_imem, IPC_CTYPE_WWAN, chnl_cfg, IRQ_MOD_OFF); diff --git a/drivers/net/wwan/iosm/iosm_ipc_mux.h b/drivers/net/wwan/iosm/iosm_ipc_mux.h index cd9d74cc097f..9968bb885c1f 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_mux.h +++ b/drivers/net/wwan/iosm/iosm_ipc_mux.h @@ -10,6 +10,7 @@ #define IPC_MEM_MAX_UL_DG_ENTRIES 100 #define IPC_MEM_MAX_TDS_MUX_AGGR_UL 60 +#define IPC_MEM_MAX_TDS_MUX_AGGR_DL 60 #define IPC_MEM_MAX_ADB_BUF_SIZE (16 * 1024) #define IPC_MEM_MAX_UL_ADB_BUF_SIZE IPC_MEM_MAX_ADB_BUF_SIZE From patchwork Mon Nov 7 07:35:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kumar, M Chetan" X-Patchwork-Id: 13033974 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13B1C4332F for ; Mon, 7 Nov 2022 07:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbiKGHgF (ORCPT ); Mon, 7 Nov 2022 02:36:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbiKGHgD (ORCPT ); Mon, 7 Nov 2022 02:36:03 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFD6C5580 for ; Sun, 6 Nov 2022 23:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667806562; x=1699342562; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0o6fW2n+JMtaYNzmTuj6whxxJNDRJAjmoyj3+vvygeA=; b=GF4V0RhnXqIzDXl4P5ihxJFZYXxHuDdntroMgA3f+BYnfHkcVOESluoM MWrA57Q1m3YSwSG6ucgyD+IuJjmN6681y8b9npMWqkLDixbFVxhZavkoQ M9V6XmlzHSSyYYTdvV2oEAhdFTnFfADRNdGI3Mi8za9W/evhhqyXC8g5O Yak3Ip8oOFf6amFZ/9HHmSMuVaGQL5pztHuu6qNycdSMYD/7dw7A4iG48 U5ySFMKv0qZLstpe+GV7x3KDLWxm3fzIrGZBcvII6in5X7wkTbJ5wnBbV 3v7006nMrBp/g3qjHSBWjj+CMWC4bqHkcVX1W/NIcy7VVqrB+P0kH0IWt A==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="307970562" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="307970562" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2022 23:36:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="635806399" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="635806399" Received: from bswcg005.iind.intel.com ([10.224.174.25]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2022 23:35:58 -0800 From: m.chetan.kumar@linux.intel.com To: netdev@vger.kernel.org Cc: kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, edumazet@google.com, pabeni@redhat.com, linuxwwan@intel.com, M Chetan Kumar , kernel test robot Subject: [PATCH net V2 4/4] net: wwan: iosm: fix kernel test robot reported errors Date: Mon, 7 Nov 2022 13:05:24 +0530 Message-Id: <20221107073524.1978224-1-m.chetan.kumar@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: M Chetan Kumar Include linux/vmalloc.h in iosm_ipc_coredump.c & iosm_ipc_devlink.c to resolve kernel test robot errors. Reported-by: kernel test robot Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_coredump.c | 1 + drivers/net/wwan/iosm/iosm_ipc_devlink.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/wwan/iosm/iosm_ipc_coredump.c b/drivers/net/wwan/iosm/iosm_ipc_coredump.c index 9acd87724c9d..26ca30476f40 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_coredump.c +++ b/drivers/net/wwan/iosm/iosm_ipc_coredump.c @@ -2,6 +2,7 @@ /* * Copyright (C) 2020-2021 Intel Corporation. */ +#include #include "iosm_ipc_coredump.h" diff --git a/drivers/net/wwan/iosm/iosm_ipc_devlink.c b/drivers/net/wwan/iosm/iosm_ipc_devlink.c index 17da85a8f337..2fe724d623c0 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_devlink.c +++ b/drivers/net/wwan/iosm/iosm_ipc_devlink.c @@ -2,6 +2,7 @@ /* * Copyright (C) 2020-2021 Intel Corporation. */ +#include #include "iosm_ipc_chnl_cfg.h" #include "iosm_ipc_coredump.h"