From patchwork Mon Nov 7 09:38:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 13034201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFFBC4332F for ; Mon, 7 Nov 2022 09:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231805AbiKGJkH (ORCPT ); Mon, 7 Nov 2022 04:40:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231818AbiKGJjp (ORCPT ); Mon, 7 Nov 2022 04:39:45 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C4FA175A1; Mon, 7 Nov 2022 01:39:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1158B80E80; Mon, 7 Nov 2022 09:39:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0DD9C433D7; Mon, 7 Nov 2022 09:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667813982; bh=CfkW4HZMGb82FWcVBRYkBpO/da3oADoIeJLatSkDO6M=; h=From:To:Cc:Subject:Date:From; b=gaFgp/wli4XgkGktMxXWtXYUbB4YM8gn5PlorYTHKLuaHKbpzpQHjSg8dpK5NWvjD UukZps+VzfnddEXZefSglSKsVd99oRq7zMoPXQ2AYzbeBQ/iEPCvMY0tuMSOGFZxJI rk9X1sW1uT34DqID83Nb8Dwls9GdxOiqFkebDN8MdzhRia1a002a5ptedhLePtyEfo +tue+OMUhLAgk2s3MYzfI1gdaWo0usB5sXkH0fUdKD5iWDAkJ10Ov2DiUv1CgDClqk QPO/qOc06ZjUwop+r78Afm88gajn94cCjOdAmfOy0eQHi3FWlxA578o4P21/9T/mMK hecNSrzxIUqTQ== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH] generic: check direct IO writes with io_uring and O_DSYNC are durable Date: Mon, 7 Nov 2022 09:38:58 +0000 Message-Id: X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Filipe Manana Test that direct IO writes with io_uring and O_DSYNC are durable if a power failure happens after they complete. This is motivated by a regression on btrfs, affecting 5.15 stable kernels and kernels up to 6.0, where often the writes were not persisted (same behaviour as if O_DSYNC was not provided). This was recently fixed by the following commit: 51bd9563b678 ("btrfs: fix deadlock due to page faults during direct IO reads and writes") Signed-off-by: Filipe Manana Reviewed-by: Zorro Lang --- tests/generic/703 | 104 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/703.out | 2 + 2 files changed, 106 insertions(+) create mode 100755 tests/generic/703 create mode 100644 tests/generic/703.out diff --git a/tests/generic/703 b/tests/generic/703 new file mode 100755 index 00000000..39ae3773 --- /dev/null +++ b/tests/generic/703 @@ -0,0 +1,104 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2022 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 703 +# +# Test that direct IO writes with io_uring and O_DSYNC are durable if a power +# failure happens after they complete. +# +. ./common/preamble +_begin_fstest auto quick log prealloc io_uring + +_cleanup() +{ + _cleanup_flakey + cd / + rm -r -f $tmp.* +} + +. ./common/filter +. ./common/dmflakey + +fio_config=$tmp.fio +fio_out=$tmp.fio.out +test_file="${SCRATCH_MNT}/foo" + +[ $FSTYP == "btrfs" ] && + _fixed_by_kernel_commit 8184620ae212 \ + "btrfs: fix lost file sync on direct IO write with nowait and dsync iocb" + +_supported_fs generic +# We allocate 256M of data for the test file, so require a higher size of 512M +# which gives a margin of safety for a COW filesystem like btrfs (where metadata +# is always COWed). +_require_scratch_size $((512 * 1024)) +_require_odirect +_require_io_uring +_require_dm_target flakey +_require_xfs_io_command "falloc" + +cat >$fio_config <>$seqres.full 2>&1 +_require_metadata_journaling $SCRATCH_DEV +_init_flakey +_mount_flakey + +# We do 64K writes in the fio job. +_require_congruent_file_oplen $SCRATCH_MNT $((64 * 1024)) + +touch $test_file + +# On btrfs IOCB_NOWAIT writes can only be done on NOCOW files, so enable +# nodatacow on the file if we are running on btrfs. +if [ $FSTYP == "btrfs" ]; then + _require_chattr C + $CHATTR_PROG +C $test_file +fi + +$XFS_IO_PROG -c "falloc 0 256M" $test_file + +# Persist everything, make sure the file exists after power failure. +sync + +echo -e "Running fio with config:\n" >> $seqres.full +cat $fio_config >> $seqres.full + +$FIO_PROG $fio_config --output=$fio_out + +echo -e "\nOutput from fio:\n" >> $seqres.full +cat $fio_out >> $seqres.full + +digest_before=$(_md5_checksum $test_file) + +# Simulate a power failure and mount the filesystem to check that all the data +# previously written are available. +_flakey_drop_and_remount + +digest_after=$(_md5_checksum $test_file) + +if [ "$digest_after" != "$digest_before" ]; then + echo "Error: not all file data got persisted." + echo "Digest before power failure: $digest_before" + echo "Digest after power failure: $digest_after" +fi + +_unmount_flakey + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/generic/703.out b/tests/generic/703.out new file mode 100644 index 00000000..fba62571 --- /dev/null +++ b/tests/generic/703.out @@ -0,0 +1,2 @@ +QA output created by 703 +Silence is golden