From patchwork Thu Aug 9 12:45:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10561389 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A4771515 for ; Thu, 9 Aug 2018 12:45:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5768E2B063 for ; Thu, 9 Aug 2018 12:45:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4BF562B099; Thu, 9 Aug 2018 12:45:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E65742B063 for ; Thu, 9 Aug 2018 12:45:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14FB36E716; Thu, 9 Aug 2018 12:45:54 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id B910D6E717 for ; Thu, 9 Aug 2018 12:45:52 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id x5-v6so2832392edr.0 for ; Thu, 09 Aug 2018 05:45:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nABIuj44wYueJJ7u7vZ3CLeFIkL/+YdxVrrCq5iJksE=; b=ILHAX0MFCp6uV3kYyeK1x4tJ97ozGLz69OSaV2lSdO+MAs/I5T3diG633159LxYcs9 0I1xxa7tUIXx33Pl9OJdy0aM3eOpRnovUz1cilZtqtTDwMuCKslL7128ekWiVTcrO7+s x5kT1c6XtdsY7mfnwOiMOyrA5kA8SRH6LwXsdMN4rH7DIgIx6IFu5/uFXOGDjLLlO5Hm H4OmAxLuQHsYZMbVkqDzMkqlVygoa+WvDozkM7zpdbATr7SjRmzg/ycRLadnG6ASrEY9 ah9mFUlFxxEHt/K1bjI8ypotsDb7U3a8dCpMf0io/VPFcUJOL/QuC4okBwNrkTovIFED schQ== X-Gm-Message-State: AOUpUlF2ha6PdksABdAaNxS0oUzxFg3pN3z154JJTcHtmux7fFyFoMOZ KyeeGzNlqXz44akZM9sBRCtDhdFdcF0= X-Google-Smtp-Source: AA+uWPxjG6VKWVST29CA0zRsiOCO2ndQSJr/FiI2jA5sOQ7E3vCb1aLLbtHf/iRkY+4Wx8PRJfszSQ== X-Received: by 2002:aa7:d786:: with SMTP id s6-v6mr3023447edq.228.1533818751024; Thu, 09 Aug 2018 05:45:51 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56fc:0:d707:d7d8:b180:96e5]) by smtp.gmail.com with ESMTPSA id r5-v6sm2339410edo.75.2018.08.09.05.45.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 05:45:50 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Thu, 9 Aug 2018 14:45:44 +0200 Message-Id: <20180809124544.9250-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180704092909.6599-5-daniel.vetter@ffwll.ch> References: <20180704092909.6599-5-daniel.vetter@ffwll.ch> Subject: [Intel-gfx] [PATCH] drm/vgem: Remove unecessary dma_fence_ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Daniel Vetter , DRI Development , Cihangir Akturk MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Also remove the ->signaled callback, vgem can't peek ahead with a fastpath, returning false is the default implementation. v2: Protect the meaningful space! (Chris) Signed-off-by: Daniel Vetter Cc: Kees Cook Cc: Cihangir Akturk Cc: Chris Wilson Cc: Sean Paul Cc: Daniel Vetter Reviewed-by: Chris Wilson --- drivers/gpu/drm/vgem/vgem_fence.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c index b28876c222b4..e6ee71323a66 100644 --- a/drivers/gpu/drm/vgem/vgem_fence.c +++ b/drivers/gpu/drm/vgem/vgem_fence.c @@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct dma_fence *fence) return "unbound"; } -static bool vgem_fence_signaled(struct dma_fence *fence) -{ - return false; -} - -static bool vgem_fence_enable_signaling(struct dma_fence *fence) -{ - return true; -} - static void vgem_fence_release(struct dma_fence *base) { struct vgem_fence *fence = container_of(base, typeof(*fence), base); @@ -76,9 +66,6 @@ static void vgem_fence_timeline_value_str(struct dma_fence *fence, char *str, static const struct dma_fence_ops vgem_fence_ops = { .get_driver_name = vgem_fence_get_driver_name, .get_timeline_name = vgem_fence_get_timeline_name, - .enable_signaling = vgem_fence_enable_signaling, - .signaled = vgem_fence_signaled, - .wait = dma_fence_default_wait, .release = vgem_fence_release, .fence_value_str = vgem_fence_value_str,