From patchwork Thu Nov 10 13:34:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rong Tao X-Patchwork-Id: 13038796 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD5BC43219 for ; Thu, 10 Nov 2022 13:34:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9F666B0071; Thu, 10 Nov 2022 08:34:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D50656B0072; Thu, 10 Nov 2022 08:34:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17196B0074; Thu, 10 Nov 2022 08:34:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A74636B0071 for ; Thu, 10 Nov 2022 08:34:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8729640AC2 for ; Thu, 10 Nov 2022 13:34:33 +0000 (UTC) X-FDA: 80117627226.07.EB0CD0A Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 383A080011 for ; Thu, 10 Nov 2022 13:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1668087266; bh=eY7h4fhFTfwfC9Nhrrjq36hOBtSMKTwHQ0XH45yPyYA=; h=From:To:Cc:Subject:Date; b=jW0xUs58Ma6Hzl6RLY2VbdzV26A1lw7/ViwGucjFGDXxA7py2Wcytu04lzpLdXSY6 hqd4jp5p9p5XJeTzCF8xAGB17RGUIwlSzlTTUeFmv+6DgflAwvoShTzeH0775O9uuD CBGLr2MYmGDJrL6DyY2yRUCxxaiDzhUHvdHDml+I= Received: from localhost.localdomain ([111.199.191.46]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id 8972E81A; Thu, 10 Nov 2022 21:34:23 +0800 X-QQ-mid: xmsmtpt1668087263te4c0uqb5 Message-ID: X-QQ-XMAILINFO: MCKLvPxUEMECfDLJ42pOPtys1rQM8Gm7uOj/ovE65laisNHzQg0mOva9tNmM3V lxbEHMODtvFjD+2wfQta0kK+RYHMKDmYM0kwPDGYMhuG2IJEY+Yidi7wGU3bR40D5B9Qx/DBZ1Mk K05fuzfEU28zJUDc5gdULKgHlMkZFX4tQvxZglqhgSgMtDcbgkYGeWB9OaZ/NAeFBn7BQlQ+ybRD Uw0f3WEiAd03jBWeYU0t1EGpUNPwBnchI9oBQXujRpWJKkSPLPO3lHCA+mqeMXXhxs39fKgGFtMj m3uEdIB6gDyy1RNJKArlBau7L/Du73VfwP6hmwh/Ussgr9sLNFQKkLo5iidcI8eFLBLzFeMHzZzq Vbr38x8oUQazxYWvICYz9VYmuAYw5IrflhQNrPqMhh2ixW/87qJI8cdkcuvEWPJ8jTB+2u9ozAZk FWwPgRAj0KVjqgigCmvqFEKC9fx8Da/fqXqST3k3ehSrkgJkZVb4zdEqtLZwQ5BMYAZYmYd0BWiK oEeLCLGAPbKghD94iRxd15WZGr7ylK7HFkAPhij2gdZQqFx+qKvcQm2NhITvsp53S5AzneXze5al MUmZJKmmnN6gb9kYDfvN7Q2moGTWh6QLOGnR4RqOpXqal9WPBzITW8gY/DU2flsr91lBcflX6t8d uvMWj3qBsyVq3wtdGSS/gzU2430tq6lUTh5UXTPOqcSB7pMPozZllCDA0lk6TKZXq6vbpFx1v3o6 HzInbE65NyRFfmRGYaB7Xe4auglqj2qk/UGVXCFw62ZQ8eeOAsgx4d5htDWdsYxQrXACgBGRDbsq rbw4B0XOK5mNKJOl/7kW3VOtIhVUdPsMP0niDNlJr/BFPETQfngVj8wrShvgpTLaHFEeLWlsa1nI lj/MHlvZWVzmy+PN20XQgPuX/+BnoGhr2tktr5PZAgRdeTKcAOsw5mc3UEFbmNW+MRjaWD0Q7FeO KmpKJOOxzoH/Krn8lcl9lqYmUDsxVpzNFzMKC8mrysvbu+8c5VJA== From: Rong Tao To: sj@kernel.org Cc: Rong Tao , Shuah Khan , damon@lists.linux.dev (open list:DATA ACCESS MONITOR), linux-mm@kvack.org (open list:DATA ACCESS MONITOR), linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] selftests/damon: Fix unnecessary compilation warnings Date: Thu, 10 Nov 2022 21:34:18 +0800 X-OQ-MSGID: <20221110133418.17054-1-rtoax@foxmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668087272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=eY7h4fhFTfwfC9Nhrrjq36hOBtSMKTwHQ0XH45yPyYA=; b=luwCLOloqRB1nP1V662IZajg/HVmBK2M1Shqhi9tyo4ta3VJhTUsGBhsx4Rg+Ie00qGBHc lwKmmRC+Zk3mvYUG6uCQFTOnTshrSvehb2AnkVS1t+yzw46H2Rt+eh1ADWVFK84CdQHXSO TLSGRHKTMwJPe3Y+1mkVVQjRbqzSJyA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=jW0xUs58; spf=pass (imf02.hostedemail.com: domain of rtoax@foxmail.com designates 162.62.57.49 as permitted sender) smtp.mailfrom=rtoax@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668087272; a=rsa-sha256; cv=none; b=F5BvBIdVdIY338K9+UrA+p0HkRbTn/0rOCEDrhujRHM1KcaU4CiRZRGh6eHMcECXSLwLym jLoeXZ875yc1CMguHGrdmHZ/vRalHFZT3qo2pLgn2fuDpqhO9asZkiFtPMjBBSdaBUqvqr CQflqScyJy1AI3kuoNCgHCVaFTqK3GQ= X-Rspamd-Queue-Id: 383A080011 X-Rspam-User: X-Rspamd-Server: rspam08 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=jW0xUs58; spf=pass (imf02.hostedemail.com: domain of rtoax@foxmail.com designates 162.62.57.49 as permitted sender) smtp.mailfrom=rtoax@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com X-Stat-Signature: zmhk336g1o4o1wtaut59cktoqpqatisc X-HE-Tag: 1668087271-725326 X-Bogosity: Ham, tests=bogofilter, spamicity=0.150735, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Rong Tao When testing overflow and overread, there is no need to keep unnecessary compilation warnings, we should simply ignore them. How to reproduce the problem: $ make -C tools/testing/selftests/ gcc huge_count_read_write.c -o /home/sd/Git/linux/tools/testing/selftests/damon/huge_count_read_write huge_count_read_write.c: In function ‘write_read_with_huge_count’: huge_count_read_write.c:23:9: warning: ‘write’ reading 4294967295 bytes from a region of size 1 [-Wstringop-overread] 23 | write(filedesc, "", 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:378:16: note: in a call to function ‘write’ declared with attribute ‘access (read_only, 2, 3)’ 378 | extern ssize_t write (int __fd, const void *__buf, size_t __n) __wur | ^~~~~ huge_count_read_write.c:25:15: warning: ‘read’ writing 4294967295 bytes into a region of size 25 overflows the destination [-Wstringop-overflow=] 25 | ret = read(filedesc, buf, 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ huge_count_read_write.c:14:14: note: destination object ‘buf’ of size 25 14 | char buf[25]; | ^~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:371:16: note: in a call to function ‘read’ declared with attribute ‘access (write_only, 2, 3)’ 371 | extern ssize_t read (int __fd, void *__buf, size_t __nbytes) __wur | ^~~~ Signed-off-by: Rong Tao --- tools/testing/selftests/damon/huge_count_read_write.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/damon/huge_count_read_write.c b/tools/testing/selftests/damon/huge_count_read_write.c index ad7a6b4cf338..8fbe276870e7 100644 --- a/tools/testing/selftests/damon/huge_count_read_write.c +++ b/tools/testing/selftests/damon/huge_count_read_write.c @@ -8,6 +8,11 @@ #include #include +#pragma GCC diagnostic push +/* Ignore read(2) overflow and write(2) overread compile warnings */ +#pragma GCC diagnostic ignored "-Wstringop-overread" +#pragma GCC diagnostic ignored "-Wstringop-overflow" + void write_read_with_huge_count(char *file) { int filedesc = open(file, O_RDWR); @@ -27,6 +32,8 @@ void write_read_with_huge_count(char *file) close(filedesc); } +#pragma GCC diagnostic pop + int main(int argc, char *argv[]) { if (argc != 2) {