From patchwork Thu Nov 10 14:43:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Zingerman X-Patchwork-Id: 13038860 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1491C4332F for ; Thu, 10 Nov 2022 14:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbiKJOno (ORCPT ); Thu, 10 Nov 2022 09:43:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbiKJOnn (ORCPT ); Thu, 10 Nov 2022 09:43:43 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9DD264A8 for ; Thu, 10 Nov 2022 06:43:41 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id x2so3431093edd.2 for ; Thu, 10 Nov 2022 06:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bj0lyCdhAsS7lo7AhOQp7dSNjRCPbq7tfBwKNTFQmh4=; b=qulFI9XHJlZlO7Ou7I2U+T3bhdqirUicmnI2+Cz9ouiVyunXpOVNDNSZ3FshKqBLnK kaV/9j8LYc7nPAWUGuMBQskVgECa4Vfh4cnnUzB+bGOuynU5GnypiZ1tHfWfenuozaQK YQbXPT5SdMEWHVya02pSpU0HBLwVRGG0ww4eu+8w7wwi0wJq1/li1PzwG0Ujiqa8UN2O IH3151+irDSJ8VCwWXGfijsK28pJ4jBo52cT5NaTxRA5Zpx4f3k7oudesWYEptRi/rge o+bX0twm505JEnQ7l+xihCn/MHfRJdCx+Gl+5MdU2QEuHUZcelqeo0O9fOI/SvMgGhpo L0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bj0lyCdhAsS7lo7AhOQp7dSNjRCPbq7tfBwKNTFQmh4=; b=HjjfsLExHLjeMnJy14Q87x9TQcYj5EEP5tZxhrt0V60G0S9RcvtRaMgkF7q2dKQamK nf0vK8YMynSciigCoDwUjT49MusiE+5pUW+K9OD//3DEiEx5QBkr0n+TkWkHuRxkGEAG wWEb/T45Eb8sWzSppj1to3/7HA31u+4kWSxNcOP6berfJgtHa1vSqVBi7lCzvFELGoB4 YIfBff9ZH0WLdKqu82F7eBPItxicDYTHKLljaMFR7Na/oRxpT/YDAsUCj2gs2J4xLjL+ mbUtLAMyB9rb8laVs7viUFHJERZHDeTGTe7w7vW3dGA8UBVo/mVMe3jwWnnuOf6X95jQ KCSg== X-Gm-Message-State: ACrzQf36SxgOJ3tEmhzhAZUQyKfSLpG/GavN3J/3wq981+avMlHjNclv 5nySPT8YGz326h9hg9eUSOiqM6UVHhurXRAJ X-Google-Smtp-Source: AMsMyM5w1dFNGNkqqKN1WcZ8oVxfmxmwlH5AcG25U+cNCjXW6Wmbbq9lV55JMVG5A07mx9Pf0I16wg== X-Received: by 2002:a05:6402:321b:b0:463:bd67:dbba with SMTP id g27-20020a056402321b00b00463bd67dbbamr2388672eda.301.1668091419727; Thu, 10 Nov 2022 06:43:39 -0800 (PST) Received: from pluto.. (boundsly.muster.volia.net. [93.72.16.93]) by smtp.gmail.com with ESMTPSA id g22-20020a50ee16000000b004616b006871sm8609272eds.82.2022.11.10.06.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:43:38 -0800 (PST) From: Eduard Zingerman To: bpf@vger.kernel.org, ast@kernel.org Cc: andrii@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, yhs@fb.com, Eduard Zingerman Subject: [PATCH bpf-next v3 1/3] libbpf: __attribute__((btf_decl_tag("..."))) for btf dump in C format Date: Thu, 10 Nov 2022 16:43:18 +0200 Message-Id: <20221110144320.1075367-2-eddyz87@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221110144320.1075367-1-eddyz87@gmail.com> References: <20221110144320.1075367-1-eddyz87@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Clang's `__attribute__((btf_decl_tag("...")))` is represented in BTF as a record of kind BTF_KIND_DECL_TAG with `type` field pointing to the type annotated with this attribute. This commit adds reconstitution of such attributes for BTF dump in C format. BTF doc says that BTF_KIND_DECL_TAGs should follow a target type but this is not enforced and tests don't honor this restriction. This commit uses hashmap to map types to the list of decl tags. The hashmap is filled incrementally by the function `btf_dump_assign_decl_tags` called from `btf_dump__dump_type` and `btf_dump__dump_type_data`. It is assumed that total number of types annotated with decl tags is relatively small, thus some space is saved by using hashmap instead of adding a new field to `struct btf_dump_type_aux_state`. It is assumed that list of decl tags associated with a single type is small. Thus the list is represented by an array which grows linearly. To accommodate older Clang versions decl tags are dumped using the following macro: #if __has_attribute(btf_decl_tag) #define __btf_decl_tag(x) __attribute__((btf_decl_tag(x))) #else #define __btf_decl_tag(x) #endif The macro definition is emitted upon first call to `btf_dump__dump_type`. Clang allows to attach btf_decl_tag attributes to the following kinds of items: - struct/union supported - struct/union field supported - typedef supported - global variables supported - function prototype parameters supported - function not applicable - function parameter not applicable - local variables not applicable Signed-off-by: Eduard Zingerman --- tools/lib/bpf/btf_dump.c | 181 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 173 insertions(+), 8 deletions(-) diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c index 12f7039e0ab2..1cbc0da43cb4 100644 --- a/tools/lib/bpf/btf_dump.c +++ b/tools/lib/bpf/btf_dump.c @@ -75,6 +75,14 @@ struct btf_dump_data { bool is_array_char; }; +/* + * An array of ids of BTF_DECL_TAG objects associated with a specific type. + */ +struct decl_tag_array { + __u32 cnt; + __u32 tag_ids[0]; +}; + struct btf_dump { const struct btf *btf; btf_dump_printf_fn_t printf_fn; @@ -111,6 +119,18 @@ struct btf_dump { * name occurrences */ struct hashmap *ident_names; + /* + * maps type id to decl_tag_array, assume that relatively small + * fraction of types has btf_decl_tag's attached + */ + struct hashmap *decl_tags; + /* indicates whether '#define __btf_decl_tag ...' was printed */ + bool btf_decl_tag_is_defined; + /* + * next id to be scanned for decl tags presence, needed to update + * decl_tags map when dump_type calls are interleaved with BTF updates. + */ + __u32 next_decl_tag_scan_id; /* * data for typed display; allocated if needed. */ @@ -127,6 +147,16 @@ static bool str_equal_fn(long a, long b, void *ctx) return strcmp((void *)a, (void *)b) == 0; } +static size_t identity_hash_fn(long key, void *ctx) +{ + return (size_t)key; +} + +static bool identity_equal_fn(long k1, long k2, void *ctx) +{ + return k1 == k2; +} + static const char *btf_name_of(const struct btf_dump *d, __u32 name_off) { return btf__name_by_offset(d->btf, name_off); @@ -143,6 +173,7 @@ static void btf_dump_printf(const struct btf_dump *d, const char *fmt, ...) static int btf_dump_mark_referenced(struct btf_dump *d); static int btf_dump_resize(struct btf_dump *d); +static int btf_dump_assign_decl_tags(struct btf_dump *d); struct btf_dump *btf_dump__new(const struct btf *btf, btf_dump_printf_fn_t printf_fn, @@ -170,15 +201,19 @@ struct btf_dump *btf_dump__new(const struct btf *btf, d->type_names = hashmap__new(str_hash_fn, str_equal_fn, NULL); if (IS_ERR(d->type_names)) { err = PTR_ERR(d->type_names); - d->type_names = NULL; goto err; } d->ident_names = hashmap__new(str_hash_fn, str_equal_fn, NULL); if (IS_ERR(d->ident_names)) { err = PTR_ERR(d->ident_names); - d->ident_names = NULL; goto err; } + d->decl_tags = hashmap__new(identity_hash_fn, identity_equal_fn, NULL); + if (IS_ERR(d->decl_tags)) { + err = PTR_ERR(d->decl_tags); + goto err; + } + d->next_decl_tag_scan_id = 1; err = btf_dump_resize(d); if (err) @@ -219,13 +254,20 @@ static int btf_dump_resize(struct btf_dump *d) return 0; } -static void btf_dump_free_names(struct hashmap *map) +static void btf_dump_free_strs_map(struct hashmap *map, bool free_keys, bool free_values) { size_t bkt; struct hashmap_entry *cur; - hashmap__for_each_entry(map, cur, bkt) - free((void *)cur->pkey); + if (IS_ERR_OR_NULL(map)) + return; + + hashmap__for_each_entry(map, cur, bkt) { + if (free_keys) + free((void *)cur->pkey); + if (free_values) + free(cur->pvalue); + } hashmap__free(map); } @@ -248,14 +290,16 @@ void btf_dump__free(struct btf_dump *d) free(d->cached_names); free(d->emit_queue); free(d->decl_stack); - btf_dump_free_names(d->type_names); - btf_dump_free_names(d->ident_names); + btf_dump_free_strs_map(d->type_names, true, false); + btf_dump_free_strs_map(d->ident_names, true, false); + btf_dump_free_strs_map(d->decl_tags, false, true); free(d); } static int btf_dump_order_type(struct btf_dump *d, __u32 id, bool through_ptr); static void btf_dump_emit_type(struct btf_dump *d, __u32 id, __u32 cont_id); +static void btf_dump_ensure_btf_decl_tag_macro(struct btf_dump *d); /* * Dump BTF type in a compilable C syntax, including all the necessary @@ -284,6 +328,9 @@ int btf_dump__dump_type(struct btf_dump *d, __u32 id) if (err) return libbpf_err(err); + btf_dump_ensure_btf_decl_tag_macro(d); + btf_dump_assign_decl_tags(d); + d->emit_queue_cnt = 0; err = btf_dump_order_type(d, id, false); if (err < 0) @@ -373,6 +420,62 @@ static int btf_dump_mark_referenced(struct btf_dump *d) return 0; } +/* + * Scans all BTF objects looking for BTF_KIND_DECL_TAG entries. + * The id's of the entries are stored in the `btf_dump.decl_tags` table, + * grouped by a target type. + */ +static int btf_dump_assign_decl_tags(struct btf_dump *d) +{ + __u32 id, new_cnt, type_cnt = btf__type_cnt(d->btf); + struct decl_tag_array *old_tags, *new_tags; + const struct btf_type *t; + size_t new_sz; + int err; + + for (id = d->next_decl_tag_scan_id; id < type_cnt; id++) { + t = btf__type_by_id(d->btf, id); + if (!btf_is_decl_tag(t)) + continue; + + old_tags = NULL; + hashmap__find(d->decl_tags, t->type, &old_tags); + /* Assume small number of decl tags per id, increase array size by 1 */ + new_cnt = old_tags ? old_tags->cnt + 1 : 1; + if (new_cnt == UINT_MAX) + return -ERANGE; + new_sz = sizeof(struct decl_tag_array) + new_cnt * sizeof(old_tags->tag_ids[0]); + new_tags = realloc(old_tags, new_sz); + if (!new_tags) + return -ENOMEM; + + new_tags->tag_ids[new_cnt - 1] = id; + new_tags->cnt = new_cnt; + + /* No need to update the map if realloc have not changed the pointer */ + if (old_tags == new_tags) + continue; + + err = hashmap__set(d->decl_tags, t->type, new_tags, NULL, NULL); + if (!err) + continue; + /* + * If old_tags != NULL there is a record that holds it in the map, thus + * the hashmap__set() call should not fail as it does not have to + * allocate. If it does fail for some bizarre reason it's a bug and double + * free is imminent because of the previous realloc call. + */ + if (old_tags) + pr_warn("hashmap__set() failed to update value for existing entry\n"); + free(new_tags); + return err; + } + + d->next_decl_tag_scan_id = type_cnt; + + return 0; +} + static int btf_dump_add_emit_queue_id(struct btf_dump *d, __u32 id) { __u32 *new_queue; @@ -899,6 +1002,51 @@ static void btf_dump_emit_bit_padding(const struct btf_dump *d, } } +/* + * Define __btf_decl_tag to be either __attribute__ or noop. + */ +static void btf_dump_ensure_btf_decl_tag_macro(struct btf_dump *d) +{ + if (d->btf_decl_tag_is_defined || !hashmap__size(d->decl_tags)) + return; + + d->btf_decl_tag_is_defined = true; + btf_dump_printf(d, "#if __has_attribute(btf_decl_tag)\n"); + btf_dump_printf(d, "#define __btf_decl_tag(x) __attribute__((btf_decl_tag(x)))\n"); + btf_dump_printf(d, "#else\n"); + btf_dump_printf(d, "#define __btf_decl_tag(x)\n"); + btf_dump_printf(d, "#endif\n\n"); +} + +/* + * Emits a list of __btf_decl_tag(...) attributes attached to some type. + * Decl tags attached to a type and to it's fields reside in a same + * list, thus use component_idx to filter out relevant tags: + * - component_idx == -1 designates the type itself; + * - component_idx >= 0 designates specific field. + */ +static void btf_dump_emit_decl_tags(struct btf_dump *d, + struct decl_tag_array *decl_tags, + int component_idx) +{ + struct btf_type *t; + const char *text; + struct btf_decl_tag *tag; + __u32 i; + + if (!decl_tags) + return; + + for (i = 0; i < decl_tags->cnt; ++i) { + t = btf_type_by_id(d->btf, decl_tags->tag_ids[i]); + tag = btf_decl_tag(t); + if (tag->component_idx != component_idx) + continue; + text = btf__name_by_offset(d->btf, t->name_off); + btf_dump_printf(d, " __btf_decl_tag(\"%s\")", text); + } +} + static void btf_dump_emit_struct_fwd(struct btf_dump *d, __u32 id, const struct btf_type *t) { @@ -914,11 +1062,13 @@ static void btf_dump_emit_struct_def(struct btf_dump *d, int lvl) { const struct btf_member *m = btf_members(t); + struct decl_tag_array *decl_tags = NULL; bool is_struct = btf_is_struct(t); int align, i, packed, off = 0; __u16 vlen = btf_vlen(t); packed = is_struct ? btf_is_struct_packed(d->btf, id, t) : 0; + hashmap__find(d->decl_tags, id, &decl_tags); btf_dump_printf(d, "%s%s%s {", is_struct ? "struct" : "union", @@ -945,6 +1095,7 @@ static void btf_dump_emit_struct_def(struct btf_dump *d, m_sz = max((__s64)0, btf__resolve_size(d->btf, m->type)); off = m_off + m_sz * 8; } + btf_dump_emit_decl_tags(d, decl_tags, i); btf_dump_printf(d, ";"); } @@ -964,6 +1115,7 @@ static void btf_dump_emit_struct_def(struct btf_dump *d, btf_dump_printf(d, "%s}", pfx(lvl)); if (packed) btf_dump_printf(d, " __attribute__((packed))"); + btf_dump_emit_decl_tags(d, decl_tags, -1); } static const char *missing_base_types[][2] = { @@ -1090,6 +1242,7 @@ static void btf_dump_emit_typedef_def(struct btf_dump *d, __u32 id, const struct btf_type *t, int lvl) { const char *name = btf_dump_ident_name(d, id); + struct decl_tag_array *decl_tags = NULL; /* * Old GCC versions are emitting invalid typedef for __gnuc_va_list @@ -1104,6 +1257,8 @@ static void btf_dump_emit_typedef_def(struct btf_dump *d, __u32 id, btf_dump_printf(d, "typedef "); btf_dump_emit_type_decl(d, t->type, name, lvl); + hashmap__find(d->decl_tags, id, &decl_tags); + btf_dump_emit_decl_tags(d, decl_tags, -1); } static int btf_dump_push_decl_stack_id(struct btf_dump *d, __u32 id) @@ -1438,9 +1593,12 @@ static void btf_dump_emit_type_chain(struct btf_dump *d, } case BTF_KIND_FUNC_PROTO: { const struct btf_param *p = btf_params(t); + struct decl_tag_array *decl_tags = NULL; __u16 vlen = btf_vlen(t); int i; + hashmap__find(d->decl_tags, id, &decl_tags); + /* * GCC emits extra volatile qualifier for * __attribute__((noreturn)) function pointers. Clang @@ -1481,6 +1639,7 @@ static void btf_dump_emit_type_chain(struct btf_dump *d, name = btf_name_of(d, p->name_off); btf_dump_emit_type_decl(d, p->type, name, lvl); + btf_dump_emit_decl_tags(d, decl_tags, i); } btf_dump_printf(d, ")"); @@ -1896,6 +2055,7 @@ static int btf_dump_var_data(struct btf_dump *d, const void *data) { enum btf_func_linkage linkage = btf_var(v)->linkage; + struct decl_tag_array *decl_tags = NULL; const struct btf_type *t; const char *l; __u32 type_id; @@ -1920,7 +2080,10 @@ static int btf_dump_var_data(struct btf_dump *d, type_id = v->type; t = btf__type_by_id(d->btf, type_id); btf_dump_emit_type_cast(d, type_id, false); - btf_dump_printf(d, " %s = ", btf_name_of(d, v->name_off)); + btf_dump_printf(d, " %s", btf_name_of(d, v->name_off)); + hashmap__find(d->decl_tags, id, &decl_tags); + btf_dump_emit_decl_tags(d, decl_tags, -1); + btf_dump_printf(d, " = "); return btf_dump_dump_type_data(d, NULL, t, type_id, data, 0, 0); } @@ -2421,6 +2584,8 @@ int btf_dump__dump_type_data(struct btf_dump *d, __u32 id, d->typed_dump->skip_names = OPTS_GET(opts, skip_names, false); d->typed_dump->emit_zeroes = OPTS_GET(opts, emit_zeroes, false); + btf_dump_assign_decl_tags(d); + ret = btf_dump_dump_type_data(d, NULL, t, id, data, 0, 0); d->typed_dump = NULL; From patchwork Thu Nov 10 14:43:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Zingerman X-Patchwork-Id: 13038861 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB16C433FE for ; Thu, 10 Nov 2022 14:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbiKJOnq (ORCPT ); Thu, 10 Nov 2022 09:43:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbiKJOno (ORCPT ); Thu, 10 Nov 2022 09:43:44 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F8292EF0A for ; Thu, 10 Nov 2022 06:43:43 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id l11so3418425edb.4 for ; Thu, 10 Nov 2022 06:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SfhLrjMmd1glswz5hr/esjMdBgxEvM9G/4scmePJDNc=; b=I5sV0GMAZOLkBAgLhGbxeN9KHa+zCD8CmcqVlmtfq6TbD9L/1DRsBwKKQPrVslRIOP mycbSSn096p8cbOQTDzAa6OpPp7b+PbQTDQNus986sosdV6uSrMzFqKigdiPv0L4N2Px 8DK7DN/YngzC1Op4c+nTFa25y6rkWVhNHQVgjcFrs5wj5oBl9GlHJ1iqJk05E2d0V/Bp 7HpbunpUlOhj1ObY0s6OqMVRzzMw/2zEwa98Nj9gUO/sVvhH952CvEAHJwyvt42KGy+g jqRKD7s1Uw0Jc8IPn9q5XL5CJE8IP41Q/usroeqiSzMhAugL0uU+wp0MJLJ2xtatS8AT EGKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SfhLrjMmd1glswz5hr/esjMdBgxEvM9G/4scmePJDNc=; b=VOAXmxCJzjMg+Hu5lGOfeYRBh4fFsz3VK1O9Y1edUpkBnt2Cpp6BhCEHpz1Znj9x9S SeVFGBhJzgAgZbGItW3ajiTNtLlzN+PWCH4bNAC98NJiRg/c+J8cIkwdbzuQjxvapnQO skNOPt3GKNT8LBWqYllq1YRYQfq1z0jnBD5F17IVlILui/YNjca/yiOW/EyediAoXwxN fODwEB42PK5ByZT3wzbpsObIsLCDHOiDjNlODFyeA85XEwa3rYwqPSXB+N/mJWA8o7Md L6tA6MqderWD3+3yeRr2ul0S0R6ys24pPPn60eREA+0lOiz603+2r8gbH6fuY96ogH7X unhg== X-Gm-Message-State: ACrzQf2AWQGYBj4/D9P0xYuUhJ/ijFHjwtU9ndi0gSYY5uYfu6c95kNc mfVJqv9UV3g0yDp5H5MEV+hUi+zxUPOGwEKI X-Google-Smtp-Source: AMsMyM6fXBbIk1k6if2xxa8ws9+0EZTHqJgxR3qiOUShVToPEttviUd93xjRHPVv6y92ti3lNQLMug== X-Received: by 2002:a50:c01e:0:b0:460:fab2:c31f with SMTP id r30-20020a50c01e000000b00460fab2c31fmr2483066edb.335.1668091421831; Thu, 10 Nov 2022 06:43:41 -0800 (PST) Received: from pluto.. (boundsly.muster.volia.net. [93.72.16.93]) by smtp.gmail.com with ESMTPSA id g22-20020a50ee16000000b004616b006871sm8609272eds.82.2022.11.10.06.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:43:40 -0800 (PST) From: Eduard Zingerman To: bpf@vger.kernel.org, ast@kernel.org Cc: andrii@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, yhs@fb.com, Eduard Zingerman Subject: [PATCH bpf-next v3 2/3] selftests/bpf: Dump data sections as part of btf_dump_test_case tests Date: Thu, 10 Nov 2022 16:43:19 +0200 Message-Id: <20221110144320.1075367-3-eddyz87@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221110144320.1075367-1-eddyz87@gmail.com> References: <20221110144320.1075367-1-eddyz87@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Modify `test_btf_dump_case` to test `btf_dump__dump_type_data` alongside `btf_dump__dump_type`. The `test_btf_dump_case` function provides a convenient way to test `btf_dump__dump_type` behavior as test cases are specified in separate C files and any differences are reported using `diff` utility. This commit extends `test_btf_dump_case` to call `btf_dump__dump_type_data` for each `BTF_KIND_DATASEC` object in the test case object file. Signed-off-by: Eduard Zingerman --- .../selftests/bpf/prog_tests/btf_dump.c | 118 +++++++++++++++--- 1 file changed, 104 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/btf_dump.c b/tools/testing/selftests/bpf/prog_tests/btf_dump.c index 24da335482d4..a0bdfc45660d 100644 --- a/tools/testing/selftests/bpf/prog_tests/btf_dump.c +++ b/tools/testing/selftests/bpf/prog_tests/btf_dump.c @@ -1,6 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 #include #include +#include +#include static int duration = 0; @@ -23,31 +25,104 @@ static struct btf_dump_test_case { {"btf_dump: namespacing", "btf_dump_test_case_namespacing", false}, }; -static int btf_dump_all_types(const struct btf *btf, void *ctx) +static int btf_dump_all_types(const struct btf *btf, struct btf_dump *d) { size_t type_cnt = btf__type_cnt(btf); - struct btf_dump *d; int err = 0, id; - d = btf_dump__new(btf, btf_dump_printf, ctx, NULL); - err = libbpf_get_error(d); - if (err) - return err; - for (id = 1; id < type_cnt; id++) { err = btf_dump__dump_type(d, id); if (err) - goto done; + break; + } + + return err; +} + +/* Keep this as macro to retain __FILE__, __LINE__ values used by PRINT_FAIL */ +#define report_elf_error(fn) \ + ({ \ + int __err = elf_errno(); \ + PRINT_FAIL("%s() failed %s(%d)\n", fn, elf_errmsg(__err), __err); \ + __err; \ + }) + +static int btf_dump_datasec(Elf *elf, const struct btf *btf, struct btf_dump *d, __u32 id) +{ + const char *btf_sec, *elf_sec; + const struct btf_type *t; + Elf_Data *data = NULL; + Elf_Scn *scn = NULL; + size_t shstrndx; + GElf_Shdr sh; + + if (elf_getshdrstrndx(elf, &shstrndx)) + return report_elf_error("elf_getshdrstrndx"); + + t = btf__type_by_id(btf, id); + btf_sec = btf__str_by_offset(btf, t->name_off); + + while ((scn = elf_nextscn(elf, scn)) != NULL) { + if (!gelf_getshdr(scn, &sh)) + return report_elf_error("gelf_getshdr"); + elf_sec = elf_strptr(elf, shstrndx, sh.sh_name); + if (!elf_sec) + return report_elf_error("elf_strptr"); + if (strcmp(btf_sec, elf_sec) == 0) { + data = elf_getdata(scn, NULL); + if (!data) + return report_elf_error("elf_getdata"); + break; + } + } + + if (CHECK(!data, "btf_dump_datasec", "can't find ELF section %s\n", elf_sec)) + return -1; + + return btf_dump__dump_type_data(d, id, data->d_buf, data->d_size, NULL); +} + +static int btf_dump_all_datasec(const struct btf *btf, struct btf_dump *d, + char *test_file, FILE *f) +{ + size_t type_cnt = btf__type_cnt(btf); + int err = 0, id, fd = 0; + Elf *elf = NULL; + + fd = open(test_file, O_RDONLY | O_CLOEXEC); + if (CHECK(fd < 0, "open", "can't open %s for reading, %s(%d)\n", + test_file, strerror(errno), errno)) { + err = errno; + goto done; + } + + elf = elf_begin(fd, ELF_C_READ, NULL); + if (!elf) { + err = report_elf_error("elf_begin"); + goto done; + } + + for (id = 1; id < type_cnt; id++) { + if (!btf_is_datasec(btf__type_by_id(btf, id))) + continue; + err = btf_dump_datasec(elf, btf, d, id); + if (err) + break; + fprintf(f, "\n\n"); } done: - btf_dump__free(d); + if (fd) + close(fd); + if (elf) + elf_end(elf); return err; } static int test_btf_dump_case(int n, struct btf_dump_test_case *t) { char test_file[256], out_file[256], diff_cmd[1024]; + struct btf_dump *d = NULL; struct btf *btf = NULL; int err = 0, fd = -1; FILE *f = NULL; @@ -86,12 +161,22 @@ static int test_btf_dump_case(int n, struct btf_dump_test_case *t) goto done; } - err = btf_dump_all_types(btf, f); - fclose(f); - close(fd); - if (CHECK(err, "btf_dump", "failure during C dumping: %d\n", err)) { + d = btf_dump__new(btf, btf_dump_printf, f, NULL); + err = libbpf_get_error(d); + if (CHECK(err, "btf_dump", "btf_dump__new failed: %d\n", err)) + goto done; + + err = btf_dump_all_types(btf, d); + if (CHECK(err, "btf_dump", "btf_dump_all_types failed: %d\n", err)) + goto done; + + err = btf_dump_all_datasec(btf, d, test_file, f); + if (CHECK(err, "btf_dump", "btf_dump_all_datasec failed: %d\n", err)) + goto done; + + if (CHECK(fflush(f), "btf_dump", "fflush() on %s failed: %s(%d)\n", + test_file, strerror(errno), errno)) goto done; - } snprintf(test_file, sizeof(test_file), "progs/%s.c", t->file); if (access(test_file, R_OK) == -1) @@ -122,6 +207,11 @@ static int test_btf_dump_case(int n, struct btf_dump_test_case *t) remove(out_file); done: + if (f) + fclose(f); + if (fd >= 0) + close(fd); + btf_dump__free(d); btf__free(btf); return err; } From patchwork Thu Nov 10 14:43:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduard Zingerman X-Patchwork-Id: 13038862 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C6CC43217 for ; Thu, 10 Nov 2022 14:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbiKJOnr (ORCPT ); Thu, 10 Nov 2022 09:43:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbiKJOnq (ORCPT ); Thu, 10 Nov 2022 09:43:46 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CC8431217 for ; Thu, 10 Nov 2022 06:43:45 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id u24so3369484edd.13 for ; Thu, 10 Nov 2022 06:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zTzlma0XCtqOCUCIZzuJkV+Gqw8Y7IkDywVKUQ+ShOY=; b=a0sq+O/AYEAaR6pBg94ZagdeN5ZDUTwrsvCAFiWHUOXTBUVTyQRtJhfih9wpVxM2oE tHPW3InETvrG5BidjbjsNcSA5i76pwJiHyDs+oE5qCoprdh4c3iUDFDfK72+Tl8NkOl2 mU1QPyd9AsZlfY6dTSItivwwO4WKrPWEG5cb2riwshoydms6uQjan/QETaAlKW+nCJzF 5wEzCn5FAnJLyD4ndOHucm91sABpUcRoxDaeOP/YprOlsYtvc8KC/fabDbLrthcsBYii 0//8MY810z1W3K6xBwz7ZLHuQlTbgKJK9EMmntIJ8JpTCnEpL/tRGxEThat7rX2Q05wT j20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zTzlma0XCtqOCUCIZzuJkV+Gqw8Y7IkDywVKUQ+ShOY=; b=DlDiQx/igKIfcFVs6KdFUgu6uUW3hGcAkmS4H9nS6OKXnjVrUKt9/xnqNUCPBvWY6n BP8Ogfnb+NlrPvDRxhAqVE5xpqoyczFOgGc0yHuZ8vrj3dEgsf3o/bdZYHqcYmQD26LX zhhHFwOMGaZMo/JBXwL//KvlVJEXVJnYW/srKYBBPEhAgtrP/F248QltDK84WranF7AI iON4JTPBy7J6LKqqZrGj42GhIcx2AeoyjAgBHAMVb8Av1m0k7V3+4Xv1wMAoCK08tMzg 3GKllssmoC6g9lYH9TRvzpMbIo0ls7m94eilavY6fpsi38o+oJ2ZiZ1OGq6MX8kIWBMO oB6w== X-Gm-Message-State: ACrzQf3219ZFQOdMkJhYXc1dkGRRqB04q/vRkzi8PmF+9Wg74uP8jPVs Mdwl9DlagxPXTPvlm3zfJThgdPnanBwiKbCL X-Google-Smtp-Source: AMsMyM7h5pB/qRPP37P7DKShDQYcAPdQvnYdlI4wKnUnuxhj90nOtoayLrppo9doYsjK1tVih6Z37A== X-Received: by 2002:a05:6402:1767:b0:461:f1c6:1f22 with SMTP id da7-20020a056402176700b00461f1c61f22mr2493166edb.95.1668091423403; Thu, 10 Nov 2022 06:43:43 -0800 (PST) Received: from pluto.. (boundsly.muster.volia.net. [93.72.16.93]) by smtp.gmail.com with ESMTPSA id g22-20020a50ee16000000b004616b006871sm8609272eds.82.2022.11.10.06.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:43:42 -0800 (PST) From: Eduard Zingerman To: bpf@vger.kernel.org, ast@kernel.org Cc: andrii@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, yhs@fb.com, Eduard Zingerman Subject: [PATCH bpf-next v3 3/3] selftests/bpf: Tests for BTF_KIND_DECL_TAG dump in C format Date: Thu, 10 Nov 2022 16:43:20 +0200 Message-Id: <20221110144320.1075367-4-eddyz87@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221110144320.1075367-1-eddyz87@gmail.com> References: <20221110144320.1075367-1-eddyz87@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Covers the following cases: - `__atribute__((btf_decl_tag("...")))` could be applied to structs and unions; - decl tag applied to an empty struct is printed on a single line; - decl tags with the same name could be applied to several structs; - several decl tags could be applied to the same struct; - attribute `packed` works fine with decl tags (it is a separate branch in `tools/lib/bpf/btf_dump.c:btf_dump_emit_attributes`; - decl tag could be attached to typedef; - decl tag could be attached to a struct field; - decl tag could be attached to a struct field and a struct itself simultaneously; - decl tag could be attached to a global variable; - decl tag could be attached to a func proto parameter; - btf__add_decl_tag could be interleaved with btf_dump__dump_type calls. Signed-off-by: Eduard Zingerman --- .../selftests/bpf/prog_tests/btf_dump.c | 79 +++++++++++++++++++ .../bpf/progs/btf_dump_test_case_decl_tag.c | 65 +++++++++++++++ 2 files changed, 144 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/btf_dump_test_case_decl_tag.c diff --git a/tools/testing/selftests/bpf/prog_tests/btf_dump.c b/tools/testing/selftests/bpf/prog_tests/btf_dump.c index a0bdfc45660d..2e6135a555e3 100644 --- a/tools/testing/selftests/bpf/prog_tests/btf_dump.c +++ b/tools/testing/selftests/bpf/prog_tests/btf_dump.c @@ -23,6 +23,7 @@ static struct btf_dump_test_case { {"btf_dump: bitfields", "btf_dump_test_case_bitfields", true}, {"btf_dump: multidim", "btf_dump_test_case_multidim", false}, {"btf_dump: namespacing", "btf_dump_test_case_namespacing", false}, + {"btf_dump: decl_tag", "btf_dump_test_case_decl_tag", true}, }; static int btf_dump_all_types(const struct btf *btf, struct btf_dump *d) @@ -345,6 +346,82 @@ static void test_btf_dump_incremental(void) btf__free(btf); } +static void test_btf_dump_func_proto_decl_tag(void) +{ + struct btf *btf = NULL; + struct btf_dump *d = NULL; + int id, err; + + dump_buf_file = open_memstream(&dump_buf, &dump_buf_sz); + if (!ASSERT_OK_PTR(dump_buf_file, "dump_memstream")) + return; + btf = btf__new_empty(); + if (!ASSERT_OK_PTR(btf, "new_empty")) + goto err_out; + d = btf_dump__new(btf, btf_dump_printf, dump_buf_file, NULL); + if (!ASSERT_OK(libbpf_get_error(d), "btf_dump__new")) + goto err_out; + + /* First, BTF corresponding to the following C code: + * + * typedef void (*fn)(int a __btf_decl_tag("a_tag")); + * + */ + id = btf__add_int(btf, "int", 4, BTF_INT_SIGNED); + ASSERT_EQ(id, 1, "int_id"); + id = btf__add_func_proto(btf, 0); + ASSERT_EQ(id, 2, "func_proto_id"); + err = btf__add_func_param(btf, "a", 1); + ASSERT_OK(err, "func_param_ok"); + id = btf__add_decl_tag(btf, "a_tag", 2, 0); + ASSERT_EQ(id, 3, "decl_tag_a"); + id = btf__add_ptr(btf, 2); + ASSERT_EQ(id, 4, "proto_ptr"); + id = btf__add_typedef(btf, "fn", 4); + ASSERT_EQ(id, 5, "typedef"); + + err = btf_dump_all_types(btf, d); + ASSERT_OK(err, "btf_dump_all_types #1"); + fflush(dump_buf_file); + dump_buf[dump_buf_sz] = 0; /* some libc implementations don't do this */ + + ASSERT_STREQ(dump_buf, + "#if __has_attribute(btf_decl_tag)\n" + "#define __btf_decl_tag(x) __attribute__((btf_decl_tag(x)))\n" + "#else\n" + "#define __btf_decl_tag(x)\n" + "#endif\n" + "\n" + "typedef void (*fn)(int a __btf_decl_tag(\"a_tag\"));\n\n", + "decl tags for fn"); + + /* Next, add BTF corresponding to the following C code: + * + * typedef int foo __btf_decl_tag("foo_tag"); + * + * To verify that decl_tag's table is updated incrementally. + */ + id = btf__add_typedef(btf, "foo", 1); + ASSERT_EQ(id, 6, "typedef"); + id = btf__add_decl_tag(btf, "foo_tag", 6, -1); + ASSERT_EQ(id, 7, "decl_tag_foo"); + + fseek(dump_buf_file, 0, SEEK_SET); + err = btf_dump_all_types(btf, d); + ASSERT_OK(err, "btf_dump_all_types #2"); + fflush(dump_buf_file); + dump_buf[dump_buf_sz] = 0; /* some libc implementations don't do this */ + + ASSERT_STREQ(dump_buf, + "typedef int foo __btf_decl_tag(\"foo_tag\");\n\n", + "decl tags for foo"); +err_out: + fclose(dump_buf_file); + free(dump_buf); + btf_dump__free(d); + btf__free(btf); +} + #define STRSIZE 4096 static void btf_dump_snprintf(void *ctx, const char *fmt, va_list args) @@ -963,6 +1040,8 @@ void test_btf_dump() { } if (test__start_subtest("btf_dump: incremental")) test_btf_dump_incremental(); + if (test__start_subtest("btf_dump: func arg decl_tag")) + test_btf_dump_func_proto_decl_tag(); btf = libbpf_find_kernel_btf(); if (!ASSERT_OK_PTR(btf, "no kernel BTF found")) diff --git a/tools/testing/selftests/bpf/progs/btf_dump_test_case_decl_tag.c b/tools/testing/selftests/bpf/progs/btf_dump_test_case_decl_tag.c new file mode 100644 index 000000000000..1205351e9a68 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/btf_dump_test_case_decl_tag.c @@ -0,0 +1,65 @@ +// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) + +/* + * BTF-to-C dumper test for __atribute__((btf_decl_tag("..."))). + */ + +#define SEC(x) __attribute__((section(x))) + +/* ----- START-EXPECTED-OUTPUT ----- */ +#if __has_attribute(btf_decl_tag) +#define __btf_decl_tag(x) __attribute__((btf_decl_tag(x))) +#else +#define __btf_decl_tag(x) +#endif + +struct empty_with_tag {} __btf_decl_tag("a"); + +struct one_tag { + int x; +} __btf_decl_tag("b"); + +struct same_tag { + int x; +} __btf_decl_tag("b"); + +struct two_tags { + int x; +} __btf_decl_tag("a") __btf_decl_tag("b"); + +struct packed { + int x; + short y; +} __attribute__((packed)) __btf_decl_tag("another_name"); + +typedef int td_with_tag __btf_decl_tag("td"); + +struct tags_on_fields { + int x __btf_decl_tag("t1"); + int y; + int z __btf_decl_tag("t2") __btf_decl_tag("t3"); +}; + +struct tag_on_field_and_struct { + int x __btf_decl_tag("t1"); +} __btf_decl_tag("t2"); + +struct root_struct { + struct empty_with_tag a; + struct one_tag b; + struct same_tag c; + struct two_tags d; + struct packed e; + td_with_tag f; + struct tags_on_fields g; + struct tag_on_field_and_struct h; +}; + +SEC(".data") int global_var __btf_decl_tag("var_tag") = (int)777; + +/* ------ END-EXPECTED-OUTPUT ------ */ + +int f(struct root_struct *s) +{ + return 0; +}