From patchwork Sat Nov 12 14:28:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Cowan X-Patchwork-Id: 13041235 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D815C4332F for ; Sat, 12 Nov 2022 14:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbiKLOak (ORCPT ); Sat, 12 Nov 2022 09:30:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230170AbiKLOaj (ORCPT ); Sat, 12 Nov 2022 09:30:39 -0500 Received: from beige.elm.relay.mailchannels.net (beige.elm.relay.mailchannels.net [23.83.212.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C361A83E; Sat, 12 Nov 2022 06:30:37 -0800 (PST) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6D4B1821BE8; Sat, 12 Nov 2022 14:30:36 +0000 (UTC) Received: from pdx1-sub0-mail-a218.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EDE02821BC8; Sat, 12 Nov 2022 14:30:35 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1668263436; a=rsa-sha256; cv=none; b=LowArWQR1ubo44tvwjck1xopghn3KIdT/ec/1qbIkFTFfuVy9Wqe9xY5kv9T/FubsVKP19 CTLRtLLe8MTdLH+PqiShrgoNSdNtFTQyC/tNYZ2k23um5amFfhdyt/njFvVzI73DMWeF5g bNCyN+38LKqecyF9u81AV+8HFDV9Hd+RBF/4ZzZR/VBAXR/fCHejj3xAabBILXCL1nG/nq MN6IOWASpxG2ujgG5UPxYiD/V/6pZP0hRPD/Bu61/jstFX6mbR7ZYzXC9z9nGroMf9JZMD RWtPVXml3ANwwvt6cDYf/TcBqG59L+P66cwaFI4RiwJZfYPWTLP2SbWF585ETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1668263436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFOu58EziI41+nlF3fAgrd3T4bqfAOOprYCBnpz0jLw=; b=kRhcyMeGuTngjCA9taCj4RfHet0Plv65yglkHtmN9bNeF0t6BnYVxLWbD+GLO0iuFReJUa 0gWmEIL6HIk55Mv3BL7sd2PBhcSlMYQuVoXyS0wplOlwvy69lXTGQfZOu73O2qwmmwrZ45 uW8mjiWhWwAtR7RdJfxw6bYQ0WutgmoaKrJxBJfmSeybVFWlg0WGQxCoEXu4FY+E/XeBIv thdVyLQRCrpUxt8SNFbGUkaiScWfGrNmJiw/X3Lz088YuN7HKaIqlomZeC38+QfrI+jvfV hAOcrcIeHh5S0kvb2UT5p5IY6fNK0upV0jhJe58sVyZIpp9GdoYuYyCjrAWeWA== ARC-Authentication-Results: i=1; rspamd-7f9bbcf788-8nkdq; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Lyrical-Minister: 2842be025922d1d6_1668263436215_1143567332 X-MC-Loop-Signature: 1668263436215:652404706 X-MC-Ingress-Time: 1668263436215 Received: from pdx1-sub0-mail-a218.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.48.91 (trex/6.7.1); Sat, 12 Nov 2022 14:30:36 +0000 Received: from rhino.lan (dsl-50-5-144-34.fuse.net [50.5.144.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a218.dreamhost.com (Postfix) with ESMTPSA id 4N8dK72fNmz24; Sat, 12 Nov 2022 06:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1668263435; bh=iFOu58EziI41+nlF3fAgrd3T4bqfAOOprYCBnpz0jLw=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=nls1JS0aLZb+tSYINzICUgT6sbb4yRC96UOnJwHbgUJ9ayXFU0tx6BgwtGEZoUFHN XIF3/U3Ecl3i73/9Uz8T1Hel/+w+JikGVQoKUkCfcTUYoWB0pex5W4Yv10eXUN63bA EUCQiN5XesqQJB0VwtsRolOxZ4EldBnjXR94+XwM0OadaGeputFrPXxSppc7Z1+oQt 7oq/drfy5PI2JoxOD8cq9LeJyl01J62AMSeA1vbDqrfooSl3I2IvdB2tLj819Vgi9n n4fgeO1mePLoChbL/5k3ZbmczN/Tr3VaSN27olcDwksXESGDjgJVmR25nhZytA68bY JD6lZESOdpbCw== From: Ian Cowan To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Cowan Subject: [PATCH 1/3] PCI: SHPC: remove unused get_mode1_ECC_cap callback declaration Date: Sat, 12 Nov 2022 09:28:57 -0500 Message-Id: <20221112142859.319733-2-ian@linux.cowan.aero> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221112142859.319733-1-ian@linux.cowan.aero> References: <20221112142859.319733-1-ian@linux.cowan.aero> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The ->get_mode1_ECC_cap callback in the shpchp_hpc_ops struct is never called so we'll remove it. This removes that callback from the declaration of the struct in the shpc module. Signed-off-by: Ian Cowan --- drivers/pci/hotplug/shpchp_hpc.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index bd7557ca4910..48e4daefc44a 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c @@ -489,23 +489,6 @@ static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value) return retval; } -static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode) -{ - int retval = 0; - struct controller *ctrl = slot->ctrl; - u16 sec_bus_status = shpc_readw(ctrl, SEC_BUS_CONFIG); - u8 pi = shpc_readb(ctrl, PROG_INTERFACE); - - if (pi == 2) { - *mode = (sec_bus_status & 0x0100) >> 8; - } else { - retval = -1; - } - - ctrl_dbg(ctrl, "Mode 1 ECC cap = %d\n", *mode); - return retval; -} - static int hpc_query_power_fault(struct slot *slot) { struct controller *ctrl = slot->ctrl; @@ -900,7 +883,6 @@ static const struct hpc_ops shpchp_hpc_ops = { .get_adapter_status = hpc_get_adapter_status, .get_adapter_speed = hpc_get_adapter_speed, - .get_mode1_ECC_cap = hpc_get_mode1_ECC_cap, .get_prog_int = hpc_get_prog_int, .query_power_fault = hpc_query_power_fault, From patchwork Sat Nov 12 14:28:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Cowan X-Patchwork-Id: 13041236 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330F3C433FE for ; Sat, 12 Nov 2022 14:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234853AbiKLOal (ORCPT ); Sat, 12 Nov 2022 09:30:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234747AbiKLOal (ORCPT ); Sat, 12 Nov 2022 09:30:41 -0500 Received: from beige.elm.relay.mailchannels.net (beige.elm.relay.mailchannels.net [23.83.212.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08E7C1A83E; Sat, 12 Nov 2022 06:30:39 -0800 (PST) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 572A0201769; Sat, 12 Nov 2022 14:30:39 +0000 (UTC) Received: from pdx1-sub0-mail-a218.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E0002201C06; Sat, 12 Nov 2022 14:30:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1668263438; a=rsa-sha256; cv=none; b=bDbj0ovzR8m5yweB7/gcXHpa0RvoAGpP6ldzpSDs8GV7o5qpaSn4kjfA2MSyxRe40I7vTl exjmy9XzZaKCmpT4pRpoCl0/ZSfPYPlD3Py0UvoN7tOtaFUBx4u+FdukhrxL5RbhWeIWzF Ezemq/ZjlZuQTcbOanppdXQJ6N6lFgZA23Cd43IZvmF+3HSWuu2DJuRaEyO6znlcR1Q2RL Dj21NwCskpUeEH8AuW+1y7bHCUmePXJTuKgDZeA1iDCFy7trWkS65Q/TX7g4p6u7+nIBO8 92nCDincfGNoYmWkr+SY3YhiOlU8VcxqikHlKL0BHaK+TaC4l5eiOo6Cpf7Crg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1668263438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D3Xr03eLr426oQvYQ3eI2Of6RqoxNDQolv691ZaKJpU=; b=t3ULH7I6G/oysyfSjt/+OFay5mna2BkHFxnIuh5bz/tzHQkeHlroe8vULh5v40ZHOxKNn3 dIF0ziWo8zTdL9/LCyrntBTs7FzB9EDAyq+qB+ORO/JzlNJSj6sPIkm+Y07kUYJ/7o1MF0 42p6xvVgTne73Rzom9k5H0D+QmRq6v0xwiPpXE6XxJIXPIT6j1XySt3yMisW4MjomqEuUV WzgWgfueUfy2/Lq3sbG1MBm1YKLU4KZ3VMUGL/csq/Vn+64OoyyIMJf1wDyS86JmienroQ rVfZZ9G7PCrgOjz0mVpoW9i0FM+wiNOKpqlAQ//bfypH0imU2N+EvFB2LTUpfw== ARC-Authentication-Results: i=1; rspamd-7f9bbcf788-6fwcn; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Name-Cold: 2adb1a1e20f0e52c_1668263439166_2745515620 X-MC-Loop-Signature: 1668263439166:4284031045 X-MC-Ingress-Time: 1668263439166 Received: from pdx1-sub0-mail-a218.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.229.20 (trex/6.7.1); Sat, 12 Nov 2022 14:30:39 +0000 Received: from rhino.lan (dsl-50-5-144-34.fuse.net [50.5.144.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a218.dreamhost.com (Postfix) with ESMTPSA id 4N8dKB255yz1M; Sat, 12 Nov 2022 06:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1668263438; bh=D3Xr03eLr426oQvYQ3eI2Of6RqoxNDQolv691ZaKJpU=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=T++3iiweLkJGr7u3ODBpW2LLaNmWW2YQ2ShrPdmFT/MQE3SwkU1kDqSkLRdsl82sW c404EJjNyr1aUJ+ONJrap9e02AfXMU7aBwVVXrEENtyH372YsaygRfstiddBgdmRc5 GfUFPH4zPrBr3mxPXQ2mZY3Dy7DHfu+4Dj/oboq3Vi4DtS1RMrDr2/MRoj5R0XCobA qwcCiq6k4DmO9Z/BbwiQ9KPPohAAfrYWJFkM3OOfZs2z2BRsG0wMnavBEh4asixxyc Lz8yROk9Zamw5T2fyGwe2SJ07TZ5wpQre6iH6a2kqxhPJ8BZI6+rhX3+StjTs9uv4a nEAUA785fNigQ== From: Ian Cowan To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Cowan Subject: [PATCH 2/3] PCI: SHPC: remove unused get_mode1_ECC_cap callback from definition Date: Sat, 12 Nov 2022 09:28:58 -0500 Message-Id: <20221112142859.319733-3-ian@linux.cowan.aero> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221112142859.319733-1-ian@linux.cowan.aero> References: <20221112142859.319733-1-ian@linux.cowan.aero> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The ->get_mode1_ECC_cap callback is never used in the shpchp_hpc_ops struct, so we can remove that. This removes that from the hpc_ops struct definition in the shpc module. Signed-off-by: Ian Cowan --- drivers/pci/hotplug/shpchp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h index 6e85885b554c..3a97f455336e 100644 --- a/drivers/pci/hotplug/shpchp.h +++ b/drivers/pci/hotplug/shpchp.h @@ -311,7 +311,6 @@ struct hpc_ops { int (*get_latch_status)(struct slot *slot, u8 *status); int (*get_adapter_status)(struct slot *slot, u8 *status); int (*get_adapter_speed)(struct slot *slot, enum pci_bus_speed *speed); - int (*get_mode1_ECC_cap)(struct slot *slot, u8 *mode); int (*get_prog_int)(struct slot *slot, u8 *prog_int); int (*query_power_fault)(struct slot *slot); void (*green_led_on)(struct slot *slot); From patchwork Sat Nov 12 14:28:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Cowan X-Patchwork-Id: 13041238 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F41C43219 for ; Sat, 12 Nov 2022 14:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234063AbiKLOau (ORCPT ); Sat, 12 Nov 2022 09:30:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234933AbiKLOas (ORCPT ); Sat, 12 Nov 2022 09:30:48 -0500 Received: from crane.ash.relay.mailchannels.net (crane.ash.relay.mailchannels.net [23.83.222.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CD721C12A; Sat, 12 Nov 2022 06:30:44 -0800 (PST) X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 184503C1EA7; Sat, 12 Nov 2022 14:30:41 +0000 (UTC) Received: from pdx1-sub0-mail-a218.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AEEE73C1997; Sat, 12 Nov 2022 14:30:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1668263440; a=rsa-sha256; cv=none; b=rpyE8bGpSAdXfK7sLzn/u2LW+TiC0NZxTKL5Ic0LAQhSoHQWvDjaCMPSmLYHL7l62wpYYK ujNPepQxeCaVjLFy1nutWx1I6jYEF8E26qmDjTodt25HpORSo/yjNXeWe4aduhnm9vUNHz Mp+fIiCEEnnm58m58cZ5vXmB6oCXrfRO6T2xDf+HiOZ7OPWB8PxWGKUXiP5ztfzKXsOjvw h4Uh3VkIHmfEB2BCt2Mp570I1v07M9iuVpu7eNeQ+G1wx7AZwmR+Kt3KUQNBN5F4jI3+UK X0TkCmrjoIoOAFiy+7m9YKu4nyH+J27o7ykf/L3hS13bYuNr79aZxubE4UTZOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1668263440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZldjB1QXpaMaa585PwQA9L52Y7Bh6VzfKf1mPIq62YA=; b=1+3NLPGjx8DQi0OLIwfyBGFeyg1JIDdWwL2km7sbj8pwR1BkctQxoYUYPikqtWqeekmeS5 QmdE4zL5isV1f4Isvr7dmDyrgXvT/FIvb7jG0Kw8yrmyH6aL0QspUSwOswJlibQ/IrITAH H56S+FLyE/P7k273bAtG6MaeI8PbY18o2hKkjU+7zRm8LRmcXF7vUxuvM0B2MuBCigxfPD PqHZMJYZWau9Y5aeS1uebVgCIBdaBPrE0zkDDTvPg0K3Dr5TzFiUGSl44U2REywm8q9htG 8Pd98ZBdj9wL8bdoSbGEy86LGv+ZxOfM80Yasdw4lVGJ6SjBGuH3BASQ6JMsrQ== ARC-Authentication-Results: i=1; rspamd-7f9bbcf788-nvvnz; auth=pass smtp.auth=dreamhost smtp.mailfrom=ian@linux.cowan.aero X-Sender-Id: dreamhost|x-authsender|ian@linux.cowan.aero X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|ian@linux.cowan.aero X-MailChannels-Auth-Id: dreamhost X-Cooperative-Slimy: 71e11c3d6d4e732d_1668263440953_2366251542 X-MC-Loop-Signature: 1668263440953:951357203 X-MC-Ingress-Time: 1668263440953 Received: from pdx1-sub0-mail-a218.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.179.71 (trex/6.7.1); Sat, 12 Nov 2022 14:30:40 +0000 Received: from rhino.lan (dsl-50-5-144-34.fuse.net [50.5.144.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ian@linux.cowan.aero) by pdx1-sub0-mail-a218.dreamhost.com (Postfix) with ESMTPSA id 4N8dKD0NLfz5y; Sat, 12 Nov 2022 06:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.cowan.aero; s=dreamhost; t=1668263440; bh=ZldjB1QXpaMaa585PwQA9L52Y7Bh6VzfKf1mPIq62YA=; h=From:To:Cc:Subject:Date:Content-Transfer-Encoding; b=tbCXFW7ibaOJkjeQHBa0rmK36vceGZEN6sP9Wx4b+sP2qW+I1EQW9r2Q95itCIBSI bHydwg12xMOgTVryJi4f3bCwRdvRbZKvpiobMPgaoKXNyVQt87+YoBUVPH9G7bmyOU RZJqye4wQ2vYpTjVEeeC/2zl2VykmuEA9JP0INpy3lVU75L7N9RslY3Ke+SknwG5SM 0Wk7BpIarrovz2MZSWVMHDHt9FjOODdWROM68j6fJV3FjRAEe9hBptyAbpFYDCcv3B m2OxRhlaLaLG64Qv/ohOBjpRPwbk6qWYd6jt8v8oZN38COF/U2SGUinzbnQi4NLDr6 H2JMzN6NegD9w== From: Ian Cowan To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Cowan Subject: [PATCH 3/3] PCI: SHPC: update todo Date: Sat, 12 Nov 2022 09:28:59 -0500 Message-Id: <20221112142859.319733-4-ian@linux.cowan.aero> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221112142859.319733-1-ian@linux.cowan.aero> References: <20221112142859.319733-1-ian@linux.cowan.aero> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This removes the note in the todo regarding the removal of the ->get_mode1_ECC_cap callback. Signed-off-by: Ian Cowan --- drivers/pci/hotplug/TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/hotplug/TODO b/drivers/pci/hotplug/TODO index 88f217c82b4f..fdb8dd6ea24d 100644 --- a/drivers/pci/hotplug/TODO +++ b/drivers/pci/hotplug/TODO @@ -58,9 +58,6 @@ shpchp: pciehp with commit 82a9e79ef132 ("PCI: pciehp: remove hpc_ops"). Clarify if there was a specific reason not to apply the same change to shpchp. -* The ->get_mode1_ECC_cap callback in shpchp_hpc_ops is never invoked. - Why was it introduced? Can it be removed? - * The hardirq handler shpc_isr() queues events on a workqueue. It can be simplified by converting it to threaded IRQ handling. Use pciehp as a template.