From patchwork Tue Nov 15 03:17:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bo Liu X-Patchwork-Id: 13043197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C75C4332F for ; Tue, 15 Nov 2022 03:18:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A9BB8E0002; Mon, 14 Nov 2022 22:18:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 435AF6B0075; Mon, 14 Nov 2022 22:18:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322038E0002; Mon, 14 Nov 2022 22:18:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D0E66B0074 for ; Mon, 14 Nov 2022 22:18:07 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E1F1B120E37 for ; Tue, 15 Nov 2022 03:18:06 +0000 (UTC) X-FDA: 80134217772.11.C6B31F2 Received: from unicom146.biz-email.net (unicom146.biz-email.net [210.51.26.146]) by imf27.hostedemail.com (Postfix) with ESMTP id D92EA4000F for ; Tue, 15 Nov 2022 03:18:05 +0000 (UTC) Received: from ([60.208.111.195]) by unicom146.biz-email.net ((D)) with ASMTP (SSL) id JEG00156; Tue, 15 Nov 2022 11:17:56 +0800 Received: from localhost.localdomain (10.200.104.97) by jtjnmail201602.home.langchao.com (10.100.2.2) with Microsoft SMTP Server id 15.1.2507.12; Tue, 15 Nov 2022 11:17:59 +0800 From: Bo Liu To: , , CC: , , , Bo Liu Subject: [PATCH] binfmt_elf: replace IS_ERR() with IS_ERR_VALUE() Date: Mon, 14 Nov 2022 22:17:57 -0500 Message-ID: <20221115031757.2426-1-liubo03@inspur.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-Originating-IP: [10.200.104.97] tUid: 20221115111756b87c5982aa519fccab65dc704674a7a4 X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of liubo03@inspur.com designates 210.51.26.146 as permitted sender) smtp.mailfrom=liubo03@inspur.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668482286; a=rsa-sha256; cv=none; b=l7EahSS05UbDFyM9B47kI30PlsvVt+QQXxKjluPjm0jJNS7xPSSBqOPJGVKGUTCwCGthGg D1+hLpfXXShfkli/PQ7UjEHddV/xE75iEBn2nvLYNn3DsdbgLZiTWSPrjxM74CL4gBAeY3 vFn/kIrM8Hfj3CQM65qogZzkFyxIQkM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668482286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=4RVJBELiWytDFwBcHcydZPGe4xSGwTz6ZMRyW4i1t24=; b=ymvj8H6M/oB3KoDNFmiY01+nItMbCPSjxFZrHLTOOUD31JvhdAL83BJSyZmgVlmnjwy8Hp 4TXGLYFvuag+Q4W4mdm/b/HHuQPTUtARUdrU3Yuj4jwwrrXuiNjExXg92WZiZqpubT9mHS gRYwYJ6oAOFXkU3+HJqdSjZcjxSOQok= X-Stat-Signature: s7g4n1bux5pasajxk7wxd95nafoyguwb X-Rspamd-Queue-Id: D92EA4000F X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of liubo03@inspur.com designates 210.51.26.146 as permitted sender) smtp.mailfrom=liubo03@inspur.com; dmarc=none X-Rspamd-Server: rspam11 X-HE-Tag: 1668482285-177894 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE() instead. Signed-off-by: Bo Liu --- fs/binfmt_elf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 528e2ac8931f..d9af34f816a9 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1160,7 +1160,7 @@ static int load_elf_binary(struct linux_binprm *bprm) error = elf_map(bprm->file, load_bias + vaddr, elf_ppnt, elf_prot, elf_flags, total_size); if (BAD_ADDR(error)) { - retval = IS_ERR((void *)error) ? + retval = IS_ERR_VALUE(error) ? PTR_ERR((void*)error) : -EINVAL; goto out_free_dentry; } @@ -1245,7 +1245,7 @@ static int load_elf_binary(struct linux_binprm *bprm) interpreter, load_bias, interp_elf_phdata, &arch_state); - if (!IS_ERR((void *)elf_entry)) { + if (!IS_ERR_VALUE(elf_entry)) { /* * load_elf_interp() returns relocation * adjustment @@ -1254,7 +1254,7 @@ static int load_elf_binary(struct linux_binprm *bprm) elf_entry += interp_elf_ex->e_entry; } if (BAD_ADDR(elf_entry)) { - retval = IS_ERR((void *)elf_entry) ? + retval = IS_ERR_VALUE(elf_entry) ? (int)elf_entry : -EINVAL; goto out_free_dentry; }