From patchwork Wed Nov 16 20:01:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13045709 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41B8C4332F for ; Wed, 16 Nov 2022 20:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3PJGU/SlZa+dqN1RZUAL2skpneDUOETYOPqydwXt+Z8=; b=4lGV1AnI9NPZxf iWuyEqDFe24b+YCkNXxDhUEgE1j1CPWgdysyatdEHxSmVazq0xh6s2PbJmwX6LSgHz+P1Y5ILvsWo Sz0sgExAp4IgEf1NoxsUdd1j4qS5wUstNqQ5sijFNZ0T7uCDVMaZsASPCMMk0V5aX+TmS9qpJ+ZJ7 9z4J9cnOP4kea3H7cTZ5RJPdbUPI2DNDLePVsG/8LXYApmsN+WONTRlpXEYa5GJ/RhrB4EIlicMGn 8VMXgO55ySnt867ruU5/vw/nFxi+FbFi1UH+eZHS43DI9TscwwaPMLzRLvCo6GEMYm1hvOxLO4t84 5HTmkJkTRrC32wlxnUEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcB-007TV6-Qk; Wed, 16 Nov 2022 20:02:31 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOc8-007TSi-6n; Wed, 16 Nov 2022 20:02:29 +0000 Received: by mail-pj1-x102f.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so3360274pjc.3; Wed, 16 Nov 2022 12:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gWHeg8M1ItPKLADHrX13a52utCw4BMmhpRsIIQk2Fck=; b=XMsHoBVwkTCzyxRUnxAnS4OFKDbb1cNra2uUSHWdYCfwL9DGCbnSB80aMn0s2RiSv/ dzgPX4ZLZz7WWLKdqaz/iMX3PYvnXcUaA+GfcKYixqUqO1KRF6V8B041ZZiWqWvWJyRs KjxLQ3Vfcjq7dCBSBret8vz3d2bVmpMplOdSDnlrtGBX7rhcfTReRFbwKa2w6z8qipXe oNNaCNmgrlR5CcasYxh5HGGqk8bm9yBmpMm224JG/biPZESuByYdmSlCtPPPHnZAyWmS e1T9vGJOgXrxPr/+rnxsgCAuWmUYP8EJHeiZxmeC2YJN+4J1NmjeQn3fX8/s2XEpeBfr XUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gWHeg8M1ItPKLADHrX13a52utCw4BMmhpRsIIQk2Fck=; b=WgE5o1wGggTMKyhfuqH1kPIjYWnPte+Ruo8ZXJlgLAharpIK4Av2ku7DMJEe8dW0Lo Yw6xxCADu7tQZHBf9jh3wobmnQYYJoE/oaEsJdzp1GP/wHLZFuYzwGQrO8dkIQ3GqvMY l4MmSa4JY7H0q+xu3TIasL8DK2iqZdIZCSx6KbSEKoJKKU47bAUEIndT2YY0l8qHDBLV uywTwKK4ctAQY9Ohrx8ZXeNqInUjrAxL1X2rJthQrSQFOgA63+wgDQbr8e4ZPzpJV1Uu VG6orxL0a+vcuTv45KH/MyAsmazhvqWOWlcWF7gjtJ2S5g177/ujog2yhGcwIRh1AmFB J/xw== X-Gm-Message-State: ANoB5pkeYBuenpAtazpQB40LYOQd5Q9M07VtnT1/1aIJYtH6wZYncEsq OHNEw8fwXfULeaVr2TeE+C0= X-Google-Smtp-Source: AA0mqf5WKCdpBqS0le2On+nkdH9MkMJqW/Gj1R/YMS4+BiCNzeC5zLTPe4lkmEF8PNdG2C5SYXspFg== X-Received: by 2002:a17:902:c94f:b0:188:712f:dfa5 with SMTP id i15-20020a170902c94f00b00188712fdfa5mr10049999pla.140.1668628945118; Wed, 16 Nov 2022 12:02:25 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:24 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 1/5] arm64: dts: rockchip: Fix gmac phy mode to rgmii on Rock 3A SBC. Date: Wed, 16 Nov 2022 20:01:43 +0000 Message-Id: <20221116200150.4657-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_120228_261272_D95C8C95 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On rk356x ethernet phy support reduced media independent interface (RMII) and reduced gigabit media independent interface (RGMII). So set the phy mode to rgmii to support clock delay, also add TX and RX delay for phy-mode. Fix following warning [ 7.365215] rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay. [ 7.365219] rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30 [ 7.365224] rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay. [ 7.365228] rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10 Signed-off-by: Anand Moon --- V2: Fix commit message and added the RX and TX clock delay. --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index ea74ba32fbbd..e1c75532dcee 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -253,13 +253,16 @@ &gmac1 { assigned-clock-rates = <0>, <125000000>; clock_in_out = "output"; phy-handle = <&rgmii_phy1>; - phy-mode = "rgmii-id"; + phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&gmac1m1_miim &gmac1m1_tx_bus2 &gmac1m1_rx_bus2 &gmac1m1_rgmii_clk &gmac1m1_rgmii_bus>; + + tx_delay = <0x4f>; + rx_delay = <0x26>; status = "okay"; }; From patchwork Wed Nov 16 20:01:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13045708 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8CC8C433FE for ; Wed, 16 Nov 2022 20:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a5RTEgxWGN6eKNtvKBLe8jKz/up695mbV0BmpRqwKIE=; b=i7QhS2JfTmFUNa LAI+Q0SKZf446qb281IcRJUWwjHVemAp0E0hmzRKLzUcyT65VOMRHsHJ8it6WUzYo1bRmeBVkjdmW ceRWmVtIjfHPkD65ZUc7MzbeTObNsp/7tQBcyLxzdaTui4tmNbWsy0y0tVPP6QKP8CwqvT4rMnpOs EKpBZSvMGFlFxhGXkbADQQQ1Ebdl/aC/2273oR/pOmS24uFD2J1WXzEiXigOdkj1oMtMkpZyFMfzR hA6WdRCptsV7iu79/dtzCWAzPtZmqPG4DLWLkIaFUcYMzqfIeXybe5rJxmB54qw9bOS0BtOaDFFMx WMUb6d8ptGbd19iMm9DQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcP-007TaD-H3; Wed, 16 Nov 2022 20:02:45 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcE-007TVP-Aa; Wed, 16 Nov 2022 20:02:36 +0000 Received: by mail-pj1-x1030.google.com with SMTP id m14-20020a17090a3f8e00b00212dab39bcdso3460794pjc.0; Wed, 16 Nov 2022 12:02:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=As0fulMLun+eJjqjObjSTdg/PTBD9UNPaQIMHAXZOXg=; b=HF+WPJyRYMs597lubkXXvkdDma+90w/DWbM/ldOz6YR0pmeg3/ztGGIkmlIlb9vErS nLkLssypMX366ESoLasH3xX4jIb/d3PI5KNYYhpn7wjhV/81J/VMCw//RVp2PExQHVMP /UhkGVXOuZLhy/KZYOeyAgjZpSt8frCme9FgOy+5VP2uuk6Q7I3DrbpycnxZb+MWlONg g6VHarv+9bkOdWOIQ+Xt4kpq5KIew1mfIJ1xE9iTO2vzcSwJ0GcTm17t9mSK6qdpGtvx tzKLD9qGlBH59gUTR6EW5Jy601opo5iJKh69FcFHrpTn9HVXom4nItSUZXgLZaEJMiWG Bh1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=As0fulMLun+eJjqjObjSTdg/PTBD9UNPaQIMHAXZOXg=; b=jvZ+cf6ipvKC392qq/6B6JJuSnwsBaf2l5+SGHdgGSb4cKdIihBtx51LeRpsK1vKSv dtbwr+IR28CFPDeTgB8LLZwLQCh8HzWvxGWugfRc0QRrAp/n0TJXhCvfzFdhKjz/ow1A RwZGx4AMYqymd8EwHDevw9WxV1eFS1o977WBQmV54FqZ7m9nbn/Yq7Tw+QsmYOm4Vtz6 jvM5xEYnTL/bx6iPeZdCCfrzl/6hjhr6118EpRLEkjOL2Cgab7e8ceaAEmyoM8XQdB7G AoGTdUUU/+hlb4Za5AtJ8U+kd1Uh5rvTnj40rycrg38ivvKFhhufQGt0Ng7EFQtrcPZr /xbw== X-Gm-Message-State: ANoB5pnxnnqv/TjiXqtsnpMwwqsZ5OUD3O0oZ7MsRVJVSRbyUrOi6ZA6 a3xLpcdzzioriecZknhdVz8= X-Google-Smtp-Source: AA0mqf5K1iGwEgJfomYHvGNZlBmAKHUob/dddxCYWbbDWYXMYIUVPRGmp/cnjjkHHHFqrb3PbXovHA== X-Received: by 2002:a17:902:ba91:b0:188:c395:1748 with SMTP id k17-20020a170902ba9100b00188c3951748mr10019993pls.155.1668628951901; Wed, 16 Nov 2022 12:02:31 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:31 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 2/5] arm64: dts: rockchip: Add support of external clock to ethernet node on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:44 +0000 Message-Id: <20221116200150.4657-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_120234_436752_BA7104BC X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add support of external clock gmac1_clkin which is used as input clock to ethernet node. Signed-off-by: Anand Moon Reviewed-by: Michael Riesch Tested-by: Michael Riesch --- V2: None --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index e1c75532dcee..b848282ea005 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -32,6 +32,13 @@ hdmi_con_in: endpoint { }; }; + gmac1_clkin: external-gmac1-clock { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "gmac1_clkin"; + #clock-cells = <0>; + }; + leds { compatible = "gpio-leds"; @@ -249,9 +256,8 @@ &cpu3 { &gmac1 { assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>; - assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>; - assigned-clock-rates = <0>, <125000000>; - clock_in_out = "output"; + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&gmac1_clkin>; + clock_in_out = "input"; phy-handle = <&rgmii_phy1>; phy-mode = "rgmii"; pinctrl-names = "default"; @@ -259,6 +265,7 @@ &gmac1 { &gmac1m1_tx_bus2 &gmac1m1_rx_bus2 &gmac1m1_rgmii_clk + &gmac1m1_clkinout &gmac1m1_rgmii_bus>; tx_delay = <0x4f>; From patchwork Wed Nov 16 20:01:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13045710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AB07C4332F for ; Wed, 16 Nov 2022 20:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yjVn4GX/E7AyF8z6dHgOPkrQdtW8C/DznnXzBmUFW4M=; b=ZV3/KpCZ5Ylwee hIm7+XbGKhj2DJdbRse5GbxVO/jvUzm4ufkUDuJ3idPl4mCqbvIJqBeZAsPCYbWSdAQKxGD4WS+JA KoBl2YP5uJnMKLQpe3GGvyTAR3p7gE6tey8S0sbl6WjtnlUIoOuivPb7MvuDwUSHE1VYGWYx9wZ6i VA1t8rqXg/mupqH/xsIMZcebP7Yx0dbVpZwlk4sCAhg67SQMRTo0FIG1yyHtRl5vUn2C8OWiiX2md 1B0/mtHuCk1hmKJZSqTFMXMRdJGybigZc64fB1zOxll7Rw3vtY6O56zA1TgqXw0Wvz8jiaCfWQPys 23IMXuAFVuaAapilcHeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcc-007TeK-79; Wed, 16 Nov 2022 20:02:58 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcL-007TXP-CT; Wed, 16 Nov 2022 20:02:53 +0000 Received: by mail-pg1-x533.google.com with SMTP id v3so17730643pgh.4; Wed, 16 Nov 2022 12:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9u48IeVxeYRpqZXDq8TEy2jgfthr+zPe9V44R0XXV6s=; b=OJlre6S9pakulZA+yEGpONatIYHUbfqM2duW/AMNUeogjFygAv4bC1gl8iiKIN6L6l 9V9rlywuoLnK5SwYcyVQS2YSTt3Kqvii4TqEmU2ENGMclvuydNlmNCAUteaOS75MjF/Y MhGThK8Twowj8WQeQ9lAWEYmiILMeQtIu+PiP3qqkDG6rsjtDicG+9RKXHykP+xknhc6 X6gs7BePV5RcqSFi1V8QY3DelJ/Ut7FesSt/BazrNm21n79ND4L3ithnApPPwZpaJJfM TAh28RRnZv87qP/NiskyIMIboOAh8QHacJG3uShCw95I0tDHwrsw/zQMQFyCOGnu5Bag R17Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9u48IeVxeYRpqZXDq8TEy2jgfthr+zPe9V44R0XXV6s=; b=pKfVK6z4QX7IOKah/V3v3Duq4sWMEMG5Z4rbyo+G2qbh5g/8IXGOUEUcc78VBgrPjj mICWYP0PIJ35i4/7UpNENnecJWlPpSW8gTsnKX/QVs+Mnh+HbFqyUKirVOQhuW7dNGfg KnEyMYzMWS0Kl2nUpdfTy5VAvyE2eKXpBy1tMJp+YQWJlW11URW85/IBiOq1a4Zp15Nv wU1kALh0pEzQspbCz+zfk5sWNodZ/CxkH7gR92xolPUYZRJ5CxQ5H7E0I+roKYQ+9rjx u+spnsNUnytmPBsRvk5uSAHWmiAUafjau4NJXZTo4DBJaPEqg1R+c3RpT7+MQ/B/BnKu Fz3w== X-Gm-Message-State: ANoB5pkLBhLZLDmzbaUih5w33J/TXvQk8On688DDqGYP1Z+G8GYGjReA QPaS4Iy2X0F2kVC/FYNei1E= X-Google-Smtp-Source: AA0mqf790rR++Tn3av8PLwCoZX/3FlqthhDW8C6waWJTH8vWZ4I6VdRk+YNTEVcH7PvR8/e6wp9Pyg== X-Received: by 2002:a63:5f4c:0:b0:45f:fc05:270b with SMTP id t73-20020a635f4c000000b0045ffc05270bmr21765809pgb.14.1668628958408; Wed, 16 Nov 2022 12:02:38 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:37 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 3/5] arm64: dts: rockchip: Add support of regulator for ethernet node on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:45 +0000 Message-Id: <20221116200150.4657-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_120241_483792_E9B6C65E X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add regulator support for ethernet node Fix following warning. [ 7.365199] rk_gmac-dwmac fe010000.ethernet: no regulator found Signed-off-by: Anand Moon Acked-by: Michael Riesch Tested-by: Michael Riesch --- v2: new patch added --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index b848282ea005..5378254c57ca 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -260,6 +260,7 @@ &gmac1 { clock_in_out = "input"; phy-handle = <&rgmii_phy1>; phy-mode = "rgmii"; + phy-supply = <&vcc_3v3>; pinctrl-names = "default"; pinctrl-0 = <&gmac1m1_miim &gmac1m1_tx_bus2 From patchwork Wed Nov 16 20:01:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13045711 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E28CBC4332F for ; Wed, 16 Nov 2022 20:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EDsCbkzD8SLKzWmwuCed3+DxY2vnd/hxJH6aqdI7AeY=; b=nCkGxb/KNct5QW Z3kVtwDnDwFE1Kz3sXWDQaeNeXcCRPk5zHvrAP8iub8PU3+L3TdIkjtB0bQaPnlPhcH8VzsW9UNZR 2S/O6KfzjfZSMPGK4OypBLYdVPOYqBdggdC5GCLex9hbv4SAbhFxcYdM2J/W7NiQCjKo7XkOdo8Jq wXMuuWibyW8haoXEqnU+JZ6BfLYcHiZiukE0RRymNavW8U2zaYMW3AQnB5Ugin4O0jDJKntunSy+l 5Vr/HWCuNNw5rKS2aHdj2KyCgBW9UNd1L1AfqsvFNDzV5WISeQnwGpxVskLx83v+BGmsi4eL6E2IV be+eU1xhYPhXE+Rnzf3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcv-007Tik-72; Wed, 16 Nov 2022 20:03:17 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOca-007Tds-Af; Wed, 16 Nov 2022 20:02:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=Hlf4RPnys2xlptR6hKKlXQBW5qSMO1/p3GZVaaL5DEk=; b=FN+Sd97riK2aSwUH5qVWSThSvj e+1Fn+6l9/ySWUBqVvbqJZTm/Z6Cvrq4+TqVg0ZYqzrFgn81vWytp0ACoTe9z58BTVYXCvfip0Q1E Joh0QKVBf+7T2yNfcptkzS1BZYxUg0+dXe5YyMQn80CdWie367Z1BUTQpzuSp7wMCE604I9/xWr86 GIcw2tqDjU7WyI5UKmzhXqOzqpZw05mTI4PD9gApjYbNPaYjtS963/HcHN30BqBXtBOmwOY8JjihR yW8zWc8YOXsj0yMrnNo7KEXbxXQf8eYHgIZfJiswF6i9YceqcYq+oN+kBAfkkypUUuWCi4xlOPYcB d8s/Nrng==; Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOcS-001SGq-7Z; Wed, 16 Nov 2022 20:02:54 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 136so17743197pga.1; Wed, 16 Nov 2022 12:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hlf4RPnys2xlptR6hKKlXQBW5qSMO1/p3GZVaaL5DEk=; b=Q1vmNkgnMV1rfn9shs7EUPv1E8qMY58IiMlv0wjSwmEEfxjXjMTTfXyJEBhBiZo4RV 1jqoXycSq7g9T26erjmpPfcESFrKSgB+0GZ9uXRuDnLliTwzcp3CITDb5rLft3pHUUpi Uk/ztpz5RY8cTkGXRuGcM71hNwq5QyUBzol5xPf0dZrny2lfx3BZa6ABxvJWlWOVNpv/ XHOslswzR/EJoP37wdNKNz8kCdbb+T/xvt0e+VpK+v0o88GygLfHfFUJ01ijAAnOvSuC 2OvmU1Qfgf4o7q2CmJmFZvLTNWSz59rzYkXWJyMLkM4/jBLVp2C4joBXxUv+a2T27LLc EBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hlf4RPnys2xlptR6hKKlXQBW5qSMO1/p3GZVaaL5DEk=; b=ftaSY0VWOTpPoDycSZI2vwcPey4KWO9xsn9V+36RDdIP8yolwL2hEZSjYfT5mXHF+G EXrJUtEs0TRVGvk2j1blEC2k3unbULcjabGNUX9iRWvLLdPbxZxsm5tNajHd/bTbFXpd fs4A56cCIM5rrMt8qTDZnPxb5+deCY5DbsDTk1NxAavRLGLaoK0Il7n0nOizs979UViw UWoET4oRs8e2mOPCwNJ9RsRPAlOHFXz5mqKlm6hymRDD4NjOOtC474hGj5kPaEX4dlYY T0+wbCj3X6xCLe9kyVUm4YyRL0B1+oWUOnqysxzupEHyLtwbybXkobRQlVRn5SwRAWR5 Q1tQ== X-Gm-Message-State: ANoB5plebUXBsxg4yOG3nwKdfjmvBm9itzP8+S3J+hz8IL6d6nhMLhAi 8+81XqOBzLTqF6VihLzn6F8= X-Google-Smtp-Source: AA0mqf6qbEHBcFkhsJEvfxwuN4QewKdZ0Bpri9Q9/YF+J2TGtG47mtLJ3TFInumyyIdAseU3vRyqgQ== X-Received: by 2002:a05:6a00:4186:b0:56b:d951:67d2 with SMTP id ca6-20020a056a00418600b0056bd95167d2mr24621348pfb.55.1668628964901; Wed, 16 Nov 2022 12:02:44 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:44 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 4/5] arm64: dts: rockchip: Add support of interrupt to ethernet node on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:46 +0000 Message-Id: <20221116200150.4657-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_200248_488435_30CCCC1C X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As per the shematic gmac1 support gpio interrupt controller GMAC1_INT/PMEB_GPIO3_A7 add the support for this. Signed-off-by: Anand Moon --- v2: new patch added --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index 5378254c57ca..9f84a23a8789 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -588,10 +588,14 @@ rgmii_phy1: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x0>; pinctrl-names = "default"; - pinctrl-0 = <ð_phy_rst>; + pinctrl-0 = <ð_phy_rst>, <ð_phy_int>; reset-assert-us = <20000>; reset-deassert-us = <100000>; reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>; + interrupt-parent = <&gpio3>; + /* GMAC1_INT/PMEB_GPIO3_A7 */ + interrupts = ; + #interrupt-cells = <1>; }; }; @@ -630,6 +634,10 @@ vcc_mipi_en: vcc_mipi_en { }; ethernet { + eth_phy_int: eth-phy-int { + rockchip,pins = <3 RK_PA7 RK_FUNC_GPIO &pcfg_pull_down>; + }; + eth_phy_rst: eth_phy_rst { rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; }; From patchwork Wed Nov 16 20:01:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13045713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 379EAC4332F for ; Wed, 16 Nov 2022 20:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M9C6QpiXzJ58WPAciELRjH0Dg+b82juPLJ88sBoYpK8=; b=sgg+0VZR//4Y+R TMwUvbicnM0+PpdhJlqC86usHJwrO9h9NFP8h6VFStVKnzM0GdTGiCmZGxDgqDS+v1PRSv/LAsykM XgIpabGhUz2bt5EovC7vaOfF9NCN3lg+e6MQKEj3L1K0S4kwrkSR37hlpCPL77Eiwz8Ioc+iINSd/ IpZK+VlhYSzI7PDi1VnODD+Z8DhhPQRXonT7zo8rSxtSmhIrzQdQhBqXvqunjPy8hJ56/myZYVXLj qstWb4HX+O97gDAuTRMkEI9CRH6i5sznObxIuRaZI6L083IVHdf70xW6L/4dsnvJTFAq4syyvjeKh URVhlYayWJY2Z/LNjHKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOe6-007UPz-Hs; Wed, 16 Nov 2022 20:04:31 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovOce-007Tee-VG; Wed, 16 Nov 2022 20:03:15 +0000 Received: by mail-pf1-x431.google.com with SMTP id q9so18506709pfg.5; Wed, 16 Nov 2022 12:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dU5Mwb4CLrFeMhe4gtPSXHFZzIZzSCF10R2Jay+I0+Y=; b=fZt/DptU/WyyXomIIYhusRu/ggtb7lQmge+tN9aC26JOHUiotfJ6pNPE0sOZsXFlHA SgeDoeiwbjAZfkgqTVCECcv7sWywKNuPLRdXB2lRWWgg1k051QO2wO27w3GpXYG67DmI FBc61+kKx9u3T8aPUbm4mWTchGz3YT6lsXgp6Ikq8d/gCmzPV1sum84ZZ8KtlSWELjkp s9JSmZIn2Qu5zRciJVrRw9g0Br1hI3QpPZLRyl6iZ3/4k0Cy16ZuG9/RVTWW1T4dZMma PQENYUq9QG6GJX+VI+8yQwhjbChPWtHurVy20PsG4eSo+W5qreGGu90lFrtHhMBdfTj2 NvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dU5Mwb4CLrFeMhe4gtPSXHFZzIZzSCF10R2Jay+I0+Y=; b=nbOpWxsDUUZtSNXUynFZEyvkMX5qNAuG7jfgwp+EO7T9LuAIJzFa3UZ2mWEsr3VcbW RN7kUH4/Wx/Grad9HDBA/aSMvJGdVLbT/eqf2FtNSgwWAeuBhtiTtMXEKZ1XtTnUsK06 h1qgMnvKnT8PhuvhfgIeu/VONOI20cq+QjhvB3vOB1hzqS7q8BCAvLyk1XCiYYrB5W2V wh66IPHuX0VfYiZLMrikUY85qXVKIpJJAdt8qtDBDXbKGfhFKeCpJFT6OaizcCE/uoSz eW9qKuMu15I8l6/MjDuteFUqvMpr21WopgrCp8+++3KnZtFOCwKYEygAs5pQ1at3kVbj k5yA== X-Gm-Message-State: ANoB5pnc0vFhsMWfLHGrMPPN7+LRD06E/Bs/lnSFAo1qkX0u2IzE4/dR t8C6yuCYtTbAFc4Ga8y/q6I= X-Google-Smtp-Source: AA0mqf65fkbouqf7pu70romJDYuiqQRkWpQa9l+BjQMgcgn/bj4rOIJ3+Bmx2ZNSZkKx+2HoKXBR6A== X-Received: by 2002:a05:6a00:3689:b0:563:3d81:7faf with SMTP id dw9-20020a056a00368900b005633d817fafmr24476557pfb.45.1668628978034; Wed, 16 Nov 2022 12:02:58 -0800 (PST) Received: from localhost.localdomain ([103.51.72.182]) by smtp.gmail.com with ESMTPSA id s18-20020a170903215200b00186a6b6350esm12423950ple.268.2022.11.16.12.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:02:57 -0800 (PST) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: Anand Moon , Chukun Pan , Michael Riesch , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [linux-next-v2 5/5] arm64: dts: rockchip: Add missing of ethernet-phy-id to reset the phy on Rock 3A SBC Date: Wed, 16 Nov 2022 20:01:48 +0000 Message-Id: <20221116200150.4657-7-linux.amoon@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116200150.4657-1-linux.amoon@gmail.com> References: <20221116200150.4657-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_120301_064659_67925D7B X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add MDIO description with ethernet-phy-id compatible string which enable calling reset of the phy. The PHY will then be probed, independent of if it can be found on the bus or not, and that probing will enable the GPIO. ethernet-phy-id is read from ethenet register dump reg2 and reg3. Fix following warning. [ 12.323417] rk_gmac-dwmac fe010000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0 [ 12.324078] rk_gmac-dwmac fe010000.ethernet eth0: no phy at addr -1 [ 12.324099] rk_gmac-dwmac fe010000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19) Signed-off-by: Anand Moon --- V2: new to the patch series. alarm@rock-3a:~$ sudo ethtool -d eth0 [sudo] password for alarm: ST GMAC Registers GMAC Registers Reg0 0x08072203 Reg1 0x00000000 Reg2 0x00000404 Reg3 0x00000000 Reg4 0x00000002 --- arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts index 9f84a23a8789..fe36156a5017 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts @@ -585,7 +585,7 @@ &i2s2_2ch { &mdio1 { rgmii_phy1: ethernet-phy@0 { - compatible = "ethernet-phy-ieee802.3-c22"; + compatible = "ethernet-phy-id0000.0404", "ethernet-phy-ieee802.3-c22"; reg = <0x0>; pinctrl-names = "default"; pinctrl-0 = <ð_phy_rst>, <ð_phy_int>;