From patchwork Tue Jan 22 12:41:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juha-Pekka Heikkila X-Patchwork-Id: 10775453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 207696C2 for ; Tue, 22 Jan 2019 12:42:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FADC2A360 for ; Tue, 22 Jan 2019 12:42:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 031692A36C; Tue, 22 Jan 2019 12:42:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B2A822A360 for ; Tue, 22 Jan 2019 12:42:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5F196ECC1; Tue, 22 Jan 2019 12:42:02 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FCE26ECC1 for ; Tue, 22 Jan 2019 12:42:02 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id i12so11713545pfo.7 for ; Tue, 22 Jan 2019 04:42:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6UzqSVbGmv8Yu6H/Aldicb+7/tnBqKylYbpspG7PER4=; b=hFIL6F36e/LH8xPUlY9mqZNz8cw1Lhu42BITWH526tBAoLJ64cHKdnD3WCYREkG5Rk WYbll9/sOv29uBCpSQKXlQZXasvRXFQCZ7e8w1j4wyqyUxiGL9ONBMmN64PBcSDvubKJ 7VaUfkovc/fRdk8qBCiUEB7Q74buftLqJvUX8uNDZhHIPt5lTOsgdx+c+yJ8j/shxa6V DTWYw/EXBRsP/EBWKESYGihAoCXHSa9kxcy92sp8TxRpapatuEdWGrcUCaJvOGGF+4Ue aZzzt/U1eSw7fnBtS0r+B/K0OY5rfodl6kcZVsQVn4pcaTt2gnX5EtLB72ekzosBswpo /ZjA== X-Gm-Message-State: AJcUukeyIddoCxGnswg6TYYga0UDb5mTIU4OSHc90DPyDI76MvsoeMcK pIiua/fRj0ltxtkYaU0Z19ojCOG9+Cs= X-Google-Smtp-Source: ALg8bN49c3ZOp+UgbLzL+zNx6+DjOp/JzvIJGM2m0oG0ETaoJCUfLFWqM7yjaMoS5QeHmZybpE07dw== X-Received: by 2002:a63:f444:: with SMTP id p4mr31625555pgk.124.1548160921644; Tue, 22 Jan 2019 04:42:01 -0800 (PST) Received: from jheikkil-mobl.fi.intel.com (jfdmzpr05-ext.jf.intel.com. [134.134.139.74]) by smtp.gmail.com with ESMTPSA id c23sm18846315pfi.83.2019.01.22.04.41.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Jan 2019 04:42:01 -0800 (PST) From: Juha-Pekka Heikkila To: intel-gfx@lists.freedesktop.org Date: Tue, 22 Jan 2019 14:41:49 +0200 Message-Id: <1548160909-11491-1-git-send-email-juhapekka.heikkila@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [Intel-gfx] [PATCH] drm/i915: Use fb width to measure fb width instead of visible plane width when verify NV12 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Using visible plane width for testing NV12 source suitability may fail randomly when plane is clipped. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109381 Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index b02d3d9..a15c5ef 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -1516,7 +1516,7 @@ static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_s { const struct drm_framebuffer *fb = plane_state->base.fb; unsigned int rotation = plane_state->base.rotation; - int src_w = drm_rect_width(&plane_state->base.src) >> 16; + int src_w = plane_state->base.fb->width; /* Display WA #1106 */ if (fb->format->format == DRM_FORMAT_NV12 && src_w & 3 &&