From patchwork Tue Nov 29 01:29:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 13058094 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56ACAC46467 for ; Tue, 29 Nov 2022 01:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kYxotAXwiduwskoZBxhWSKtfFEj7JjTb00XDbxpV25w=; b=BUDMA0EInnm8Sd n2WYMySsOKNjuokO9xFPA3uWtJcf0ncmDtVKO0RoOepZrBbluTIAuEsjCMX3wCirIh1ZgGQ2Jut11 +E59/W8H1a5D/+uX/rCPdSQyjji2JHTP2lCwAhgDRObgCQ4gHDleu00xGNztvHalHL69bwl3p9Yq5 GjqKr9bEA/SpPlJidNfScEEXXLySxtxbcnGJDZeLYJVLI/yoK+OWRe7J6ShEfDXxuRdQkSnClaXgd 2MVQZk0sautFjksA1vVlCCGKchJ8DxkRvScmEypuQVOyamk+aPLLZZh0y7fnhD9iuazHJrc2bk4Yg ix1dLdnGA17zhdD1XxLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozpRK-004zDq-6x; Tue, 29 Nov 2022 01:29:38 +0000 Received: from out30-8.freemail.mail.aliyun.com ([115.124.30.8]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozpRG-004zCZ-Hx for linux-arm-kernel@lists.infradead.org; Tue, 29 Nov 2022 01:29:36 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VVyDh8n_1669685364; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VVyDh8n_1669685364) by smtp.aliyun-inc.com; Tue, 29 Nov 2022 09:29:25 +0800 From: Yang Li To: paul.kocialkowski@bootlin.com Cc: mchehab@kernel.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] staging: media: Remove surplus dev_err() when using platform_get_irq() Date: Tue, 29 Nov 2022 09:29:23 +0800 Message-Id: <20221129012923.111691-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_172934_805498_27591E20 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. ./drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:390:2-9: line 390 is redundant because platform_get_irq() already prints an error Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3274 Reported-by: Abaci Robot Signed-off-by: Yang Li Acked-by: Jernej Skrabec Acked-by: Paul Kocialkowski --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c index 7b7947509b69..a6e813ff413a 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c @@ -387,7 +387,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev, irq = platform_get_irq(platform_dev, 0); if (irq < 0) { - dev_err(dev, "failed to get interrupt\n"); ret = -ENXIO; goto error_clock_rate_exclusive; }