From patchwork Tue Jan 22 21:50:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E1A11390 for ; Tue, 22 Jan 2019 21:51:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B52E2B741 for ; Tue, 22 Jan 2019 21:51:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F5632B748; Tue, 22 Jan 2019 21:51:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B38F32B741 for ; Tue, 22 Jan 2019 21:51:55 +0000 (UTC) Received: from localhost ([127.0.0.1]:50777 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3xa-0008WU-W0 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:51:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wA-0007Js-0r for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3w4-0007nr-Sb for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:21 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:38146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3w2-0007jE-RR for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:19 -0500 Received: by mail-wr1-x441.google.com with SMTP id v13so83358wrw.5 for ; Tue, 22 Jan 2019 13:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=KvLilcT7T/5EypOW6sb2RhODzswUWt58bUcNYBmvVMxpZPVd/DLHLvbOBgYWoWYQds q0g7HC/Cl3RT6kHtz10sP1PjnSRjDprYMTgcnLeLEbhFy6DTDVfeP5baFMxxRZ+g4laj nzR6Yg07qThPXuomsa6zn68zBr0aD+UVeFgIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1nYURC9J3WUUZatMQMjMushGVVnRe2BtZ2VT+vU0n5Y=; b=lE7ksnZbAL53h7JpMFmTzSnFv5xWZHPVpL4mY3SL2i38xyTahny9PGuKxEHdly3xTO atCrWZpJljlWnBQHoTF8E66c4J0IGjTKPlPyFhEkV/z897O0UGuGUpe3OBNGdS37DCxW h9zbk1TfT6YXlAzrpDCZ+V67GJmPQEnFv9BHImUtNjq+vs9DM7OXX0+tLHrqzkOQeUgH I5FMgx7dF4r1q7IKejqGor25jAsfikgwKfFZo8CA0KufYrN3CdygapH8nGUaT0tzCNON he18nmqYMkgk6x6Ew5LsGNFOKGKWE4fRTIyXt2zcsnzNHcxj92in8YXt1ZIBtSBYBOzy OyWA== X-Gm-Message-State: AJcUukevAWB5KwTCgPFej8pkwCZ0DxhLkP1LHBUXFHcQDiCKOrc6guW6 mWBh96RygyWRMwvZW4pHQj3vZQ== X-Google-Smtp-Source: ALg8bN78OxZROHVFNQg7/NuJnoz5JMQqIVABXzn1ggPVbHqgD4ZfBxE/KVOCeYQxc8Zgo9fKp2nCfg== X-Received: by 2002:a5d:4a0c:: with SMTP id m12mr34170832wrq.38.1548193817615; Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p4sm81010790wrs.74.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3B6243E0807; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:06 +0000 Message-Id: <20190122215016.18697-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 01/11] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r; From patchwork Tue Jan 22 21:50:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776341 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C4ACF1390 for ; Tue, 22 Jan 2019 21:58:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A35A528DC3 for ; Tue, 22 Jan 2019 21:58:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 905A028E91; Tue, 22 Jan 2019 21:58:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D13928EB6 for ; Tue, 22 Jan 2019 21:58:49 +0000 (UTC) Received: from localhost ([127.0.0.1]:50907 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm44G-0006vM-Gi for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:58:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wP-0007RT-3E for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wM-0008CJ-Iv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:40 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wK-0007l2-JJ for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:37 -0500 Received: by mail-wr1-x444.google.com with SMTP id z5so50588wrt.11 for ; Tue, 22 Jan 2019 13:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=eaNrnb9lJUzjFslVmypTpso1EiPUsPfYAhRJ04YXOhFS4b9k7aIFIxy9jpTkRjvlZj S9myyW4AG7mRTbeRsA8peKMhcyJQXVzTQbVyNu+gUMAhO0DGhPh08F6Ql+dsbipD7JpA 3ONq5X/qe0EgErmda5B1XR6/HxfsWdbayJ+7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=Vj4/TCfoOIPOz7rmbWxaLvisqsoJ16jfszOp0JsSuPMcM1cNbNumbqyPF621KECeq2 fmzZYsDuAszy6SCP8QjN94z1f1lDkdcIIHD+n7RKXe/N2SBolbfffrV9oAm4YwwEFV97 cfBLE65N9vA86s0R29Q6JZ8Uqns50Y8OaevLWAuRZQg23R0Gag7QTHpMjGrKasdffPay maauAUbQmu1fscXbsgzZUNZFLLaVq1SfSM5lGR0MI2IimBsAu/7+Le+dw53OFxMSC5NN m61RTkYWWPOqC2QIlU/HjsNYDTE1Pj/dNqQt0g7uC+WS7Pb6KgWd8BN/iOMRSsb5EePi AJ0g== X-Gm-Message-State: AJcUukfEG9OSbsR8rs602pjHzr02xKf5aIbrJwo5ivrJ5ly4yvBD1eqa 7rmZTgbhgQpCzqSRASzf9ZKKjiST2Qo= X-Google-Smtp-Source: ALg8bN6zbnGBj7L+8oIuEK/23MMr4Sm2XFRnwt2X+qPuhhU1F6Ub+pAkwjSbznDc3GwZ0siV4GC37w== X-Received: by 2002:adf:fc09:: with SMTP id i9mr32149284wrr.299.1548193818596; Tue, 22 Jan 2019 13:50:18 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c13sm108608405wrb.38.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 4DC923E08E3; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:07 +0000 Message-Id: <20190122215016.18697-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v3 02/11] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached(); From patchwork Tue Jan 22 21:50:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 05F1C1390 for ; Tue, 22 Jan 2019 21:55:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E82F92B5A5 for ; Tue, 22 Jan 2019 21:55:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DCCED2B5E9; Tue, 22 Jan 2019 21:55:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8A94E2B5A5 for ; Tue, 22 Jan 2019 21:55:45 +0000 (UTC) Received: from localhost ([127.0.0.1]:50863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm41I-0003yo-Df for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:55:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wD-0007LO-85 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wA-0007wA-Lz for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:29 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3w6-0007mP-9w for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:25 -0500 Received: by mail-wr1-x443.google.com with SMTP id t27so77683wra.6 for ; Tue, 22 Jan 2019 13:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gZImyNtt7AiS5wLW217m9CulCQW4HP3CZXV2WKdWr+k=; b=ZHempPUzgdYfOG+cL99bYuwX8nJx8SPLtXl3y99YKeYzRMEUEnmkgVvuo8cqMB3P50 ARp2lzHw+Ghl6o4yFQF8NsSkC04R8yYu5bH3snscOcB7YTGF8PY1e8BZZGHn1NamJ/iz 3UlTXESU3+6d8kRFdQo+SXh/otCCGrqSWRO7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gZImyNtt7AiS5wLW217m9CulCQW4HP3CZXV2WKdWr+k=; b=PeAQSo/Gp4VASPYfkesh91EBQkrXxEdsOL0HMEqYTeeC/tlMK+MUY3W9yCSUOpmI0U 0LFYgsgC/1v8h/G5clbri+p69KV6EmysUjC3zXcPrBgFZKVbRjKY6YSPBeCleX7HqLgC h71bO0LEiVY7YgX6jBdzz0RdUaV11f86dkjZE2Xc/n77Mmf+/xm4hqL5gQ8k1DknlYav xaNk6VRnSUa/wh4YBaSmWsyu/3rNR9MJuBExwzEuxLiToFfbRbQ4uvd0L4BvN1ZAAaC1 kTpdzX7PrtEk+SVJpeWG/fvJGEOHtKP/5emu1S1kL6D4uPTjyulVnz5Z+D9vb4UlaZYJ iZWQ== X-Gm-Message-State: AJcUukeDvqN/o5HhnufGVMh3Jas2Bfp8UhKGrQ/N/r9JyDkl9GzWrvbV l8wAd1oK6I7mJxTuXCgt+6np1fR5zF8= X-Google-Smtp-Source: ALg8bN4azh6FFNJ0OjEAtQRkySznk3Neo4qLEmFZetDJEdTocXxwRBLT5WkcO87td7+4K9VAMtsqWQ== X-Received: by 2002:adf:fa05:: with SMTP id m5mr33815400wrr.155.1548193819114; Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id q9sm75353684wrv.26.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 631A03E0971; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:08 +0000 Message-Id: <20190122215016.18697-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v3 03/11] berkeley-testfloat-3: pull changes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" - fail: constify fail_programName Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/berkeley-testfloat-3 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3 index ca9fa2ba05..5a59dcec19 160000 --- a/tests/fp/berkeley-testfloat-3 +++ b/tests/fp/berkeley-testfloat-3 @@ -1 +1 @@ -Subproject commit ca9fa2ba05625ba929958f163b01747e07dd39cc +Subproject commit 5a59dcec19327396a011a17fd924aed4fec416b3 From patchwork Tue Jan 22 21:50:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776331 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9477C1390 for ; Tue, 22 Jan 2019 21:52:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 840C12B741 for ; Tue, 22 Jan 2019 21:52:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7602C2B748; Tue, 22 Jan 2019 21:52:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 24FC82B741 for ; Tue, 22 Jan 2019 21:52:12 +0000 (UTC) Received: from localhost ([127.0.0.1]:50779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3xq-0000LG-T0 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:52:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wL-0007OS-7n for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wI-00084T-2o for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:35 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wH-0007n0-52 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:33 -0500 Received: by mail-wr1-x42f.google.com with SMTP id r10so56540wrs.10 for ; Tue, 22 Jan 2019 13:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OWcHEp1BPzETLyMerlsa5+Hn4wdXJpxzWX+97qsuLY4=; b=B+xMoClLjdMAkkugg673u5UMI2e1mXXzdV7aE0vbroVereThxwkscULkJTUvGCgwpK NiBONi4eSLWSNDjAyGlPwQNSZQ0P0gmXftSYuuevR6Q6tSnGtnIbbP3vfxIPuiY7XwOy gnDMmF2Sr8E0NuWCLX3A/LNWyPRqYs4ToRcBo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OWcHEp1BPzETLyMerlsa5+Hn4wdXJpxzWX+97qsuLY4=; b=J8JxagrGrUEAitNy4mQy6SO06tatbIGxyGWWfXO1qw7Xt2YaV9GnYg+aeDbNDbP+GI Ntivn5DBDjvn6gOU8e7bGrV1OJ71gZIUwZxB/Uf3mseZckeFsZkZAv5XupZLUncmoDle BPlApYleHtDzwoWW0nMeYxm5UX3qkdtUtgfbNr93IhTDRtcIWpB8LZpVC6EI7Yty1Sro YrtsoVcDKY9InLMcmTnMyACadnsTnv2yWLjBnyJO+YJI9FWDFLwTWK/d0ckasIwSMt1Z emIw+CFu+k3VeKBfqOBl23EEh0YEkNBh2/sqmAPmCn6FKb0rWaUCZwiWVyQTJ2/wxtfj rfYw== X-Gm-Message-State: AJcUukepF9eihSYZG6hkHxkA4b6VIZzCMSL0gFBWP5f+QGv/MOWdhmGK TmDNORPvkwgp2vBpIs9sWOvT9A== X-Google-Smtp-Source: ALg8bN6ebrUP42jkYDlP9l4hKeCqhpo9pUtJ9Ds4EYUfLyYVNnRTjPem/h7wHkFEqboiRne5YxJwQA== X-Received: by 2002:a5d:4acb:: with SMTP id y11mr5384373wrs.281.1548193819758; Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id e17sm154618562wri.36.2019.01.22.13.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:17 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 75CE53E09BE; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:09 +0000 Message-Id: <20190122215016.18697-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PATCH v3 04/11] tests/fp/Makefile: do not use gcc-only -W flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" The build now completes in both gcc and clang. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/fp/Makefile b/tests/fp/Makefile index 5019dcdca0..5a35e7c210 100644 --- a/tests/fp/Makefile +++ b/tests/fp/Makefile @@ -65,8 +65,7 @@ QEMU_CFLAGS += $(TF_OPTS) TF_CFLAGS := TF_CFLAGS += -Wno-strict-prototypes TF_CFLAGS += -Wno-unknown-pragmas -TF_CFLAGS += -Wno-discarded-qualifiers -TF_CFLAGS += -Wno-maybe-uninitialized +TF_CFLAGS += -Wno-uninitialized TF_CFLAGS += -Wno-missing-prototypes TF_CFLAGS += -Wno-return-type TF_CFLAGS += -Wno-unused-function From patchwork Tue Jan 22 21:50:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776347 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E857F1390 for ; Tue, 22 Jan 2019 22:04:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D861B2B109 for ; Tue, 22 Jan 2019 22:04:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA14F2B10C; Tue, 22 Jan 2019 22:04:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 712BC2B109 for ; Tue, 22 Jan 2019 22:04:29 +0000 (UTC) Received: from localhost ([127.0.0.1]:51010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm49k-0002OT-QK for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 17:04:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wR-0007TM-2g for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008GK-Sh for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:39877) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007p5-I0 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x341.google.com with SMTP id y8so75583wmi.4 for ; Tue, 22 Jan 2019 13:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kDdMLOeQCo1DbHRKXtgMY221tGVIm99Vb8Z6bllUC2U=; b=R3uT0wqe2+7SmjtPweR215y4cIf7K9cgAtELwn2SzP1VKT3pwlLwTCRtHY9a8sn8gv SBOXA35Y56znxwSLlaVnBKznsavaA8yLzhnCaYBLo1bIz/ojX3kKNKXgXRioPWSLcdwW 5arVwzd2UkiAFOX1klD1BKVfgX57N0aeBxJTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kDdMLOeQCo1DbHRKXtgMY221tGVIm99Vb8Z6bllUC2U=; b=BUPX1fnXHyVAEDWjmyqvbj9XFW3ev+Q4x7pAg1J856xCL23f4ltbE81Ul52/tlWbnM O0Y1HhC9l9KwHmTfmTC7nJDXDm7tgLBzyzzcCv/Q39+ZiklnMNykjoVsVRRz+ojxnKBD C6m1mwGphxydjMR9Manj5Sg6xxVLr5iVslBUeDXzysqzncYJQu3mLS4nn8JZ8Br18qPH Vc/LJ4QoRY0ge3pflL/sJ+kfrZAbYVbPqfv527xyM89e9urjljQFLetZJDYs2K6JoYTw Hxq1l2J2P1UwuWYweJbjKvvhD6WdI0UdNCiuiI7cmH4Krrjc9/PXTXm2XQ6I7uiAAxzK NkHw== X-Gm-Message-State: AJcUuke4BPCZ9m0vXjPpHPA+uBvxcERDFsPGYK34QTs0rQ+XlMXguKwY roWiwvWcf7xe5DyNSKg57QZX3Q== X-Google-Smtp-Source: ALg8bN7AWgY8G5UpoSUl380FUueExU6bSVRRtWigB2QJBAFQmNuYCkabhmPa0NVLGp6sT1GTRVm9AQ== X-Received: by 2002:a1c:7eca:: with SMTP id z193mr175136wmc.5.1548193821782; Tue, 22 Jan 2019 13:50:21 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t70sm84764921wmd.36.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 887713E0AA5; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:10 +0000 Message-Id: <20190122215016.18697-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 05/11] fp-test: fix signature of slow_clear_flags and qemu_clear_flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" To match the type in testfloat. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/fp-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c index fca576309c..2a35ef601d 100644 --- a/tests/fp/fp-test.c +++ b/tests/fp/fp-test.c @@ -789,7 +789,7 @@ static int set_init_flags(const char *flags) return 0; } -static uint8_t slow_clear_flags(void) +static uint_fast8_t slow_clear_flags(void) { uint8_t prev = slowfloat_exceptionFlags; @@ -797,7 +797,7 @@ static uint8_t slow_clear_flags(void) return prev; } -static uint8_t qemu_clear_flags(void) +static uint_fast8_t qemu_clear_flags(void) { uint8_t prev = qemu_flags_to_sf(qsf.float_exception_flags); From patchwork Tue Jan 22 21:50:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2989E14E5 for ; Tue, 22 Jan 2019 21:57:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 177902B598 for ; Tue, 22 Jan 2019 21:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B8422B5D5; Tue, 22 Jan 2019 21:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A8B242B598 for ; Tue, 22 Jan 2019 21:57:31 +0000 (UTC) Received: from localhost ([127.0.0.1]:50875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm430-0005sd-Kp for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:57:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007Sr-LS for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Fo-KK for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:38101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007s8-Bk for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x343.google.com with SMTP id m22so81307wml.3 for ; Tue, 22 Jan 2019 13:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vz8eNc4Bi34/phbpQzL2afwL7DpHo9/quR04/vTR/5U=; b=B1iNqrHfkicFlYMPxQtuRM+aLHlqLqH562v5bud2JGg0Rd78JG60Xy+d/JhSbQs56q jOWJ0ksxzfyw1B0/WyyxyGJTT53h0VyrKs5wOEkx+Hto1G5LPyCBg/LJGP/nJwib2pDw J/WzQ7UFFFA1465sSQ5scsiJooa6GhuKTcn4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vz8eNc4Bi34/phbpQzL2afwL7DpHo9/quR04/vTR/5U=; b=gQ9ASw2AFuvaTTlZwrtVhjxRAQaEckXNn+TXXBeO03pk+O9Mo0DatOvXCrqODaNafk HxZHldAEL3nXjTAOPckcYjqYTXv//33hoJ1W8FynOa1eBKHtqR4QospQaHP4fjzTDc2J o2W8M0/b4pT6LBuO5bEwx+SVOieAwO9QVLpr803S7LBET9skH5gtccufxUlvN7ikCr+F +FowXwbcKNV4crXUCSPiKoVGaStBYWsTfztbf7UjnvBdIoTX1/4Ay98WDCc8lfZFqxVk sfSwq2HqT+Q3KzIqTgjkTJhJC3T5fr9egi0B+9wTabOH9NYgWVfY/y6QQF/XtADKJGIC 2Z+g== X-Gm-Message-State: AJcUukckrczH8h4XctfXlVg0lvm78hRkR/QddHU5zRYqworFU2Dr4eby lcZan/+dxQN/xAlLfUI4dIbGRQ== X-Google-Smtp-Source: ALg8bN5fh7NBc7pgNpiJqPYNjVNVBB3X41Qsc4bB2ynHjzPrcXcq2dsI0wkb1rfOGogae0kAreGr8A== X-Received: by 2002:a1c:e046:: with SMTP id x67mr183532wmg.122.1548193823634; Tue, 22 Jan 2019 13:50:23 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b129sm45369446wmd.24.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 9AA983E0B11; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:11 +0000 Message-Id: <20190122215016.18697-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v3 06/11] tests/fp/platform.h: include config-host.h X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" We get HOST_WORDS_BIGENDIAN from config-host.h, but the include is missing. Fix it. This fixes `make check-softfloat' on big endian hosts. Reported-by: Peter Maydell Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée --- tests/fp/platform.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/fp/platform.h b/tests/fp/platform.h index f8c423dde3..c20ba70baa 100644 --- a/tests/fp/platform.h +++ b/tests/fp/platform.h @@ -29,6 +29,7 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include "config-host.h" #ifndef HOST_WORDS_BIGENDIAN #define LITTLEENDIAN 1 From patchwork Tue Jan 22 21:50:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6160614E5 for ; Tue, 22 Jan 2019 21:55:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50CA12B598 for ; Tue, 22 Jan 2019 21:55:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 455F52B5A5; Tue, 22 Jan 2019 21:55:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D9F792B598 for ; Tue, 22 Jan 2019 21:55:54 +0000 (UTC) Received: from localhost ([127.0.0.1]:50867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm41S-00049D-5H for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:55:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007SZ-Bh for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Eu-25 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wL-0007ph-70 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:37 -0500 Received: by mail-wm1-x341.google.com with SMTP id m1so81910wml.2 for ; Tue, 22 Jan 2019 13:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=faBd61OejxUkxq2rvQ3pDsb42Y/YIlwTE9s8AKa1cmg=; b=KeP0kqWau5nI7FaqnskD8K9BYGaUs789d8O9AfKetFJ/Y1t/oWMlUn3MgA26p7Sg4n acl1XhdHokeENrbBPX3G7UqIvpB6iIeVZJHqhV/kPg1q6sU6ZtIEczVgg6UPgjQfqyNW 0zDK5tbBhq+OgNjlIKZexY8edRBF2YIjSMD6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=faBd61OejxUkxq2rvQ3pDsb42Y/YIlwTE9s8AKa1cmg=; b=E4gTOxL0JH+K9CpANJye0kH7W21OceD6rF1KIYI672D5Wtxr/AobSnPTR28WFMRdhT puOrDoRMzWsOYPYn2aCUOhTrIiSXInYXuDV5QGbX1kB1XBPjFtJP8KkDG65GK8lZiSjy l+EzZFvWo0fe1fMm8Oaht73Qqzc6rlZxloPzyHeaEPPue94CYD9+fK5+NNlvxEceAj10 zJRYi9CSCaJP7TM6TaAC0wsy1npp82oys7wYHu3iYFJdhrW+OmVy3cWSEBMrnFBz9tC5 +DsUTBNjiBIwUkDZVaSslF4Lw+qQqV2dtpY+2Kr370LEuBj/VdVQSF0P3Xva00rXlVWq qlpA== X-Gm-Message-State: AJcUukfCe7LzD+I9mZE8Q58LEJirT3ZHOJZYUpv3ZCU00bT+m4HOLAbX 6WYq7cI30M1F5i4VdJyGaF6lQ47qDJY= X-Google-Smtp-Source: ALg8bN61uy/vPybzTOiC7FIguQXKpDOaCMEiwkjCtmWetfrlPXenHA2d+J5I1jAlhkZ700OQvPkE7Q== X-Received: by 2002:a1c:4855:: with SMTP id v82mr179502wma.15.1548193822289; Tue, 22 Jan 2019 13:50:22 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id f187sm39611990wma.4.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id AD8E33E0B76; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:12 +0000 Message-Id: <20190122215016.18697-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 07/11] softfloat: enforce softfloat if the host's FMA is broken X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Emilio G. Cota" , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: "Emilio G. Cota" The added branch to the FMA ops is marked as unlikely and therefore its impact on performance (measured with fp-bench) is within noise range when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. Reported-by: Laurent Desnogues Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- fpu/softfloat.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 59eac97d10..9132d7a0b0 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1542,6 +1542,8 @@ soft_f64_muladd(float64 a, float64 b, float64 c, int flags, return float64_round_pack_canonical(pr, status); } +static bool force_soft_fma; + float32 QEMU_FLATTEN float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) { @@ -1562,6 +1564,11 @@ float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) if (unlikely(!f32_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -1623,6 +1630,11 @@ float64_muladd(float64 xa, float64 xb, float64 xc, int flags, float_status *s) if (unlikely(!f64_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -7974,3 +7986,24 @@ float128 float128_scalbn(float128 a, int n, float_status *status) , status); } + +static void __attribute__((constructor)) softfloat_init(void) +{ + union_float64 ua, ub, uc, ur; + + if (QEMU_NO_HARDFLOAT) { + return; + } + /* + * Test that the host's FMA is not obviously broken. For example, + * glibc < 2.23 can perform an incorrect FMA on certain hosts; see + * https://sourceware.org/bugzilla/show_bug.cgi?id=13304 + */ + ua.s = 0x0020000000000001ULL; + ub.s = 0x3ca0000000000000ULL; + uc.s = 0x0020000000000000ULL; + ur.h = fma(ua.h, ub.h, uc.h); + if (ur.s != 0x0020000000000001ULL) { + force_soft_fma = true; + } +} From patchwork Tue Jan 22 21:50:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B8BF1390 for ; Tue, 22 Jan 2019 22:01:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECDF82B5AF for ; Tue, 22 Jan 2019 22:01:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF46E2B5D4; Tue, 22 Jan 2019 22:01:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7F4412B5AF for ; Tue, 22 Jan 2019 22:01:25 +0000 (UTC) Received: from localhost ([127.0.0.1]:50959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm46m-0000YO-OP for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 17:01:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007SU-99 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008FN-AO for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:45683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007qg-3e for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wr1-x441.google.com with SMTP id t6so46281wrr.12 for ; Tue, 22 Jan 2019 13:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EAPNIESGsiwOeWgYA3ZDDIcXw7LSNCiic8+xiezNhwM=; b=P5S48D6lZDPHsZ0AYxDOU4oL63tRzp+9ifQhhFjoxgPxV2rL1gIuU4ZqEMKuOWwIFh gdJ3h5UxE5/edrHo6hropJxQpQZkGZRwYAOCqJEWLNXWntVSTie4f2rLqULQyiTrBckl G/ePlfhPc28IyBErMkBMDzDc/MyAgyvx6XEVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EAPNIESGsiwOeWgYA3ZDDIcXw7LSNCiic8+xiezNhwM=; b=LEffwSmD7fZ0rnX2O5eEOswOM67MHrv1OG4wyD68Z7DDFdg9HyDwuzEnBOwLhEP1dF SRPWSrgGvaBn95Z/3PLfq5Idx8bxrJXsDwZHJ2f5+jBfHPXPw5brggGKUk2MtsBPUYmb nViChNDt38quRvlZB6It4XqnYC3xqB5TK/ApLYAbRqjZGaHTvKXN229LfYcCoz7dxk8H 7ICdgjhverGL5bA+r3GAvzfUXFB0SP8XkOaWxATDmWrmPTTOvbeLYNtV/HJTonvevq2o iPjm19pbm8kYTaHdNOZzxC9ohLA1kzxSJv1ex02cyr5Y9j04ie937UJqUAL14bxMTn8h DujQ== X-Gm-Message-State: AJcUukd6OVw2Ze2DZdA1QsfvS/c4EydQ6/rGVoJ+sRFAmMnOCWbsHVTc Ax3RULxJH+lG5QALfCjtfn6enA== X-Google-Smtp-Source: ALg8bN5WjazD6vg6Jby/Z+4fiwSirbOIl29r2Q2eB4Ks+bFO9XEhDRdC5oDZZPCskZYYlSr1dtqBsQ== X-Received: by 2002:adf:ff09:: with SMTP id k9mr33231940wrr.97.1548193822915; Tue, 22 Jan 2019 13:50:22 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id y138sm64153926wmc.16.2019.01.22.13.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:19 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C00D13E0CD5; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:13 +0000 Message-Id: <20190122215016.18697-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v3 08/11] include/fpu/softfloat: Fix compilation with Clang on s390x X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thomas Huth Clang v7.0.1 does not like the __int128 variable type for inline assembly on s390x: In file included from fpu/softfloat.c:97: include/fpu/softfloat-macros.h:647:9: error: inline asm error: This value type register class is not natively supported! asm("dlgr %0, %1" : "+r"(n) : "r"(d)); ^ Disable this code part there now when compiling with Clang, so that the generic code gets used instead. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Acked-by: Cornelia Huck Signed-off-by: Alex Bennée --- include/fpu/softfloat-macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fpu/softfloat-macros.h b/include/fpu/softfloat-macros.h index b1d772e6d4..bd5b6418e3 100644 --- a/include/fpu/softfloat-macros.h +++ b/include/fpu/softfloat-macros.h @@ -641,7 +641,7 @@ static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1, uint64_t q; asm("divq %4" : "=a"(q), "=d"(*r) : "0"(n0), "1"(n1), "rm"(d)); return q; -#elif defined(__s390x__) +#elif defined(__s390x__) && !defined(__clang__) /* Need to use a TImode type to get an even register pair for DLGR. */ unsigned __int128 n = (unsigned __int128)n1 << 64 | n0; asm("dlgr %0, %1" : "+r"(n) : "r"(d)); From patchwork Tue Jan 22 21:50:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776343 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 533FA1399 for ; Tue, 22 Jan 2019 22:00:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 400BD2B4D8 for ; Tue, 22 Jan 2019 22:00:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 344F42B536; Tue, 22 Jan 2019 22:00:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A35722B4AD for ; Tue, 22 Jan 2019 22:00:10 +0000 (UTC) Received: from localhost ([127.0.0.1]:50939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm45a-000800-1X for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 17:00:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wR-0007TN-2s for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Fi-Ij for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:34734) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007uB-9s for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x341.google.com with SMTP id y185so9540697wmd.1 for ; Tue, 22 Jan 2019 13:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vNUVzXJMeciF3yCxVe8r8HtMv+v24ndvlEQDb539ja8=; b=hkGkPTyMs3RHAunAfxnBdNpIoMnn1uNsLcEULTrjtaww0vHAm3F6v82bZPcEAK9ZcV CG1U20cTTF49UQvIb0EK3As+i9vrcpftDVZOTG6hQKyYkHGY1HLQLrrCymkJAGKM0FK5 2mJjVGPwfm0VpEUBcgtAVV/hXtPlrhhfBH/Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vNUVzXJMeciF3yCxVe8r8HtMv+v24ndvlEQDb539ja8=; b=F79P2M11tko+9MT/TnU2qffFKx37+E7PXYogAcQ9Rzp1MsrfwedrTkxKnapXZrldhH yZCwfl0vkjwZFvcBi3l6qRrmrFKQ5Ic9f3J8S71J1ZV+6sP6UIyw+lP54Xsw7LAzdoTJ urqmBK5lNH0PbUcA3URNnVxcgKi+VpbwEDcL5Mx3orhU6y/JO6FEZ4a62MkMZ1QJXLUY vUwieqWoNOrvwt6VifyByVlCnA8n241g5TCgZJZSmyKr4nnjHLXe4tVJaoP+b3yKyER+ 8pdj6C9Ca1+QrCYf0E4fKOPN5effPU4nDZ8eBVF52Dnqi38wCFqf/xSpz6C3gIbgXzZq GKug== X-Gm-Message-State: AJcUukcxPiQinMOHGEBtXwKm7urwTteILZRdQu+WWL2teEe2O4iUZLzy hzHTE6SYMdrjuUoSvRAz6SDUIY9EaF4= X-Google-Smtp-Source: ALg8bN5C9hs+jdQ2VzJ2pkId9/XkkTEvXGuEGSd06QAZI+B6Jy3g7i497uXywPlz4DdYugZlHb37AA== X-Received: by 2002:a1c:f71a:: with SMTP id v26mr152368wmh.131.1548193824398; Tue, 22 Jan 2019 13:50:24 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t66sm18073834wme.15.2019.01.22.13.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id D24103E0D0E; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:14 +0000 Message-Id: <20190122215016.18697-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v3 09/11] tests/Makefile: add floating point tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Wire up test/fp-test into the main testing Makefile. Currently we skip some of the extF80 and f128 related tests. Once we re-factor and fix these tests the plumbing should get simpler. Signed-off-by: Alex Bennée --- v3 - tweak test function - always call fp-test build --- tests/Makefile.include | 120 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.include index 4eea38ae99..f123616bc7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -880,6 +880,126 @@ check-report-unit.tap: $(check-unit-y) check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check-report-unit.tap $(call quiet-command,./scripts/tap-merge.py $^ > $@,"GEN","$@") +# FPU Emulation tests (aka softfloat) +# +# As we still have some places that need fixing the rules are a little +# more complex than they need to be and have to override some of the +# generic Makefile expansions. Once we are cleanly passing all +# the tests we can simplify the make syntax. + +FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test + +# the build dir is created by configure +.PHONY: $(FP_TEST_BIN) +$(FP_TEST_BIN): $(BUILD_DIR)/tests/fp fpu/softfloat.c + $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && make, \ + "BUILD", $<) + +# The full test suite can take a bit of time, default to a quick run +ifeq ($(SPEED), quick) +FP_TL=-l 1 +else +FP_TL=-l 2 -r all +endif + +# $1 = tests, $2 = description +test-softfloat = $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && \ + ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \ + (cat $2.out && exit 1;), \ + "FLOAT TEST", $2) + +# Conversion Routines: +# FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken) +# ui32_to_f128 (not implemented), f128_to_ui32 (not implemented) +# extF80_roundToInt (broken) +# +check-softfloat-conv: $(FP_TEST_BIN) + $(call test-softfloat, \ + i32_to_f16 i64_to_f16 \ + i32_to_f32 i64_to_f32 \ + i32_to_f64 i64_to_f64 \ + i32_to_f128 i64_to_f128, int-to-float) + $(call test-softfloat, \ + ui32_to_f16 ui64_to_f16 \ + ui32_to_f32 ui64_to_f32 \ + ui32_to_f64 ui64_to_f64 \ + ui64_to_f128, uint-to-float) + $(call test-softfloat, \ + f16_to_i32 f16_to_i32_r_minMag \ + f32_to_i32 f32_to_i32_r_minMag \ + f64_to_i32 f64_to_i32_r_minMag \ + extF80_to_i32 extF80_to_i32_r_minMag \ + f128_to_i32 f128_to_i32_r_minMag \ + f16_to_i64 f16_to_i64_r_minMag \ + f32_to_i64 f32_to_i64_r_minMag \ + f64_to_i64 f64_to_i64_r_minMag \ + extF80_to_i64 extF80_to_i64_r_minMag \ + f128_to_i64 f128_to_i64_r_minMag, \ + float-to-int) + $(call test-softfloat, \ + f16_to_ui32 f16_to_ui32_r_minMag \ + f32_to_ui32 f32_to_ui32_r_minMag \ + f64_to_ui32 f64_to_ui32_r_minMag \ + f16_to_ui64 f16_to_ui64_r_minMag \ + f32_to_ui64 f32_to_ui64_r_minMag \ + f64_to_ui64 f64_to_ui64_r_minMag, \ + float-to-uint) + $(call test-softfloat, \ + f16_roundToInt f32_roundToInt \ + f64_roundToInt f128_roundToInt, \ + round-to-integer) + +# Generic rule for all float operations +# +# Some patterns are overidden due to broken or missing tests. +# Hopefully these can be removed over time. + +check-softfloat-%: $(FP_TEST_BIN) + $(call test-softfloat, f16_$* f32_$* f64_$* extF80_$* f128_$*, $*) + +# Float Compare routines +SF_COMPARE_OPS=eq eq_signaling le le_quiet lt_quiet +SF_COMPARE_RULES=$(patsubst %,check-softfloat-%, $(SF_COMPARE_OPS)) + +# FIXME: extF80_le_quiet (broken) +check-softfloat-le_quiet: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_le_quiet f32_le_quiet f64_le_quiet \ + f128_le_quiet, \ + le_quiet) + +# FIXME: extF80_lt_quiet (broken) +check-softfloat-lt_quiet: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_lt_quiet f32_lt_quiet f64_lt_quiet \ + f128_lt_quiet, \ + lt_quiet) + +.PHONY: check-softfloat-compare +check-softfloat-compare: $(SF_COMPARE_RULES) + +# Math Operations + +# FIXME: extF80_mulAdd (missing) +check-softfloat-mulAdd: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \ + mulAdd) + +# FIXME: extF80_rem (broken) +check-softfloat-rem: $(FP_TEST_BIN) + $(call test-softfloat, \ + f16_rem f32_rem f64_rem f128_rem, \ + rem) + +SF_MATH_OPS=add sub mul mulAdd div rem sqrt +SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) + +.PHONY: check-softfloat-ops +check-softfloat-ops: $(SF_MATH_RULES) + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) From patchwork Tue Jan 22 21:50:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776333 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 462E614E5 for ; Tue, 22 Jan 2019 21:52:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 367BF2B741 for ; Tue, 22 Jan 2019 21:52:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A7A62B748; Tue, 22 Jan 2019 21:52:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D13052B741 for ; Tue, 22 Jan 2019 21:52:17 +0000 (UTC) Received: from localhost ([127.0.0.1]:50781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3xw-0000QL-3u for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 16:52:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wQ-0007TC-Ty for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008GJ-SP for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:42 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:52536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007vu-J9 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x333.google.com with SMTP id m1so82040wml.2 for ; Tue, 22 Jan 2019 13:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HjyDClYTa4RavIRqdKjd3FAFDFKhqzTfdleMBuojdXM=; b=XCLNqwUdqnz5SIuu0zCkuBinV77EtEfmkPjtO/cBY5xQacMZkOJTmAPnF/HFUjYwoA wcGXm3/pLUIWPYbviF1M2ZLpueMu+JTtPUouddQljT0wZ6nqBvZq5/oK2/W/BEPFwTMo 9QcE/pPOpUZdlmQt2AcW6PVfTonz7Fqf56xmA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HjyDClYTa4RavIRqdKjd3FAFDFKhqzTfdleMBuojdXM=; b=IIOR/nf2z7GvaLHq6IJMhmAaC84AkJYnqw4W1ANe9C6d3n/zGXfAlTT0Bx0SEfdHoN ciO2zPgZ2Bw7vTYfJVhKp2K0EJqangVlx2epr8PZUpXbhL2s9WTMe8ypw1k1eb3tv4eX SS6MLo2Rguy2L3k1sHNHb4QrVeKEMNukNNTvPDi6ntfTAcF3RJkoiHAS3WK3NMRcfzKJ AuyzQR1ktUMMgbWUNbzKcMfGup9WlQXzZ1Goj9RNF0ZjaBQk/2oX3PnlCSxkugUfHAq4 Vq3c49butr3WkOAH+VQrvmDpYNEV+rFG6VT1nmlLVc24LCzVid6xzIN+DbKkIv4hlFBc ovyQ== X-Gm-Message-State: AJcUukdJ4uMFHZc06ZE+uUByXlCmI/qK0H7D9GHurXx+M1wC+Z/hiCg8 kMk9JucYhFmRAvmkAX91pNHYgw== X-Google-Smtp-Source: ALg8bN7c7DdxsLO1Ew2xekt+k1LrCCxm7CE6Dg0kikMEU52YurgT4J/ckbnpbFcvvGvlDJjgCxPcEg== X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr212197wmk.44.1548193825850; Tue, 22 Jan 2019 13:50:25 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id f191sm10843767wmg.12.2019.01.22.13.50.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id E466F3E0D4B; Tue, 22 Jan 2019 21:50:16 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:15 +0000 Message-Id: <20190122215016.18697-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::333 Subject: [Qemu-devel] [PATCH v3 10/11] scripts/archive-source: include softfloat tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP We need these if we want to run unit/softfloat tests in our docker containers. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- scripts/archive-source.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh index 62bd22578b..6eed2a29bd 100755 --- a/scripts/archive-source.sh +++ b/scripts/archive-source.sh @@ -26,7 +26,7 @@ vroot_dir="${tar_file}.vroot" # independent of what the developer currently has initialized # in their checkout, because the build environment is completely # different to the host OS. -submodules="dtc ui/keycodemapdb" +submodules="dtc ui/keycodemapdb tests/fp/berkeley-softfloat-3 tests/fp/berkeley-testfloat-3" trap "status=$?; rm -rf \"$list_file\" \"$vroot_dir\"; exit \$status" 0 1 2 3 15 From patchwork Tue Jan 22 21:50:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 10776351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B78B8746 for ; Tue, 22 Jan 2019 22:07:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A73FC2B109 for ; Tue, 22 Jan 2019 22:07:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B6B82B11F; Tue, 22 Jan 2019 22:07:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3CD372B109 for ; Tue, 22 Jan 2019 22:07:23 +0000 (UTC) Received: from localhost ([127.0.0.1]:51096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm4CY-0004PC-2X for patchwork-qemu-devel@patchwork.kernel.org; Tue, 22 Jan 2019 17:07:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm3wS-0007V1-MR for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm3wP-0008Gb-Tg for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:43 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:34735) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm3wP-0007uk-Kv for qemu-devel@nongnu.org; Tue, 22 Jan 2019 16:50:41 -0500 Received: by mail-wm1-x342.google.com with SMTP id y185so9540708wmd.1 for ; Tue, 22 Jan 2019 13:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yttWb6PrQgq8ISO/77UEb790jQuJJJcQac8NOTluiGI=; b=XWN4xjzReym44TgmGejty7JvcaGYLiaOCnu/rwV3fMotUUAPatf0wXxMwn6UYyDxMz i/4S+kyOb/NRKfpoFlPf2qt8K7CDmQph4/H3zxMh7xgkRvP7XijNfmlTHqKOEwyGyWjG NfRGkyv8x3xi6cLQ0d/r6BcGk2nlF6zmTYEGU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yttWb6PrQgq8ISO/77UEb790jQuJJJcQac8NOTluiGI=; b=n6z0wCXTgEi106xEjYwJuOZivLWCxqOKOIYl4QPsVcRCaFoXzepzcJvV0fll7d0QMP SeNZKZ91yurw9la95D+ZIuyuG9ewWag0OXuGnzYgqKAXzTbm6a9317Ps+flulU4O9Cmg EjEVR+ugkl9B/vHrfLUmnso+WLz0VOnpDrGOHvd4e4skt/Ul2DsRN3/JCJFkAxxQa1B9 26+j72MkxaKeu3mf61uDwgriKgi807/ozSbylBTTkWv7ZQNj+IDhgYuMVLzxP8fspBrq MJCRhrvYqV+RpIhgtiL6BmTuBnR0j26ZNWFn3MISvUjD+O1o/hmb1CPFwo/JgXBRje3b ywzg== X-Gm-Message-State: AJcUukc2AQaTEnzWEpPbBcLYHTldqwry4sa/VrqHQIosDsgkwpSwsNik ebi9rMdfJprZco7of4x9u+HtUWKVqq8= X-Google-Smtp-Source: ALg8bN7BYvK7GNq+LgFbfqJFKoDA8r61EA2pDq8pKlzbvW17NnodxIfYmMt6LcEU0nGPFp7ig+2Xgg== X-Received: by 2002:a1c:b14:: with SMTP id 20mr175133wml.103.1548193825022; Tue, 22 Jan 2019 13:50:25 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id k128sm72720551wmd.37.2019.01.22.13.50.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 13:50:20 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 020313E0DCD; Tue, 22 Jan 2019 21:50:17 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 22 Jan 2019 21:50:16 +0000 Message-Id: <20190122215016.18697-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190122215016.18697-1-alex.bennee@linaro.org> References: <20190122215016.18697-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v3 11/11] tests/Makfile: add check-softfloat rule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This adds a rule to run all of our softfloat tests. It is included as a pre-requisite to check-tcg and check-unit as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Emilio G. Cota --- tests/Makefile.include | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index f123616bc7..acf166e0e2 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -12,6 +12,7 @@ check-help: @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" @echo " $(MAKE) check-block Run block tests" @echo " $(MAKE) check-tcg Run TCG tests" + @echo " $(MAKE) check-softfloat Run FPU emulation tests" @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" @echo @echo " $(MAKE) check-report.html Generates an HTML test report" @@ -1000,6 +1001,18 @@ SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) .PHONY: check-softfloat-ops check-softfloat-ops: $(SF_MATH_RULES) +# Finally a generic rule to test all of softfoat. If TCG isnt't +# enabled we define a null operation which skips the tests. + +.PHONY: check-softfloat +ifeq ($(CONFIG_TCG),y) +check-softfloat: check-softfloat-conv check-softfloat-compare check-softfloat-ops +else +check-softfloat: + $(call quiet-command, /bin/true, "FLOAT TEST", \ + "SKIPPED for non-TCG builds") +endif + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) @@ -1032,7 +1045,7 @@ clean-tcg-tests-%: build-tcg: $(BUILD_TCG_TARGET_RULES) .PHONY: check-tcg -check-tcg: $(RUN_TCG_TARGET_RULES) +check-tcg: check-softfloat $(RUN_TCG_TARGET_RULES) .PHONY: clean-tcg clean-tcg: $(CLEAN_TCG_TARGET_RULES) @@ -1113,7 +1126,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) check-tests/qapi-schema/doc-good.texi check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) check-block: $(patsubst %,check-%, $(check-block-y)) -check: check-qapi-schema check-unit check-qtest check-decodetree +check: check-qapi-schema check-unit check-softfloat check-qtest check-decodetree check-clean: rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(target)-y)) $(check-qtest-generic-y))