From patchwork Fri Dec 2 10:26:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C37BC47088 for ; Fri, 2 Dec 2022 10:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 918D06B0074; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 796DF6B007E; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 592776B007D; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C2406B0075 for ; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0E9A11409D2 for ; Fri, 2 Dec 2022 10:27:04 +0000 (UTC) X-FDA: 80196988368.01.8BEC2E5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 30F57140011 for ; Fri, 2 Dec 2022 10:27:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p4T0SSAw; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tshiIOlyizQCn3wWRqEk8o+H1VcPDbPrSjSJx6S/vZI=; b=u570cch3PkZfg+6wFJWA5VqVNtn1ENnVi5G6iVehEUT/UeqvnmajAb+H5D98JTi2/xI2tV cm7i8SpSZ1YAhjGF50P3ci7SErQyE0dFyK050S/pLy9TmxG38mkLe0oD5POP2FeP7jif7D E4lrsXADE7WgOpBCZ/yKDod3yAxzLzc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p4T0SSAw; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976823; a=rsa-sha256; cv=none; b=GhGBvZMi8ml8LaCAwqPxEIKgxGi5ED8Uk68IMV91k1q8vcCpL6qOC/1rVxRz9MM0WNBJmY 1YQVV8D41ez12UmuYYwUEHcQ/LpgNYh4J6+jOrIhvc0c5AvNvXQQaipHdMzOrpKHJ/97V1 jnSVQjHgZ6ueVfVkgUU/OnUHO/sTOEw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=tshiIOlyizQCn3wWRqEk8o+H1VcPDbPrSjSJx6S/vZI=; b=p4T0SSAwoIWZnEozmQOSV1gt/m MIsRDd+GQm1I/cTGz+x3lh11gl9nlIOzHMxB4vQ1meJn45PtYaDQhPY42zKL/K405lsql7KgD71Um 2RREPX5GNnwopdJ0PXyvfmfbM8KWrMs3PkztXKT4lZxcMAKD5EavokoI5B0Ijhx/nFCu2G26xXa/0 CpNmv0l7/fvEHrXC2Xc4LXjaIfYob5/hQ/D2RBNqs4LR7DZR+wNPRqrCxPOPftOqV+6CBciDdnS87 blEIGvCe0Q99ktCpoqgEH7vI3DzmeKXMGnIrjgPcWRsX1zUFMOE1orH/KBqJDWv8jUnjrvv7IzQhz mz06UUiw==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fp-00FQwZ-F8; Fri, 02 Dec 2022 10:26:50 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 1/7] extfat: remove ->writepage Date: Fri, 2 Dec 2022 11:26:38 +0100 Message-Id: <20221202102644.770505-2-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spamd-Result: default: False [0.79 / 9.00]; BAYES_HAM(-2.81)[99.18%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Stat-Signature: pgotcyhw3wd6bqfitr1af3d8m59m4bt5 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 30F57140011 X-Rspam-User: X-HE-Tag: 1669976822-119059 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Namjae Jeon Acked-by: Johannes Weiner --- fs/exfat/inode.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c index 5590a1e83126c9..eac95bcd9a8aae 100644 --- a/fs/exfat/inode.c +++ b/fs/exfat/inode.c @@ -345,11 +345,6 @@ static void exfat_readahead(struct readahead_control *rac) mpage_readahead(rac, exfat_get_block); } -static int exfat_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, exfat_get_block, wbc); -} - static int exfat_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -473,12 +468,12 @@ static const struct address_space_operations exfat_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = exfat_read_folio, .readahead = exfat_readahead, - .writepage = exfat_writepage, .writepages = exfat_writepages, .write_begin = exfat_write_begin, .write_end = exfat_write_end, .direct_IO = exfat_direct_IO, - .bmap = exfat_aop_bmap + .bmap = exfat_aop_bmap, + .migrate_folio = buffer_migrate_folio, }; static inline unsigned long exfat_hash(loff_t i_pos) From patchwork Fri Dec 2 10:26:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062580 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DB0C4167B for ; Fri, 2 Dec 2022 10:27:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD8B36B0078; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B37ED6B007B; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830506B007D; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 64D806B0078 for ; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 36B0A120A90 for ; Fri, 2 Dec 2022 10:27:04 +0000 (UTC) X-FDA: 80196988368.03.6ACFDA9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 8B8A8C0010 for ; Fri, 2 Dec 2022 10:27:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XcSze6yI; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8Lak3cqHWQ+dnfyhXDbmC5RGlFrgzaazzdLBDYGtZQ=; b=0mK1u8GfsCiG6PYFEG7nNlC+E3wc+b+xV1utp8iKxezyiZI9xay1tstXltN8Pb8zR8j6Zj X701D1+AVjT+pM2Yfecy5nX8ONa8/3oP2iRkwIpAygruvjK1Jha+WwCTaD93YIq1nKSMjK Xb7Ednx28c2Vf4WZELPngIn1FO1m6J8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XcSze6yI; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976823; a=rsa-sha256; cv=none; b=ApCEtttvW+UDQ7M9q+dN23YZoD92VDkoqt5/DaqGqptOmvy3d1iaGDET7vpkjrN1UZZWiX Ixc1oF/azzAIU4Ak/3vgK/PArJkJsTIX9dnNYAZNoiNldhC11NUlJ8EEp+ej0ySJ7m/a5l Mo0z81PACOSIBV7DnCyTTVrSwokhhIw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Y8Lak3cqHWQ+dnfyhXDbmC5RGlFrgzaazzdLBDYGtZQ=; b=XcSze6yIF5L/Kmd8YUIv94LZPC WzH1nM4w+yQHudWoL9X1McNCpmKkrfOOG/ybs6VEgRXDnhtzvFFxgF2K+DRRZs4rgwFwlL1IUYb0k GD2FywGv16g5FhymEprpfNUd6SH8P47C11uUX/kneFiXVwoksI8Pewz+dE9CejlFM3PqFw+Uo/hEK EVbR8rGTHIwXSRM3s9uHqMr05/dPb9LZP1W1w7y76Odxbvyt8owe45cylBT3x2ZFd2uwXCyfeYAfU qbd/2u8s94Xp6wtw3UJdMXQdpbplxOqWjnoMs2IR9BvBIGrSlqgK8NhU9/ARmvkeJON4bYlzq2qqQ Yv6ZzMhQ==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fs-00FQxO-F4; Fri, 02 Dec 2022 10:26:53 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 2/7] fat: remove ->writepage Date: Fri, 2 Dec 2022 11:26:39 +0100 Message-Id: <20221202102644.770505-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spamd-Result: default: False [0.74 / 9.00]; BAYES_HAM(-2.86)[99.41%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Stat-Signature: 34dixazz1pczdmi6ibgqnocfpgmjmd9b X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8B8A8C0010 X-Rspam-User: X-HE-Tag: 1669976822-334772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/fat/inode.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 1cbcc4608dc78f..d99b8549ec8f91 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -194,11 +194,6 @@ static int fat_get_block(struct inode *inode, sector_t iblock, return 0; } -static int fat_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, fat_get_block, wbc); -} - static int fat_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -346,12 +341,12 @@ static const struct address_space_operations fat_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = fat_read_folio, .readahead = fat_readahead, - .writepage = fat_writepage, .writepages = fat_writepages, .write_begin = fat_write_begin, .write_end = fat_write_end, .direct_IO = fat_direct_IO, - .bmap = _fat_bmap + .bmap = _fat_bmap, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Fri Dec 2 10:26:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631DAC4332F for ; Fri, 2 Dec 2022 10:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 647186B0075; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 608FF6B0074; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C0C6B007B; Fri, 2 Dec 2022 05:27:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2E6036B0074 for ; Fri, 2 Dec 2022 05:27:04 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00B27C076A for ; Fri, 2 Dec 2022 10:27:03 +0000 (UTC) X-FDA: 80196988326.04.DA69585 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 6399318000D for ; Fri, 2 Dec 2022 10:27:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Yebwp0ce; spf=none (imf24.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yJxb4jf5H4wN5CZm7p5uEgZxeUIn0cECx2KzjI/LP/8=; b=XPHEUT2ZFBu0LrXINUhI+BxUrsnRIMLpV1Cs9sn+DPLB2O60glY6TvzVg2GH36XwX1iu9K GNhUkYPNQcFHSNxjDtMBq73rrUb9aP9laFAmJJJWp0o/lZcVFU56JPjsjbKpUIf7W2K7OC 8r/9VdrXFtL6lDeilq2t5jLicux0uBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976823; a=rsa-sha256; cv=none; b=6a2suAh7E4WU6kuVyWgUgd9Rbifc6SMr8cc+z8IFFZsm2wk0yGLWmAZiMEkdM71gzx6PPP 0GsANbRK0YvYKBAbnOiZhH8D9j6LLPl9NsEvNSQRSqYsLg9oZCfCwb5yp4j5yIo0sxs+94 JzxOsYid/HtvClWDkQ+VoKcKaJfeKY8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Yebwp0ce; spf=none (imf24.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=yJxb4jf5H4wN5CZm7p5uEgZxeUIn0cECx2KzjI/LP/8=; b=Yebwp0cearBPaYNKDQ0kQsacj0 WN5XnrFBFmcCGes73mk3QFiMUCa+hUsukP6klrjLDcVQa24dA4WKU35EJ1YXm2ElvIVIDXoCme8A9 icylY5Ogd4rySe2g5gdxIoK6NEfFi3FWalKeHkGTBTCid+Pfsd1hF74xRb4RXm3LJ3moR+qcZSmyd atUSuew4vVLKLbprx9fI/Bs8pFvbA8/JbQaLLkUm1G51JPgPCXFp8DId7kyIxfJXVHkZIWOzmoztl 32dL8SKJW25E5v0DSAQJYU2mIp59r0sBdNkOlH2A3PPqX+4gmJAI+PoyZmy8HkxCO29XSSddL+44L y7k2IGzQ==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fv-00FQyS-Dv; Fri, 02 Dec 2022 10:26:56 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 3/7] hfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:40 +0100 Message-Id: <20221202102644.770505-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 6399318000D X-Stat-Signature: g1cxb9f68eee4i5gouqp9wxoyntb1s9n X-Rspamd-Server: rspam01 X-Spamd-Result: default: False [1.12 / 9.00]; R_MISSING_CHARSET(2.50)[]; BAYES_HAM(-2.48)[97.63%]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-HE-Tag: 1669976823-946644 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfs_aops. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/hfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index c4526f16355d54..16466a5e88b44b 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -173,12 +173,12 @@ const struct address_space_operations hfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfs_read_folio, - .writepage = hfs_writepage, .write_begin = hfs_write_begin, .write_end = generic_write_end, .bmap = hfs_bmap, .direct_IO = hfs_direct_IO, .writepages = hfs_writepages, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Fri Dec 2 10:26:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062581 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0925C4167B for ; Fri, 2 Dec 2022 10:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFE5D6B007D; Fri, 2 Dec 2022 05:27:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B60EA6B007E; Fri, 2 Dec 2022 05:27:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA356B0080; Fri, 2 Dec 2022 05:27:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7EC1B6B007D for ; Fri, 2 Dec 2022 05:27:07 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A4D6160A1A for ; Fri, 2 Dec 2022 10:27:07 +0000 (UTC) X-FDA: 80196988494.04.5A66B1E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id E2216A0014 for ; Fri, 2 Dec 2022 10:27:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Dq2jBfet; spf=none (imf25.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y5m0F6Pyvv6Ear4bOX/of/SNS6Ys875CaEmxQ7Nl5xY=; b=JHcPvKDTsNd+1vTJKgc6ARjAEgBKlL1Hu1JwM3ANo/7xyRDmFV8QXeSkg9A0hGqbmV93Gv JLrrzvetP4La9I6SUoBoSjOXPq57URCXRGg6YCZ6dUSBhMLzeoxlIkBeSj+WDunpOCKb5M VtpyKlBpbcI9igIHoWUZ0st4j/4PewA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976827; a=rsa-sha256; cv=none; b=sV8rmB1NEoHnhprnuVgs3hT7XiV9m7PyweDQlaOW+h9FzE9lpMUQLv/R/syvUzCzcuFaEY jM5ly6xD8DjyBkeU56xoL7GSiiBWI5s/h5VgbTwizr/LVXYI10bbS1C6bWlx6UPtZqT6Jq N0AlIv77kdrKhqtxPqycCAimXvKtNBM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Dq2jBfet; spf=none (imf25.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Y5m0F6Pyvv6Ear4bOX/of/SNS6Ys875CaEmxQ7Nl5xY=; b=Dq2jBfetFtoC66mXgk3+Xi4fJB OTRUGmBgVVpn1WO6TuOtU0AvCG7tltCOVBprltqtRo0PhfqAR8CZlF+NoEYBsEW2Tfi23xSxmP4wd ZsjsuwuUAXvUD13OJKFPZDIiCzUociRfJ0XicdWQbJmVrYMpYudWbWBMrDTBmv8TSc+s2xzAHENgd Wr5Blr873CIIAO+BgZ/IU+xMnGLdir5vOnE2G64KSxlCvzT2SAvcP9MNleg60o6xMcFVr50vr+xOZ vsJs5T3nX0hj1/xsaid0ChvYBqR62W97UI9prrX8QkRtZMVWGPJvqqiD1fbD3ClunUd23iQtM9z8S mZnZMvXw==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13Fy-00FQzp-DD; Fri, 02 Dec 2022 10:26:59 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 4/7] hfsplus: remove ->writepage Date: Fri, 2 Dec 2022 11:26:41 +0100 Message-Id: <20221202102644.770505-5-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Spamd-Result: default: False [0.99 / 9.00]; BAYES_HAM(-2.61)[98.29%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Stat-Signature: t813edd31mdy885ym3u8frdfyj5grx4g X-Rspamd-Queue-Id: E2216A0014 X-Rspamd-Server: rspam05 X-HE-Tag: 1669976826-735529 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfsplus_aops. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/hfsplus/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index aeab83ed1c9c6e..d6572ad2407a7c 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c @@ -170,12 +170,12 @@ const struct address_space_operations hfsplus_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfsplus_read_folio, - .writepage = hfsplus_writepage, .write_begin = hfsplus_write_begin, .write_end = generic_write_end, .bmap = hfsplus_bmap, .direct_IO = hfsplus_direct_IO, .writepages = hfsplus_writepages, + .migrate_folio = buffer_migrate_folio, }; const struct dentry_operations hfsplus_dentry_operations = { From patchwork Fri Dec 2 10:26:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EA0C47088 for ; Fri, 2 Dec 2022 10:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E3216B007E; Fri, 2 Dec 2022 05:27:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5958F6B0080; Fri, 2 Dec 2022 05:27:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 434D76B0081; Fri, 2 Dec 2022 05:27:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 335716B007E for ; Fri, 2 Dec 2022 05:27:11 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F09481405DF for ; Fri, 2 Dec 2022 10:27:10 +0000 (UTC) X-FDA: 80196988620.06.18FED2F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id A7EF880014 for ; Fri, 2 Dec 2022 10:27:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=INC7W8kc; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mbvlyXxWhO9WFxugvmMSJQGn9fzMBZ852OGR/GsDnBQ=; b=Tw1rqVHlqRBr7aaatZWOwrbv+ioEO7u1iGfA4wltiz/SX2APND1X397z1cZBYJeOIjRpqi nuW/hjn2PsywHi55m1WX5jBi8xg9xcpMrH5QdJlMsF2bxn3Dxmg3ef5ketdDcoBL5RKEuE 5AKId6fO1YgZkNbM1Ptvg4JwT3BaD7k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=INC7W8kc; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976830; a=rsa-sha256; cv=none; b=Xk1W+Bu3vDO3a/nYXqb9beLxqB9hpZYYFC46Eyyi9+kHN2mTM4ZoW2aNfgucU31EnR/lAf WQHW1yQ7Rhq+HJsBsrHYTquXGZALaiin+Q+I0hgx56kw5GhFBoCXhm+7xrknExwqs0OpOX 2oJpsSvRxiVKh9nGq8KjQ+1/WOMFkSs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=mbvlyXxWhO9WFxugvmMSJQGn9fzMBZ852OGR/GsDnBQ=; b=INC7W8kcASEs2+FQI6tK+fkYe7 FVLv5J6Yt9ZchoTmC3IrWcFjNI8P8nW/kfVnPT8z4afsigc0DyzXO/8jHJO4Lb+ZG3fJnolV4DQRY IAUlwenbG5qLTeP0d/+f+FXyW/PFBt2gXZ6V7In4xC82yItOO63+eSh9MshNuHBeHLlaZoxr2Wtg7 h0UuhIkcrY6s4liyPpdjMHfpFvKmXU3TZC0Z8kursgybQFsK42q7alrWlDNMR9loGPNZPTlr5PC3X 0N2gBn0iRz0FtIqvqeAeyX0/yD7W1p+duoifLZEIOu0sc7+LbZHHQjXMm8l5LgxIqc7RrHLLYUWvZ YtODIeZA==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13G1-00FR1N-A5; Fri, 02 Dec 2022 10:27:01 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 5/7] hpfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:42 +0100 Message-Id: <20221202102644.770505-6-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spamd-Result: default: False [1.17 / 9.00]; R_MISSING_CHARSET(2.50)[]; BAYES_HAM(-2.43)[97.38%]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Stat-Signature: ikne98djqai8uaxm4bno1hzus19i8zb6 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A7EF880014 X-Rspam-User: X-HE-Tag: 1669976830-146559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Johannes Weiner --- fs/hpfs/file.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/hpfs/file.c b/fs/hpfs/file.c index f7547a62c81f6a..88952d4a631e6c 100644 --- a/fs/hpfs/file.c +++ b/fs/hpfs/file.c @@ -163,11 +163,6 @@ static int hpfs_read_folio(struct file *file, struct folio *folio) return mpage_read_folio(folio, hpfs_get_block); } -static int hpfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, hpfs_get_block, wbc); -} - static void hpfs_readahead(struct readahead_control *rac) { mpage_readahead(rac, hpfs_get_block); @@ -248,12 +243,12 @@ const struct address_space_operations hpfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hpfs_read_folio, - .writepage = hpfs_writepage, .readahead = hpfs_readahead, .writepages = hpfs_writepages, .write_begin = hpfs_write_begin, .write_end = hpfs_write_end, - .bmap = _hpfs_bmap + .bmap = _hpfs_bmap, + .migrate_folio = buffer_migrate_folio, }; const struct file_operations hpfs_file_ops = From patchwork Fri Dec 2 10:26:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1370C4708D for ; Fri, 2 Dec 2022 10:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FCE16B0080; Fri, 2 Dec 2022 05:27:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 238936B0081; Fri, 2 Dec 2022 05:27:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DA8A6B0082; Fri, 2 Dec 2022 05:27:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E66ED6B0080 for ; Fri, 2 Dec 2022 05:27:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C2EF51A0E55 for ; Fri, 2 Dec 2022 10:27:12 +0000 (UTC) X-FDA: 80196988704.20.ED0000B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 773B920015 for ; Fri, 2 Dec 2022 10:27:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TWvEKxe1; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fqr9TW+rT8ValeXLVFOQSDtrNHXsSl7u56JKe2jXztI=; b=7MlWo4RAY9MFObagZWr0KUdPrFL3Vr3vbok4OqTeygprnr6lkOsj/NJtutjrMfMpLUhycJ gcD+xQNLNX/97mRbLh8qvAyWJGT3iYrCTG+UaElYja+xYZ9yShkchOfjfndMJjpZoWua5A MHgp0lmc56JpWRzYaSnF76HUwQE9cFw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976832; a=rsa-sha256; cv=none; b=kEmGsxFKzaiRCz+Rw3Gj8SPSN7XO9vJUbtzN4HGsnzCGlILPiSNGD/pTMUy1n7UlG+InXL BqsfwlZaQ6I60dJHmWRut0yjCTTRtepvlU5evDWBAw8R5AVUpooyfJfA9q9P9qMBVlGKSs l3LT/y51y9hl63si399hhHsOBfto/Ak= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=TWvEKxe1; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=fqr9TW+rT8ValeXLVFOQSDtrNHXsSl7u56JKe2jXztI=; b=TWvEKxe1hgaqaar0S3SdimrN6x CCDVFmRGCM1ggNXnG5FjJDcpDBjli7i4LD/ks900zzcj1gTmSm5Gec8vrJIJc0FAdbCn/oPYdx6Zt T05aBcXid3fSpkehDIgr1ssY1DY7NeoCM6NTgkF8Vti6BYts/hcAO9azLBFkGAkL3ItNAnApvXXyu BZ5KwzzO58NFGMAbVIIZUWGmHki7aOK6zFx1KMBI5NFt2H8SHg5srWFPDo3CeaHU/T3xDokLMAjJ4 ueFDVhrzFEEHXF9JZhYku8gRMyvySJf07CcRonjhN0xseuAoTI2jGFX2ZwGLSf2ZqyQh893fl2rar sG+xo6dA==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13G4-00FR2o-7h; Fri, 02 Dec 2022 10:27:04 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Dave Kleikamp , Johannes Weiner Subject: [PATCH 6/7] jfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:43 +0100 Message-Id: <20221202102644.770505-7-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 773B920015 X-Stat-Signature: etqmt8p3surz619e59f7pp59fyf79w8k X-Rspamd-Server: rspam01 X-Spamd-Result: default: False [0.81 / 9.00]; BAYES_HAM(-2.79)[99.11%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[15]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-HE-Tag: 1669976832-584845 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Dave Kleikamp Acked-by: Johannes Weiner --- fs/jfs/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index d1ec920aa030a8..8ac10e39605081 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c @@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock, return rc; } -static int jfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, jfs_get_block, wbc); -} - static int jfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = jfs_read_folio, .readahead = jfs_readahead, - .writepage = jfs_writepage, .writepages = jfs_writepages, .write_begin = jfs_write_begin, .write_end = jfs_write_end, .bmap = jfs_bmap, .direct_IO = jfs_direct_IO, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Fri Dec 2 10:26:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13062593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23FCC4332F for ; Fri, 2 Dec 2022 10:27:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D1356B0081; Fri, 2 Dec 2022 05:27:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481246B0082; Fri, 2 Dec 2022 05:27:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 370F16B0083; Fri, 2 Dec 2022 05:27:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27DA86B0081 for ; Fri, 2 Dec 2022 05:27:17 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E89CD140A57 for ; Fri, 2 Dec 2022 10:27:16 +0000 (UTC) X-FDA: 80196988872.21.804DBE2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 9C69020014 for ; Fri, 2 Dec 2022 10:27:15 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HXq5AdxV; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669976835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ywtjhPQcgOlGzjWc3Exa4ySbtdQqSrPXJutgQizLuUo=; b=XbzJ8BZ0FLrKsO/+9LaUMu8kYt+vW7YzKtLGqfztM1e088A+0Oe6qW2h/CQp58VQ0TGeh4 lS7ApJpNInAt7v24/QzY+EvW+ulBydoJAQTtzsAqHR4rwTWpM1uM4SV3czYDKJokJdxLpI vHzB3lpMq7Zz6pOtB4DZAgRkU8Zw4Qk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HXq5AdxV; spf=none (imf03.hostedemail.com: domain of BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+dbb76fff442e09cb8719+7040+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669976835; a=rsa-sha256; cv=none; b=BLPuOjGL8yxnqZOrR4/RrMMf8VI9S25JpjTbS7drqknOvYz2qhYwvd1bMSmV63RXYiZOP/ /h/ttCHeMPbVhezUa27X+BXm9RqKO7U/qwSbNrhYRpok633mAFmyUo8BnNUH88ydTLOk3s YUAlwVizZjdKfLXxNYyXHpcOhUp3Uw4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=ywtjhPQcgOlGzjWc3Exa4ySbtdQqSrPXJutgQizLuUo=; b=HXq5AdxV/JLPsHwBXHtl6u2lb/ O7u7n/5ATf1Y7czUryBELG+fWD6o77IRDBXirmaK99zd0OnuWoCsFD0vvB7MBwGPmX+UfXJ6JYnHe 60yXoyn70JPY2g2sOi+iZ6861z+gHmCSZj06a3POXM4lZjepl0cQW4c1s99+y0pdCmW36KUOMkD4l xEH4Q9edKiH5Kyi92aSET/9e7N2etBpDpDi60GkmsRcId338irWzzNt/ZjxGhj83RHXOQC9rfYLSX 2hZ27PRsmWgyB65AhiG12LwsukHkkFy+mJ6XLTA/KuMEgryP5l2NB3YI2C6BRf2mEyCfDxmY5jCLd MLpoafjg==; Received: from [2001:4bb8:192:26e7:bcd3:7e81:e7de:56fd] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p13G7-00FR4c-4r; Fri, 02 Dec 2022 10:27:07 +0000 From: Christoph Hellwig To: Andrew Morton , Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org, Johannes Weiner Subject: [PATCH 7/7] omfs: remove ->writepage Date: Fri, 2 Dec 2022 11:26:44 +0100 Message-Id: <20221202102644.770505-8-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221202102644.770505-1-hch@lst.de> References: <20221202102644.770505-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spamd-Result: default: False [0.84 / 9.00]; BAYES_HAM(-2.76)[98.95%]; R_MISSING_CHARSET(2.50)[]; MID_CONTAINS_FROM(1.00)[]; FORGED_SENDER(0.30)[hch@lst.de,BATV@bombadil.srs.infradead.org]; R_DKIM_ALLOW(-0.20)[infradead.org:s=bombadil.20210309]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[14]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TAGGED_FROM(0.00)[dbb76fff442e09cb8719,7040,infradead.org,hch]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[infradead.org:+]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[lst.de]; FROM_NEQ_ENVFROM(0.00)[hch@lst.de,BATV@bombadil.srs.infradead.org] X-Rspamd-Queue-Id: 9C69020014 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 81k9x79spyk4cf43omxjaybb6qcjwyh7 X-HE-Tag: 1669976835-529497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Bob Copeland Acked-by: Johannes Weiner --- fs/omfs/file.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/omfs/file.c b/fs/omfs/file.c index fa7fe2393ff686..3a5b4b88a58385 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -294,11 +294,6 @@ static void omfs_readahead(struct readahead_control *rac) mpage_readahead(rac, omfs_get_block); } -static int omfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, omfs_get_block, wbc); -} - static int omfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -375,10 +370,10 @@ const struct address_space_operations omfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = omfs_read_folio, .readahead = omfs_readahead, - .writepage = omfs_writepage, .writepages = omfs_writepages, .write_begin = omfs_write_begin, .write_end = generic_write_end, .bmap = omfs_bmap, + .migrate_folio = buffer_migrate_folio, };