From patchwork Thu Dec 8 19:32:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13068698 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8CCC4332F for ; Thu, 8 Dec 2022 19:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbiLHTca (ORCPT ); Thu, 8 Dec 2022 14:32:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiLHTc3 (ORCPT ); Thu, 8 Dec 2022 14:32:29 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7969E474 for ; Thu, 8 Dec 2022 11:32:28 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id c66so218304edf.5 for ; Thu, 08 Dec 2022 11:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4NYG9lYEZ9wsyuwGTuamr3MpqAUVMVxHSEFMBUyZQg4=; b=m9UY/ppuM6so+aDHm+3TIwuNG7HnrZ3nIcDPo9V1AwCuSkmep2GCi6PfDDOXcWMyjw GIhZjgXZTyDVsaX9chD/htfVDFQdiwd3BJP13/sQj/ELrxyQ6309pqxaUjXKq6Zr+myA u1fALcmv+4XVfPzadmEctOhpe7mUXDrybcQtp2+woNTAngBw33V1wUEtvjYcIcQlUkh9 AFR+iVuyQ/Xp4rXMTKTI8AdrZoKYh3tMV/11HXQAUODiAvkK/ZQbkmmP3tvBbgPBcGDH 2GXAcPxs+Q+75EiqwC92o4R0/IW4aff19D0AGehn6eMpyF6oGo2yUtjxWOH6L69bQiah 4/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4NYG9lYEZ9wsyuwGTuamr3MpqAUVMVxHSEFMBUyZQg4=; b=z3llIwyxQHJYroQvvO95UsaRZ+/BB0Crz34+U9VoW4bbcz9V950FrmNH0fZmGdfy6I FPs/SKzUqwl6dk2tZtMt08Lcl7jDqlFZYOTboPqQo4d9jxqrG85ZUKDs7u1lwxAN4wrx 49UQh90pzNzdYlo020UpW7ZyIVlfNdttHmvbMHZCora/O0bTDYEG1AoxMXRMEjs0Fg91 NwKb3Oau0zVcxKkXqLb6dsu+WAdq/qCg2ANQ7XbvJ3Wrub53evHog0fnYAVqUYUuWK6O whtMbpcZvtN94iRLb8Gm0zZg/oGe5duzr+VBR5GpJ+YsK8pFJF7zjQ1G6bTFpzeDmD9z mCQA== X-Gm-Message-State: ANoB5pk0LPehpt0kJR7ejRWbGWMhTgiI+urYSpKWeD0WlLMLR3vvP2Cj 3xuEROzPwf1j9esqcVM0UZi9YlbSm78= X-Google-Smtp-Source: AA0mqf7s3PQBOGhiXPe+M67kdRx9kXAsTrBDKpZII3ME4oRMm0U9+AXjPkPk8ZnhiXdxUQ0+U2PD6w== X-Received: by 2002:aa7:c844:0:b0:461:9faf:6895 with SMTP id g4-20020aa7c844000000b004619faf6895mr2710687edt.16.1670527946592; Thu, 08 Dec 2022 11:32:26 -0800 (PST) Received: from [192.168.1.50] ([79.119.240.254]) by smtp.gmail.com with ESMTPSA id g3-20020aa7c843000000b0046c5baa1f58sm3682864edt.97.2022.12.08.11.32.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 11:32:25 -0800 (PST) Message-ID: <4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com> Date: Thu, 8 Dec 2022 21:32:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: "linux-wireless@vger.kernel.org" Cc: Jes Sorensen , Ping-Ke Shih From: Bitterblue Smith Subject: [PATCH 1/2] wifi: rtl8xxxu: Fix assignment to bit field priv->pi_enabled Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Just because priv->pi_enabled is only one bit doesn't mean it works like a bool. The value assigned to it loses all bits except bit 0, so only assign 0 or 1 to it. This affects the RTL8188FU, but fixing the assignment didn't make a difference for my device. Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU") Signed-off-by: Bitterblue Smith Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c index 2c4f403ba68f..97e7ff7289fa 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c @@ -1122,7 +1122,7 @@ static void rtl8188fu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, if (t == 0) { val32 = rtl8xxxu_read32(priv, REG_FPGA0_XA_HSSI_PARM1); - priv->pi_enabled = val32 & FPGA0_HSSI_PARM1_PI; + priv->pi_enabled = u32_get_bits(val32, FPGA0_HSSI_PARM1_PI); } /* save RF path */ From patchwork Thu Dec 8 19:34:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 13068699 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8594C4332F for ; Thu, 8 Dec 2022 19:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiLHTeK (ORCPT ); Thu, 8 Dec 2022 14:34:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbiLHTeJ (ORCPT ); Thu, 8 Dec 2022 14:34:09 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D70A60340 for ; Thu, 8 Dec 2022 11:34:05 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id z92so245478ede.1 for ; Thu, 08 Dec 2022 11:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j0fIvmWIXC/bOWAKQkQKVKw+6yE449NOWkc6VNjsFKQ=; b=aXQVFP6hoFx2chr6GTNTGHbeOTUJowiTyysxXQxi7gLi8ZDZCuk3FQ9PiW2B30utlN 0gwoPuGa2NW13giRAd0GOK0YugbVy4K2V8Do6ErbJF/etWlqa95KE3OAzsGP9xnKaw80 ZKUvByM04F1h7c+DkMJBFsTVZaxzhSPoAF/7CV8jF9lKhsRsAaS69GboyJ0mVcGih7dr ikacTvgua9EAKHOQc6qnRU59pkvg8yE104CI0n8dXuoVsSWWfRXYYQaaPf3H6HhnafiE RzIifMGNwsxDq1hEdMqyRZQY9YZXBCtZKnFSmX4O7cHJmHLJNBIURe4V1GD+BuRxR11h 0tCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j0fIvmWIXC/bOWAKQkQKVKw+6yE449NOWkc6VNjsFKQ=; b=6YDLAlr28/HCybZwIoRLvopkC1UZBtqepB02SlpicmP+nXwM2uz7RVOlBQ2Y5O/eC7 KQzzJ+KL/exVu5O4G9V/meev6LXLCBlQXNwl/29KdEMSly7V9sSM8yLGhmy1w/Fqzj0i xmiZF+fpYEkPNmIl0Eb82tzvqOhmHC46bP7u8qqDERKHJkN3r50BwEamKPlcEQShX0S5 hMkjUlDixVBnUtruohF9KY2fKdAgpOWJrK3FEctLjwQkfap4rh7U2W95xlHgnJVjK7JX S45qNdDictOdMpg9SH2J37pStL7xLwZJsVHd0b1RySU/nMNNJfgKu+HjKird5u5YK6Vy KTCQ== X-Gm-Message-State: ANoB5pkijfHTygr+dC0ED7EMHvd4bN3V/X1WZ3eYKmGHOhu6nfWLlLYm AjKGBTboRh/n2PM5m9UHiLn6Azhpsmk= X-Google-Smtp-Source: AA0mqf7M2Fw1iYOL+dYIX0HQMbfysgASvFt+XX+XQpLWkNqeSHt+OoBKn2RV0BFJYSMUlpyt/8Up3g== X-Received: by 2002:a05:6402:289c:b0:461:bf47:ba43 with SMTP id eg28-20020a056402289c00b00461bf47ba43mr3527749edb.28.1670528043857; Thu, 08 Dec 2022 11:34:03 -0800 (PST) Received: from [192.168.1.50] ([79.119.240.254]) by smtp.gmail.com with ESMTPSA id dk21-20020a0564021d9500b0045723aa48ccsm3716598edb.93.2022.12.08.11.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 11:34:03 -0800 (PST) Message-ID: <7bb4858c-5cef-9cae-5e08-7e8444e8ba89@gmail.com> Date: Thu, 8 Dec 2022 21:34:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: [PATCH 2/2] wifi: rtl8xxxu: Fix assignment to bit field priv->cck_agc_report_type Content-Language: en-US From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Jes Sorensen , Ping-Ke Shih References: <4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com> In-Reply-To: <4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Just because priv->cck_agc_report_type is only one bit doesn't mean it works like a bool. The value assigned to it loses all bits except bit 0, so only assign 0 or 1 to it. This affects the RTL8192EU, but rtl8xxxu already can't connect to any networks with this chip, so it probably didn't bother anyone. Fixes: 2ad2a813b803 ("wifi: rtl8xxxu: Fix the CCK RSSI calculation") Signed-off-by: Bitterblue Smith Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 3ed435401e57..799b03ec1980 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -4208,10 +4208,12 @@ static int rtl8xxxu_init_device(struct ieee80211_hw *hw) * should be equal or CCK RSSI report may be incorrect */ val32 = rtl8xxxu_read32(priv, REG_FPGA0_XA_HSSI_PARM2); - priv->cck_agc_report_type = val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR; + priv->cck_agc_report_type = + u32_get_bits(val32, FPGA0_HSSI_PARM2_CCK_HIGH_PWR); val32 = rtl8xxxu_read32(priv, REG_FPGA0_XB_HSSI_PARM2); - if (priv->cck_agc_report_type != (bool)(val32 & FPGA0_HSSI_PARM2_CCK_HIGH_PWR)) { + if (priv->cck_agc_report_type != + u32_get_bits(val32, FPGA0_HSSI_PARM2_CCK_HIGH_PWR)) { if (priv->cck_agc_report_type) val32 |= FPGA0_HSSI_PARM2_CCK_HIGH_PWR; else