From patchwork Thu Aug 9 19:00:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 10561693 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EC64B13B4 for ; Thu, 9 Aug 2018 19:01:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBBB22B8FA for ; Thu, 9 Aug 2018 19:01:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CFF3E2B8CE; Thu, 9 Aug 2018 19:01:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B4372B8FA for ; Thu, 9 Aug 2018 19:01:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727133AbeHIV1T (ORCPT ); Thu, 9 Aug 2018 17:27:19 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36289 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbeHIV1T (ORCPT ); Thu, 9 Aug 2018 17:27:19 -0400 Received: by mail-ed1-f67.google.com with SMTP id k15-v6so3392481edr.3 for ; Thu, 09 Aug 2018 12:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2z4P02GW83/D1XuhUC6Aa6+fYDqMjrn5AdhFuC8OVtk=; b=basFcsozrC2qG4tDDK7WrADtkbdwg7hwEYjm6UYHqwp8itx3bJSmVnYBcXrzpmbOBo pkwA/QzQMl1Nu64P1q6Ohl5l4R6Nk4S4bPzGLj1IaKDYRLk3EnI9kGdBSpmew30HX7nv UoD+lDX8y9IxbaugsSvDuUQcd709opPHqfwaLA8Afgvz1JkzxvqD0caiJY2oK4oMGlad +hJdDalRpzGFxy6hkUj9bx//fYIC+No61goXxxjKawda/fkuDJk3L3Gv7dDXHvZyo2Cy aXzBGAV6GANMV7wDYhKCzYC/6eAm5sJbVT6PQ/mE4IO0c7YMQsJrzvh4l86Ks5Cv8ZP8 BZcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2z4P02GW83/D1XuhUC6Aa6+fYDqMjrn5AdhFuC8OVtk=; b=JmuzlWiNymQ4sES+CwHieEMBdfoaLrZ3dMtC7mQQvAYrnt9XuzkUepQ5yNCFjU2yA4 iJCKvu1jRotIALI7oXvviivmdmS9GEzeSaCKiV30T9z4UeQWH1bjas65C3tA9U5GFV/Y sFlTI6STmJnSbCnDDxiUcf51hZEUyBi72wINfVTxY6OdVuvcqFZSZHv8YpsseCp72ieD 6c2/8s475WzE6L6dtYoXSNsWimGot9Z7C2IXmPrTv9QOZSbjx4wn5iaTCmlTjF3CfVTT iKq4nms+5AoPWvBdWV+X1mLdWdkfR1JTjbjV9d9e1QBE+NwdjXwArRrv2izei/BL1Qaj HO+g== X-Gm-Message-State: AOUpUlHWLLp8HQKKQnyWueY1svUCs+QxLUz8IguBpHLsxMIBck7CS+6e 50zA3vpHGN3odYLfUcTmsvI= X-Google-Smtp-Source: AA+uWPw0LcwmjeOC6U4rh8kVdRvIBQhhnyTthonP3WeO36MOJSOJlzUfV7IuN/qQpQiR8f5dgLmzMA== X-Received: by 2002:a50:ec89:: with SMTP id e9-v6mr4711811edr.258.1533841267194; Thu, 09 Aug 2018 12:01:07 -0700 (PDT) Received: from a-314bh6t9fh21n.eu-west-1.compute.internal (ec2-52-214-2-46.eu-west-1.compute.amazonaws.com. [52.214.2.46]) by smtp.gmail.com with ESMTPSA id a5-v6sm3006332edr.1.2018.08.09.12.01.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 12:01:06 -0700 (PDT) From: Gal Pressman To: Lijun Ou , "Wei Hu(Xavier)" , Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Gal Pressman Subject: [PATCH rdma-next] RDMA/hns: Fix usage of bitmap allocation functions return values Date: Thu, 9 Aug 2018 22:00:47 +0300 Message-Id: <20180809190047.6642-1-pressmangal@gmail.com> X-Mailer: git-send-email 2.14.4 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP hns bitmap allocation functions return 0 on success and -1 on failure. Callers of these functions wrongly used their return value as an errno, fix that by making a proper conversion. Fixes: a598c6f4c5a8 ("IB/hns: Simplify function of pd alloc and qp alloc") Signed-off-by: Gal Pressman --- drivers/infiniband/hw/hns/hns_roce_pd.c | 2 +- drivers/infiniband/hw/hns/hns_roce_qp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_pd.c b/drivers/infiniband/hw/hns/hns_roce_pd.c index b9f2c871ff9a..e11c149da04d 100644 --- a/drivers/infiniband/hw/hns/hns_roce_pd.c +++ b/drivers/infiniband/hw/hns/hns_roce_pd.c @@ -37,7 +37,7 @@ static int hns_roce_pd_alloc(struct hns_roce_dev *hr_dev, unsigned long *pdn) { - return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn); + return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn) ? -ENOMEM : 0; } static void hns_roce_pd_free(struct hns_roce_dev *hr_dev, unsigned long pdn) diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c index c1dbddcd58c9..60837edbcffd 100644 --- a/drivers/infiniband/hw/hns/hns_roce_qp.c +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c @@ -115,7 +115,7 @@ static int hns_roce_reserve_range_qp(struct hns_roce_dev *hr_dev, int cnt, { struct hns_roce_qp_table *qp_table = &hr_dev->qp_table; - return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align, base); + return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align, base) ? -ENOMEM : 0; } enum hns_roce_qp_state to_hns_roce_state(enum ib_qp_state state)