From patchwork Fri Dec 16 12:47:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13074992 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F11EC4332F for ; Fri, 16 Dec 2022 12:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbiLPMrk (ORCPT ); Fri, 16 Dec 2022 07:47:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiLPMri (ORCPT ); Fri, 16 Dec 2022 07:47:38 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92E75CF5 for ; Fri, 16 Dec 2022 04:47:37 -0800 (PST) Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C997F8524E; Fri, 16 Dec 2022 13:47:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671194855; bh=fEIEJmdqmkeSkg+RQHUIRuf+WGzlxZ/wuMipOCxnQ54=; h=From:To:Cc:Subject:Date:From; b=v4PmfzUxOPbcOS9d7HuzcZnayDMZHlVVjFVW8qrwTYmtpfloVeUpj8hbj5XV+1Rwp vnf0cGEgPf8MREfltX+hAb5i/vfsxsqveBHgymnwdAYdeiHTsfANEVGkkaUtP16eUk oh2xkz9fydZ987cBXeZrMQg08QoxfoVXnZJVI0YNvJixxGzWmH8b5hzFPJ9ExuIYyc Q6AsI5fATuY3deY6ti5CXX2ovczIssI2NYGumLFHTHmXpkCDGXdcuOAfjlAKwsNrXd J+yBjoPqgDGTPB7qiW2FJDoh9mBY5QsEtv0TS1rB1vNSltWmbsnYRsVKGk371PJEKI 6ajes8/a2wP4w== From: Marek Vasut To: netdev@vger.kernel.org Cc: Marek Vasut , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Geoff Levand , Jakub Kicinski , Linus Walleij , Paolo Abeni , Petr Machata , Wolfram Sang Subject: [PATCH] net: ks8851: Drop IRQ threading Date: Fri, 16 Dec 2022 13:47:31 +0100 Message-Id: <20221216124731.122459-1-marex@denx.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Request non-threaded IRQ in the KSZ8851 driver, this fixes the following warning: " NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!! " Signed-off-by: Marek Vasut --- Cc: "David S. Miller" Cc: Dmitry Torokhov Cc: Eric Dumazet Cc: Geoff Levand Cc: Jakub Kicinski Cc: Linus Walleij Cc: Paolo Abeni Cc: Petr Machata Cc: Wolfram Sang To: netdev@vger.kernel.org --- drivers/net/ethernet/micrel/ks8851_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/micrel/ks8851_common.c b/drivers/net/ethernet/micrel/ks8851_common.c index cfbc900d4aeb9..1eba4ba0b95cf 100644 --- a/drivers/net/ethernet/micrel/ks8851_common.c +++ b/drivers/net/ethernet/micrel/ks8851_common.c @@ -443,9 +443,7 @@ static int ks8851_net_open(struct net_device *dev) unsigned long flags; int ret; - ret = request_threaded_irq(dev->irq, NULL, ks8851_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - dev->name, ks); + ret = request_irq(dev->irq, ks8851_irq, IRQF_TRIGGER_LOW, dev->name, ks); if (ret < 0) { netdev_err(dev, "failed to get irq\n"); return ret;