From patchwork Wed Dec 21 06:10:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Srinivasa Rao Mandadapu X-Patchwork-Id: 13078474 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CEFC4332F for ; Wed, 21 Dec 2022 06:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234455AbiLUGLv (ORCPT ); Wed, 21 Dec 2022 01:11:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiLUGLu (ORCPT ); Wed, 21 Dec 2022 01:11:50 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A95421E; Tue, 20 Dec 2022 22:11:49 -0800 (PST) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BL5oFQj028376; Wed, 21 Dec 2022 06:11:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=T59+OGJo76VoGlmNoaP6JZlHidx8e5QMXw8nvlGU/A0=; b=fUba4cm4RyWXngajAu6qTYjEdHSJx7gXKfAHwmqAYrHsh4dpSoC6evOL1OU0za2pxzf2 Q7FhH5Qhlfx5HOyhazccFcviHyqvXmGLwNhi8UoCpB7KilIemVYBanISGCnlyK2xX6MM 0h1jeBFhL5TiMNlRRr87aptxg2TnNOdHQq92DZTF7zZTVyA7jetGQSIt+Ey+VGmjBWG7 3RBdX0Foud9hrdjAqhExooy1HJ97Npc0DC/fpHHqRxBkXiLlFEepqvYh/P99MsVkoH0B Zo3G6vkvm6aSLLdPj3nw4Wc4VhJtbSGtUEz2UzTISrVGWdnNRV0uIklf3oAs8op1sMfA iQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mjyk53haf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Dec 2022 06:11:04 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BL6B3Md012882 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Dec 2022 06:11:03 GMT Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 20 Dec 2022 22:10:57 -0800 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , , , , , CC: Srinivasa Rao Mandadapu Subject: [PATCH v4 1/2] remoteproc: elf_loader: Update resource table name check Date: Wed, 21 Dec 2022 11:40:32 +0530 Message-ID: <1671603033-4359-2-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1671603033-4359-1-git-send-email-quic_srivasam@quicinc.com> References: <1671603033-4359-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Y315FuH7b539WBAQ_5YBIQ2ri_IgeJdG X-Proofpoint-ORIG-GUID: Y315FuH7b539WBAQ_5YBIQ2ri_IgeJdG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-21_02,2022-12-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 clxscore=1015 suspectscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212210044 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Update the way of checking resource table name with prefix substring search instead of complete string search. In general, Qualcomm DSP binary is prepared by combining different ELFs'. Hence, section header name (e.g. .resource_table), appended with ELF name to differentiate with same section(e.g. resource_table.ac_bin_process) of different ELFs'. Example readelf output of DSP binary: [60] .start.ac_bin_process PROGBITS [61] .resource_table.ac_bin_process PROGBITS [62] .comment.ac_bin_process PROGBITS Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mukesh Ojha --- drivers/remoteproc/remoteproc_elf_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c index 5a412d7..77330d6 100644 --- a/drivers/remoteproc/remoteproc_elf_loader.c +++ b/drivers/remoteproc/remoteproc_elf_loader.c @@ -272,7 +272,7 @@ find_table(struct device *dev, const struct firmware *fw) u64 offset = elf_shdr_get_sh_offset(class, shdr); u32 name = elf_shdr_get_sh_name(class, shdr); - if (strcmp(name_table + name, ".resource_table")) + if (!strstarts(name_table + name, ".resource_table")) continue; table = (struct resource_table *)(elf_data + offset); From patchwork Wed Dec 21 06:10:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Srinivasa Rao Mandadapu X-Patchwork-Id: 13078475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161F9C4167B for ; Wed, 21 Dec 2022 06:12:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234492AbiLUGMB (ORCPT ); Wed, 21 Dec 2022 01:12:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234494AbiLUGLx (ORCPT ); Wed, 21 Dec 2022 01:11:53 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C06F1C43B; Tue, 20 Dec 2022 22:11:52 -0800 (PST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BL4vVnx023999; Wed, 21 Dec 2022 06:11:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=qcppdkim1; bh=+heDGs/oZLOUaewrIht7Fb2HiZicHGJxI2rC5tPSqso=; b=SYU5lMgi4Tmn+GdhJdBtrlx7EFhCyvfispuSdyLW9e71SEzxdQaFVjtKFy8I2BBtktDu IhUHMtb/A8SaTefNuee8LqtEfm//NPdFibDyUnnfzYOwhARniDjFMYNyQ12reua7e943 nMTEUg2oIVbQILyYDPavlDVxuK5H83wO2x9i+K3spiUE0Z5wB0HDICMX8+Cs6DI7EKr+ cHGwZ8ZGA4K7OwE+RRsUd9/0jLoGs/2GZ4BVcIwePrhYAhlyJUJHuNdOHBlR4hrHi9kJ BlfjtxoHuIU9fnAWuCIHGtTdSZAvRETSL2oLPDmriaqBKFOYOs7F8PRwOk5m6LURYtrb Xg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mkcxv9xme-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Dec 2022 06:11:11 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2BL6BArX026033 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Dec 2022 06:11:10 GMT Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 20 Dec 2022 22:11:04 -0800 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , , , , , CC: Srinivasa Rao Mandadapu Subject: [PATCH v4 2/2] docs: remoteproc: Update section header name requirement Date: Wed, 21 Dec 2022 11:40:33 +0530 Message-ID: <1671603033-4359-3-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1671603033-4359-1-git-send-email-quic_srivasam@quicinc.com> References: <1671603033-4359-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: iIaKJcBDtKFQuJUyBS-h4uVK7IAHAyN7 X-Proofpoint-ORIG-GUID: iIaKJcBDtKFQuJUyBS-h4uVK7IAHAyN7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-21_02,2022-12-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=928 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212210044 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add section header name requirement specification in elf segments. Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mukesh Ojha --- Documentation/staging/remoteproc.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/staging/remoteproc.rst b/Documentation/staging/remoteproc.rst index 348ee7e..0c9c10a 100644 --- a/Documentation/staging/remoteproc.rst +++ b/Documentation/staging/remoteproc.rst @@ -244,7 +244,10 @@ according to the specified device address (might be a physical address if the remote processor is accessing memory directly). In addition to the standard ELF segments, most remote processors would -also include a special section which we call "the resource table". +also include a special section which we call the "resource table". +A "resource table" section name must start with the ".resource_table" prefix, +optionally having a more descriptive string appended. For example, +".resource_table.my_rproc" is a valid section name. The resource table contains system resources that the remote processor requires before it should be powered on, such as allocation of physically