From patchwork Wed Dec 21 21:06:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Finkelstein X-Patchwork-Id: 13079179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5063EC4332F for ; Wed, 21 Dec 2022 21:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RZ1I031qUPTw4gEr/FWAVMvhPBQLGM2bh2JV7ZVpk3M=; b=IRxtGOXakboaTW AJyVhhBq0RiHV8E7fSyenBXAXdsK6p9dqhuk+jxn3SuAwm2VXYCNwHmQ16nWb0n+jbyAamkfsfegh 8qHdy6bu3jw1gs1rGYKVcL5sPwZh0sN20cVRcE2Hf7HcQWw7L4r210D/xW1iO/3OywburA8oOSQaC nrHRH2R2TlumEva0hKtPX82vRvHA2RDVWEtNiQe/pV+rZJ7g00lHvodc4Ln7VZHjthHAAWgVQ5WTc C5KXtDqHC3tHnYwXletK/JlSfTQVa9CaLKwYvaB65V4v4pYMRFXwuXSGbizDmvZ4udM0GIitR+trU 1tDC3zmxkn0rHAy4WvbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86Ya-002iay-F4; Wed, 21 Dec 2022 21:23:21 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86Im-002Yam-St for linux-arm-kernel@lists.infradead.org; Wed, 21 Dec 2022 21:07:02 +0000 Received: by mail-wm1-x32a.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso2476309wme.5 for ; Wed, 21 Dec 2022 13:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6k6iH6ye4eNPwympT1HKSV19Z/5AZl0oVvTiapSuckY=; b=TV7HOi/nDk6tN6Btf7NEWSQXW12jGkXqBc1ZJZCpH7rHo1bIES6jPHXyDmr0LSxqbo b5uA3Oar5vljGcFFGzJfAEtkP83r+gCzHBOsSCdOBCVWDhP++QpHCL6iZoaFO81DDjOp +ln2VaE4F/NLkO8nhyNKGYtqHD7HyPc5ztIKFo8uEpxmAOy8vaB5ZgTRNQ33jW9Klc5d 4C3KidpPrCRZFnnd84lnlzKTBA7BtjKQco9hL0K1ntYXZFvcmLYkpUELHmd5cmHheaWA ppkuj5BGp+nUHilJygcVRcX3rztLrHkZB0rn2+VypnYZDGo0RF94KAxBcymdTpfPNrGM m1Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6k6iH6ye4eNPwympT1HKSV19Z/5AZl0oVvTiapSuckY=; b=rxfrnPr2Td5yCeStbGOvwSLUE39QsDFh+0VAm/emv8Dra0llXh0xNPkFrKAf+6+CR1 mgeADKEdj3oUnqc6mQYiuiAjXiOO/+w2fKcYjJDAKKPRmIulvqYVVh0Bo/4BoCZCaALg J8V4eaVicgkkCJon+cUQyQrYYRpMqXJ25BsxwRzuqCbHEHSGVmmj5xrUzibuE1qhdMgQ U5avHa9ZN1zNC/pNPnQ+PV6OqOJXnW9PEW6nmlJoSauGM2g5Srk+GYM60eelADxjCD5Z CIpu124SpGfqxvCNLSpFCUroU0YAHTcyiePoWlvDWmpQcC88Sx+b/Dvm6zq4Xtdvhr6f iOUQ== X-Gm-Message-State: AFqh2kqU7riWK5So2MyS0TZM6IEB/e438yWtlOYtMvXRbH4uE3IYGqA+ YBnDHqlr+9sBMnGTcRxUvRk= X-Google-Smtp-Source: AMrXdXtPsFcQ9nULzy25sD18SHnQ2BII+Hj9pyW0qhYMJrpKlYHMDezmfPea/fZ/j/2g/LCcQ8OxMA== X-Received: by 2002:a05:600c:3b82:b0:3cf:900c:de6b with SMTP id n2-20020a05600c3b8200b003cf900cde6bmr2673465wms.15.1671656818782; Wed, 21 Dec 2022 13:06:58 -0800 (PST) Received: from localhost ([176.234.10.188]) by smtp.gmail.com with UTF8SMTPSA id iv7-20020a05600c548700b003d35c09d4b9sm4134856wmb.40.2022.12.21.13.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 13:06:58 -0800 (PST) From: Sasha Finkelstein To: u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein , Krzysztof Kozlowski Subject: [PATCH v5 1/4] dt-bindings: pwm: Add Apple PWM controller Date: Thu, 22 Dec 2022 00:06:45 +0300 Message-Id: <20221221210648.2735-2-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20221221210648.2735-1-fnkl.kernel@gmail.com> References: <20221221210648.2735-1-fnkl.kernel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_130701_017373_FF837CCA X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight. Signed-off-by: Sasha Finkelstein Reviewed-by: Krzysztof Kozlowski Acked-by: Sven Peter --- .../bindings/pwm/apple,s5l-fpwm.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml diff --git a/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml new file mode 100644 index 000000000000..142157bff0cd --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/apple,s5l-fpwm.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/apple,s5l-fpwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple FPWM controller + +maintainers: + - asahi@lists.linux.dev + - Sasha Finkelstein + +description: PWM controller used for keyboard backlight on ARM Macs + +properties: + compatible: + items: + - enum: + - apple,t8103-fpwm + - apple,t6000-fpwm + - apple,t8112-fpwm + - const: apple,s5l-fpwm + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + + "#pwm-cells": + const: 2 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + pwm@235044000 { + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm"; + reg = <0x35044000 0x4000>; + power-domains = <&ps_fpwm1>; + clocks = <&clkref>; + #pwm-cells = <2>; + }; From patchwork Wed Dec 21 21:06:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Finkelstein X-Patchwork-Id: 13079182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34B3EC4332F for ; Wed, 21 Dec 2022 21:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sznH2HsJ0K8+U48Q5RUWaWeLUSqwTY1wLYSpHuIgDMU=; b=vCLP3goObG/Ful uO8LeC/QLNRcryPEbl4QbWg+35MKwPKY9f/PM+JP5cmhVVHr8dc6ZBo2cz6C4JqomozEK25Agy2TI 6mLithTKKJVuSHMtuxhCGOr3r2Eahz7cOSFhN7xzrwvThmY+vlh+5UZki/R6+DW4Yp367NxYk3QM4 I58HAS8bvuB91diaFessqvafZQUTN53vheVLy6M2ZF627RMCW9a+sHmE+NHxgWDqYtIF/gT573QUx NzfN+JlDQZORjnrqwGbhw+fyxEk+iZ7VdBNLQnb1hFjFpYBtdzaxJW3Vujhth9UtIq7/EmvQqDTSN d2xGw/s167oB8Bwv2Tqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86aW-002jY1-RM; Wed, 21 Dec 2022 21:25:22 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86Iw-002Yg5-DN for linux-arm-kernel@lists.infradead.org; Wed, 21 Dec 2022 21:07:12 +0000 Received: by mail-wm1-x32e.google.com with SMTP id ay2-20020a05600c1e0200b003d22e3e796dso2379492wmb.0 for ; Wed, 21 Dec 2022 13:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQdvSaqbWHS4wz+69NFwa5kReNCnCDhDB3OtMVssUjQ=; b=aIpgBQsker2pIhmo1vLTLk2kkV1LfzF0IhdRh0TNqIQM5KqT1ZC7HZYKU59/rnnCjx tFN3rmaYs6o2bQNlNJbZhOC3Lae01EMw0qepQarchNCU8HFgJk+O3O2otdFN0wY9WHLt GHgIL5WwWQ2VBU4xi0rKOjpZUA0KKlr2XUGxHFjISPA37veWlyUcI4y7qBFjruLY5cyW lSSCenaawwGIO+fzlyDZdYLynVpao+ZkqS+1SZJOzpPCutWFAi3TL68XoUtW2Yf+ouy8 A89nFOThjCkx/We+X8kjykeFSr8Eq2lUPPTpiDKOi4SnWRPumpHVdeT7FzCNGgf+p0CZ a3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQdvSaqbWHS4wz+69NFwa5kReNCnCDhDB3OtMVssUjQ=; b=4EFWfsvp131LoPjeoFirnUoya4FcmERP9NX9dMw1gzb24r+qqni54KSJvzpMnaTVRE P07FxRmYtTmPk5/eceT0H2cBH+VqE7vQc2iaS9i+iSOkbqp70VVG8Mg9OFM+ImZrGe3Q xcDKTAIuqgSFLmncgMmyK7wdzWMRQFLD58yTGC1B4+6dkQGQCTKTqEa9sIVC41ECI0RV Wys73w+dHd4bf9csHQEJ4pvduu1bAWczXKv5X/gLmuK22S+ddeFSn/hbSiutPAonGO4i h/DZXAUMMsYqbc7REqtv+oYav3CQznoAdixtluOAbXrKBGf1VZDH+0jRdFAKxvudb2Y1 RGXw== X-Gm-Message-State: AFqh2krR0CYWYt6mnKyr12PoHN7xVadqYmo3CMdzX9cNoHUbHoE0u0Xg boDbHjDULLe4h/eotxnTSIY= X-Google-Smtp-Source: AMrXdXuoS7C9qK4GEk0MQPo0OanE6nyR5kYYS03xd9vnUbNCr2Thc5mqdT081cn4vMQeiFxjSuvoVw== X-Received: by 2002:a05:600c:34d3:b0:3c6:e61e:ae74 with SMTP id d19-20020a05600c34d300b003c6e61eae74mr3129826wmq.4.1671656825883; Wed, 21 Dec 2022 13:07:05 -0800 (PST) Received: from localhost ([176.234.10.188]) by smtp.gmail.com with UTF8SMTPSA id x15-20020a1c7c0f000000b003c6bbe910fdsm4438944wmc.9.2022.12.21.13.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 13:07:05 -0800 (PST) From: Sasha Finkelstein To: u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein Subject: [PATCH v5 2/4] pwm: Add Apple PWM controller Date: Thu, 22 Dec 2022 00:06:46 +0300 Message-Id: <20221221210648.2735-3-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20221221210648.2735-1-fnkl.kernel@gmail.com> References: <20221221210648.2735-1-fnkl.kernel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_130710_549515_E888BB4D X-CRM114-Status: GOOD ( 27.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Adds the Apple PWM controller driver. Signed-off-by: Sasha Finkelstein Acked-by: Sven Peter --- drivers/pwm/Kconfig | 12 ++++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-apple.c | 154 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 167 insertions(+) create mode 100644 drivers/pwm/pwm-apple.c diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index 60d13a949bc5..c3be11468414 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -51,6 +51,18 @@ config PWM_AB8500 To compile this driver as a module, choose M here: the module will be called pwm-ab8500. +config PWM_APPLE + tristate "Apple SoC PWM support" + depends on ARCH_APPLE || COMPILE_TEST + help + Generic PWM framework driver for PWM controller present on + Apple SoCs + + Say Y here if you have an ARM Apple laptop, otherwise say N + + To compile this driver as a module, choose M here: the module + will be called pwm-apple. + config PWM_ATMEL tristate "Atmel PWM support" depends on ARCH_AT91 || COMPILE_TEST diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index 7bf1a29f02b8..19899b912e00 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -2,6 +2,7 @@ obj-$(CONFIG_PWM) += core.o obj-$(CONFIG_PWM_SYSFS) += sysfs.o obj-$(CONFIG_PWM_AB8500) += pwm-ab8500.o +obj-$(CONFIG_PWM_APPLE) += pwm-apple.o obj-$(CONFIG_PWM_ATMEL) += pwm-atmel.o obj-$(CONFIG_PWM_ATMEL_HLCDC_PWM) += pwm-atmel-hlcdc.o obj-$(CONFIG_PWM_ATMEL_TCB) += pwm-atmel-tcb.o diff --git a/drivers/pwm/pwm-apple.c b/drivers/pwm/pwm-apple.c new file mode 100644 index 000000000000..09048b02b2f5 --- /dev/null +++ b/drivers/pwm/pwm-apple.c @@ -0,0 +1,154 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* + * Driver for the Apple SoC PWM controller + * + * Copyright The Asahi Linux Contributors + * + * Limitations: + * - The writes to cycle registers are shadowed until a write to + * the control register. + * - If both OFF_CYCLES and ON_CYCLES are set to 0, the output + * is a constant off signal. + */ + +#include +#include +#include +#include +#include +#include + +#define APPLE_PWM_CTRL 0x00 +#define APPLE_PWM_ON_CYCLES 0x1c +#define APPLE_PWM_OFF_CYCLES 0x18 + +#define APPLE_CTRL_ENABLE BIT(0) +#define APPLE_CTRL_MODE BIT(2) +#define APPLE_CTRL_UPDATE BIT(5) +#define APPLE_CTRL_TRIGGER BIT(9) +#define APPLE_CTRL_INVERT BIT(10) +#define APPLE_CTRL_OUTPUT_ENABLE BIT(14) + +struct apple_pwm { + struct pwm_chip chip; + void __iomem *base; + u64 clkrate; +}; + +static inline struct apple_pwm *to_apple_pwm(struct pwm_chip *chip) +{ + return container_of(chip, struct apple_pwm, chip); +} + +static int apple_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct apple_pwm *fpwm; + + if (state->polarity == PWM_POLARITY_INVERSED) + return -EINVAL; + + fpwm = to_apple_pwm(chip); + if (state->enabled) { + u64 on_cycles, off_cycles; + + on_cycles = mul_u64_u64_div_u64(fpwm->clkrate, + state->duty_cycle, NSEC_PER_SEC); + if (on_cycles > 0xFFFFFFFF) + return -ERANGE; + + off_cycles = mul_u64_u64_div_u64(fpwm->clkrate, + state->period, NSEC_PER_SEC) - on_cycles; + if (off_cycles > 0xFFFFFFFF) + return -ERANGE; + + writel(on_cycles, fpwm->base + APPLE_PWM_ON_CYCLES); + writel(off_cycles, fpwm->base + APPLE_PWM_OFF_CYCLES); + writel(APPLE_CTRL_ENABLE | APPLE_CTRL_OUTPUT_ENABLE | APPLE_CTRL_UPDATE, + fpwm->base + APPLE_PWM_CTRL); + } else { + writel(0, fpwm->base + APPLE_PWM_CTRL); + } + return 0; +} + +static void apple_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, + struct pwm_state *state) +{ + struct apple_pwm *fpwm; + u32 on_cycles, off_cycles, ctrl; + + fpwm = to_apple_pwm(chip); + + ctrl = readl(fpwm->base + APPLE_PWM_CTRL); + on_cycles = readl(fpwm->base + APPLE_PWM_ON_CYCLES); + off_cycles = readl(fpwm->base + APPLE_PWM_OFF_CYCLES); + + state->enabled = (ctrl & APPLE_CTRL_ENABLE) && (ctrl & APPLE_CTRL_OUTPUT_ENABLE); + state->polarity = PWM_POLARITY_NORMAL; + // on_cycles + off_cycles is 33 bits, NSEC_PER_SEC is 30, there is no overflow + state->duty_cycle = DIV64_U64_ROUND_UP((u64)on_cycles * NSEC_PER_SEC, fpwm->clkrate); + state->period = DIV64_U64_ROUND_UP(((u64)off_cycles + (u64)on_cycles) * + NSEC_PER_SEC, fpwm->clkrate); +} + +static const struct pwm_ops apple_pwm_ops = { + .apply = apple_pwm_apply, + .get_state = apple_pwm_get_state, + .owner = THIS_MODULE, +}; + +static int apple_pwm_probe(struct platform_device *pdev) +{ + struct apple_pwm *fpwm; + struct clk *clk; + int ret; + + fpwm = devm_kzalloc(&pdev->dev, sizeof(*fpwm), GFP_KERNEL); + if (!fpwm) + return -ENOMEM; + + fpwm->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(fpwm->base)) + return dev_err_probe(&pdev->dev, PTR_ERR(fpwm->base), "unable to map mmio"); + + clk = devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), "unable to get the clock"); + + /* + * uses the 24MHz system clock on all existing devices, can only + * happen if the device tree is broken + */ + fpwm->clkrate = clk_get_rate(clk); + if (fpwm->clkrate > NSEC_PER_SEC) + return dev_err_probe(&pdev->dev, -EINVAL, "pwm clock out of range"); + + fpwm->chip.dev = &pdev->dev; + fpwm->chip.npwm = 1; + fpwm->chip.ops = &apple_pwm_ops; + + ret = devm_pwmchip_add(&pdev->dev, &fpwm->chip); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "unable to add pwm chip"); + + return 0; +} + +static const struct of_device_id apple_pwm_of_match[] = { + { .compatible = "apple,s5l-fpwm" }, + {} +}; +MODULE_DEVICE_TABLE(of, apple_pwm_of_match); + +static struct platform_driver apple_pwm_driver = { + .probe = apple_pwm_probe, + .driver = { + .name = "apple-pwm", + .of_match_table = apple_pwm_of_match, + }, +}; +module_platform_driver(apple_pwm_driver); + +MODULE_DESCRIPTION("Apple SoC PWM driver"); +MODULE_LICENSE("Dual MIT/GPL"); From patchwork Wed Dec 21 21:06:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Finkelstein X-Patchwork-Id: 13079183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEE77C4332F for ; Wed, 21 Dec 2022 21:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AIuoHQPYCiR+rU4Zi8YTr31iq3P4XgBuPzL8DY9OBS8=; b=oUQhamosc2Vgc2 ukjJ23364eR6hjKQgW+DWuH7mvKLDQqtgeHqGBZk+NFHXhbNz6s7zuQ5fVwRNH32fiHD1QuQMIPz9 hkRGCvjFlZnXIiQsbpdfXOps3VsLjNjLgQV232WqM6lwFq2BUgJt2h/fhZAB+/aZk993epZ/Gl6pF 5YmNhwbTkpxA8/cbb7hRRp0fmeLVW8nN6OFMTsqMVX97PyP2mmocry3arFeJNDNarteChFT+LxE+r JKspqv3Cr/CBQAiCu9QczoiMBtyNUFj9UZoM0aQ25sS2PiJINF4riVVwp8Gvt0LmrJFdExf65/ZNg GUCxLE7S8YokDG5s3T3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86ct-002kiT-G5; Wed, 21 Dec 2022 21:27:49 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86Iy-002Yjc-7U for linux-arm-kernel@lists.infradead.org; Wed, 21 Dec 2022 21:07:13 +0000 Received: by mail-wm1-x32c.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso2354218wmp.3 for ; Wed, 21 Dec 2022 13:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5nrHW2nZPS02ZWv3aQJK/QCBWF5IiEBszwRBGZwror8=; b=gnICfvvqTzoxFV9J6OhD0dfy1GMLDNmK/+HGPTgNy7dKVlH4BJtcjnaMWCj0kUHjSb PuUR6Pw/5E0+NzyemYIlh07NYT/DIYBozIoFTNM05Nh5VemjtWNf5stVx/bLlH5yNyQB IjFEW8elV7s6xC9lVWDg8fdLI7MrHrzvdqhxpdjlA7hpSrcn+Q+4JWL35hroS0mR3ZfB b7i4ashBFei/Wf4nHej2MssKZof6oEi/VbgD0AUQUDigRaq5AJoisgNqzDYp3OzbiPuc 48v2tGY8toKeT68Cbg2DGBjecM50txuHjcj3/tkcLvYZTeN73lHQVV4uBAZRK48LKiCr ADXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nrHW2nZPS02ZWv3aQJK/QCBWF5IiEBszwRBGZwror8=; b=BxpLiBSw0/L84K5P2BXDsdu+s4AkyErx0hPT1aPojNzbz06eZLWzPNOznxHh2a0WDx 3r8dluZxtqee+gt7bGHWBo7JLLtFOgAr6YIkT5g8Lxe+3N1SktLQd6VTuS6KcSatdElu Cb+6UObmTA+8eDIse/AIVFDC3MrgzaHi0FrTkVat49rxfJt1qJG2vz1u645iptkDuR5A PDEpTtItna1Ky7nwdBSv0iIRIEF7vCpnBKInz4rcwYVQ3xM1Mfyx3YzVImwViN3SrLj7 qsfkN7+2oomhQm8/vyi1p3xZmj8IWV4hI/R2oon/Zfv9EXieYNS/28vu61n3dqpW0Jv0 irkg== X-Gm-Message-State: AFqh2kpFnQ+I2sofcmycJDjisaH9fquhpXIph4zkfB2IHHFkU755MpTO dF4joucXA8EqX9++IJH1TPw= X-Google-Smtp-Source: AMrXdXsWqORR30ZKUUcvgUiVkQFjXes2NPsOYf28UCYRbqgLunfHxhURs5+D2N0hCE/rzH4p3p7CTA== X-Received: by 2002:a05:600c:3b9d:b0:3d2:3e75:7bb9 with SMTP id n29-20020a05600c3b9d00b003d23e757bb9mr2358068wms.34.1671656829455; Wed, 21 Dec 2022 13:07:09 -0800 (PST) Received: from localhost ([176.234.10.188]) by smtp.gmail.com with UTF8SMTPSA id a1-20020a05600c348100b003b47b80cec3sm3412423wmq.42.2022.12.21.13.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 13:07:09 -0800 (PST) From: Sasha Finkelstein To: u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein Subject: [PATCH v5 3/4] arm64: dts: apple: t8103: Add PWM controller Date: Thu, 22 Dec 2022 00:06:47 +0300 Message-Id: <20221221210648.2735-4-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20221221210648.2735-1-fnkl.kernel@gmail.com> References: <20221221210648.2735-1-fnkl.kernel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_130712_363299_0744F213 X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Adds PWM controller and keyboard backlight bindings for M1 MacBooks Signed-off-by: Sasha Finkelstein Acked-by: Sven Peter --- arch/arm64/boot/dts/apple/t8103-j293.dts | 19 +++++++++++++++++++ arch/arm64/boot/dts/apple/t8103-j313.dts | 19 +++++++++++++++++++ arch/arm64/boot/dts/apple/t8103.dtsi | 9 +++++++++ 3 files changed, 47 insertions(+) diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts index ecb10d237a05..43f79570b458 100644 --- a/arch/arm64/boot/dts/apple/t8103-j293.dts +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts @@ -11,6 +11,7 @@ #include "t8103.dtsi" #include "t8103-jxxx.dtsi" +#include / { compatible = "apple,j293", "apple,t8103", "apple,arm-platform"; @@ -43,3 +44,21 @@ &i2c2 { &i2c4 { status = "okay"; }; + +/ { + led-controller { + compatible = "pwm-leds"; + led-0 { + pwms = <&fpwm1 0 40000>; + label = "kbd_backlight"; + function = LED_FUNCTION_KBD_BACKLIGHT; + color = ; + max-brightness = <255>; + default-state = "keep"; + }; + }; +}; + +&fpwm1 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/apple/t8103-j313.dts b/arch/arm64/boot/dts/apple/t8103-j313.dts index df741737b8e6..57e75e6ddf63 100644 --- a/arch/arm64/boot/dts/apple/t8103-j313.dts +++ b/arch/arm64/boot/dts/apple/t8103-j313.dts @@ -11,6 +11,7 @@ #include "t8103.dtsi" #include "t8103-jxxx.dtsi" +#include / { compatible = "apple,j313", "apple,t8103", "apple,arm-platform"; @@ -35,3 +36,21 @@ &pcie0_dart_2 { /delete-node/ &port01; /delete-node/ &port02; + +/ { + led-controller { + compatible = "pwm-leds"; + led-0 { + pwms = <&fpwm1 0 40000>; + label = "kbd_backlight"; + function = LED_FUNCTION_KBD_BACKLIGHT; + color = ; + max-brightness = <255>; + default-state = "keep"; + }; + }; +}; + +&fpwm1 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi index 51a63b29d404..ccdb26ef6b22 100644 --- a/arch/arm64/boot/dts/apple/t8103.dtsi +++ b/arch/arm64/boot/dts/apple/t8103.dtsi @@ -191,6 +191,15 @@ i2c4: i2c@235020000 { status = "disabled"; /* only used in J293 */ }; + fpwm1: pwm@235044000 { + compatible = "apple,t8103-fpwm", "apple,s5l-fpwm"; + reg = <0x2 0x35044000 0x0 0x4000>; + power-domains = <&ps_fpwm1>; + clocks = <&clkref>; + #pwm-cells = <2>; + status = "disabled"; + }; + serial0: serial@235200000 { compatible = "apple,s5l-uart"; reg = <0x2 0x35200000 0x0 0x1000>; From patchwork Wed Dec 21 21:06:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Finkelstein X-Patchwork-Id: 13079185 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22C62C4332F for ; Wed, 21 Dec 2022 21:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vsM7dnGu5SM/5jbheAw/0gQeAvCueJdckW5zLZdIYjI=; b=vW2nl4+uHlUZlQ YDiel0Oz2GGiC1x7A6DAJa2HSVgq+qExqYTzMQujRkXCvrgc4UQOiYiuGNy9hKXftJLEX3AJN9Qg3 CU9RjRGWC9yPPirUIMqZQlOuef0JgbxJiewbxkNeqn/ky1VtbYoaU84OF9RCV1QKVwzlyRVn2xaji pucQwZfQO8xCiPqJxQce9UouNRbqp5s3HH1F4RCEbZgXFsISrdhL0GlHexsDVpfayQMIvhCQl9kvo K6h6pia3z1nynIj9PYLHndCi/lhF4g6jvWTfqzd/YBR2Q0XUSyV2kdIX/20kPmQR1wRoeGK4YCKve NNqsBV7x4ldLG34hPPBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86f6-002lkk-1s; Wed, 21 Dec 2022 21:30:05 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p86J3-002Yn0-0i for linux-arm-kernel@lists.infradead.org; Wed, 21 Dec 2022 21:07:18 +0000 Received: by mail-wm1-x334.google.com with SMTP id r126-20020a1c4484000000b003d6b8e8e07fso2288008wma.0 for ; Wed, 21 Dec 2022 13:07:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lVXE/tLR92m2sGWA4Ap2iyUSciCN0CAi8jf/sNy+hqY=; b=J45PmuQV/HLwZbSRa1zjfv/tsrzWpuonlqZd6yTp1A6jaZbjVPWCZaZyTqYveMq9q6 264D8JUg9gWkj+4GOjbq1x1wf5vhTjg3Bda9/RFAqyqh6YuA5hVG0vQv5Qdcf+Z/CA/b Qrq+qb2hYkgBCKmGnrWWK2wBqCOzkJAZ3M53R0I4abbQXs3CxH9o+PdQXpuS/5rYyGeH moF9ehwTKu/HeN84sg+yA4VEy8SyhYJEp5909w3wSb/3ZI7p6RnK+Y2ZDbLHq8Ojlwzm WCBTheS1nGU9FTTxS1uMeP42pkjFNxvK2lkUJjInGvxJuOL0+K7V5HZYAzlUGEnf4iPT BMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lVXE/tLR92m2sGWA4Ap2iyUSciCN0CAi8jf/sNy+hqY=; b=IfsLtpwDCdIiyT+KhFgAGRhdrVQK57Fik1myKRBnmMwtkd6/F3umpBoEH/TWibBaZh V7+6/I4hsBQZUuum/cKkRhA/NqMKxbwQH94TGP8/BTezMr6SHJLe4iN46mi/m9O4pqNr ZLWzunwGFApctMjq3t9osEdkg4rCXBa8OnUhjepg1DI9rvN5jk6bJqZDUZPQmtesP4WB 0PdXf92I638r6+Jj5BEMjN2Uh+gM1T6WUhvy8lkyELNj+Nq7CCtHIHI/Gb/SCcv5Jf+C 2oP4TX2LSymPgsUXMkPsiCZyFqE5lbf60RbM+IG0taT6aOZHz+tW+ZcRDgmFP5iEfFQZ nRuw== X-Gm-Message-State: AFqh2kouiBf49zCqBZXLeSGkJDn9jUPCkLdI4zIiVy+sSWjDsVAiYoju J5rkY53RWmja7wf2bUdY7aA= X-Google-Smtp-Source: AMrXdXvfbPVNSKTMpgu1wbKyL0z1Y/4/DV/Eb7PMOIvGuhk7PEFn9XlRuloouZwAEemucsMt6AaFMw== X-Received: by 2002:a7b:c3c6:0:b0:3d2:3376:6f37 with SMTP id t6-20020a7bc3c6000000b003d233766f37mr2633965wmj.10.1671656833130; Wed, 21 Dec 2022 13:07:13 -0800 (PST) Received: from localhost ([176.234.10.188]) by smtp.gmail.com with UTF8SMTPSA id r9-20020a05600c35c900b003d6b71c0c92sm4911025wmq.45.2022.12.21.13.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 13:07:12 -0800 (PST) From: Sasha Finkelstein To: u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Finkelstein Subject: [PATCH v5 4/4] MAINTAINERS: Add entries for Apple PWM driver Date: Thu, 22 Dec 2022 00:06:48 +0300 Message-Id: <20221221210648.2735-5-fnkl.kernel@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20221221210648.2735-1-fnkl.kernel@gmail.com> References: <20221221210648.2735-1-fnkl.kernel@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_130717_147888_27321519 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the MAINTAINERS entries for the driver Signed-off-by: Sasha Finkelstein Acked-by: Sven Peter --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 886d3f69ee64..cf773aa53210 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1908,6 +1908,7 @@ F: Documentation/devicetree/bindings/nvmem/apple,efuses.yaml F: Documentation/devicetree/bindings/pci/apple,pcie.yaml F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml F: Documentation/devicetree/bindings/power/apple* +F: Documentation/devicetree/bindings/pwm/pwm-apple.yaml F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml F: arch/arm64/boot/dts/apple/ F: drivers/clk/clk-apple-nco.c @@ -1921,6 +1922,7 @@ F: drivers/mailbox/apple-mailbox.c F: drivers/nvme/host/apple.c F: drivers/nvmem/apple-efuses.c F: drivers/pinctrl/pinctrl-apple-gpio.c +F: drivers/pwm/pwm-apple.c F: drivers/soc/apple/* F: drivers/watchdog/apple_wdt.c F: include/dt-bindings/interrupt-controller/apple-aic.h