From patchwork Mon Dec 26 09:48:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13081754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93F8C4167B for ; Mon, 26 Dec 2022 09:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbiLZJs1 (ORCPT ); Mon, 26 Dec 2022 04:48:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiLZJs0 (ORCPT ); Mon, 26 Dec 2022 04:48:26 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7471B3 for ; Mon, 26 Dec 2022 01:48:23 -0800 (PST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NgXxm0YrKz16Lpf; Mon, 26 Dec 2022 17:47:08 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 26 Dec 2022 17:48:21 +0800 From: Gaosheng Cui To: , , , , , , CC: , Subject: [PATCH -next] media: staging: stkwebcam: Fix the build error with stkwebcam Date: Mon, 26 Dec 2022 17:48:20 +0800 Message-ID: <20221226094820.1157244-1-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.244.148.83] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org When I am building the kernel on arm64, set config CONFIG_USB=m && CONFIG_VIDEO_STKWEBCAM=y, I get some error reports as follows: drivers/staging/media/deprecated/stkwebcam/stk-webcam.o: In function `stk_v4l_dev_release': stk-webcam.c:(.text+0x3e0): undefined reference to `usb_put_intf' stk-webcam.c:(.text+0x3e8): undefined reference to `usb_put_dev' drivers/staging/media/deprecated/stkwebcam/stk-webcam.o: In function `stk_clean_iso': stk-webcam.c:(.text+0xb0c): undefined reference to `usb_kill_urb' stk-webcam.c:(.text+0xb14): undefined reference to `usb_free_urb' Fix it by add dependency option on USB for VIDEO_STKWEBCAM. Signed-off-by: Gaosheng Cui --- drivers/staging/media/deprecated/stkwebcam/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/deprecated/stkwebcam/Kconfig b/drivers/staging/media/deprecated/stkwebcam/Kconfig index 7234498e634a..083fadab232d 100644 --- a/drivers/staging/media/deprecated/stkwebcam/Kconfig +++ b/drivers/staging/media/deprecated/stkwebcam/Kconfig @@ -2,7 +2,7 @@ config VIDEO_STKWEBCAM tristate "USB Syntek DC1125 Camera support (DEPRECATED)" depends on VIDEO_DEV - depends on MEDIA_USB_SUPPORT && MEDIA_CAMERA_SUPPORT + depends on USB && MEDIA_USB_SUPPORT && MEDIA_CAMERA_SUPPORT help Say Y here if you want to use this type of camera. Supported devices are typically found in some Asus laptops,