From patchwork Fri Dec 30 00:14:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Frayer X-Patchwork-Id: 13083961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F38BC3DA79 for ; Fri, 30 Dec 2022 00:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jjHZRX6WLVeSISOIev/jKHC8n+rD2SpGT8ProQGCvNI=; b=zygOpPueTTZOYT GptJtXecqL2ocQGOVX29lbkDrzI/32tirHXwci2T01QiTM9RfehbUtxcFY5PiKQ7oEzQw5Au+DEsZ 65bWyQ4TCwu5u3ZHEiHmnwO+fiHUXQB96oUas/1JHaiH2XYTHmVDKcoz+dyEKblSKmSTeKPB117vi Hqr0g1eY2Fzxh7/wNcTXcdn4tlsNtTLGZqaH1SzBnzVVEGSxHQEdAXdEU/5+xsJdKmEB7MFqbilWS fl3b7q6CrQYFdTsMh7kzz+gfFaDW2QRx4NFRRFaY1FEk2AcpbT9tpEmgR3bpy+NbHNS6BGCdH1Icv Uckh2I6Biy2QP4jSoysA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB37G-003Wuk-Jk; Fri, 30 Dec 2022 00:19:19 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB32P-003V0I-2e for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 00:14:19 +0000 Received: by mail-wm1-x32b.google.com with SMTP id z8-20020a05600c220800b003d33b0bda11so12101585wml.0 for ; Thu, 29 Dec 2022 16:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CyWkmbfdqtlGY0rwiPi83ReuiFdfPg46opu9XRadU/A=; b=fx1KlIHvSJVrk+xOsmnVPA/zQYrSCik2VK7jM1MLNetCvtb0PMBJoxnN4K7WaEPHYm RmQtIPkhbP7znLcHv+Bx1P3+eLQferowU5K4tmabYE92hVnI6h+JreQYRA1dfMDxa9/V ynPmjtCetnrzNAult8OuvHXEyb4Mj61P+dH59JHTDhSt1M10Jto5VFxbVpBelOqy+zEC tmevg7STdGd7H8YP7rsvw1PPiXhm3LWy2CQ572VvDffZdUbs2/qwqpkO0N0m3/OjfbL4 OjZcH8UApH52C35bV8W2kMnL43QqL3DtIX05vNjvJpELrCRuX6Ba0c0GxfO+12HWk8i2 m6cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CyWkmbfdqtlGY0rwiPi83ReuiFdfPg46opu9XRadU/A=; b=Fu0u0BKP7r6/0UJRSlS4JNFAUiENyinTEnt8zFk+tUXzWxsDwT5b6cCNX0HOq9kIw1 n80oWSeMIf5w3pL/IsOHsc7Xc54VX3uumuUJ8Hr1EMuXOC1Cn699fIpa2LR5CAJ9zAvk tofs+MvG1QXDxdMxNbOvDvAY2gmkUBzxHLEIxcqbAcDeKxEo/bZRfU8RkYlXfjTj3Mz9 iAL3PWlJe7oNjJdB4KMAt7grlz0NpezE1LXHKDaKRmR5nu/2vAk8ID832tdE6B0xKo90 RyhQ1UcLNKuhc1/7bLi3RZDvycz1/wgZcUkbKrvQ/2HcaWVbNYeZ/z3mZ9erG+Dia770 IW6Q== X-Gm-Message-State: AFqh2krtvfG8qtX71j1rz5widFN2UlE6FNFRwLgNGSNu4HeF16p+1dXL Uptw+TFckwtKQ0VnjE/d+8WSx3PMfmi6BM+j X-Google-Smtp-Source: AMrXdXsCR9WaEyXWhmaMjZSkWwIeN8p6D0UlvvOz5lUl68Pm6PMfgdeoCO0yZz/NixYos/Vf5qDnpA== X-Received: by 2002:a05:600c:a10:b0:3d2:2904:dfe9 with SMTP id z16-20020a05600c0a1000b003d22904dfe9mr24824442wmp.21.1672359252962; Thu, 29 Dec 2022 16:14:12 -0800 (PST) Received: from nicolas-Precision-3551.home ([2001:861:5180:dcc0:a1a7:f1c1:a2d2:514c]) by smtp.gmail.com with ESMTPSA id o8-20020a05600c4fc800b003d99a39b846sm5072994wmq.5.2022.12.29.16.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 16:14:12 -0800 (PST) From: Nicolas Frayer To: peter.ujfalusi@gmail.com, nm@ti.com, ssantosh@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, grygorii.strashko@ti.com, khilman@baylibre.com, glaroque@baylibre.com, mkorpershoek@baylibre.com, nfrayer@baylibre.com Subject: [PATCH v2] soc: ti: k3-ringacc: Add try_module_get() to k3_dmaring_request_dual_ring() Date: Fri, 30 Dec 2022 01:14:04 +0100 Message-Id: <20221230001404.10902-1-nfrayer@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_161417_177315_4445F45C X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the k3 ring accelerator driver has been modified to add module build support, try_module_get() and module_put() have been added to update the module refcnt. One code path has not been updated and it has introduced an issue where the refcnt is decremented by module_put() in k3_ringacc_ring_free() without being incremented previously. Adding try_module_get() to k3_dmaring_request_dual_ring() ensures the refcnt is kept up to date. Fixes: c07f216a8b72 ("soc: ti: k3-ringacc: Allow the driver to be built as module") Signed-off-by: Nicolas Frayer Reviewed-by: Peter Ujfalusi --- v1->v2: Added the Fixes and Reviewed-by tags drivers/soc/ti/k3-ringacc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c index e01e4d815230a..8f131368a7586 100644 --- a/drivers/soc/ti/k3-ringacc.c +++ b/drivers/soc/ti/k3-ringacc.c @@ -406,6 +406,11 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id, mutex_lock(&ringacc->req_lock); + if (!try_module_get(ringacc->dev->driver->owner)) { + ret = -EINVAL; + goto err_module_get; + } + if (test_bit(fwd_id, ringacc->rings_inuse)) { ret = -EBUSY; goto error; @@ -421,6 +426,8 @@ static int k3_dmaring_request_dual_ring(struct k3_ringacc *ringacc, int fwd_id, return 0; error: + module_put(ringacc->dev->driver->owner); +err_module_get: mutex_unlock(&ringacc->req_lock); return ret; }