From patchwork Mon Jan 2 08:28:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 13086571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A81DC4167B for ; Mon, 2 Jan 2023 08:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MUK/Q3hOO10MzYPQU1POIH4ibvGIo8V+WJqJsEs1D+E=; b=HuK/uCGKQDJ/XL E6CGFao2iIhz2i+4jVUM1xDEEnoT5GNO0pxt6ViNjIoTI8zoSfKDQuItXcsbiIzDmCAc0IiEyeP6H Oce7vnm/rVMCe2se5nx5JWo62CupXjD7dJekEp7/ZIMseF64cM+aep6RbreD1tk1IR7rw2WGClXRt +Ma16ZcJZhTffSQbXEOsiNz252pfK2ICLAPWZjLldmQB4EpQ01aKOc9lznbkKSg1+jEgrGTHDeqlX cStM3J83N3NoqMXHYFTN1LO6ELzEf2fbAXzf2hgpAyQaTGfT5s9StM6l9v9e/WIdBmqjBFsMImpUh JMXKsES/+6su2eY8sR7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCGCC-009PkY-Ve; Mon, 02 Jan 2023 08:29:25 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCGBH-009PTP-CF for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 08:28:29 +0000 Received: by mail-pj1-x1031.google.com with SMTP id j8-20020a17090a3e0800b00225fdd5007fso18030407pjc.2 for ; Mon, 02 Jan 2023 00:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tWYzTA7raDtUxD/VqUrbyJ284rX1lgj8dyWdOkvF1/E=; b=NYz9nZkWD8n7Y+KSMqiNTxN+6FhHH3GXtAGRsxrjjih7ndCEXFdM0rMvMEySOwDxA+ xLqAKs8/8C+3uIu3WtNB+TCcHonmimcA2f/gaJAfiM/o+UQJqULcllRH2j5x6uzkHuE+ zi9stt2ateVWUyHyovEc8o+r6aK+n9fO8Gtui/6sTy97uwfctvBGAeiySoOVgtzFrZ7r UXbZWKKKQc8nm/FjDKa3hwczLw3X6cthv3U1qN1VeNoRyVc4g7U7ivYqFWYec66nYCPm oqEmqO6U2QYkouRMyzxijwLYxDbjTxWITCxbmd3eE4kXcyeQEbDNR3K9TonsB4XLjABS k8jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tWYzTA7raDtUxD/VqUrbyJ284rX1lgj8dyWdOkvF1/E=; b=tZaeungkSsBDdLP+mjEdp5XmmLRYwD/A/krJJAVbBET13LkhQksqCHvDo2j6Yc5urb X54ZDmuUEPzFrynEfT3zwx734ohTtU4FjcSTj1SftrHoVdxn8erL5JIypxgCPoJa3YpD sVUgWm3i9erhusDHy4JMpVPVpdykDnXqKunvh1Z9pNWe5d/30jDtxfJSnB7lOgTe6HiY xcv9suYT0td28Oh5Npo9OGlfpBv7NKpOa9+rRFzDAedHrHumiSdFgq3S3rkRWCRJaoVA qOp03e80VKO39ny6qABDLGk8YeZ2zrW9ZY2bMAROrIVyWg4SkcENRp510qHzkkuqj/IG Flgw== X-Gm-Message-State: AFqh2kpT4esmdpERDmQGXG/CRctnleYHgPgak+TCHQDnHSkXIplJWloN i9lartxjzszbedabNVA5RaQ= X-Google-Smtp-Source: AMrXdXuCvB4Q/rCA0blb/+/pytP9qgF48OIE+yOs+ZahyOcj0vAEeerV/ZscDpOywoT65AXgLJwZjg== X-Received: by 2002:a05:6a20:13a6:b0:af:9c75:6699 with SMTP id w38-20020a056a2013a600b000af9c756699mr67051926pzh.1.1672648099525; Mon, 02 Jan 2023 00:28:19 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id q6-20020a655246000000b004468cb97c01sm16697724pgp.56.2023.01.02.00.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 00:28:18 -0800 (PST) From: Miaoqian Lin To: Tsahee Zidenberg , Antoine Tenart , Thomas Gleixner , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] irqchip/alpine-msi: Fix refcount leak in alpine_msix_init_domains Date: Mon, 2 Jan 2023 12:28:10 +0400 Message-Id: <20230102082811.3947760-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_002827_514976_C01BC731 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak. Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-alpine-msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index 5ddb8e578ac6..fc1ef7de3797 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -199,6 +199,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, } gic_domain = irq_find_host(gic_node); + of_node_put(gic_node); if (!gic_domain) { pr_err("Failed to find the GIC domain\n"); return -ENXIO;