From patchwork Wed Jan 4 09:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 13088343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79D0C4708E for ; Wed, 4 Jan 2023 09:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233638AbjADJUS (ORCPT ); Wed, 4 Jan 2023 04:20:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239073AbjADJTj (ORCPT ); Wed, 4 Jan 2023 04:19:39 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B25C21DDD6 for ; Wed, 4 Jan 2023 01:19:36 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id r18so21806236pgr.12 for ; Wed, 04 Jan 2023 01:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KIS8WxqeTpJ/Hb9V5wgA31o+L5mO3ZUQH0XmBEAll1Y=; b=UqwdSRMIhvS3VGWkfLRpPU5LOvLcyybpZ2u3QNbwiBoFK1yai5T2OFfGZ4ikwefeuu mvIPfUmt+Xtyiu8MwlxaYUhASFWfDCUBUmhGMY/KvznZE//fUogRdlW9WBV1Cb2n/1WL 3/CglqVin7v8VhMI8ZfrBIM8xJpE2K4Kq0mT/B1qhgU3pEnrpOQL3LloI1w8Zwf6Z4ua k2+cZy6o2fp2InqUFtzK62zWpusQ0E3wiwOE29pJMnNyJmPKbJsNc3Ol0+tejkazb6qW mK0RkSCZBRXi3UuRdPdQIhFnHxddNX7DmjjeEsmSn4e7ozqEbeI43Y3Ltq21I4Nybm6Q IdiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KIS8WxqeTpJ/Hb9V5wgA31o+L5mO3ZUQH0XmBEAll1Y=; b=36ujdoJxeZvGD4yc8X0kRab3m+Af9KDBMnUi8CotBPrzgwnX+SeQjdAziuMs9MBUY6 NX9M5iH8VYFAx8y8gSx5A0QIxuNmJiMv+77u38xMu0tffioOXfpYCoa/BF3pGC5kL99i XhALZJ28JHZzcFMQUoDiyRXoxX/neiHXdXiaalIKAcJ6mpJjOOfdBTD3KLvzAF+C/Qk0 //+0OZWc+mD/33QlKSXMw1tNVNQgl4d/xsakdyOC/9P2Pgx9lMsHuzo7wVylRFKgc73O Cad2lT9+p30AxxeWOA0Ba3SjCA9Esy7GFvXBsn63CDZgN8i93v6uBS9Uv8+sI07Ixr1x 3H0w== X-Gm-Message-State: AFqh2kp+VBh11tsKHF71HpHTxyXSd4WlfVcMMiAvYA20wVUex4I5TU+Q im3Ul3l+LPIspyzoFrGsEBlmAw== X-Google-Smtp-Source: AMrXdXulMYNKm6hmQhZqyEVnE5o8T6dZlXuPVisWXa5DTaSXYoyLuRhXkAFbFJ4CUDFKDhEHrV2E5g== X-Received: by 2002:aa7:804c:0:b0:576:cd93:2b06 with SMTP id y12-20020aa7804c000000b00576cd932b06mr43685798pfm.6.1672823976038; Wed, 04 Jan 2023 01:19:36 -0800 (PST) Received: from localhost.localdomain ([2401:4900:1c5e:e3b5:c341:16de:ce17:b857]) by smtp.gmail.com with ESMTPSA id b189-20020a621bc6000000b00580d877a50fsm19205877pfb.55.2023.01.04.01.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 01:19:35 -0800 (PST) From: Bhupesh Sharma To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_schowdhu@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, bhupesh.sharma@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: [PATCH 1/2] arm64: dts: qcom: sc7280: Fix EUD dt node syntax Date: Wed, 4 Jan 2023 14:49:21 +0530 Message-Id: <20230104091922.3959602-2-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230104091922.3959602-1-bhupesh.sharma@linaro.org> References: <20230104091922.3959602-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org As noted by Konrad while reviewing [1], fix the EUD and DWC3 node syntax in sc7280 dtsi file. While at it also fix the errors reported by '$ make dtbs_check' for the EUD node: arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: eud@88e0000: ports: 'oneOf' conditional failed, one must be fixed: 'port' is a required property '#address-cells' is a required property '#size-cells' is a required property From schema: Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml [1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org Signed-off-by: Bhupesh Sharma --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 32 +++++++++++++++++----------- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 0adf13399e649..f4c87059919e4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -623,6 +623,18 @@ cpu7_opp_3014mhz: opp-3014400000 { }; }; + eud_typec: connector { + compatible = "usb-c-connector"; + + ports { + port@0 { + con_eud: endpoint { + remote-endpoint = <&eud_con>; + }; + }; + }; + }; + memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the size */ @@ -3411,6 +3423,7 @@ usb_2_dwc3: usb@8c00000 { phy-names = "usb2-phy"; maximum-speed = "high-speed"; usb-role-switch; + port { usb2_role_switch: endpoint { remote-endpoint = <&eud_ep>; @@ -3585,17 +3598,23 @@ system-cache-controller@9200000 { }; eud: eud@88e0000 { - compatible = "qcom,sc7280-eud","qcom,eud"; + compatible = "qcom,sc7280-eud", "qcom,eud"; reg = <0 0x88e0000 0 0x2000>, <0 0x88e2000 0 0x1000>; interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>; + ports { + #address-cells = <1>; + #size-cells = <0>; port@0 { + reg = <0>; eud_ep: endpoint { remote-endpoint = <&usb2_role_switch>; }; }; + port@1 { + reg = <1>; eud_con: endpoint { remote-endpoint = <&con_eud>; }; @@ -3603,17 +3622,6 @@ eud_con: endpoint { }; }; - eud_typec: connector { - compatible = "usb-c-connector"; - ports { - port@0 { - con_eud: endpoint { - remote-endpoint = <&eud_con>; - }; - }; - }; - }; - nsp_noc: interconnect@a0c0000 { reg = <0 0x0a0c0000 0 0x10000>; compatible = "qcom,sc7280-nsp-noc"; From patchwork Wed Jan 4 09:19:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh Sharma X-Patchwork-Id: 13088344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A370C4708E for ; Wed, 4 Jan 2023 09:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234084AbjADJUU (ORCPT ); Wed, 4 Jan 2023 04:20:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239103AbjADJTo (ORCPT ); Wed, 4 Jan 2023 04:19:44 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B371DF26 for ; Wed, 4 Jan 2023 01:19:41 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id q9so4853287pgq.5 for ; Wed, 04 Jan 2023 01:19:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1G1WrgAhnt9agzGWzGIJSePzdmnF9/zsBwV6xg6YY9k=; b=GDMHYBKOUekAtt2zSWtFMLOxRt6vLRVca+p1PkQ43UOeFbWtp9iu9Pgl8CyZZeQ6zF bBC2d6U/LxMDZbcAUEs7gNw3UWXv+0QS9yMuYX/lyw1Q+3SyBUt2efkRM/sgHtwBLSe/ p/Udiqdg8rSIWWb6gE3nsgo3563qLqveqMcgeLhGES6/tnrAy8Y3x0U5PXKpxSsEeVZh Gp7boUotSrNCmprZmd2kSKbyH/swClOBkI88+aTNwfKhwY8ChGOyiZ33TJaHsE3G5MN2 OVkItu3AwPhelYioyWJkNn+wiQQtdRM4h0kbVAaTxPfcsmyamOkp5Z+ucm6Dn41L0Mmd qyIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1G1WrgAhnt9agzGWzGIJSePzdmnF9/zsBwV6xg6YY9k=; b=yTZXnSuYYhRv5zPvfE4vxS9SV8DHlLFgSM0rq2p7CWyPJvZs8ZYYOOaBhWcufefN5S Nerf2M9pXY+vtnUyOTYpDvBPtyCnF2SaWMBTsQkssdDPVypduFs6sCGjl4MiGMSWW/iz MIDerK1yvU6oV76bq79LprWVO9oaJd3fv1MyvNiOjFKD4JeyJwOSZlLiL3RKIVQ5A8ft X0AUPr6jH0Dd2v3WdVKi5eb9bExq/IzPZbHxvt9SXBFxi278KKx/sLG4ydr2e9IHK3wB /DcaeuCiJAgIFIX9LNiCCSBBdMphcowkGYHIQB0FuSCfprt21m7YKYCLQUcCioui9diw fJsQ== X-Gm-Message-State: AFqh2kpK+1bVeBF53BiS0snvsfcDGW3kQmhaTg32Waa1DgLAOpFK4TAr AYOMIfM2+1RuUUz5ozjXTQ04ew== X-Google-Smtp-Source: AMrXdXvejb3coMePWBqm+XvTYaavFEL8rS6Eyf2gm52JwXdwlhWV7YXTVzNtEIWYo1qtFRVSSwS5bw== X-Received: by 2002:a05:6a00:150c:b0:581:38df:f9f8 with SMTP id q12-20020a056a00150c00b0058138dff9f8mr39313914pfu.4.1672823980564; Wed, 04 Jan 2023 01:19:40 -0800 (PST) Received: from localhost.localdomain ([2401:4900:1c5e:e3b5:c341:16de:ce17:b857]) by smtp.gmail.com with ESMTPSA id b189-20020a621bc6000000b00580d877a50fsm19205877pfb.55.2023.01.04.01.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 01:19:39 -0800 (PST) From: Bhupesh Sharma To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_schowdhu@quicinc.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, bhupesh.sharma@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: [PATCH 2/2] dt-bindings: soc: qcom: eud: Fix identation issues in the example Date: Wed, 4 Jan 2023 14:49:22 +0530 Message-Id: <20230104091922.3959602-3-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230104091922.3959602-1-bhupesh.sharma@linaro.org> References: <20230104091922.3959602-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org As noted by Konrad while reviewing [1], the example node in the EUD yaml documentation has identation issues. So fix them. [1]. https://lore.kernel.org/linux-arm-msm/20221231131945.3286639-1-bhupesh.sharma@linaro.org Signed-off-by: Bhupesh Sharma --- Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml index c98aab209bc5d..385ebd7cbbf0c 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml @@ -55,9 +55,10 @@ additionalProperties: false examples: - | eud@88e0000 { - compatible = "qcom,sc7280-eud","qcom,eud"; - reg = <0x88e0000 0x2000>, - <0x88e2000 0x1000>; + compatible = "qcom,sc7280-eud", "qcom,eud"; + reg = <0 0x88e0000 0 0x2000>, + <0 0x88e2000 0 0x1000>; + ports { #address-cells = <1>; #size-cells = <0>; @@ -67,6 +68,7 @@ examples: remote-endpoint = <&usb2_role_switch>; }; }; + port@1 { reg = <1>; eud_con: endpoint {