From patchwork Sun Jan 8 13:04:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13092485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B22C53210 for ; Sun, 8 Jan 2023 13:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjAHNEs (ORCPT ); Sun, 8 Jan 2023 08:04:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbjAHNEr (ORCPT ); Sun, 8 Jan 2023 08:04:47 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FB65DF82; Sun, 8 Jan 2023 05:04:46 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id 18so8723468edw.7; Sun, 08 Jan 2023 05:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pbPYYWyqM3Km+MmO9M4MvtLvP8fuh3Tc+91cRMxFpfs=; b=f53LoH7fItXvtlkArddm8RAl+/EDorUMczf+yqZ6S9QjOmj6sniNIQQScBKu4uY2s5 FHzdgC95593j8Qy8tKdA+TMwfwtig+ynLe+43yXtcZS0wUmlRsVpr+3EpGmLf6CZ8/Ds SeAlPPdGatgLjFvVC+/nyndYffgd8Fyk/7/crQDXWawhHPHhaKmXmKq6ev0n4zLMObsb pLq8GHSCNOtRPxJ34PEWjtQUBkHcJhE8DsMUBBNmmKXwcQQxPHxrEadS/tZxoQEr9KMW LfIM8gj9dGDPKnumGiSG9ZW+dpwVIIe9iHqJxti/ofRz7mjLT19LTu8GOmnWj3Cp4uR9 /mpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pbPYYWyqM3Km+MmO9M4MvtLvP8fuh3Tc+91cRMxFpfs=; b=00H+QHUR3ljhXMC4Z8DhErOAD+x0j6mUfob/WekNj30qhzIm2YZJuQXLHw0FHMguUv gjwXW+4eYOQM67k2YtMKwioeC7t67tmQP6hP1QolAtgU5UIysp0XNqCii5Jevka3SRMl J0KoZDpBaJ9lRPF9pGEgDmyam+BvEdk4B9TGEpk7+Iw0ba1xMLvAI4l0CJsV5vBe48eh SgEOR3wcnu/563bh8FBHsgIJWkBK8Kdpa8Vg2hzzHwicIzup7FO5lbDf1ywCB3nINBpA r+16EHdzddqbaVhz5YI3IA7AmGPPqPKCghzzlZBWZWfUFIcv2k/zkKbneIUHW5ooXlT/ hzRw== X-Gm-Message-State: AFqh2krE9fsVcwaG3cC9qKOwAErSeEUo8l5iWjeGa3cUlQuf4e1vaP01 WUdWBJmgHA5Znywp29la9Vc= X-Google-Smtp-Source: AMrXdXuzq4+RB/jzO8hsBGSL8+tJxAHR09IDSwyHUvpD8zU0jmnaFUFz9kcQFLBYGLlk6W+2B+c3Yg== X-Received: by 2002:a05:6402:541a:b0:46c:6ed1:83b0 with SMTP id ev26-20020a056402541a00b0046c6ed183b0mr53791418edb.9.1673183084497; Sun, 08 Jan 2023 05:04:44 -0800 (PST) Received: from fedora.. (cpezg-94-253-128-11-cbl.xnet.hr. [94.253.128.11]) by smtp.googlemail.com with ESMTPSA id l10-20020aa7d94a000000b0048ebf8a5736sm2499285eds.21.2023.01.08.05.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 05:04:43 -0800 (PST) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Robert Marko Subject: [PATCH 1/2] clk: qcom: ipq8074: populate fw_name for usb3phy-s Date: Sun, 8 Jan 2023 14:04:39 +0100 Message-Id: <20230108130440.670181-1-robimarko@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Having only .name populated in parent_data for clocks which are only globally searchable currently will not work as the clk core won't copy that name if there is no .fw_name present as well. So, populate .fw_name for usb3phy clocks in parent_data as they were missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents"). Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data") Signed-off-by: Robert Marko Reviewed-by: Dmitry Baryshkov --- drivers/clk/qcom/gcc-ipq8074.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c index 8374cc40915a..888e8df7bc92 100644 --- a/drivers/clk/qcom/gcc-ipq8074.c +++ b/drivers/clk/qcom/gcc-ipq8074.c @@ -934,7 +934,7 @@ static struct clk_rcg2 usb0_mock_utmi_clk_src = { }; static const struct clk_parent_data gcc_usb3phy_0_cc_pipe_clk_xo[] = { - { .name = "usb3phy_0_cc_pipe_clk" }, + { .fw_name = "usb3phy_0_cc_pipe_clk", .name = "usb3phy_0_cc_pipe_clk" }, { .fw_name = "xo", .name = "xo" }, }; @@ -1002,7 +1002,7 @@ static struct clk_rcg2 usb1_mock_utmi_clk_src = { }; static const struct clk_parent_data gcc_usb3phy_1_cc_pipe_clk_xo[] = { - { .name = "usb3phy_1_cc_pipe_clk" }, + { .fw_name = "usb3phy_1_cc_pipe_clk", .name = "usb3phy_1_cc_pipe_clk" }, { .fw_name = "xo", .name = "xo" }, }; From patchwork Sun Jan 8 13:04:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13092486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CDDC61DB3 for ; Sun, 8 Jan 2023 13:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233233AbjAHNEt (ORCPT ); Sun, 8 Jan 2023 08:04:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232900AbjAHNEs (ORCPT ); Sun, 8 Jan 2023 08:04:48 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8633DF83; Sun, 8 Jan 2023 05:04:47 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id c17so8691350edj.13; Sun, 08 Jan 2023 05:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZSsCe1/vYrCPdq2/qm0aU0QWLaInEUASjxbLN6gEMCs=; b=LyJWVkmkVQDracXJJR1Fnzi4JLU/adPerzQZNgCGezlTDDfY33AgCdT+6EkACT2wI/ gI/6ciVPbG6LDcZvrK9EQwNkvV6SbzOKj3utJzad3cneej0JH7aHqB9gr4ghzZSNS49y y1ZMjiFHO7iiw14O0Go4NNvmJNxAjZBrtcVU020KlNsQGWmx9VELCzujvVjuxbpBmUN1 Hh73QCrZ1+4Hf+NHQn4pCUtcEAEEcS7SCUbkBZn87zPcluoOkFCT2URY3vkidBWTrPXu 0czzc3o/JVBCrfz9xfrSXJQaPEXwNRMhZ0PAaqr07QSWQZiobvF/CTaHSCQcq25rPQTU i8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZSsCe1/vYrCPdq2/qm0aU0QWLaInEUASjxbLN6gEMCs=; b=JAqH9Hr1B7AI3mC/goZPotGe/nSyKBGpvsehq3iQoiKQx1D74BhW1jRdVjq+jYMAPH x4FEZfYu51Kjs7SXw6ip2PhkWF1xa6r4Gjs5lmzerCVuF6ZgcweRQFnzemAc29ilEaWM 5rx/c/yTEZ/5sxYqC7aWESVIv/Ay9pJBOcFjgc78jUUNIsSfGRKrOe1Ke3mACaWZnfZs KsrJhIeprpDgJWiEzanYmGfXFsMLyhW5MWkKeEGf5p2aFiO9xiwOO4zhaLbnSh3ZDMA5 0VQ1DFXSOllk5z/7ZS5gJi+TZ03CJNfRE2inzDnmh1vcrB9TzbStmG59QZZnQ429gG3R O+EA== X-Gm-Message-State: AFqh2krQu16ajF7LGKjckR/NR436CyeWyFkkvLM7MtjHR2CPNSvWTKd4 mS8zLi9jlwbHwzwAjQhAK9uZh7VPve64Ow== X-Google-Smtp-Source: AMrXdXvIg7qVZS0BDw1oYpfXn7Aq8TDaG087Z9cth3zZXWQ1MOPSPsU0+XIGwVesdwYDFpsGYRZRvg== X-Received: by 2002:aa7:cd49:0:b0:497:d8ea:d79c with SMTP id v9-20020aa7cd49000000b00497d8ead79cmr5259999edw.27.1673183086239; Sun, 08 Jan 2023 05:04:46 -0800 (PST) Received: from fedora.. (cpezg-94-253-128-11-cbl.xnet.hr. [94.253.128.11]) by smtp.googlemail.com with ESMTPSA id l10-20020aa7d94a000000b0048ebf8a5736sm2499285eds.21.2023.01.08.05.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 05:04:45 -0800 (PST) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Robert Marko Subject: [PATCH 2/2] arm64: dts: qcom: ipq8074: correct USB3 QMP PHY-s clock output names Date: Sun, 8 Jan 2023 14:04:40 +0100 Message-Id: <20230108130440.670181-2-robimarko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230108130440.670181-1-robimarko@gmail.com> References: <20230108130440.670181-1-robimarko@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org It seems that clock-output-names for the USB3 QMP PHY-s where set without actually checking what is the GCC clock driver expecting, so clock core could never actually find the parents for usb0_pipe_clk_src and usb1_pipe_clk_src clocks in the GCC driver. So, correct the names to be what the driver expects so that parenting works. Before: gcc_usb0_pipe_clk_src 0 0 0 125000000 0 0 50000 Y gcc_usb1_pipe_clk_src 0 0 0 125000000 0 0 50000 Y After: usb3phy_0_cc_pipe_clk 1 1 0 125000000 0 0 50000 Y usb0_pipe_clk_src 1 1 0 125000000 0 0 50000 Y gcc_usb0_pipe_clk 1 1 0 125000000 0 0 50000 Y usb3phy_1_cc_pipe_clk 1 1 0 125000000 0 0 50000 Y usb1_pipe_clk_src 1 1 0 125000000 0 0 50000 Y gcc_usb1_pipe_clk 1 1 0 125000000 0 0 50000 Y Fixes: 5e09bc51d07b ("arm64: dts: ipq8074: enable USB support") Signed-off-by: Robert Marko Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index a0f7460020c2..3d1fccdf37c7 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -263,7 +263,7 @@ usb1_ssphy: phy@58200 { #clock-cells = <0>; clocks = <&gcc GCC_USB1_PIPE_CLK>; clock-names = "pipe0"; - clock-output-names = "gcc_usb1_pipe_clk_src"; + clock-output-names = "usb3phy_1_cc_pipe_clk"; }; }; @@ -306,7 +306,7 @@ usb0_ssphy: phy@78200 { #clock-cells = <0>; clocks = <&gcc GCC_USB0_PIPE_CLK>; clock-names = "pipe0"; - clock-output-names = "gcc_usb0_pipe_clk_src"; + clock-output-names = "usb3phy_0_cc_pipe_clk"; }; };