From patchwork Tue Jan 17 13:47:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 13104687 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32528C3DA78 for ; Tue, 17 Jan 2023 13:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbjAQNs2 (ORCPT ); Tue, 17 Jan 2023 08:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbjAQNr7 (ORCPT ); Tue, 17 Jan 2023 08:47:59 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 861633B3C0; Tue, 17 Jan 2023 05:47:55 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id z4-20020a17090a170400b00226d331390cso34120336pjd.5; Tue, 17 Jan 2023 05:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oLaPVpyO8fEFfx+PftWktnY3K5s7zHqLAXxofLOrVZM=; b=cDZSuJHo96k7zFrjzugnMFoMn6FgMcDq8/a/qgQyVnlI+y4N3bGCR2BdiWmwb6aRS+ WcC53Sj0ai4RzvZ1o7B6f8wernhBI3qMNNCVQnIF0AV4mlxmfJ4WOWi1H+6bMG8WY7Ft wPscLcODOJoHWiH12KUflGHe8i1rGw/NobDeRXz8xDr214MNrJUZ6kFaIX3VYFNS/jWg VkvfaN7/PuysHU2xYkkeskNQILTBcjdPd8mZ339mEk4wztWa5grciQHt1ykm6agQfB2w X40/zIsKAYek/CaqbiR3Q3shSgqgz2f3apO+gGn+ZmK3XUg57fJ9FHp8F+b7mbhOmZMZ hDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oLaPVpyO8fEFfx+PftWktnY3K5s7zHqLAXxofLOrVZM=; b=z+QCG3eT68grAdl4WwHnTiNsXH3qhUP/MR2lDyPKJ/TzqPlMbogm0ahTmDrHAcqVXb S7/w+50cDhwnoB3nSLX+nH245ZwnwuOZ25rg2b9tVMieKTy+XHO8Y51gtvO6SvbrAZv6 T13fmqBUbXtV8I5Lt0kT6xQSXeSo0txZjxhjS3HWDCYM4UsGAyVpob4t63XhA+qcBXsc nRQKp6l4JTxdNo0WmbvX6DLBtG58AbCRgtie0n2cOUlszg83hcjb2DubQHC11Aj/PhGi cE1hDKH2aFlvzGojGMQMibSQaQsGXF4HM2GroJLuCAPlUAelD5etw/6o5CnwjWL+al5n fPmg== X-Gm-Message-State: AFqh2kqIN47XUBNizGy5MiVqEtxyoy0SVUnAsAc4ezhNaymNxkPehA/2 kwGsD4pAqIHnmci/MTjXlAQ= X-Google-Smtp-Source: AMrXdXsidr5CNwwh1pPByydIB0f87THs0xmzqbnwFi5HFXbfm1OwHOpjG9wE2t2/30lwEhpziRnfHg== X-Received: by 2002:a05:6a20:428b:b0:a5:7700:2a4a with SMTP id o11-20020a056a20428b00b000a577002a4amr3369255pzj.51.1673963275058; Tue, 17 Jan 2023 05:47:55 -0800 (PST) Received: from localhost.localdomain (n220246252084.netvigator.com. [220.246.252.84]) by smtp.gmail.com with ESMTPSA id a3-20020a170902900300b00189393ab02csm3747958plp.99.2023.01.17.05.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 05:47:54 -0800 (PST) From: Jianhua Lu To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Jianhua Lu Subject: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight Date: Tue, 17 Jan 2023 21:47:41 +0800 Message-Id: <20230117134742.23238-1-lujianhua000@gmail.com> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes in v2: - Add missing staitc modifier to ktz8866_write function. Changes in v3: - Add 2022 to Copyright line. - Sort headers. - Remove meaningless comment. - Use definitions instead of hardcoding. - Add missing maintainer info. Changes in v4: - Change 2022 to 2023. - Remove useless macro and enum. - Describe settings by devicetree. - Move header file to C file. MAINTAINERS | 6 + drivers/video/backlight/Kconfig | 8 ++ drivers/video/backlight/Makefile | 1 + drivers/video/backlight/ktz8866.c | 195 ++++++++++++++++++++++++++++++ 4 files changed, 210 insertions(+) create mode 100644 drivers/video/backlight/ktz8866.c diff --git a/MAINTAINERS b/MAINTAINERS index 42fc47c6edfd..2084e74e1b58 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11674,6 +11674,12 @@ M: John Hawley S: Maintained F: tools/testing/ktest +KTZ8866 BACKLIGHT DRIVER +M: Jianhua Lu +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml +F: drivers/video/backlight/ktz8866.c + L3MDEV M: David Ahern L: netdev@vger.kernel.org diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 936ba1e4d35e..2845fd7e33ad 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -190,6 +190,14 @@ config BACKLIGHT_KTD253 which is a 1-wire GPIO-controlled backlight found in some mobile phones. +config BACKLIGHT_KTZ8866 + tristate "Backlight Driver for Kinetic KTZ8866" + depends on I2C + select REGMAP_I2C + help + Say Y to enabled the backlight driver for the Kinetic KTZ8866 + found in Xiaomi Mi Pad 5 series. + config BACKLIGHT_LM3533 tristate "Backlight Driver for LM3533" depends on MFD_LM3533 diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile index e815f3f1deff..f70a819c304c 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -36,6 +36,7 @@ obj-$(CONFIG_BACKLIGHT_HP680) += hp680_bl.o obj-$(CONFIG_BACKLIGHT_HP700) += jornada720_bl.o obj-$(CONFIG_BACKLIGHT_IPAQ_MICRO) += ipaq_micro_bl.o obj-$(CONFIG_BACKLIGHT_KTD253) += ktd253-backlight.o +obj-$(CONFIG_BACKLIGHT_KTZ8866) += ktz8866.o obj-$(CONFIG_BACKLIGHT_LM3533) += lm3533_bl.o obj-$(CONFIG_BACKLIGHT_LM3630A) += lm3630a_bl.o obj-$(CONFIG_BACKLIGHT_LM3639) += lm3639_bl.o diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c new file mode 100644 index 000000000000..98916f92d069 --- /dev/null +++ b/drivers/video/backlight/ktz8866.c @@ -0,0 +1,195 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Backlight driver for the Kinetic KTZ8866 + * + * Copyright (C) 2023 Jianhua Lu + */ + +#include +#include +#include +#include +#include +#include +#include + +#define DEFAULT_BRIGHTNESS 1500 +#define MAX_BRIGHTNESS 2047 +#define REG_MAX 0x15 + +/* reg */ +#define DEVICE_ID 0x01 +#define BL_CFG1 0x02 +#define BL_CFG2 0x03 +#define BL_BRT_LSB 0x04 +#define BL_BRT_MSB 0x05 +#define BL_EN 0x08 +#define LCD_BIAS_CFG1 0x09 +#define LCD_BIAS_CFG2 0x0A +#define LCD_BIAS_CFG3 0x0B +#define LCD_BOOST_CFG 0x0C +#define OUTP_CFG 0x0D +#define OUTN_CFG 0x0E +#define FLAG 0x0F +#define BL_OPTION1 0x10 +#define BL_OPTION2 0x11 +#define PWM2DIG_LSBs 0x12 +#define PWM2DIG_MSBs 0x13 +#define BL_DIMMING 0x14 +#define PWM_RAMP_TIME 0x15 + +/* definition */ +#define BL_EN_BIT BIT(6) +#define LCD_BIAS_EN 0x9F +#define PWM_HYST 0x5 + +struct ktz8866 { + struct i2c_client *client; + struct regmap *regmap; + bool led_on; +}; + +static const struct regmap_config ktz8866_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = REG_MAX, +}; + +static int ktz8866_write(struct ktz8866 *ktz, unsigned int reg, + unsigned int val) +{ + return regmap_write(ktz->regmap, reg, val); +} + +static int ktz8866_update_bits(struct ktz8866 *ktz, unsigned int reg, + unsigned int mask, unsigned int val) +{ + return regmap_update_bits(ktz->regmap, reg, mask, val); +} + +static int ktz8866_backlight_update_status(struct backlight_device *backlight_dev) +{ + struct ktz8866 *ktz = bl_get_data(backlight_dev); + unsigned int brightness = backlight_get_brightness(backlight_dev); + + if (!ktz->led_on && brightness > 0) { + ktz8866_update_bits(ktz, BL_EN, BL_EN_BIT, BL_EN_BIT); + ktz->led_on = true; + } else if (brightness == 0) { + ktz8866_update_bits(ktz, BL_EN, BL_EN_BIT, 0); + ktz->led_on = false; + msleep(10); + } + + /* Set brightness */ + ktz8866_write(ktz, BL_BRT_LSB, brightness & 0x7); + ktz8866_write(ktz, BL_BRT_MSB, (brightness >> 3) & 0xFF); + + return 0; +} + +static const struct backlight_ops ktz8866_backlight_ops = { + .options = BL_CORE_SUSPENDRESUME, + .update_status = ktz8866_backlight_update_status, +}; + +static void ktz8866_init(struct ktz8866 *ktz) +{ + unsigned int val; + + if(of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val)) + ktz8866_write(ktz, BL_EN, BIT(val) - 1); + else + /* Enable all 6 current sinks if the number of current sinks isn't specifed. */ + ktz8866_write(ktz, BL_EN, BIT(6) - 1); + + if(of_property_read_u32(ktz->client->dev.of_node, "current-ramping-time", &val)) + ktz8866_write(ktz, BL_CFG2, BIT(7) | (ilog2(val) << 3) | PWM_HYST); + + if(of_property_read_u32(ktz->client->dev.of_node, "led-ramping-time", &val)) { + unsigned int ramp_off_time = ilog2(val) + 1; + unsigned int ramp_on_time = ramp_off_time << 4; + ktz8866_write(ktz, BL_DIMMING, ramp_on_time | ramp_off_time); + } + + if(of_property_read_bool(ktz->client->dev.of_node, "enable-lcd-bias")) + ktz8866_write(ktz, LCD_BIAS_CFG1, LCD_BIAS_EN); +} + +static int ktz8866_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct backlight_device *backlight_dev; + struct backlight_properties props; + struct ktz8866 *ktz; + + ktz = devm_kzalloc(&client->dev, sizeof(*ktz), GFP_KERNEL); + if (!ktz) + return -ENOMEM; + + ktz->client = client; + ktz->regmap = devm_regmap_init_i2c(client, &ktz8866_regmap_config); + + if (IS_ERR(ktz->regmap)) { + dev_err(&client->dev, "failed to init regmap\n"); + return PTR_ERR(ktz->regmap); + } + + memset(&props, 0, sizeof(props)); + props.type = BACKLIGHT_RAW; + props.max_brightness = MAX_BRIGHTNESS; + props.brightness = DEFAULT_BRIGHTNESS; + + backlight_dev = devm_backlight_device_register( + &client->dev, "ktz8866-backlight", &client->dev, ktz, + &ktz8866_backlight_ops, &props); + + if (IS_ERR(backlight_dev)) { + dev_err(&client->dev, "failed to register backlight device\n"); + return PTR_ERR(backlight_dev); + } + + ktz8866_init(ktz); + + i2c_set_clientdata(client, backlight_dev); + backlight_update_status(backlight_dev); + + return 0; +} + +static void ktz8866_remove(struct i2c_client *client) +{ + struct backlight_device *backlight_dev = i2c_get_clientdata(client); + + backlight_dev->props.brightness = 0; + backlight_update_status(backlight_dev); +} + +static const struct i2c_device_id ktz8866_ids[] = { + { "ktz8866", 0 }, + {}, +}; +MODULE_DEVICE_TABLE(i2c, ktz8866_ids); + +static const struct of_device_id ktz8866_match_table[] = { + { + .compatible = "kinetic,ktz8866", + }, + {}, +}; + +static struct i2c_driver ktz8866_driver = { + .driver = { + .name = "ktz8866", + .of_match_table = ktz8866_match_table, + }, + .probe = ktz8866_probe, + .remove = ktz8866_remove, + .id_table = ktz8866_ids, +}; + +module_i2c_driver(ktz8866_driver); + +MODULE_DESCRIPTION("Kinetic KTZ8866 Backlight Driver"); +MODULE_AUTHOR("Jianhua Lu "); +MODULE_LICENSE("GPL"); From patchwork Tue Jan 17 13:47:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianhua Lu X-Patchwork-Id: 13104688 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FF0C678D7 for ; Tue, 17 Jan 2023 13:48:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbjAQNsa (ORCPT ); Tue, 17 Jan 2023 08:48:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbjAQNsD (ORCPT ); Tue, 17 Jan 2023 08:48:03 -0500 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40CE934C1F; Tue, 17 Jan 2023 05:48:02 -0800 (PST) Received: by mail-pj1-x102e.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso6239512pjg.2; Tue, 17 Jan 2023 05:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nsZvgpdsbOSZhJAZ1QAJPedjqfxUnjeKrZqaXm358r0=; b=Y0aqBtoOHjCVqYsvR98g7ZosHRR3wcidEggRSlAS73WqTuKhr0y1bCfXnTshMho+4c u4yJoh3kRcHoOAQlItFDcr9kQ733A4bCElXX9l7MPOo60dl5ZZknfZ/7ZFL+stS8Mb4y ZUxh3exectYTZre84JGIPrgKieU8WCd2AWzz9izq40ACJzf9KTs9cFdRt1E4obi8V2ib 7o1HhrqhYneJyNYoZy0ynyoAz20U/NHHqhzrYlcwWIc1dkS7eMQQKqYuD+EEUUz2a7wg ZMPATcxthLmkKPQHTPsCYeCZCAjv0ZeqzgswFWF5eSPP4IV1jQvEOFv6amj5Aj2AXWhO 6Obg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nsZvgpdsbOSZhJAZ1QAJPedjqfxUnjeKrZqaXm358r0=; b=kAs/XcscsmzouA/mzrscmH6VFB+Z7AUnYf1C5mVcseu9L5mUDW2FN0HGmzvhnDjuKa /z5nuMQASzic7Dd5CNMKNJJITja/zUW+o90FnYXu82chqZSQ917xyUvHOxPv/bQW522A 54SPBAtUd7+GkJxJS/yvKBWKZVKrdRYRJFyamXd8FzzDydVBFV5v8HbsymlcTz8Nqfd0 KyS44TODZ9zbDPqhpCQI9vJLs0nerBD/ruLd6K1k2eetZb56AgzTNnSllbtg0LsWqDEy a+aVSaVp1EhI89HUI+7kuT95SPokPohPG7rtwz4EMy7xPArGU6os22LiPFBJ4H94s3Tb nxCw== X-Gm-Message-State: AFqh2kqxRATeycY2ogcBTjzu+D2x0Hg2sDyCca7vnhA3J9GOz9WBS/WU bHk7HvhuD4QU/sGxPB4C2Dc= X-Google-Smtp-Source: AMrXdXu/zWBQUKC6ZNgX4gXkB2pdzeuGV+K0owx8758eOjlAQC+ZwRI1EVhNsBftFCuNwmBqxEowSA== X-Received: by 2002:a17:902:c10d:b0:191:3aad:cf33 with SMTP id 13-20020a170902c10d00b001913aadcf33mr4164697pli.55.1673963281835; Tue, 17 Jan 2023 05:48:01 -0800 (PST) Received: from localhost.localdomain (n220246252084.netvigator.com. [220.246.252.84]) by smtp.gmail.com with ESMTPSA id a3-20020a170902900300b00189393ab02csm3747958plp.99.2023.01.17.05.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 05:48:01 -0800 (PST) From: Jianhua Lu To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Helge Deller Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, Jianhua Lu Subject: [PATCH v4 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight Date: Tue, 17 Jan 2023 21:47:42 +0800 Message-Id: <20230117134742.23238-2-lujianhua000@gmail.com> X-Mailer: git-send-email 2.38.2 In-Reply-To: <20230117134742.23238-1-lujianhua000@gmail.com> References: <20230117134742.23238-1-lujianhua000@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3: - Add Krzysztof's R-b Changes in v4: - Drop Krzysztof's R-b - Add some new properties .../leds/backlight/kinetic,ktz8866.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml new file mode 100644 index 000000000000..18571d69accb --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Kinetic Technologies KTZ8866 backlight + +maintainers: + - Jianhua Lu + +description: | + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight + with dual lcd bias power. + https://www.kinet-ic.com/ktz8866/ + +allOf: + - $ref: common.yaml# + +properties: + compatible: + const: kinetic,ktz8866 + + current-num-sinks: + description: Number of LED current sinks. + + current-ramping-time: + description: LED current ramping time. + + led-ramping-time: + description: LED on/off ramping time. + + enable-lcd-bias: + description: Set if we want to output bias power supply for LCD. + type: boolean + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + backlight { + compatible = "kinetic,ktz8866"; + + pinctrl-names = "default"; + pinctrl-0 = <&bl_en_default>; + + current-num-sinks = <5>; + current-ramping-time = <128>; + led-ramping-time = <1>; + enable-lcd-bias; + };