From patchwork Wed Jan 18 14:48:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 13106471 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27A2C38147 for ; Wed, 18 Jan 2023 14:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbjAROyS (ORCPT ); Wed, 18 Jan 2023 09:54:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbjAROyA (ORCPT ); Wed, 18 Jan 2023 09:54:00 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE9546D79 for ; Wed, 18 Jan 2023 06:48:20 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE57E5BFC0; Wed, 18 Jan 2023 14:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674053298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OiRjN7NIUQyd4jxpceaU2xclU8h8+TX458Q0uyHS+bE=; b=rhaYwMJXOB8YSnYT0dULNkC+WTceBFH9azijjF+mwxOiLcMKKm/5o5uRGQyWFfdPfdnzm7 t3Ueyr4vdLt/sX91PHn+Z4XR3NX74b3upVcTEhoEN8Wj6aqsUfQUUXtm9nz5kbv42Lzq1M PRO1iwI5iynDax9RJ+JOcHy/xoUp8AI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674053298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OiRjN7NIUQyd4jxpceaU2xclU8h8+TX458Q0uyHS+bE=; b=WJQxJTDdO+Pn5OZAfMpuKbW7tUEs/awvZTmdGdvJaOtIhqgJk/Km4+UYOkEsjqUnmx3mcr sEqvleXcxA+9KmBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EFB2138FE; Wed, 18 Jan 2023 14:48:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id v03xBbIGyGO8bgAAMHmgww (envelope-from ); Wed, 18 Jan 2023 14:48:18 +0000 From: Gabriel Krisman Bertazi To: axboe@kernel.dk Cc: io-uring@vger.kernel.org, Gabriel Krisman Bertazi Subject: [PATCH liburing] test/helpers: fix socket length type Date: Wed, 18 Jan 2023 11:48:06 -0300 Message-Id: <20230118144806.18352-1-krisman@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org t_create_socket_pair uses size_t for paddrlen, which is uint64 on 64-bit architecture, while the network syscalls expect uint32. The implicit cast is always safe for little-endian here due to the structure format, its small size and the fact it was previously zeroed - so the test succeeds. Still, on BE machines, our CI caught a few tests crashing on connect(). For instance: localhost:~/liburing/test # ./send_recv.t connect failed test_invalid failed Signed-off-by: Gabriel Krisman Bertazi --- test/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/helpers.c b/test/helpers.c index 869e90342f9a..37ba67c070c8 100644 --- a/test/helpers.c +++ b/test/helpers.c @@ -173,7 +173,7 @@ int t_create_socket_pair(int fd[2], bool stream) int val; struct sockaddr_in serv_addr; struct sockaddr *paddr; - size_t paddrlen; + socklen_t paddrlen; type |= SOCK_CLOEXEC; fd[0] = socket(AF_INET, type, 0);