From patchwork Thu Jan 19 11:47:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun R Murthy X-Patchwork-Id: 13107768 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0733DC6379F for ; Thu, 19 Jan 2023 11:52:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B2E710E917; Thu, 19 Jan 2023 11:52:43 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DA1710E912; Thu, 19 Jan 2023 11:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674129160; x=1705665160; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IjtNrB+4d+dVVFO/zsHyXhtWbn+dN/mrcFLiTT1ibHs=; b=LfVIE+35NfaCOQnu9l+1K4wNm+cqdPl8v4yIVOsR2fRU5lp8+CgA0T1Y edNwFQNRCzjYtWJkUyAN6sgz0C/Jv1PAGk20yNR2dGiQQT4hedUqCFzQN /SMnnZySSV4sT1tuoqeU41FmKUhVWEmVKTeuQbrFo7+IuwoCpto/Cq0d6 hCNEbbnuWy+WfJuWZNMGDutkx1IzAJPhXXlYmdNmLMpCycCTZuahXOoNy C/Eypq+WXnbqH5iv1P2neqqmW884Vym8YaLbPuwsV4Ak8DL1xhie9BNOI S32ou5fQSXBZDFhLvgtl1UYuKt+ffztgIonB0UTwY5vUKcaseaVAKasZU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="305636618" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="305636618" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 03:52:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="692392471" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="692392471" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orsmga001.jf.intel.com with ESMTP; 19 Jan 2023 03:52:36 -0800 From: Arun R Murthy To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jani.nikula@intel.com Subject: [PATCHv2 1/2] drm: Add SDP Error Detection Configuration Register Date: Thu, 19 Jan 2023 17:17:06 +0530 Message-Id: <20230119114707.1425501-1-arun.r.murthy@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230113043653.795183-1-arun.r.murthy@intel.com> References: <20230113043653.795183-1-arun.r.murthy@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arun R Murthy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" DP2.0 E11 defines a new register to facilitate SDP error detection by a 128B/132B capable DPRX device. v2: Update the macro name to reflect the DP spec(Harry) Signed-off-by: Arun R Murthy Reviewed-by: Harry Wentland --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 632376c291db..358db4a9f167 100644 --- a/include/drm/display/drm_dp.h +++ b/include/drm/display/drm_dp.h @@ -692,6 +692,9 @@ # define DP_FEC_LANE_2_SELECT (2 << 4) # define DP_FEC_LANE_3_SELECT (3 << 4) +#define DP_SDP_ERROR_DETECTION_CONFIGURATION 0x121 /* DP 2.0 E11 */ +#define DP_SDP_CRC16_128B132B_EN BIT(0) + #define DP_AUX_FRAME_SYNC_VALUE 0x15c /* eDP 1.4 */ # define DP_AUX_FRAME_SYNC_VALID (1 << 0) From patchwork Thu Jan 19 11:47:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun R Murthy X-Patchwork-Id: 13107767 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 843ECC00A5A for ; Thu, 19 Jan 2023 11:52:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1998210E915; Thu, 19 Jan 2023 11:52:42 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id C36B610E915; Thu, 19 Jan 2023 11:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674129160; x=1705665160; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=trNCxGnSP4ZToFQVZRvV2mLowfUfMjvj7+tgltCb35Q=; b=Jt8gkmP7iie3+QR/qQAjQL2Am3dQ/zQM4MhR70LKgLqhbuUpQLBGeDYH MSfqFs1X6aZcAvYAbBCTCN96oOq41lqvph03dNAqR/gIu9TxDGU3afvP2 UyNiQy9czhxejpgkrt98mT3bRifGP5Gw8mWx157/bfc/XIKueVWi34Fgm rm/JOJxV2x8hAFj3YJbYrb1HY+/cA5CZITVwZ5owWJ6KVBAQQ/XZvRWoz 7VX5b81K5B0KVsqZHlWagH1qpMsSYCt17h7w8Oa5Rf9tuFO+lFo1mq8Pa Ik+EF7Myh7YAYwAP/X+x38ccnxwkvEUVg+18wG8hbf5QUJB+lW+RK7Y5x g==; X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="305636627" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="305636627" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 03:52:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10594"; a="692392485" X-IronPort-AV: E=Sophos;i="5.97,229,1669104000"; d="scan'208";a="692392485" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orsmga001.jf.intel.com with ESMTP; 19 Jan 2023 03:52:38 -0800 From: Arun R Murthy To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jani.nikula@intel.com Subject: [PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer Date: Thu, 19 Jan 2023 17:17:07 +0530 Message-Id: <20230119114707.1425501-2-arun.r.murthy@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230119114707.1425501-1-arun.r.murthy@intel.com> References: <20230113043653.795183-1-arun.r.murthy@intel.com> <20230119114707.1425501-1-arun.r.murthy@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arun R Murthy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Enable SDP error detection configuration, this will set CRC16 in 128b/132b link layer. For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is added to enable/disable SDP CRC applicable for DP2.0 only, but the default value of this bit will enable CRC16 in 128b/132b hence skipping this write. Corrective actions on SDP corruption is yet to be defined. v2: Moved the CRC enable to link training init(Jani N) Signed-off-by: Arun R Murthy --- .../gpu/drm/i915/display/intel_dp_link_training.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c index 3d3efcf02011..7064e465423b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -1453,4 +1453,16 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp, if (!passed) intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); + + /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */ + if (intel_dp_is_uhbr(crtc_state) && passed) + drm_dp_dpcd_writeb(&intel_dp->aux, + DP_SDP_ERROR_DETECTION_CONFIGURATION, + DP_SDP_CRC16_128B132B_EN); + /* + * VIDEO_DIP_CTL register bit 31 should be set to '0' to not + * disable SDP CRC. This is applicable for Display version 13. + * Default value of bit 31 is '0' hence discarding the write + */ + /* TODO: Corrective actions on SDP corruption yet to be defined */ }