From patchwork Mon Jan 23 15:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 13112329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF6CC38142 for ; Mon, 23 Jan 2023 15:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HfQ1QqNJcCLdNHEPtGLs7RqOZUV1tnmGcRMvf82mZwc=; b=jZjxEaHKvAcqkL 3YTQPK4Xmjyc/YUII2R2ztSRn/jbU2+OHEK/5zEDOuv+1jOp0ueeGVNpGXw+3USoVRXjSiI7hzbXi 4bAaOuHib4zYmnvPzBQySZPvWqLuJVy8bWIHGCdyn9snhjCO5CrYMH2RwGztd5yBhIJpKOF1+khAa pjSAEkNy8OuMAP2SKvSP0A/XtVQOw6b+4ExYpJ3i4J+vxKrIqzgdZYB4z8lc+i3rc8B3ZPCCbA4Zu wM/lZzXTUQPiOagJINNg5fv065z4Zu9j9S9peBNXDhICG+EnIoESWmyqdyIM2gsZx+xRda2tvUjQ4 awbhqjlCZ8x3XbQ5gcRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJyPn-0004BP-6I; Mon, 23 Jan 2023 15:07:19 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJyPj-0004AB-Mm for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 15:07:17 +0000 Received: by mail-wr1-x42b.google.com with SMTP id b7so11112705wrt.3 for ; Mon, 23 Jan 2023 07:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2r/jQsT2oEtOaIcS9vBErqTIfKM514JHFTcSRlzNiJk=; b=NI9VeMmKPpbbz0TCCZFqlACCyCjRtIQH1LXay4iHb5L7cwXC9C05rVzDy8t4boOARD ITqqWkdZFg7s2dhkfzDTO0PYouCczNUgmF+g0YNlPypmfQSuxkf3gwgc0duluEn5zYRe BGj9luGazljmvjSSK2kIM6dkPKipT0gSqF/d9p5/6Koa6Wid4/sy5ZPSc0XvxveIANNL OLmoxPLeorbSCHvaRFPquDrzvdacAeSEWCXY42GIyODGEhGAAU5kpNZnK9BZLN4alsXe 6CCqQjhq0hAxdpyuOyKTM/TAiyOYtOiMc3Px61GIiQ0oL4dOz6mvsI/ahi9gmNe0cVeT buSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2r/jQsT2oEtOaIcS9vBErqTIfKM514JHFTcSRlzNiJk=; b=mKRl4drKHswVtnWkbL5IC4+qzAid6tOtk+Ix1kT8GynbOyH2vnRe3bmBTvHpBoyRGB 8bESQ7H232t9ciKmsdPCfU/WWGBaigrwd7Owi1QrP6neG52CYPpZLk137oUZPaYzeAEn YbrQKxFPxJqum7IbJL/sbOyQL1qsdqWyKj5QwqKaghP9jOMrqciSNPaLxxKY9O6xYlMi +LNr6GVumcbDa26X0a+ON1Ib9AAOmEIOdAQLAEFZjlHGjlrEIixKwpEJnmtdU3gqTZvs Har3ecj3aMM7iiGnJfZL6tfJyBCSprWVlp6JHupgTPJAtw5sdOCTWjZIsLxyjjNy6hmH SICw== X-Gm-Message-State: AFqh2kqtwFCR5KiRsdpP9fvLTh/Cwy9eRf7VKX/SbYpilHMYUEWD9e3g xctM/mNseuaT7PmfK0i57e4= X-Google-Smtp-Source: AMrXdXsU5OJbMtMy8HopokShczr+JtKjkxOBLstZUM6HS5OjuWvTMCsoLgWmESZH43ffbscSu/cnPQ== X-Received: by 2002:a05:6000:98d:b0:2bb:6d44:5d1 with SMTP id by13-20020a056000098d00b002bb6d4405d1mr24853979wrb.28.1674486431669; Mon, 23 Jan 2023 07:07:11 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bu3-20020a056000078300b002be505ab59asm8888399wrb.97.2023.01.23.07.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 07:07:11 -0800 (PST) Date: Mon, 23 Jan 2023 18:07:07 +0300 From: Dan Carpenter To: Sudeep Holla , Cristian Marussi Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] firmware: arm_scmi: Clean up a return statement Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_070715_781127_40FAFEBF X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The comments say "enabled" where "disabled" is intended. Also it's cleaner to return zero explicitly instead of ret. Signed-off-by: Dan Carpenter --- drivers/firmware/arm_scmi/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index d21c7eafd641..703f16ef3953 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev) if (ret) goto clear_dev_req_notifier; - /* Bail out anyway when coex enabled */ - return ret; + /* Bail out anyway when coex disabled. */ + return 0; } /* Coex enabled, carry on in any case. */