From patchwork Mon Jan 23 18:46:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 13112782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E746BC05027 for ; Mon, 23 Jan 2023 18:46:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 158D110E078; Mon, 23 Jan 2023 18:46:56 +0000 (UTC) Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7F7210E078 for ; Mon, 23 Jan 2023 18:46:54 +0000 (UTC) Received: by mail-pj1-x102a.google.com with SMTP id lp10so9092569pjb.4 for ; Mon, 23 Jan 2023 10:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=edgeble-ai.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=m5i4QR8qy1CMbxdo43pdI8cVBA6fl0tkLIrsZh+J/D4=; b=C2iWosssSY0cmzfPxup47V5McMzQzaWs+qrgrMKlZj9B9iFiaFiRYG/S9I2vl1vAWq dAODN44UDjBtbgAWsAayBRtSav8QjtUwr0gzOEpSH5H9Bd/xCkYeAl9dvPtTy7utl26O 6n4poiukSq+nw8ySuoEsh1UWzKyfZd8rQjziSfV4a+WxOBRYgTVpzNbM9ePst/4llMA/ JxUBWb/Fxnkl+1knfTmAcExt+ci8seV/v/CydCJyQh8BJ3VPbbKjptZ7DzQGG3Y4pixx qWxf6RQlwG7HI7In5FuiSVGzHQ/E09NA+om0S7Rv1551beszM2dzq9EbgcFcJ9p9g7Ot nzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m5i4QR8qy1CMbxdo43pdI8cVBA6fl0tkLIrsZh+J/D4=; b=d8+3En2qjvl/+DRACJ7ScBcjXX4iesYebonO/dovUwd3PP/ERWtpjAZebdj3GSmPkc YIF7fKtrpXqqVk1Wjf5qasxpcaBPxN2ARLzEziMl23jXrz343Mw4Ck+fR6Nh5b5lpxIl QJOs7/N+U0UTrj3I0hwykTjT/JMM/dIiES6FTNnf/5aptKYkGGnqrmyzqmyOC60suXDE 9NFD/DdjeorIPKc2lY5wbZTi8J+DncdS102illz1Wab286b1/wMk3xTrZq9viWXjznQz A7P2cNLXlGj2iJK0KP+p5dgKkTYYsN9qSTfD88SD2C03UAxkH9PaEuPHPFyVaFSbhmIN Lz0Q== X-Gm-Message-State: AFqh2krwaV1tMBQMEgAzRVdWJDOqj9QsuTlsu1D0IWP7UY8zVKdWs7fD ibT7ka2sfjMglZ9LVliHHPljSw== X-Google-Smtp-Source: AMrXdXsb9+5dnzTJOITTAhlcH22qiCHJZTUcZ0ir4M/PwCv7rd/tvtjDKZkkSYM4UtaRBlhPzz2ntg== X-Received: by 2002:a17:902:c408:b0:194:6afa:ca with SMTP id k8-20020a170902c40800b001946afa00camr36597498plk.56.1674499614293; Mon, 23 Jan 2023 10:46:54 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id jb11-20020a170903258b00b00189a7fbfd44sm17441plb.211.2023.01.23.10.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 10:46:54 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Neil Armstrong , Robert Foss Subject: [PATCH 1/2] drm: bridge: dw-mipi-dsi: Handle NO_EOT_PACKET mode Date: Tue, 24 Jan 2023 00:16:46 +0530 Message-Id: <20230123184647.437965-1-jagan@edgeble.ai> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Many downstream bridges or panels followed by dw-mipi-dsi were using MIPI_DSI_MODE_NO_EOT_PACKET. So, handle the EOTP bits accordingly in the dw-mipi-dsi host. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index b2efecf7d160..47bd69d5ac99 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -664,7 +664,13 @@ static void dw_mipi_dsi_dpi_config(struct dw_mipi_dsi *dsi, static void dw_mipi_dsi_packet_handler_config(struct dw_mipi_dsi *dsi) { - dsi_write(dsi, DSI_PCKHDL_CFG, CRC_RX_EN | ECC_RX_EN | BTA_EN); + u32 val; + + val = CRC_RX_EN | ECC_RX_EN | BTA_EN | EOTP_TX_EN; + if (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) + val &= ~EOTP_TX_EN; + + dsi_write(dsi, DSI_PCKHDL_CFG, val); } static void dw_mipi_dsi_video_packet_config(struct dw_mipi_dsi *dsi, From patchwork Mon Jan 23 18:46:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 13112783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADEA2C05027 for ; Mon, 23 Jan 2023 18:47:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E24410E223; Mon, 23 Jan 2023 18:47:00 +0000 (UTC) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FD4610E223 for ; Mon, 23 Jan 2023 18:46:58 +0000 (UTC) Received: by mail-pl1-x633.google.com with SMTP id z20so10377265plc.2 for ; Mon, 23 Jan 2023 10:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=edgeble-ai.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/kLbhwTQMwg9Q/s7+KMD8jqghIEpKJvQwNNB9zhXZbM=; b=t2J+tcHZN8L0jZAtbMSQebnCe/qpsds5NDuY7z5bKB5II0VDXNB9EPxV2FK16H/yDS knGojVQ1IzxR6sb3mqGmRqxN9Zl67pq/arrR55OioYTv5ndG/Pb3HTfiRmB1Rx1Ri6HK f9Q7C5JLYRGWNaXbqsZ+l0pCGQW4A0JYwOaSa7s09sKCTRJo6vxYEZG5YsNnQpqDJmUx Cxv5rpRGzlZqKmHTBaIch5+M/cZKjQ4U6UvDW37dKcTaGhHQJrhXG2PZIOxhjRTP7WPI HXGXSwAv07jELvKwZN1ucH6B6hJagEe09xddTc/uW2ZpKViZAfF+QAr7oivzUeklIoj4 tmug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/kLbhwTQMwg9Q/s7+KMD8jqghIEpKJvQwNNB9zhXZbM=; b=o+x+1ltkgQFT2yNyEZ540yrvQNXZJ/1rgse32vmGO5eBRACnNBUz0Xzr/J5BygBZ4B 4POEfz21n8fUBx6gwf1LValCGqIMpUpSvn34BnPdOf9Hp3cZUuDqa014pYN0V0V734nQ mAZ1stxcn7MqIuD5bGEI7WkCERW+OTqfiduKZdRY+Qo+VhG+0XLDXprrhLJ5+i9Hi3hj 9YsWdFHAof4dOcu+AbmEYSJP8119CY2MHOYdJlcVUA6glPHV5DmAljCyt0HBsmdP3I2a eFy6P9maqUWrMzdc4Mn0a88FvZwVbWg6JgjMmvfoX8vjbb3TW2KewgdJOG+A3xIWa0OO stNw== X-Gm-Message-State: AFqh2krurO4dvU+1VM5khMyVmX9uDjXNn4wUA8pDeqWabMeUHdNfClID Z0raEd2lajN+tq9uYkaoUJsXOg== X-Google-Smtp-Source: AMrXdXvGtL5GwRI9/jEZIqSG7Eux3w2Pg52X+qUDo5VgBlHaXzPKoJoAvuToHMaVWEcDwJHXp9uW6g== X-Received: by 2002:a17:902:ef86:b0:194:59c2:a154 with SMTP id iz6-20020a170902ef8600b0019459c2a154mr25357025plb.61.1674499617725; Mon, 23 Jan 2023 10:46:57 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a15f:2279:f361:f93b:7971]) by smtp.gmail.com with ESMTPSA id jb11-20020a170903258b00b00189a7fbfd44sm17441plb.211.2023.01.23.10.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 10:46:57 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Neil Armstrong , Robert Foss Subject: [PATCH 2/2] drm: bridge: dw-mipi-dsi: Switch to regmap support Date: Tue, 24 Jan 2023 00:16:47 +0530 Message-Id: <20230123184647.437965-2-jagan@edgeble.ai> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230123184647.437965-1-jagan@edgeble.ai> References: <20230123184647.437965-1-jagan@edgeble.ai> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To make debugging easier, switch the driver to use regmap from conventional io calls. Signed-off-by: Jagan Teki --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 81 ++++++++++++------- 1 file changed, 54 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 47bd69d5ac99..62a160af4047 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include