From patchwork Thu Jan 26 04:02:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD31C61D97 for ; Thu, 26 Jan 2023 04:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbjAZECz (ORCPT ); Wed, 25 Jan 2023 23:02:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjAZECx (ORCPT ); Wed, 25 Jan 2023 23:02:53 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EDDAE2D72 for ; Wed, 25 Jan 2023 20:02:46 -0800 (PST) IronPort-SDR: ZLrEiAKOvoujCwa9n0eD60zQVbzu//um34Y27tLnrt0O0q3bRa7t+Ze/dJtApdOqe6An39yVGw 6z85FN2Z+Uq88Z2k+4b3fDs3S8S5kN8qFj86Ch8PgIqjeCtzNNR6H5TCs+b8jDvGegBTEAvQwI 4qlU7J24O+8u64mhhpQyUKW2+3BDvQcFX3si9yQqgywZeJuBQJBEhR4uVpxPhQxge0AnCPwfAN 0vadoZZtqtZy02911P892uD03jF+SaKKAcnWAByhnG45yp/6XvxZcOkEIDKch4fF6jg8LIvbLq NZh7xCmLkLbzlKNimV+RQSKR X-SMTP-MATCH: 0 X-IPAS-Result: A2AsBgCK+tFjjPQc8jxaHQEBAQEJARIBBQUBSYFGgi2CYJVtnz4PAQ8BAUQEAQGFBgKFIyY4EwECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgQUAQEBAUBSBwtSBwtYBweBQQuBYRMLAzENhlYCAQMnCwENAQE3AQ8ZOFcGARKCfoMjrGMzgQGCCAEBBoJimmeBXgmBQIthgRSDN3pDP4FOglGBPm6LA44IjTYKgTl4gSUOTHqBDwIJAhGBLAMJAwcFSUADCxgNFjIKEyw1CwtKKxobB4EGKigVAwQEAwIGEwMgAg0oMRQEKRMNJyZpCQIDIV8FAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeHHKBDoFxkz8KjnuhYoN8gVKefUyBRII1k0eRapdNIINmnh6BGIQrAgoHFoF5gX5NHxmDIk8BAgEBAQ0BAgEBAwECAQEBCQEBAQGOHQwNCYIKjDhhOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:6bZoOh0ZJSFp8JEvsmDPn1BlVkEcU/3cNA8J8dwskbtRfKO589LvO VGZ5PkrhUKaFYzB4KdCjOzb+7vlRXRG+5uEt2wPNZ1UAhEJhZ9EwAUpDJyJVRKrfqe4PScwR ZwQX1Q9oBmG IronPort-Data: A9a23:+gPjAag1m2m6DiPsErV1/PjSX161VBYKZh0ujC45NGQN5FlHY01je htvWmnTa/uMajf2LY0jYYy3o05UvZDdzoQxGwVrrSlnQipApceZXYTJIh36b33DcZySEBM/s ZlGMYGaJp9uR3PW/T6gY+PrxZVe/fjYHuCmVIYoGczQqStMEnpJZcdLwrZh6mJQqYHlRVvL4 7semuWHULOf82cc3l88sspvljs/5JwehxtA1rAOTagjUIj2yhH5pLpGTU2AByOQrrt8R4ZWd M6fpF2NxV41yj92Yj+TfhcXRWVRKlLaFVDmZnO7wMFOiDAazsA5+v5T2Pbx9S67hh3R9+2dx umhurS0axg0OYvBwN8ZCTgDPiBVPLB80pvYdC3XXcy7lyUqclPmwul1SkosNJIW/fx7R2xL6 LoZJHYEc3hvhcromPThFrMq3JRldpW3VG8ckigIITXxA+wvR5PrSL/D+tFfxjt2i8VTW/fSI cMEAdZqREicO00eZg1OWPrSms+EqFrlLhtmoW6SirQF/m/p9TVu1bziZY+9ltuiHp0OzhzC9 woq5V/RBhAcKczaySWA9XSEmODCh2X4VZgUGbn+8eRl6HWXx2oOGDUMUlaworykkQi4Vs43A 04Y9y4wpLI/3Fe2VdS7VBq9yENopTZCA58KT7d/slHIkPaIpR2FD3QFRXhdcNMn8sQxQHojy zdlgu8FGxRrkqKITlSQroyQ9xLpFCk+LHI4TwsbGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/ 9xshHZn71n0pZBWv5hX7WwrkBrp/cOZEVdpjunDdjv4t1khPNDNi5mAswCz0BpWEGqOZnC81 JTus/OP4OYDHPlhfwTXGL1VdF1Fz9CIL3XnhkNzH9Ee/jCg4BaekW14vmk7fhszd5xUPGW1P AnIpQpN5ZQVIGOlbOl8ZIf3AtlCIUnc+TbNCqy8gjlmOMMZmOq7EMZGPxD44owVuBJw+ZzTw L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2MGc6klkj9juLOPxZ5rIvp1nPQN4jVC4va/W3oH yp3bZriJ+h3CrKlO3KPoeb/03hXfSZiXfgaVPC7hsbYelE2QjtwYxMg6a85dMRkmbhYjOHF4 hmAtrxwljLCaYn8AVzSMBhehEbHAc4XQYQTYXVyYT5FGhELPe6S0UvoX8RqLeJ7pL07k5aZj ZAtIq29PxiGcRyfkxx1UHU3hNYKmM2DiV3cMiy7TiI4epI8FQXF9sW9Llnk7iARAC2tuY0zp qDm1w+dSIdaH1ZuC8PfafSOyVKtvCFDx7grBhCXfIVeKBf27YxnCy3tlftpccsCHhX0wGfI3 QihHkZKrObAlIY57d3ViP3WtIyuCeZ/QBZXEjCDv7a7PCXX5ES5xopEXLradDzRTjqkqq64b PpbyOvwdvACgRBLv8x1Du8zn6454tLuoZ5czxhlRSuUNQ3yUew+fnTfhJtBrKxAwLNdqDCaY EPX94kII6iNNePkDEUVelgvYNOD4vdIyDPc2utkckz16Rh+8KeDTUgPbQKHjzZQLeUpPY4on bUhtcoR51DtgxYmKIzd3CpV63/KJWYJTKsgrJ1cDYr2zAsnjFhfOMSOBijz6ZCJStNNLkhzf GDO3fOZ2OoAyxqQaWc3GFjMwfFZ28YEtidK+1ledV6HrcWU1PY40SpY/SkzUgkInA5M1Ph+O zY3OkApd7+C+Sxk2JpKU2y2QFsTWkXcoBCrjgFZ0TeFEw+zSmXRLWZ7Jf6C/QYS9GcadyUCp OOUz2PsUDDLesDt33JsBhQ88qe8E4B8pl/YhcSqP8WZBJ1mMzDrtan/N2MHpizuDd41mECa9 /Jh+/x9aPOnOCMdy0Hh51J2CVjNpMi4GVF/ IronPort-HdrOrdr: A9a23:/u4soavFUJVdTxthpKv+DXUf7skDrNV00zEX/kB9WHVpm6yj/f xGUs576faSskdpZJlD8ersBEDkex/hHPFOkOos1NuZMzUO/VHYSL2KjrGSpQEIZReOlNK1vJ 0IG8ND4Z/LfD9HZK3BgDVQfexP/DEJnZrY/ds2t00dKD2Cc5sQkzuRFDzrb3GemzM2fqbQxf Knl7B6mwY= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:32:43 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5U1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:38 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5U1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705759; bh=ZEPjMNMpNNGoT3JyHGJY8+fZzD0RHKUVp9nUZ1q8/Qw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DkFZWM4l3iEQL7BWqQGC5IrBhZY4+YAaojAqwqLtMS+M1EbL/+I/kozeIWjulp/Vl jQJMuyRvS1+yQyIotQa3sdsadOKGe/r4G/rZrL+divArYoyOD6HQK97fPV5H34FTY5 CRj9JtpVjctxC5C78Cji1JzD0FuQ0XVroqLz4qJZZPgbbapE6XmEP3TmMMfueqCPjN MSbPnlT2GoMEFhFbPM78rzMWFcyEKxRmLqtQGVXqIKFaAujkzXIw4GGDmyd+nN/CdF Ejk+7J0sUGrdAovMyv21LvIliLVO29w3HqjtIup3AOs10+PNsXEzcmC9NW7sYg01BB p1FP2Qpy/SjVg== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Date: Thu, 26 Jan 2023 15:02:17 +1100 Message-Id: <20230126040223.986189-2-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:39 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Disabling configuration mode on some chips can result in system hang-ups and access failures to the Super-IO chip at the second SIO address. Never exit configuration mode on these chips to avoid the problem. This patch should be applied in conjunction with a previous one to initialise the second chip for certain mother boards. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index a8a6a0ffee82..7049e81f5af1 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -128,10 +128,12 @@ static inline int superio_enter(int ioreg) return 0; } -static inline void superio_exit(int ioreg) +static inline void superio_exit(int ioreg, bool doexit) { - outb(0x02, ioreg); - outb(0x02, ioreg + 1); + if (doexit) { + outb(0x02, ioreg); + outb(0x02, ioreg + 1); + } release_region(ioreg, 2); } @@ -497,6 +499,7 @@ static const struct it87_devices it87_devices[] = { struct it87_sio_data { int sioaddr; enum chips type; + u8 doexit; /* Values read from Super-I/O config space */ u8 revision; u8 vid_value; @@ -523,6 +526,8 @@ struct it87_data { u8 peci_mask; u8 old_peci_mask; + bool doexit; /* true if exit from sio config is ok */ + unsigned short addr; const char *name; struct mutex update_lock; @@ -2405,6 +2410,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, int err; u16 chip_type; const struct it87_devices *config; + bool doexit = true; err = superio_enter(sioaddr); if (err) @@ -2501,6 +2507,8 @@ static int __init it87_find(int sioaddr, unsigned short *address, goto exit; } + sio_data->doexit = doexit; + err = 0; sio_data->sioaddr = sioaddr; sio_data->revision = superio_inb(sioaddr, DEVREV) & 0x0f; @@ -2827,7 +2835,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, sio_data->skip_pwm |= dmi_data->skip_pwm; exit: - superio_exit(sioaddr); + superio_exit(sioaddr, doexit); return err; } @@ -3061,6 +3069,7 @@ static int it87_probe(struct platform_device *pdev) data->addr = res->start; data->sioaddr = sio_data->sioaddr; data->type = sio_data->type; + data->doexit = sio_data->doexit; data->features = it87_devices[sio_data->type].features; data->peci_mask = it87_devices[sio_data->type].peci_mask; data->old_peci_mask = it87_devices[sio_data->type].old_peci_mask; @@ -3213,7 +3222,7 @@ static void it87_resume_sio(struct platform_device *pdev) reg2c); } - superio_exit(data->sioaddr); + superio_exit(data->sioaddr, data->doexit); } static int it87_resume(struct device *dev) From patchwork Thu Jan 26 04:02:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1900CC05027 for ; Thu, 26 Jan 2023 04:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbjAZECy (ORCPT ); Wed, 25 Jan 2023 23:02:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjAZECx (ORCPT ); Wed, 25 Jan 2023 23:02:53 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D7437ECA for ; Wed, 25 Jan 2023 20:02:50 -0800 (PST) IronPort-SDR: FBiUMfC1NEJOmJbf78FmHcZiIOEOM1Ut54HIdbeTd4wNFfTaQ82oanIZS4gRAZGFhXoS0UbwuM wbBDsVmG9Xa2LhKzuD7hMACNMwFduUDqCmxWq48NF9cw9dBJW7HSPERzPdFqpALvHgpC0HqI2L qtQ/YykWk6wIpM6E3EsiDLL5S1qyrSY8nJOZx8pJoEJ+JP4Pyu5coja5YeiyUAJjTMrMHuMIpy 6aFIY5Ex9cQVvmQl5ow47P9jZ72VaQxXGz4kzaS0baasKkgvgnHQW8fFYRWbiqMjvoHzUhKqbO 2djpfcbuBWAovLlGalSi0skO X-SMTP-MATCH: 0 X-IPAS-Result: A2BFBACK+tFjjPQc8jxaHAEBAQEBAQcBARIBAQQEAQFJgUaCLYJglW2fPg8BDwEBRAQBAYUGAoUjJjgTAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBBQBAQEBQFIHC1IHC1gHB4FBC4FhEwsDBAglDYZWAgEDJwsBDQEBNwEPGThXBgESgn6DI6xjM4EBgggBAQaCYppngV4JgUCLYYEUgzd6Qz+BToQPbosDmz4KgTl4gSUOTHqBDwIJAhGBLAMJAwcFSUADCxgNFjIKEyw1CwtKEBsaGweBBiooFQMEBAMCBhMDIAINKDEUBCkTDScmaQkCAyFfBQMDBCgtCT8HJiQ8B1Y3BgIPHzcGAwkDAh9PcS8SEgUDCxUqRwQINgUGHDYSAggPEg8sRA5CNzQTBlwBKQsOEQNQRxluBIIRBikmnhxrB1k1ToEjkz8KsF2DfIFSnn1MgUSnZpdNIINmnh6BGIQrAgoHFoF5gX5NHxmDIk8BAgEBAQ0BAgEBAwECAQEBCQEBAQGBM4xqGYITjDhhOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:rPGi9RKC2ljLThFf9NmcuVEyDhhOgF28FgQU9oFhgKhHbaqk5ZikM UnCo/RhylbUDs3S8fkRje3Qvuj7XHAYp4yMtXcefdlNT0oLhclMzVMpCcLXBRGkfKyzPX4xF p0aBlRupy7TDA== IronPort-Data: A9a23:jh9y/qMtam1dXGbvrR2RkcFynXyQoLVcMsEvi/4bfWQNrUorgjVTy WsXUD+EPPiJZTf9ctslPo3kp00BupeAzt9hSlBt+SA1H3xD88CZC4XJcxr6birIcsObEB07s Z8VOtSbBc1lFXW0SjWFa+i59yMgvU2rqhsQLMaeZ0idkCc9EH9JZSpLwrJ/2sgy6TSAK1vlV ena+qUzBXf8s9JKGjJMg068gEsHUMTa4Fv0aXRjDRzjlAa2e0g9VPrzF4noR5fLatU88tqBe gr25OrRElU1XvsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0o2HKJ0VKtZt9mGt+pN4 /5NrazhcAU4YZfnqt8Bf0VZAggraMWq+JefSZS+mcaS01aAeGHl3PtpFk1wMIgFvOd7R2hTn RAaAG5VKErf3aTskPThFrUEascLdaEHOKsRoHhmzhnSF/85T5fZT+PH4MIe3Tt2j90m8fP2O 5ZBOWszNk6ZC/FJEnc9Nbs9m86avUH+eD5Dsn2ngbA5xkGGmWSd15C2aIGFIIbbLSlPpW6cp 2Tb7yH5HRQdMvSBxjeftHGhnOnCmWX8Qo16PLm58ON6qEeUy2cQTQANE122vZGRiEKzX8xWM UE84Tc1oO4580nDczXmd0Pg5STY5FtGC58KT7F88x2E1qvfpRqBCWlCRTlELtU73CMredA0/ mW1tPjpHQw+ib+EFki2xIyIgW+zKAFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJYjvdR2iYL 9ei8nVWulkDsSIY/+DgpgCY2m7ESozhF1NsvF2PAApJ+ysjPOaYi5qUBU/zxMsowGyxdUiNu nUV8yR1xLpWVcnleMClZugSVIqu+uqFeALVhVN0d6TNGhzzozv5IdoVumE7fhs1dN0YcCPoa wnPoQxQopRUOT2jcMebgr5d6ex2kcAM9vy/DZg4i+aihbArKme6ENlGPxL44owUuBFEfVsDE Zmaa92wKn0RFL5qyjG7L89Ej+B3mH9nmTmMHcCgp/hC7VZ4TCDMIVviGAXTBt3VEIve8W05D v4FaJDTkE0POAEASnSHr9dLRbz1EZTLLcuu8JwNLL/rzvtOBHkuQ/7X3b47fYF595m5Zc+Wl kxRrnRwkQKl7UAr3C3WMhiPnpuzBMgjxZ/6VARwVWuVN48LPtv/t/tPJsNpFVTlncQ6pcNJo zA+U53oKpxypv7volzxtLHx895vcgqFnwWLM3b3aTQzZccwFQfT88DqeRHjsiQLE2y2uY03v uT4hA/cRJMCQSVkDdrXMazwlQro5idDxu8iDVHVJtRzeVn39NY4ISLGjsgxf5MGJyLcl2mT2 AuhCBsFofXA/t0u+97TiKHa84qkSrMsHkdTE2TBw6yxMC3WojiqzYNaCbbadirUS23z4qnka OBIifDwdvQaxQ4Yv415Grdt7KQ/+9q2+eAAl10/QyuVYg3yWL16I3SA0c1ejYF3x+dU6VmsR 0aC2thGIrHXasnrJ14mIlZ3ZOq0yqBGkzbf2v05PUHm6XIl57GAS0hTYUWBhSEBfrt4NIQpn bUotMIMsVftgBs2KZCNlClL+WOWIjoNVrhht51cCZKy0lgnzVRLYJr9DC7q4cjRNI8VaxJ1f GGZ1PjYmrBR5kveaH5tR3LD6upqg8hcsh590w5QLluErdPJm/sr0UAD6j8wVAlUkElK3r4hI GRtLEEpd6yC8y0z3podByX2R1sEXk3coBCtjUAVnXHYRA+0TmPMamY6PKCE4RlBoW5bezFa+ pCeyXrkCGi1JpiohXRsB0M1+eb+SdFR9xHZnJz1FcqyGchoaDXotaaieG4Upka1Gsg2nkDG+ 7Vn8esYhXcX7sLMT3DX07Wn6Ik= IronPort-HdrOrdr: A9a23:/Dnuiaxl91mbh9BkPVSNKrPw9r1zdoMgy1knxilNoHxuGPBwWf rOoB19726MtN5yMEtMpTnkAsW9qBznhP1ICOUqUotKGTOW3FdAT7sSi7cKvQeQeREWn9Q1vc xdmupFebrN5DNB7foSjjPXLz6ureP3iJxA/d2uqkuFVTsaF52I8T0JdzpzzXcGPzWv1PICZe Ch2vY= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:32:46 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5V1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:42 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5V1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705762; bh=y13tW2raThAmNNP5ikKI/08rRN0vvmnwjxeCltInTIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t83S66JtXa6jBgBtX9K0krC62mpq+qw/5zLahT7rVurwpIVLVHJ0GJYdf5ykkDy4n uBU/NtycVghxUSSN7Kpt6/xlvAqhvSXkkoNICr5tgiwjFHwDH9hHDoT0QijH8RBNby mtNQ8GzvaZ0EjIf8pEdnNZ9MAlj4sMMrmW6jysmnBfO3KU9yooeXCUtgKyejZ6BBX9 WY5Y4Hlyt8+0a23yE16g/EQT80LQWMZKtad5K//dOxVYt95UyemVmUZKHSo6K7fwgS PgRZrvMK+wcManoBJgCpEbnzFkBOaxowhW32bXLIsHwId0zyRnCd3FhaH85b242sZu BO/N09LqQrrbg== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 2/7] hwmon: (it87) Disable configuration exit for certain chips Date: Thu, 26 Jan 2023 15:02:18 +1100 Message-Id: <20230126040223.986189-3-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:42 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org IT8790E and IT8792E/IT8795E have been identified as chips that can have issues when disabling configuration mode. Set to never exit configuration mode. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 7049e81f5af1..c5e46b94f0b8 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -2453,6 +2453,13 @@ static int __init it87_find(int sioaddr, unsigned short *address, break; case IT8792E_DEVID: sio_data->type = it8792; + /* + * Disabling configuration mode on IT8792E can result in system + * hang-ups and access failures to the Super-IO chip at the + * second SIO address. Never exit configuration mode on this + * chip to avoid the problem. + */ + doexit = false; break; case IT8771E_DEVID: sio_data->type = it8771; @@ -2474,6 +2481,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, break; case IT8790E_DEVID: sio_data->type = it8790; + doexit = false; /* See IT8792E comment above */ break; case IT8603E_DEVID: case IT8623E_DEVID: From patchwork Thu Jan 26 04:02:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116610 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FE0C54E94 for ; Thu, 26 Jan 2023 04:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbjAZEC4 (ORCPT ); Wed, 25 Jan 2023 23:02:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjAZECy (ORCPT ); Wed, 25 Jan 2023 23:02:54 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4F99493EA for ; Wed, 25 Jan 2023 20:02:52 -0800 (PST) IronPort-SDR: +ZBDV/WWHdNET8LtLiA+qXJL43EZseSRQlgygQvjo+MHv2fQZi+LhOrvZMxX2PT/9tL3cKzZrl BXTOo6fYSYwQUHyE4oewd7LYswUcGCyNgxIKVCDAvm//EOtVOi8jFUSgO1or73906tJd5JtpAW JKHMSVvjZ89bFLsi0cjV2l+RCVvGL6xcxJC+he37kbOnBl5GV94SbH7OEK0xjgcNE7km3pVWIa hnsBhDnRbYx4VBMuplI4xI8i96PUHvmfU6xe8+csuFh5PQtVSetcZ8FkZiDrZFTIRm1djUHtTg M8hhszgle2YZ6B2seybILm9F X-SMTP-MATCH: 0 X-IPAS-Result: A2B8AQCK+tFjjPQc8jxaHQEBAQEJARIBBQUBSYE1BQELAYIsgmC1Kw8BDwEBRAQBAYUGAoUjJjcGDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgQUAQEBAUBSBwtSBwtYBweBQQuBYRMLAzENhlYCAQMnCwENAQE3AQ8ZOFcGARKCfoMjrGMzgQGCCAEBBoJimmeBXgmBQAGLYIEUgzd6Qz+BToR9iwObPgqBOXiBJQ5MeoEPAgkCEYEsAwkDBwVJQAMLGA0WMgoTLDULC0oQGxobB4EGKigVAwQEAwIGEwMgAg0oMRQEKRMNJyZpCQIDIV8FAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeHHKBDpVejlehYoN8gVKefUyBRKdml00goxyEKwIKBxaBeIF/TR8ZO4JnTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dGYITjDhhOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:8YyZgBRr7MPjUFnwxSPDCIXqJNpso4vLVj580XJvo7hPbr/l9I7rI 0LY//krgVrUG4TXrftZ2KLfqau1X2sG7N6atWwaNoZBUhgZhIAXh1kuDMLfWxLyJfK4Y3BlT JYbBg1u9SjjY0NeQJmWWg== IronPort-Data: A9a23:Mc78faxe93F62Qf7GN16t+cDwCrEfRIJ4+MujC+fZmUNrF6WrkUFm GUaXz3VbP/bYmbzfdt2ao3k9B5UvZXQn9JiSgI6pCAxQ3kV+ZudDN2XcBz6ZXPJJJyaHBM25 ZpGZ4nJIM5vZ3KN/R3F3prJ9Ckkj/vULlbf5E8oHggrGGeInQ940UoLd9YR29Iu2Z7ja++0k YuaT/f3YTdJ5hYtWo4qw/LbwP9QlKyaVAMw5jTSstgW1LN2vyB94KM3fcldHVOhKmVnNrLSq 9L48V2M1jixEyHBqz+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRYRQR8/ttmHozx+4 Ptk7pi3bRo0Aqnviu0YThlHIwhAAYQTrdcrIVDn2SCS50fHb2CqyO9nE08xJ4Fe9+NqR2BCs /UFQNwPRk7bwbjqmvThGq822phLwMrDZevzvllu1zjfDt4tW5ncTaLQ6ZlV2Sp2h8wIFOu2i 88xNWY3PEWcOUcSUrsRIMsnwuWUhVPBSiB361W5qqNn5EPonTUkhdABN/KOIofaH58E9qqCn UrC/mLkElQaK9mYzxKb/X+2wOzChyX2XMQVDrLQ3vprhkCD7nYUBRYVEEag5/+0liaWWd5SL 1Id4CcGtrUp+QqgSdyVYvGjiCDc+0RAAZ8KQ6hgtF3L0bbd/weSQHQcQT8HY9sj8sYrLdA36 rOXt/3AXjholKCIdXa+5L6RsDOtCQErEUZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJ9dfYn WniQM8W2eh7sCIb60mo1RWc2GLz/8Shohodv1iOBDr9sGuVcab/P+SVBU7nAeFoBbvxorOph 2kIncWPhAzlJcvVzHTlrAklOry2r82CLSHcyWFmG5Q6nwlBFlb9JcUKvGs7fhcsaJpYPyT1a VPSskVN/JBSenCtaOl+fupd6vjGL4C8SbwJtdiONbKih6SdkyfdoklTiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymH9imzyKGcqkl0T8uVZ7WJJzYelcWLdpRr5khJ5oXC2Po r6zyuPQlE4GC7WuCsUp2dNDcwlSRZTEOXwGg5cPLb7ZeFsO9JAJF+feibInZ4F/malJ/tokD VnjMnK0PGHX3CWdQThmn1g/MNsDq74j9CxnVcHtVH70s0UejXGHs/pPLMdnLOF5nAGhpNYtJ 8Q4lwy7KqwnYlz6F/41NPERdaRuK0amgxygJS2gbGRtdpJsXVWZqNT+dxTh8zMCSCeyqI0/r /upy1qDE5YEQg1jCufQae6ulg3u5yFEw70sDkaYcMNOfEjM8ZRxL3KjhPEAI/YKdUfJyAyFh lSfDhovrOXQp5M4rYvSjqeeoob3T+ZzRxIIH2TS4busGzPd+26vnd1JXOqSJGCPX3n956ulf +kTwvThdvwL2l9X6tIuH7FuxKM4xt3uu74DkFs+RSyQMAr6B+o5cHec3MRJuqlc/ZNjuFO7C hCV591XGbSVI8e7QlQfEwoSaLjR3/8jhWiA5Ps4F0z2+Str8efVSk5VJRSN1nBQIbYpYoMox eAt5Jwf5wCl0EF4ONealWZf7W2TIHsaX+Mqs4xcAYOtgxdykgNOZpnVCynX5pCTaowSbRNze 2TL2vvP1+ZG207PU3svDnyTj+BTspQ5vkwYxlE1OAXbk9XIsfY7wRlN/GllVQ9S1BhGjb5+N zQ5LUFzPqnSrT5kiNIYBTLyQ0QbWEfcoBy0kQdV0nbFRlWpXSrRNGI8f+2K+QYQ7jsELDRc+ biZzkfjUCrrJZ+uhHJrAhE7+vGzH8Zs8gDimdy8G5jXFZcNZ2u3i6CjUmMEth/7DJ5jn0bAv +Rrorp9ZKCT2fT8eEHn51R2DYgtdS0= IronPort-HdrOrdr: A9a23:PIrpzan2llt4ddL2JStt2jzxAZ/pDfL23DAbv31ZSRFFG/Fw9/ rFoB3U737JYVEqKQgdcbLpAsS9qBbnmaKdjrNhXotKMDOIhILsFvAH0WKA+UyHJ8SBzJ8+6U 4IScEXY+EYT2IK6voSizPZLz9P+re6GC/Ev5an854Ud3AOV0h51XYENu+EKDwKeOCYP+tDKH JMjvA33QadRQ== X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:32:49 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5W1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:45 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5W1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705765; bh=72KEhg2VuK+8YcxrcFPd3+rUbQfNLdkE87+BGsoGkoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oULfo4EP7b0X10hcwtVrBuWxCW9XFVG1Lla7Gvp9GCFQKYGPXDnTH53vDQZODtsgg SM9zh733sEsSDJ1B1+h1IaZBOXKEAkLjYSi0ffTHlskAtPSLudVIhPOBhwA1k1VTGq 5sRbR6QywNixLbM9VUYZrUVS3hwVnVePIbz07wZsKLMyJNmIDaKqVN+WXKCPdEh34I 20M9MfNppWOYu2t9XzBfsOLsHl2vyVy+dj4HJ1RCRJDRIOvxZmM/Jy1m5wSe8bWGln 2miOykjlg1X7t+oFD2ZL3ExKbyofQRtPEDU4mWtXjvp+0saDLTiJfHdohUVDiDzCL1 l+hs/aINANrfg== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 3/7] hwmon: (it87) List full chip model name Date: Thu, 26 Jan 2023 15:02:19 +1100 Message-Id: <20230126040223.986189-4-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:45 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org ITE model names do not always match the chip ID. Convert from just adding a suffix to specifying the full model name. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index c5e46b94f0b8..16394b38dce3 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -277,7 +277,7 @@ static const u8 IT87_REG_AUTO_BASE[] = { 0x60, 0x68, 0x70, 0x78, 0xa0, 0xa8 }; struct it87_devices { const char *name; - const char * const suffix; + const char * const model; u32 features; u8 peci_mask; u8 old_peci_mask; @@ -306,24 +306,24 @@ struct it87_devices { static const struct it87_devices it87_devices[] = { [it87] = { .name = "it87", - .suffix = "F", + .model = "IT87F", .features = FEAT_OLD_AUTOPWM, /* may need to overwrite */ }, [it8712] = { .name = "it8712", - .suffix = "F", + .model = "IT8712F", .features = FEAT_OLD_AUTOPWM | FEAT_VID, /* may need to overwrite */ }, [it8716] = { .name = "it8716", - .suffix = "F", + .model = "IT8716F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, }, [it8718] = { .name = "it8718", - .suffix = "F", + .model = "IT8718F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, @@ -331,7 +331,7 @@ static const struct it87_devices it87_devices[] = { }, [it8720] = { .name = "it8720", - .suffix = "F", + .model = "IT8720F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, @@ -339,7 +339,7 @@ static const struct it87_devices it87_devices[] = { }, [it8721] = { .name = "it8721", - .suffix = "F", + .model = "IT8721F", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_IN7_INTERNAL @@ -349,7 +349,7 @@ static const struct it87_devices it87_devices[] = { }, [it8728] = { .name = "it8728", - .suffix = "F", + .model = "IT8728F", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -357,7 +357,7 @@ static const struct it87_devices it87_devices[] = { }, [it8732] = { .name = "it8732", - .suffix = "F", + .model = "IT8732F", .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL, @@ -366,7 +366,7 @@ static const struct it87_devices it87_devices[] = { }, [it8771] = { .name = "it8771", - .suffix = "E", + .model = "IT8771E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -378,7 +378,7 @@ static const struct it87_devices it87_devices[] = { }, [it8772] = { .name = "it8772", - .suffix = "E", + .model = "IT8772E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -390,28 +390,28 @@ static const struct it87_devices it87_devices[] = { }, [it8781] = { .name = "it8781", - .suffix = "F", + .model = "IT8781F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8782] = { .name = "it8782", - .suffix = "F", + .model = "IT8782F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8783] = { .name = "it8783", - .suffix = "E/F", + .model = "IT8783E/F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8786] = { .name = "it8786", - .suffix = "E", + .model = "IT8786E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -419,7 +419,7 @@ static const struct it87_devices it87_devices[] = { }, [it8790] = { .name = "it8790", - .suffix = "E", + .model = "IT8790E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -427,7 +427,7 @@ static const struct it87_devices it87_devices[] = { }, [it8792] = { .name = "it8792", - .suffix = "E", + .model = "IT8792E/IT8795E", .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL, @@ -436,7 +436,7 @@ static const struct it87_devices it87_devices[] = { }, [it8603] = { .name = "it8603", - .suffix = "E", + .model = "IT8603E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_AVCC3 | FEAT_PWM_FREQ2, @@ -444,7 +444,7 @@ static const struct it87_devices it87_devices[] = { }, [it8620] = { .name = "it8620", - .suffix = "E", + .model = "IT8620E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2 @@ -453,7 +453,7 @@ static const struct it87_devices it87_devices[] = { }, [it8622] = { .name = "it8622", - .suffix = "E", + .model = "IT8622E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS | FEAT_FIVE_PWM | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2 @@ -462,7 +462,7 @@ static const struct it87_devices it87_devices[] = { }, [it8628] = { .name = "it8628", - .suffix = "E", + .model = "IT8628E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2 @@ -2520,8 +2520,8 @@ static int __init it87_find(int sioaddr, unsigned short *address, err = 0; sio_data->sioaddr = sioaddr; sio_data->revision = superio_inb(sioaddr, DEVREV) & 0x0f; - pr_info("Found IT%04x%s chip at 0x%x, revision %d\n", chip_type, - it87_devices[sio_data->type].suffix, + pr_info("Found %s chip at 0x%x, revision %d\n", + it87_devices[sio_data->type].model, *address, sio_data->revision); config = &it87_devices[sio_data->type]; From patchwork Thu Jan 26 04:02:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C1DC61D9D for ; Thu, 26 Jan 2023 04:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229536AbjAZEC5 (ORCPT ); Wed, 25 Jan 2023 23:02:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjAZECz (ORCPT ); Wed, 25 Jan 2023 23:02:55 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8E88D2D72 for ; Wed, 25 Jan 2023 20:02:53 -0800 (PST) IronPort-SDR: ldxoz8I1hk9ezsQU93YclsKp240Y6Any6P0e3WpZht2X2pESl8uYDhvM3/WWoWNSLPF1umgQRw NwU8msGtf2dDCUrnOYB/IiQasRvBRLrTY3UYdWKVxjL/xye+Tk3Zg0JuWe4v7vGE9OsHV+zQp7 UXgsumIE3BtPNJgJ9xsZzsOBhOaSkm16pkju7Whj9qkysP+vOXNKdgWFBhnoBdlWFyJ9FZcj2E RteIscJpnyIFbBCKlrspNYJ3rI0JTjqqzPlJnErR+8r/zyR+i/TYfSvoGN6LZjPWo5y3QwRIRb FtL9xZnUIc0VdmoW8d59s3ot X-SMTP-MATCH: 0 X-IPAS-Result: A2C4AACK+tFjjPQc8jxaHQEBAQEJARIBBQUBSYE0BgELAYIsgmCzLYF+DwEPAQFEBAEBhQYChSMmNgcOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBBQBAQEBQFIHC1IHC1gHB4FBC4FhEwsDMQ2GVgIBAzIBDQEBNwEPGThXBgESgn6DI60WgQGCCAEBBoJimmeBXgmBQAGLYIEUgzd6Qz+BToR9iwObPgqBOXiBJQ5MeoEPAgkCEYEsAwkDBwVJQAMLGA0WMgoTLDULC0oQGxobB4EGKigVAwQEAwIGEwMgAg0oMRQEKRMNJyZpCQIDIV8FAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeFAhygQ6BJ8Rwg3yBUp59TIFEp2YtlyAgoxyEKwIKBxaBaQaCCE0fGYMiTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dGYITjDhhOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:fdi85h0haJsooluysmDPn1BlVkEcU/3cNA8J8dwskbtRfKO589LvO VGZ5PkrhUKaFYzB4KdCjOzb+7vlRXRG+5uEt2wPNZ1UAhEJhZ9EwAUpDJyJVRKrfqe4PScwR ZwQX1Q9oBmG IronPort-Data: A9a23:VRRacKpPUHHAPat5FfsxM9I27U9eBmIsYxIvgKrLsJaIsI4StFCzt garIBmOaPmCYzPzKd8lPITlpB8GsMPVztNhGQtkpS42F34Qo8SdX4SXIhn9ZnqeJ8OeQUw9v 8lCZNLJd5llFHXQrE71G7Ww9nMUOYOgH+qkUrSYUsxSqa6IbA971HqPTsZg2tYAbeCRWl/L4 ZWoyyHmEAfNNwRcawr41orawP9RlKSq0N8nlgRWicBj5DcyQFFIZH63DfjZw0rQGuG4LMbjL wrw5O3RElfiwvsYIojNfoAX06E9auW60QCm0hK6UkU56/RIjnRaPq0TbJLwZarL4tmEt4gZ9 TlDiXC/YSQXJO7iv9wmbx1VLix5baF31fjBeWfq5KR/z2WeG5ft6/9vEFpwNpcR5ehwG20I+ PkFbjEBKBme7w606OzjDLMw3IJ5fI+xYN93VnJIlFk1Cd4oW5nFQI3B/9ZH0jAqioZDGOuYZ sZfYCcHgBHoP0EXagZLUshv9AuurifucAFy+XGzmbUIxm70kAda7JTrNNWAL7RmQu0Oxh3I/ DiXl4jjOTkeNdqC2X+F7XergMfRki7hHoEfDru18rhtmlL77mgSDgAGfUG8rPK6z1OlHdRSN yQ8+CYjqbY77kGDVcTmUluzp3vsg/IHc4QIVrdmskTXmu+Ov1rfHXQNUj9KLsA+u85wTjsvk FaU9z/0OdBxmJ6rUzGz0Y+vkTe/BCUSfWMzSGgCFRRQtrEPv7oPph7IS99iFou8gdv0BSz8z li2QM4W2ex7YSkjifjTwLzXv96/jt2SFV5qv1m/snaNt14gPtb9OeRE/HCBtZ59wJClok6pl UVsdyK21/ECC5yc/MBmaL9VROnBCxqtFjDDyWVoAoUhvwuk/3O4Fb28DRkgfAIzbpxBI2+sO hOP/xhN7YNSNz22daB2JYm2DoIj0MAM9OgJtNiIMrKigbArL2drGR2CgmbKgQjQfLAEy/1XB HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8+nkUv+jeDBPC7OIVvgDLdoRr5ghE9jiFuIm +uzy+PQmn2zrcWkPXKOqtZDRbz0BSVrW8muwyCoSgJzClE+QzF7Ua65LUIJZ5Rq16VTiurS+ HyhMnK0O3Kh7UAr3T6iMyg5AI4DqL4j9RrXywRwZAj0s5XiCK7zhJoim2wfIuR3r7AznKYqJ xTHEu3Zaslypv3802x1RfHAQEZKLnxHXCqCYHioZiYRZZllS1Cb89PoZFK/piIUBzW5stEy5 bCly0XaTdwKWl06XsrRbfuuyXK3vGQcwbwtBRKReYYMI0i8opJ3LyHRj+MsJ59eIxv0xgyci 1ScDyAH9LvErIIC+dXUgbyJ8tWyGOxkE0sEQ2TWtO7kNSTT8me575VHVeKEIWLUWG/uofXwb v9c0P/7KvFBkVNX9YtwVb92lPps69zqrr5c7wJlAHSSMQvxU+o7fSbd0JAW5KNXx7JftQ+nY W61+4FXaeeTJcfoMF8NPw57PO6N4vEjnGWA5/oCPxSo7SB6y7OLTEFOMkTekydaNrZ0bt8oz Op96s4b7wuz1kgjPtqc1HsG/WWQNToLSaw4uJYADMnmjxdty10EaIGFUn3655SGatNtNEg2I 2bK2/Cb3u8DmRHPIygpCHzA/etBnpBQ6hpE+181IQjbkNTyma5l1RJcxj07UwBJw0gVyOl0I GVqaRF4KPnc5Ttun8QfDWmgFxsaXk/HogmrlwFMzj2cFRX0EHfRJXE8MqCR5E8YtWlbe35S4 ejAmmriVD/reuD33zczABA68aW6FoMurQCSytq6G8mlHoUhZWa3iKGZYztaohTqNso9mUnbq LQ45+13c6D6a3IdrqBT51N2DljMpM1o/FB/fMw= IronPort-HdrOrdr: A9a23:k8E2eqG3lc9SoJY1pLqEMseALOsnbusQ8zAXPiBKIyC9vPb4qy nIpoVj6feX4Ax9ZJhEo7y90ca7MBDhHPJOjrX5eI3SODUO21HYSr2Kk7GSoQEIcheWnoVgPO VbAs9D4bbLbWSS4/yV3OE2fuxQuOVviJrY4Ns2100dMT2CdZsQkjuR1TzraXGflWF9dOAEKK Y= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:32:53 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5X1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:49 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5X1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705769; bh=j4miW7H4JfEp13E/Sj+Qly/9lxdu3kxkwxQBCQkViUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i60qvMCZuSX4Uw98nH/pp69i6JPiyGjAJ4RpXZ67b/8WDtPqwA3V4oC5tVASY6ExC rzrHwf44LRhkNnUEwKafXXO2rqpMBYnUC359gqImyA7fh0mF13zkvdmMJ2pmHCpkPJ 6j3bTQVRrlPV3OkyYeT3UuafTgVn3k2Dp0oTs8KRfRcr+mUVIKnvSUGolR/QbUSeFp hSfasCnI4kBTiUpe4ahJEZzkPHSU7OD6h+FVi0yUld+wtqe5Easmc8RWpb+Yf2BV7/ im5LjAZprXA+fniw/DWAiyeFLmt7mRhOdzlj7VXErsWg3n9K9GbTSlmi3SMCsqMedt U096iY+q5FzIA== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 4/7] hwmon: (it87) Add chip_id in some info message Date: Thu, 26 Jan 2023 15:02:20 +1100 Message-Id: <20230126040223.986189-5-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:49 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org In cases where there are multiple chips, print out which chip is referred to, in the informational message. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 16394b38dce3..5ca8449887da 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -2505,13 +2505,15 @@ static int __init it87_find(int sioaddr, unsigned short *address, superio_select(sioaddr, PME); if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) { - pr_info("Device not activated, skipping\n"); + pr_info("Device (DEVID=0x%x) not activated, skipping\n", + chip_type); goto exit; } *address = superio_inw(sioaddr, IT87_BASE_REG) & ~(IT87_EXTENT - 1); if (*address == 0) { - pr_info("Base address not set, skipping\n"); + pr_info("Base address not set (DEVID=0x%x), skipping\n", + chip_type); goto exit; } From patchwork Thu Jan 26 04:02:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D34DC05027 for ; Thu, 26 Jan 2023 04:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbjAZEDC (ORCPT ); Wed, 25 Jan 2023 23:03:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjAZEDB (ORCPT ); Wed, 25 Jan 2023 23:03:01 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E78501EFC9 for ; Wed, 25 Jan 2023 20:02:59 -0800 (PST) IronPort-SDR: MZj+GfMCPsurV3sP7bBvVEmZCwW3gKIzqJUiEtcIxWInBGSpg+Cj3/acKfIOVEfHHrS39KF/DV A3qNWbmYfunhwvO9uUq4Yh7X7JJBbICoBNxAOTbQnW7OZREvAyGofZAiyphH4+xh73jXkIfgh1 owyiz6AsMmZTyknxUMPs2YzX86VDly6tkiMhs2Enpm4Eqd8huxvV1uBO5434CXMV9UCLLUCtVO zSDRc33KkPcYISJjcTzTfuQY842g1geXygFiDfBLXBavNEtUohoJFZc9jKIEL5qVAI6rTNggoN gjadn24aR3jSkIa7I6NRNaAA X-SMTP-MATCH: 0 X-IPAS-Result: A2C5AACK+tFjjPQc8jxaHQEBAQEJARIBBQUBSYE0BgELAYIsgmCVbZ1AgX4PAQ8BAUQEAQGFBgKFIyY2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEFAEBAQFAUgcLUgcLWAcHgUELgWETCwMxDYZWAgEDMgENAQE3AQ8ZOFcGARKCfoMjrRaBAYIIAQEGgmKaZ4FeCYFAAYtggRSDN3pDP4FOgRWBPIIsiwOOCI02CoE5eIElDkx6gQ8CCQIRgSwDCQMHBUlAAwsYDRYyChMsNQsLShAbGhsHgQYqKBUDBAQDAgYTAyACDSgxFAQpEw0nJmkJAgMhXwUDAwQoLQk/ByYkPAdWNwYCDx83BgMJAwIfT3EvEhIFAwsVKkcECDYFBhw2EgIIDxIPLEQOQjc0EwZcASkLDhEDUEcZbgSCEQYpJp4cawYBLSY7MHfEcIN8gVKefUyBRKZcgQotlyAgoxyEKwIKBxaBaQyCAk0fGYMiTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dDA0JggqMOGE7AgcLAQEDCYwjAQE IronPort-PHdr: A9a23:QdrHbxfKc0WbODtYH3yurkY+lGM/hYqcDmcuAtIPgbNSaeKo5Z39M kvF6bNgiUKPXImd4u8Xw+PMuPXmXmoNqY2ErGhEapFJUAMIzMQOygIsDJTXVkTyIKzmM3NqT p0QBlRvpinpOkMNR67D IronPort-Data: A9a23:OZBkxawMa+9tS1WfGBh6t+cDwCrEfRIJ4+MujC+fZmUNrF6WrkUEn 2FMDW6CPauOMWSjedkkO43l/B8D65CHn9MxSgY6/Ck2ES4X+JLMCIzFcRqqNHLMIMacHRpq4 5pDZISaIco6Z3KN/R3F3prJ9Ckkj/vULlbf5E8oHggrGGeInQ940UoLd9YR29Iu2Z7ja++0k YuaT/f3YTdJ5hYtWo4qw/LbwP9QlKyaVAMw5jTSstgW1LN2vyB94KM3fcldHVOhKmVnNrLSq 9L48V2M1jixEyHBqz+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRYRQR8/ttmHozx+4 PRM6LP3VgglBKjRtt5EdyNpKwNwG7ITrdcrIVDn2SCS50fHb2CqyO9nE08xJ4Fe9+NqR2BCs /UFQNwPRk7bwbjqmvThGq822phLwMrDZevzvllu1zjfDt4tW5ncTaLQ6ZlV2Sp2h8wIFOu2i 88xNWY3PEWcOUYQUrsRIKkvtsW4nCnNSjMG8gqQ+bUs/Vj50hMkhdABN/KOIofaH58E9qqCn UrC/mLkElQaK9mYzxKb/X+2wOzChyX2XMQVDrLQ3vprhkCD7nYUBRYVEEag5/+0liaWWd5SL 1Id4CcGtrUp+QqgSdyVYvGjiCDc+0RAAZ8KQ6hgtF3L0bbd/weSQHQcQT8HY9sj8sYrLdA36 rOXt/LoWBMor7KZc3eA2I3NiQmDAQobC3BXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJ9dfYn WniQM8W2eh7sCIb60mo1RWc2GLz/8Shohodv1iOBDr9sGuVcab/P+SVBU7nAeFoBbvxorOph 2kIncWPhAzlJcvVzHTlrAklOry2r82CLSHcyWFmG5Q6nwlBFlb9JcUKvGs7fhcsaJpYPyT1a VPSskVN/JBSenCtaOl+fupd6vjGL4C8SbwJtdiONbKih6SdkyfdoklTiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymH9imzyKGcqkl0T8uVZ7WJJzYelcWLdpRr5khJ5oXC2Po r6zyuPQlE4GC7WuCsUp2dNDcwlSRZTEOXwGg5cPLb7ZeFsO9JAJF+feibInZ4F/malJ/tokD VnjMnK0PGHX3CWdQThmn1g/MNsDq74j9CxnVcHtVH70s0UejXGHs/pPLMdnLOF5nAGhpNYtJ 8Q4lwy7KqwnYlz6F/41NvERdaRuK0amgxygJS2gbGRtdpJsXVWZqNT+dxTh8zMCSCeyqI0/r /upy1qDE5YEQg1jCufQae6ulg3u5yFEw70tAUaYcMNOfEjM8ZRxL3KjhPEAI/YKdUfJyAyFh lSfDhovrOXQp5M4rYvSjqeeoob3T+ZzRxIIH2TS4busGzPd+26vnd1JXOqSJGCPX3n956ulf +kTwvThdvwL2l9X6tIuH7FuxKM4xt3uu74DkFs+RSyQMAv1B+o5cHec3MRJuqlc/ZNjuFO7C hCV591XGbSVI8e7QlQfEwoSaLjR3/8jhWiA5Ps4F0z2+Str8efVSk5VJRSN1nBQIbYpYoMox eAt5Jwf5wCl0EF4ONealWZf7W2TIHsaX+Mqs4xcAYOtgxdykgNOZpnVCynX5pCTaowSbRNze 2TL2/TP1+ZG207PU3svDnyTj+BTspQ5vkwYxlE1OAXbk9XIsfY7wRlN/GllVQ9S1BhGjb5+N zQ5LUFzPqnSrT5kiNIYBTLyQ0QbWEfcoBy0kQdV0nbFRlWpXSrRNGI8f+2K+QYQ7jsELDRc+ biZzkfjUCrrJZ+uhHJrAhE69fGzH8Zs8gDimdy8G5jXFZcNZ2u3i6CjUmMEth/7DJ5jn0bAv +Rrorp9ZKCT2fT8eEHn51R2DYgtdS0= IronPort-HdrOrdr: A9a23:igPjWqGxs6i4lOq6pLqEMseALOsnbusQ8zAXPiBKIyC9vPb4qy nIpoVj6feX4Ax9ZJhEo7y90ca7MBDhHPJOjrX5eI3SODUO21HYSr2Kk7GSoQEIcheWnoVgPO VbAs9D4bbLbWSS4/yV3OE2fuxQuOVviJrY4Ns2100dMT2CdZsQkjuR1TzraXGflWF9dOAEKK Y= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:32:56 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5Y1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:52 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5Y1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705773; bh=BiiMcgP26Vs6FZg97hrCL0vSKFwCY4LST4qXAGKxIG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uh/wmD1bQ9+vAsdCnS2cRlyLdf4TAtTm1yI+2MKm9gtLSYQZEqLCkj57X+uUNu+9u QN7v+uaA2wRfAmRxYlVAFBxJ927e2k9ZVVgDJxtLdAcCwlL6FwWNpK3Qwk3ZjSbnaS Yx59MWf+Dg9s76g2sIh/uyurRS+vHYFnIuGjmMfgaf/imm7A/MR9VA32gfwk4Q9dVd L2PuTH171qVc9ONx1J0wMJld2ljdt5r8coSztw96QH3vq2ZR5fQmirXyjfDm72TF+e 6/Fb/EEWBCkh4APHhZlECbuYO6UNehk0O+OZaAarFLqlMzD57vwkXZmkzZKSgm++FW HU3MUzWImlzVQ== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Date: Thu, 26 Jan 2023 15:02:21 +1100 Message-Id: <20230126040223.986189-6-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:53 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Extend the force_id module parameter to allow specifying one or both chip IDs separately. If only a single parameter is given it defaults to using that value for all chips, similar to previous usage. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 5ca8449887da..e8eeedd23bee 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -175,8 +175,9 @@ static inline void superio_exit(int ioreg, bool doexit) #define IT87_SIO_VID_REG 0xfc /* VID value */ #define IT87_SIO_BEEP_PIN_REG 0xf6 /* Beep pin mapping */ -/* Force chip ID to specified value. Should only be used for testing */ -static unsigned short force_id; +/* Force chip IDs to specified values. Should only be used for testing */ +static unsigned short force_id[2]; +static unsigned int force_id_cnt; /* ACPI resource conflicts are ignored if this parameter is set to 1 */ static bool ignore_resource_conflict; @@ -2405,7 +2406,7 @@ static const struct attribute_group it87_group_auto_pwm = { /* SuperIO detection - will change isa_address if a chip is found */ static int __init it87_find(int sioaddr, unsigned short *address, - struct it87_sio_data *sio_data) + struct it87_sio_data *sio_data, int chip_cnt) { int err; u16 chip_type; @@ -2422,8 +2423,12 @@ static int __init it87_find(int sioaddr, unsigned short *address, if (chip_type == 0xffff) goto exit; - if (force_id) - chip_type = force_id; + if (force_id_cnt == 1) { + /* If only one value given use for all chips */ + if (force_id[0]) + chip_type = force_id[0]; + } else if (force_id[chip_cnt]) + chip_type = force_id[chip_cnt]; switch (chip_type) { case IT8705F_DEVID: @@ -3426,7 +3431,7 @@ static int __init sm_it87_init(void) for (i = 0; i < ARRAY_SIZE(sioaddr); i++) { memset(&sio_data, 0, sizeof(struct it87_sio_data)); isa_address[i] = 0; - err = it87_find(sioaddr[i], &isa_address[i], &sio_data); + err = it87_find(sioaddr[i], &isa_address[i], &sio_data, i); if (err || isa_address[i] == 0) continue; /* @@ -3475,8 +3480,8 @@ static void __exit sm_it87_exit(void) MODULE_AUTHOR("Chris Gauthron, Jean Delvare "); MODULE_DESCRIPTION("IT8705F/IT871xF/IT872xF hardware monitoring driver"); -module_param(force_id, ushort, 0); -MODULE_PARM_DESC(force_id, "Override the detected device ID"); +module_param_array(force_id, ushort, &force_id_cnt, 0); +MODULE_PARM_DESC(force_id, "Override one or more detected device ID(s)"); module_param(ignore_resource_conflict, bool, 0); MODULE_PARM_DESC(ignore_resource_conflict, "Ignore ACPI resource conflict"); From patchwork Thu Jan 26 04:02:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06469C54E94 for ; Thu, 26 Jan 2023 04:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbjAZEDE (ORCPT ); Wed, 25 Jan 2023 23:03:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjAZEDD (ORCPT ); Wed, 25 Jan 2023 23:03:03 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C0B8F12042 for ; Wed, 25 Jan 2023 20:03:01 -0800 (PST) IronPort-SDR: 0wxu9zT8UyCLwHes9Hdoigz1kqQPKS+HFIwmq+VEbpdnNijNRLlStFLBAuYa1d8IPEE2TcuCtN mGAZX9IV+JUfxQYD2MZ1vRor/Ytl6evlqX1C4XAQ+4qXQHaEJG8vOwel5M4PP7/ysJlqggk3pw YjIwmN3SV4sfXwlWI9OXTHNo5zL8p5zO8+6TpQ5KYABMqX7buhn5lpPcmZmh5UuAjcM7nwqXuM xoRRtGQP5Ji7JpPR9wBvkoMy7D9gFf26JAHK6TECX0aQCxFxRFov17500nF9jEIJzM/KLg29YT wMIzu5O8/k04NfwpqQRzUXOM X-SMTP-MATCH: 0 X-IPAS-Result: A2B8AQCK+tFjjPQc8jxaHQEBAQEJARIBBQUBSYE1BQELAYIsgmCzQYFqDwEPAQFEBAEBhQYChSMmNwYOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBBQBAQEBQFIHC1IHC1gHB4FBC4FhEwsDBAglDYZWAgEDJwsBDQEBNwEPGThXBgESgn6DI6xjM4EBgggBAQaCYppngV4JgUABi2CBFIM3ekM/gU6CUYIsgQWDAgSGeI4IjTYKgTl4gSUOTHqBDwIJAhGBLAMJAwcFSUADCxgNFjIKEyw1CwtKEBsaGweBBiooFQMEBAMCBhMDIAINKDEUBCkTDScmaQkCAyFfBQMDBCgtCT8HJiQ8B1Y3BgIPHzcGAwkDAh9PcS8SEgUDCxUqRwQINgUGHDYSAggPEg8sRA5CNzQTBlwBKQsOEQNQRxluBIIRBikmnhxrB4EOpDWhYoN8gVKefUyBRKdml00goxyEKwIKBxaBeIF/TR8ZgyJPAQIBAQENAQIBAQMBAgEBAQkBAQEBgTOMagwLAgmCCow4YTsCBwsBAQMJiUqCWQEB IronPort-PHdr: A9a23:WzaKjBxHW4CFrPfXCzPpngc9DxPP853+PxIOrJE9gq1Adb6vuZnnI Qre6bNkkQyBVJ/QvvRDjeeeqKX8QSoa7JOGrH1HcYQZWRMJ05dJlgUsUsLZVh2pday4ZCZjR JZJXwc6l0w= IronPort-Data: A9a23:HDoSnKuZPS43na0QsM+aj21Y2+fnVGJYMUV32f8akzHdYApBsoF/q tZmKTiBMvaKYTGheNElOo3j9koAu5bXy4I3S1dopHsxQnwaosSdWIqVIBqgY3LLIMaeEx5r4 cwTM4jMJ849RyGEqEyEP+m6pxGQ94nRFuKmUrKs1gOd5ONAYH184f62s7dh2uaEufDgX0XV/ 4maT/T3YDdJ4RYtWo4pw/vrRC1H7KyaVAww5jTSVdgT1LMJvyR94Do3fMldHlOgKmVmNrfSq 9XrkNlVyljkEyIFUbtJpFpannoiGdY+NSDW4pZftjPLbhJq/kTe2Y5jXBYQhNs+Zzihx7hMJ NtxWZOYZDoyb4rQveInDEcbFQclYp9l2biaPi3q2SCT5xWun3rEyfRyFwc9J4QH9OFtDSdD8 OFeKTxLZw3ra+Cenur9ELU2wJ5zapO3YOvzuVk5pd3dJfg8SJbAa67Q7MBW2y08wM1LALDfa 4wQdFKDaTycP0UfawtNU8JWcOGAtiPQWjJAiFuunoE+3U7awj1VzZLoL4+AEjCNbZ4NxRbC/ DOuE37CKhUbMsGPjDqa93WqrvHAkDm9W48IErC8sPlwjzW7wm0VFQ0+T1y2qvr8l1X4Xd9DQ 2QW9icqs6Eo+WSwU8LwGRa/pRa5UgU0BYIVSbFgrVvdj/CIv0CCGmEYTzUHdMQptYk9Qjls3 0Lhc87V6SJHnYCOGFWB07Gu8m3xPw5Ocl0hRChZUl5QizX8m70bghXKR9dlNae6iNzpBD39q wxmSgBg3t3/auZVis2GEUD7byGE48OSHlFsum07Skr8s1ojPNb7D2C9wQKDhcusOrp1WXGog RDoceCl/ewIAIDleMelGr1VRNlFC96jPSKUullyA5lpyD2p9mXLQGy9yG8mYR01aINeKXqzP BOVoh9Y+J5YemeyYq4xaIW0Tc03pUQBKTgHfqyIBjatSsIqHONiwM2JTRTOt10BaGB2zckC1 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGsylkE37i+XGNCX9pVI53L2mMLlRAESs/li9z jqjH5Hbo/mieLehOXCMqd57wa4icChlXMieRzNrmh6reVI9SDt7Wpc9MJs9Y4MtnqJJm/3O8 23VZ6Or4ASXuJEzEi3TMioLVV8adconxZ7NFXB1YwrANrlKSdrH0ZrzgLNoIOl8qLwylaAco jtsU5zoP8mjgw/vo1w1BaQRZqQ7HPhyrQ7RbSejfhYleJtsG17A9tP+J1u9/zMHESSwr8d4r ri9kALXB5MeHlwwAMHTYfOp7lWwoXlExr0oBhKTfYkLdRW+6pVuJgzwkuQzfZMGJyLD8T3Gh QyYNghJ9+DCrrg8/MTNma3Z/ZyiFPFzHxQGEmSCteS2OCDW83CN24hFVOrULznRWHmtqPepf +xKwfbmPLsKmUsMsoY6GqsylfAy4N7mprl7yAV4HSyVMA7yU+g/ciGLhJAduLdMy7lVvRqNd niOotQKa6+UPM7FEUIKIFR3ZOq01cYSxmvY48MqcRfz6yJA9baaVVlfYkuXgytHIborbI4oz LtzuMMS7ADj2BMmPszc1XJe9niXaHcaWropsYsWRoLul0wqxhdLfMWEWCPx5ZiObfRKM1Ure 2HL3vOb3OsMnkeSIWAuEXXt3PZGgcpcsh59zGgEewaDlO3a160+0xBm+DgqShhYk0dc2OVpN 2k1a0B4efeU8zFziJQRVmygAVobVkPBvxatkR5TxCiDExXuTXDEMGw2f/qV80Ff+GVZODFGp enKxGHgWDfsXcfwwiprBxE/8qW4Eowp+12Qgt2jEuSEA4I+PWjvjJioNDgBpBbQCM8sgFHK+ Ltx9+FqZKylaSMdrsXX0WVBOWj8lfxcGFF/fA== IronPort-HdrOrdr: A9a23:9D4sFanxRDAY0MI7lORbdXjtvj7pDfL23DAbv31ZSRFFG/Fw9/ rFoB3U737JYVEqKQgdcbLpAsS9qBbnmaKdjrNhXotKMDOIhILsFvAH0WKA+UyHJ8SBzJ8+6U 4IScEXY+EYT2IK6voSizPZLz9P+re6GC/Ev5an854Ud3AOV0h51XYENu+EKDwKeOCYP+tDKH JMjvA33QadRQ== X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:33:00 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5Z1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:56 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5Z1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705776; bh=tdQZHnX3FSPggPw9g2HOssmXYd+rzqSj9YmgIAzCZzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TqVXUr7uO5GGuWOI6m29wZJtyJCrVWRojws8W29lIavmeb14wYWVqTMeiW4E9Y2SJ +S18zJCRBFG+wAlWhjEDKC3kYCvOw2NQpkpC0+4LmNchLRyP45G2rajgNBqOUlo9yM TKgXtD47yYJTys0YpCORUv6RiKi9ICrXqwU8j+twAHm/NdjkQ01F8M46UC1f5xkKmn +JYXeu4H05obRtrJmeKNI0MXH2kqA2c7cAxQ8K27m53cL8VayyK0W4NUeEI7r9gCEH zu3h2XzYeF7nuiutxWM9R2/rOKaM91r608v5N68+uyysfCfgPXd+9r78eszT9k+G/f yd+XDn2uXovqA== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 6/7] hwmon: (it87) Add new chipset IT87952E Date: Thu, 26 Jan 2023 15:02:22 +1100 Message-Id: <20230126040223.986189-7-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:02:56 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Add IT87952E, a new chip ID (DEV ID 0x8695), which appears to be an updated version of the IT8792E and takes the same configuration. The model name comes from the model name printed on the chip. There is no datasheet publicly available. Signed-off-by: Frank Crawford --- drivers/hwmon/it87.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e8eeedd23bee..85ecc61dbf9e 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -34,6 +34,7 @@ * IT8786E Super I/O chip w/LPC interface * IT8790E Super I/O chip w/LPC interface * IT8792E Super I/O chip w/LPC interface + * IT87952E Super I/O chip w/LPC interface * Sis950 A clone of the IT8705F * * Copyright (C) 2001 Chris Gauthron @@ -63,7 +64,7 @@ enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8732, it8771, it8772, it8781, it8782, it8783, it8786, it8790, - it8792, it8603, it8620, it8622, it8628 }; + it8792, it8603, it8620, it8622, it8628, it87952 }; static struct platform_device *it87_pdev[2]; @@ -160,6 +161,7 @@ static inline void superio_exit(int ioreg, bool doexit) #define IT8622E_DEVID 0x8622 #define IT8623E_DEVID 0x8623 #define IT8628E_DEVID 0x8628 +#define IT87952E_DEVID 0x8695 #define IT87_ACT_REG 0x30 #define IT87_BASE_REG 0x60 @@ -470,6 +472,15 @@ static const struct it87_devices it87_devices[] = { | FEAT_SIX_TEMP | FEAT_VIN3_5V, .peci_mask = 0x07, }, + [it87952] = { + .name = "it87952", + .model = "IT87952E", + .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS + | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI + | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL, + .peci_mask = 0x07, + .old_peci_mask = 0x02, /* Actually reports PCH */ + }, }; #define has_16bit_fans(data) ((data)->features & FEAT_16BIT_FANS) @@ -2501,6 +2512,10 @@ static int __init it87_find(int sioaddr, unsigned short *address, case IT8628E_DEVID: sio_data->type = it8628; break; + case IT87952E_DEVID: + sio_data->type = it87952; + doexit = false; /* See IT8792E comment above */ + break; case 0xffff: /* No device at all */ goto exit; default: From patchwork Thu Jan 26 04:02:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13116614 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6235EC05027 for ; Thu, 26 Jan 2023 04:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbjAZEDM (ORCPT ); Wed, 25 Jan 2023 23:03:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjAZEDL (ORCPT ); Wed, 25 Jan 2023 23:03:11 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 36DB02D72 for ; Wed, 25 Jan 2023 20:03:10 -0800 (PST) IronPort-SDR: psbGyEhsS9L2cm2XCYpJ2mjSx8cqU8nIK3n8hgq2XauspANQRdRhDTlLAhr1Ve4RZI7BTGbKSI D2yD0mFh8pStxN2U8hP+bMn0iNNPDX3KjiomDVTO0zPZKHipGY8N5OC6H0kIelm39Yqi6cLNCE nw+t89jQhrlxQ8e44O9609CTQnyntK0B1LQ9+89vMDGIPSjGJ2bXxu+wU1Xs4izVqkogSNdpCI 7xuUdzHbDCi+vfyBVNEXRLXqCHz0gXhOZScIQ3iZul9ILboA0ETa0DaQS90mg0RU4paBAsGtG7 EaY6tLtRhsGpszeSgDsDpvCY X-SMTP-MATCH: 0 X-IPAS-Result: A2A1BgCK+tFjjPQc8jxaHgEBCxIMSYE7C4ItgmCVbZ1AgX4PAQ8BAUQEAQGFBgKFIyY2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEFAEBAQFAUgcLUgcLWAcHgUELgWETCwMECCUNhlYCAQMyAQ0BATcBDxk4VwYBEhmCZYMjrRaBAYIIAQEGgmKaZ4FeCYFAi2GBFIM3ekM/gU6BFYE8gT5uhAElEYYqIo4IjTYKgTl4gSUOTHqBDwIJAhGBLAMJAwcFSUADCxgNFjIKEyw1CwtKKxobB4EGKigVAwQEAwIGEwMgAg0NGzEUBCkTDScmJkMJAgMhXwUDAwQoLQk/ByYkPAdWNwYCDx83BgMJAwIfT3EvEhIFAwsVKkcECDYFBhw2EgIIDxIPLEQOQjc0EwZcASkIAw4RA1BHGW4EghEGKSafBwcOHBNRgSeBKRmSdRytaX6BNoN8gVKefUyBRII1jF+GaJFqhRaPYYJWIKIEgRiEKwIKBxaBaQKCDE0fGTuCZ08BAgEBAQ0BAgEBAwECAQEBCQEBAQGCBIwZGYITjDhhOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:jp1W+BbJVNvQXNmoc+wTLmz/LTAZhN3EVzX9orItiq5VNK+59ovsO 1bTo/hokRnIUcPS9qEMgvDd5qbnX2FI+pOdqDYYfZlLSxJAiN1DkQAsWpzaAET3fvK2MHxoR ZYQX1U8pyOwOhAKcPs= IronPort-Data: A9a23:2znzwaz8i8Aa7tAutBZ6t+cDwCrEfRIJ4+MujC+fZmUNrF6WrkVVm jBNUWGHO/aIYmXwfNl3YY2z9h4EsZGAmNVkQFBopS4wQi0aoJbJXd7FfhqoZnLCcMefF05rt ZwSO4SRJ59kZ3KN/R3F3prJ9Ckkj/vULlbf5E8oHggrGGeInQ940UoLd9YR29Iu2Z7ja++0k YuaT/f3YTdJ5hYtWo4qw/LbwP9QlKyaVAMw5jTSstgW1LN2vyB94KM3fcldHVOhKmVnNrLSq 9L48V2M1jixEyHBqz+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRYRQR8/ttmHozx+4 MVUlp6XRy4oApH3xeVGYytoUAZlfpQTrdcrIVDn2SCS50fHb2CqyO9nE08xJ4Fe9+NqR2BCs /UFQNwPRk7bwbjqmvThGq822phLwMrDZevzvllu1zjfDt4tW5ncTaLQ6ZlV2Sp2h8wIFOu2i 88xNWY3PEWcOUEUUrsRILQYjsP2un70TwRFsFWX4qA0+k3W1AMkhdABN/KOIofaH58E9qqCn UrC/mLkElQaK9mYzxKb/X+2wOzChyX2XMQVDrLQ3vprhkCD7nYUBRYVEEag5/+0liaWWd5SL 1Id4CcGtrUp+QqgSdyVYvGjiCDc+0RAAZ8KQ6hgtF3L0bbd/weSQHQcQT8HY9sj8sYrLdA36 rOXt8PwJj5IvpSUdU6mq7bPnQGCeg8OblZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJ9dfYn WniQM8W2eh7sCIb60mo1RWc2GLz/8Shohodv1iOBDr9sGuVcab/P+SVBU7nAeFoBbvxorOph 2kIncWPhAzlJcvVzHTlrAklOry2r82CLSHcyWFmG5Q6nwlBFlb9JcUKvGs7fhcsaJpYPyT1a VPSskVN/JBSenCtaOl+fupd6vjGL4C8SbwJtdiONbKih6SdkyfdoklTiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymH9imzyKGcqkl0T8uVZ7WJJzYelcWLdpRr5khJ5oXC2Po r6zyuPQlE4GC7WuCsUp2dNDcwlSRZTEOXwGg5cPLb7ZeFsO9JAJF+feibInZ4F/malJ/tokD VnjMnK0PGHX3CWdQThmn1g/MNsDq74j9CxnVcHtVH70s0UejXGHs/pPLMdnLOF5nAGhpNYtJ 8Q4lwy7KqwnYlz6F/41NPERdaRuK0amgxygJS2gbGRtdpJsXVWZqNT+dxTh8zMCSCeyqI0/r /upy1qDE5YEQg1jCufQae6ulg3u5yFEw70iD0aYcMNOfEjM8ZRxL3KjhPEAI/YKdUfJyAyFh lSfDhovrOXQp5M4rYvSjqeeoob3T+ZzRxIIH2TS4busGzPd+26vnd1JXOqSJGCPX3n956ulf +kTwvThdvwL2l9X6tIuH7FuxKM4xt3uu74DkFs+RSyQMAT7B+o5cHec3MRJuqlc/ZNjuFO7C hCV591XGbSVI8e7QlQfEwoSaLjR3/8jhWiA5Ps4F0z2+Str8efVSk5VJRSN1nBQIbYpYoMox eAt5Jwf5wCl0EF4ONealWZf7W2TIHsaX+Mqs4xcAYOtgxdykgNOZpnVCynX5pCTaowSbRNze 2TL1PrP1+ZG207PU3svDnyTj+BTspQ5vkwYxlE1OAXbk9XIsfY7wRlN/GllVQ9S1BhGjb5+N zQ5LUFzPqnSrT5kiNIYBTLyQ0QbWEfcoBy0kQdV0nbFRlWpXSrRNGI8f+2K+QYQ7jsELDRc+ biZzkfjUCrrJZ+uhHJrAhE1+/GzH8Zs8gDimdy8G5jXFZcNZ2u3i6CjUmMEth/7DJ5jn0bAv +Rrorp9ZKCT2fT8eEHn51R2DYgtdS0= IronPort-HdrOrdr: A9a23:814RcaG+FgMWrTULpLqEMseALOsnbusQ8zAXPiBKIyC9vPb4qy nIpoVj6feX4Ax9ZJhEo7y90ca7MBDhHPJOjrX5eI3SODUO21HYSr2Kk7GSoQEIcheWnoVgPO VbAs9D4bbLbWSS4/yV3OE2fuxQuOVviJrY4Ns2100dMT2CdZsQkjuR1TzraXGflWF9dOAEKK Y= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 26 Jan 2023 14:33:08 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30Q42O5a1960730 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 26 Jan 2023 15:02:59 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30Q42O5a1960730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674705780; bh=qvNHfDoiv+ywiowF+uC67ZtVUGDsZYxajcY210GkE+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FZjLUo7B75n8Hfs6PbIngfUVdxRwfotCe/5I8gM1HVlP0ZIsxwpGutA6GFaxWcb4Y etmfpIxyKfW6A6ZrXc1WUNBn7ihuMDimT6XPijjik7hSo+BqRLm+s+o7IwKLya6qFV A97LfEuxLtZ0WDrODvvvazCLwLHTZ86sWiYuMNu93hWDJtQ8EYFNed816Vj/aQM9X7 8oKKP4tkq79pML9YfUFeY3Q+9pphVpRPRWgM7XQc2YDdAWDvvQ+6ntfKY322JlIRfC 2cfwspM7HbEDL7L8M3FJLzpNVQda+lJDlrzEB/mTlOiofoz0FuRlMPxmq7AITpwLIq VgxjAtsnARMPw== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v1 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Date: Thu, 26 Jan 2023 15:02:23 +1100 Message-Id: <20230126040223.986189-8-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230126040223.986189-1-frank@crawford.emu.id.au> References: <20230126040223.986189-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Thu, 26 Jan 2023 15:03:00 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Updated the driver documentation to list all current chips and describe the module parameters as per descriptions in the code. Signed-off-by: Frank Crawford --- Documentation/hwmon/it87.rst | 47 ++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git a/Documentation/hwmon/it87.rst b/Documentation/hwmon/it87.rst index 2d83f23bee93..5cef4f265000 100644 --- a/Documentation/hwmon/it87.rst +++ b/Documentation/hwmon/it87.rst @@ -145,6 +145,22 @@ Supported chips: Datasheet: Not publicly available + * IT8792E/IT8795E + + Prefix: 'it8792' + + Addresses scanned: from Super I/O config space (8 I/O ports) + + Datasheet: Not publicly available + + * IT87952E + + Prefix: 'it87952' + + Addresses scanned: from Super I/O config space (8 I/O ports) + + Datasheet: Not publicly available + * SiS950 [clone of IT8705F] Prefix: 'it87' @@ -162,7 +178,7 @@ Authors: Module Parameters ----------------- -* update_vbat: int +* update_vbat bool 0 if vbat should report power on value, 1 if vbat should be updated after each read. Default is 0. On some boards the battery voltage is provided by either the battery or the onboard power supply. Only the first reading @@ -171,11 +187,31 @@ Module Parameters the chip so can be read at any time. Excessive reading may decrease battery life but no information is given in the datasheet. -* fix_pwm_polarity int +* fix_pwm_polarity bool Force PWM polarity to active high (DANGEROUS). Some chips are misconfigured by BIOS - PWM values would be inverted. This option tries to fix this. Please contact your BIOS manufacturer and ask him for fix. +* force_id short, short + + Force multiple chip ID to specified value, separated by ','. + For example "force_id=0x8689,0x8633". A value of 0 is ignored + for that chip. + Note: A single force_id value (e.g. "force_id=0x8689") is used for + all chips, to only set the first chip use "force_id=0x8689,0". + Should only be used for testing. + +* ignore_resource_conflict bool + + Similar to acpi_enforce_resources=lax, but only affects this driver. + ACPI resource conflicts are ignored if this parameter is provided and + set to 1. + Provided since there are reports that system-wide acpi_enfore_resources=lax + can result in boot failures on some systems. + Note: This is inherently risky since it means that both ACPI and this driver + may access the chip at the same time. This can result in race conditions and, + worst case, result in unexpected system reboots. + Hardware Interfaces ------------------- @@ -193,8 +229,8 @@ Description This driver implements support for the IT8603E, IT8620E, IT8623E, IT8628E, IT8705F, IT8712F, IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8732F, -IT8758E, IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E, IT8790E, and -SiS950 chips. +IT8758E, IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E, IT8790E, +IT8792E/IT8795E, IT87952E and SiS950 chips. These chips are 'Super I/O chips', supporting floppy disks, infrared ports, joysticks and other miscellaneous stuff. For hardware monitoring, they @@ -238,7 +274,8 @@ of the fan is not supported (value 0 of pwmX_enable). The IT8620E and IT8628E are custom designs, hardware monitoring part is similar to IT8728F. It only supports 16-bit fan mode. Both chips support up to 6 fans. -The IT8790E supports up to 3 fans. 16-bit fan mode is always enabled. +The IT8790E, IT8792E/IT8795E and IT87952E support up to 3 fans. 16-bit fan +mode is always enabled. The IT8732F supports a closed-loop mode for fan control, but this is not currently implemented by the driver.