From patchwork Fri Jan 27 04:41:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46107C54EAA for ; Fri, 27 Jan 2023 04:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229446AbjA0Elp (ORCPT ); Thu, 26 Jan 2023 23:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjA0Elm (ORCPT ); Thu, 26 Jan 2023 23:41:42 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AEAD539CD1 for ; Thu, 26 Jan 2023 20:41:40 -0800 (PST) IronPort-SDR: UO0ChA7U11i2w6ZegW9bcS1ERnUTwXXil1EGnemWBYVyrjBUHlIoDR17ZITR7zXLncIEhrxn0j heytIq8qBGMn5oTGFmpn1OI7FKJpbAeSfpx8dGR+Y/Lj9CYWWhe9+mhiICaibDKmkfKHYx1EEO WolaWMIu6Hvz07Cv4jdmZvddHryrMgA0auyywKAPsSb6oNADpWVdtyHugTqEG4DHahxVXDVvkD oRd4dhAvKb7ipsVdd0uRJA7XUaNyv3/esCVG/1XmZbisJylTmI7WNc2hJB+YHSSss3/sTFgvlH AMlmcsTMa9Xpzop6xN4MZMNU X-SMTP-MATCH: 0 X-IPAS-Result: A2D7AQCKVdNj//Qc8jxaHQEBAQEJARIBBQUBSYE1BQELAYIsgmCVbZ8+DwEPAQFEBAEBhQcChSMmNwYOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBIEqBwtSBwtYBweBQQuBYRMLAzENhlYCAQMnCwENAQE3AQ8ZOFcGARKCfoMjq2kzgQGCCAEBBoJimmeBXgmBQAGLYIEUgzd6Qz+BToJRgT5uiwOOIo08CoE5eIElDkx6gQ8CCQIRdFkDCQMHBUlAAwsYDRYyChMsNQsLSisaGweBBiooFQMEBAMCBhMDIgINKDEUBCkTDScmaQkCAyJiAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeMQhygQ6BcU6ScQqwXYN8gVKefUyBRKdml00gg2aeHoEYhCsCCgcWgXiBf00fGYMiTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dDBaCCpFLYTsCBwsBAQMJjCMBAQ IronPort-PHdr: A9a23:10geBR+ofg7GFv9uWBXoyV9kXcBvk7/1IhVT4YAulLxJaKjl8pH/e k3To/xw3xfAR46O7fVChqLNtrz4H3YN5JGdvTUDaMlCWxNf25oflgByDJLaWR+ifqzhZXViT s9JDAANwg== IronPort-Data: A9a23:K0+28q4dutz7/Zqi2poBkAxRtBzBchMFZxGqfqrLsTDasY5as4F+v jAYDTyDMv2DamXwL9x0bo6zpkkEuZSHx4BiTVc/qipkFSgRpJOaWIjEf0ytZXqed5OaHBxqv p9GY4PKJZ5oFnX1q0b2ONANj1ElhfnSHOaU5M0om8xVbVU5IMv0oUs7w4bVuqYx3Z7hRVnlV era+6UzAnf8s9JJGjt8B5yr+EsHUMva4Fv0jnRmDRyclAK2e9E9VfrzFInpR5fKatA88t2SG 44v+IqEElbxpH/BPD8EfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1hUp/0120c95NJ NplmKSLdQsLB7L1n+lDXjBXCwU5EIBaweqSSZS/mZT7I0zueXrw2LNlFkgpM4oC9qB6BHwI9 PBeIS1lghKr2brwmu7hDLM8wJ5/cKEHP6tG0p1k5T/DBPAlaZvZSrrE4sVUmjo1m4ZPEbDXe qL1bBIzMEyRPkAQYAt/5JQWnduMviLVYydjp1/LhPcR423z9Qg26e24WDbSUofSHpUPxBfwS nj912D4BAwKcdyAzD2D2myji/WJni7hXo8WUrqi+ZZChFyV23w7EhobXlj+vOL/jEOiM/pdJ 0EQ5CM0oIAp6VemCNL6WnWFTGWs4EZZAYYKVrdqrVvRluzP/w+FB2NCUiZOaZots8pwTCFCO kK1c83BKARUjLG3cG2k8brKoBq9IQxSAEIeXHpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ0cJ RjX/EDSYJ1N0KY2O7WHEUPvxmn39seQEmbZ8i2OAzv/tlsnDGKwT9bwgWU3+8qsO66wczFtV lA/isSY4fFm4XqlznTVGI3h8JmP6unNCzrBnV4nIJAl+i/FxpJOVd4IpWsifgIzYoNeJWOve 1PapQJaooNLM3rsZqhyJYusYyjL8UQCPYi5Phw3RoAVCnSUSONg1HswDXN8J0i3zCARfVgXY P92sa+EVB7285hPwjusXPs62rQ23C04zm67bcmlkEj4jOXOPybOEett3L6yggYRsfPsTOL9r Ys3Cid2408OOAEDSnOIqtdIdQBiwYYTWMGt8Zc/mhG/zvpOQzl6W6WLkNvNiqR5h6sdl+HU8 2u7V1Mw9bYMrSOvFOhLA1g9AI7SsWFX9CpmZ3NzZwv2ghDOo++Htc8iSnf+RpF/nMQL8BK+Z 6JtlxyoDqsdRzLZ1S4aaJWh/oVueA7y1VCFJSO6bj8lc9htQhGP+9Oidxa2rHsCCS++tM0fp by811qFHsBZH14+XZvbOKC10le8nXkBg+YsDUHGFdlkfhm++oZdNH2jh/A6FMgANBHfy2bIz A2RGxoZ+7XArtZtotnEjKyJtamzFO56EhYIFmXX9+/mZyLA93WtxpVMFuuNYHbcWCX95fz6N +lSyvj9NtwBnUpL6tQjSewzl/5vuta2/u1U1AVpGnnPfm+HMLI4LynUx9RLu41M2qRd51m8V HWPzd8Ga7+HD9y0QlceKT0sYvmHyfxJyCLZ6u44IRum6SJ6oOiHXEFVM0XegSBRNuEuYokk3 fxns9Qf9AK4kBZsP9ObyCFYsW2RdyRSX6Iiv5AcIYnqlgtylA4YO8SGVn6r7cHdcchIP2krP iSQ2vjIiYNc8UyeIXA9Imecj+NSiKMHtA1O0FJfdU+CncDIh6Fr0RANoy47SB9ZkkdO3+5pY TI5aRUwf/nUum04wZIfAya3BwhdBRbf5lT+yh0Ck2ifRlTxDj7BK2g0OOCs+kEF8jsCIWIBp OvEmTvoAWTwYcX8/iouQko5+fbtetogpATNlfeuE9mBA5RnMyHuhbWjZDRUphbqaS/raJYre QW3ED5MVJDG IronPort-HdrOrdr: A9a23:SGwLZahkchRv+YMZu8NQld7JcnBQXgAji2hC6mlwRA09TyX5ra qTdTogtCMc7wxhIU3J+7i7VZVoJEmxyXcb2/hzAV7PZmbbUS6TXeVfBOjZslvd8lPFh4xgPM 5bGsAUNDSzNykcsS+Q2mmF+rgbruVuf82T9J/jJg9WPGRXgrlbnntE4xigYzBLrdZ9dOEE/E v13Ls8mwad X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:35 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIge2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:31 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIge2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794492; bh=uoZah0rQxLm7wOzrN2eniIO7ElG39WnTDXpl8eAJTDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KYDUJsqFEsnpvoE4pqPDqJ0LBgo1GRSiB/Dzdyyc3GAykLfzGfg6d0/12u78LONXc 7nJmp173tCpK2uAuPXgQe5QXIesTNQ1vYqgmVCfMK2KatEeTSN4/57r9zlR8SgTRyE zYrY/HSXCnbrk8SGIYCSh41+Sznrx27UZEUHSREB2vk2+tM5fuDwjceSe7vJzffST5 7Us9MTL6hMGdPeaH9JCmWLhoKrof7u1Zvz5kNOesPz2BRg07mRNf9IkfAK2M+I//Kh 7ls7CavFqDPkzZNwzSY0OfU4duD6AI8qXGPGuW47C4MuMlfLp5fKpBFawaE7jITm/o UzJgVt5AH6czA== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Date: Fri, 27 Jan 2023 15:41:10 +1100 Message-Id: <20230127044116.1257799-2-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:32 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Disabling configuration mode on some chips can result in system hang-ups and access failures to the Super-IO chip at the second SIO address. Never exit configuration mode on these chips to avoid the problem. This patch should be applied in conjunction with a previous one to initialise the second chip for certain mother boards. Signed-off-by: Frank Crawford --- v2: * Convert to use feature flag and related macros rather than a separate field, as suggested in review. * Reverse sense of flag in superio_exit to simplify feature macro. --- drivers/hwmon/it87.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index a8a6a0ffee82..9d44d1d6f3e9 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -128,10 +128,12 @@ static inline int superio_enter(int ioreg) return 0; } -static inline void superio_exit(int ioreg) +static inline void superio_exit(int ioreg, bool noexit) { - outb(0x02, ioreg); - outb(0x02, ioreg + 1); + if (!noexit) { + outb(0x02, ioreg); + outb(0x02, ioreg + 1); + } release_region(ioreg, 2); } @@ -300,6 +302,13 @@ struct it87_devices { #define FEAT_PWM_FREQ2 BIT(16) /* Separate pwm freq 2 */ #define FEAT_SIX_TEMP BIT(17) /* Up to 6 temp sensors */ #define FEAT_VIN3_5V BIT(18) /* VIN3 connected to +5V */ +/* + * Disabling configuration mode on some chips can result in system + * hang-ups and access failures to the Super-IO chip at the + * second SIO address. Never exit configuration mode on these + * chips to avoid the problem. + */ +#define FEAT_CONF_NOEXIT BIT(28) /* Chip should not exit conf mode */ static const struct it87_devices it87_devices[] = { [it87] = { @@ -493,6 +502,7 @@ static const struct it87_devices it87_devices[] = { #define has_pwm_freq2(data) ((data)->features & FEAT_PWM_FREQ2) #define has_six_temp(data) ((data)->features & FEAT_SIX_TEMP) #define has_vin3_5v(data) ((data)->features & FEAT_VIN3_5V) +#define has_conf_noexit(data) ((data)->features & FEAT_CONF_NOEXIT) struct it87_sio_data { int sioaddr; @@ -2489,6 +2499,8 @@ static int __init it87_find(int sioaddr, unsigned short *address, goto exit; } + config = &it87_devices[sio_data->type]; + superio_select(sioaddr, PME); if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) { pr_info("Device not activated, skipping\n"); @@ -2508,8 +2520,6 @@ static int __init it87_find(int sioaddr, unsigned short *address, it87_devices[sio_data->type].suffix, *address, sio_data->revision); - config = &it87_devices[sio_data->type]; - /* in7 (VSB or VCCH5V) is always internal on some chips */ if (has_in7_internal(config)) sio_data->internal |= BIT(1); @@ -2827,7 +2837,7 @@ static int __init it87_find(int sioaddr, unsigned short *address, sio_data->skip_pwm |= dmi_data->skip_pwm; exit: - superio_exit(sioaddr); + superio_exit(sioaddr, has_conf_noexit(config)); return err; } @@ -3213,7 +3223,7 @@ static void it87_resume_sio(struct platform_device *pdev) reg2c); } - superio_exit(data->sioaddr); + superio_exit(data->sioaddr, has_conf_noexit(data)); } static int it87_resume(struct device *dev) From patchwork Fri Jan 27 04:41:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F0EC61DA7 for ; Fri, 27 Jan 2023 04:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjA0Elq (ORCPT ); Thu, 26 Jan 2023 23:41:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjA0Eln (ORCPT ); Thu, 26 Jan 2023 23:41:43 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 246643A5BF for ; Thu, 26 Jan 2023 20:41:41 -0800 (PST) IronPort-SDR: u21Y9zmB1QtVuigVNZynP8tMQaF0vl7SpfvtNHrx2swsOAKXXJAOnlJwNbciYe4IOatch2DMh7 23qt05qNMGz6I0LBiawB87ztS1vCHZuUGUKfIh6I2Ph8dKbJH+Q4mpZWjD1CKu8q9g6i5yu+ly cMajRYGydIpXxWqjCI5Lqnh7HHdKe8RCaSZ/ccYHPfezSDMWnveZTnECgPfR0CwOksxmMNsByd Eg5+9sGT73i5FZBoQ+fJ4HMXVpRaNZPhXPASoZCrM25ctGPiiysdUILpmVN/n3qKDIYjMZbxeT umQD3YTXHRatcglm4Vm59L5j X-SMTP-MATCH: 0 X-IPAS-Result: A2D2AACKVdNj//Qc8jxaHQEBAQEJARIBBQUBSYE0BgELAYIsgmCzLYF+DwEPAQFEBAEBhQcChSMmNgcOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBIEqBwtSBwtYBweBQQuBYRMLAzENhlYCAQMyAQ0BATcBDxk4VwYBEoJ+gyOsHIEBgggBAQaCYppngV4JgUABi2CBFIM3ekM/gU6ED26LA5teCoE5eIElDkx6gQ8CCQIRdFkDCQMHBUlAAwsYDRYyChMsNQsLShAbGhsHgQYqKBUDBAQDAgYTAyICDSgxFAQpEw0nJmkJAgMiYgMDBCgtCT8HJiQ8B1Y3BgIPHzcGAwkDAh9PcS8SEgUDCxUqRwQINgUGHDYSAggPEg8sRA5CNzQTBlwBKQsOEQNQRxluBIIRBikmnytZNU7FSYN8gVKefUyBRKdml00goxyEKwIKBxaBaQeCB00fGYMiTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dgiyRS2E7AgcLAQEDCYwjAQE IronPort-PHdr: A9a23:4yEIKRT81z5coemDSoh8cIyqVdpso4vLVj580XJvo7hPbr/l9I7rI 0LY//krgVrUG4TXrftZ2KLfqau1X2sG7N6atWwaNoZBUhgZhIAXh1kuDMLfWxLyJfK4Y3BlT JYbBg1u9SjjY0NeQJmWWg== IronPort-Data: A9a23:w7D5G6hg7XOKqR9n4YRa9tzEX161RBYKZh0ujC45NGQN5FlHY01je htvXDqOOauDMGr1KN9+ad+xoEkC6JTUmNFmS1dl+yo1EH8T9pKYCdrGdxmuM3LMcJ2ZQBM/s ZgQZIiadJhtFyXX/T6gY+PrxZVe/fjYHuCmVIYoGczQqStMEnpJZcdLwrZh6mJQqYHlRVvL4 7semuWHULOf82cc3l88sspvljs/5JwehxtA1rAOTagjUIj2yhH5pLpGTU2AByOQrrt8R4ZWd M6fpF2NxV41yj92Yj+TfhcXRWVRKlLaFVDmZnO7wMFOiDAazsA5+v5T2Pbx9S67hh3R9+2dx umhurTtd1cQLJ2Pnt8nUhpqHwJuMKlP+ZDIdC3XXcy7lyUqclPmwul1SkosNJIW/fx7R2xL6 LoZJHYEc3hvhcromPThFrMq3JRldpW3VG8ckigIITXxA+wvR5PrSL/D+tFfxjt2i8VTW/fSI cMEAdZqREicO0wSZwhMUPrSms/vvEHaQmdojG7Mnoto4TmK3SB+6YDEZY+9ltuiHp0OzhzC9 woq5V/RBhAcKczaySWA9XSEmODCh2X4VZgUGbn+8eRl6HWXx2oOGDUMUlaworykkQi4Vs43A 04Y9y4wpLI/3Fe2VdS7VBq9yENopTZCA58KT7d/slHIkPaIpR2FD3QFRXhdcNMn8sQxQHojy zdlgu8FGxQyju2sW0Le8IyurDCANQsFIGsLZAALGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/ 9xshHVu71n0pZBWv5hX7WwrkBrp/cOZEVdpjunDdjv4t1khPNDNi5mAswCz0BpWEGqOZnC81 JTus/OP4OYDHPlhfwTXGL1VdF1Fz9CIL3XnhkNzH9Ee/jCg4BaekW14vmk7fhszd5xUPGW1P AnIpQpN5ZQVIGOlbOl8ZIf3AtlCIUnc+TbNCqy8gjlmOMMZmOq7EMZGPxD44owVuBJw+ZzTw L/CGStsZF5DYUid8BK4Rv0GzZggzT0kyGXYSPjTlkr4jeXDOy7OEexdbDNii9zVCovZ8G05F P4BaqO3J+l3CryWjtT/q9FIdAtSfRDX+7ir+pcNLYZv3TaK6El6U6SBm+lwE2CUt7hNma/J+ G2wQElV1DLCaY7vd223h7EKQO2HYKuTWlpiZXF2YgnyhiZ6CWtthY9GH6YKkXAc3LQL5ZZJo zMtIq1s29xDFWbK/Sozd574oNAwfRinn1vebSG/aScxeIRsAQHM55nlck3m6XBWXCawsMI/p Zym1x/aGMRcHV46VpqHOf//nUmsuXU9mf5pWxWaKNdkeHLqrNpgJRvu360+LMw7IBnewieXi lSNChACqOiT/4I4qYGbha2No4qzPfF5G05WQzvS4bqsbHmI9XCq3oFHSurOcDXAEmL4vqy/P L0Hw/b5OfwBvVBLr4slTekxl/pku4q+quYDnAp+HXjNY1C6MZ9aIyGLjZtVq6lA5r5Fog/oC EiBzdltP+nbMs3SDw9DLQUoWe2PyPUIl2SA9v8yOkj7unN68bfbA0VfOx6A1H5UILdvath3y +Y9o4gd8QWghB0wPpCLiz0S9mjKJ2FZC/crsZQTAYnKjAs3ywgcPsaGUnWqscCCO4dWL00nA j6In66c1b5S8Ur1dSZhH3b6wrsPjJsDjxlG0VseKgnbgdHCnPI2gkFc/GhlVAhT1Rkbget/N nIwbR8rfeDUo20t3pgGBTzwXRpdDQGY8Qrt01QI0mbeSg+hSzWVfmE6PO+M+mEf8n5dJ2YEp uvAkjq0ADu6Ltvs2iYSWFJ+r6CxR9JG8FyQkc+qKM2JAp0mbGe3maSpf2cJ9UfqDM5ZaJcrf gW2EDucsZHGCBM= IronPort-HdrOrdr: A9a23:/Hk3eaiPUlhB7KDXeQ15bB/e73BQXgAji2hC6mlwRA09TyX5ra qTdTogtCMc7wxhIU3J+7i7VZVoJEmxyXcb2/hzAV7PZmbbUS6TXeVfBOjZslvd8lPFh4xgPM 5bGsAUNDSzNykcsS+Q2mmF+rgbruVuf82T9J/jJg9WPGRXgrlbnntE4xigYzBLrdZ9dOEE/E v13Ls8mwad X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:39 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgf2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:35 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgf2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794495; bh=oORJC5y+9mo7ZhPt1yhalMdHuNwGqVTPdIg1LuUAw6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mcMSxIkx9Bc3EJ6mbqYm1kPhSjVIyhez8/4aECb1wAUSZJ6yT+cDRAG8gXS/gago+ gczB6CkK2Mf4VnaqCReWu9sdqpyssEcZG6Q5ofvDy4hsutNlBq6/2PRBsIozPze20o wWxtpRQ8CyeiiK/G6Q58U3B5Ktt6S8zfphSsQV5bdkv/LLfqPSmJhp2LG5JGpsPB52 ugX1lrQIlBOg+dfc4AJKbt3QVvYvUwCWJrnq2gaGig4a1sVH/FblKx5eOgj7IU4U+L HNuSF2LY7NDL2q4PI5hwTe1hUHLEpv9Jti7wUQy5uYlJcU6rJfML9vxb6wH8QfNR3Z V6gPePlIqlKuQ== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 2/7] hwmon: (it87) Disable configuration exit for certain chips Date: Fri, 27 Jan 2023 15:41:11 +1100 Message-Id: <20230127044116.1257799-3-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:35 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org IT8790E and IT8792E/IT8795E have been identified as chips that can have issues when disabling configuration mode. Set to never exit configuration mode. Signed-off-by: Frank Crawford --- v2: * Make use of new feature flag rather than separate field. --- drivers/hwmon/it87.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 9d44d1d6f3e9..16130d469180 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -429,7 +429,7 @@ static const struct it87_devices it87_devices[] = { .suffix = "E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL - | FEAT_PWM_FREQ2, + | FEAT_PWM_FREQ2 | FEAT_CONF_NOEXIT, .peci_mask = 0x07, }, [it8792] = { @@ -437,7 +437,7 @@ static const struct it87_devices it87_devices[] = { .suffix = "E", .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI - | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL, + | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL | FEAT_CONF_NOEXIT, .peci_mask = 0x07, .old_peci_mask = 0x02, /* Actually reports PCH */ }, From patchwork Fri Jan 27 04:41:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E585C61DA3 for ; Fri, 27 Jan 2023 04:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbjA0Elq (ORCPT ); Thu, 26 Jan 2023 23:41:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjA0Elp (ORCPT ); Thu, 26 Jan 2023 23:41:45 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 92CFB39B9E for ; Thu, 26 Jan 2023 20:41:43 -0800 (PST) IronPort-SDR: 1T1HxQ9DybaB1wSFN1ZwzgXuNhgzEs3Tdlh+Vi+/o1wtVnUmB2X190EtsI9O6p2x5Bm1VSvA4u CfZpus+xEenQ3pZv/hhRZbl06xAsGxoAYsng8vsZydBNxjQj/FU4d5aj9gB9ghbq+KXVfGCIsT hA+RgTfOxAvJ9RgIoT8P8ssOqumn3iZ+dT/jPKV9rI1GX+G+2rSLlYaAMnWtYcu4gexC7hNSsv 9U2QVyLngic4yzwKC4MiBYkpmqDEchLr0spXhWsnw1cd7HhPbEFJQowcmhGDbPysD4k715u0wK NxYEtwJdEngj+bXGtGAxPg86 X-SMTP-MATCH: 0 X-IPAS-Result: A2BcAQCKVdNj//Qc8jxaHAEBAQEBAQcBARIBAQQEAQFJgTUEAQELAYIsgmC1Kw8BDwEBRAQBAYUHAoUjJjcGDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgSBKgcLUgcLWAcHgUELgWETCwMxDYZWAgEDJwsBDQEBNwEPGThXBgESgn6DI6tpM4EBgggBAQaCYppngV4JgUABi2CBFIM3ekM/gU6EfYsDm14KgTl4gSUOTHqBDwIJAhF0WQMJAwcFSUADCxgNFjIKEyw1CwtKEBsaGweBBiooFQMEBAMCBhMDIgINKDEUBCkTDScmaQkCAyJiAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeOXEBgQ6VXo5XoWKDfIFSnn1MgUSnZpdNIKMchCsCCgcWgXiBf00fGTuCZ08BAgEBAQ0BAgEBAwECAQEBCQEBAQGOHYIskUthOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:pRdZyx0t2N23hF5lsmDPn1BlVkEcU/3cNA8J8dwskbtRfKO589LvO VGZ5PkrhUKaFYzB4KdCjOzb+7vlRXRG+5uEt2wPNZ1UAhEJhZ9EwAUpDJyJVRKrfqe4PScwR ZwQX1Q9oBmG IronPort-Data: A9a23:MbZEF6xdJvnWFV5k/Nd6t+cTwCrEfRIJ4+MujC+fZmUNrF6WrkVVz GccCG/TaP+IYGKmKohyO43k80gC7ZTdnINiTgRp/y80QitBo5LOD9+VcB2uMSiZd52YEkhtt p0UM4OffJ84Z3KN/R3F3prJ9Ckkj/vULlbf5E8oHggrGGeInQ940UoLd9YR29Iu2Z7ja++0k YuaT/f3YTdJ5hYtWo4qw/LbwP9QlKyaVAMw5jTSstgW1LN2vyB94KM3fcldHVOhKmVnNrLSq 9L48V2M1jixEyHBqz+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRYRQR8/ttmHozx+4 PcUsZ2pThkGBIzjo+UtSSQBDxhzLJQTrdcrIVDn2SCS50fHb2CqyO9nE08xJ4Fe9+NqR2BCs /UFQNwPRk7bwbjqmvThGq822phLwMrDZevzvllu1zjfDt4tW5ncTaLQ6ZlV2Sp2h8wIFOu2i 88xNWY3PUmdPEYRUrsRIIhugvX5gFymSCJBiHS5hrAp6nDIwTUkhdABN/KOIofaH58E9qqCn UrC/mLkElQaK9mYzxKb/X+2wOzChyX2XMQVDrLQ3vprhkCD7nYUBRYVEEag5/+0liaWWd5SL 1Id4CcGtrUp+QqgSdyVYvGjiCDc+0RAAZ8KQ6hgtF3L0bbd/weSQHQcQT8HY9sj8sYrLdA36 rOXt/GwAT12t6O6c1Oyzbaktw7rJREYPFZXMEfoUjA5y9XkpYgyiDfGQdBiDLO5g7XJ9dfYn mDiQM8W2eh7sCIb60mo1RWc2GLz/8Shohodv1iOBDr9sGuVcab/P+SVBU7nAeFoBbvxorOph 2kIncWPhAzlJcvVzHTlrAklOry2r82CLSHcyWFmG5Q6nwlBFlb9JcUKvGs7fhcsaJpYPyT1a VPSskVN/JBSenCtaOl+fupd6vjGL4C8SbwJtdiONbKih6SdkyfdoklTiba4hTyFraTVufhX1 FfyWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8+nkEn4geHGPybJIVvgDLdoRr1phE9jiFuIm +uzy+PQmn2zrcWkPXKOqtZDRbz0BSVqXsqtwyCoSgJzClE+QzF7Ua65LUIJZ5Rq16VTiurS+ HyhMnK0O3Kh7UAq6GyiNBheVV8Ydc8n8ChkYnZxYw/ANrpKSd/H0ZrzvqAfJdEPnNGPB9YtJ xXcU8nfUPlJVBrd/DERMcv0oIB4LUT5jhiHICSiejR5cpt9AQ3FvNb5J1O9+C4LByuxlM0/v 7z5iFyBG8JZGlw4AZaEcu+rwnOwoWMZxrB4UXzIFd8PKk/ix5c7eSX+g8g+L9wINRielCCR0 BybAElEqOSU+901/dDFiLqqtYCsF+ciTENWE3OCveS9LyDF8G25zclNVfvOfDybXX6toPeuY uBczvfdNvwbnQ8U7NAmS+w2lfgzvoK9qaVbwwJoGGTwQ26qUr4wcGOb2cRvt7FWwuELswWBW nWJpotQN4KWaZHsH1MmLQY4aviOiKMPkT7I4PVrfEj36XMl/LeDVkkObRCAhDYHd+l/MZ8+h +w7sdEY7BazzBcvL5CHgmZd6j3UfHAHVqwmsLAcAZPq01R0kAsaO8GEUCKmsouSb9hsM1UxJ mHGjqT1h4NamhjIfU0sRCrE0udqjJgTvAxHkQ0ZLFOTl9ub2vI6gE9L/TIsQlgHxxlLybkpa DYzchcpf+DUr3Iy2JQFRHylBwBKQgGB9U23wFwM0mTEFhH6WmvIJWw7GOCM4EFArT0GJGABo enCxTa3SyvuceHwwjA2BRxvpcvlHI54+QD1kcy6G9iIQsshaj3/j67wOWcFpnML2y/qaJEre AWywNtNVA== IronPort-HdrOrdr: A9a23:M1Pi/ajaAySdwdZDNe0RVFdT5HBQXgAji2hC6mlwRA09TyX5ra qTdTogtCMc7wxhIU3J+7i7VZVoJEmxyXcb2/hzAV7PZmbbUS6TXeVfBOjZslvd8lPFh4xgPM 5bGsAUNDSzNykcsS+Q2mmF+rgbruVuf82T9J/jJg9WPGRXgrlbnntE4xigYzBLrdZ9dOEE/E v13Ls8mwad X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:42 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgg2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:38 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgg2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794498; bh=ypDoyNVtANPP5ZfydD/arJDMgjyuguW9TJZlRqiwgmo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CUt08NZa+6ZVrt5hGEucKrTjZxL4X6sh26Kyvnqb2GV4hliervSUZTXziTag4ttRq R0b8VOVb9vzKUv8gzDJPQ5huHZFiuZk96vajvIMD9mCJRWpyWIRroYmuypWyTvIsoK LzcEFZjqlQ9TPgWZTGUnASP9Or6MeCZFZIVnK4Jx0a5YnUiWjPrMI9/lMzr3zH9aM/ 7aOn3KUZtj1rVXIOiMaDKcY9g1aJ4yQ7beCWy/2Vh3jecZK++ndsRiyILIL58yYpYb S2INcTwgcAsspo9DwhOZGLfoKpSz+AnKgtCQ4azN8w1fKEpMC7eYzXas4nANyTqx8j 8OFV5klgCIGhQ== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 3/7] hwmon: (it87) List full chip model name Date: Fri, 27 Jan 2023 15:41:12 +1100 Message-Id: <20230127044116.1257799-4-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:38 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org ITE model names do not always match the chip ID. Convert from just adding a suffix to specifying the full model name. Signed-off-by: Frank Crawford --- v2: * No change. --- drivers/hwmon/it87.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 16130d469180..9295391e4c55 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -277,7 +277,7 @@ static const u8 IT87_REG_AUTO_BASE[] = { 0x60, 0x68, 0x70, 0x78, 0xa0, 0xa8 }; struct it87_devices { const char *name; - const char * const suffix; + const char * const model; u32 features; u8 peci_mask; u8 old_peci_mask; @@ -313,24 +313,24 @@ struct it87_devices { static const struct it87_devices it87_devices[] = { [it87] = { .name = "it87", - .suffix = "F", + .model = "IT87F", .features = FEAT_OLD_AUTOPWM, /* may need to overwrite */ }, [it8712] = { .name = "it8712", - .suffix = "F", + .model = "IT8712F", .features = FEAT_OLD_AUTOPWM | FEAT_VID, /* may need to overwrite */ }, [it8716] = { .name = "it8716", - .suffix = "F", + .model = "IT8716F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, }, [it8718] = { .name = "it8718", - .suffix = "F", + .model = "IT8718F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, @@ -338,7 +338,7 @@ static const struct it87_devices it87_devices[] = { }, [it8720] = { .name = "it8720", - .suffix = "F", + .model = "IT8720F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_VID | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_PWM_FREQ2, @@ -346,7 +346,7 @@ static const struct it87_devices it87_devices[] = { }, [it8721] = { .name = "it8721", - .suffix = "F", + .model = "IT8721F", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_FAN16_CONFIG | FEAT_FIVE_FANS | FEAT_IN7_INTERNAL @@ -356,7 +356,7 @@ static const struct it87_devices it87_devices[] = { }, [it8728] = { .name = "it8728", - .suffix = "F", + .model = "IT8728F", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -364,7 +364,7 @@ static const struct it87_devices it87_devices[] = { }, [it8732] = { .name = "it8732", - .suffix = "F", + .model = "IT8732F", .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL, @@ -373,7 +373,7 @@ static const struct it87_devices it87_devices[] = { }, [it8771] = { .name = "it8771", - .suffix = "E", + .model = "IT8771E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -385,7 +385,7 @@ static const struct it87_devices it87_devices[] = { }, [it8772] = { .name = "it8772", - .suffix = "E", + .model = "IT8772E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -397,28 +397,28 @@ static const struct it87_devices it87_devices[] = { }, [it8781] = { .name = "it8781", - .suffix = "F", + .model = "IT8781F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8782] = { .name = "it8782", - .suffix = "F", + .model = "IT8782F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8783] = { .name = "it8783", - .suffix = "E/F", + .model = "IT8783E/F", .features = FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_FAN16_CONFIG | FEAT_PWM_FREQ2, .old_peci_mask = 0x4, }, [it8786] = { .name = "it8786", - .suffix = "E", + .model = "IT8786E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2, @@ -426,7 +426,7 @@ static const struct it87_devices it87_devices[] = { }, [it8790] = { .name = "it8790", - .suffix = "E", + .model = "IT8790E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2 | FEAT_CONF_NOEXIT, @@ -434,7 +434,7 @@ static const struct it87_devices it87_devices[] = { }, [it8792] = { .name = "it8792", - .suffix = "E", + .model = "IT8792E/IT8795E", .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL | FEAT_CONF_NOEXIT, @@ -443,7 +443,7 @@ static const struct it87_devices it87_devices[] = { }, [it8603] = { .name = "it8603", - .suffix = "E", + .model = "IT8603E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL | FEAT_AVCC3 | FEAT_PWM_FREQ2, @@ -451,7 +451,7 @@ static const struct it87_devices it87_devices[] = { }, [it8620] = { .name = "it8620", - .suffix = "E", + .model = "IT8620E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2 @@ -460,7 +460,7 @@ static const struct it87_devices it87_devices[] = { }, [it8622] = { .name = "it8622", - .suffix = "E", + .model = "IT8622E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_FIVE_FANS | FEAT_FIVE_PWM | FEAT_IN7_INTERNAL | FEAT_PWM_FREQ2 @@ -469,7 +469,7 @@ static const struct it87_devices it87_devices[] = { }, [it8628] = { .name = "it8628", - .suffix = "E", + .model = "IT8628E", .features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_SIX_FANS | FEAT_IN7_INTERNAL | FEAT_SIX_PWM | FEAT_PWM_FREQ2 @@ -2516,8 +2516,8 @@ static int __init it87_find(int sioaddr, unsigned short *address, err = 0; sio_data->sioaddr = sioaddr; sio_data->revision = superio_inb(sioaddr, DEVREV) & 0x0f; - pr_info("Found IT%04x%s chip at 0x%x, revision %d\n", chip_type, - it87_devices[sio_data->type].suffix, + pr_info("Found %s chip at 0x%x, revision %d\n", + it87_devices[sio_data->type].model, *address, sio_data->revision); /* in7 (VSB or VCCH5V) is always internal on some chips */ From patchwork Fri Jan 27 04:41:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076CFC54EAA for ; Fri, 27 Jan 2023 04:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbjA0Elt (ORCPT ); Thu, 26 Jan 2023 23:41:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjA0Els (ORCPT ); Thu, 26 Jan 2023 23:41:48 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 76A034FAE0 for ; Thu, 26 Jan 2023 20:41:47 -0800 (PST) IronPort-SDR: fQD5KurEoNn8pqXkbKe8GiN4T0WwIRuefuSTvDfCy+vogfsVeY1d97pWtuvZAvBsLghArrDRG2 9A+422hK2XUrfi9lNYPcPx7L9NPqQ3EWxdZElT4PKaR35Ka5JqjZ8fm8iqAI/V69te+ucVjHe0 GEX+i1AnZh7wcLXNhmSDEOQJVTT+4jkTz1vu1ma9uKtYUWOp8iZkNlamsTLGKzsZWgmKyDtqAU C5jjVRe88bHZWxbLsrgzB9R+L+NIWTJX0StgNmm3vq+YtIWCdnK/qhzhXWnmw5XMAG8zN0fzk+ igGVI6L6u/3cE1/Sj/jP8bHs X-SMTP-MATCH: 0 X-IPAS-Result: A2B2AACKVdNj//Qc8jxaHAEBAQEBAQcBARIBAQQEAQFJgTMGAQELAYIsgmCzLYF+DwEPAQFEBAEBhQcChSMmNQgOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBIEqBwtSBwtYBweBQQuBYRMLAzENhlYCAQMnCwENAQE3AQ8ZOFcGARKCfoMjq2kzgQGCCAEBBoJimmeBXgmBQAGLYIEUgzd6Qz+BToR9iwObXgqBOXiBJQ5MeoEPAgkCEXRZAwkDBwVJQAMLGA0WMgoTLDULC0oQGxobB4EGKigVAwQEAwIGEwMiAg0oMRQEKRMNJyZpCQIDImIDAwQoLQk/ByYkPAdWNwYCDx83BgMJAwIfT3EvEhIFAwsVKkcECDYFBhw2EgIIDxIPLEQOQjc0EwZcASkLDhEDUEcZbgSCEQYpJp4xCHKBDoEngRjDWIN8gVKefUyBRKdmLZcgIKMchCsCCgcWgWQBghJNHxmDIk8BAgEBAQ0BAgEBAwECAQEBCQEBAQGOHYIskUthOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:oI+OqhE35+lu+7mCaCKPGZ1GfhYY04WdBeZdwpAml6kIeb6q4JrlJ kCZ6PBwyl7FG4zGuLpNkeGDtafmVCQb5IqZ9moPdZtQWloEkZAYkwB6UpGMAEGpIKK1P35jT pZJXgY9rXqwaRc9JQ== IronPort-Data: A9a23:yA1+x69cewy+dLlseBZ5DrUDpHiTJUtcMsCJ2f8bNWPcYEJGY0x3x zAYD2/QPfrZZ2ryLt9zaYW/9h8EvcDRnIBiQQtqrygwRCMTp5DMDImQcBmrZ33NfpafHEhqs csUY9WZfJw4FFbR90ynWlTDhSAsjfvSGtIQKwJl1gRZH1IMpPIJ0Eo78wIBqtc0x4D/WWthg PuqyyHlEAbNNwNcawr41YrT8HuDg9yq0N8olgRWiSdj4TcyP1FMZH4uDfnZw0nQG+G4LcbmL wr394xVy0uCl/sb5nJJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwZG8P4whlkeydx /0Xv82PGAwDJZTBlbswURB9M2JRN79vreqvzXiX6aR/zmXMcmf3hf50BV44OpcUvOtyHCdP+ boRNVjhbDjd36TsnOj9ELkq3Jh/RCXoFNp3VnVIwyvQC/UOSorKXKvN/9Me0TItwMFCW//DD yYcQWYzNEWdPkIUaj/7DrphnsKDhHX0NAEIgwOWgJFwxzHRzlxYhe2F3N39IYTRFZ8Pzy50v Fnu+2X/HwFfNMOazjyt7H2hnKnMkDn9VYZUE6e3ntZugVuO1kQJDxAdVh6mur+/h1LWc9BTJ kgK8zAjhbMv70HtRd74NyBUu1ba5ltGB4AVSb1/sl3RjLHI6hqYDS4YVjFALtchsYk/WFTGy 2NlgfuzD21Q4ba/UkuQ++i5rzqXGWs6J30rMHpsoRQ+3/Hvp4Q6jxTqR9llEbKogtCdJd0W6 23axMTZr+tO5fPnx5lX7niC2Gn8+cGVJuIhzlyKBzj9tl0RiJuNPdTA1LTN0RpXBK+kJrVrl EMVl86T/Yji5rnXzHTVKAnhNJek+L6+NyDAgRZQFp0s7FyQF5OLI9gVum0kYR05d5xYJXnyf EbPuAgX+IdcPT2haqoxap/Z5yUWIUrISYiNuhP8NIEmjn1NmOivpn8GWKJo9zqx+HXAaIlmU XpbGO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6kk0v6jurFPCXNFd/p1WdiiMhkvMtoRy2Lr r5i2zeikUQ3vBDWOHaMqNVLfTjm01BmVMus8KS7idJv0iI9QDpxUaWAqV/QU5B9kOxUkPvF5 HewRidlJKnX2xX6xMTjQi4LVY4Dqr4m9S9hYnN2YAjxs5XhCK72hJoim1IMVeFP3IReITRcF pHpou2MXaZCTCrp4TMYYcWvpYBubk371wmUNjWrZyIzOZNlWkrI9pntY1K3piUJCyO2s+o4o qGhj12EG8BbHVk6UsuGOuiyy16RvGQGnLwgVUX/Iu5VJBfm/r91en74gfIAKs0RLQnOm2mB3 AGMDBZG+eTA+tdn8NTAia2egZ2uFu9yQhhTE2XBtObkPjPT4WSk24MGXeOVOzHREmrpof3wa eJQxvD6EfsGgFcT7dUmSe4xkPpg6oK29bFAzwliEHHaVHiRC+ttciucwM1ClqxR3bsH6wG4b UK4/IUIM7u+J5K3GVEcEwMpc+Cf2KxGgTLV9/k0fhn36SIrrrqKVUJeY0uFhCBHduAnOoI52 qEqoscJ5QulhlwnN8vAjywS/nnVdi4MVKAut5c7Bo73i1N1lQsYOcaBUnH7sMOVdtFBEkg2O TvK1qDMsLRrwBaQeXQECimf1OVQsp0CpRRWwQJQPF+OgNfE2KM60UED6zgxVQgJnBxL3/goY Do1bwgvef/LpWct3pQfGXuwEh1AD1uF4kPwjVAOkSvQUhDwBGDKKWQ8P8eL/VwYqjwDJGIDp uzAlmu1Ayz3eMzR3zcpXRI3ofLUS40j/wLPr8mrAsCZEsRoejHimKKvOzYFphaP7RndX6EbS TSGJNpNVJA= IronPort-HdrOrdr: A9a23:J3k5vKMB7pZR7MBcThujsMiBIKoaSvp037BK7SpMoNJuE/Bw8P re5cjyt3fP5Qr5PUtNpTnuAtjifZqxz/FICMwqTNOftWrdyQ2Vxf9ZnOnfKlTbckWUygce79 YGT0EUMr3N5DZB4/oTb2SDYq4dKaG8gcWVbP/lvgtQpB9RGtxdBthCe32m+pwffng9OaYE X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:46 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgh2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:42 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgh2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794502; bh=tHTaC3/BOiYHzi0C4LYaHzvtV14rs05GmxHMecgape8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eyhUIfhMtjcYl1vDhEAX/T1i0gGgJksMaiyN8fi5W7EqwBqrEm5ejMBLABDOQo21N q2nk68RLP9upQHf7Ydlcv4W0P7n34XdOZp/6xaSF5mpkRTYbdIZa5+z2o3OlKGV1Tp awupadvmi01BJTdCoGZhuChs9/NUIHbLFAyqcefF5FOfinuVnSQlSrQdrHE+iTDRqg Z7bkqtkey7uCwzIX/tNZMWx3Hfsem0EJM2lo9RPTQ6xYgR0P+BF9ARgGVfT9vifOOa +5RLGFu+FPE0lWGSaAReF576suCQ9edgHfb0thtYEQ25/MIDwTx5QCQtfIbeckrQQc zKhozeaMYUk8g== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 4/7] hwmon: (it87) Add chip_id in some info message Date: Fri, 27 Jan 2023 15:41:13 +1100 Message-Id: <20230127044116.1257799-5-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:42 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org In cases where there are multiple chips, print out which chip is referred to, in the informational message. Signed-off-by: Frank Crawford --- v2: * Improved chip description following review. --- drivers/hwmon/it87.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 9295391e4c55..61a1a2c643ed 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -2503,13 +2503,15 @@ static int __init it87_find(int sioaddr, unsigned short *address, superio_select(sioaddr, PME); if (!(superio_inb(sioaddr, IT87_ACT_REG) & 0x01)) { - pr_info("Device not activated, skipping\n"); + pr_info("Device (chip %s ioreg 0x%x) not activated, skipping\n", + config->model, sioaddr); goto exit; } *address = superio_inw(sioaddr, IT87_BASE_REG) & ~(IT87_EXTENT - 1); if (*address == 0) { - pr_info("Base address not set, skipping\n"); + pr_info("Base address not set (chip %s ioreg 0x%x), skipping\n", + config->model, sioaddr); goto exit; } From patchwork Fri Jan 27 04:41:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF53C38142 for ; Fri, 27 Jan 2023 04:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbjA0Elw (ORCPT ); Thu, 26 Jan 2023 23:41:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjA0Elv (ORCPT ); Thu, 26 Jan 2023 23:41:51 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 74CEC3B0C9 for ; Thu, 26 Jan 2023 20:41:50 -0800 (PST) IronPort-SDR: +M9xOtF+rJYlSG6yMX5ImpTcrUo3mQsSI45ZBCd1fmZb/zCjf4P2zF4e/HElE2JdM6Yvzx/5/n mBAfYBAbrj0GfgscyH/K+HQF0BXqesdA/g9g0rTJ3BL7++wAbstfudzL16jYA+k4KHhC9A0EJN vg0DokG4nV6kefGPXItUEGgZQAgyJoti1mBcZHrD1XhlqXtIczkUl5aeGFMocDpsHvddUWIb3u vf65fiEHOVF2M1KVkcdWMWMDoqtXdF3jAM3dSVtKLT8ojrfpFwctbhVDZy1Z1ycZR3KAqsukVY x3s1z5Q9Tn0IRn4xuHtlE3KY X-SMTP-MATCH: 0 X-IPAS-Result: A2ApCACKVdNj//Qc8jxaHQEBAQEJARIBBQUBSYFGgi2CYJVtnz4PAQ8BAUQEAQGFBwKFIyY4EwECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBBgSBKgcLUgcLWAcHgUELgWETCwMxDYZWAgEDMgENAQE3AQ8ZOFcGARKCfoMjrByBAYIIAQEGgmKaZ4FeCYFAi2GBFIM3ekM/gU6BFYE8giyLA44ijTwKgTl4gSUOTHqBDwIJAhF0WQMJAwcFSUADCxgNFjIKEyw1CwtKEBsaGweBBiooFQMEBAMCBhMDIgINKDEUBCkTDScmaQkCAyJiAwMEKC0JPwcmJDwHVjcGAg8fNwYDCQMCH09xLxISBQMLFSpHBAg2BQYcNhICCA8SDyxEDkI3NBMGXAEpCw4RA1BHGW4EghEGKSaeOWsGAS0mOzB3xHCDfIFSnn1MgUSmXIEKLZcgIKMchCsCCgcWgXmBfk0fGYMiTwECAQEBDQECAQEDAQIBAQEJAQEBAY4dDBaCCpFLYTsCBwsBAQMJjCMBAQ IronPort-PHdr: A9a23:PSChzB0KG9ttIqCvsmDPn1BlVkEcU/3cNA8J8dwskbtRfKO589LvO VGZ5PkrhUKaFYzB4KdCjOzb+7vlRXRG+5uEt2wPNZ1UAhEJhZ9EwAUpDJyJVRKrfqe4PScwR ZwQX1Q9oBmG IronPort-Data: A9a23:H1dSharXzkLQjLwvtoS4tzXYTXFeBmI8YxIvgKrLsJaIsI4StFCzt garIBnUP66MNGKkeI0kbIi+9RwO6sSGm4NqGVdkrC8xFXtE8cSVC92Xcx/+bn2ZJ5GeQk5ut pkUMdXNIJBoEySBqhzwG7Ww9nMUOYOgH+qkUrSYUsxSqa6IbA971HqPTsZg2tYAbeCRWl/L4 ZWoyyHmEAfNNwRcawr41orawP9RlKSq0N8nlgRWicBj5DcyQFFIZH63DfjZw0rQGuG4LMbjL wrw5O3RElfiwvsYIojNfoAX06E9auW60QCm0hK6UkU56/RIjnRaPq0TbJLwZarL4tmEt4gZ9 TlDiXC/YSg5brf2tbUdaD4bSCxyLad6x5vAIEHq5KR/z2WeG5ft6/9vEFpwNpcR5ehwG20I+ PkFbjEBKBme7w606OzjDLMw3IJ5fI+xYN93VnJIlFk1Cd4oW5nFQI3B/9ZH0jAqioZDGOuYZ sZfYCcHgBHoP0EXawpKV85l9AuuriT0NGNbtHK7nqsq+WPX4FYyibe2C/OAL7RmQu0Oxh3I/ DiXl4jjOTkeNdqC2X+F7XergMfRki7hHoEfDru18rhtmlL77mgSDgAGfUG8rPK6z1OlHdRSN yQ8+CYjqbY77kGDVcTmUluzp3vsg/IHc4QIVrdmskTXmu+Ov1rfHXQNUj9KLsA+u85wTjsvk FaU9z/0OdBxmJKFGWin2+aUlhTxYiUZPWU+WgsDTDJQtrEPv7oPph7IS99iFou8gdv0BSz8z li2QM4W2uV7YSkjifjTwLzXv96/jt2SFV5qv1m/snaNt14gPtb9OeRE/HCBtZ59wJClok6pl UVsdyK21/ECC5yc/MBmaL9VROnBCxqtFjDDyWVoAoUhvwuk/3O4Fb28DRkgfAIzbpxBI2+sO hOP/xhN7YNSNz22daB2JYm2DoIj0MAM9OgJtNiIMrKigbArL2drGR2CgmbKgQjQfLAEy/1XB HtiWZ/E4LZzIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+XCOyPKGexdawPSBgzc0E9iiFiFm zq4H5XXoyizrMWkM0E7DKZJcgtTdiBrbXwIg5EGLbTYSuaZJI3RI6SJmuN7Id0Nc1V9iv/Ht nC7RkJCzlfj7UAr2i3UAk2OqdrHA/5CkJ7MFXV0YAz3hCJ+P9/HAWV2X8JfQITLPddLlZZcJ 8Tpse3ZahiWYjiYqTkbc7fnq4luKEaiiQ6UZnr3ayI2YJBnXQCP99r5OArjsiATV3Llucw7q rym9wXaXZtaGVs4Vp6MNar+wgPjp2UZlcJzQ1DMfItZdnLsx442eSb/ueBmccgDJCLKyiaey wvLUwwTovPAotFp/dSQ3fKEoo6lHvFQBE1fG2WHv7+6OTODrjio24ZfXuGScXbQUX6y+ankb PgMl6PwN/gOnVBrtYtgEu81kvhkv4Gy/+5Xl102Em/KYlKnDqJbDkOHhcQf5LdQwrJ5uBetX hzd8NdtOYKPZJHvHmkOdVgsYem03P0JniXfsKYuK0Lg6S4poLeKXBkAPxSIjyABfrJ5PJl/m rUrudINrQelgwUkNcyKyC1R6iKNIjoJTvx/5J0dBYbqjCsty01DOMKDUHWuuszXOtgcYFM3J jK0hbbZg+oOzET1c001SSrH091C1MYHtx19xVMfI0iEx4jejfgt0RwPrTk6ElZPwhNc374hM 2RnLRYvd/vWum003o0ZDyX2R10HHwGQ5k36jUcRm2yfRE6tEGXQdTVvNeGI9UEf0mRdYjkCo u7Ckj6/DG67cZGjxDY2VG5kt+fnEY57+DrEyZKuEMmyFpUnZSbo3/21bm0Sphq5Xc48iSUrf wWxEDqctEEjCRMtng== IronPort-HdrOrdr: A9a23:ErHXAqqExL7Hs0iZbtMz/+gaV5rxeYIsimQD101hICG9Evbzqy lhppUmPHjP+U8ssBNJo7290cy7LU80mqQFgrX5UY3MYOCighrNEGgA1/qF/9SfIVydygc178 4JGJSWSueAamSS5vyb3ODXKbgdKFbrytHRuQ6n9QYJcehzUdAd0+5mMHfnLqSofng8OXLpfK DsnPZ6mw== X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:49 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgi2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:45 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgi2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794506; bh=hcotMYrz3/juQ80iYm5gcIUjBnolTH1T+VhLUa/Dlug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oGMTIQpo61cuchpClulwU9W/g59Aa3wG+r9I8I61yOQ/UIw/wqC4CJCp98M3A61A2 0FtiAA2wozWZPQXwrDVg5TCFPUY2smncFIL55i/gzgGZWpVu5V2b1Mnqo4Zg8hx7Sn XSbV3t1+/OFzC1TqEAT/5J7aZmgrgMdesoJCtu7XF3j0COEAxMNYx8OYu3DlWn3BkL 1HbjT+W+P5zHzpaylm/eefAy5+oYYRKti4G3z9NZhiKUUjRhbf7aA3QVeU1ESwy2lt pimrvxInZLIVcU9dEDMtiHFqBfHUFDhTJQLQNen00MNhbwF2ULEM7MNzP5qgIMF/r1 pc/lG5E46RwKg== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Date: Fri, 27 Jan 2023 15:41:14 +1100 Message-Id: <20230127044116.1257799-6-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:46 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Extend the force_id module parameter to allow specifying one or both chip IDs separately. If only a single parameter is given it defaults to using that value for all chips, similar to previous usage. Signed-off-by: Frank Crawford --- v2: * No change. --- drivers/hwmon/it87.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 61a1a2c643ed..f41da0896097 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -175,8 +175,9 @@ static inline void superio_exit(int ioreg, bool noexit) #define IT87_SIO_VID_REG 0xfc /* VID value */ #define IT87_SIO_BEEP_PIN_REG 0xf6 /* Beep pin mapping */ -/* Force chip ID to specified value. Should only be used for testing */ -static unsigned short force_id; +/* Force chip IDs to specified values. Should only be used for testing */ +static unsigned short force_id[2]; +static unsigned int force_id_cnt; /* ACPI resource conflicts are ignored if this parameter is set to 1 */ static bool ignore_resource_conflict; @@ -2410,7 +2411,7 @@ static const struct attribute_group it87_group_auto_pwm = { /* SuperIO detection - will change isa_address if a chip is found */ static int __init it87_find(int sioaddr, unsigned short *address, - struct it87_sio_data *sio_data) + struct it87_sio_data *sio_data, int chip_cnt) { int err; u16 chip_type; @@ -2426,8 +2427,12 @@ static int __init it87_find(int sioaddr, unsigned short *address, if (chip_type == 0xffff) goto exit; - if (force_id) - chip_type = force_id; + if (force_id_cnt == 1) { + /* If only one value given use for all chips */ + if (force_id[0]) + chip_type = force_id[0]; + } else if (force_id[chip_cnt]) + chip_type = force_id[chip_cnt]; switch (chip_type) { case IT8705F_DEVID: @@ -3419,7 +3424,7 @@ static int __init sm_it87_init(void) for (i = 0; i < ARRAY_SIZE(sioaddr); i++) { memset(&sio_data, 0, sizeof(struct it87_sio_data)); isa_address[i] = 0; - err = it87_find(sioaddr[i], &isa_address[i], &sio_data); + err = it87_find(sioaddr[i], &isa_address[i], &sio_data, i); if (err || isa_address[i] == 0) continue; /* @@ -3468,8 +3473,8 @@ static void __exit sm_it87_exit(void) MODULE_AUTHOR("Chris Gauthron, Jean Delvare "); MODULE_DESCRIPTION("IT8705F/IT871xF/IT872xF hardware monitoring driver"); -module_param(force_id, ushort, 0); -MODULE_PARM_DESC(force_id, "Override the detected device ID"); +module_param_array(force_id, ushort, &force_id_cnt, 0); +MODULE_PARM_DESC(force_id, "Override one or more detected device ID(s)"); module_param(ignore_resource_conflict, bool, 0); MODULE_PARM_DESC(ignore_resource_conflict, "Ignore ACPI resource conflict"); From patchwork Fri Jan 27 04:41:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C22C54EAA for ; Fri, 27 Jan 2023 04:41:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbjA0El4 (ORCPT ); Thu, 26 Jan 2023 23:41:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjA0Elz (ORCPT ); Thu, 26 Jan 2023 23:41:55 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED46F4FAE0 for ; Thu, 26 Jan 2023 20:41:53 -0800 (PST) IronPort-SDR: N3hOJY8ovt40HMyze7RZHzp12bDiVi6YAj/Q7hrwKZJryUm6eZcVzBFNMtH3i3ChCsh2j80ZY9 MztmEVpZtRtxI+GJroJ9Vb+8DoLZnIdXcsImj8i8k0UtTTq76SOnH9TsNbJXAhFNFfYGC7sYcn dggKajxMDlEE3qU3IqRb671D9uGzpJtX5nC4j5rb8NM19gk2H8g8hv94bSv/clGmap8iWXdTZz G2TEVDAXlnmARpctYMIgi2bdwxnjvsPGAdeuPDIggT+cONu/8/2NxZjzGkcEO310lJ747ngDOP MxY6Mjqn7Y/gWssjGO1XupQW X-SMTP-MATCH: 0 X-IPAS-Result: A2D7AQCKVdNj//Qc8jxaHQEBAQEJARIBBQUBSYE1BQELAYIsgmCzQYFqDwEPAQFEBAEBhQcChSMmNwYOAQIEAQEBAQMCAwEBAQEBAQMBAQYBAQEBAQEGBIEqBwtSBwtYBweBQQuBYRMLAwQIJQ2GVgIBAycLAQ0BATcBDxk4VwYBEoJ+gyOraTOBAYIIAQEGgmKaZ4FeCYFAAYtggRSDN3pDP4FOglGCLIEFgwIEhniOIo08CoE5eIElDkx6gQ8CCQIRdFkDCQMHBUlAAwsYDRYyChMsNQsLShAbGhsHgQYqKBUDBAQDAgYTAyICDSgxFAQpEw0nJmkJAgMiYgMDBCgtCT8HJiQ8B1Y3BgIPHzcGAwkDAh9PcS8SEgUDCxUqRwQINgUGHDYSAggPEg8sRA5CNzQTBlwBKQsOEQNQRxluBIIRBikmnjlrB4EOpDWhYoN8gVKefUyBRKdml00goxyEKwIKBxaBeIF/TR8ZgyJPAQIBAQENAQIBAQMBAgEBAQkBAQEBgTOMagwLC4IKkUthOwIHCwEBAwmJSoJZAQE IronPort-PHdr: A9a23:G11Y4BfU+ZHUpUiFXofRbTu9lGM/hYqcDmcuAtIPgbNSaeKo5Z39M kvF6bNgiUKPXImd4u8Xw+PMuPXmXmoNqY2ErGhEapFJUAMIzMQOygIsDJTXVkTyIKzmM3NqT p0QBlRvpinpOkMNR67D IronPort-Data: A9a23:FVZ3HKnZ3CYMLjCEg3NbBtbo5gylIERdPkR7XQ2eYbSJt1+Wr1Gzt xIdWm6PPf2INGCjctByYYy3pBsHsZaGyIU3T1c4/CA9RXlG8paUVI3DckmrbijPdsbNQBprs 5sUMYfMcZ5kFnKCjxr8abKJQVtUjPHQHOCgYALn1oGdYSc+FU/NXDo6w7ZRbrZA2IT/W0XX0 T/Li5W31GWNglaYD0pNg069gEM31BjNkGtwUmwWPZina3eD/5W9JMt3yZCZdxMUcKENdgKJb 7qrIIWCw4/s10xF5uVJM1rMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKtao23hojx/9 DlCncPtVTorb4CPo9sYcSlzNSR4F/N6yJaSdBBTseTLp6HHW3Ht3+4oB1s/IoMf4OoxDGRTs /0UbjkQBvyBr7zuhujnEK821oJ5cJWD0IA34xmMyRnXF/8gQrjIWazV69hC0HE9g90IHPqYb tdxhT9HMEiYMkASZQtJYH44tL/riFDGSx5Kk3KEmI49xXXU1ikp/Le4ZbI5ffTRHZ4FxBzJz o7cxEz9AxcHJJmf1j+C9FqyieLV2yD2QoQfEPu/7PECqFmSwHEDIAcRWFC45OSizEizR7p3K UAZ/jQnt6Ua71GwQ5/2WBjQnZKflkBEHoAMSahguETXlvaS+BqQGmkPCCJZZ91gv8gzAzU3v rOUoz/3LWMyrICXGF/ezYiRjwOZHy0TBzE+VQZRGGPp/OLfiI00ixvOSPNqH6i0ksD5FFnML 9ai8XhWa1I705Nj6kmrwbzUq3f3/ciWF1JdChH/Bz/8tFshOuZJcqTysTDmAeB8wJGxZ2TpU JIsoNmS6u0fZX1mvHbVGL1l8F2BwfuaeAbbnEJvV6Yo8zm2k0NPkKgOuHQkeB0saJZBI2O1J lTPsB9Q79lPJHSrK6RwZsS4FqzGLJQM9/y5Cpg4jfIUOfCdkTNrGwk0OyatM5jFyhRErE3GE c7znAbFJS9y5V5b5DS3XfwB9rQg2zozw2jeLbiikUv7jufBNCXNEu9ZWLdrUgzfxP7UyOky2 4gCX/ZmNz0FAYUSnwGNrtVKdghaRZTFLc2n8JYMHgJ8HuaWMDp5UK+Lm+JJl31Ng7xa3ubO4 nynXEJEoGcTdlWZQThnqxlLNtvSYHqIhStjYHZzYgz1hSFLjETGxP53SqbbtIIPrIRLpcOYh dFfEylZKvgQGDnB5RoHapzx8N5reBix3FLcNDCsfzY4ZZImSgnUvN7oOALyrXFcAi2yvMo4g ruhygKCH8VZHVw4UZ+NZaL91U61sFgchPl2ARnCLO5TT0OwooJkHDOg3PY4LvYFJQjH2jbHh R2dBg0VpLeRroJsqIvJiKmIop2HCex7GkYGTWDX4azvZXvR5GO8z4haXKCFeC2bVW+y8bj7P bdZyPT1MfsmmldWstMiTOwxlfhjvoDi/uYIwB5lEXPHa0WQJolhenTWj9NSsqBtx6NCvVXkU Ey4+u5cZeeDNvT6QQwYKwcSZ+ie0e0Zx2vJ5vMvLUSkuCJ68ebVUUhWOBXQ2iVRIKEva9Evw Ps6/sUM4hOxjQAmdNuDk2ZV+yKFMyVYAakgs5gbBq7tixYqkw8dO8aEUHKvu5zfOc9RNkQKI yOPgPSQjbprxn3ELyg5G0/SjLhUipk5sRxXyEMPegaSkd3fi/5pgBBcrWYtQgJOwkkV2u5/I DMxZRMtYP/SpXIy1I0ZAzzqAB1IGBySvFDpxFpPn2rcCUC1DzSfIGo4MOeL3UYY72MFIGcBp unClT++XGa4Ztz10wszRVVh967pQ+t3p1/Ll82QFsiYG4U3PGj+iai0aGtW9xbqDKvdXqEcS TWGIQqoVZDGCA== IronPort-HdrOrdr: A9a23:7YOq/anF2fXxzlbJ1WKuJ6jpFr3pDfL23DAbv31ZSRFFG/Fw9/ rFoB3U737JYVEqKQgdcbLpAsS9qBbnmaKdjrNhXotKMDOIhILsFvAH0WKA+UyHJ8SBzJ8+6U 4IScEXY+EYT2IK6voSizPZLz9P+re6GC/Ev5an854Ud3AOV0h51XYENu+EKDwKeOCYP+tDKH JMjvA33QadRQ== X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:53 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgj2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:49 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgj2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794509; bh=biKFHKUv+mXskoknmYPVejp/Q75GPmy61AfbzxwGfRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TvjNVdTZG/JMbeZrZPr4M1ORFC9SY/HMKqpgr7enynSeEVQbViaOBKr/1+xye30lq Q2aU4tbTco6puQmLK+rdZMw8jaCp3FNq1F6NpFTsHwtHEcwJBvSBcrld7CqtXQMsuc SqA1tR2ZXa7QEem7hkTNljfMUFbs3HeaH9cTfvKrE74w09XeiRthV7WkqM7f2cl7IV XVRA0Pr3CiHK60MZPu6mSKufy2xwCzaoamwNFDW/Q0rVHi8jOp+uQ5VwHAe1lFcIaC 7L0rWlW7pkPmGtBHADckGO85verjAh2Aq4HHBIUQWkYezvb/pA+z0nKNRKdJ9XarS0 +6tY8kdvdKgow== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 6/7] hwmon: (it87) Add new chipset IT87952E Date: Fri, 27 Jan 2023 15:41:15 +1100 Message-Id: <20230127044116.1257799-7-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:49 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Add IT87952E, a new chip ID (DEV ID 0x8695), which appears to be an updated version of the IT8792E and takes the same configuration. The model name comes from the model name printed on the chip. There is no datasheet publicly available. Signed-off-by: Frank Crawford --- v2: * Make use of feature flag for definition. --- drivers/hwmon/it87.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index f41da0896097..fdba5873434a 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -34,6 +34,7 @@ * IT8786E Super I/O chip w/LPC interface * IT8790E Super I/O chip w/LPC interface * IT8792E Super I/O chip w/LPC interface + * IT87952E Super I/O chip w/LPC interface * Sis950 A clone of the IT8705F * * Copyright (C) 2001 Chris Gauthron @@ -63,7 +64,7 @@ enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8732, it8771, it8772, it8781, it8782, it8783, it8786, it8790, - it8792, it8603, it8620, it8622, it8628 }; + it8792, it8603, it8620, it8622, it8628, it87952 }; static struct platform_device *it87_pdev[2]; @@ -160,6 +161,7 @@ static inline void superio_exit(int ioreg, bool noexit) #define IT8622E_DEVID 0x8622 #define IT8623E_DEVID 0x8623 #define IT8628E_DEVID 0x8628 +#define IT87952E_DEVID 0x8695 #define IT87_ACT_REG 0x30 #define IT87_BASE_REG 0x60 @@ -477,6 +479,15 @@ static const struct it87_devices it87_devices[] = { | FEAT_SIX_TEMP | FEAT_VIN3_5V, .peci_mask = 0x07, }, + [it87952] = { + .name = "it87952", + .model = "IT87952E", + .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS + | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI + | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL | FEAT_CONF_NOEXIT, + .peci_mask = 0x07, + .old_peci_mask = 0x02, /* Actually reports PCH */ + }, }; #define has_16bit_fans(data) ((data)->features & FEAT_16BIT_FANS) @@ -2497,6 +2508,9 @@ static int __init it87_find(int sioaddr, unsigned short *address, case IT8628E_DEVID: sio_data->type = it8628; break; + case IT87952E_DEVID: + sio_data->type = it87952; + break; case 0xffff: /* No device at all */ goto exit; default: From patchwork Fri Jan 27 04:41:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Crawford X-Patchwork-Id: 13118158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D602C54EAA for ; Fri, 27 Jan 2023 04:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjA0EmD (ORCPT ); Thu, 26 Jan 2023 23:42:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjA0EmC (ORCPT ); Thu, 26 Jan 2023 23:42:02 -0500 Received: from ipmail06.adl3.internode.on.net (ipmail06.adl3.internode.on.net [150.101.137.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4DE9539CD1 for ; Thu, 26 Jan 2023 20:42:00 -0800 (PST) IronPort-SDR: 6xfREQDbBCLHIyk3Dt2FTpx2c7n9hWPx8JGh2JWFM0gLDNorfppoZ8hqAQgZ3FynEpc3pgIQxk H6QxZD0l0A+JOLEAtEkPnbZ7h4dP3lV/66YBhYzkvb/kTC/5zgc6mchiwJ4/3dVmQbzvGGCNnF dRJdHaIyUg5DelyWqTo3QJTyPrdgtXyp38XlIg3C/kbrnHPYeQXWCPE5rSMRMPgfvAgFqqT4Ix M5CVqWLZgcEj3z3q0ybAOrRMHX53c4uKba+/Ox4qnBoYc7oqfxFdfStmhozuvOfDFTUCMYIkzK y3kcqA5XAqzyBkDqBCEmfpBR X-SMTP-MATCH: 0 X-IPAS-Result: A2A2CACKVdNj//Qc8jxaHgEBCxIMSYE7C4ItgmCVbZ1AgX4PAQ8BAUQEAQGFBwKFIyY2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEgSoHC1IHC1gHB4FBC4FhEwsDBAglDYZWAgEDMgENAQE3AQ8ZOFcGARIZgmWDI6wcgQGCCAEBBoJimmeBXgmBQIthgRSDN3pDP4FOgRWBPIE+boQBJRGGKiKOIo08CoE5eIElDkx6gQ8CCQIRdFkDCQMHBUlAAwsYDRYyChMsNQsLSisaGweBBiooFQMEBAMCBhMDIgINDRsxFAQpEw0nJiZDCQIDImIDAwQoLQk/ByYkPAdWNwYCDx83BgMJAwIfT3EvEhIFAwsVKkcECDYFBhw2EgIIDxIPLEQOQjc0EwZcASkIAw4RA1BHGW4EghEGKSafJAYBDhwTUYEngSkZknUcrWl+gTaDfIFSnn1MgUSCNYxfhmiRaoUWj2GCViCiBIEYhCsCCgcWgWkGgghNHxk7gmdPAQIBAQENAQIBAQMBAgEBAQkBAQEBggSMGYIskUthOwIHCwEBAwmMIwEB IronPort-PHdr: A9a23:YHMwgR3w69a7IawcsmDPn1BlVkEcU/3cNA8J8dwskbtRfKO589LvO VGZ5PkrhUKaFYzB4KdCjOzb+7vlRXRG+5uEt2wPNZ1UAhEJhZ9EwAUpDJyJVRKrfqe4PScwR ZwQX1Q9oBmG IronPort-Data: A9a23:+Zi7vKP9B+DwjIzvrR2BkcFynXyQoLVcMsEvi/4bfWQNrUon0DcHy TYeXWqHaKyPMTD9c40jaoi0pkIPupLSmtdiQQdrry1mRCsV+JGUWI/Bdh/9bynIf8OaQU49s JwSNIXKBc1lFXW0SjWFa+i59yMgvU2rqhsQLMaeZ0idkCc9EH9JZSpLwrJ/2sgy6TSAK1vlV ena+qUzBXf8s9JKGjJMg068gEsHUMTa4Fv0aXRjDRzjlAa2e0g9VPrzF4noR5fLatU88tqBe gr25OrRElU1XvsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0o2HKJ0VKtZt9mGt+th1 d4OnKW+cggkOYb2ydsCYTNhKBgraMWq+JefSZS+mcaS01aAeGHl3PtpFk1wMIgFvOd7R2hTn RAaAG5VKErf3aTskPThFrUEascLdaEHOKsRoHhmzhnSF/85T5fZT+PH4MIe3Tt2j90m8fP2O 5ZBOGcyM0mfC/FJEkgJLJQdmc73umC8diRxsgOz9aol/EGGmWSd15C2aIGFIIbbLSlPpW6cp 2Tb7yH5HRQdMvSBxjeftHGhnOnCmWX8Qo16PLm58ON6qEeUy2cQTQANE122vZGRiEKzX8xWM UE84Tc1oO4580nDczXmd0Pg5STY5FtGC58KT7F88x2E1qvfpRqBCWlCRTlELtU73CMredA0/ mSZgtiqLAVhi7KYTlmnp4iLnxmLAhFAeAfuehQ4ZQcC5tDipqQ6gRTOUstvHcaJYjvdRGGYL 9ei8nVWulkDsSIY/+DgpgCY2m7ESozhF1NsvF2PAApJ+ysjPOaYi5qUBU/zxMsowGyxdUiNu nUV8yR1xLpWVcnleMClZugSVIqu+uqFeALVhVN0d6TNGhzzozv5IdoVumE7fhs1dN0YcCPoa wnPoQxQopRUOT2jcMebgr5d6ex2kcAM9vy/DZg4i+aihbArKme6ENlGPxL44owUuBFEfGFWE c7znTyQJXgbE7976zG9Wv0Q17QmrghnmzyPGs2kn0//iuLCDJJwdVvjGAbeBgzexP3ZyDg5D /4FZqNmNj0FD7anOXGHmWLtBQ1bdiJgbXwJlyCnXrXbeVo8QjBJ5w753asuM41jg6lPkOrUl kxRqWcGoGcSRBTvd223V5yUQOq3AMwg8ihmY3VE0JTB8yFLXLtDJZw3L/MfFYTLPsQ5pRKtZ /VaKciGHNpVTTHLp2YUYZXn9dwwfw6imgyJJSbjbT0iOZ9sAQXUo4e2cgzq/SgILyy2qcpn/ eL6jFuBHMBbSlQwFtvSZdKu00i14yoXltVyaE2UcNNdT1q9ooFlJhv4guIzP8xRew7IwSGX1 ljKDBpB/bvNroY5/cPnn6eBq4v1QeJyElADTzvQ97+pOy7A8iyuxJIGUerOdC2EDDH4/6CrZ ON0yfDgMaRZwwwQ69AhSe5mlPts6cHuqrlWyhVfME/KN1n7WKl9JnSm3NVUsvMfzLFuuTywB hCF9O5FaOeAN87SGVIMIBYoM7aY3vYOlziMsfk4LRmo5CJz+7bbA0xeMwPW035XLadudog/y Pgvv9QarQG6l1wrPpCPk3kMpWiLK3UBVYQht40bWdG00FBzkAwYOZGMWDXr5JyvaslXNhd4K DGjhJ3E2+ZWyH3dIig6GnX61OZAgYgD5UJRx1gYKlXXxtfI2q0t0BtK/WhlRwhZ1E4dgbwrf zI3bQgvdeDUo2sun9RKQ2GnXR1ZCxzf8Uv0jVIUzTWLQ06tX23LDWs8JefUoh9DqToGI2ID8 eHK0nvhXBbrYNr1gnk4V3lj+q7qQtFG/wHfnNyqQpaeFJ4gbDu73qKjaALkcfc87R/dWaEfm dRXwQ== IronPort-HdrOrdr: A9a23:E4GCLaHqD5BHGDD4pLqEMseALOsnbusQ8zAXPiBKIyC9vPb4qy nIpoVj6feX4Ax9ZJhEo7y90ca7MBDhHPJOjrX5eI3SODUO21HYSr2Kk7GSoQEIcheWnoVgPO VbAs9D4bbLbWSS4/yV3OE2fuxQuOVviJrY4Ns2100dMT2CdZsQkjuR1TzraXGflWF9dOAEKK Y= X-IronPort-Anti-Spam-Filtered: true Received: from 60-242-28-244.static.tpgi.com.au (HELO bits.crawford.emu.id.au) ([60.242.28.244]) by ipmail06.adl3.internode.on.net with ESMTP; 27 Jan 2023 15:11:59 +1030 Received: from agc.crawford.emu.id.au (agc.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc07]) (authenticated bits=0) by bits.crawford.emu.id.au (8.17.1/8.17.1) with ESMTPSA id 30R4fIgk2462776 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 27 Jan 2023 15:41:52 +1100 Authentication-Results: bits.crawford.emu.id.au; arc=none smtp.remote-ip=fdd2:7aad:d478:1::cb10:cc07 DKIM-Filter: OpenDKIM Filter v2.11.0 bits.crawford.emu.id.au 30R4fIgk2462776 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crawford.emu.id.au; s=s1; t=1674794513; bh=l8K/vWpF+NJex4qLWZCsbMrBM0Jhr5y34qoPkEoO/bQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qi83ITOUM/GzUj1zk5msLc8gaovIHOSsfqABgnse7LA2ZHlqcbdAlPggsOM8lPtKF ajRTUiBPA4Cd+Jfii8oPu8CnA6JYnBcbq5IuykDpFMPuRNjk6MoJxjpSbMBD/drHQf saX8EbFcIXxgQ+zza0d62tRM1gHI0zsuFYXvddYiL6TSIoicZ/1nmHe16Me+QQe0Iq wpVJ34zTU4/gtmaJhuXPgiBswTzjqs/o6eKhPP7Kpdj6TaMXXPVrA/ze9yLCoHZvCL ekXc8B0/miJmrJo4ANdYQQjRgtcpCcq10wkojNmNSfewiTLbcjEeI7Ht/F/KPxeNgt lVMHkFztlyWbA== From: Frank Crawford To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, Frank Crawford Subject: [PATCH v2 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Date: Fri, 27 Jan 2023 15:41:16 +1100 Message-Id: <20230127044116.1257799-8-frank@crawford.emu.id.au> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230127044116.1257799-1-frank@crawford.emu.id.au> References: <20230127044116.1257799-1-frank@crawford.emu.id.au> MIME-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (bits.crawford.emu.id.au [IPv6:fdd2:7aad:d478:1:0:0:cb10:cc01]); Fri, 27 Jan 2023 15:41:53 +1100 (AEDT) X-Virus-Scanned: clamav-milter 0.103.7 at bits.crawford.emu.id.au X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Updated the driver documentation to list all current chips and describe the module parameters as per descriptions in the code. Signed-off-by: Frank Crawford --- v2: * No change. --- Documentation/hwmon/it87.rst | 47 ++++++++++++++++++++++++++++++++---- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git a/Documentation/hwmon/it87.rst b/Documentation/hwmon/it87.rst index 2d83f23bee93..5cef4f265000 100644 --- a/Documentation/hwmon/it87.rst +++ b/Documentation/hwmon/it87.rst @@ -145,6 +145,22 @@ Supported chips: Datasheet: Not publicly available + * IT8792E/IT8795E + + Prefix: 'it8792' + + Addresses scanned: from Super I/O config space (8 I/O ports) + + Datasheet: Not publicly available + + * IT87952E + + Prefix: 'it87952' + + Addresses scanned: from Super I/O config space (8 I/O ports) + + Datasheet: Not publicly available + * SiS950 [clone of IT8705F] Prefix: 'it87' @@ -162,7 +178,7 @@ Authors: Module Parameters ----------------- -* update_vbat: int +* update_vbat bool 0 if vbat should report power on value, 1 if vbat should be updated after each read. Default is 0. On some boards the battery voltage is provided by either the battery or the onboard power supply. Only the first reading @@ -171,11 +187,31 @@ Module Parameters the chip so can be read at any time. Excessive reading may decrease battery life but no information is given in the datasheet. -* fix_pwm_polarity int +* fix_pwm_polarity bool Force PWM polarity to active high (DANGEROUS). Some chips are misconfigured by BIOS - PWM values would be inverted. This option tries to fix this. Please contact your BIOS manufacturer and ask him for fix. +* force_id short, short + + Force multiple chip ID to specified value, separated by ','. + For example "force_id=0x8689,0x8633". A value of 0 is ignored + for that chip. + Note: A single force_id value (e.g. "force_id=0x8689") is used for + all chips, to only set the first chip use "force_id=0x8689,0". + Should only be used for testing. + +* ignore_resource_conflict bool + + Similar to acpi_enforce_resources=lax, but only affects this driver. + ACPI resource conflicts are ignored if this parameter is provided and + set to 1. + Provided since there are reports that system-wide acpi_enfore_resources=lax + can result in boot failures on some systems. + Note: This is inherently risky since it means that both ACPI and this driver + may access the chip at the same time. This can result in race conditions and, + worst case, result in unexpected system reboots. + Hardware Interfaces ------------------- @@ -193,8 +229,8 @@ Description This driver implements support for the IT8603E, IT8620E, IT8623E, IT8628E, IT8705F, IT8712F, IT8716F, IT8718F, IT8720F, IT8721F, IT8726F, IT8728F, IT8732F, -IT8758E, IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E, IT8790E, and -SiS950 chips. +IT8758E, IT8771E, IT8772E, IT8781F, IT8782F, IT8783E/F, IT8786E, IT8790E, +IT8792E/IT8795E, IT87952E and SiS950 chips. These chips are 'Super I/O chips', supporting floppy disks, infrared ports, joysticks and other miscellaneous stuff. For hardware monitoring, they @@ -238,7 +274,8 @@ of the fan is not supported (value 0 of pwmX_enable). The IT8620E and IT8628E are custom designs, hardware monitoring part is similar to IT8728F. It only supports 16-bit fan mode. Both chips support up to 6 fans. -The IT8790E supports up to 3 fans. 16-bit fan mode is always enabled. +The IT8790E, IT8792E/IT8795E and IT87952E support up to 3 fans. 16-bit fan +mode is always enabled. The IT8732F supports a closed-loop mode for fan control, but this is not currently implemented by the driver.